Matan Lurey
e4d88c98a4
Run DrawSolidBlueScreenTest 20x in a row in bringup (up from 5x) ( flutter/engine#51850 )
...
I'm hoping this increases the chance of a flake by ~4x, as that would help me debug https://github.com/flutter/flutter/issues/145988 .
Also removed `--verbose`, which wasn't valuable (just made the "filtered" logs harder to read).
2024-04-02 22:33:54 +00:00
Jason Simmons
e67380cbf1
Return an empty optional in HardwareBuffer::GetSystemUniqueID if the underlying NDK API is unavailable ( flutter/engine#51839 )
2024-04-02 22:33:51 +00:00
Matan Lurey
5084d0b432
Use fml::ScopedCleanupClosure instead of DeathRattle. ( flutter/engine#51834 )
...
Closes https://github.com/flutter/flutter/issues/146105 .
Originally when we authored these suites, `ScopedCleanupClosure` disallowed move-semantics, but that was fixed in https://github.com/flutter/engine/pull/45772 , so there is no reason to have a copy of these in different tests.
/cc @jonahwilliams
2024-04-02 22:33:48 +00:00
Tong Mu
bf68661eba
Remove the view ID check in macOS/FlutterCompositor ( flutter/engine#51852 )
...
This PR removes the view ID check added in https://github.com/flutter/engine/pull/51738 , which has been causing a test `FlutterEngineTest.CompositorIgnoresUnknownView`, added in https://github.com/flutter/engine/pull/51436 , to fail.
This problem was missed by the CI because the test and the view ID check were added in two PRs recently and they were not using the latest engine to check.
The view ID check is not needed anyway, and is only a temporary check until the multiview support is landed.
[C++, Objective-C, Java style guides]: https://github.com/flutter/engine/blob/main/CONTRIBUTING.md#style
2024-04-02 22:17:36 +00:00
Matan Lurey
d3cc586a58
Do not use adb shell screenrecord during CI runs. ( flutter/engine#51848 )
...
This introduced quite a bit of flakiness because the system UI sometimes (???) reappears:
2024-04-02 21:08:31 +00:00
Loïc Sharma
b363028a18
[Embedder API] Add view ( flutter/engine#51523 )
...
Adds `FlutterEngineAddView` to the embedder API. This will be used to add a view.
Design doc: https://flutter.dev/go/multi-view-embedder-apis
Part of https://github.com/flutter/flutter/issues/144806
Part of https://github.com/flutter/flutter/issues/142845
[C++, Objective-C, Java style guides]: https://github.com/flutter/engine/blob/main/CONTRIBUTING.md#style
2024-04-02 21:04:54 +00:00
Jackson Gardner
fea11e834d
[skwasm] Fix Paragraph.getLineBoundary ( flutter/engine#51846 )
...
The Skia APIs I was previously using were returning `-1` for `paragraphGetLineNumberAt` when querying at the end of the string. I changed the implementation to be identical to what CanvasKit and the native Paragraph object are doing.
2024-04-02 20:31:56 +00:00
Chinmay Garde
2a07f9e53a
Allow creating slimpeller engine variants. ( flutter/engine#51824 )
...
Fixes https://github.com/flutter/flutter/issues/144432
2024-04-02 20:21:53 +00:00
Jonah Williams
444c075779
[Impeller] fix plus blend mode in porterduff shader. ( flutter/engine#51792 )
...
DrawAtlas already has the optimization in https://github.com/flutter/engine/pull/51778 and so it is still rendering incorrectly with wide gamut.
2024-04-02 20:21:52 +00:00
auto-submit[bot]
0434a4332f
Reverts "Replace WindowInsetsController... with adb shell commands ( #51843 )" ( flutter/engine#51847 )
...
Reverts: flutter/engine#51843
Initiated by: matanlurey
Reason for reverting: broke tree because the bottom bar now shows up.
Original PR Author: matanlurey
Reviewed By: {jonahwilliams}
This change reverts the following previous change:
Previously our screenshots looked like this (when they ran correctly):
Now, sometimes (only on CI unfortunately) they look like this:
This started happening after https://github.com/flutter/engine/pull/51832 , but the change should be future-proof as well even if we disable the screen recording feature.
h/t @reidbaker
2024-04-02 19:32:48 +00:00
Matan Lurey
e124b252ae
Replace WindowInsetsController... with adb shell commands ( flutter/engine#51843 )
...
Previously our screenshots looked like this (when they ran correctly):
Now, sometimes (only on CI unfortunately) they look like this:
This started happening after
https://github.com/flutter/engine/pull/51832 , but the change should be
future-proof as well even if we disable the screen recording feature.
h/t @reidbaker
2024-04-02 10:01:59 -07:00
K Lubick
4ec8483024
Use moved GrBackendTexture factories for Skia's Metal backend ( flutter/engine#51828 )
...
In https://skia-review.googlesource.com/c/skia/+/833302 , Skia moved the
constructors for Metal versions of GrBackendTexture (and other
functions/methods). This updates uses in Flutter to use the new APIs.
## Pre-launch Checklist
- [x] I read the [Contributor Guide] and followed the process outlined
there for submitting PRs.
- [x] I read the [Tree Hygiene] wiki page, which explains my
responsibilities.
- [x] I read and followed the [Flutter Style Guide] and the [C++,
Objective-C, Java style guides].
- [ ] I listed at least one issue that this PR fixes in the description
above.
- [x] I added new tests to check the change I am making or feature I am
adding, or the PR is [test-exempt]. See [testing the engine] for
instructions on writing and running engine tests.
- [x] I updated/added relevant documentation (doc comments with `///`).
- [x] I signed the [CLA].
- [x] All existing and new tests are passing.
If you need help, consider asking for advice on the #hackers-new channel
on [Discord].
<!-- Links -->
[Contributor Guide]:
https://github.com/flutter/flutter/wiki/Tree-hygiene#overview
[Tree Hygiene]: https://github.com/flutter/flutter/wiki/Tree-hygiene
[test-exempt]:
https://github.com/flutter/flutter/wiki/Tree-hygiene#tests
[Flutter Style Guide]:
https://github.com/flutter/flutter/wiki/Style-guide-for-Flutter-repo
[C++, Objective-C, Java style guides]:
https://github.com/flutter/engine/blob/main/CONTRIBUTING.md#style
[testing the engine]:
https://github.com/flutter/flutter/wiki/Testing-the-engine
[CLA]: https://cla.developers.google.com/
[flutter/tests]: https://github.com/flutter/tests
[breaking change policy]:
https://github.com/flutter/flutter/wiki/Tree-hygiene#handling-breaking-changes
[Discord]: https://github.com/flutter/flutter/wiki/Chat
2024-04-02 11:49:15 -04:00
skia-flutter-autoroll
5ab6def547
Roll Dart SDK from aa6544b48523 to e6e6d5fe3fb0 (1 revision) ( flutter/engine#51837 )
...
https://dart.googlesource.com/sdk.git/+log/aa6544b48523..e6e6d5fe3fb0
2024-04-01 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com Version 3.5.0-7.0.dev
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/dart-sdk-flutter-engine
Please CC dart-vm-team@google.com ,jacksongardner@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter Engine: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-04-02 15:32:06 +00:00
dependabot[bot]
ff48787ccd
Bump actions/setup-python from 5.0.0 to 5.1.0 ( flutter/engine#51841 )
...
Bumps [actions/setup-python](https://github.com/actions/setup-python ) from 5.0.0 to 5.1.0.
<details>
<summary>Release notes</summary>
<p><em>Sourced from <a href="https://github.com/actions/setup-python/releases ">actions/setup-python's releases</a>.</em></p>
<blockquote>
<h2>v5.1.0</h2>
<h2>What's Changed</h2>
<ul>
<li>Leveraging the raw API to retrieve the version-manifest, as it does not impose a rate limit and hence facilitates unrestricted consumption without the need for a token for Github Enterprise Servers by <a href="https://github.com/Shegox "><code>@âShegox</code></a> in <a href="https://redirect.github.com/actions/setup-python/pull/766 ">actions/setup-python#766</a>.</li>
<li>Dependency updates by <a href="https://github.com/dependabot "><code>@âdependabot</code></a> and <a href="https://github.com/HarithaVattikuti "><code>@âHarithaVattikuti</code></a> in <a href="https://redirect.github.com/actions/setup-python/pull/817 ">actions/setup-python#817</a></li>
<li>Documentation changes for version in README by <a href="https://github.com/basnijholt "><code>@âbasnijholt</code></a> in <a href="https://redirect.github.com/actions/setup-python/pull/776 ">actions/setup-python#776</a></li>
<li>Documentation changes for link in README by <a href="https://github.com/ukd1 "><code>@âukd1</code></a> in <a href="https://redirect.github.com/actions/setup-python/pull/793 ">actions/setup-python#793</a></li>
<li>Documentation changes for link in Advanced Usage by <a href="https://github.com/Jamim "><code>@âJamim</code></a> in <a href="https://redirect.github.com/actions/setup-python/pull/782 ">actions/setup-python#782</a></li>
<li>Documentation changes for avoiding rate limit issues on GHES by <a href="https://github.com/priya-kinthali "><code>@âpriya-kinthali</code></a> in <a href="https://redirect.github.com/actions/setup-python/pull/835 ">actions/setup-python#835</a></li>
</ul>
<h2>New Contributors</h2>
<ul>
<li><a href="https://github.com/basnijholt "><code>@âbasnijholt</code></a> made their first contribution in <a href="https://redirect.github.com/actions/setup-python/pull/776 ">actions/setup-python#776</a></li>
<li><a href="https://github.com/ukd1 "><code>@âukd1</code></a> made their first contribution in <a href="https://redirect.github.com/actions/setup-python/pull/793 ">actions/setup-python#793</a></li>
<li><a href="https://github.com/Jamim "><code>@âJamim</code></a> made their first contribution in <a href="https://redirect.github.com/actions/setup-python/pull/782 ">actions/setup-python#782</a></li>
<li><a href="https://github.com/Shegox "><code>@âShegox</code></a> made their first contribution in <a href="https://redirect.github.com/actions/setup-python/pull/766 ">actions/setup-python#766</a></li>
<li><a href="https://github.com/priya-kinthali "><code>@âpriya-kinthali</code></a> made their first contribution in <a href="https://redirect.github.com/actions/setup-python/pull/835 ">actions/setup-python#835</a></li>
</ul>
<p><strong>Full Changelog</strong>: <a href="https://github.com/actions/setup-python/compare/v5.0.0...v5.1.0 ">https://github.com/actions/setup-python/compare/v5.0.0...v5.1.0 </a></p>
</blockquote>
</details>
<details>
<summary>Commits</summary>
<ul>
<li><a href="82c7e631bbhttps://redirect.github.com/actions/setup-python/issues/835 ">#835</a>)</li>
<li><a href="10aa35afd7https://redirect.github.com/actions/setup-python/issues/766 ">#766</a>)</li>
<li><a href="9a7ac94420https://redirect.github.com/actions/setup-python/issues/817 ">#817</a>)</li>
<li><a href="871daa956chttps://redirect.github.com/actions/setup-python/issues/782 ">#782</a>)</li>
<li><a href="2f078955e4https://redirect.github.com/actions/setup-python/issues/793 ">#793</a>)</li>
<li><a href="e9d6f99097https://redirect.github.com/actions/setup-python/issues/776 ">#776</a>)</li>
<li>See full diff in <a href="0a5c615913...82c7e631bbhttps://dependabot-badges.githubapp.com/badges/compatibility_score?dependency-name=actions/setup-python&package-manager=github_actions&previous-version=5.0.0&new-version=5.1.0 )](https://docs.github.com/en/github/managing-security-vulnerabilities/about-dependabot-security-updates#about-compatibility-scores )
Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting `@dependabot rebase`.
---
<details>
<summary>Dependabot commands and options</summary>
<br />
You can trigger Dependabot actions by commenting on this PR:
- `@dependabot rebase` will rebase this PR
- `@dependabot recreate` will recreate this PR, overwriting any edits that have been made to it
- `@dependabot merge` will merge this PR after your CI passes on it
- `@dependabot squash and merge` will squash and merge this PR after your CI passes on it
- `@dependabot cancel merge` will cancel a previously requested merge and block automerging
- `@dependabot reopen` will reopen this PR if it is closed
- `@dependabot close` will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
- `@dependabot show <dependency name> ignore conditions` will show all of the ignore conditions of the specified dependency
- `@dependabot ignore this major version` will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
- `@dependabot ignore this minor version` will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
- `@dependabot ignore this dependency` will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)
</details>
2024-04-02 05:46:22 +00:00
skia-flutter-autoroll
6f2999789b
Roll Skia from fe64c32d7f2e to cd75e4672719 (1 revision) ( flutter/engine#51833 )
...
https://skia.googlesource.com/skia.git/+log/fe64c32d7f2e..cd75e4672719
2024-04-01 bungeman@google.com [paragraph] TypefaceFontProvider impl more FontMgr
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC brianosman@google.com ,jacksongardner@google.com,kjlubick@google.com,rmistry@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-04-02 02:02:23 +00:00
Matan Lurey
1ff20bb3db
Move scenario_app integration tests back to max_attempts: 2. ( flutter/engine#51838 )
...
This seems to be the flakiest target, and is/was making our CI red all day.
Related: https://github.com/flutter/flutter/issues/145988 .
2024-04-02 00:56:14 +00:00
auto-submit[bot]
3bca0bb5c9
Reverts "[Impeller] Avoid loading redundant Vulkan extensions. ( #51818 )" ( flutter/engine#51835 )
...
Reverts: flutter/engine#51818
Initiated by: chinmaygarde
Reason for reverting: VK_EXT_queue_family_foreign needs to be explicitly enabled even though the documentation stays that 1.1 is a dependency (https://registry.khronos.org/vulkan/specs/1.3-extensions/man/html/VK_EXT_queue_family_foreign.html#_extension_and_version_dependencies ). Broke validation enabled builds downstream. https://ci.chromium.org/ui/p/flutter/builders/prod/Linux_pixel_7pro%20hello_world_impeller/3118/ov
Original PR Author: chinmaygarde
Reviewed By: {jonahwilliams}
This change reverts the following previous change:
All dependencies of VK_ANDROID_external_memory_android_hardware_buffer were enabled earlier. But I didn't realize that those extensions became core in Vulkan 1.1. There is no need to load them unnecessarily. It just makes the extensions requirements look more complicated than they are.
Just deletes code. No change in functionality.
2024-04-01 23:08:30 +00:00
Matan Lurey
a70095b10c
Run and record adb shell screenrecord during Android scenario app ( flutter/engine#51832 )
...
More grasping at straws to solve https://github.com/flutter/flutter/issues/145988 .
At some point this could be moved to `--verbose` if it isn't useful.
This will automatically be copied into `${FLUTTER_LOGS_DIR}`, yay!
Example:
https://github.com/flutter/engine/assets/168174/c8caca7a-88ec-4d09-88bd-ebfc531f6512
2024-04-01 22:49:47 +00:00
skia-flutter-autoroll
abe6506bda
Roll Skia from 0b0ed6ca101b to fe64c32d7f2e (4 revisions) ( flutter/engine#51831 )
...
https://skia.googlesource.com/skia.git/+log/0b0ed6ca101b..fe64c32d7f2e
2024-04-01 egdaniel@google.com Reland "Add compressed texture support to graphite."
2024-04-01 kjlubick@google.com Revert "Fix defines for icu_subset"
2024-04-01 kjlubick@google.com Fix some c++20 warnings
2024-04-01 armansito@google.com [graphite][compute] Buffer clear at DispatchGroup granularity
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC brianosman@google.com ,jacksongardner@google.com,kjlubick@google.com,rmistry@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-04-01 22:42:17 +00:00
Matan Lurey
f8b8fafd60
Run the DrawSolidBlueScreenTest 5x in a row in bringup builds. ( flutter/engine#51829 )
...
Trying to reproduce https://github.com/flutter/flutter/issues/145988
outside of texture tests.
/cc @ricardoamador
2024-04-01 14:47:52 -07:00
Matan Lurey
4ae59a2770
Remove tests related to StrictMode that were never running on CI. ( flutter/engine#51827 )
...
Closes https://github.com/flutter/flutter/issues/60635 as not planned.
2024-04-01 21:26:58 +00:00
Jonah Williams
f414c684e0
[Impeller] Ignore warnign about shader stages not consuming outputs. ( flutter/engine#51822 )
...
Otherwise it really complicates runtime_effect, as we'd need two vertex shaders.
Fixes https://github.com/flutter/flutter/issues/145860
2024-04-01 21:22:05 +00:00
Jackson Gardner
adfd52167c
[Skwasm] Forward text height from paragraph height to default text style ( flutter/engine#51819 )
...
We need to apply the paragraph style's height to the initial default text style on the stack. I also added a `toString` method for `StrutStyle` so that things are a bit easier to debug.
2024-04-01 21:20:28 +00:00
Matan Lurey
9f1dd63dac
Remove log statements that did not help. ( flutter/engine#51825 )
...
Introduced in https://github.com/flutter/engine/pull/51789 , but none of the crashes/hangs on CI seem related to these events, so removing.
2024-04-01 21:19:53 +00:00
skia-flutter-autoroll
210666d858
Roll Skia from 40c436a785fa to 0b0ed6ca101b (6 revisions) ( flutter/engine#51823 )
...
https://skia.googlesource.com/skia.git/+log/40c436a785fa..0b0ed6ca101b
2024-04-01 egdaniel@google.com Revert "Add compressed texture support to graphite."
2024-04-01 skia-autoroll@skia-public.iam.gserviceaccount.com Roll vulkan-deps from 778a83fe011e to 319732cc90e4 (1 revision)
2024-04-01 jamesgk@google.com [graphite] Fix off-by-one error in render step limit check
2024-04-01 kjlubick@google.com Remove Metal #ifdefs from GrBackendSurface
2024-04-01 johnstiles@google.com Remove divmod optimization trick for GCC + ARM32.
2024-04-01 kjlubick@google.com Fix defines for icu_subset
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC brianosman@google.com ,jacksongardner@google.com,kjlubick@google.com,rmistry@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-04-01 20:26:59 +00:00
Jason Simmons
1bfca0c056
[Impeller] Add a TextureGLES API for wrapping a framebuffer and use it to implement OpenGL FBO targets in the embedder library ( flutter/engine#51269 )
...
The Linux embedder is rendering to a FlutterOpenGLFramebuffer that specifies an OpenGL FBO. This API allows the embedder to create a color attachment that wraps the FBO so that the render pass will bind to that FBO during encoding.
2024-04-01 20:19:14 +00:00
Matan Lurey
a16ee1a7ac
Remove testing/android_background_image which does not run/exist on CI. ( flutter/engine#51815 )
...
I am guessing this just either served it's purpose (https://github.com/flutter/flutter/issues/26654 , https://github.com/flutter/flutter/issues/26728 ) or didn't and was never followed up. I can't find any examples of it running on CI - I suspect if we want a test like this, we're better off just adding it to `scenario_app` versus creating more 1-off Android integration test environments.
2024-04-01 18:59:50 +00:00
Chinmay Garde
97dbb54cc8
[Impeller] Avoid loading redundant Vulkan extensions. ( flutter/engine#51818 )
...
All dependencies of VK_ANDROID_external_memory_android_hardware_buffer were enabled earlier. But I didn't realize that those extensions became core in Vulkan 1.1. There is no need to load them unnecessarily. It just makes the extensions requirements look more complicated than they are.
Just deletes code. No change in functionality.
2024-04-01 18:59:48 +00:00
skia-flutter-autoroll
6b0dca4000
Roll Skia from dacd62255b8d to 40c436a785fa (3 revisions) ( flutter/engine#51817 )
...
https://skia.googlesource.com/skia.git/+log/dacd62255b8d..40c436a785fa
2024-04-01 egdaniel@google.com Add compressed texture support to graphite.
2024-04-01 bungeman@google.com [paragraph] Use ICU4X for ICU4X test
2024-04-01 johnstiles@google.com Fix potential overflow in SkISize::area.
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC brianosman@google.com ,jacksongardner@google.com,kjlubick@google.com,rmistry@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-04-01 18:17:48 +00:00
Matan Lurey
6969c285f3
Remove unused and untested timeline data branch for scenario_app ( flutter/engine#51816 )
...
All of this appears to be completely unused and untested, and I don't see value in fixing it.
2024-04-01 18:06:52 +00:00
Jason Simmons
e6b41a1754
Use the stripped Vulkan validation library in Android engine builds by default ( flutter/engine#51628 )
...
The unstripped build will be used if GN is configured with the --no-stripped flag
2024-04-01 17:48:50 +00:00
Jason Simmons
18cfd29d00
[Impeller] Set RGBA8888 as the default Vulkan color format before the app acquires a surface ( flutter/engine#51770 )
...
An app may render offscreen images before it gets a window. The ContextVK needs to have a default color format so that render passes can be created before the ContextVK is updated to use the window's format.
2024-04-01 17:33:05 +00:00
Matan Lurey
1fd40fb2e4
Never panic in finally { ... }, check output logs on success only. ( flutter/engine#51814 )
...
Work towards https://github.com/flutter/flutter/issues/145988 .
Should be a NO-OP in behavior, but hopefully make some of the false negatives less confusing (i.e. getting "missing X outputted files when the test is about to fail anyway".
2024-04-01 17:33:02 +00:00
skia-flutter-autoroll
26eea799a1
Roll Skia from da4cd3390be9 to dacd62255b8d (1 revision) ( flutter/engine#51813 )
...
https://skia.googlesource.com/skia.git/+log/da4cd3390be9..dacd62255b8d
2024-04-01 bungeman@google.com [fontations] Modernize family name
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC brianosman@google.com ,jacksongardner@google.com,kjlubick@google.com,rmistry@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-04-01 17:05:05 +00:00
Zachary Anderson
52d352a9ea
Roll buildroot to dcd71b5b237e1e58f2ad8a7e51bead0c2a3755a9 ( flutter/engine#51812 )
...
To pick up https://github.com/flutter/buildroot/pull/843
2024-04-01 09:41:31 -07:00
skia-flutter-autoroll
7657c62f94
Roll Dart SDK from b735974580e7 to aa6544b48523 (1 revision) ( flutter/engine#51810 )
...
https://dart.googlesource.com/sdk.git/+log/b735974580e7..aa6544b48523
2024-04-01 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com Version 3.5.0-6.0.dev
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/dart-sdk-flutter-engine
Please CC dart-vm-team@google.com ,jacksongardner@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter Engine: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-04-01 16:15:14 +00:00
skia-flutter-autoroll
b7b725aa6d
Roll Skia from 3093d7c90fb2 to da4cd3390be9 (1 revision) ( flutter/engine#51811 )
...
https://skia.googlesource.com/skia.git/+log/3093d7c90fb2..da4cd3390be9
2024-04-01 robertphillips@google.com [graphite] Add Arithmetic SkBlender to Precompilation system
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC brianosman@google.com ,jacksongardner@google.com,kjlubick@google.com,rmistry@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-04-01 14:15:42 +00:00
skia-flutter-autoroll
b9b08f3339
Roll Skia from 45e4d2cbdd4f to 3093d7c90fb2 (1 revision) ( flutter/engine#51807 )
...
https://skia.googlesource.com/skia.git/+log/45e4d2cbdd4f..3093d7c90fb2
2024-04-01 skia-autoroll@skia-public.iam.gserviceaccount.com Roll ANGLE from 2b66694d37de to c6a6d3f9fa69 (13 revisions)
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC brianosman@google.com ,jacksongardner@google.com,kjlubick@google.com,rmistry@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-04-01 11:29:21 +00:00
skia-flutter-autoroll
3b8751fe48
Roll Skia from b9d078716d40 to 45e4d2cbdd4f (2 revisions) ( flutter/engine#51806 )
...
https://skia.googlesource.com/skia.git/+log/b9d078716d40..45e4d2cbdd4f
2024-04-01 skia-autoroll@skia-public.iam.gserviceaccount.com Roll SK Tool from df0949e75440 to c70da7bc67c4
2024-04-01 skia-autoroll@skia-public.iam.gserviceaccount.com Roll Dawn from 2126889e45aa to 591c327b3bb5 (11 revisions)
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC brianosman@google.com ,jacksongardner@google.com,kjlubick@google.com,rmistry@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-04-01 07:13:42 +00:00
skia-flutter-autoroll
30c49fc205
Roll Fuchsia Linux SDK from TXxMINUq7JduIRX8K... to 5W6KVvHCGwWHBjm2m... ( flutter/engine#51805 )
...
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/fuchsia-linux-sdk-flutter-engine
Please CC jacksongardner@google.com ,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-04-01 07:04:19 +00:00
skia-flutter-autoroll
5bee981696
Roll Skia from c61843470d89 to b9d078716d40 (1 revision) ( flutter/engine#51804 )
...
https://skia.googlesource.com/skia.git/+log/c61843470d89..b9d078716d40
2024-04-01 skia-autoroll@skia-public.iam.gserviceaccount.com Roll Skia Infra from 33ace26e29f4 to df0949e75440 (8 revisions)
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC brianosman@google.com ,jacksongardner@google.com,kjlubick@google.com,rmistry@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-04-01 06:10:21 +00:00
Zachary Anderson
2512c698ae
Prefix non-local build config names with ci/ ( flutter/engine#51474 )
...
Part 1 of https://github.com/flutter/flutter/issues/145263
This PR updates the names of builds outside of `local_engine.json` to be
prefixed with the string `ci/` (or `ci\` on Windows). For better or
worse, the "name" field of a build is used to construct a path used as
the source directory of a copy operation (I think the CAS archive
step?). Because of that, changing the name of a build also requires
updating the build output directory of the ninja build.
This PR also adds tests to make sure the naming of these builds remains
consistent.
2024-03-31 12:43:02 -07:00
Matan Lurey
1bf91441fa
Finish clangd testing. ( flutter/engine#51786 )
...
Closes https://github.com/flutter/flutter/issues/141641 , yay we done!
---------
Co-authored-by: Zachary Anderson <zanderso@users.noreply.github.com>
2024-03-31 10:20:44 -07:00
skia-flutter-autoroll
ed62b96527
Roll Skia from 0970776d543a to c61843470d89 (1 revision) ( flutter/engine#51802 )
...
https://skia.googlesource.com/skia.git/+log/0970776d543a..c61843470d89
2024-03-31 skia-autoroll@skia-public.iam.gserviceaccount.com Roll SK Tool from 341432c665a4 to df0949e75440
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC brianosman@google.com ,jacksongardner@google.com,kjlubick@google.com,rmistry@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-03-31 07:28:38 +00:00
skia-flutter-autoroll
d38575f90f
Roll Fuchsia Linux SDK from wrbGDfD0BEOBXEGMK... to TXxMINUq7JduIRX8K... ( flutter/engine#51801 )
...
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/fuchsia-linux-sdk-flutter-engine
Please CC jacksongardner@google.com ,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-03-31 05:40:22 +00:00
skia-flutter-autoroll
71d3a545cf
Roll Dart SDK from 572de60e008a to b735974580e7 (2 revisions) ( flutter/engine#51799 )
...
https://dart.googlesource.com/sdk.git/+log/572de60e008a..b735974580e7
2024-03-30 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com Version 3.5.0-5.0.dev
2024-03-30 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com Version 3.5.0-4.0.dev
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/dart-sdk-flutter-engine
Please CC dart-vm-team@google.com ,jacksongardner@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter Engine: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-03-30 07:00:30 +00:00
skia-flutter-autoroll
3fb1323d4a
Roll Skia from 7dc399e01f98 to 0970776d543a (1 revision) ( flutter/engine#51796 )
...
https://skia.googlesource.com/skia.git/+log/7dc399e01f98..0970776d543a
2024-03-30 skia-autoroll@skia-public.iam.gserviceaccount.com Roll vulkan-deps from b203847466b0 to 778a83fe011e (3 revisions)
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC brianosman@google.com ,jacksongardner@google.com,jamesgk@google.com,rmistry@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-03-30 04:22:51 +00:00
skia-flutter-autoroll
b74c15a651
Roll Fuchsia Linux SDK from 3vgfbp1vjXkdMZ09m... to wrbGDfD0BEOBXEGMK... ( flutter/engine#51797 )
...
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/fuchsia-linux-sdk-flutter-engine
Please CC jacksongardner@google.com ,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-03-30 04:19:37 +00:00
skia-flutter-autoroll
ecdc5bd4fa
Roll Skia from ab0f4a038cec to 7dc399e01f98 (2 revisions) ( flutter/engine#51795 )
...
https://skia.googlesource.com/skia.git/+log/ab0f4a038cec..7dc399e01f98
2024-03-30 lovisolo@google.com [bazel] Define //tools/sk_app:sk_app modular build target.
2024-03-29 lovisolo@google.com [bazel] Define //tools/window:window modular build target.
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC brianosman@google.com ,jacksongardner@google.com,jamesgk@google.com,rmistry@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-03-30 02:17:04 +00:00
skia-flutter-autoroll
9813e61ed5
Roll Dart SDK from 52b05146758e to 572de60e008a (1 revision) ( flutter/engine#51794 )
...
https://dart.googlesource.com/sdk.git/+log/52b05146758e..572de60e008a
2024-03-29 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com Version 3.5.0-3.0.dev
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/dart-sdk-flutter-engine
Please CC dart-vm-team@google.com ,jacksongardner@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter Engine: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-03-30 01:52:51 +00:00
