14002 Commits

Author SHA1 Message Date
xster
e1cfc1ac6b Fix a AppLifecycleTest present time race between the animation and the rest of the test (flutter/engine#21107) 2020-09-14 08:50:16 -07:00
skia-flutter-autoroll
f223bcae3a Roll Fuchsia Mac SDK from 78RTO77Tu... to m7z9dEdGg... (flutter/engine#21143) 2020-09-13 19:12:02 -07:00
Greg Spencer
b78f92a7c5 Track lock key down state instead of lock state (flutter/engine#20836)
This converts the GTK keyboard code to track the key down states of the lock modifiers NumLock and CapsLock so that they represent the actual "down" state of the key, rather than the lock state itself.

GTK tracks the lock state, and Flutter expects the down state.
2020-09-13 14:44:25 -07:00
skia-flutter-autoroll
704bfa2d07 Roll Fuchsia Linux SDK from 0XXjmMun1... to KA_kDgY7C... (flutter/engine#21142) 2020-09-13 08:37:01 -07:00
skia-flutter-autoroll
53d3ff8552 Roll Fuchsia Mac SDK from C73kzh_IF... to 78RTO77Tu... (flutter/engine#21141) 2020-09-13 04:37:02 -07:00
skia-flutter-autoroll
a41786e595 Roll Skia from 186866c46179 to b711737c1384 (1 revision) (flutter/engine#21140) 2020-09-13 03:07:01 -07:00
skia-flutter-autoroll
31b375e938 Roll Dart SDK from 4bf1f624d06e to b6f67aa2cc72 (1 revision) (flutter/engine#21139) 2020-09-12 20:52:02 -07:00
skia-flutter-autoroll
6fdce1b6b4 Roll Fuchsia Linux SDK from hO-ki0WJb... to 0XXjmMun1... (flutter/engine#21138) 2020-09-12 19:17:01 -07:00
skia-flutter-autoroll
440b4a61ea Roll Dart SDK from 3533cfda999e to 4bf1f624d06e (1 revision) (flutter/engine#21137) 2020-09-12 16:42:01 -07:00
skia-flutter-autoroll
2e352f77a1 Roll Fuchsia Mac SDK from oINI9fspF... to C73kzh_IF... (flutter/engine#21136) 2020-09-12 15:32:01 -07:00
skia-flutter-autoroll
67a79592eb Roll Dart SDK from d2ba4fd3275e to 3533cfda999e (1 revision) (flutter/engine#21134) 2020-09-12 12:32:01 -07:00
Chris Bracken
7f7616418b [felt] Use autoninja instead of hardcoding threads (flutter/engine#21130)
autoninja is included as part of depot_tools and automatically
determines the optimal thread count.

Also applies quoting on the affected lines.
2020-09-12 12:14:05 -07:00
skia-flutter-autoroll
27dd510443 Roll Skia from 582c5a9a84ac to 186866c46179 (1 revision) (flutter/engine#21133) 2020-09-12 09:37:02 -07:00
skia-flutter-autoroll
e82a56ab9b Roll Fuchsia Linux SDK from f3YqG3OdI... to hO-ki0WJb... (flutter/engine#21132) 2020-09-12 04:27:02 -07:00
skia-flutter-autoroll
76c70e97cc Roll Fuchsia Mac SDK from ggoll70iR... to oINI9fspF... (flutter/engine#21131) 2020-09-12 02:27:01 -07:00
Chris Bracken
2586db3b22 Clean up C++ includes (flutter/engine#21127)
Cleans up header order/grouping for consistency: associated header, C/C++ system/standard library headers, library headers, platform-specific #includes.

Adds <cstring> where strlen, memcpy are being used: there are a bunch of places we use them transitively.

Applies linter-required cleanups. Disables linter on one file due to included RapidJson header. See https://github.com/flutter/flutter/issues/65676

This patch does not cover flutter/shell/platform/darwin. There's a separate, slightly more intensive cleanup for those in progress.
2020-09-11 21:18:35 -07:00
skia-flutter-autoroll
8163011d78 Roll Dart SDK from 1c887123b92c to d2ba4fd3275e (1 revision) (flutter/engine#21128) 2020-09-11 20:27:01 -07:00
skia-flutter-autoroll
a2635619b8 Roll Skia from 9eb848ae8218 to 582c5a9a84ac (1 revision) (flutter/engine#21124) 2020-09-11 18:02:01 -07:00
Emmanuel Garcia
1ec891cb52 Fix comment indentation (flutter/engine#21114) 2020-09-11 17:50:26 -07:00
Chris Bracken
d03692449b Prefer C++ standard headers to their C counterpart (flutter/engine#21091)
We currently use a mix of C standard includes (e.g. limits.h) and their
C++ variants (e.g. climits). This migrates to a consistent style for all
cases where the C++ variants are acceptable, but leaves the C
equivalents in place where they are required, such as in the embedder
API and other headers that may be used from C.
2020-09-11 17:10:00 -07:00
Emmanuel Garcia
8a317ebabc Add a new raster status kSkipAndRetry frame (flutter/engine#21059) 2020-09-11 16:29:11 -07:00
Jason Simmons
c3a37bec80 Check for a valid SkSL cache directory before calling VisitFiles (flutter/engine#21118)
The directory may be invalid when running shell_unittests because
some tests call SetCacheDirectoryPath and then delete the directory.
Later tests that try to use that cache base path will be unable to
open the directory.
2020-09-11 16:23:25 -07:00
Chris Bracken
eaa458dd36 Disable iOS application lifetime Scenario tests (flutter/engine#21125)
This speculatively disables the ApplicationLifecycle Scenarios iOS tests
which continue to fail after being re-enabled in flutter/engine#21087.

Related P0 issue: https://github.com/flutter/flutter/issues/61620
2020-09-11 16:12:22 -07:00
skia-flutter-autoroll
05bc0c6cd2 Roll Skia from 6518d77a2200 to 9eb848ae8218 (20 revisions) (flutter/engine#21122) 2020-09-11 15:10:01 -07:00
skia-flutter-autoroll
dc2f43df04 Roll Fuchsia Linux SDK from XIejclW2X... to f3YqG3OdI... (flutter/engine#21121) 2020-09-11 15:05:02 -07:00
Chris Bracken
9233f884e7 Update OCMock to version 3.7.1 (flutter/engine#21111)
This gets us to latest and fixes a warning about a missing cast.

This rolls buildroot to f83d1d75216e97fb696434bca1cb9a4e7a570fb6

Related patch: https://github.com/flutter/buildroot/pull/401
2020-09-11 13:52:00 -07:00
Sam Rawlins
b72dca37f3 Fix erroneous dartdoc @tool directive. (flutter/engine#21109) 2020-09-11 12:00:02 -07:00
Chris Bracken
7acd2b407c Fix linter errors in mock_engine (flutter/engine#21102)
Make a single-param ctor explicit in order to prevent surprising
implicit conversions.

Add a check for zero message-size and don't malloc/memcpy the incoming
message in those cases.

Add braces where they were missing.
2020-09-11 10:27:00 -07:00
skia-flutter-autoroll
3e7466a904 Roll Fuchsia Mac SDK from b9rM1nBK1... to ggoll70iR... (flutter/engine#21101) 2020-09-11 10:10:01 -07:00
skia-flutter-autoroll
09acacc846 Roll Dart SDK from 14f1940f537e to 1c887123b92c (1 revision) (flutter/engine#21093) 2020-09-11 09:55:01 -07:00
xster
a0944e63b4 re-enable scenario tests on iOS (flutter/engine#21088) 2020-09-11 09:21:37 -07:00
Chris Bracken
9ff7d7ca44 Copyright header hygiene improvements (flutter/engine#21089)
Add copyright headers in a few files where they were missing.

Trim trailing blank comment line where present, for consistency with
other engine code.

Use the standard libtxt copyright header in one file where it differed
(extra (C) and comma compared to other files in libtxt).

This also amends tools/const_finder/test/const_finder_test.dart to look
for a const an additional four lines down to account for the copyright
header added to the test fixture.
2020-09-11 08:55:37 -07:00
skia-flutter-autoroll
d4cab475f2 Roll Skia from bbe69951b416 to 6518d77a2200 (1 revision) (flutter/engine#21096) 2020-09-11 08:10:02 -07:00
skia-flutter-autoroll
109666e75e Roll Dart SDK from 1abce6d054ad to 14f1940f537e (1 revision) (flutter/engine#21092) 2020-09-11 02:05:01 -07:00
skia-flutter-autoroll
31834626c2 Roll Fuchsia Linux SDK from l8baHga4c... to XIejclW2X... (flutter/engine#21086) 2020-09-11 00:25:01 -07:00
skia-flutter-autoroll
16f7e116e6 Roll Skia from 9d6f955f52e9 to bbe69951b416 (4 revisions) (flutter/engine#21090) 2020-09-11 00:05:02 -07:00
Chris Bracken
c117a411ae Re-enable (most) iOS Scenarios tests (flutter/engine#21087)
This re-enables the iOS Scenarios tests which have been flaky in the
last couple days.

Disabling two tests where we've seen the flakes:
* AppLifecycleTests testFlutterViewControllerDetachingSendsApplicationLifecycle
* FlutterViewControllerInitialRouteTest testSettingInitialRoute

This reverts commit 84995bd516d94a3a7e52e752ad666a8b22068498.
2020-09-10 22:57:56 -07:00
skia-flutter-autoroll
5b60d0d508 Roll Skia from 0b6bf1c9668e to 9d6f955f52e9 (8 revisions) (flutter/engine#21085) 2020-09-10 22:45:02 -07:00
skia-flutter-autoroll
e5f07b4fc2 Roll Dart SDK from 72393cc698da to 1abce6d054ad (3 revisions) (flutter/engine#21083)
https://dart.googlesource.com/sdk.git/+log/72393cc698da..1abce6d054ad

2020-09-11 dart-luci-ci-builder@dart-ci.iam.gserviceaccount.com Version 2.10.0-115.0.dev
2020-09-10 dart-luci-ci-builder@dart-ci.iam.gserviceaccount.com Version 2.10.0-114.0.dev
2020-09-10 dart-luci-ci-builder@dart-ci.iam.gserviceaccount.com Version 2.10.0-113.0.dev

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/dart-sdk-flutter-engine
Please CC dart-vm-team@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md
2020-09-10 21:37:36 -07:00
stuartmorgan
087ad9a390 Minor windows.h cleanup (flutter/engine#21082)
- Standardize on lowercase for windows.h
- Don't define NOMINMAX before including windows.h in (some) public
  wrapper headers, since it causes a warning when combined with setting
  NOMINMAX at the build level, which is the more robust way to avoid
  issues with min/max and windows.h
2020-09-10 21:11:07 -07:00
stuartmorgan
1cb8585fa7 Remove deprecated methods from FlutterViewController (flutter/engine#21081)
The template now uses the FlutterEngine versions.
2020-09-10 21:10:28 -07:00
stuartmorgan
91c34dca2e Clean up deprecated EncodableValue code (flutter/engine#20981)
Removes the older pointer-based versions of APIs taking EncodableValues for which there are now reference-based versions.
2020-09-10 21:08:52 -07:00
xster
7f02d137c3 add back a line to build host for scenario tests (flutter/engine#21076) 2020-09-10 21:05:03 -07:00
skia-flutter-autoroll
0a9b5e19ad Roll Skia from fb5e0ebef07c to 0b6bf1c9668e (2 revisions) (flutter/engine#21074)
https://skia.googlesource.com/skia.git/+log/fb5e0ebef07c..0b6bf1c9668e

2020-09-10 skia-autoroll@skia-public.iam.gserviceaccount.com Roll dawn from 0a1061da0c7f to 87f25134a8c1 (7 revisions)
2020-09-10 bsalomon@google.com Revert "Temporary hack to force text texture index varying to be float."

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC reed@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md
2020-09-10 21:03:49 -07:00
skia-flutter-autoroll
de4cbc902d Roll Fuchsia Mac SDK from 5o9onBKYd... to b9rM1nBK1... (flutter/engine#21079)
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/fuchsia-mac-sdk-flutter-engine
Please CC jsimmons@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md
2020-09-10 21:03:31 -07:00
chunhtai
da3c08e3ba Implement browser history class for router widget (flutter/engine#20794) 2020-09-10 21:00:02 -07:00
Chris Bracken
84995bd516 Disable iOS ScenariosTests suite (flutter/engine#21080)
This disables the macOS Scenarios app tests until a fix for the current
flakiness is found.

This also reverts commit 9ef075582e0dcaa4df990338b931219465ffcbce where
one test was previously disabled. However, another started failing soon
after, so instead we disable the whole suite here.
2020-09-10 19:50:03 -07:00
Chris Bracken
9ef075582e Disable a flaky Scenarios test (flutter/engine#21075)
This disables the macOS Scenarios app test
testFlutterViewControllerDetachingSendsApplicationLifecycle
until a fix for the flakiness is found.

Related issue: https://github.com/flutter/flutter/issues/61620
2020-09-10 13:21:17 -07:00
skia-flutter-autoroll
e40f3637e0 Roll Skia from 3d41d509a6a9 to fb5e0ebef07c (1 revision) (flutter/engine#21072) 2020-09-10 09:25:03 -07:00
Damian Wrobel
d71cece456 Add missing <cstring> header (flutter/engine#21069)
Fixes the following compilation errors:

../../flutter/shell/platform/linux/fl_value.cc:267:3: error: use of undeclared identifier 'memcpy'
  memcpy(self->values, data, sizeof(uint8_t) * data_length);
  ^
../../flutter/shell/platform/linux/fl_value.cc:284:3: error: use of undeclared identifier 'memcpy'
  memcpy(self->values, data, sizeof(int32_t) * data_length);
  ^
../../flutter/shell/platform/linux/fl_value.cc:294:3: error: use of undeclared identifier 'memcpy'
  memcpy(self->values, data, sizeof(int64_t) * data_length);
  ^
../../flutter/shell/platform/linux/fl_value.cc:304:3: error: use of undeclared identifier 'memcpy'
  memcpy(self->values, data, sizeof(double) * data_length);
  ^

../../flutter/shell/platform/linux/fl_string_codec.cc:29:28: error: use of undeclared identifier 'strlen'
  return g_bytes_new(text, strlen(text));
                           ^

../../flutter/shell/platform/linux/fl_standard_message_codec.cc:512:23: error: use of undeclared identifier 'strlen'
      size_t length = strlen(text);
                      ^

Signed-off-by: Damian Wrobel <dwrobel@ertelnet.rybnik.pl>
2020-09-10 09:24:54 -07:00