Re-enable (most) iOS Scenarios tests (flutter/engine#21087)

This re-enables the iOS Scenarios tests which have been flaky in the
last couple days.

Disabling two tests where we've seen the flakes:
* AppLifecycleTests testFlutterViewControllerDetachingSendsApplicationLifecycle
* FlutterViewControllerInitialRouteTest testSettingInitialRoute

This reverts commit 84995bd516d94a3a7e52e752ad666a8b22068498.
This commit is contained in:
Chris Bracken 2020-09-10 22:57:56 -07:00 committed by GitHub
parent 5b60d0d508
commit c117a411ae
3 changed files with 12 additions and 13 deletions

View File

@ -227,7 +227,9 @@ FLUTTER_ASSERT_ARC
[engine setViewController:nil];
}
- (void)testFlutterViewControllerDetachingSendsApplicationLifecycle {
// TODO(cbracken): re-enable this test by removing the skip_ prefix once the source of its flakiness
// has been identified. https://github.com/flutter/flutter/issues/61620
- (void)skip_testFlutterViewControllerDetachingSendsApplicationLifecycle {
XCTestExpectation* engineStartedExpectation = [self expectationWithDescription:@"Engine started"];
// Let the engine finish booting (at the end of which the channels are properly set-up) before

View File

@ -33,7 +33,9 @@ FLUTTER_ASSERT_ARC
[super tearDown];
}
- (void)testSettingInitialRoute {
// TODO(cbracken): re-enable this test by removing the skip_ prefix once the source of its flakiness
// has been identified. https://github.com/flutter/flutter/issues/61620
- (void)skip_testSettingInitialRoute {
self.flutterViewController =
[[FlutterViewController alloc] initWithProject:nil
initialRoute:@"myCustomInitialRoute"

View File

@ -33,14 +33,9 @@ if [[ $# -eq 1 ]]; then
FLUTTER_ENGINE="$1"
fi
echo "iOS Scenarios tests currently disabled due to flakiness"
echo "See: https://github.com/flutter/flutter/issues/61620"
# TODO(cbracken): re-enable when
# https://github.com/flutter/flutter/issues/61620 is fixed.
# cd ios/Scenarios
# set -o pipefail && xcodebuild -sdk iphonesimulator \
# -scheme Scenarios \
# -destination 'platform=iOS Simulator,name=iPhone 8' \
# test \
# FLUTTER_ENGINE="$FLUTTER_ENGINE"
cd ios/Scenarios
set -o pipefail && xcodebuild -sdk iphonesimulator \
-scheme Scenarios \
-destination 'platform=iOS Simulator,name=iPhone 8' \
test \
FLUTTER_ENGINE="$FLUTTER_ENGINE"