DEV/flutter_flutter
1
0
Fork 0
mirror of https://github.com/flutter/flutter.git synced 2026-02-20 02:29:02 +08:00
Code Issues Packages Projects Releases Wiki Activity
83,405 Commits 882 Branches 1,069 Tags
Commit Graph

30119 Commits

Author SHA1 Message Date
Jason Simmons
7692c1143e
Update the Dart package creation script to copy source files instead of creating symlinks to the source tree (#165242) 
The use of symlinks and the use of a directory as a GN output path may
cause unnecessary rebuilds when Ninja checks file modification times to
determine whether build outputs are up to date.

Also remove various other unused featues that were copied from the
original version of the script in the Mojo project.
 2025-03-25 21:08:08 +00:00
Jason Simmons
efd9f148fa
Roll Dart SDK from 31df9f4a0c12 to e28bf080514a (1 revision) (#165893) 
https://dart.googlesource.com/sdk.git/+log/31df9f4a0c12..e28bf080514a

2025-03-25 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com
Version 3.8.0-223.0.dev

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/dart-sdk-flutter
Please CC dart-vm-team@google.com,jimgraham@google.com on the revert to
ensure that a human is aware of the problem.

To file a bug in Flutter:
https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

Co-authored-by: engine-flutter-autoroll <engine-flutter-autoroll@skia.org>
 2025-03-25 21:08:08 +00:00
auto-submit[bot]
8d484fc4ed
Reverts "[iOS] reduce wide gamut memory by 50% (for onscreen surfaces). (#165601)" (#165915) 
<!-- start_original_pr_link -->
Reverts: flutter/flutter#165601
<!-- end_original_pr_link -->
<!-- start_initiating_author -->
Initiated by: jonahwilliams
<!-- end_initiating_author -->
<!-- start_revert_reason -->
Reason for reverting: descriptor mismatch not caught in testing. Maybe
missing feature?
<!-- end_revert_reason -->
<!-- start_original_pr_author -->
Original PR Author: jonahwilliams
<!-- end_original_pr_author -->

<!-- start_reviewers -->
Reviewed By: {gaaclarke}
<!-- end_reviewers -->

<!-- start_revert_body -->
This change reverts the following previous change:
If the onscreen surface is opaque, resolve to an alpha-less wide gamut
format. This reduces the bits per color from 40 to 32, which allows us
to fit in a 32 bit texture size, down from 64. This should reduce memory
usage by nearly 50 MB for typical applications.
<!-- end_revert_body -->

Co-authored-by: auto-submit[bot] <flutter-engprod-team@google.com>
 2025-03-25 19:46:47 +00:00
chunhtai
bf6481104d
Revert "Add set semantics enabled API and wire iOS a11y bridge (#1612… (#165901) 
…65)"

This reverts commit 26037dff87ade9d9dee04cc2ef90b3fe5cf0faf3.

<!--
Thanks for filing a pull request!
Reviewers are typically assigned within a week of filing a request.
To learn more about code review, see our documentation on Tree Hygiene:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md
-->

PR causes internal test failures

## Pre-launch Checklist

- [ ] I read the [Contributor Guide] and followed the process outlined
there for submitting PRs.
- [ ] I read the [Tree Hygiene] wiki page, which explains my
responsibilities.
- [ ] I read and followed the [Flutter Style Guide], including [Features
we expect every widget to implement].
- [ ] I signed the [CLA].
- [ ] I listed at least one issue that this PR fixes in the description
above.
- [ ] I updated/added relevant documentation (doc comments with `///`).
- [ ] I added new tests to check the change I am making, or this PR is
[test-exempt].
- [ ] I followed the [breaking change policy] and added [Data Driven
Fixes] where supported.
- [ ] All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel
on [Discord].

<!-- Links -->
[Contributor Guide]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#overview
[Tree Hygiene]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md
[test-exempt]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#tests
[Flutter Style Guide]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md
[Features we expect every widget to implement]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md#features-we-expect-every-widget-to-implement
[CLA]: https://cla.developers.google.com/
[flutter/tests]: https://github.com/flutter/tests
[breaking change policy]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#handling-breaking-changes
[Discord]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Chat.md
[Data Driven Fixes]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Data-driven-Fixes.md
 2025-03-25 18:24:46 +00:00
auto-submit[bot]
8893670e15
Reverts "[Impeller] remove transfer barriers from render pass, drop blit, tighten up graphics on level 3. (#165584)" (#165898) 
<!-- start_original_pr_link -->
Reverts: flutter/flutter#165584
<!-- end_original_pr_link -->
<!-- start_initiating_author -->
Initiated by: jonahwilliams
<!-- end_initiating_author -->
<!-- start_revert_reason -->
Reason for reverting: render pass compatibility issue.
<!-- end_revert_reason -->
<!-- start_original_pr_author -->
Original PR Author: jonahwilliams
<!-- end_original_pr_author -->

<!-- start_reviewers -->
Reviewed By: {gaaclarke}
<!-- end_reviewers -->

<!-- start_revert_body -->
This change reverts the following previous change:
The change to fix PowerVR barriers regressed Mali (see
https://github.com/flutter/flutter/issues/165538)

We need to tighten the barriers to remove the transfer barrier to get
back mali performance. however, this requires us to drop the usage of
the blit for onscreen restore. not a huge loss imo.

At any rate, all of these changes should be visible in benchmarks.
<!-- end_revert_body -->

Co-authored-by: auto-submit[bot] <flutter-engprod-team@google.com>
 2025-03-25 16:40:57 +00:00
Mouad Debbar
b02c436c34
[web] Fix semantic scrollable when there are no scroll actions (#165064) 2025-03-25 15:18:54 +00:00
Jonah Williams
e60822e1a6
[iOS] reduce wide gamut memory by 50% (for onscreen surfaces). (#165601) 
If the onscreen surface is opaque, resolve to an alpha-less wide gamut
format. This reduces the bits per color from 40 to 32, which allows us
to fit in a 32 bit texture size, down from 64. This should reduce memory
usage by nearly 50 MB for typical applications.
 2025-03-25 15:05:06 +00:00
Jonah Williams
33cf3b65bc
[Impeller] remove transfer barriers from render pass, drop blit, tighten up graphics on level 3. (#165584) 
The change to fix PowerVR barriers regressed Mali (see
https://github.com/flutter/flutter/issues/165538)

We need to tighten the barriers to remove the transfer barrier to get
back mali performance. however, this requires us to drop the usage of
the blit for onscreen restore. not a huge loss imo.

At any rate, all of these changes should be visible in benchmarks.
 2025-03-25 15:04:59 +00:00
engine-flutter-autoroll
9774050f90
Roll Fuchsia Linux SDK from Skjlz6df4TA2nmfI2... to Aewmpu7l_HniO7aKQ... (#165863) 
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/fuchsia-linux-sdk-flutter
Please CC jsimmons@google.com,zra@google.com on the revert to ensure
that a human
is aware of the problem.

To file a bug in Flutter:
https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2025-03-25 08:38:17 +00:00
Miguel
3632590f5d
[fuchsia] Roll F26 (#165697) 
Includes a change to:

- Remove LogSink.Connect and handle unknown interactions in mock.
  This method is gone in F26.

Bug: https://fxbug.dev/405407295

## Pre-launch Checklist

- [x] I read the [Contributor Guide] and followed the process outlined
there for submitting PRs.
- [x] I read the [Tree Hygiene] wiki page, which explains my
responsibilities.
- [x] I read and followed the [Flutter Style Guide], including [Features
we expect every widget to implement].
- [x] I signed the [CLA].
- [x] I listed at least one issue that this PR fixes in the description
above.
- [x] I updated/added relevant documentation (doc comments with `///`).
- [x] I added new tests to check the change I am making, or this PR is
[test-exempt].
- [x] I followed the [breaking change policy] and added [Data Driven
Fixes] where supported.
- [x] All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel
on [Discord].

<!-- Links -->
[Contributor Guide]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#overview
[Tree Hygiene]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md
[test-exempt]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#tests
[Flutter Style Guide]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md
[Features we expect every widget to implement]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md#features-we-expect-every-widget-to-implement
[CLA]: https://cla.developers.google.com/
[flutter/tests]: https://github.com/flutter/tests
[breaking change policy]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#handling-breaking-changes
[Discord]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Chat.md
[Data Driven Fixes]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Data-driven-Fixes.md
 2025-03-25 04:29:28 +00:00
engine-flutter-autoroll
c15cb26e32
Roll Dart SDK from 7b1062f9a8df to 31df9f4a0c12 (1 revision) (#165845) 
https://dart.googlesource.com/sdk.git/+log/7b1062f9a8df..31df9f4a0c12

2025-03-24 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com
Version 3.8.0-222.0.dev

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/dart-sdk-flutter
Please CC dart-vm-team@google.com,jsimmons@google.com on the revert to
ensure that a human
is aware of the problem.

To file a bug in Flutter:
https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2025-03-25 01:07:19 +00:00
Jackson Gardner
355129961c
Add debug json mechanism for EngineSceneBuilder. (#165821) 
I added some debugging mechanisms that can help create a minimal test
case more easily:

* In debug mode, you can press `Alt+F10` and the engine will generate a
JSON representation of the most recently rendered scene and download it.
* Added a script called `generate_scene_test.dart` which can take that
JSON and generate a dart file which renders a scene with the identical
hierarchy and layout. All the pictures are rendered as squares with
random-ish colors.
 2025-03-25 00:24:37 +00:00
engine-flutter-autoroll
838515b967
Roll Skia from 9ba7bf8be99d to 271cd2c4b1bd (2 revisions) (#165837) 
https://skia.googlesource.com/skia.git/+log/9ba7bf8be99d..271cd2c4b1bd

2025-03-24 zengyonghust@gmail.com Fix incorrect equality check in
WayRoughlyEqual function. eg. a = (0, 10), b = (0, 100) then largestDiff
will be 0, which will incorrectly judge that a is equal to b.
2025-03-24 kjlubick@google.com Introduce SkRasterPipelineContexts
namespace

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC jsimmons@google.com,kjlubick@google.com,maxhudnell@google.com
on the revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter:
https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2025-03-24 23:26:19 +00:00
engine-flutter-autoroll
844c31a683
Roll Skia from 22f5a70db6b3 to 9ba7bf8be99d (5 revisions) (#165825) 
https://skia.googlesource.com/skia.git/+log/22f5a70db6b3..9ba7bf8be99d

2025-03-24 lehoangquyen@google.com graphite: Use approx sizes for MSAA
textures.
2025-03-24 michaelludwig@google.com Reland "Reland "[graphite] Convert
drawPath to drawPoints for lines""
2025-03-24 robertphillips@google.com Revert "[graphite] Re-enable
Precompilation tests on TSAN"
2025-03-24 skia-autoroll@skia-public.iam.gserviceaccount.com Roll
vulkan-deps from 5ad52bb056fe to acafa2b3b5e2 (2 revisions)
2025-03-24 borenet@google.com [infra] Add jobs for new Chromebooks

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC jsimmons@google.com,kjlubick@google.com,maxhudnell@google.com
on the revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter:
https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2025-03-24 20:59:07 +00:00
chunhtai
26037dff87
Add set semantics enabled API and wire iOS a11y bridge (#161265) 
fixes https://github.com/flutter/flutter/issues/158399

old pr https://github.com/flutter/engine/pull/56691

previously the only correct way to enable semantics is that ios
embedding receive signal from native OS, it call SetSemanticsEnabled to
shell and then to dart to enable semantics tree generation.

If for some reason framework decide to enable semantics first, e.g.
through SemanticsBinding.instance.ensureSemantics(typically due to
integration test or ci that wants to test semantics), the update will be
dropped in shell. Even if it later on receive signal from native OS to
turn on semantics, it can't construct the complete accessibility tree in
embedding because the updatesemantics sends diff update and previous
updates are gone forever. It will end up in a broken state.

This pr changes so that the only source of truth will be in the
framework side. When framework starts generating the the semantics tree,
it will call SetSemanticsTreeEnabled through dart:ui, and the embedding
needs to prepare itself to accept semantics update after receiving the
message.

This however require some refactoring on iOS embedding because it will
only create a11y bridge when receiving OS notification when assitive
technologies turns on.

This requires three phase transition

add an empty dart:ui API setSemanticsTreeEnabled
makes framework calls the empty API.
merge this pr with actual implementation of setSemanticsTreeEnabled

I will do the android part in a separate pr


## Pre-launch Checklist

- [ ] I read the [Contributor Guide] and followed the process outlined
there for submitting PRs.
- [ ] I read the [Tree Hygiene] wiki page, which explains my
responsibilities.
- [ ] I read and followed the [Flutter Style Guide], including [Features
we expect every widget to implement].
- [ ] I signed the [CLA].
- [ ] I listed at least one issue that this PR fixes in the description
above.
- [ ] I updated/added relevant documentation (doc comments with `///`).
- [ ] I added new tests to check the change I am making, or this PR is
[test-exempt].
- [ ] I followed the [breaking change policy] and added [Data Driven
Fixes] where supported.
- [ ] All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel
on [Discord].

<!-- Links -->
[Contributor Guide]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#overview
[Tree Hygiene]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md
[test-exempt]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#tests
[Flutter Style Guide]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md
[Features we expect every widget to implement]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md#features-we-expect-every-widget-to-implement
[CLA]: https://cla.developers.google.com/
[flutter/tests]: https://github.com/flutter/tests
[breaking change policy]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#handling-breaking-changes
[Discord]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Chat.md
[Data Driven Fixes]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Data-driven-Fixes.md
 2025-03-24 20:11:13 +00:00
engine-flutter-autoroll
85235a41f6
Roll Dart SDK from e00a58dc8fe7 to 7b1062f9a8df (1 revision) (#165823) 
https://dart.googlesource.com/sdk.git/+log/e00a58dc8fe7..7b1062f9a8df

2025-03-24 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com
Version 3.8.0-221.0.dev

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/dart-sdk-flutter
Please CC dart-vm-team@google.com,jsimmons@google.com on the revert to
ensure that a human
is aware of the problem.

To file a bug in Flutter:
https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2025-03-24 19:50:17 +00:00
Yegor
e717b6c30e
[web] skip image_to_byte_data_test.dart in Firefox (#165678) 
Most of our tests that need graphics already skip Firefox. This test
somehow was lucky enough to pass in Firefox until the latest Ubuntu
upgrade. It is finally failing as expected, so skipping.

Co-authored-by: Kevin Moore <kevmoo@users.noreply.github.com>
 2025-03-24 17:44:04 +00:00
gaaclarke
84cd384682
Implements anti-aliased lines (#164734) 
issue: https://github.com/flutter/flutter/issues/138682
design doc:
https://docs.google.com/document/d/19I6ToHCMlSgSava-niFWzMLGJEAd-rYiBQEGOMu8IJg/edit?tab=t.0

This puts an experimental line drawing approach behind the following
flags:
  - iOS: `FLTAntialiasLines` boolean, default NO
- Android: `io.flutter.embedding.android.ImpellerAntialiasLines`
boolean, default false

Right now they just support DrawLines and don't support line caps.

A test was added that works as a playground for vulkan, opengles and
metal. Only the Metal version was turned into a golden test though here.

## Pre-launch Checklist

- [x] I read the [Contributor Guide] and followed the process outlined
there for submitting PRs.
- [x] I read the [Tree Hygiene] wiki page, which explains my
responsibilities.
- [x] I read and followed the [Flutter Style Guide], including [Features
we expect every widget to implement].
- [x] I signed the [CLA].
- [x] I listed at least one issue that this PR fixes in the description
above.
- [x] I updated/added relevant documentation (doc comments with `///`).
- [x] I added new tests to check the change I am making, or this PR is
[test-exempt].
- [x] I followed the [breaking change policy] and added [Data Driven
Fixes] where supported.
- [x] All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel
on [Discord].

<!-- Links -->
[Contributor Guide]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#overview
[Tree Hygiene]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md
[test-exempt]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#tests
[Flutter Style Guide]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md
[Features we expect every widget to implement]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md#features-we-expect-every-widget-to-implement
[CLA]: https://cla.developers.google.com/
[flutter/tests]: https://github.com/flutter/tests
[breaking change policy]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#handling-breaking-changes
[Discord]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Chat.md
[Data Driven Fixes]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Data-driven-Fixes.md
 2025-03-24 17:32:11 +00:00
hellohuanlin
4cb18b3e21
[ios][pv]fix platform view crash due to screenScale=0 (#165525) 
This is a regression introduced by:
https://github.com/flutter/flutter/pull/162785/files#diff-b08b98ecaa5bd434f8b4181793f2dad9389c32c5b8cdedb52b01a2d3355f51a9R26

It's reported by one of the customers. We are not able to reproduce it. 

It's likely that `flutterView` itself is `nil` (rather than
`flutterView.screen` being `nil`), because we reset `flutterView` when
backgrounding the app

*List which issues are fixed by this PR. You must list at least one
issue. An issue is not required if the PR fixes something trivial like a
typo.*

b/403598670

*If you had to change anything in the [flutter/tests] repo, include a
link to the migration guide as per the [breaking change policy].*

## Pre-launch Checklist

- [x] I read the [Contributor Guide] and followed the process outlined
there for submitting PRs.
- [x] I read the [Tree Hygiene] wiki page, which explains my
responsibilities.
- [x] I read and followed the [Flutter Style Guide], including [Features
we expect every widget to implement].
- [x] I signed the [CLA].
- [x] I listed at least one issue that this PR fixes in the description
above.
- [x] I updated/added relevant documentation (doc comments with `///`).
- [x] I added new tests to check the change I am making, or this PR is
[test-exempt].
- [x] I followed the [breaking change policy] and added [Data Driven
Fixes] where supported.
- [x] All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel
on [Discord].

<!-- Links -->
[Contributor Guide]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#overview
[Tree Hygiene]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md
[test-exempt]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#tests
[Flutter Style Guide]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md
[Features we expect every widget to implement]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md#features-we-expect-every-widget-to-implement
[CLA]: https://cla.developers.google.com/
[flutter/tests]: https://github.com/flutter/tests
[breaking change policy]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#handling-breaking-changes
[Discord]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Chat.md
[Data Driven Fixes]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Data-driven-Fixes.md
 2025-03-24 17:32:11 +00:00
Jackson Gardner
b34ad4acf0
[skwasm] Fix clip rect occlusion rect calculation. (#165446) 
The clip region is always expressed in the global coordinates. Hence, we
should do the intersection with the clip *after* transforming the
rectangle to global coordinates.

This fixes https://github.com/dart-lang/sdk/issues/59993

---------

Co-authored-by: Mouad Debbar <mouad.debbar@gmail.com>
 2025-03-24 16:55:08 +00:00
Jason Simmons
08d2703016
Roll libcxx to bd557f6f (#165621) 
Changes required for this roll:
* addition of LLVM libc (which is now a dependency of libcxx)
* updates the to license script
* patching the verify_exported check to allow some symbols added by
libcxx
* annotations for clang-tidy warnings
 2025-03-24 15:39:26 +00:00
engine-flutter-autoroll
7b0be2e57e
Roll Dart SDK from 13e950e67c2a to e00a58dc8fe7 (1 revision) (#165791) 
https://dart.googlesource.com/sdk.git/+log/13e950e67c2a..e00a58dc8fe7

2025-03-24 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com
Version 3.8.0-220.0.dev

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/dart-sdk-flutter
Please CC dart-vm-team@google.com,jsimmons@google.com on the revert to
ensure that a human
is aware of the problem.

To file a bug in Flutter:
https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2025-03-24 14:34:27 +00:00
engine-flutter-autoroll
3dad107b35
Roll Fuchsia Linux SDK from Btjuc6db5cj3okKa5... to Skjlz6df4TA2nmfI2... (#165772) 
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/fuchsia-linux-sdk-flutter
Please CC jsimmons@google.com,zra@google.com on the revert to ensure
that a human
is aware of the problem.

To file a bug in Flutter:
https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2025-03-24 05:58:25 +00:00
engine-flutter-autoroll
f8c1f3cccc
Roll Fuchsia Linux SDK from zb7ddt_3LqBcDg5_U... to Btjuc6db5cj3okKa5... (#165760) 
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/fuchsia-linux-sdk-flutter
Please CC jsimmons@google.com,zra@google.com on the revert to ensure
that a human
is aware of the problem.

To file a bug in Flutter:
https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2025-03-23 03:48:24 +00:00
engine-flutter-autoroll
6f6cc0a0fb
Roll Skia from 47c46a0a97c9 to d13c2682e1d8 (1 revision) (#165746) 
https://skia.googlesource.com/skia.git/+log/47c46a0a97c9..d13c2682e1d8

2025-03-22 bungeman@google.com Ensure cmap glyph in range in
getGlyphToUnicodeMap

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC jsimmons@google.com,jvanverth@google.com,kjlubick@google.com
on the revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter:
https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2025-03-22 16:52:27 +00:00
engine-flutter-autoroll
bb81a93d75
Roll Dart SDK from 41a60009ed5c to 13e950e67c2a (2 revisions) (#165738) 
https://dart.googlesource.com/sdk.git/+log/41a60009ed5c..13e950e67c2a

2025-03-22 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com
Version 3.8.0-219.0.dev
2025-03-22 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com
Version 3.8.0-218.0.dev

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/dart-sdk-flutter
Please CC dart-vm-team@google.com,jsimmons@google.com on the revert to
ensure that a human
is aware of the problem.

To file a bug in Flutter:
https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2025-03-22 11:00:01 +00:00
Hannah Jin
efa81a7af6
Reland #163662 [web][a11y]Delete _childContainerElement (#165434) 
Reland #163662  with some changes 
1. when a node's role changes and reparenting it, append children to it
 2. Merge optimization from /pull/165352  


fix: https://github.com/flutter/flutter/issues/45205 
## Pre-launch Checklist

- [ ] I read the [Contributor Guide] and followed the process outlined
there for submitting PRs.
- [ ] I read the [Tree Hygiene] wiki page, which explains my
responsibilities.
- [ ] I read and followed the [Flutter Style Guide], including [Features
we expect every widget to implement].
- [ ] I signed the [CLA].
- [ ] I listed at least one issue that this PR fixes in the description
above.
- [ ] I updated/added relevant documentation (doc comments with `///`).
- [ ] I added new tests to check the change I am making, or this PR is
[test-exempt].
- [ ] I followed the [breaking change policy] and added [Data Driven
Fixes] where supported.
- [ ] All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel
on [Discord].

<!-- Links -->
[Contributor Guide]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#overview
[Tree Hygiene]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md
[test-exempt]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#tests
[Flutter Style Guide]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md
[Features we expect every widget to implement]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md#features-we-expect-every-widget-to-implement
[CLA]: https://cla.developers.google.com/
[flutter/tests]: https://github.com/flutter/tests
[breaking change policy]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#handling-breaking-changes
[Discord]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Chat.md
[Data Driven Fixes]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Data-driven-Fixes.md
 2025-03-22 03:38:20 +00:00
engine-flutter-autoroll
66df85a254
Roll Dart SDK from c929e6d3d08f to 41a60009ed5c (7 revisions) (#165730) 
https://dart.googlesource.com/sdk.git/+log/c929e6d3d08f..41a60009ed5c

2025-03-22 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com
Version 3.8.0-217.0.dev
2025-03-21 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com
Version 3.8.0-216.0.dev
2025-03-21 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com
Version 3.8.0-215.0.dev
2025-03-21 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com
Version 3.8.0-214.0.dev
2025-03-21 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com
Version 3.8.0-213.0.dev
2025-03-20 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com
Version 3.8.0-212.0.dev
2025-03-20 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com
Version 3.8.0-211.0.dev

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/dart-sdk-flutter
Please CC dart-vm-team@google.com,jsimmons@google.com on the revert to
ensure that a human
is aware of the problem.

To file a bug in Flutter:
https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2025-03-22 02:52:07 +00:00
Jonah Williams
31ff6497f1
Reland: [Impeller] add a configuration option that allows defering all PSO construction until needed. (#165622) 
The cost of bootstapping the initial PSOs can regress cold startup time
for customer money. As an experiment, attempt to defer PSO construction
to skia like.

---------

Co-authored-by: Aaron Clarke <aaclarke@google.com>
Co-authored-by: gaaclarke <30870216+gaaclarke@users.noreply.github.com>
 2025-03-22 01:34:05 +00:00
engine-flutter-autoroll
a4b982738e
Roll Skia from e1f426dad46d to d54c36d6edd7 (15 revisions) (#165721) 
https://skia.googlesource.com/skia.git/+log/e1f426dad46d..d54c36d6edd7

2025-03-21 egdaniel@google.com Revert "Reland "Fix need query for
copyOnWrite for dual-proxies Ganesh images.""
2025-03-21 kjlubick@google.com Clarify RasterPipeline API for stages
2025-03-21 michaelludwig@google.com [graphite] Fix swapchain creation
for BGRA_SRGB
2025-03-21 skia-autoroll@skia-public.iam.gserviceaccount.com Roll
vulkan-deps from eaa43b73e162 to 331cd868767f (13 revisions)
2025-03-21 michaelludwig@google.com Fix GPU_TEST_UTILS regex in
PRESUBMIT.py
2025-03-21 skia-autoroll@skia-public.iam.gserviceaccount.com Roll
vulkan-deps from 687c1fb080fa to eaa43b73e162 (8 revisions)
2025-03-20 jvanverth@google.com [graphite] Pull ClipAtlas's DrawAtlas
management into private class.
2025-03-20 jlavrova@google.com Fixes for Bidi API in CanvasKit
2025-03-20 skia-autoroll@skia-public.iam.gserviceaccount.com Roll
vulkan-deps from 1bec8a448930 to 687c1fb080fa (5 revisions)
2025-03-20 lukasza@chromium.org [rust png] Reland: Tweak mapping Skia
`CompressionLevel` to `png` API.
2025-03-20 jvanverth@google.com [graphite] Restore compute SkSL tests.
2025-03-20 kjlubick@google.com Move Mac11 jobs onto Mac14 machines
2025-03-20 skia-autoroll@skia-public.iam.gserviceaccount.com Roll
SwiftShader from 27b44046a577 to 76ce2c6def3d (1 revision)
2025-03-20 skia-autoroll@skia-public.iam.gserviceaccount.com Roll Dawn
from dfc82bb1097a to b9b83d3a1dc7 (16 revisions)
2025-03-20 skia-autoroll@skia-public.iam.gserviceaccount.com Roll
vulkan-deps from 6737c973130b to 1bec8a448930 (12 revisions)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC jsimmons@google.com,jvanverth@google.com,kjlubick@google.com
on the revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter:
https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2025-03-22 01:34:05 +00:00
engine-flutter-autoroll
8c5bbf2931
Roll Fuchsia Linux SDK from y-WmESARBN4BZF0gs... to zb7ddt_3LqBcDg5_U... (#165711) 
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/fuchsia-linux-sdk-flutter
Please CC jsimmons@google.com,zra@google.com on the revert to ensure
that a human
is aware of the problem.

To file a bug in Flutter:
https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2025-03-22 01:32:10 +00:00
auto-submit[bot]
9164e2332e
Reverts "Moving Linux linux_unopt for tree greeness (#165694)" (#165705) 
<!-- start_original_pr_link -->
Reverts: flutter/flutter#165694
<!-- end_original_pr_link -->
<!-- start_initiating_author -->
Initiated by: jtmcdole
<!-- end_initiating_author -->
<!-- start_revert_reason -->
Reason for reverting: bot is green (no, really, this specific bot is
green).
<!-- end_revert_reason -->
<!-- start_original_pr_author -->
Original PR Author: jtmcdole
<!-- end_original_pr_author -->

<!-- start_reviewers -->
Reviewed By: {matanlurey}
<!-- end_reviewers -->

<!-- start_revert_body -->
This change reverts the following previous change:
Unknown how many more changes are needed to make the tree go green and
close out #163012.

<!-- end_revert_body -->

Co-authored-by: auto-submit[bot] <flutter-engprod-team@google.com>
 2025-03-21 21:44:25 +00:00
John "codefu" McDole
97bdde5f74
Moving Linux linux_unopt for tree greeness (#165694) 
Unknown how many more changes are needed to make the tree go green and
close out #163012.
 2025-03-21 20:01:59 +00:00
Jason Simmons
bfe880363e
Fix pylint warning in run_tests.py (#165692) 2025-03-21 19:35:49 +00:00
Jason Simmons
d3571a28a1
Remove the path_ops library test from the run_tests script (#165675) 
This test was not running previously on the Linux builder, but it
started running again when ASAN was disabled due to the Ubuntu 24
upgrade on LUCI. The test is not currently functioning as intended and
needs to be disabled until the Ubuntu upgrade is stable.

See https://github.com/flutter/flutter/pull/165661
 2025-03-21 17:36:44 +00:00
John "codefu" McDole
b6921e1895
Mark Linux linux_web_engine as bringup (#165665) 
After upgrading Ubuntu to 24.04, these tests started flaking.
 2025-03-21 15:38:08 +00:00
Jason Simmons
5a8d4032e9
Disable the address sanitizer in the linux_unopt build (#165661) 
This is causing issues on LUCI workers that were upgraded to a new
version of Ubuntu.

See https://github.com/flutter/flutter/issues/165594
See https://github.com/flutter/flutter/pull/165620
 2025-03-21 15:02:51 +00:00
Jonah Williams
8b49f4d4f0
disable linux lsan. (#165620) 
With the ubuntu upgrade, everything is leaking now.
 2025-03-21 01:36:47 +00:00
auto-submit[bot]
0158281d6e
Reverts "[Impeller] add a configuration option that allows defering all PSO construction until needed. (#165261)" (#165619) 
<!-- start_original_pr_link -->
Reverts: flutter/flutter#165261
<!-- end_original_pr_link -->
<!-- start_initiating_author -->
Initiated by: jonahwilliams
<!-- end_initiating_author -->
<!-- start_revert_reason -->
Reason for reverting: bork the tree
<!-- end_revert_reason -->
<!-- start_original_pr_author -->
Original PR Author: jonahwilliams
<!-- end_original_pr_author -->

<!-- start_reviewers -->
Reviewed By: {gaaclarke}
<!-- end_reviewers -->

<!-- start_revert_body -->
This change reverts the following previous change:
The cost of bootstapping the initial PSOs can regress cold startup time
for customer money. As an experiment, attempt to defer PSO construction
to skia like.
<!-- end_revert_body -->

Co-authored-by: auto-submit[bot] <flutter-engprod-team@google.com>
 2025-03-21 00:17:47 +00:00
Jonah Williams
cab4fe33c3
[Impeller] add a configuration option that allows defering all PSO construction until needed. (#165261) 
The cost of bootstapping the initial PSOs can regress cold startup time
for customer money. As an experiment, attempt to defer PSO construction
to skia like.

---------

Co-authored-by: Aaron Clarke <aaclarke@google.com>
Co-authored-by: gaaclarke <30870216+gaaclarke@users.noreply.github.com>
 2025-03-20 21:06:09 +00:00
Chinmay Garde
2db84b20f9
[Impeller] libImpeller: Expose APIs to draw shadows. (#165517) 
Fixes https://github.com/flutter/flutter/issues/165146
 2025-03-20 17:28:00 +00:00
Matthew Kosarek
554c814ada
(#112207) Adding view_id parameter to DispatchSemanticsAction and UpdateSemantics (#164577) 
fixes #112207

## What's new?
- Added a `view_id` on `UpdateSemantics`
- Added a `view_id` on `DispatchSemanticsAction`
- Piped the `view_id` all over creation
- Updated tests for these actions across the different platforms
- Added `FlutterEngineSendSemanticsAction` to the embedder API in order
to not break `FlutterEngineDispatchSemanticsAction`
- Using this view ID properly on the Windows platform (see
`engine/src/flutter/shell/platform/windows/flutter_windows_engine.cc`)

## How to test
1. Checkout
[foundation-plus-framework](https://github.com/canonical/flutter/pull/36)
from canonical/flutter
2. Merge this branch into it
3. Enable the "Narrator" screen reader on windows
4. Run the Multi window reference app (see
[PR](https://github.com/canonical/flutter/pull/36) for details)
5. Open up another window, and note that the right buttons and things
are being highlighted, as the screenreader would expect 🎉

## Pre-launch Checklist
- [x] I read the [Contributor Guide] and followed the process outlined
there for submitting PRs.
- [x] I read the [Tree Hygiene] wiki page, which explains my
responsibilities.
- [x] I read and followed the [Flutter Style Guide], including [Features
we expect every widget to implement].
- [x] I signed the [CLA].
- [x] I listed at least one issue that this PR fixes in the description
above.
- [x] I updated/added relevant documentation (doc comments with `///`).
- [x] I added new tests to check the change I am making, or this PR is
[test-exempt].
- [x] I followed the [breaking change policy] and added [Data Driven
Fixes] where supported.
- [x] All existing and new tests are passing.
 2025-03-20 16:30:07 +00:00
engine-flutter-autoroll
7f2064cda1
Roll Dart SDK from 6cece361df65 to c929e6d3d08f (2 revisions) (#165568) 
https://dart.googlesource.com/sdk.git/+log/6cece361df65..c929e6d3d08f

2025-03-20 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com
Version 3.8.0-210.0.dev
2025-03-20 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com
Version 3.8.0-209.0.dev

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/dart-sdk-flutter
Please CC dart-vm-team@google.com,jsimmons@google.com on the revert to
ensure that a human
is aware of the problem.

To file a bug in Flutter:
https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2025-03-20 15:54:32 +00:00
Jim Graham
e6fbc63d37
[Impeller][DisplayList] Consolidate BlendMode definitions (#165450) 
The 2 enum classes `impeller::BlendMode` and `flutter::DlBlendMode` were
essentially identical so they were merged.

The names were consolidated to the ui.BlendMode/DlBlendMode versions and
the implementation is shared from Impeller to DisplayList via a `using`
directive. No conversion is needed any more to describe blend modes
between DisplayList and Impeller.
 2025-03-20 05:34:06 +00:00
engine-flutter-autoroll
75b9a25fc2
Roll Fuchsia Linux SDK from nvix6F7GN9Q4nLH2Z... to y-WmESARBN4BZF0gs... (#165534) 
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/fuchsia-linux-sdk-flutter
Please CC jsimmons@google.com,zra@google.com on the revert to ensure
that a human
is aware of the problem.

To file a bug in Flutter:
https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2025-03-20 02:40:35 +00:00
engine-flutter-autoroll
57bde858cd
Roll Dart SDK from fab994cca421 to 6cece361df65 (1 revision) (#165532) 
https://dart.googlesource.com/sdk.git/+log/fab994cca421..6cece361df65

2025-03-19 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com
Version 3.8.0-208.0.dev

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/dart-sdk-flutter
Please CC dart-vm-team@google.com,jsimmons@google.com on the revert to
ensure that a human
is aware of the problem.

To file a bug in Flutter:
https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2025-03-20 02:12:34 +00:00
ash2moon
ecbb115ae3
deprecate Android announcement events and add deprecation warning. (#165195) 
Due to this [Android
deprecation](https://developer.android.com/reference/android/view/View#announceForAccessibility(java.lang.CharSequence))
Flutter needs to show deprecation warnings to developers when using
announce on Android.

Unfortunately testing this log statement is impossible since robolectric
currently does not support API >=36.
https://github.com/flutter/flutter/issues/165220 will add the test code
in once robolectric supports 36.

## Pre-launch Checklist

- [x] I read the [Contributor Guide] and followed the process outlined
there for submitting PRs.
- [x] I read the [Tree Hygiene] wiki page, which explains my
responsibilities.
- [x] I read and followed the [Flutter Style Guide], including [Features
we expect every widget to implement].
- [x] I signed the [CLA].
- [x] I listed at least one issue that this PR fixes in the description
above.
- [x] I updated/added relevant documentation (doc comments with `///`).
- [x] I added new tests to check the change I am making, or this PR is
[test-exempt].
- [x] I followed the [breaking change policy] and added [Data Driven
Fixes] where supported.
- [x] All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel
on [Discord].

<!-- Links -->
[Contributor Guide]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#overview
[Tree Hygiene]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md
[test-exempt]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#tests
[Flutter Style Guide]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md
[Features we expect every widget to implement]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md#features-we-expect-every-widget-to-implement
[CLA]: https://cla.developers.google.com/
[flutter/tests]: https://github.com/flutter/tests
[breaking change policy]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#handling-breaking-changes
[Discord]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Chat.md
[Data Driven Fixes]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Data-driven-Fixes.md
 2025-03-19 23:42:18 +00:00
Jonah Williams
125a2b749e
[Impeller] fix barriers on PowerVR hardware / ensure Render pass cached on non-MSAA. (#165497) 
Work towards https://github.com/flutter/flutter/issues/162033

- barriers for render pass are not correct, but only causes a problem on
powervr/imagination. Added new external subpass dependencies that have
better descriptions for what they do. We now use the subpass to
transition images that are sampled to the final shaderReadOnlylayout,
while keeping swapchain images in eGeneral.

- missing cache for render pass objects when using non-msaa passes. This
mostly impacts powervr hardware because render pass construction is much
slower there.
 2025-03-19 23:31:04 +00:00
engine-flutter-autoroll
a7a3f55ccd
Roll Skia from dbfd72770bdd to e1f426dad46d (1 revision) (#165518) 
https://skia.googlesource.com/skia.git/+log/dbfd72770bdd..e1f426dad46d

2025-03-19 bungeman@google.com Do not create nullptr SkTypeface_proxy

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC jsimmons@google.com,jvanverth@google.com,kjlubick@google.com
on the revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter:
https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2025-03-19 21:09:16 +00:00
engine-flutter-autoroll
ff6ce3fb9b
Roll Dart SDK from cef5d9bd7616 to fab994cca421 (1 revision) (#165516) 
https://dart.googlesource.com/sdk.git/+log/cef5d9bd7616..fab994cca421

2025-03-19 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com
Version 3.8.0-207.0.dev

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/dart-sdk-flutter
Please CC dart-vm-team@google.com,jsimmons@google.com on the revert to
ensure that a human
is aware of the problem.

To file a bug in Flutter:
https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2025-03-19 20:49:07 +00:00