Kishan Rathore
4a6965c4e6
Docs: Update date picker theme day color properties doc ( #166122 )
...
Docs: Update date picker theme day color properties doc
fixes : #161052
Part 2 of #164972
## Pre-launch Checklist
- [x] I read the [Contributor Guide] and followed the process outlined
there for submitting PRs.
- [x] I read the [Tree Hygiene] wiki page, which explains my
responsibilities.
- [x] I read and followed the [Flutter Style Guide], including [Features
we expect every widget to implement].
- [x] I signed the [CLA].
- [x] I listed at least one issue that this PR fixes in the description
above.
- [x] I updated/added relevant documentation (doc comments with `///`).
- [x] I added new tests to check the change I am making, or this PR is
[test-exempt].
- [x] I followed the [breaking change policy] and added [Data Driven
Fixes] where supported.
- [x] All existing and new tests are passing.
---------
Co-authored-by: Qun Cheng <36861262+QuncCccccc@users.noreply.github.com>
2025-04-18 22:50:08 +00:00
Matt Boetger
c74cd04dbb
Add ktlint test for generated files from templates ( #167378 )
...
Creates a new test in analyze.dart that will generate kotlin files from
.kt.tmpl and .kts.tmpl files and then run ktlint on them.
Fixes : #166497
## Pre-launch Checklist
- [X] I read the [Contributor Guide] and followed the process outlined
there for submitting PRs.
- [X] I read the [Tree Hygiene] wiki page, which explains my
responsibilities.
- [X] I read and followed the [Flutter Style Guide], including [Features
we expect every widget to implement].
- [X] I signed the [CLA].
- [X] I listed at least one issue that this PR fixes in the description
above.
- [X] I updated/added relevant documentation (doc comments with `///`).
- [X] I added new tests to check the change I am making, or this PR is
[test-exempt].
- [X] I followed the [breaking change policy] and added [Data Driven
Fixes] where supported.
- [X] All existing and new tests are passing.
If you need help, consider asking for advice on the #hackers-new channel
on [Discord].
<!-- Links -->
[Contributor Guide]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#overview
[Tree Hygiene]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md
[test-exempt]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#tests
[Flutter Style Guide]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md
[Features we expect every widget to implement]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md#features-we-expect-every-widget-to-implement
[CLA]: https://cla.developers.google.com/
[flutter/tests]: https://github.com/flutter/tests
[breaking change policy]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#handling-breaking-changes
[Discord]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Chat.md
[Data Driven Fixes]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Data-driven-Fixes.md
2025-04-18 22:30:26 +00:00
Loïc Sharma
66ecc88655
Revert "[Windows] Enable merged platform and UI thread by default" ( #167420 )
...
This reverts commit afdc861129d88fa298ab9952c2d8c4dfb2d74ac1.
See: https://github.com/flutter/flutter/issues/167418
2025-04-18 22:13:32 +00:00
Greg Price
c1f6ceb9bb
Add a DrivenScrollActivity.simulation constructor ( #166730 )
...
I'd like to have a scroll activity that drives the scroll view through a
particular animation -- just like a DrivenScrollActivity does -- but
where the animation doesn't have an end point or duration that's known
when the animation begins.
(Concretely, this is to implement a "scroll to the end of history"
button in the Zulip message list. The end point is maxScrollExtent...
except that maxScrollExtent while in the middle of history is only an
estimate, and will change as the list view scrolls through shorter and
longer messages.)
That means the animation is naturally described by a Simulation, but not
by the parameters accepted by the current DrivenScrollActivity
constructor, or by the animateTo method which wraps it.
I think this can be handled quite cleanly with an alternate constructor
on DrivenScrollActivity, one that accepts a Simulation instead of the
from/to/duration/curve parameters accepted by the default constructor.
The new constructor is very similar to the constructor of
BallisticScrollActivity.
Most of the changes here are in revising the docs of both
DrivenScrollActivity and BallisticScrollActivity. The docs had
characterized the difference between the two as about using a Simulation
vs. the from/to/duration/curve animation parameters, but I think that's
never been the most important difference between them: the key
difference is really the `goBallistic` calls in BallisticScrollActivity,
particularly in `applyNewDimensions`, and the implications those have
for how the simulation needs to relate to the scroll physics. So this
rewrites the docs to describe that.
2025-04-18 22:06:24 +00:00
Shay Molcho
d9d9df4a01
Added missing period for consistency and readability ( #162887 )
...
Added a missing period in a specific part of the text to maintain
consistency across the document. This ensures a uniform writing style,
improves readability, and aligns with the formatting used throughout the
content.
<!--
Thanks for filing a pull request!
Reviewers are typically assigned within a week of filing a request.
To learn more about code review, see our documentation on Tree Hygiene:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md
-->
*Replace this paragraph with a description of what this PR is changing
or adding, and why. Consider including before/after screenshots.*
*List which issues are fixed by this PR. You must list at least one
issue. An issue is not required if the PR fixes something trivial like a
typo.*
*If you had to change anything in the [flutter/tests] repo, include a
link to the migration guide as per the [breaking change policy].*
## Pre-launch Checklist
- [ ] I read the [Contributor Guide] and followed the process outlined
there for submitting PRs.
- [ ] I read the [Tree Hygiene] wiki page, which explains my
responsibilities.
- [ ] I read and followed the [Flutter Style Guide], including [Features
we expect every widget to implement].
- [ ] I signed the [CLA].
- [ ] I listed at least one issue that this PR fixes in the description
above.
- [ ] I updated/added relevant documentation (doc comments with `///`).
- [ ] I added new tests to check the change I am making, or this PR is
[test-exempt].
- [ ] I followed the [breaking change policy] and added [Data Driven
Fixes] where supported.
- [ ] All existing and new tests are passing.
If you need help, consider asking for advice on the #hackers-new channel
on [Discord].
<!-- Links -->
[Contributor Guide]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#overview
[Tree Hygiene]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md
[test-exempt]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#tests
[Flutter Style Guide]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md
[Features we expect every widget to implement]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md#features-we-expect-every-widget-to-implement
[CLA]: https://cla.developers.google.com/
[flutter/tests]: https://github.com/flutter/tests
[breaking change policy]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#handling-breaking-changes
[Discord]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Chat.md
[Data Driven Fixes]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Data-driven-Fixes.md
2025-04-18 21:45:16 +00:00
engine-flutter-autoroll
406fb12f6a
Roll Skia from 6c4595124690 to 177a2929e32f (1 revision) ( #167417 )
...
https://skia.googlesource.com/skia.git/+log/6c4595124690..177a2929e32f
2025-04-18 skia-autoroll@skia-public.iam.gserviceaccount.com Manual roll
Dawn from 971cc7345000 to fe0be9e4b4f9 (6 revisions)
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC bwils@google.com ,codefu@google.com,kjlubick@google.com on the
revert to ensure that a human
is aware of the problem.
To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter:
https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2025-04-18 21:02:51 +00:00
LouiseHsu
6f14c960ec
Fix codesigning for Mac_arm64_ios imitation_game_flutter ( #167307 )
...
https://ci.chromium.org/ui/p/flutter/builders/luci.flutter.staging/Mac_arm64_ios%20imitation_game_flutter
The swiftui benchmark has been failing in bring up because the project
wasnt getting correctly codesigned. Also, fixes the fact that I flipped
the naming of imitation_game_flutter and imitation_game_swiftui 😶🌫️
Also removes extraneous targets from the project
https://ci.chromium.org/ui/p/flutter/builders/try.shadow/Mac_arm64_ios%20imitation_game_flutter/14/overview
Tested with `led`, proof that it's working post this PR ^
## Pre-launch Checklist
- [x] I read the [Contributor Guide] and followed the process outlined
there for submitting PRs.
- [x] I read the [Tree Hygiene] wiki page, which explains my
responsibilities.
- [x] I read and followed the [Flutter Style Guide], including [Features
we expect every widget to implement].
- [x] I signed the [CLA].
- [x] I listed at least one issue that this PR fixes in the description
above.
- [x] I updated/added relevant documentation (doc comments with `///`).
- [x] I added new tests to check the change I am making, or this PR is
[test-exempt].
- [x] I followed the [breaking change policy] and added [Data Driven
Fixes] where supported.
- [x] All existing and new tests are passing.
2025-04-18 21:02:51 +00:00
Matan Lurey
7f136e2681
Mark windows_host_engine_test flaky ( #167419 )
...
See https://github.com/flutter/flutter/issues/167418 .
2025-04-18 21:02:42 +00:00
engine-flutter-autoroll
18f7f347c9
Roll Dart SDK from ab60afc99bcb to 0cfefe2a03fb (1 revision) ( #167414 )
...
https://dart.googlesource.com/sdk.git/+log/ab60afc99bcb..0cfefe2a03fb
2025-04-18 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com
Version 3.9.0-32.0.dev
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/dart-sdk-flutter
Please CC codefu@google.com ,dart-vm-team@google.com on the revert to
ensure that a human
is aware of the problem.
To file a bug in Flutter:
https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2025-04-18 20:54:44 +00:00
Yegor
7ca63fadd7
[web] close input connection when window/iframe loses focus ( #166804 )
...
Fixes https://github.com/flutter/flutter/issues/155265
This includes 2 fixes:
* When the window/iframe loses focus, close the text input connection
instead of grabbing the focus again.
* Do not enable semantics using the placeholder when moving focus using
the "Tab" key.
Bonus: remove the no longer necessary `ViewFocusBinding.isEnabled`
(doesn't fix any issues, just a clean-up).
---------
Co-authored-by: Mouad Debbar <mdebbar@google.com>
2025-04-18 17:43:36 +00:00
LouiseHsu
3ed38e2452
Update led docs ( #167380 )
...
Update led docs to include `led edit -pa is_fusion='true'`
## Pre-launch Checklist
- [x] I read the [Contributor Guide] and followed the process outlined
there for submitting PRs.
- [x] I read the [Tree Hygiene] wiki page, which explains my
responsibilities.
- [x] I read and followed the [Flutter Style Guide], including [Features
we expect every widget to implement].
- [x] I signed the [CLA].
- [x] I listed at least one issue that this PR fixes in the description
above.
- [x] I updated/added relevant documentation (doc comments with `///`).
- [x] I added new tests to check the change I am making, or this PR is
[test-exempt].
- [x] I followed the [breaking change policy] and added [Data Driven
Fixes] where supported.
- [x] All existing and new tests are passing.
2025-04-18 17:03:55 +00:00
Jason Simmons
ab7a990dc8
Throw an error if --local-engine-host is used without --local-engine ( #166948 )
...
The artifact selector will only use artifacts from the local engine if
both of these flags are provided.
2025-04-18 17:00:57 +00:00
Reid Baker
f20bc39cc0
Add kotlin compatability to build file validation ( #167143 )
...
Fixes https://github.com/flutter/flutter/issues/161443
* adds a new gradle task like `javaVersion` named `kgpVersion` that
prints the version of kgp.
* adds gradle_utils.dart method for getting kgp version
* * kgp method is moved to utilities and we attempt to use a plugin
method before reflection.
* adds methods or evaluating KGP + gradle and KGP + AGP compatibility.
* * It turns out that we have been using incompatible versions that
happen to work with the subset of kotlin we are using.
* Uses new kgp methods in flutter analyze --suggestions as part of the
existing agp/java/gradle compatibility matrix.
* adds new tests for all new functionality
* Adds comments to sections of the code I found could use them.
* Modifies flutter gallery to use a compatible version of kotlin and
update its lockfiles.
## Pre-launch Checklist
- [x] I read the [Contributor Guide] and followed the process outlined
there for submitting PRs.
- [x] I read the [Tree Hygiene] wiki page, which explains my
responsibilities.
- [x] I read and followed the [Flutter Style Guide], including [Features
we expect every widget to implement].
- [x] I signed the [CLA].
- [x] I listed at least one issue that this PR fixes in the description
above.
- [x] I updated/added relevant documentation (doc comments with `///`).
- [X] I added new tests to check the change I am making, or this PR is
[test-exempt].
- [x] I followed the [breaking change policy] and added [Data Driven
Fixes] where supported.
- [x] All existing and new tests are passing.
2025-04-18 16:32:08 +00:00
engine-flutter-autoroll
d203008741
Roll Skia from 844496884aa0 to 6c4595124690 (2 revisions) ( #167400 )
...
https://skia.googlesource.com/skia.git/+log/844496884aa0..6c4595124690
2025-04-18 skia-autoroll@skia-public.iam.gserviceaccount.com Roll
vulkan-deps from da64cc98aa1f to b61587033344 (1 revision)
2025-04-18 skia-autoroll@skia-public.iam.gserviceaccount.com Roll ANGLE
from a6a7de5aecab to 4b9525b2667f (7 revisions)
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC bwils@google.com ,codefu@google.com,kjlubick@google.com on the
revert to ensure that a human
is aware of the problem.
To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter:
https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2025-04-18 12:39:41 +00:00
Bruno Leroux
7cadbeac6a
Fix CarouselView crashes when initlal viewportDimension is 0.0 ( #167271 )
...
## Description
This PR fixes CarouselView crashes due to viewportDimension being 0.0.
At startup, a warm-up frame can be produced before the Flutter engine
has reported the
initial view metrics. As a result, the first frame can be produced with
a size of zero. In the context of CarouselView this leads to some
problems mainly related to division by zero.
## Related Issue
Fixes https://github.com/flutter/flutter/issues/163436
Fixes https://github.com/flutter/flutter/issues/160679
## Tests
Adds 5 tests.
2025-04-18 12:15:30 +00:00
engine-flutter-autoroll
810024f3c9
Roll Dart SDK from b1eb743f97f5 to ab60afc99bcb (1 revision) ( #167396 )
...
https://dart.googlesource.com/sdk.git/+log/b1eb743f97f5..ab60afc99bcb
2025-04-18 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com
Version 3.9.0-31.0.dev
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/dart-sdk-flutter
Please CC codefu@google.com ,dart-vm-team@google.com on the revert to
ensure that a human
is aware of the problem.
To file a bug in Flutter:
https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2025-04-18 09:41:26 +00:00
Bruno Leroux
8e3e7f4a3e
Add InputDecoration.visualDensity and InputDecorationTheme.visualDensity ( #166834 )
...
## Description
This PR introduces `InputDecoration.visualDensity` and
`InputDecorationTheme.visualDensity`.
See
https://github.com/flutter/flutter/issues/166201#issuecomment-2774622584
for motivation.
## Related Issue
Fixes https://github.com/flutter/flutter/issues/166201
## Tests
Adds 8 tests (4 for filled decoration, 4 for outlined decoration).
2025-04-18 09:23:38 +00:00
engine-flutter-autoroll
b98efa6a31
Roll Skia from acc910544da7 to 844496884aa0 (1 revision) ( #167389 )
...
https://skia.googlesource.com/skia.git/+log/acc910544da7..844496884aa0
2025-04-18 skia-autoroll@skia-public.iam.gserviceaccount.com Roll
SwiftShader from 2d70dae3d0ca to 0e75e7030ccb (1 revision)
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC bwils@google.com ,codefu@google.com,kjlubick@google.com on the
revert to ensure that a human
is aware of the problem.
To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter:
https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2025-04-18 07:21:24 +00:00
engine-flutter-autoroll
b29d7bc42a
Roll Skia from a409d685a711 to acc910544da7 (10 revisions) ( #167388 )
...
https://skia.googlesource.com/skia.git/+log/a409d685a711..acc910544da7
2025-04-18 skia-autoroll@skia-public.iam.gserviceaccount.com Manual roll
Dawn from 33862a3ffc8a to 971cc7345000 (191 revisions)
2025-04-17 skia-autoroll@skia-public.iam.gserviceaccount.com Roll
vulkan-deps from f6ce0375d108 to da64cc98aa1f (7 revisions)
2025-04-17 robertphillips@google.com Fix ChromePrecompileTest for Intel
Macs
2025-04-17 borenet@google.com [infra] Add P30 jobs
2025-04-17 skia-autoroll@skia-public.iam.gserviceaccount.com Roll
skottie-base from 868103199143 to f4a4eee934a3
2025-04-17 skia-autoroll@skia-public.iam.gserviceaccount.com Roll
shaders-base from 64b9cec3c82d to 11837b5a53d7
2025-04-17 skia-autoroll@skia-public.iam.gserviceaccount.com Roll
jsfiddle-base from 05716f858285 to 05b60ca904d9
2025-04-17 skia-autoroll@skia-public.iam.gserviceaccount.com Roll
debugger-app-base from 9e80d6bc5f11 to f59c59370426
2025-04-17 nicolettep@google.com [graphite] Run precompile tests when
making changes to relevant files
2025-04-17 jvanverth@google.com [graphite] Use sk_sp<TextureProxy> for
PathAtlas instead of raw pointer.
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC bwils@google.com ,codefu@google.com,kjlubick@google.com on the
revert to ensure that a human
is aware of the problem.
To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter:
https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2025-04-18 05:02:08 +00:00
engine-flutter-autoroll
40f25c9b19
Roll Dart SDK from 2bb85834e77e to b1eb743f97f5 (2 revisions) ( #167387 )
...
https://dart.googlesource.com/sdk.git/+log/2bb85834e77e..b1eb743f97f5
2025-04-18 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com
Version 3.9.0-30.0.dev
2025-04-17 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com
Version 3.9.0-29.0.dev
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/dart-sdk-flutter
Please CC codefu@google.com ,dart-vm-team@google.com on the revert to
ensure that a human
is aware of the problem.
To file a bug in Flutter:
https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2025-04-18 04:32:31 +00:00
engine-flutter-autoroll
1db4930a43
Roll Fuchsia Linux SDK from m8Aln7fTF_8zy1V9N... to MwYckh5OvwwmIYLx0... ( #167385 )
...
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/fuchsia-linux-sdk-flutter
Please CC codefu@google.com ,zra@google.com on the revert to ensure that
a human
is aware of the problem.
To file a bug in Flutter:
https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2025-04-18 02:06:36 +00:00
engine-flutter-autoroll
99c3d03758
Roll Skia from cc2b57434651 to a409d685a711 (3 revisions) ( #167347 )
...
https://skia.googlesource.com/skia.git/+log/cc2b57434651..a409d685a711
2025-04-17 michaelludwig@google.com Revert "[graphite] Update DrawWriter
to minimize binds by using pending base offsets."
2025-04-17 jvanverth@google.com [graphite] Use sk_sp<TextureProxy> for
ClipAtlas instead of raw pointer.
2025-04-17 skia-autoroll@skia-public.iam.gserviceaccount.com Roll
vulkan-deps from 3bc11f8f2d55 to f6ce0375d108 (4 revisions)
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC bwils@google.com ,codefu@google.com,kjlubick@google.com on the
revert to ensure that a human
is aware of the problem.
To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter:
https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2025-04-17 21:43:48 +00:00
Jason Simmons
c53fdbdf24
Reduce app startup latency by initializing the engine on a separate thread ( #166918 )
...
If settings.merged_platform_ui_thread is set to kMergeAfterLaunch, then
the engine will be started on the UI thread. After engine setup
completes and the Dart isolate is loaded, the UI task runner will be
merged into the platform thread and all future Dart execution will run
on the platform thread.
This makes it possible for other work to run on the platform thread
while the engine starts.
See https://github.com/flutter/flutter/issues/163064
2025-04-17 21:40:08 +00:00
engine-flutter-autoroll
9f4fe843a7
Roll Dart SDK from 992221a362ec to 2bb85834e77e (7 revisions) ( #167361 )
...
https://dart.googlesource.com/sdk.git/+log/992221a362ec..2bb85834e77e
2025-04-17 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com
Version 3.9.0-28.0.dev
2025-04-17 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com
Version 3.9.0-27.0.dev
2025-04-17 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com
Version 3.9.0-26.0.dev
2025-04-16 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com
Version 3.9.0-25.0.dev
2025-04-16 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com
Version 3.9.0-24.0.dev
2025-04-16 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com
Version 3.9.0-23.0.dev
2025-04-16 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com
Version 3.9.0-22.0.dev
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/dart-sdk-flutter
Please CC codefu@google.com ,dart-vm-team@google.com on the revert to
ensure that a human
is aware of the problem.
To file a bug in Flutter:
https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2025-04-17 21:38:52 +00:00
gaaclarke
ffa1891ab8
Added docstring for FilterInput::GetSnapshot ( #167226 )
...
fixes https://github.com/flutter/flutter/issues/137970
## Pre-launch Checklist
- [x] I read the [Contributor Guide] and followed the process outlined
there for submitting PRs.
- [x] I read the [Tree Hygiene] wiki page, which explains my
responsibilities.
- [x] I read and followed the [Flutter Style Guide], including [Features
we expect every widget to implement].
- [x] I signed the [CLA].
- [x] I listed at least one issue that this PR fixes in the description
above.
- [x] I updated/added relevant documentation (doc comments with `///`).
- [x] I added new tests to check the change I am making, or this PR is
[test-exempt].
- [x] I followed the [breaking change policy] and added [Data Driven
Fixes] where supported.
- [x] All existing and new tests are passing.
If you need help, consider asking for advice on the #hackers-new channel
on [Discord].
<!-- Links -->
[Contributor Guide]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#overview
[Tree Hygiene]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md
[test-exempt]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#tests
[Flutter Style Guide]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md
[Features we expect every widget to implement]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md#features-we-expect-every-widget-to-implement
[CLA]: https://cla.developers.google.com/
[flutter/tests]: https://github.com/flutter/tests
[breaking change policy]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#handling-breaking-changes
[Discord]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Chat.md
[Data Driven Fixes]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Data-driven-Fixes.md
2025-04-17 21:38:52 +00:00
gaaclarke
df5dfdba61
adds Entity docstrings ( #167228 )
...
fixes https://github.com/flutter/flutter/issues/144943
## Pre-launch Checklist
- [x] I read the [Contributor Guide] and followed the process outlined
there for submitting PRs.
- [x] I read the [Tree Hygiene] wiki page, which explains my
responsibilities.
- [x] I read and followed the [Flutter Style Guide], including [Features
we expect every widget to implement].
- [x] I signed the [CLA].
- [x] I listed at least one issue that this PR fixes in the description
above.
- [x] I updated/added relevant documentation (doc comments with `///`).
- [x] I added new tests to check the change I am making, or this PR is
[test-exempt].
- [x] I followed the [breaking change policy] and added [Data Driven
Fixes] where supported.
- [x] All existing and new tests are passing.
If you need help, consider asking for advice on the #hackers-new channel
on [Discord].
<!-- Links -->
[Contributor Guide]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#overview
[Tree Hygiene]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md
[test-exempt]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#tests
[Flutter Style Guide]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md
[Features we expect every widget to implement]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md#features-we-expect-every-widget-to-implement
[CLA]: https://cla.developers.google.com/
[flutter/tests]: https://github.com/flutter/tests
[breaking change policy]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#handling-breaking-changes
[Discord]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Chat.md
[Data Driven Fixes]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Data-driven-Fixes.md
2025-04-17 21:38:52 +00:00
gaaclarke
a23e4ca194
fixed impeller golden content scale ( #167308 )
...
fixes https://github.com/flutter/flutter/issues/162036
This fixes the problem my scaling the render texture by the content
scalar. This means locally you'll probably be generating 2048x1536
images. This matches the rendering that is happening in playgrounds. On
CI the content scalar should be one so there is no change there.
## Pre-launch Checklist
- [x] I read the [Contributor Guide] and followed the process outlined
there for submitting PRs.
- [x] I read the [Tree Hygiene] wiki page, which explains my
responsibilities.
- [x] I read and followed the [Flutter Style Guide], including [Features
we expect every widget to implement].
- [x] I signed the [CLA].
- [x] I listed at least one issue that this PR fixes in the description
above.
- [x] I updated/added relevant documentation (doc comments with `///`).
- [x] I added new tests to check the change I am making, or this PR is
[test-exempt].
- [x] I followed the [breaking change policy] and added [Data Driven
Fixes] where supported.
- [x] All existing and new tests are passing.
If you need help, consider asking for advice on the #hackers-new channel
on [Discord].
<!-- Links -->
[Contributor Guide]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#overview
[Tree Hygiene]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md
[test-exempt]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#tests
[Flutter Style Guide]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md
[Features we expect every widget to implement]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md#features-we-expect-every-widget-to-implement
[CLA]: https://cla.developers.google.com/
[flutter/tests]: https://github.com/flutter/tests
[breaking change policy]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#handling-breaking-changes
[Discord]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Chat.md
[Data Driven Fixes]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Data-driven-Fixes.md
2025-04-17 21:37:00 +00:00
gaaclarke
0e4bebffa1
Added docstring for FilterContents::RenderFilter ( #167227 )
...
fixes https://github.com/flutter/flutter/issues/137704
## Pre-launch Checklist
- [x] I read the [Contributor Guide] and followed the process outlined
there for submitting PRs.
- [x] I read the [Tree Hygiene] wiki page, which explains my
responsibilities.
- [x] I read and followed the [Flutter Style Guide], including [Features
we expect every widget to implement].
- [x] I signed the [CLA].
- [x] I listed at least one issue that this PR fixes in the description
above.
- [x] I updated/added relevant documentation (doc comments with `///`).
- [x] I added new tests to check the change I am making, or this PR is
[test-exempt].
- [x] I followed the [breaking change policy] and added [Data Driven
Fixes] where supported.
- [x] All existing and new tests are passing.
If you need help, consider asking for advice on the #hackers-new channel
on [Discord].
<!-- Links -->
[Contributor Guide]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#overview
[Tree Hygiene]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md
[test-exempt]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#tests
[Flutter Style Guide]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md
[Features we expect every widget to implement]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md#features-we-expect-every-widget-to-implement
[CLA]: https://cla.developers.google.com/
[flutter/tests]: https://github.com/flutter/tests
[breaking change policy]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#handling-breaking-changes
[Discord]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Chat.md
[Data Driven Fixes]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Data-driven-Fixes.md
2025-04-17 21:35:41 +00:00
Kishan Rathore
434cb54e77
Feat: Add equality to NoDefaultCupertinoThemeData ( #166655 )
...
Feat: Add equality to NoDefaultCupertinoThemeData
fixes : #165455
## Pre-launch Checklist
- [x] I read the [Contributor Guide] and followed the process outlined
there for submitting PRs.
- [x] I read the [Tree Hygiene] wiki page, which explains my
responsibilities.
- [x] I read and followed the [Flutter Style Guide], including [Features
we expect every widget to implement].
- [x] I signed the [CLA].
- [x] I listed at least one issue that this PR fixes in the description
above.
- [x] I updated/added relevant documentation (doc comments with `///`).
- [x] I added new tests to check the change I am making, or this PR is
[test-exempt].
- [x] I followed the [breaking change policy] and added [Data Driven
Fixes] where supported.
- [x] All existing and new tests are passing.
2025-04-17 21:35:40 +00:00
LinXunFeng
946f952534
Fix link to engine docs ( #167346 )
2025-04-17 21:35:39 +00:00
Matej Knopp
9d3d0dc0ed
[macOS] Enable merged platform and UI thread by default ( #166536 )
...
This enables running UI isolate on platform thread by default.
## Pre-launch Checklist
- [x] I read the [Contributor Guide] and followed the process outlined
there for submitting PRs.
- [x] I read the [Tree Hygiene] wiki page, which explains my
responsibilities.
- [x] I read and followed the [Flutter Style Guide], including [Features
we expect every widget to implement].
- [x] I signed the [CLA].
- [x] I listed at least one issue that this PR fixes in the description
above.
- [x] I updated/added relevant documentation (doc comments with `///`).
- [x] I added new tests to check the change I am making, or this PR is
[test-exempt].
- [x] I followed the [breaking change policy] and added [Data Driven
Fixes] where supported.
- [x] All existing and new tests are passing.
If you need help, consider asking for advice on the #hackers-new channel
on [Discord].
<!-- Links -->
[Contributor Guide]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#overview
[Tree Hygiene]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md
[test-exempt]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#tests
[Flutter Style Guide]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md
[Features we expect every widget to implement]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md#features-we-expect-every-widget-to-implement
[CLA]: https://cla.developers.google.com/
[flutter/tests]: https://github.com/flutter/tests
[breaking change policy]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#handling-breaking-changes
[Discord]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Chat.md
[Data Driven Fixes]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Data-driven-Fixes.md
2025-04-17 15:30:40 +00:00
Matej Knopp
afdc861129
[Windows] Enable merged platform and UI thread by default ( #163726 )
...
This enables running UI isolate on platform thread by default.
## Pre-launch Checklist
- [x] I read the [Contributor Guide] and followed the process outlined
there for submitting PRs.
- [x] I read the [Tree Hygiene] wiki page, which explains my
responsibilities.
- [x] I read and followed the [Flutter Style Guide], including [Features
we expect every widget to implement].
- [x] I signed the [CLA].
- [x] I listed at least one issue that this PR fixes in the description
above.
- [x] I updated/added relevant documentation (doc comments with `///`).
- [x] I added new tests to check the change I am making, or this PR is
[test-exempt].
- [x] I followed the [breaking change policy] and added [Data Driven
Fixes] where supported.
- [x] All existing and new tests are passing.
If you need help, consider asking for advice on the #hackers-new channel
on [Discord].
<!-- Links -->
[Contributor Guide]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#overview
[Tree Hygiene]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md
[test-exempt]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#tests
[Flutter Style Guide]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md
[Features we expect every widget to implement]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md#features-we-expect-every-widget-to-implement
[CLA]: https://cla.developers.google.com/
[flutter/tests]: https://github.com/flutter/tests
[breaking change policy]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#handling-breaking-changes
[Discord]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Chat.md
[Data Driven Fixes]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Data-driven-Fixes.md
---------
Co-authored-by: Loïc Sharma <737941+loic-sharma@users.noreply.github.com>
2025-04-17 15:30:29 +00:00
Matan Lurey
3c247110f7
Update CHANGELOG.md ( #167225 )
...
Add warning about reading this file in tests and builders.
The backend will be updated in
https://github.com/flutter/cocoon/pull/4521 .
2025-04-17 15:19:08 +00:00
Victoria Ashworth
ecabb1a052
Hide error on mDNS registration failure and print warning in flutter attach ( #166782 )
...
Publishing an mDNS service stopped working on macOS 15.4 for the iOS
Simulator. `DNSServiceRegister` always returns a callback with error
code `kDNSServiceErr_PolicyDenied`, as if the user had rejected the
permissions popup (except no popup is ever shown). mDNS is used to
discover the Dart VM when running `flutter attach`.
This PR does not display the error message when `DNSServiceRegister`
fails for iOS Simulators. Instead, it prints a warning if `flutter
attach` takes too long with instructions to either use `--debug-url` or
to run `flutter attach` before running the app.
If `DNSServiceRegister` works again in a future macOS update, mDNS will
continue to work the way it did previously.
Workaround for https://github.com/flutter/flutter/issues/166333 .
## Pre-launch Checklist
- [x] I read the [Contributor Guide] and followed the process outlined
there for submitting PRs.
- [x] I read the [Tree Hygiene] wiki page, which explains my
responsibilities.
- [x] I read and followed the [Flutter Style Guide], including [Features
we expect every widget to implement].
- [x] I signed the [CLA].
- [x] I listed at least one issue that this PR fixes in the description
above.
- [x] I updated/added relevant documentation (doc comments with `///`).
- [x] I added new tests to check the change I am making, or this PR is
[test-exempt].
- [x] I followed the [breaking change policy] and added [Data Driven
Fixes] where supported.
- [x] All existing and new tests are passing.
If you need help, consider asking for advice on the #hackers-new channel
on [Discord].
<!-- Links -->
[Contributor Guide]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#overview
[Tree Hygiene]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md
[test-exempt]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#tests
[Flutter Style Guide]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md
[Features we expect every widget to implement]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md#features-we-expect-every-widget-to-implement
[CLA]: https://cla.developers.google.com/
[flutter/tests]: https://github.com/flutter/tests
[breaking change policy]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#handling-breaking-changes
[Discord]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Chat.md
[Data Driven Fixes]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Data-driven-Fixes.md
2025-04-17 14:20:23 +00:00
Bruno Leroux
fbed8a7194
Add support for language hints in TextFields (Android only) ( #165554 )
...
## Description
This PR adds support for language hints in TextFields.
This is supported only on Android for the moment and the property name,
aka `TextField.hintLocales`, is based on Android's
`EditorInfo.hintLocales` property, see
https://developer.android.com/reference/android/view/inputmethod/EditorInfo#hintLocales .
## Related Issue
Fixes [Support for language hints in
TextFields](https://github.com/flutter/flutter/issues/163698 )
## Tests
Adds 4 tests.
Updates several tests.
2025-04-17 10:58:38 +00:00
engine-flutter-autoroll
6a7428da45
Roll Skia from d8f13372549d to cc2b57434651 (1 revision) ( #167331 )
...
https://skia.googlesource.com/skia.git/+log/d8f13372549d..cc2b57434651
2025-04-17 skia-autoroll@skia-public.iam.gserviceaccount.com Roll ANGLE
from ca0457f68880 to a6a7de5aecab (7 revisions)
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC bwils@google.com ,codefu@google.com,kjlubick@google.com on the
revert to ensure that a human
is aware of the problem.
To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter:
https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2025-04-17 09:08:28 +00:00
Bruno Leroux
eee1cffcee
Add DropdownMenu.restorationId ( #166684 )
...
## Description
This PR introduces `DropdownMenu.restorationId`.
This value is passed to the inner `TextField.restorationId` which is
required to activate the TextField restoration capability.
## Related Issue
Required for https://github.com/flutter/flutter/pull/163721
## Tests
Adds 1 test.
2025-04-17 06:37:01 +00:00
engine-flutter-autoroll
af2e73343a
Roll Skia from 3d6165b70199 to d8f13372549d (14 revisions) ( #167325 )
...
https://skia.googlesource.com/skia.git/+log/3d6165b70199..d8f13372549d
2025-04-16 robertphillips@google.com Revise ChromePrecompileTest
2025-04-16 bungeman@google.com [freetype] Check palette actually found
2025-04-16 skia-autoroll@skia-public.iam.gserviceaccount.com Roll
vulkan-deps from 729a70498186 to 3bc11f8f2d55 (2 revisions)
2025-04-16 vigneshv@google.com SkCrabbyAvifCodec: Use icc profile from
the decoded image
2025-04-16 thomsmit@google.com [graphite] Update DrawWriter to minimize
binds by using pending base offsets.
2025-04-16 faijur.rahman@imagination.corp-partner.google.com img-ddk:
Fix Driver Version Deduction for Unknown ANGLE Backend
2025-04-16 kjlubick@google.com Enforce IWYU on some graphite types
2025-04-16 coldpalelight@gmail.com Fix issue where drawArc loses endcaps
when stroke width is greater than or equal to oval size
2025-04-16 nicolettep@google.com [graphite] Add test to prove Vulkan
shares renderpasses when expected
2025-04-16 kjlubick@google.com Add thread-safe version of
SkResourceCache
2025-04-16 jvanverth@google.com Reland "[graphite] Add ProxyCache
support to RasterPathAtlas."
2025-04-16 jlavrova@google.com Small fix in Unicode CodeUnits API
2025-04-16 skia-autoroll@skia-public.iam.gserviceaccount.com Roll ANGLE
from a3f2545f6bb3 to ca0457f68880 (12 revisions)
2025-04-16 jeongik@google.com Support GL texture for BGRA8 format
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC bwils@google.com ,codefu@google.com,kjlubick@google.com on the
revert to ensure that a human
is aware of the problem.
To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter:
https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2025-04-17 04:44:05 +00:00
jiancheng
c232c70c66
fix(CircularProgressIndicator.adaptive): strokeWidth default value ( #165370 )
...
fix: https://github.com/flutter/flutter/issues/165294
## Pre-launch Checklist
- [x] I read the [Contributor Guide] and followed the process outlined
there for submitting PRs.
- [x] I read the [Tree Hygiene] wiki page, which explains my
responsibilities.
- [x] I read and followed the [Flutter Style Guide], including [Features
we expect every widget to implement].
- [x] I signed the [CLA].
- [x] I listed at least one issue that this PR fixes in the description
above.
- [x] I updated/added relevant documentation (doc comments with `///`).
- [x] I added new tests to check the change I am making, or this PR is
[test-exempt].
- [x] I followed the [breaking change policy] and added [Data Driven
Fixes] where supported.
- [x] All existing and new tests are passing.
2025-04-17 03:56:17 +00:00
Ahmed Elsayed
6b6f49e749
Remove unnecessary builder ( #166623 )
...
The `builder` was needed to access `Focus.of(context)` but it's no
longer needed after https://github.com/flutter/flutter/pull/159472
## Pre-launch Checklist
- [x] I read the [Contributor Guide] and followed the process outlined
there for submitting PRs.
- [x] I read the [Tree Hygiene] wiki page, which explains my
responsibilities.
- [x] I read and followed the [Flutter Style Guide], including [Features
we expect every widget to implement].
- [x] I signed the [CLA].
- [x] I listed at least one issue that this PR fixes in the description
above.
- [x] I updated/added relevant documentation (doc comments with `///`).
- [x] I added new tests to check the change I am making, or this PR is
[test-exempt].
- [x] I followed the [breaking change policy] and added [Data Driven
Fixes] where supported.
- [x] All existing and new tests are passing.
2025-04-17 03:16:12 +00:00
Gray Mackall
4884722b21
Add a gradle_errors.dartentry for missing NDK source.properties file ( #167320 )
...
Adds an error handler for
https://github.com/flutter/flutter/issues/164085 , based on the suggested
workaround.
The only related Android issue I could find is
http://issuetracker.google.com/issues/201557284 , which suggests it is
due to an incorrect path for the NDK within the Android directory, which
means that allowing AGP to re-download would fix the issue. Users also
suggest that doing that fixes the issue in this comment
https://github.com/flutter/flutter/issues/164085#issuecomment-2684252849 ,
so the handler suggests that as the official workaround.
## Pre-launch Checklist
- [x] I read the [Contributor Guide] and followed the process outlined
there for submitting PRs.
- [x] I read the [Tree Hygiene] wiki page, which explains my
responsibilities.
- [x] I read and followed the [Flutter Style Guide], including [Features
we expect every widget to implement].
- [x] I signed the [CLA].
- [x] I listed at least one issue that this PR fixes in the description
above.
- [x] I updated/added relevant documentation (doc comments with `///`).
- [x] I added new tests to check the change I am making, or this PR is
[test-exempt].
- [x] I followed the [breaking change policy] and added [Data Driven
Fixes] where supported.
- [x] All existing and new tests are passing.
If you need help, consider asking for advice on the #hackers-new channel
on [Discord].
<!-- Links -->
[Contributor Guide]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#overview
[Tree Hygiene]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md
[test-exempt]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#tests
[Flutter Style Guide]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md
[Features we expect every widget to implement]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md#features-we-expect-every-widget-to-implement
[CLA]: https://cla.developers.google.com/
[flutter/tests]: https://github.com/flutter/tests
[breaking change policy]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#handling-breaking-changes
[Discord]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Chat.md
[Data Driven Fixes]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Data-driven-Fixes.md
---------
Co-authored-by: Gray Mackall <mackall@google.com>
2025-04-17 03:13:09 +00:00
engine-flutter-autoroll
2391db55b3
Roll Skia from 6627deb65939 to 3d6165b70199 (1 revision) ( #167255 )
...
https://skia.googlesource.com/skia.git/+log/6627deb65939..3d6165b70199
2025-04-16 skia-autoroll@skia-public.iam.gserviceaccount.com Roll
vulkan-deps from 971325a8d446 to 729a70498186 (7 revisions)
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC bwils@google.com ,codefu@google.com,kjlubick@google.com on the
revert to ensure that a human
is aware of the problem.
To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter:
https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2025-04-17 02:04:00 +00:00
engine-flutter-autoroll
83b2f7f57c
Manual roll Dart SDK from 87965ab4864e to 992221a362ec (35 revisions) ( #167243 )
...
Manual roll Dart SDK from 87965ab4864e to 992221a362ec (35 revisions)
Manual roll requested by codefu@google.com
https://dart.googlesource.com/sdk.git/+log/87965ab4864e..992221a362ec
2025-04-15 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com
Version 3.9.0-21.0.dev
2025-04-15 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com
Version 3.9.0-20.0.dev
2025-04-15 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com
Version 3.9.0-19.0.dev
2025-04-15 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com
Version 3.9.0-18.0.dev
2025-04-15 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com
Version 3.9.0-17.0.dev
2025-04-14 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com
Version 3.9.0-16.0.dev
2025-04-14 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com
Version 3.9.0-15.0.dev
2025-04-12 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com
Version 3.9.0-14.0.dev
2025-04-12 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com
Version 3.9.0-13.0.dev
2025-04-11 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com
Version 3.9.0-12.0.dev
2025-04-11 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com
Version 3.9.0-11.0.dev
2025-04-11 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com
Version 3.9.0-10.0.dev
2025-04-11 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com
Version 3.9.0-9.0.dev
2025-04-11 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com
Version 3.9.0-8.0.dev
2025-04-11 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com
Version 3.9.0-7.0.dev
2025-04-10 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com
Version 3.9.0-6.0.dev
2025-04-10 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com
Version 3.9.0-5.0.dev
2025-04-10 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com
Version 3.9.0-4.0.dev
2025-04-10 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com
Version 3.9.0-3.0.dev
2025-04-09 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com
Version 3.9.0-2.0.dev
2025-04-09 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com
Version 3.9.0-1.0.dev
2025-04-09 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com
Version 3.9.0-0.0.dev
2025-04-08 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com
Version 3.8.0-278.0.dev
2025-04-07 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com
Version 3.8.0-277.0.dev
2025-04-07 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com
Version 3.8.0-276.0.dev
2025-04-07 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com
Version 3.8.0-275.0.dev
2025-04-07 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com
Version 3.8.0-274.0.dev
2025-04-07 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com
Version 3.8.0-273.0.dev
2025-04-06 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com
Version 3.8.0-272.0.dev
2025-04-05 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com
Version 3.8.0-271.0.dev
2025-04-05 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com
Version 3.8.0-270.0.dev
2025-04-04 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com
Version 3.8.0-269.0.dev
2025-04-04 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com
Version 3.8.0-268.0.dev
2025-04-04 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com
Version 3.8.0-267.0.dev
2025-04-04 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com
Version 3.8.0-266.0.dev
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/dart-sdk-flutter
Please CC codefu@google.com ,dart-vm-team@google.com on the revert to
ensure that a human
is aware of the problem.
To file a bug in Flutter:
https://github.com/flutter/flutter/issues/new/choose
...
Co-authored-by: Siva <a-siva@users.noreply.github.com>
2025-04-17 00:31:14 +00:00
engine-flutter-autoroll
b747aeeb1f
Roll Fuchsia Linux SDK from 7bWzHwIPBTyU6R9nO... to m8Aln7fTF_8zy1V9N... ( #167312 )
...
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/fuchsia-linux-sdk-flutter
Please CC codefu@google.com ,zra@google.com on the revert to ensure that
a human
is aware of the problem.
To file a bug in Flutter:
https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2025-04-16 23:57:14 +00:00
Victoria Ashworth
e841350bfc
Don't throw on error for mDNS when searching for Dart VML url on core devices ( #167135 )
...
When we discover the Dart VM for iOS Core Devices (iOS 17+), we use both
the device logs and mDNS simultaneously. Since mDNS is having issues
with macOS 15, don't throw if mDNS errors - this will allow the Dart VM
to have a chance to be found by the device logs instead.
Improving experience for
https://github.com/flutter/flutter/issues/150131 .
Also should unblock https://github.com/flutter/flutter/issues/166843 .
## Pre-launch Checklist
- [x] I read the [Contributor Guide] and followed the process outlined
there for submitting PRs.
- [x] I read the [Tree Hygiene] wiki page, which explains my
responsibilities.
- [x] I read and followed the [Flutter Style Guide], including [Features
we expect every widget to implement].
- [x] I signed the [CLA].
- [x] I listed at least one issue that this PR fixes in the description
above.
- [x] I updated/added relevant documentation (doc comments with `///`).
- [x] I added new tests to check the change I am making, or this PR is
[test-exempt].
- [x] I followed the [breaking change policy] and added [Data Driven
Fixes] where supported.
- [x] All existing and new tests are passing.
If you need help, consider asking for advice on the #hackers-new channel
on [Discord].
<!-- Links -->
[Contributor Guide]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#overview
[Tree Hygiene]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md
[test-exempt]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#tests
[Flutter Style Guide]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md
[Features we expect every widget to implement]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md#features-we-expect-every-widget-to-implement
[CLA]: https://cla.developers.google.com/
[flutter/tests]: https://github.com/flutter/tests
[breaking change policy]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#handling-breaking-changes
[Discord]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Chat.md
[Data Driven Fixes]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Data-driven-Fixes.md
2025-04-16 22:46:13 +00:00
Kishan Rathore
37fa9ae6f1
Fix: Localization for non zero time in 24 hours format ( #164885 )
...
Fix: Localization for non zero time in 24 hours format
fixes : #164860
## Pre-launch Checklist
- [x] I read the [Contributor Guide] and followed the process outlined
there for submitting PRs.
- [x] I read the [Tree Hygiene] wiki page, which explains my
responsibilities.
- [x] I read and followed the [Flutter Style Guide], including [Features
we expect every widget to implement].
- [x] I signed the [CLA].
- [x] I listed at least one issue that this PR fixes in the description
above.
- [x] I updated/added relevant documentation (doc comments with `///`).
- [x] I added new tests to check the change I am making, or this PR is
[test-exempt].
- [x] I followed the [breaking change policy] and added [Data Driven
Fixes] where supported.
- [x] All existing and new tests are passing.
2025-04-16 22:34:52 +00:00
gaaclarke
3f0ff18e76
Updated docstrings for TextureContents ( #167221 )
...
fixes https://github.com/flutter/flutter/issues/139527
## Pre-launch Checklist
- [x] I read the [Contributor Guide] and followed the process outlined
there for submitting PRs.
- [x] I read the [Tree Hygiene] wiki page, which explains my
responsibilities.
- [x] I read and followed the [Flutter Style Guide], including [Features
we expect every widget to implement].
- [x] I signed the [CLA].
- [x] I listed at least one issue that this PR fixes in the description
above.
- [x] I updated/added relevant documentation (doc comments with `///`).
- [x] I added new tests to check the change I am making, or this PR is
[test-exempt].
- [x] I followed the [breaking change policy] and added [Data Driven
Fixes] where supported.
- [x] All existing and new tests are passing.
If you need help, consider asking for advice on the #hackers-new channel
on [Discord].
<!-- Links -->
[Contributor Guide]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#overview
[Tree Hygiene]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md
[test-exempt]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#tests
[Flutter Style Guide]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md
[Features we expect every widget to implement]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md#features-we-expect-every-widget-to-implement
[CLA]: https://cla.developers.google.com/
[flutter/tests]: https://github.com/flutter/tests
[breaking change policy]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#handling-breaking-changes
[Discord]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Chat.md
[Data Driven Fixes]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Data-driven-Fixes.md
2025-04-16 21:55:43 +00:00
gaaclarke
90b37bf053
Broke cyclical dependency with dlpath and typographer. ( #167293 )
...
fixes https://github.com/flutter/flutter/issues/166593
## Pre-launch Checklist
- [x] I read the [Contributor Guide] and followed the process outlined
there for submitting PRs.
- [x] I read the [Tree Hygiene] wiki page, which explains my
responsibilities.
- [x] I read and followed the [Flutter Style Guide], including [Features
we expect every widget to implement].
- [x] I signed the [CLA].
- [x] I listed at least one issue that this PR fixes in the description
above.
- [x] I updated/added relevant documentation (doc comments with `///`).
- [x] I added new tests to check the change I am making, or this PR is
[test-exempt].
- [x] I followed the [breaking change policy] and added [Data Driven
Fixes] where supported.
- [x] All existing and new tests are passing.
If you need help, consider asking for advice on the #hackers-new channel
on [Discord].
<!-- Links -->
[Contributor Guide]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#overview
[Tree Hygiene]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md
[test-exempt]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#tests
[Flutter Style Guide]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md
[Features we expect every widget to implement]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md#features-we-expect-every-widget-to-implement
[CLA]: https://cla.developers.google.com/
[flutter/tests]: https://github.com/flutter/tests
[breaking change policy]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#handling-breaking-changes
[Discord]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Chat.md
[Data Driven Fixes]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Data-driven-Fixes.md
2025-04-16 20:12:32 +00:00
Gray Mackall
8745940120
Set an additional CMake arg in forceNdkDownload to make the task name align with the BuildType ( #167240 )
...
Aligns the generated task names with what they would be expected to be,
i.e. `configureCMakeDebug` now depends on `compileFlutterBuildDebug`
(before it was profile).
Does this by:
1. Instead of configuring this in a `defaultConfig`, configure per build
type.
2. Move the invocation of this code to after where we create the
`profile` build type.
Fixes https://github.com/flutter/flutter/issues/166744
## Pre-launch Checklist
- [x] I read the [Contributor Guide] and followed the process outlined
there for submitting PRs.
- [x] I read the [Tree Hygiene] wiki page, which explains my
responsibilities.
- [x] I read and followed the [Flutter Style Guide], including [Features
we expect every widget to implement].
- [x] I signed the [CLA].
- [x] I listed at least one issue that this PR fixes in the description
above.
- [x] I updated/added relevant documentation (doc comments with `///`).
- [x] I added new tests to check the change I am making, or this PR is
[test-exempt].
- [x] I followed the [breaking change policy] and added [Data Driven
Fixes] where supported.
- [x] All existing and new tests are passing.
If you need help, consider asking for advice on the #hackers-new channel
on [Discord].
<!-- Links -->
[Contributor Guide]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#overview
[Tree Hygiene]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md
[test-exempt]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#tests
[Flutter Style Guide]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md
[Features we expect every widget to implement]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md#features-we-expect-every-widget-to-implement
[CLA]: https://cla.developers.google.com/
[flutter/tests]: https://github.com/flutter/tests
[breaking change policy]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#handling-breaking-changes
[Discord]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Chat.md
[Data Driven Fixes]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Data-driven-Fixes.md
---------
Co-authored-by: Gray Mackall <mackall@google.com>
2025-04-16 20:09:19 +00:00
Huy
2c516f26f9
Fix Carousel crashes when using PageStorageKey ( #166817 )
...
- Fix https://github.com/flutter/flutter/issues/166067
- PageStorage is usually used to save and restore offset of scrollable
widget when the widget is recreated in practice. From the crash stack
trace in bug report, it happens when [oldViewportDimensions gets a null
value](3fa9b38705/packages/flutter/lib/src/material/carousel.dart (L1472-L1485)3fa9b38705/packages/flutter/lib/src/widgets/scroll_position.dart (L275)https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#overview
[Tree Hygiene]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md
[test-exempt]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#tests
[Flutter Style Guide]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md
[Features we expect every widget to implement]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md#features-we-expect-every-widget-to-implement
[CLA]: https://cla.developers.google.com/
[flutter/tests]: https://github.com/flutter/tests
[breaking change policy]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#handling-breaking-changes
[Discord]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Chat.md
[Data Driven Fixes]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Data-driven-Fixes.md
2025-04-16 19:53:17 +00:00
