DEV/flutter_flutter
1
0
Fork 0
mirror of https://github.com/flutter/flutter.git synced 2026-02-20 02:29:02 +08:00
Code Issues Packages Projects Releases Wiki Activity
32,892 Commits 882 Branches 1,069 Tags
Commit Graph

24932 Commits

Author SHA1 Message Date
skia-flutter-autoroll
20430cf3e4 Roll Skia from df263765ebc8 to 775da2d297de (2 revisions) (flutter/engine#47861) 
https://skia.googlesource.com/skia.git/+log/df263765ebc8..775da2d297de

2023-11-09 brianosman@google.com Remove unused store_u16_be raster pipeline stage
2023-11-09 johnstiles@google.com Use STArray for MeshGP arrays.

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC bdero@google.com,brianosman@google.com,fmalita@google.com,rmistry@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2023-11-09 16:52:18 +00:00
auto-submit[bot]
aa4fb605c3 Reverts "Remove physical geometry" (flutter/engine#47862) 
Reverts flutter/engine#47825
Initiated by: zanderso
This change reverts the following previous change:
Original Description:
Looks like this was proactively added in https://github.com/flutter/engine/pull/20496, but never wired up to anything on any platform. It is also unused in framework and customer code; we never exposed this on e.g. MediaQuery.

Related framework PR: https://github.com/flutter/flutter/pull/138103 (Checks will fail until that PR is submitted).
 2023-11-09 16:06:19 +00:00
skia-flutter-autoroll
c378306ada Roll Skia from 7d0768083298 to df263765ebc8 (2 revisions) (flutter/engine#47860) 
https://skia.googlesource.com/skia.git/+log/7d0768083298..df263765ebc8

2023-11-09 johnstiles@google.com Remove skcms_internal.h from modules/skcms.
2023-11-09 robertphillips@google.com Add VkTestHelper factory

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC bdero@google.com,brianosman@google.com,fmalita@google.com,rmistry@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2023-11-09 15:45:27 +00:00
skia-flutter-autoroll
47ed379656 Roll Dart SDK from 6f36eb00cacf to 6bd98dc2dffd (1 revision) (flutter/engine#47857) 
https://dart.googlesource.com/sdk.git/+log/6f36eb00cacf..6bd98dc2dffd

2023-11-09 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com Version 3.3.0-112.0.dev

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/dart-sdk-flutter-engine
Please CC bdero@google.com,dart-vm-team@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter Engine: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2023-11-09 13:56:10 +00:00
skia-flutter-autoroll
f89e9b9fd4 Roll Fuchsia Linux SDK from sD8HRA4JmXczujkqO... to 0pD5ceqf-e9y9NTNn... (flutter/engine#47847) 
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/fuchsia-linux-sdk-flutter-engine
Please CC bdero@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2023-11-09 03:40:39 +00:00
Michael Goderbauer
c273bd8d71 Remove physical geometry (flutter/engine#47825) 
Looks like this was proactively added in https://github.com/flutter/engine/pull/20496, but never wired up to anything on any platform. It is also unused in framework and customer code; we never exposed this on e.g. MediaQuery.

Related framework PR: https://github.com/flutter/flutter/pull/138103 (Checks will fail until that PR is submitted).
 2023-11-09 02:18:24 +00:00
Loïc Sharma
9aee1bdaff [Windows] Remove global state in keyboard tests (flutter/engine#47829) 
Currently the keyboard tests use global state to track key calls. As a result, a good test can fail if a bad test leaves key calls in the global state. This removes the global state and ensures each test is isolated.

Preparation for https://github.com/flutter/flutter/issues/115611

[C++, Objective-C, Java style guides]: https://github.com/flutter/engine/blob/main/CONTRIBUTING.md#style
 2023-11-09 00:10:05 +00:00
Mouad Debbar
5f8e18d0f8 [web] Non-singleton implementation of ui.FlutterView (flutter/engine#47806) 
- Provide a non-singleton implementation of `EngineFlutterView`.
- Move all common "view" logic into `EngineFlutterView`.
- Remove the unused `windowConfigurations` map from `EnginePlatformDispatcher`.
 2023-11-08 23:58:02 +00:00
Greg Spencer
68166947cc Move window state update to window realize callback (flutter/engine#47713) 
## Description

This moves the state update to only happen on realizing the window instead of at initialization time, based on [the comment from](https://github.com/flutter/flutter/issues/137262#issuecomment-1792020246) @robert-ancell .

## Related Issues
 - https://github.com/flutter/flutter/issues/137262

## Tests
 - I tried to add tests, but it doesn't seem possible to create a view without an actual display connected (and making a mock of it defeats the purpose of the test). I'm happy to be proven wrong, though.
 2023-11-08 23:56:01 +00:00
auto-submit[bot]
f5605fa8aa Reverts "Upgrade Android SDK to 34 "UpsideDownCake"" (flutter/engine#47834) 
Reverts flutter/engine#47609
Initiated by: zanderso
This change reverts the following previous change:
Original Description:
~**This should not land until https://github.com/flutter/buildroot/pull/790 (re)lands, and I swap the buildroot url back to the latest commit.**~ ~Reland of PR to update buildroot at https://github.com/flutter/buildroot/pull/792. ~ <- landed, and changed the buildroot commit to the latest in DEPS

Upgrades to android api 34

Also:
1. Upgrades to java 17 in DEPS/ci, because the linter now requires it.
2. Stops running some roboelectric tests on android apis 16-18, because Roboelectric indicated those versions were unsupported and we don't support them either.
3. Applies the four trivial new suggestions from the newer linter.
4. Updates the baseline lint to include the new non-trivial lint ([fixed in a different PR](https://github.com/flutter/engine/pull/47817/files)).
5. Changes some instances where we were hardcoding android apis as numbers (e.g. `sdk = 16') to use version codes (see the [comment below](https://github.com/flutter/engine/pull/47609#issuecomment-1800308658)).

[C++, Objective-C, Java style guides]: https://github.com/flutter/engine/blob/main/CONTRIBUTING.md#style
 2023-11-08 22:57:25 +00:00
skia-flutter-autoroll
5b184b80e9 Roll Skia from e585bb68893b to 1241a903cd33 (2 revisions) (flutter/engine#47830) 
https://skia.googlesource.com/skia.git/+log/e585bb68893b..1241a903cd33

2023-11-08 nicolettep@google.com [graphite] Add label to YCbCr sampler conversion resource instantiation
2023-11-08 johnstiles@google.com Fix rewrite_includes errors.

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC bdero@google.com,brianosman@google.com,fmalita@google.com,rmistry@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2023-11-08 22:17:05 +00:00
Gray Mackall
542d29dedd Upgrade Android SDK to 34 "UpsideDownCake" (flutter/engine#47609) 
~**This should not land until https://github.com/flutter/buildroot/pull/790 (re)lands, and I swap the buildroot url back to the latest commit.**~ ~Reland of PR to update buildroot at https://github.com/flutter/buildroot/pull/792. ~ <- landed, and changed the buildroot commit to the latest in DEPS

Upgrades to android api 34

Also:
1. Upgrades to java 17 in DEPS/ci, because the linter now requires it.
2. Stops running some roboelectric tests on android apis 16-18, because Roboelectric indicated those versions were unsupported and we don't support them either.
3. Applies the four trivial new suggestions from the newer linter.
4. Updates the baseline lint to include the new non-trivial lint ([fixed in a different PR](https://github.com/flutter/engine/pull/47817/files)).
5. Changes some instances where we were hardcoding android apis as numbers (e.g. `sdk = 16') to use version codes (see the [comment below](https://github.com/flutter/engine/pull/47609#issuecomment-1800308658)).

[C++, Objective-C, Java style guides]: https://github.com/flutter/engine/blob/main/CONTRIBUTING.md#style
 2023-11-08 22:15:17 +00:00
Chris Bracken
c5b1d11b65 [macOS] Allocate textures as unique_ptr earlier (flutter/engine#47786) 
This cleans up several places where instead of allocating a
std::unique_ptr immediately, we were making allocations with the new
operator, then later wrapping in a unique_ptr. The previous code was
correct but there was no reason not to allocate a unique_ptr
immediately.

This code makes no semantic changes; just applies a stylistic
improvement that makes the code very slightly safer.


## Pre-launch Checklist

- [X] I read the [Contributor Guide] and followed the process outlined
there for submitting PRs.
- [X] I read the [Tree Hygiene] wiki page, which explains my
responsibilities.
- [X] I read and followed the [Flutter Style Guide] and the [C++,
Objective-C, Java style guides].
- [ ] I listed at least one issue that this PR fixes in the description
above.
- [X] I added new tests to check the change I am making or feature I am
adding, or the PR is [test-exempt]. See [testing the engine] for
instructions on writing and running engine tests.
- [X] I updated/added relevant documentation (doc comments with `///`).
- [X] I signed the [CLA].
- [X] All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel
on [Discord].

<!-- Links -->
[Contributor Guide]:
https://github.com/flutter/flutter/wiki/Tree-hygiene#overview
[Tree Hygiene]: https://github.com/flutter/flutter/wiki/Tree-hygiene
[test-exempt]:
https://github.com/flutter/flutter/wiki/Tree-hygiene#tests
[Flutter Style Guide]:
https://github.com/flutter/flutter/wiki/Style-guide-for-Flutter-repo
[C++, Objective-C, Java style guides]:
https://github.com/flutter/engine/blob/main/CONTRIBUTING.md#style
[testing the engine]:
https://github.com/flutter/flutter/wiki/Testing-the-engine
[CLA]: https://cla.developers.google.com/
[flutter/tests]: https://github.com/flutter/tests
[breaking change policy]:
https://github.com/flutter/flutter/wiki/Tree-hygiene#handling-breaking-changes
[Discord]: https://github.com/flutter/flutter/wiki/Chat
 2023-11-08 13:50:42 -08:00
Jim Graham
4979e236a9 Reland "[Impeller] add support for Skia concept of RRect::isSimple needed for DL dispatching" (flutter/engine#47824) 
Reverts flutter/engine#47821

The original PR was reverted because the Vulkan backends couldn't handle the extra tests, but they've since been patched to fix the problem.
 2023-11-08 21:32:49 +00:00
skia-flutter-autoroll
55083d455b Roll Skia from e2b8ebe16203 to e585bb68893b (7 revisions) (flutter/engine#47826) 
https://skia.googlesource.com/skia.git/+log/e2b8ebe16203..e585bb68893b

2023-11-08 michaelludwig@google.com GrBlurUtils: Subset on low-res pixel boundary, not float coords
2023-11-08 jvanverth@google.com Force coloremoji GM to have a small multitexture atlas.
2023-11-08 mike@reedtribe.org Add build-flag to enable smaller/slower mipmap builder
2023-11-08 egdaniel@google.com [Graphite] Add initial support for Resource labels.
2023-11-08 herb@google.com Tighten up image and empty tracking for SkGlyph
2023-11-08 skia-autoroll@skia-public.iam.gserviceaccount.com Roll SK Tool from 4da518531bee to 6a90ad65ed95
2023-11-08 nicolettep@google.com [graphite] Add sampler YCbCr conversion class, info struct; share utilities w/ ganesh

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC bdero@google.com,brianosman@google.com,fmalita@google.com,rmistry@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2023-11-08 21:32:46 +00:00
Jonah Williams
513906fced [Impeller] Add support for specialization constants (III). (flutter/engine#47765) 
Reland of https://github.com/flutter/engine/pull/47432

Also includes:

https://github.com/flutter/engine/pull/47617
https://github.com/flutter/engine/pull/47637

Fixes the performance on iOS by removing blocking on compilation of shaders. From local testing this has identical before/after numbers. Additional, ensures that we don't unecessarily specialize vertex shaders and notes this restriction in the documentation.

Adds support for Specialization constants to Impeller for our usage in the engine. A motivating example has been added in the impeller markdown docs.

Fixes https://github.com/flutter/flutter/issues/136210
Fixes https://github.com/flutter/flutter/issues/119357

Investigating: https://github.com/flutter/flutter/issues/138028
 2023-11-08 21:29:42 +00:00
gaaclarke
40a52fcc16 [Impeller] Documented the 2 step in the gaussian blur. (flutter/engine#47822) 
[C++, Objective-C, Java style guides]: https://github.com/flutter/engine/blob/main/CONTRIBUTING.md#style
 2023-11-08 21:10:47 +00:00
Jason Simmons
61f09f66a5 [Impeller] Create a global Vulkan instance in PlaygroundImplVK to prevent SwiftShader from being unloaded after a test completes (flutter/engine#47781) 
Libcxx is leaking a thread-local storage key each time SwiftShader is
loaded and unloaded. If a test's Vulkan instance is the only one in the
process, then SwiftShader will be unloaded after the test ends. If many
Vulkan playground tests run in a suite, then eventually the leak will
cause the process to exceed its limit of TLS keys and the suite will
fail.

The process can ensure that SwiftShader remains loaded by holding
another Vulkan instance that persists across all tests in the suite.

Fixes https://github.com/flutter/flutter/issues/138028
 2023-11-08 12:36:31 -08:00
auto-submit[bot]
01ff55b358 Reverts "[Impeller] add support for Skia concept of RRect::isSimple needed for DL dispatching" (flutter/engine#47821) 
Reverts flutter/engine#47736
Initiated by: zanderso
This change reverts the following previous change:
Original Description:
Fixes https://github.com/flutter/flutter/issues/133793
 2023-11-08 20:35:25 +00:00
skia-flutter-autoroll
d7a5bcba01 Roll Skia from fb69e696dc45 to e2b8ebe16203 (4 revisions) (flutter/engine#47815) 
https://skia.googlesource.com/skia.git/+log/fb69e696dc45..e2b8ebe16203

2023-11-08 nicolettep@google.com [graphite] VulkanResourceProvider findOrCreate method improvements
2023-11-08 johnstiles@google.com Change resizing strategy for empty TArrays.
2023-11-08 skia-autoroll@skia-public.iam.gserviceaccount.com Roll vulkan-deps from 969da898b476 to 6fff5ad7622c (1 revision)
2023-11-08 brianosman@google.com Remove rgf32 stages from RP

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC bdero@google.com,brianosman@google.com,fmalita@google.com,rmistry@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2023-11-08 19:01:22 +00:00
Jim Graham
0080fdec3c [Impeller] add support for Skia concept of RRect::isSimple needed for DL dispatching (flutter/engine#47736) 
Fixes https://github.com/flutter/flutter/issues/133793
 2023-11-08 18:55:22 +00:00
Gray Mackall
81faa02060 Switch to Android 14 for physical device firebase tests (flutter/engine#47016) 
Switch to the latest android version for tests.

Device is high capacity, and [currently in use in flutter/flutter](dbb79e63eb/.ci.yaml (L451)). See [here](https://firebase.google.com/docs/test-lab/android/available-testing-devices) to get the list of devices.

Related to https://github.com/flutter/flutter/pull/136736

[C++, Objective-C, Java style guides]: https://github.com/flutter/engine/blob/main/CONTRIBUTING.md#style
 2023-11-08 18:50:05 +00:00
Jonah Williams
3c6f5e10f2 [Impeller] remove capability to read from onscreen. (flutter/engine#47808) 
As discovered by @knopp in https://github.com/flutter/flutter/issues/131567#issuecomment-1678210475, this is actually reducing performance substantially when there are multiple blurs. In the case of https://github.com/flutter/flutter/issues/132735 , removing this capbility improves GPU performance from 400ms per frame to ~100 ms per frame.

Fixes https://github.com/flutter/flutter/issues/131567#issuecomment-1678210475

-----

  | Macrobench | Example App
-- | -- | --
TOT | 250 | 450
W/Out OnScreen | 203-187 | 125-109
W/Out Onscreen and Resolve | 203 | 125
 2023-11-08 18:38:59 +00:00
skia-flutter-autoroll
fa37b61785 Roll Skia from a4cce5236dcf to fb69e696dc45 (1 revision) (flutter/engine#47810) 
https://skia.googlesource.com/skia.git/+log/a4cce5236dcf..fb69e696dc45

2023-11-08 johnstiles@google.com Use STArray for SkMesh child array.

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC bdero@google.com,brianosman@google.com,fmalita@google.com,rmistry@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2023-11-08 17:49:03 +00:00
skia-flutter-autoroll
0e9c6facbb Roll Dart SDK from 15c286ed91ea to 14933042494d (5 revisions) (flutter/engine#47805) 
https://dart.googlesource.com/sdk.git/+log/15c286ed91ea..14933042494d

2023-11-08 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com Version 3.3.0-107.0.dev
2023-11-08 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com Version 3.3.0-106.0.dev
2023-11-08 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com Version 3.3.0-105.0.dev
2023-11-07 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com Version 3.3.0-104.0.dev
2023-11-07 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com Version 3.3.0-103.0.dev

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/dart-sdk-flutter-engine
Please CC bdero@google.com,dart-vm-team@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter Engine: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2023-11-08 17:39:56 +00:00
utzcoz
3382ab50ac Use targetSdkVersion 33 for Android platform AndroidManifest.xml (flutter/engine#47683) 
buildroot has switched to use 33 as default target sdk version.

[C++, Objective-C, Java style guides]: https://github.com/flutter/engine/blob/main/CONTRIBUTING.md#style
 2023-11-08 17:15:16 +00:00
Jim Graham
46235bbe4c [Impeller] Add EXPECT_OBJ_NEAR macros similar to the ASSERT_OBJ_NEAR versions (flutter/engine#47795) 
Fixes https://github.com/flutter/flutter/issues/137873

The `ASSERT_..._NEAR` macros are used in many places in the Impeller unit tests, but they are "fatal errors" in that they immediately exit the individual unit test. These versions allow testing expectations without ending the unit test early.
 2023-11-08 17:12:56 +00:00
Jonah Williams
5dd5cd253a [Impeller] null check drawable. (flutter/engine#47488) 
Speculative fix for the first crash noted in https://github.com/flutter/flutter/issues/136628#issue-1944779964

nextDrawble can return null if the method times out.

Fixes https://github.com/flutter/flutter/issues/136525
 2023-11-08 16:35:03 +00:00
Chris Bracken
c947cfce7e [macOS] Clean up resources in ViewController tests (flutter/engine#47792) 
Wraps all FlutterViewController tests in an autorelease pool to ensure
resources are cleaned up.

Adds a MockFlutterEngineTest subclass of AutoreleasePoolTest that
creates an OCPartialMock FlutterEngine and shuts it down at the end of
the test. Previously we were not shutting down any FlutterEngine
instances we allocated, resulting in potentially thousands of threads
and graphics contexts being allocated.

Prior to this change, running these tests via:

    ../out/host_debug_unopt_arm64/flutter_desktop_darwin_unittests \
        --gtest_filter='FlutterViewController.*' --gtest_repeat=1000

resulted in test failures and sometimes segfaults. This ensures
resources are cleaned up

Eventually all unit tests should configure their FlutterEngine via
either FlutterEngineTest (which should be an AutoreleasePoolTest) or
MockFlutterEngineTest, and the CreateMockFlutterEngine function moved to
a static used in the implementation of these.

Issue: https://github.com/flutter/flutter/issues/104789
Issue: https://github.com/flutter/flutter/issues/127441
Issue: https://github.com/flutter/flutter/issues/124840

## Pre-launch Checklist

- [x] I read the [Contributor Guide] and followed the process outlined
there for submitting PRs.
- [x] I read the [Tree Hygiene] wiki page, which explains my
responsibilities.
- [x] I read and followed the [Flutter Style Guide] and the [C++,
Objective-C, Java style guides].
- [x] I listed at least one issue that this PR fixes in the description
above.
- [x] I added new tests to check the change I am making or feature I am
adding, or the PR is [test-exempt]. See [testing the engine] for
instructions on writing and running engine tests.
- [x] I updated/added relevant documentation (doc comments with `///`).
- [x] I signed the [CLA].
- [x] All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel
on [Discord].

<!-- Links -->
[Contributor Guide]:
https://github.com/flutter/flutter/wiki/Tree-hygiene#overview
[Tree Hygiene]: https://github.com/flutter/flutter/wiki/Tree-hygiene
[test-exempt]:
https://github.com/flutter/flutter/wiki/Tree-hygiene#tests
[Flutter Style Guide]:
https://github.com/flutter/flutter/wiki/Style-guide-for-Flutter-repo
[C++, Objective-C, Java style guides]:
https://github.com/flutter/engine/blob/main/CONTRIBUTING.md#style
[testing the engine]:
https://github.com/flutter/flutter/wiki/Testing-the-engine
[CLA]: https://cla.developers.google.com/
[flutter/tests]: https://github.com/flutter/tests
[breaking change policy]:
https://github.com/flutter/flutter/wiki/Tree-hygiene#handling-breaking-changes
[Discord]: https://github.com/flutter/flutter/wiki/Chat
 2023-11-07 23:50:31 -08:00
Jim Graham
d04690cbe0 [Impeller] Add Rect::GetNormalizingTransform to handle UV coordinate conversion (flutter/engine#47775) 
Three places in the code were manually computing the UV coordinates relative to a texture coverage rectangle while also transforming the points. This change will make it easier both to compute the UV conversion matrix and also to consolidate it with the transform that was already being applied to streamline the total computations.
 2023-11-08 04:37:19 +00:00
Yegor
1aecccf6c5 [web] fix clicks on merged semantic nodes (attempt #2) (flutter/engine#47360) 
This relands https://github.com/flutter/engine/pull/43620 with a fix for nested tappable nodes. The first PR introduced this regression: https://github.com/flutter/flutter/issues/134842.

This PR includes the original PR and a fix for the regression. The fix is to call `stopPropagation` on the "click" event so that it is not handled by the ancestor if the child has already decided to send a `SemanticsAction.tap` to the framework. This ensures that there cannot be more than one `SemanticsAction.tap` sent to the framework.

Fixes https://github.com/flutter/flutter/issues/134842
 2023-11-08 04:23:05 +00:00
skia-flutter-autoroll
37d07dd14e Roll Skia from 0f78e5f765d3 to b4fa927468e6 (1 revision) (flutter/engine#47788) 
https://skia.googlesource.com/skia.git/+log/0f78e5f765d3..b4fa927468e6

2023-11-08 sunnyps@chromium.org graphite: Fixes for enabling storage buffers for Dawn backend

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC bdero@google.com,brianosman@google.com,fmalita@google.com,rmistry@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2023-11-08 03:19:12 +00:00
Jia Hao
2156a17b9a Fix narrowing conversion lint (flutter/engine#47740) 
Internally we have a lint that surfaces this as a warning. Googlers, please refer to go/al-rule/NarrowingConversion.

Related: b/309552840

When we do:
```
coords.toolMajor = (float) (double) coordsList.get(3) * density;
```

`coordsList.get(3)` is casted to a `double`, then a `float`, before the multiplication happens. 

I don't think this is intentional. The intention of the code here seems to be:

- Cast to a `double`: `coordsList` is a `List<Object>` so the cast narrows the value
- Cast to a `float`: To fit the resulting value into [`coords.toolMajor`](https://developer.android.com/reference/android/view/MotionEvent.PointerCoords#toolMajor), which is a `float`.

As such, add parenthesis to address this.

[C++, Objective-C, Java style guides]: https://github.com/flutter/engine/blob/main/CONTRIBUTING.md#style
 2023-11-08 01:41:25 +00:00
Chris Bracken
7a923cd1d9 [macOS] Bail out of tests if engine not running (flutter/engine#47771) 
In engine tests where we require a running engine to proceed with the
test, immediately fail if the engine isn't running rather than carrying
on with the test. In most cases, the fixture test proceeds to block the
main thread on a latch until it's released from the UI thread, so this
results in quicker test failures.

## Pre-launch Checklist

- [X] I read the [Contributor Guide] and followed the process outlined
there for submitting PRs.
- [X] I read the [Tree Hygiene] wiki page, which explains my
responsibilities.
- [X] I read and followed the [Flutter Style Guide] and the [C++,
Objective-C, Java style guides].
- [ ] I listed at least one issue that this PR fixes in the description
above.
- [X] I added new tests to check the change I am making or feature I am
adding, or the PR is [test-exempt]. See [testing the engine] for
instructions on writing and running engine tests.
- [X] I updated/added relevant documentation (doc comments with `///`).
- [X] I signed the [CLA].
- [X] All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel
on [Discord].

<!-- Links -->
[Contributor Guide]:
https://github.com/flutter/flutter/wiki/Tree-hygiene#overview
[Tree Hygiene]: https://github.com/flutter/flutter/wiki/Tree-hygiene
[test-exempt]:
https://github.com/flutter/flutter/wiki/Tree-hygiene#tests
[Flutter Style Guide]:
https://github.com/flutter/flutter/wiki/Style-guide-for-Flutter-repo
[C++, Objective-C, Java style guides]:
https://github.com/flutter/engine/blob/main/CONTRIBUTING.md#style
[testing the engine]:
https://github.com/flutter/flutter/wiki/Testing-the-engine
[CLA]: https://cla.developers.google.com/
[flutter/tests]: https://github.com/flutter/tests
[breaking change policy]:
https://github.com/flutter/flutter/wiki/Tree-hygiene#handling-breaking-changes
[Discord]: https://github.com/flutter/flutter/wiki/Chat
 2023-11-07 17:27:14 -08:00
Chris Bracken
229331bcff [testing] Extract StreamCapture test utility (flutter/engine#47774) 
Factors out an RAII-based class that can be used to capture std::cout, std::cerr, or technically any other std::ostream, though that's unlikely to be useful.

This makes the logic reusable but more importantly, ensures the capture is cleaned up at the end of the test.

[C++, Objective-C, Java style guides]: https://github.com/flutter/engine/blob/main/CONTRIBUTING.md#style
 2023-11-08 01:18:16 +00:00
auto-submit[bot]
b82cf7549f Reverts "Promote fuchsia build v2 to prod." (flutter/engine#47779) 
Reverts flutter/engine#47729
Initiated by: bdero
This change reverts the following previous change:
Original Description:
The current failure in staging is because the service account does not have write access to the release bucket.

[C++, Objective-C, Java style guides]: https://github.com/flutter/engine/blob/main/CONTRIBUTING.md#style
 2023-11-08 01:04:18 +00:00
Alexander Aprelev
62c7eb298f Include updated locations for dart third_party components into license ignore-list. (flutter/engine#47770) 
Incoming dart roll with
https://dart.googlesource.com/sdk/+/4d308f39115a2969fb9908055b37a93969d4fc8d
moves `runtime/third_parry` in dart to `third_party`, so license script
ignore-list have to be updated to accommodate new location.

Once the roll lands, old locations should be cleaned up from the
ignore-list.
 2023-11-07 16:37:59 -08:00
skia-flutter-autoroll
6933a28f56 Roll Skia from 030e21befbc9 to f91d39395e85 (6 revisions) (flutter/engine#47769) 
https://skia.googlesource.com/skia.git/+log/030e21befbc9..f91d39395e85

2023-11-07 jvanverth@google.com Fix colorspace transform with multitexture color text.
2023-11-07 nscobie@google.com Revert "Migrate many direct and indirect uses of SkFontMgr to use TestFontMgr"
2023-11-07 skia-autoroll@skia-public.iam.gserviceaccount.com Roll SK Tool from e98bb78ac013 to 4da518531bee
2023-11-07 egdaniel@google.com [Graphite] Add support for SkTraceMemoryDump for gpu Resources.
2023-11-07 michaelludwig@google.com [graphite] Skip calling getMostRecentDraw() for draws that don't need it for sorting
2023-11-07 kjlubick@google.com Migrate many direct and indirect uses of SkFontMgr to use TestFontMgr

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC bdero@google.com,brianosman@google.com,fmalita@google.com,rmistry@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2023-11-07 22:24:55 +00:00
Chinmay Garde
9e7b63b085 [Impeller] Support static thread safety analysis with condition variables. (flutter/engine#47763) 
Fixes https://github.com/flutter/flutter/issues/134843
 2023-11-07 21:27:43 +00:00
godofredoc
5f8dd1ed6d Promote fuchsia build v2 to prod. (flutter/engine#47729) 
The current failure in staging is because the service account does not have write access to the release bucket.

[C++, Objective-C, Java style guides]: https://github.com/flutter/engine/blob/main/CONTRIBUTING.md#style
 2023-11-07 21:27:42 +00:00
Loïc Sharma
9b3d3b0231 [Windows] Reduce warnings produced by unit tests (flutter/engine#47724) 
This PR contains no functional changes but improves existing unit tests to reduce the number of warnings output when the tests are ran:

1. Replaced `ON_CALL` with `EXPECT_CALL` for expected method calls
2. Added some missing mocks

[C++, Objective-C, Java style guides]: https://github.com/flutter/engine/blob/main/CONTRIBUTING.md#style
 2023-11-07 21:13:33 +00:00
Jim Graham
9a968220c3 [Impeller] Make IsEmpty methods on Rect and Size NaN-aware (flutter/engine#47725) 
Removes unused or redundant overloads and fixes the IsEmpty method on Size to be both simpler (2 comparisons vs. 4) and NaN-aware. Rect automatically uses the new code via delegation to the Size object.
 2023-11-07 21:10:13 +00:00
auto-submit[bot]
57780e74c3 Reverts "[Impeller] Add support for specialization constants redux." (flutter/engine#47762) 
Reverts flutter/engine#47678
Initiated by: jonahwilliams
This change reverts the following previous change:
Original Description:
Reland of https://github.com/flutter/engine/pull/47432

Also includes:
  * https://github.com/flutter/engine/pull/47617
  * https://github.com/flutter/engine/pull/47637
  
Fixes the performance on iOS by removing blocking on compilation of shaders. From local testing this has identical before/after numbers. Additional, ensures that we don't unecessarily specialize vertex shaders and notes this restriction in the documentation.

----

Adds support for Specialization constants to Impeller for our usage in the engine. A motivating example has been added in the impeller markdown docs.

Fixes https://github.com/flutter/flutter/issues/136210
Fixes https://github.com/flutter/flutter/issues/119357
 2023-11-07 20:44:36 +00:00
gaaclarke
aab5af3615 [Impeller] added tests for matrices (flutter/engine#47754) 
[C++, Objective-C, Java style guides]: https://github.com/flutter/engine/blob/main/CONTRIBUTING.md#style
 2023-11-07 19:39:40 +00:00
Chris Yang
5c12a78db9 [ios] making objective-C smart pointers support ARC (flutter/engine#47612) 
Moving the implementation from https://codereview.chromium.org/1855483004 into the code base, including:

- scoped_nsobject, scoped_nsprotocol, scoped_block will support both mrc and arc
- Added parent class scoped_typeref for shared code between scoped_block and scoped_nsobject
- moving OwnershipPolicy to its own file

The implementation of the smart pointers are almost identical to https://codereview.chromium.org/1855483004 besides some syntax preference differences between chromium and flutter.

This PR also migrated [VsyncWaiterIosTest.mm](https://github.com/flutter/engine/pull/47612/files#diff-c98ce1a2aca65c29bbc444523b66921a53ecce5ff39a420b4eda7dbfe8ca1cc7) to ARC with scoped_nsobject

fixes https://github.com/flutter/flutter/issues/137802

[C++, Objective-C, Java style guides]: https://github.com/flutter/engine/blob/main/CONTRIBUTING.md#style
 2023-11-07 19:25:45 +00:00
Zachary Anderson
e24e3b5746 Don't use Skia BUILD.gn files (flutter/engine#47677) 
The new `BUILD.gn` files in the Engine tree can't go under
`build/secondary` because Skia still has its own, and they'd be selected
first. So, this PR puts the new `BUILD.gn` files under `flutter/skia`.
 2023-11-07 11:12:29 -08:00
Jonah Williams
2a4a3ec9ea [Impeller] Add support for specialization constants redux. (flutter/engine#47678) 
Reland of https://github.com/flutter/engine/pull/47432

Also includes:
  * https://github.com/flutter/engine/pull/47617
  * https://github.com/flutter/engine/pull/47637
  
Fixes the performance on iOS by removing blocking on compilation of shaders. From local testing this has identical before/after numbers. Additional, ensures that we don't unecessarily specialize vertex shaders and notes this restriction in the documentation.

----

Adds support for Specialization constants to Impeller for our usage in the engine. A motivating example has been added in the impeller markdown docs.

Fixes https://github.com/flutter/flutter/issues/136210
Fixes https://github.com/flutter/flutter/issues/119357
 2023-11-07 19:08:48 +00:00
skia-flutter-autoroll
9ed9f17fab Roll Skia from 51b8c1cc715a to 62fc1374cc5d (1 revision) (flutter/engine#47755) 
https://skia.googlesource.com/skia.git/+log/51b8c1cc715a..62fc1374cc5d

2023-11-07 michaelludwig@google.com [graphite] Add upper bound to grid size for Grid/HybridBoundsManagers

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC bdero@google.com,brianosman@google.com,fmalita@google.com,rmistry@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2023-11-07 18:54:46 +00:00
skia-flutter-autoroll
439f0f1500 Roll Skia from 058145c1e5b5 to 51b8c1cc715a (1 revision) (flutter/engine#47752) 
https://skia.googlesource.com/skia.git/+log/058145c1e5b5..51b8c1cc715a

2023-11-07 skia-autoroll@skia-public.iam.gserviceaccount.com Roll skcms from e9cc5993398f to b60ffc00fe5c (2 revisions)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC bdero@google.com,brianosman@google.com,fmalita@google.com,rmistry@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2023-11-07 17:36:17 +00:00
skia-flutter-autoroll
487526647b Roll Skia from 3ac7216f1f6d to 71d865c5211e (1 revision) (flutter/engine#47746) 
https://skia.googlesource.com/skia.git/+log/3ac7216f1f6d..71d865c5211e

2023-11-07 johnstiles@google.com Fix skcms roll issues with IWYU.

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC bdero@google.com,brianosman@google.com,fmalita@google.com,rmistry@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2023-11-07 14:18:31 +00:00