DEV/flutter_flutter
1
0
Fork 0
mirror of https://github.com/flutter/flutter.git synced 2026-02-20 02:29:02 +08:00
Code Issues Packages Projects Releases Wiki Activity
32,892 Commits 882 Branches 1,069 Tags
Commit Graph

32892 Commits

This Branch
This Branch
All Branches
Author SHA1 Message Date
Jonah Williams
330c06a4f2 [Impeller] Dont copy the paint until we're sure that the RRect blur optimization will apply. (flutter/engine#48298) 
Extremely minor micro optimization. Dont copy the paint too early.

Before

![image](https://github.com/flutter/engine/assets/8975114/b5884e02-25ed-4e53-a6e0-d8d5a6a9a79a)

13/269 = ~5%

After:

![image](https://github.com/flutter/engine/assets/8975114/ac5981bb-40c6-4a38-b24c-46b7ad5399a4)

3/262 = ~1%
 2023-11-22 00:24:06 +00:00
Matan Lurey
d5b171165f Finish making shell/platform/linux/... compatible with .clang-tidy. (flutter/engine#48297) 2023-11-21 15:35:36 -08:00
Matan Lurey
aa6fdad4cd Finish making shell/platform/android/... compatible with .clang-tidy. (flutter/engine#48296) 2023-11-21 15:34:06 -08:00
Matan Lurey
b6f162e8b3 Finish making shell/common/... compatible with .clang-tidy. (flutter/engine#48295) 2023-11-21 15:33:43 -08:00
skia-flutter-autoroll
29e3f2edc7 Roll Fuchsia Linux SDK from Q3HcTitDF90ZOPWDa... to IK4xyRtZkDwqT6pXA... (flutter/engine#48294) 
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/fuchsia-linux-sdk-flutter-engine
Please CC jacksongardner@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2023-11-21 23:12:38 +00:00
skia-flutter-autoroll
f1f8c59fdf Roll Skia from c6d971f87d12 to cac28f3634a3 (12 revisions) (flutter/engine#48293) 
https://skia.googlesource.com/skia.git/+log/c6d971f87d12..cac28f3634a3

2023-11-21 jvanverth@google.com Revert "[graphite] Use colorspace matrix to handle RGB swizzle."
2023-11-21 jvanverth@google.com [graphite] Use colorspace matrix to handle RGB swizzle.
2023-11-21 nicolettep@google.com [graphite] Implement AHardwareBuffer BackendTexture creation for Vulkan
2023-11-21 nicolettep@google.com [graphite] Add public Recorder method to create a BackendTexture from an AHardwareBuffer
2023-11-21 johnstiles@google.com Revert "[graphite] Add no-yield option to ContextOptions."
2023-11-21 kjlubick@google.com Remove MutableTextureStateRef and sketch out Vulkan-specific functions
2023-11-21 kjlubick@google.com Reland "Remove other uses of SkFontMgr::RefDefault"
2023-11-21 kjlubick@google.com Assert if null fallbackMgr used in FontMgrRunIterator
2023-11-21 johnstiles@google.com Enable individual feature flags in skcms with clang-cl.
2023-11-21 jvanverth@google.com [graphite] Remove RRRR swizzle.
2023-11-21 briansalomon@gmail.com [graphite] Add no-yield option to ContextOptions.
2023-11-21 skia-autoroll@skia-public.iam.gserviceaccount.com Roll skcms from 02a8c0638601 to c0be9bb8bc17 (2 revisions)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC brianosman@google.com,jacksongardner@google.com,jamesgk@google.com,rmistry@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2023-11-21 22:57:05 +00:00
gaaclarke
e80ecd9194 [Impeller] Switched to static linked libc++ in vulkan validation layers. (flutter/engine#48290) 
fixes https://github.com/flutter/flutter/issues/138535
test coverage: existing integration tests in flutter repo which look for validation layers

I also verified locally that the `libc++.so` is no longer present and that it runs correctly.

```
$ find lib/arm64-v8a/
lib/arm64-v8a/
lib/arm64-v8a//libflutter.so
lib/arm64-v8a//libVkLayer_khronos_validation.so
```

[C++, Objective-C, Java style guides]: https://github.com/flutter/engine/blob/main/CONTRIBUTING.md#style
 2023-11-21 22:06:05 +00:00
Matan Lurey
0b7f44c8c4 Yet more compliance with .clang_tidy, stragglers edition. (flutter/engine#48291) 
Based off the
[failures](https://logs.chromium.org/logs/flutter/buildbucket/cr-buildbucket/8763786250936903249/+/u/test:_test:_lint_host_debug/stdout)
in https://github.com/flutter/engine/pull/48145.

Nothing particularly interesting.
 2023-11-21 13:39:18 -08:00
Jackson Gardner
4dacd0341d Update skia build file to account for new skcms changes. (flutter/engine#48286) 
This should address https://github.com/flutter/flutter/issues/138838 which is blocking the skia roll.

This basically ports over the build rule changes from https://skia-review.googlesource.com/c/skia/+/777538
 2023-11-21 21:12:05 +00:00
Matan Lurey
edb665c82d Make {shell|lib/ui}/... compatible with .clang_tidy. (flutter/engine#48242) 
This is mostly just rename `ThreadHost::Type::{IDENTIFIER}` to
`kIdentifier`.

I also ignored some enum violations that are in public APIs.
 2023-11-21 12:29:14 -08:00
Jonah Williams
753e9e6ac7 [Impeller] Ensure that overlay surfaces are constructed with wide gamut settings. (flutter/engine#48190) 
Fixes https://github.com/flutter/flutter/issues/138373

When constructing overlay layers when there are platform views, make sure the same pixel format and color space as the main view is used.

Add validation to impeller HAL about blitting different pixel formats.
 2023-11-21 20:29:05 +00:00
Matan Lurey
b1a29657a9 Make {flow|fml|impeller}/... compatible with .clang_tidy. (flutter/engine#48241) 
Another few stragglers.
 2023-11-21 18:53:06 +00:00
Jonah Williams
260ec88f60 [Impeller] preallocate command buffer to next power of two of entity list. (flutter/engine#48185) 
Commands are massive 500 byte objects, re-allocating this vector while recording them can actually add a substantial amount of overhead to applications with lots of drawing commands. Sizing to npot so that underestimating by a few commands doesn't force us to immediately copy all command objects.

This is still a herustic driven approach. An alternative exact approach would have entities/contents describe how many commands they would add. This may be more important for stencil then cover (depending on how we do it) since some contents would need to create two commands.
 2023-11-21 18:12:20 +00:00
gaaclarke
e18e1d286c [Impeller] implements gaussian "blur halo" (flutter/engine#48149) 
This makes the blurred item have a halo effect that is rendered outside of the bounds of the original thing that was rendered.

issue: https://github.com/flutter/flutter/issues/131580

[C++, Objective-C, Java style guides]: https://github.com/flutter/engine/blob/main/CONTRIBUTING.md#style
 2023-11-21 16:47:24 +00:00
Zachary Anderson
e42d4109db Revert Dart SDK to 3.3.0-152.0.dev (flutter/engine#48272) 
Revert for https://github.com/flutter/flutter/issues/138813
 2023-11-21 08:07:11 -08:00
David Iglesias
b6a14724a8 [web] Add add/removeView JS methods. (flutter/engine#48106) 
This PR adds:

* JS-interop types to expose addView/removeView from the running FlutterApp object on JavaScript.
  * Also, the options object that can be passed to `addView`.

### Issues:

* Fixes: https://github.com/flutter/flutter/issues/137377

### Info

Most interesting files:

* `app_bootstrap.dart` -> Adds the implementation for JS add/remove view.
* `js_app.dart` -> Adds the js-interop layer for the FlutterApp object, and the configuration type. (Two options: `hostElement` and `initialData`).
* `flutter_view_manager.dart` -> An abstraction over the `viewData` map that keeps related things together: viewData, js configuration options, register/unregister methods and a Stream<void> of modification events.

The rest of the changes were ""required"" to have a small demo that does anything (currently it lets me "register" views from javascript). I didn't add much in there, because probably it's already being worked on by @mdebbar; just fiddled with the constructor of the EngineFlutterView to create views from JS Config, and added a wrapper around the `viewData` map (`FlutterViewManager`) to prevent direct access to the Map.

## Usage

This is how I'm currently initializing my Flutter App, so I can "leak" the `flutterApp` to window and do things asynchronously after flutter loads:

```html
<script>
  window.addEventListener('load', async function(ev) {
    _flutter.loader.loadEntrypoint({
      onEntrypointLoaded: function(engineInitializer) {
        engineInitializer.initializeEngine({
          multiViewEnabled: true,
        }).then(function(appRunner) {
          return appRunner.runApp();
        }).then(onAppRunning);
      }
    });
    // Leak flutterApp to window so we can do async things...
    function onAppRunning(flutterApp) {
      console.log('Running app', flutterApp);
      window.flutterApp = flutterApp;
    }
  });
</script>
```

This to test:

 * Go on your JS console and use `flutterApp.addView({})` and see how that returns a Promise for the viewId it just added,
 * Now do `flutterApp.removeView(0)` (removes the implicitView), and see how everything starts crashing! (as expected) 
   * Get out of this weird state with a hot reload 🥳

[C++, Objective-C, Java style guides]: https://github.com/flutter/engine/blob/main/CONTRIBUTING.md#style
 2023-11-21 15:30:07 +00:00
skia-flutter-autoroll
1a7fb0fac9 Roll Skia from c244996e79d6 to c6d971f87d12 (1 revision) (flutter/engine#48268) 
https://skia.googlesource.com/skia.git/+log/c244996e79d6..c6d971f87d12

2023-11-21 briansalomon@gmail.com Fix Graphite-Dawn wasm build

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC brianosman@google.com,jacksongardner@google.com,jamesgk@google.com,rmistry@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2023-11-21 14:53:29 +00:00
skia-flutter-autoroll
418ffafcaa Roll Skia from 516357c42907 to c244996e79d6 (1 revision) (flutter/engine#48266) 
https://skia.googlesource.com/skia.git/+log/516357c42907..c244996e79d6

2023-11-21 kjlubick@google.com Revert "Remove other uses of SkFontMgr::RefDefault"

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC brianosman@google.com,jacksongardner@google.com,jamesgk@google.com,rmistry@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2023-11-21 14:00:18 +00:00
skia-flutter-autoroll
11e100c56f Roll Dart SDK from 99d9cf9bd05a to 5e7b22caba8a (1 revision) (flutter/engine#48264) 
https://dart.googlesource.com/sdk.git/+log/99d9cf9bd05a..5e7b22caba8a

2023-11-21 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com Version 3.3.0-155.0.dev

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/dart-sdk-flutter-engine
Please CC dart-vm-team@google.com,jacksongardner@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter Engine: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2023-11-21 13:39:22 +00:00
skia-flutter-autoroll
97fda7e694 Roll Dart SDK from 64cbfa6c51e6 to 99d9cf9bd05a (1 revision) (flutter/engine#48261) 
https://dart.googlesource.com/sdk.git/+log/64cbfa6c51e6..99d9cf9bd05a

2023-11-21 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com Version 3.3.0-154.0.dev

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/dart-sdk-flutter-engine
Please CC dart-vm-team@google.com,jacksongardner@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter Engine: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2023-11-21 09:37:05 +00:00
skia-flutter-autoroll
7662e2fdbf Roll Skia from 88a9e6328f93 to 516357c42907 (1 revision) (flutter/engine#48260) 
https://skia.googlesource.com/skia.git/+log/88a9e6328f93..516357c42907

2023-11-21 skia-autoroll@skia-public.iam.gserviceaccount.com Roll vulkan-deps from ac8158a19e0b to 856d90fb41aa (8 revisions)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC brianosman@google.com,jamesgk@google.com,jonahwilliams@google.com,rmistry@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2023-11-21 08:24:05 +00:00
skia-flutter-autoroll
f508c00d32 Roll Skia from a26e5a5771c8 to 88a9e6328f93 (1 revision) (flutter/engine#48259) 
https://skia.googlesource.com/skia.git/+log/a26e5a5771c8..88a9e6328f93

2023-11-21 skia-autoroll@skia-public.iam.gserviceaccount.com Roll ANGLE from 98d79260fa0e to 1169f6b4ae5c (4 revisions)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC brianosman@google.com,jamesgk@google.com,jonahwilliams@google.com,rmistry@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2023-11-21 07:36:26 +00:00
skia-flutter-autoroll
a0ad6a60c2 Roll Skia from f8daeeb7f092 to a26e5a5771c8 (2 revisions) (flutter/engine#48258) 
https://skia.googlesource.com/skia.git/+log/f8daeeb7f092..a26e5a5771c8

2023-11-21 skia-autoroll@skia-public.iam.gserviceaccount.com Roll SK Tool from bc36c8dc442c to da550068f28d
2023-11-21 skia-autoroll@skia-public.iam.gserviceaccount.com Roll Dawn from ff937f71a801 to b61659d71d46 (20 revisions)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC brianosman@google.com,jamesgk@google.com,jonahwilliams@google.com,rmistry@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2023-11-21 06:16:09 +00:00
skia-flutter-autoroll
3d2401779a Roll Dart SDK from f1fd14505782 to 64cbfa6c51e6 (1 revision) (flutter/engine#48257) 
https://dart.googlesource.com/sdk.git/+log/f1fd14505782..64cbfa6c51e6

2023-11-21 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com Version 3.3.0-153.0.dev

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/dart-sdk-flutter-engine
Please CC dart-vm-team@google.com,jonahwilliams@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter Engine: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2023-11-21 05:46:23 +00:00
YaTang
950ec4aed6 [PlatformView][Android]VirtualDisplay resize on Android31 and above (flutter/engine#47946) 
Resolves: https://github.com/flutter/flutter/issues/128920
 2023-11-20 19:16:02 -08:00
Matan Lurey
f0ccf7a9a3 [Impeller] Try replacing *desc with value/is_valid checks. (flutter/engine#48194) 
Some discussion here:
https://discord.com/channels/608014603317936148/1175215129135153202.

In short, `*<std::optional>` is [undefined
behavior](https://en.cppreference.com/w/cpp/utility/optional/operator*).
After talking to @bdero we are considering that this should never
happen.

I thought of a few different approaches here, none of them are great.
However given that this class is used quite minimally, this seems to
jive with similar patterns we're using in scene/scene_context.

---

Feel free to push back or suggest alternatives, mostly proposing this to
get brain juices flowing.
 2023-11-20 16:43:28 -08:00
skia-flutter-autoroll
1cfb9254d4 Roll Dart SDK from ee7aaca9adcc to f1fd14505782 (1 revision) (flutter/engine#48250) 
https://dart.googlesource.com/sdk.git/+log/ee7aaca9adcc..f1fd14505782

2023-11-20 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com Version 3.3.0-152.0.dev

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/dart-sdk-flutter-engine
Please CC dart-vm-team@google.com,jonahwilliams@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter Engine: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2023-11-21 00:10:23 +00:00
skia-flutter-autoroll
c8d8eaf0f4 Roll Skia from 3876e576a38e to f8daeeb7f092 (1 revision) (flutter/engine#48249) 
https://skia.googlesource.com/skia.git/+log/3876e576a38e..f8daeeb7f092

2023-11-20 briansalomon@gmail.com [graphite] Expose Dawn async buffer mapping through Buffer class

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC brianosman@google.com,jamesgk@google.com,jonahwilliams@google.com,rmistry@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2023-11-21 00:03:24 +00:00
skia-flutter-autoroll
4cd10d0a1b Roll Skia from c9943f14039f to 3876e576a38e (3 revisions) (flutter/engine#48246) 
https://skia.googlesource.com/skia.git/+log/c9943f14039f..3876e576a38e

2023-11-20 kjlubick@google.com Pass TestFontMgr in when deserializing skps in dm
2023-11-20 kjlubick@google.com Remove other uses of SkFontMgr::RefDefault
2023-11-20 johnstiles@google.com Replace -march= with -mfeature toggles.

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC brianosman@google.com,jamesgk@google.com,jonahwilliams@google.com,rmistry@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2023-11-20 22:50:21 +00:00
Matan Lurey
f9adfbc62c Make runtime/... and shell/common/... compatible with .clang-tidy. (flutter/engine#48158) 2023-11-20 14:31:49 -08:00
sunhongjie
13f3bd212b Fix embedder glfw examples cmake subdirectory path error (flutter/engine#48013) 
Fix just a cmake glfw subdirectory path error in embedder examples.

Fix: https://github.com/flutter/flutter/issues/138340
 2023-11-20 22:18:37 +00:00
Matan Lurey
93104224e3 Silence a lint in common/settings.h in order to turn on clang_tidy. (flutter/engine#48239) 
See https://github.com/flutter/flutter/issues/138750.
 2023-11-20 22:12:53 +00:00
skia-flutter-autoroll
d9dcf0228b Roll Fuchsia Linux SDK from LnToEykA8o68jv58K... to Q3HcTitDF90ZOPWDa... (flutter/engine#48244) 
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/fuchsia-linux-sdk-flutter-engine
Please CC jonahwilliams@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2023-11-20 22:12:50 +00:00
skia-flutter-autoroll
a6a706cdad Roll Skia from 2bcc2e8682a6 to c9943f14039f (1 revision) (flutter/engine#48243) 
https://skia.googlesource.com/skia.git/+log/2bcc2e8682a6..c9943f14039f

2023-11-20 brianosman@google.com Fix numerous cases of casting away const

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC brianosman@google.com,jamesgk@google.com,jonahwilliams@google.com,rmistry@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2023-11-20 21:46:29 +00:00
Matan Lurey
fcd9c27649 Make vulkan/... compatible with .clang_tidy. (flutter/engine#48240) 
Missed this straggler in a previous PR. Ezpz.
 2023-11-20 21:30:07 +00:00
Matan Lurey
7cc1f2f98c [Impeller] Write a text-decoration test at the dart:ui layer (flutter/engine#48101) 
Closes https://github.com/flutter/flutter/issues/138501.

---

It would be nice to turn this into a test-fixture, and create a better local environment.

Here is how to run it locally:

```bash
# The test expects you to be PWD in the `src` directory or it crashes.
cd $ENGINE_SRC

out/host_debug_unopt_arm64/flutter_tester \
  --force-multithreading \
  --disable-observatory \
  --use-test-fonts \
  --icu-data-file-path=out/host_debug_unopt_arm64/icudtl.dat \
  --flutter-assets-dir=out/host_debug_unopt_arm64/gen/flutter/lib/ui/assets \
  --disable-asset-fonts \
  --enable-impeller \
  out/host_debug_unopt_arm64/gen/canvas_test.dart.dill

# "See" the output goldens.
open out/host_debug_unopt_arm64/gen/skia_gold_canvas_test.dart
```

![image](https://github.com/flutter/engine/assets/168174/3deeab8d-409d-4b2e-8bdf-1cae272636f8)
 2023-11-20 21:07:05 +00:00
skia-flutter-autoroll
fc50f4cca5 Roll Skia from 69213ba6f68a to 2bcc2e8682a6 (1 revision) (flutter/engine#48238) 
https://skia.googlesource.com/skia.git/+log/69213ba6f68a..2bcc2e8682a6

2023-11-20 kjlubick@google.com Re-enable legacy SkFontMgr factory for Android

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC brianosman@google.com,jamesgk@google.com,jonahwilliams@google.com,rmistry@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2023-11-20 20:44:16 +00:00
Reid Baker
6f6ca74b5e Protect sdk upload script from missing ndk, add documentation for checking write access, improve comments to add context (flutter/engine#47989) 
Script used to upload 34v7 with ndk 26.1.10909125 
Added documentation for how to check for write access before running script. 
Added documentation for why the ndk is in a non standard location. 
Protected against silent ndk failure caused by a failure to download ndk on m1 macs https://github.com/flutter/engine/pull/47609#issuecomment-1800207937
Clean up os override so that script does not dirty the environment variables in a shell where it is run.  

See https://github.com/flutter/flutter/issues/117973 for more detail on why a newer ndk is required.
 2023-11-20 20:42:23 +00:00
skia-flutter-autoroll
41b5d9116b Roll Dart SDK from 09bd5d71062d to ee7aaca9adcc (1 revision) (flutter/engine#48237) 
https://dart.googlesource.com/sdk.git/+log/09bd5d71062d..ee7aaca9adcc

2023-11-20 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com Version 3.3.0-151.0.dev

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/dart-sdk-flutter-engine
Please CC dart-vm-team@google.com,jonahwilliams@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter Engine: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2023-11-20 20:30:00 +00:00
skia-flutter-autoroll
6d9200b4af Roll Skia from 151d297efcf5 to 69213ba6f68a (2 revisions) (flutter/engine#48236) 
https://skia.googlesource.com/skia.git/+log/151d297efcf5..69213ba6f68a

2023-11-20 lehoangquyen@chromium.org GraphiteDawn: cache single texture bind group
2023-11-20 skia-autoroll@skia-public.iam.gserviceaccount.com Roll vulkan-deps from 63bb05a5e0ad to ac8158a19e0b (1 revision)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC brianosman@google.com,jamesgk@google.com,jonahwilliams@google.com,rmistry@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2023-11-20 20:07:13 +00:00
skia-flutter-autoroll
ead9769060 Roll Skia from e9206d29ef07 to 151d297efcf5 (1 revision) (flutter/engine#48235) 
https://skia.googlesource.com/skia.git/+log/e9206d29ef07..151d297efcf5

2023-11-20 jamesgk@google.com [sksl] Support FB fetch in Dawn

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC brianosman@google.com,jamesgk@google.com,jonahwilliams@google.com,rmistry@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2023-11-20 19:23:16 +00:00
skia-flutter-autoroll
61eefd3758 Roll Skia from 795a259c2f56 to e9206d29ef07 (3 revisions) (flutter/engine#48231) 
https://skia.googlesource.com/skia.git/+log/795a259c2f56..e9206d29ef07

2023-11-20 kjlubick@google.com Extract Vulkan methods out of GrBackendSemaphore
2023-11-20 nscobie@google.com Allow SkQP to be shardable
2023-11-20 jamesgk@google.com Manual Dawn roll

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC brianosman@google.com,jamesgk@google.com,jonahwilliams@google.com,rmistry@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2023-11-20 18:29:05 +00:00
Mouad Debbar
5c93379571 [web] EngineFlutterView.dispose() (flutter/engine#48183) 
- New `EngineFlutterView.dispose()` to cleanup when the view is removed (and in hot restart).
- `EnginePlatformDispatcher.dispose()` now disposes of all of its registered views.
 2023-11-20 17:21:22 +00:00
skia-flutter-autoroll
9c7f9eabf8 Roll Skia from 64d1e14df168 to 795a259c2f56 (2 revisions) (flutter/engine#48227) 
https://skia.googlesource.com/skia.git/+log/64d1e14df168..795a259c2f56

2023-11-20 johnstiles@google.com Fix fuzzer-discovered timeout with deeply-nested structs.
2023-11-20 kjlubick@google.com Reland "Turn on SK_DISABLE_LEGACY_FONTMGR_FACTORY"

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC brianosman@google.com,jamesgk@google.com,jonahwilliams@google.com,rmistry@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2023-11-20 16:50:02 +00:00
skia-flutter-autoroll
1211f7d2e3 Roll Skia from a874e29d71c0 to 64d1e14df168 (1 revision) (flutter/engine#48225) 
https://skia.googlesource.com/skia.git/+log/a874e29d71c0..64d1e14df168

2023-11-20 kjlubick@google.com Remove SK_DISABLE_LEGACY_VK_GRDIRECTCONTEXT_FACTORIES

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC brianosman@google.com,jamesgk@google.com,jonahwilliams@google.com,rmistry@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2023-11-20 15:51:40 +00:00
skia-flutter-autoroll
bf66a69e54 Roll Dart SDK from 564cfb2cfe79 to 09bd5d71062d (1 revision) (flutter/engine#48222) 
https://dart.googlesource.com/sdk.git/+log/564cfb2cfe79..09bd5d71062d

2023-11-20 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com Version 3.3.0-150.0.dev

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/dart-sdk-flutter-engine
Please CC dart-vm-team@google.com,jonahwilliams@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter Engine: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2023-11-20 13:44:06 +00:00
Kevin Lubick
0d0d4db144 Replace calls to SkFontMgr::RefDefault (flutter/engine#48179) 
Skia is removing this API, so clients must track a default FontMgr if
they want one. See https://issues.skia.org/issues/305780908

## Pre-launch Checklist

- [x] I read the [Contributor Guide] and followed the process outlined
there for submitting PRs.
- [x] I read the [Tree Hygiene] wiki page, which explains my
responsibilities.
- [x] I read and followed the [Flutter Style Guide] and the [C++,
Objective-C, Java style guides].
- [x] I listed at least one issue that this PR fixes in the description
above.
- [x] I added new tests to check the change I am making or feature I am
adding, or the PR is [test-exempt]. See [testing the engine] for
instructions on writing and running engine tests.
- [x] I updated/added relevant documentation (doc comments with `///`).
- [x] I signed the [CLA].
- [x] All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel
on [Discord].

<!-- Links -->
[Contributor Guide]:
https://github.com/flutter/flutter/wiki/Tree-hygiene#overview
[Tree Hygiene]: https://github.com/flutter/flutter/wiki/Tree-hygiene
[test-exempt]:
https://github.com/flutter/flutter/wiki/Tree-hygiene#tests
[Flutter Style Guide]:
https://github.com/flutter/flutter/wiki/Style-guide-for-Flutter-repo
[C++, Objective-C, Java style guides]:
https://github.com/flutter/engine/blob/main/CONTRIBUTING.md#style
[testing the engine]:
https://github.com/flutter/flutter/wiki/Testing-the-engine
[CLA]: https://cla.developers.google.com/
[flutter/tests]: https://github.com/flutter/tests
[breaking change policy]:
https://github.com/flutter/flutter/wiki/Tree-hygiene#handling-breaking-changes
[Discord]: https://github.com/flutter/flutter/wiki/Chat
 2023-11-20 07:57:02 -05:00
skia-flutter-autoroll
fec11b4480 Roll Skia from 5010d0578f4d to a874e29d71c0 (1 revision) (flutter/engine#48216) 
https://skia.googlesource.com/skia.git/+log/5010d0578f4d..a874e29d71c0

2023-11-20 skia-autoroll@skia-public.iam.gserviceaccount.com Roll ANGLE from 8ae36a93bedc to 98d79260fa0e (5 revisions)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC brianosman@google.com,jamesgk@google.com,jonahwilliams@google.com,rmistry@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2023-11-20 07:27:24 +00:00
Zachary Anderson
aa3f8e61c1 Moves expat, ocmock, libjpeg-turbo, libwebp, and wuffs to //flutter/third_party (flutter/engine#48193) 
As part of eliminating the Flutter buildroot
(https://github.com/flutter/flutter/issues/67373), we are moving all
third-party dependencies from //third_party to //flutter/third_party.

Once all third-party dependencies have been migrated, tooling and config
will be moved and the buildroot will be eliminated altogether.

No tests changed because there is no semantic change to this PR. This is
simply relocating a dependency.

This PR moves expat, ocmock, libjpeg-turbo, libwebp, and wuffs to
//flutter/third_party.

It also deletes //third_party/fontconfig, which was unused.
 2023-11-19 22:53:29 -08:00
skia-flutter-autoroll
e4b3ff8afc Roll Skia from 343b249b2cac to 5010d0578f4d (1 revision) (flutter/engine#48215) 
https://skia.googlesource.com/skia.git/+log/343b249b2cac..5010d0578f4d

2023-11-20 skia-autoroll@skia-public.iam.gserviceaccount.com Roll SK Tool from 70ea436295e7 to f4a0318d3443

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC brianosman@google.com,jamesgk@google.com,jonahwilliams@google.com,rmistry@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2023-11-20 06:10:22 +00:00