3849 Commits

Author SHA1 Message Date
Ian Fischer
1dfcbbd76d Avoid crashing when an iOS device isn’t connected. 2015-08-31 10:41:52 -07:00
James Robinson
503a507f14 Merge pull request #958 from jamesr/fix_android_build
Fix android build
2015-08-31 10:30:26 -07:00
James Robinson
997722db17 Fix android build
The OS_FOO macros are set by build/build_config.h, so be sure to
include that before testing the macros.
2015-08-31 10:24:39 -07:00
James Robinson
e2b960ecc3 Merge pull request #956 from jamesr/ui_gl_trim
Trim unused code from //ui/gl
2015-08-31 10:15:16 -07:00
James Robinson
04344ddb27 Trim unused code from //ui/gl
This deletes lots of unused code from //ui/gl:

*) GLImage and GLFence are not used or likely to be used soon

*) GLX/X11/Ozone are not used, Sky doesn't draw to screen on these platforms

*) EGL code is used exclusively on Android

This also restricts the use of the third_party/khronos headers to only Android
builds, where they are used to pick up a few enum values from EGL not present
in the NDK's copy of the headers.
2015-08-31 10:00:42 -07:00
Adam Barth
9f43b5a490 Merge pull request #953 from abarth/painting_docs
Add dartdoc for the painting code
2015-08-31 09:37:10 -07:00
Adam Barth
e2638c189d Add dartdoc for the painting code 2015-08-31 09:36:35 -07:00
Adam Barth
bb427e08e1 Merge pull request #952 from abarth/lerp
Move lerp for the engine types into dart:sky
2015-08-31 09:25:35 -07:00
Adam Barth
96e203329c Move lerp for the engine types into dart:sky
This patch just adds them to dart:sky. A future patch will actually use them in
the framework once we've published an updated sky_engine package. Also, add
dartdoc to the classes touched in this patch.
2015-08-31 09:25:22 -07:00
Adam Barth
29b0c96e46 Merge pull request #955 from abarth/can_flex_overflow
onPressed not called when in a Positioned Flex
2015-08-31 09:17:00 -07:00
Adam Barth
c6c4c5d26a onPressed not called when in a Positioned Flex
We were setting the main axis extent to zero because we had a sign error.

Fixes #918
2015-08-31 09:12:40 -07:00
Adam Barth
088958e8f6 Unbreak link when deployed 2015-08-30 18:43:17 -07:00
Ian Hickson
969dfe5273 Add gestures/ to README.md prose 2015-08-30 16:30:59 -07:00
Ian Hickson
9152f4643f Add gestures/ to README.md diagram 2015-08-30 16:29:48 -07:00
Adam Barth
06e43c0992 Merge pull request #951 from abarth/skydoc
Update skydoc.py now that dartdoc is in the Dart SDK
2015-08-30 15:08:58 -07:00
Adam Barth
bd01a89958 Update skydoc.py now that dartdoc is in the Dart SDK
Now that dartdoc is part of the Dart SDK, we can use the SDK version directly.
2015-08-30 13:38:54 -07:00
Adam Barth
464e3d8ddc Merge pull request #950 from abarth/base_docs
Add dartdoc for base
2015-08-30 13:03:40 -07:00
Adam Barth
92857ceef8 Add dartdoc for base 2015-08-30 13:03:03 -07:00
Adam Barth
bffdcf84f5 Update box_painter.dart 2015-08-30 11:03:00 -07:00
Adam Barth
0d3c62ef72 Merge pull request #946 from abarth/infinite_border_radius
BoxDecoration's borderRadius should be able to handle a value of double.INFINITY
2015-08-29 22:34:30 -07:00
Adam Barth
d4de1c684e Merge pull request #947 from abarth/scroll_immediately
Scrolls should start immediately when possible
2015-08-29 22:34:02 -07:00
Adam Barth
2dd8365201 Scrolls should start immediately when possible
If there are no other gestures in the arena, we should kick off the scroll
gesture right away. This change pulled a refactoring of how we dispatch events
to Widgets. Now we dispatch events to Widgets interleaved with their associated
RenderObjects. (Previously we dispatched to all of the RenderObjects first.)
2015-08-29 22:30:49 -07:00
Adam Barth
d5534a20b8 Pull in a new version of playfair
We need the new version because of the TextPainter rename.
2015-08-29 15:54:43 -07:00
Adam Barth
058c9c9a57 Merge pull request #949 from abarth/text_painter
Rename ParagraphPainter to TextPainter
2015-08-29 15:50:15 -07:00
Adam Barth
8d0a2426a6 Rename ParagraphPainter to TextPainter
Also, add asserts that the text has layout before being painted.
2015-08-29 11:41:20 -07:00
Adam Barth
acec6d0171 BoxDecoration's borderRadius should be able to handle a value of double.INIFINITY
We just need to enforce some finite clamp and Skia will do the rest.

Fixes #939
2015-08-28 20:58:34 -07:00
Adam Barth
34468e3c65 Merge pull request #945 from abarth/fix_analyzer
Remove unused import to make analyzer happy
2015-08-28 20:51:26 -07:00
Adam Barth
8a92f2d0c7 Remove unused import to make analyzer happy 2015-08-28 20:50:54 -07:00
Adam Barth
d45ca99539 Merge pull request #941 from abarth/scroll_disambig
Disambiguate horizontal and vertical scrolling
2015-08-28 20:33:31 -07:00
Adam Barth
bf3db503fd Disambiguate horizontal and vertical scrolling
We now have separate gestures for horizontal, vertical, and pan scrolling.
2015-08-28 20:33:14 -07:00
Ian Fischer
cdbb26c627 Merge pull request #944 from iansf/no_android
Don't crash when no Android device is attached
2015-08-28 19:28:51 -07:00
Misha Dynin
9d19587e9d Fixed a typo in the README. 2015-08-28 17:54:14 -07:00
Ian Fischer
987d0d5f7d Make it so that sky_tool doesn’t crash if an Android device isn’t attached.
Refactors a bunch of Android-related things into an AndroidDevice singleton class.
2015-08-28 17:13:39 -07:00
Ian Hickson
cdeab155d1 Merge pull request #942 from Hixie/mixed-mid
Fix crash when a MixedViewport is initially offset at a non-zero position
2015-08-28 16:59:43 -07:00
Ian Hickson
b1457e1dbd Merge pull request #938 from Hixie/mixed-test
Test MixedViewport
2015-08-28 16:59:37 -07:00
Hixie
c308cfbf1e Test MixedViewport
add/remove/add smoketest
basic vertical behaviour
basic horizontal behaviour
2015-08-28 16:59:10 -07:00
Hixie
7a53576ff8 Fix crash when a MixedViewport is initially offset at a non-zero position.
We need to always remove the widget when you sync a non-visible
widget, even if we already have it, because otherwise we'll try to
sync it with null again later, which causes a crash.

Test in #938.
2015-08-28 16:57:05 -07:00
Viktor Lidholt
0ea2404511 Merge pull request #940 from vlidholt/master
Improvements to demo game
2015-08-28 16:16:51 -07:00
Adam Barth
537a192e50 Rev pub package 2015-08-28 16:13:02 -07:00
Adam Barth
fc3e91600c Rev pub package 2015-08-28 16:08:30 -07:00
Viktor Lidholt
eb6a09c55c Adds power-ups to demo game 2015-08-28 16:07:00 -07:00
Viktor Lidholt
435e3a5fbd Adds new enemies and coin display to demo game 2015-08-28 16:07:00 -07:00
Ian Hickson
d317255ca3 Merge pull request #904 from Hixie/mixed
Set and remove the callbacks on the RenderObject when we create and remove it.
2015-08-28 15:29:13 -07:00
Hixie
9fee250249 Set and remove the callbacks on the RenderObject when we create and remove it.
...and not when we mount and dismount.

Turns out that when we dismount, it's too late -- we've already set
renderObject to null.

We also mark the mixed viewport as dirty when it is removed from its parent.
Without this, we try to reuse the child nodes in subsequent syncs, which is a disaster.
2015-08-28 15:07:51 -07:00
Adam Barth
3e4bc25dbc Merge pull request #934 from abarth/scroll_start
onScrollStart shouldn't have an offset
2015-08-28 15:07:42 -07:00
Adam Barth
ab13ea240d onScrollStart shouldn't have an offset
Instead, we pump a onScrollUpdate with the offset if there is an offset.
2015-08-28 15:07:30 -07:00
Adam Barth
34d0a06b6b Merge pull request #933 from abarth/rm_only
Remove --only from run_tests
2015-08-28 14:52:28 -07:00
Adam Barth
e25c6aafa3 Remove --only from run_tests
This feature is built into package:test. We don't need to reimplement it
poorly.
2015-08-28 14:39:53 -07:00
Ian Hickson
6a09a45848 Merge pull request #932 from Hixie/mixed-direction
Add support for 'direction' to MixedViewport.
2015-08-28 14:37:30 -07:00
Hixie
2f3d1fdeb8 Add support for 'direction' to MixedViewport. 2015-08-28 14:27:51 -07:00