DEV/flutter_flutter
1
0
Fork 0
mirror of https://github.com/flutter/flutter.git synced 2026-02-20 02:29:02 +08:00
Code Issues Packages Projects Releases Wiki Activity
28,584 Commits 882 Branches 1,069 Tags
Commit Graph

28584 Commits

This Branch
This Branch
All Branches
Author SHA1 Message Date
skia-flutter-autoroll
048742f9fc Roll Fuchsia Mac SDK from Du6g64Nirs3tZVK6i... to Rk2iPE0_H1vjuGV4e... (flutter/engine#41551) 
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/fuchsia-mac-sdk-flutter-engine
Please CC jsimmons@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2023-04-27 12:52:20 +00:00
Jonah Williams
144af3487e Reland: [Impeller] Use a device buffer for SkBitmap allocation, use Linear texture on Metal backend. (flutter/engine#41538) 
Original PR: https://github.com/flutter/engine/pull/41374

This was reverted because it broke on simulators as they do not support linear textures. To fix this, I've ifdef'd out the DeviceBufferMTL implementation of AsTexture so that it falls back to the slow path copy. Also updated the capabilities check so that the glyph atlas updates the texture contents when it changes.
 2023-04-27 04:33:04 +00:00
Jonah Williams
3335dcd1ee [Impeller] allow shader read for root resolve texture (flutter/engine#41543) 
This fixes a validation error I see from Xcode running the backdrop filter benchmarks
 2023-04-27 03:44:35 +00:00
skia-flutter-autoroll
9a1647725b Roll Skia from 3b14dcad64ef to 8441d7a93942 (1 revision) (flutter/engine#41542) 
https://skia.googlesource.com/skia.git/+log/3b14dcad64ef..8441d7a93942

2023-04-27 skia-autoroll@skia-public.iam.gserviceaccount.com Roll SK Tool from dec3646b8299 to dbcb144ecb6f

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC brianosman@google.com,jsimmons@google.com,rmistry@google.com,tdenniston@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2023-04-27 02:24:02 +00:00
godofredoc
ad4136d438 reland "Migrate mac_host_engine to engine v2 builds." (flutter/engine#41531) 
Relands: https://github.com/flutter/engine/pull/41149

GN+Ninja artifacts have been validated manually. The number of files and their content is the same and presubmit tests are passing correctly in the engine and flutter.

The reason of previous reverts are:

* FlutterMacOS.framework.zip required to be double zipped.
* FlutterMacOS.dSYM.zip required to be double zipped.
* GCS cache header needed to be updated during testing.

Full details of what has been fixed can be found in: https://github.com/flutter/flutter/issues/124911
 2023-04-27 01:41:48 +00:00
Zachary Anderson
34e0961a83 Roll buildroot to 5708f2051772fd02c949e5dc9397e54f8c7a4478 (flutter/engine#41540) 
To pick up https://github.com/flutter/buildroot/pull/722
 2023-04-27 01:18:48 +00:00
skia-flutter-autoroll
f14172c0a9 Roll Skia from d315ab065af3 to 3b14dcad64ef (1 revision) (flutter/engine#41539) 
https://skia.googlesource.com/skia.git/+log/d315ab065af3..3b14dcad64ef

2023-04-26 skia-autoroll@skia-public.iam.gserviceaccount.com Roll vulkan-deps from 66646c61d508 to 0f6da54b821b (4 revisions)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC brianosman@google.com,jsimmons@google.com,rmistry@google.com,tdenniston@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2023-04-27 00:50:02 +00:00
skia-flutter-autoroll
124b05b31c Roll Dart SDK from 3d444bc30fc4 to 497a81b1af4f (1 revision) (flutter/engine#41537) 
https://dart.googlesource.com/sdk.git/+log/3d444bc30fc4..497a81b1af4f

2023-04-26 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com Version 3.1.0-48.0.dev

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/dart-sdk-flutter-engine
Please CC aam@google.com,dart-vm-team@google.com,jsimmons@google.com,rmistry@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter Engine: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2023-04-27 00:18:55 +00:00
skia-flutter-autoroll
af9c210a12 Roll Fuchsia Mac SDK from rM9DAwmAeMc8pV11x... to Du6g64Nirs3tZVK6i... (flutter/engine#41536) 
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/fuchsia-mac-sdk-flutter-engine
Please CC jsimmons@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2023-04-27 00:09:13 +00:00
skia-flutter-autoroll
e8471152c2 Roll Skia from 20a1c61c5597 to d315ab065af3 (5 revisions) (flutter/engine#41535) 
https://skia.googlesource.com/skia.git/+log/20a1c61c5597..d315ab065af3

2023-04-26 brianosman@google.com Remove SkBlitter::justAnOpaqueColor
2023-04-26 johnstiles@google.com Wrap SkRP ops in #ifdef SK_ENABLE_SKSL_IN_RASTER_PIPELINE.
2023-04-26 johnstiles@google.com Switch Bazel builds to use SkRP by default.
2023-04-26 brianosman@google.com Miscellaneous blitter cleanup
2023-04-26 herb@google.com Add difficult test cases for sk_doubles_nearly_equal_ulps

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC brianosman@google.com,jsimmons@google.com,rmistry@google.com,tdenniston@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2023-04-27 00:04:06 +00:00
Jonah Williams
2c38f993b8 Revert "[Impeller] Use a device buffer for SkBitmap allocation, use Linear texture on Metal backend." (flutter/engine#41533) 
Reverts flutter/engine#41374

Breaks on Simulators!
 2023-04-26 23:05:29 +00:00
Xilai Zhang
fd46ca5e9d [codesign] Add pinned xcode version as property to mac android aot engine (flutter/engine#41518) 
context: https://github.com/flutter/flutter/issues/125570#issuecomment-1523823942

Pin xcode version for the six sub builds in mac android aot engine
 2023-04-26 22:58:15 +00:00
Brandon DeRosier
45127462d5 [Impeller] Coerce opaque ColorSourceContents to Source (flutter/engine#41525) 
This coercion happens when Entities are appended to a pass, which is the
moment where we will need to perform depth sorting.
 2023-04-26 15:56:54 -07:00
skia-flutter-autoroll
30ff8dfa06 Roll Skia from 3fea88565a83 to 20a1c61c5597 (3 revisions) (flutter/engine#41530) 
https://skia.googlesource.com/skia.git/+log/3fea88565a83..20a1c61c5597

2023-04-26 sunnyps@chromium.org graphite: Fix DrawPass::SortKey static_assert for 32-bit builds
2023-04-26 armansito@google.com [graphite] Redefine PrioritizeGpuReads as AccessPattern
2023-04-26 cmumford@google.com Merge 1 release notes into RELEASE_NOTES.md

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC brianosman@google.com,jsimmons@google.com,rmistry@google.com,tdenniston@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2023-04-26 21:32:51 +00:00
Jonah Williams
8167e14475 [Impeller] partial repaint for Impeller/iOS. (flutter/engine#40959) 
Implements partial repaint for Impeller.

Fixes https://github.com/flutter/flutter/issues/124526

The new code that manages the damage regions is more or less a copy paste from the existing Skia implementation. Compared to Skia, there are a few differences:

Normally Impeller wants to use the drawable as the resolve texture for the root MSAA pass. Unfortunately this will unconditonally clear that texture. Thus to do a partial repaint, we have to allocate a separate texture to resolve to and then blit into the drawable.

The blit seems to take about 500ns for a full screen on an iPhone 13. That implies that partial repaint is likely not worth doing if the screen is significantly changed. Thus I've added code in compositor_context.cc that computes the percentage of width or height that is part of the dirty rect. Above a threshold of (abitrarily chosen) 70%, we just render as normal. This should mean there is only a very minor hit from performing the diff on screens that are highly changed.

The other special case, is that sometimes we get damage rects that are empty - that is the drawable is already completely up to date with what we want to render. IN that case I shortcircuit all of the impeller code and just present immediately. I previously tried returning without a present but this resulted in Xcode reporting dropped frames. One caveat here is that if you use the XCode frame debugger and attempt to capture a frame where we early present, then it will claim it couldn't capture any command buffers (because we didn't create any).

To facilitate all of this, I added some additonal plumbing so that the impeller surface can get the clip rect from the submit info. Additionally, rather than using a clip rect impeller will translate and then shrink the root surface texture. This reduces memory usage compared to just clippling.
 2023-04-26 21:13:03 +00:00
gaaclarke
276fce5441 Updated todo with github issue link (flutter/engine#41517) 
followup from https://github.com/flutter/engine/pull/41490

## Pre-launch Checklist

- [x] I read the [Contributor Guide] and followed the process outlined
there for submitting PRs.
- [x] I read the [Tree Hygiene] wiki page, which explains my
responsibilities.
- [x] I read and followed the [Flutter Style Guide] and the [C++,
Objective-C, Java style guides].
- [ ] I listed at least one issue that this PR fixes in the description
above.
- [ ] I added new tests to check the change I am making or feature I am
adding, or Hixie said the PR is test-exempt. See [testing the engine]
for instructions on writing and running engine tests.
- [x] I updated/added relevant documentation (doc comments with `///`).
- [x] I signed the [CLA].
- [x] All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel
on [Discord].

<!-- Links -->
[Contributor Guide]:
https://github.com/flutter/flutter/wiki/Tree-hygiene#overview
[Tree Hygiene]: https://github.com/flutter/flutter/wiki/Tree-hygiene
[Flutter Style Guide]:
https://github.com/flutter/flutter/wiki/Style-guide-for-Flutter-repo
[C++, Objective-C, Java style guides]:
https://github.com/flutter/engine/blob/main/CONTRIBUTING.md#style
[testing the engine]:
https://github.com/flutter/flutter/wiki/Testing-the-engine
[CLA]: https://cla.developers.google.com/
[flutter/tests]: https://github.com/flutter/tests
[breaking change policy]:
https://github.com/flutter/flutter/wiki/Tree-hygiene#handling-breaking-changes
[Discord]: https://github.com/flutter/flutter/wiki/Chat
 2023-04-26 13:09:50 -07:00
skia-flutter-autoroll
7392d65f7a Roll Clang from 20d06c833d83 to 5344d8e10bb7 (flutter/engine#41524) 
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/clang-flutter-engine
Please CC jsimmons@google.com,rmistry@google.com,zanderso@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Clang: https://bugs.fuchsia.dev/p/fuchsia/issues/list?q=component%3AToolchain
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2023-04-26 20:07:55 +00:00
Jonah Williams
70457cca4f [Impeller] Use a device buffer for SkBitmap allocation, use Linear texture on Metal backend. (flutter/engine#41374) 
This reduces the cost of uploading the glyph atlas, as we can exploit metal's capabilies to create a texture from a device buffer and share the underlying memory with a linear texture. This also means that subsequent updates don't require uploads or copies either.

From scrolling through wonderous, this shaves off about 0.2 ms (0.6 ms -> 0.4 ms) of fresh atlas construction.
 2023-04-26 19:45:05 +00:00
Zachary Anderson
a9c765022b Manual clang roll to 5344d8e10bb7d8672d4bfae8adb010465470d51b (flutter/engine#41520) 2023-04-26 12:41:31 -07:00
Zachary Anderson
c8c65d837a Download and use the goma client from cipd (flutter/engine#41488) 
In https://github.com/flutter/flutter/issues/125361 we discovered that a
new version of clang can require updating goma in order for goma to work
properly. This PR adds a dependency on CIPD goma to the DEPS file so
that we can update it for use in local builds when needed. Since CI does
its own management of the goma client and the compiler proxy, and since
goma can only be used by Googlers, the DEPS file download is guarded
behind the `use_cipd_goma` gclient var. To use it one would update the
engine `.gclient` file to be something like:
```
~/flutter/engine/src $ cat ../.gclient
solutions = [
  {
    "managed": False,
    "name": "src/flutter",
    "url": "git@github.com:zanderso/engine.git",
    "custom_deps": {},
    "custom_vars": {
      "use_cipd_goma": True,
    },
    "deps_file": "DEPS",
    "safesync_url": "",
  },
]
```

I'll update the wiki with these instructions after this PR lands.
 2023-04-26 11:30:07 -07:00
godofredoc
ea69f2504d Migrate Windows AOT Engine to Engine V2. (flutter/engine#41515) 
Both builds are generating artifacts in the same way. This is moving the legacy builder to staging and updating Windows windows_aot_engine build to upload artifacts to prod.

[C++, Objective-C, Java style guides]: https://github.com/flutter/engine/blob/main/CONTRIBUTING.md#style
 2023-04-26 17:56:21 +00:00
Brandon DeRosier
1a2dfa3522 [Impeller] Store the root stencil on iOS (flutter/engine#41509) 
Switch the root RenderPass stencil from transient to device private, add
validation logs, and dry the offscreen stencil setup. Also make the
multisample root stencil setup valid in Vulkan (the attachment
mismatched the texture -- this didn't matter before since we were always
replacing it).

Fixes a bug where the stencil gets erased between root render passes --
this issue was introduced when we removed the root blit on iOS.
 2023-04-26 10:51:12 -07:00
Brandon DeRosier
280c4f0e46 [Impeller] iOS/macOS: Only wait for command scheduling prior to present (redux) (flutter/engine#41501) 
Reverts https://github.com/flutter/engine/pull/40895.
Resolves https://github.com/flutter/flutter/issues/120399 (again).

A bunch of frames get pumped on the main thread _without a transaction_
just before unmerging occurs (I don't know why this happens), and so
checking the current thread to determine whether we need to present with
a transaction or not isn't sufficient. In the prior fix, after the
unmerge, the raster thread would hang for one second while waiting for
the next drawable to get freed up (happens on the second raster thread
frame post-unmerge), and then subsequent presents would just do nothing
for a while, but eventually recover.

`presentsWithTransaction` works whether the `CATransaction` stack is
empty or not, and so the only difference here is that
`presentsWithTransaction` is always turned on and `presentDrawable` is
always avoided (otherwise it tries to present too early and nothing
renders when platform views are present).
 2023-04-26 10:50:51 -07:00
gaaclarke
98718ceb9b [Impeller] removed collisions of dead command pools between tests. (flutter/engine#41490) 
fixes https://github.com/flutter/flutter/issues/125321

Tests coverage from existing tests (see issue).

## Pre-launch Checklist

- [x] I read the [Contributor Guide] and followed the process outlined
there for submitting PRs.
- [x] I read the [Tree Hygiene] wiki page, which explains my
responsibilities.
- [x] I read and followed the [Flutter Style Guide] and the [C++,
Objective-C, Java style guides].
- [x] I listed at least one issue that this PR fixes in the description
above.
- [ ] I added new tests to check the change I am making or feature I am
adding, or Hixie said the PR is test-exempt. See [testing the engine]
for instructions on writing and running engine tests.
- [x] I updated/added relevant documentation (doc comments with `///`).
- [x] I signed the [CLA].
- [x] All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel
on [Discord].

<!-- Links -->
[Contributor Guide]:
https://github.com/flutter/flutter/wiki/Tree-hygiene#overview
[Tree Hygiene]: https://github.com/flutter/flutter/wiki/Tree-hygiene
[Flutter Style Guide]:
https://github.com/flutter/flutter/wiki/Style-guide-for-Flutter-repo
[C++, Objective-C, Java style guides]:
https://github.com/flutter/engine/blob/main/CONTRIBUTING.md#style
[testing the engine]:
https://github.com/flutter/flutter/wiki/Testing-the-engine
[CLA]: https://cla.developers.google.com/
[flutter/tests]: https://github.com/flutter/tests
[breaking change policy]:
https://github.com/flutter/flutter/wiki/Tree-hygiene#handling-breaking-changes
[Discord]: https://github.com/flutter/flutter/wiki/Chat
 2023-04-26 10:23:28 -07:00
skia-flutter-autoroll
3dad6c5612 Roll Skia from a0e3fa5aa947 to 3fea88565a83 (3 revisions) (flutter/engine#41516) 
https://skia.googlesource.com/skia.git/+log/a0e3fa5aa947..3fea88565a83

2023-04-26 johnstiles@google.com Improve RP code generation for negation.
2023-04-26 johnstiles@google.com Add immediate-mode bitwise xor.
2023-04-26 johnstiles@google.com Remove bitwise_not SkRP ops.

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC brianosman@google.com,jsimmons@google.com,rmistry@google.com,tdenniston@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2023-04-26 17:23:18 +00:00
skia-flutter-autoroll
a1d2863cc5 Roll Skia from 47cfc5a2f0a0 to a0e3fa5aa947 (1 revision) (flutter/engine#41514) 
https://skia.googlesource.com/skia.git/+log/47cfc5a2f0a0..a0e3fa5aa947

2023-04-26 sharaks@google.com Update Skia milestone to 115

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC brianosman@google.com,jsimmons@google.com,rmistry@google.com,tdenniston@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2023-04-26 15:30:18 +00:00
skia-flutter-autoroll
9b5cbe7734 Roll Dart SDK from b0dacad08d62 to 3d444bc30fc4 (1 revision) (flutter/engine#41513) 
https://dart.googlesource.com/sdk.git/+log/b0dacad08d62..3d444bc30fc4

2023-04-26 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com Version 3.1.0-47.0.dev

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/dart-sdk-flutter-engine
Please CC aam@google.com,dart-vm-team@google.com,jsimmons@google.com,rmistry@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter Engine: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2023-04-26 13:52:31 +00:00
skia-flutter-autoroll
cac896118c Roll Skia from 5085ba92075b to 47cfc5a2f0a0 (4 revisions) (flutter/engine#41512) 
https://skia.googlesource.com/skia.git/+log/5085ba92075b..47cfc5a2f0a0

2023-04-26 skia-autoroll@skia-public.iam.gserviceaccount.com Roll vulkan-deps from b01372cf570a to 66646c61d508 (3 revisions)
2023-04-26 skia-autoroll@skia-public.iam.gserviceaccount.com Roll ANGLE from b58ef53abced to d37c97d18a21 (21 revisions)
2023-04-26 skia-autoroll@skia-public.iam.gserviceaccount.com Roll SwiftShader from c0e5813a9b77 to 3076b4c0d8ce (4 revisions)
2023-04-26 skia-autoroll@skia-public.iam.gserviceaccount.com Roll Skia Infra from 8f39f2978ef8 to dec3646b8299 (14 revisions)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC brianosman@google.com,jsimmons@google.com,rmistry@google.com,tdenniston@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2023-04-26 13:10:04 +00:00
skia-flutter-autoroll
20448264e3 Roll Fuchsia Mac SDK from JKHSUjf-qEr0ZMdEi... to rM9DAwmAeMc8pV11x... (flutter/engine#41511) 
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/fuchsia-mac-sdk-flutter-engine
Please CC jsimmons@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2023-04-26 11:26:20 +00:00
skia-flutter-autoroll
db6d17984b Roll Dart SDK from f9d4d255c6e7 to b0dacad08d62 (4 revisions) (flutter/engine#41510) 
https://dart.googlesource.com/sdk.git/+log/f9d4d255c6e7..b0dacad08d62

2023-04-26 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com Version 3.1.0-46.0.dev
2023-04-26 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com Version 3.1.0-45.0.dev
2023-04-25 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com Version 3.1.0-44.0.dev
2023-04-25 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com Version 3.1.0-43.0.dev

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/dart-sdk-flutter-engine
Please CC aam@google.com,dart-vm-team@google.com,jsimmons@google.com,rmistry@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter Engine: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2023-04-26 10:05:22 +00:00
Jia Hao
2b0b0a0e78 Log dlopen errors in opt builds (flutter/engine#41477) 
As the Engine uses `dlopen` to find the `libapp.so`, https://github.com/flutter/flutter/issues/59834 can happen which will prevent `dlopen` from finding the binary. In theory this should be mitigated by https://github.com/flutter/engine/pull/9762, but an internal customer observed errors that could be related. 

The additional logging here can help to rule out that hypothesis. For Googlers, see b/276657840 for more details.

[C++, Objective-C, Java style guides]: https://github.com/flutter/engine/blob/main/CONTRIBUTING.md#style
 2023-04-26 08:16:05 +00:00
skia-flutter-autoroll
9787483f0c Roll Skia from 0f3c8eaf60b2 to 5085ba92075b (1 revision) (flutter/engine#41504) 
https://skia.googlesource.com/skia.git/+log/0f3c8eaf60b2..5085ba92075b

2023-04-26 skia-autoroll@skia-public.iam.gserviceaccount.com Roll Dawn from c1b3c7431680 to 523fbbca76ca (27 revisions)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC brianosman@google.com,jsimmons@google.com,rmistry@google.com,tdenniston@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2023-04-26 05:23:28 +00:00
Dan Field
38c9a9aa6f Roll vulkan-deps and vs_toolchain (flutter/engine#41455) 
Rolls vulkan-deps to https://chromium.googlesource.com/vulkan-deps/+/40b75117a60b11c42a1fb87bf14c0f49bcdb8b3d
 2023-04-26 04:10:11 +00:00
skia-flutter-autoroll
4148389d0b Roll Skia from 22132575fceb to 0f3c8eaf60b2 (1 revision) (flutter/engine#41499) 
https://skia.googlesource.com/skia.git/+log/22132575fceb..0f3c8eaf60b2

2023-04-26 skia-autoroll@skia-public.iam.gserviceaccount.com Roll SK Tool from 8f39f2978ef8 to dec3646b8299

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC brianosman@google.com,jsimmons@google.com,rmistry@google.com,tdenniston@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2023-04-26 03:15:11 +00:00
skia-flutter-autoroll
f496b5b47c Roll Skia from 809bf518d4ab to 22132575fceb (2 revisions) (flutter/engine#41497) 
https://skia.googlesource.com/skia.git/+log/809bf518d4ab..22132575fceb

2023-04-25 johnstiles@google.com Push constant-value scalar/splat-vector variables as literal values.
2023-04-25 skia-autoroll@skia-public.iam.gserviceaccount.com Roll vulkan-deps from a52479099cf2 to b01372cf570a (4 revisions)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC brianosman@google.com,jsimmons@google.com,rmistry@google.com,tdenniston@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2023-04-26 01:57:36 +00:00
godofredoc
59d89a96a1 Migrate windows host engine to engine v2. (flutter/engine#41487) 
Windows host engine and windows_engine_host_engine builds are generating the artifacts using gn+ninja. This PR is sending the legacy build to staging and starts uploading the engine v2 artifacts to prod.

[C++, Objective-C, Java style guides]: https://github.com/flutter/engine/blob/main/CONTRIBUTING.md#style
 2023-04-25 23:58:22 +00:00
skia-flutter-autoroll
725b2ffbc6 Roll Skia from f6f0c4b5ee98 to 809bf518d4ab (3 revisions) (flutter/engine#41494) 
https://skia.googlesource.com/skia.git/+log/f6f0c4b5ee98..809bf518d4ab

2023-04-25 johnstiles@google.com Simplify 'push, immediate-op, pop' to just 'immediate-op'.
2023-04-25 johnstiles@google.com Guard against overflow issue in RP approx_pow2.
2023-04-25 kjlubick@google.com Remove unnecessary include of SkEncodedImageFormat

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC brianosman@google.com,jsimmons@google.com,rmistry@google.com,tdenniston@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2023-04-25 23:47:02 +00:00
gaaclarke
c2ebd9ebc2 Made sure not to turn on wide gamut support without impeller. (flutter/engine#41460) 
fixes https://github.com/flutter/flutter/issues/125430

[C++, Objective-C, Java style guides]: https://github.com/flutter/engine/blob/main/CONTRIBUTING.md#style
 2023-04-25 22:27:21 +00:00
skia-flutter-autoroll
c43684dcc4 Roll Fuchsia Mac SDK from 5bc9_eyVcLoMrWvdO... to JKHSUjf-qEr0ZMdEi... (flutter/engine#41493) 
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/fuchsia-mac-sdk-flutter-engine
Please CC jsimmons@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2023-04-25 22:11:53 +00:00
skia-flutter-autoroll
7519b785e3 Roll Skia from 1bed4228ea3b to f6f0c4b5ee98 (7 revisions) (flutter/engine#41492) 
https://skia.googlesource.com/skia.git/+log/1bed4228ea3b..f6f0c4b5ee98

2023-04-25 kjlubick@google.com Replace more SkASSERTs with SkDEBUGFAIL
2023-04-25 jmbetancourt@google.com [skottie] pass slotID to Opacity callback
2023-04-25 johnstiles@google.com Add immediate mode ops to SkRP.
2023-04-25 kjlubick@google.com Move cross-context image to use DeferredFromTextureGenerator
2023-04-25 johnstiles@google.com Remove SkVM-specific command line flags.
2023-04-25 fmalita@chromium.org [skottie] Clean up deprecated ImageAsset API
2023-04-25 johnstiles@google.com Remove line numbers from SkRP dumps.

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC brianosman@google.com,jsimmons@google.com,rmistry@google.com,tdenniston@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2023-04-25 21:57:44 +00:00
gaaclarke
185d95a35d [Impeller] Fixed blit command missing tracking and added mock vulkan for tests (flutter/engine#41408) 
Adds test for https://github.com/flutter/engine/pull/41347 and adds an
extra fix for https://github.com/flutter/flutter/issues/125147.

Testing this is possible because I've mocked out all of vulkan. We can
expand on this in the future we want to be more robust.

## Pre-launch Checklist

- [x] I read the [Contributor Guide] and followed the process outlined
there for submitting PRs.
- [x] I read the [Tree Hygiene] wiki page, which explains my
responsibilities.
- [x] I read and followed the [Flutter Style Guide] and the [C++,
Objective-C, Java style guides].
- [x] I listed at least one issue that this PR fixes in the description
above.
- [x] I added new tests to check the change I am making or feature I am
adding, or Hixie said the PR is test-exempt. See [testing the engine]
for instructions on writing and running engine tests.
- [x] I updated/added relevant documentation (doc comments with `///`).
- [x] I signed the [CLA].
- [x] All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel
on [Discord].

<!-- Links -->
[Contributor Guide]:
https://github.com/flutter/flutter/wiki/Tree-hygiene#overview
[Tree Hygiene]: https://github.com/flutter/flutter/wiki/Tree-hygiene
[Flutter Style Guide]:
https://github.com/flutter/flutter/wiki/Style-guide-for-Flutter-repo
[C++, Objective-C, Java style guides]:
https://github.com/flutter/engine/blob/main/CONTRIBUTING.md#style
[testing the engine]:
https://github.com/flutter/flutter/wiki/Testing-the-engine
[CLA]: https://cla.developers.google.com/
[flutter/tests]: https://github.com/flutter/tests
[breaking change policy]:
https://github.com/flutter/flutter/wiki/Tree-hygiene#handling-breaking-changes
[Discord]: https://github.com/flutter/flutter/wiki/Chat
 2023-04-25 14:45:04 -07:00
godofredoc
fbb3fc3af8 Double zip FlutterMacOS.dSYM.zip. (flutter/engine#41425) 
The flutter tool is expecting FlutterMacOS.dSYM.zip to be double zipped.

Bug: https://github.com/flutter/flutter/issues/124911

[C++, Objective-C, Java style guides]: https://github.com/flutter/engine/blob/main/CONTRIBUTING.md#style
 2023-04-25 21:02:06 +00:00
Jim Graham
d05d99805f hide DisplayList::DisposeOps and other lint suggestions (flutter/engine#41464) 
Fixes https://github.com/flutter/flutter/issues/125428

Note that these are lint-type fixes and so there are no tests for them.
 2023-04-25 19:46:26 +00:00
skia-flutter-autoroll
fb07edfa72 Roll Dart SDK from 170137fc759b to f9d4d255c6e7 (1 revision) (flutter/engine#41486) 
https://dart.googlesource.com/sdk.git/+log/170137fc759b..f9d4d255c6e7

2023-04-25 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com Version 3.1.0-42.0.dev

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/dart-sdk-flutter-engine
Please CC aam@google.com,dart-vm-team@google.com,jsimmons@google.com,rmistry@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter Engine: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2023-04-25 19:30:11 +00:00
Srujan Gaddam
e253aeff60 Remove package:js references and move to dart:js_interop (flutter/engine#41212) 
dart:js_interop and package:js will start conflicting. Eventually, we
want people to only use dart:js_interop, so this CL refactors code to do
that.

Unblocks https://dart-review.googlesource.com/c/sdk/+/294130/8 and
prevents confusing shadowing of dart:js_interop annotations like we do
today.

## Pre-launch Checklist

- [X] I read the [Contributor Guide] and followed the process outlined
there for submitting PRs.
- [X] I read the [Tree Hygiene] wiki page, which explains my
responsibilities.
- [X] I read and followed the [Flutter Style Guide], including [Features
we expect every widget to implement].
- [X] I signed the [CLA].
- [Mentioned CL that is unblocked] I listed at least one issue that this
PR fixes in the description above.
- [X] I updated/added relevant documentation (doc comments with `///`).
- [Need test-exemption] I added new tests to check the change I am
making, or this PR is [test-exempt].
- [X] All existing and new tests are passing.
 2023-04-25 12:20:12 -07:00
林洵锋
2c3afe9b15 [ios] Fix hold and drag spacebar does not move cursor when obscureText is true. (flutter/engine#40216) 
Fixes [flutter/flutter#122139](https://github.com/flutter/flutter/issues/122139) with flutter pr [flutter/flutter#122383](https://github.com/flutter/flutter/pull/122383)
 2023-04-25 17:56:56 +00:00
skia-flutter-autoroll
63e04a3814 Roll Dart SDK from 337365e42613 to 170137fc759b (2 revisions) (flutter/engine#41483) 
https://dart.googlesource.com/sdk.git/+log/337365e42613..170137fc759b

2023-04-25 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com Version 3.1.0-41.0.dev
2023-04-25 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com Version 3.1.0-40.0.dev

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/dart-sdk-flutter-engine
Please CC aam@google.com,dart-vm-team@google.com,jsimmons@google.com,rmistry@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter Engine: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2023-04-25 15:26:29 +00:00
skia-flutter-autoroll
7e0bed752f Roll Skia from c44f06399619 to 1bed4228ea3b (1 revision) (flutter/engine#41482) 
https://skia.googlesource.com/skia.git/+log/c44f06399619..1bed4228ea3b

2023-04-25 kjlubick@google.com replace SkASSERT(! with SkDEBUGFAIL

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC brianosman@google.com,chinmaygarde@google.com,rmistry@google.com,tdenniston@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2023-04-25 14:08:21 +00:00
skia-flutter-autoroll
23df286d11 Roll Skia from 7a0879961df5 to c44f06399619 (1 revision) (flutter/engine#41479) 
https://skia.googlesource.com/skia.git/+log/7a0879961df5..c44f06399619

2023-04-25 skia-autoroll@skia-public.iam.gserviceaccount.com Roll vulkan-deps from 79949f0f1146 to a52479099cf2 (3 revisions)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC brianosman@google.com,chinmaygarde@google.com,rmistry@google.com,tdenniston@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2023-04-25 11:10:23 +00:00
skia-flutter-autoroll
3704fb44e3 Roll Skia from 571074c14049 to 7a0879961df5 (1 revision) (flutter/engine#41478) 
https://skia.googlesource.com/skia.git/+log/571074c14049..7a0879961df5

2023-04-25 skia-autoroll@skia-public.iam.gserviceaccount.com Roll Skia Infra from 83a6fdf2e118 to 8f39f2978ef8 (7 revisions)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC brianosman@google.com,chinmaygarde@google.com,rmistry@google.com,tdenniston@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2023-04-25 10:25:40 +00:00