41459 Commits

Author SHA1 Message Date
Kevin Chisholm
5874a72aa4
3.24.1 Changelog updates (#153772)
Flutter 3.24.1 Changelog updates.
3.24.1
2024-08-20 21:46:00 +00:00
Kevin Chisholm
eb60a2c540
[flutter_releases] Flutter stable 3.24.1 Framework Cherrypicks (#153731)
# Flutter stable 3.24.1 Framework

## Scheduled Cherrypicks
2024-08-20 00:10:23 +00:00
flutteractionsbot
b023fad9e5
[CP-stable]add HttpException to the list of handled exceptions within ResidentWebRunner::run (#153579)
This pull request is created by [automatic cherry pick workflow](https://github.com/flutter/flutter/blob/main/docs/releases/Flutter-Cherrypick-Process.md#automatically-creates-a-cherry-pick-request)
Please fill in the form below, and a flutter domain expert will evaluate this cherry pick request.

### Issue Link:
What is the link to the issue this cherry-pick is addressing?

https://github.com/flutter/flutter/issues/153298

### Changelog Description:
Explain this cherry pick in one line that is accessible to most Flutter developers. See [best practices](https://github.com/flutter/flutter/blob/main/docs/releases/Hotfix-Documentation-Best-Practices.md) for examples

[CLI tool] When unable to connect to Chrome/Chromium when running a flutter web app, gracefully exit with an error message instead of crashing.

### Impact Description:
What is the impact (ex. visual jank on Samsung phones, app crash, cannot ship an iOS app)? Does it impact development (ex. flutter doctor crashes when Android Studio is installed), or the shipping production app (the app crashes on launch)

Impacts users locally running Flutter web apps.

Users are likely getting noisy crashes when `flutter run` or `flutter debug-adapter` are unable to connect to the flutter web app (perhaps due to a firewall or the user closing the browser before the connection can be made).

### Workaround:
Is there a workaround for this issue?

N/A. No repro is known.

### Risk:
What is the risk level of this cherry-pick?

### Test Coverage:
Are you confident that your fix is well-tested by automated tests?

### Validation Steps:
What are the steps to validate that this fix works?

N/A. No repro is known.
2024-08-19 22:58:26 +00:00
Andrew Kolos
a1f08ba11c
[CP-stable] Bump dependency on package:vm_service from 14.2.4 to 14.2.5 (#153597)
Context: https://github.com/flutter/flutter/issues/153472.

When the Flutter VM service is disposed while there are still outstanding requests, each request is completed with an `RPCError` that has no stack trace. This was fixed in package:vm_service v14.2.5 (these errors will now have stack traces). This PR bumps the framework repo's dependency on this package from 14.2.4 to 14.2.5. This may be handy in case we miss handling these errors from specific call sites in whatever fix(es) we put out for https://github.com/flutter/flutter/issues/153472.
2024-08-19 22:23:06 +00:00
flutteractionsbot
613e43c3ab
[CP-stable][iOS] Copy Flutter.framework.dSYM into app archive (#153322)
### Issue Link:
What is the link to the issue this cherry-pick is addressing?

https://github.com/flutter/flutter/issues/116493

Dependent on engine-side CP https://github.com/flutter/engine/pull/54513

### Changelog Description:
Flutter now bundles iOS framework debugging symbols in app archives built with `flutter build ipa` or Xcode's *Product > Archive* command. This eliminates the need for manual download/bundling of Flutter debug symbols for release build crash log symbolication, and as of Xcode 16, these symbols are now required for app archives to pass App Store validation.

### Impact Description:
Without these bundled symbols, iOS App Store validation fails for Flutter apps under Xcode 16, making it impossible for developers to publish to the iOS App Store.

### Workaround:
Use Xcode 15.

### Risk:
What is the risk level of this cherry-pick?

The change itself is quite simple and in the case where we can't find a bundled Flutter.framework.dSYM inside the flutter tool's artifact cache, we simply fall back to the previous behaviour of not copying it. 

In the case where the Flutter.framework.dSYM is found in the artifact cache (which is the expected case), we simply perform a copy using `rsync` as we do with Flutter.framework itself. This is also relatively low-risk.

Further, this change has been verified by @cbracken using Flutter's own organisation on the App Store, and by [a non-Google developer](https://github.com/flutter/flutter/issues/116493#issuecomment-2282226089). 

However, I'm flagging as medium-risk since this change has only had two days of bake time for us to collect feedback, and while I expect there's a very low likelihood of an issue, we haven't yet got sufficient feedback to say definitively that we haven't missed any edge-cases.

### Test Coverage:
Are you confident that your fix is well-tested by automated tests?

### Validation Steps:
What are the steps to validate that this fix works?

The developer performing these steps will need to have *App Manager* permissions for their development team in App Store Connect.

1. Install Xcode 16 beta.
2. Make Xcode 16 beta the default on your machine: `xcode-select -s /Applications/Xcode-beta.app`
3. Create the default clickcounter app: `flutter create clickcounter`
4. Open `ios/Runner.xcworkspace` in Xcode beta 16.
5. In the project explorer sidebar, select the *Runner* app, then select the *Signing & Capabilities* tab.
6. Set the bundle identifier to the bundle identifier of your app as configured in App Store Connect.
7. From the team dropdown, select a team for which you have developer permissions.
8. From the menu bar, select *Product > Archive*. This will open the Organizer window. You can open it again later from the *Window* menu or via Command-Option-Shift-O.
9. Select the archive, then click *Validate App.*
2024-08-13 18:14:42 +00:00
Martin Kustermann
ec5d4074c6
[CP Stable] Emit source maps for wasm in flutter build web --wasm (#151643) (#153310)
Cherry-pick request: https://github.com/flutter/flutter/issues/153308

Original CL:

This will make

* `flutter run` have source maps enabled by default
* `flutter build` have source maps disabled by default

which mirrors what happens already today with the js compilers.

For local development this works quite well - even better than with dart2js (see dart2js issues in [0]).
We do have some follow-up items for source maps in dart2wasm compiler, see [1]

[0] [flutter/flutter/issues/151641](https://github.com/flutter/flutter/issues/151641)
[1] [dart-lang/sdk/issues/56232](https://github.com/dart-lang/sdk/issues/56232)
2024-08-13 18:00:14 +00:00
flutteractionsbot
cb28dec614
[CP-stable]Handle a SocketException thrown when sending the browser close command to Chrome (#153294)
This pull request is created by [automatic cherry pick workflow](https://github.com/flutter/flutter/blob/main/docs/releases/Flutter-Cherrypick-Process.md#automatically-creates-a-cherry-pick-request)
Please fill in the form below, and a flutter domain expert will evaluate this cherry pick request.

### Issue Link:
What is the link to the issue this cherry-pick is addressing?

### Changelog Description:
Explain this cherry pick in one line that is accessible to most Flutter developers. See [best practices](https://github.com/flutter/flutter/blob/main/docs/releases/Hotfix-Documentation-Best-Practices.md) for examples

Prevent CLI tool crash that can occur when unable to exit a spawned Chromium instance that's already been exited.

### Impact Description:
What is the impact (ex. visual jank on Samsung phones, app crash, cannot ship an iOS app)? Does it impact development (ex. flutter doctor crashes when Android Studio is installed), or the shipping production app (the app crashes on launch)

Noisy crashes for users. This crash represents 65.69% of tool crashes (with roughly half of that percentage of clients being affected).

### Workaround:
Is there a workaround for this issue?

There is no known workaround.

### Risk:
What is the risk level of this cherry-pick?

This simply adds a try-catch that will, at worst, obscure errors.

### Test Coverage:
Are you confident that your fix is well-tested by automated tests?

### Validation Steps:
What are the steps to validate that this fix works?

N/A. No reliable repro is known at this time.
2024-08-13 17:55:49 +00:00
flutteractionsbot
8997882808
[CP-stable]Add xcresulttool --legacy flag for deprecated usage (#153117)
### Issue Link:
https://github.com/flutter/flutter/issues/152989

### Changelog Description:
On Xcode 16 beta, compilation errors are not displayed in the output of `flutter run`.

### Impact Description:

If there are compilation errors `flutter build ios`/`run` will fail, but displays the last x lines out the Xcode output instead of a nicely formatted description of the error.

### Workaround:
Use Xcode 15.

### Risk:
What is the risk level of this cherry-pick?

### Test Coverage:
Are you confident that your fix is well-tested by automated tests?

### Validation Steps:
Run the following steps with both Xcode 15 and Xcode 16 installed (should behave the same):
```
$ flutter create test_create
$ cd test_create
$ open ios/Runner/AppDelegate.swift
```
Add code that would cause a compilation issue:
```swift
import Flutter
import UIKit

@main
@objc class AppDelegate: FlutterAppDelegate {
  override func application(
    _ application: UIApplication,
    didFinishLaunchingWithOptions launchOptions: [UIApplication.LaunchOptionsKey: Any]?
  ) -> Bool {
    var i = 1 + @""
    GeneratedPluginRegistrant.register(with: self)
    return super.application(application, didFinishLaunchingWithOptions: launchOptions)
  }
}
```
```
$ flutter build ios
```

Output should be:
```
Failed to build iOS app
Swift Compiler Error (Xcode): String literals in Swift are not preceded by an '@' sign
/Users/m/Projects/test_create/ios/Runner/AppDelegate.swift:9:16

Swift Compiler Error (Xcode): Binary operator '+' cannot be applied to operands of type 'Int' and 'String'
/Users/m/Projects/test_create/ios/Runner/AppDelegate.swift:9:14

Encountered error while building for device.
```
2024-08-13 17:46:57 +00:00
flutteractionsbot
dcc1f06039
[CP-stable]Change flutter_build_with_compilation_error_test to check stdout or stderr (#153116)
### Issue Link:
https://github.com/flutter/flutter/issues/151553

### Changelog Description:
Make a flutter_tools test pass on Xcode 16 beta.

### Impact Description:
When we update our CI to Xcode 16 after it releases (likely in September), all tests should pass.

### Workaround:
Turning off the test.

### Risk:
What is the risk level of this cherry-pick?

### Test Coverage:
Are you confident that your fix is well-tested by automated tests?

### Validation Steps:
- Install Xcode 15 and run the test (this is happening in CI now).
- Install Xcode 16 latest beta and run the test.  

Part of https://github.com/flutter/flutter/issues/148959
2024-08-12 18:07:56 +00:00
Kevin Chisholm
80c2e84975
[flutter_releases] Flutter stable 3.24.0 Framework Cherrypicks (#152557)
# Flutter stable 3.24.0 Framework

## Scheduled Cherrypicks
- https://github.com/flutter/flutter/pull/151931
3.24.0
2024-07-30 16:06:49 +00:00
Kevin Chisholm
7c6b7e9ca4
[flutter_releases] Flutter beta 3.24.0-0.2.pre Framework Cherrypicks (#152540)
# Flutter beta 3.24.0-0.2.pre Framework

## Scheduled Cherrypicks
3.24.0-0.2.pre
2024-07-30 07:26:44 +00:00
Renzo Olivares
c4dccaf58c
[CP-beta] Fix SelectionArea scrolling conflicts (#151138) (#152423)
Fixes `SelectionArea`/`SelectableRegion` scrolling jank when a `SelectionArea`/`SelectableRegion` is used as a child of a `Scrollable` like `ListView` or `PageView`.

Fixes #152420

Cherry-pick of: https://github.com/flutter/flutter/issues/151138

Related issue: https://github.com/flutter/flutter/issues/150897
2024-07-27 04:20:05 +00:00
Christopher Fujino
b864805a68
Flutter beta 3.24.0-0.1.pre (#152184)
Rolls d89dd85f25
3.24.0-0.1.pre
2024-07-23 23:06:18 +00:00
engine-flutter-autoroll
84b3f0ab79
Roll Flutter Engine from a02e3f673da3 to 8274f54f11be (4 revisions) (#151226)
a02e3f673d...8274f54f11

2024-07-03 98614782+auto-submit[bot]@users.noreply.github.com Reverts "Reland "Output .js files as ES6 modules. (#52023)" (#53688)" (flutter/engine#53709)
2024-07-03 skia-flutter-autoroll@skia.org Roll Skia from d78676d54cb5 to 9d530bb0bcbf (1 revision) (flutter/engine#53708)
2024-07-03 skia-flutter-autoroll@skia.org Roll Skia from 62c7020b7b36 to d78676d54cb5 (2 revisions) (flutter/engine#53707)
2024-07-03 skia-flutter-autoroll@skia.org Roll Skia from 7c69f39fa85b to 62c7020b7b36 (1 revision) (flutter/engine#53706)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC aaclarke@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
3.24.0-0.0.pre
2024-07-03 11:01:05 +00:00
engine-flutter-autoroll
aa179bdc01
Roll Flutter Engine from c5c0c54d6d1d to a02e3f673da3 (1 revision) (#151212)
c5c0c54d6d...a02e3f673d

2024-07-03 jiahaog@users.noreply.github.com Revert "Reland [DisplayList] Add support for clipOval to leverage Impeller optimization" (flutter/engine#53705)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC aaclarke@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-07-03 06:34:15 +00:00
engine-flutter-autoroll
f20962672e
Roll Flutter Engine from 44278941443e to c5c0c54d6d1d (9 revisions) (#151208)
4427894144...c5c0c54d6d

2024-07-03 jacksongardner@google.com Reland "Output .js files as ES6 modules. (#52023)" (flutter/engine#53688)
2024-07-02 skia-flutter-autoroll@skia.org Roll Skia from d02998fba957 to 7c69f39fa85b (1 revision) (flutter/engine#53701)
2024-07-02 skia-flutter-autoroll@skia.org Roll Skia from c1f2dd0fc5f6 to d02998fba957 (2 revisions) (flutter/engine#53699)
2024-07-02 skia-flutter-autoroll@skia.org Roll Skia from c0ee0e108900 to c1f2dd0fc5f6 (2 revisions) (flutter/engine#53697)
2024-07-02 flar@google.com [Impeller] fix typo in setup for fast elliptical rrect blurs (flutter/engine#53673)
2024-07-02 skia-flutter-autoroll@skia.org Roll Fuchsia GN SDK from RgErspyYHapUO2Spc... to sbh76PYVTMxav4ACT... (flutter/engine#53693)
2024-07-02 30870216+gaaclarke@users.noreply.github.com [Impeller] fixed units for memory measurement (flutter/engine#53687)
2024-07-02 jhy03261997@gmail.com [deep link][ios] Update openURL method to reflect the result from framework  (flutter/engine#52643)
2024-07-02 skia-flutter-autoroll@skia.org Manual roll Dart SDK from c23e58143793 to ffc8bb004a64 (2 revisions) (flutter/engine#53690)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC aaclarke@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-07-03 02:59:23 +00:00
Jonathan Lau
5698944196
Fix scheduler event loop being stuck due to task with Priority.idle (#151168)
`handleEventLoopCallback()` should return `true` rather than `false` when there are tasks in the queue but the highest priority task is not run because of the `schedulingStrategy`. If `false` is returned when the queue still has tasks, the event loop stops, causing existing and new tasks to never be scheduled.

For full context, see https://github.com/flutter/flutter/issues/73766#issuecomment-2202427256.

Fixes #73766 and #82016.
2024-07-02 23:59:20 +00:00
Matej Knopp
348fdeebb3
Fix result propagation in RenderSliverEdgeInsetsPadding.hitTestChildren (#149825)
Fixes https://github.com/flutter/flutter/issues/149824
2024-07-02 23:21:22 +00:00
Michael Goderbauer
cfa7777f7a
docImports for flutter_test (#151189)
Part of https://github.com/flutter/flutter/issues/150800

Issues encountered:
2024-07-02 23:05:52 +00:00
Igor Hnízdo
46030f1eff
Interactable ScrollView content when settling a scroll activity (#145848)
Currently when the user:
- flings a scrollable 
- overscrolls, and the scrollable is trying to settle
- applies `DrivenScrollActivity`
- swipes from one tab to the next

All inputs are discarded or forwarded directly to the Scrollable widget (scroll activity).

This leads to situations like these:

https://github.com/flutter/flutter/assets/12874766/51b7876f-5a91-4a86-aa21-c72f0b2c4263

https://github.com/flutter/flutter/assets/12874766/2f756a45-5e42-47d7-98a0-12f071d34e7c

https://github.com/flutter/flutter/assets/12874766/5eb998a1-b3b8-42a1-8b04-543f68823c2b

Which leads to poor experience on iOS. The native behavior of iOS is to allow touches while a scrollable is settling:

https://github.com/flutter/flutter/assets/12874766/e1ae61f8-d59c-40ae-a4c4-ad919f0dc6bf

This PR alters the `shouldIgnoreTouches` of `BallisticScrollAvtivity` and `DrivenScrollActivity` to not make the child of the scrollable ignore touches.

Fixes #145330

Currently tests that test tap to stop are not working as the taps now register when they should not. Because there is no distinction between flings inside and flings that go out of range.
2024-07-02 23:01:44 +00:00
Danny Tuppeny
ce0e5c4330
[flutter_tools] Update the mapping for the Dart SDK internal URI (#151170)
This changes the mapping for the Dart SDK inside Flutter from `org-dartlang-sdk:///third_party/dart/sdk` to org-dartlang-sdk:///flutter/third_party/dart/sdk`. This URI changed in https://github.com/flutter/engine/pull/51917 but was not caught by tests because they only tested a specific set of mappings and there were no integration tests checking what URIs were actually produced by a running app.

So, this change also adds an integration tests that ensures that a real running app produces URIs that are then correctly mapped.

Fixes https://github.com/Dart-Code/Dart-Code/issues/5164.
2024-07-02 22:56:17 +00:00
flutter-pub-roller-bot
d0852df663
Roll pub packages (#151129)
This PR was generated by `flutter update-packages --force-upgrade`.
2024-07-02 22:36:13 +00:00
Qun Cheng
5d3c4568d4
Fix typo (#151192)
Trivial PR to fix typo. The code snippet uses `alignment1`.

4cb6d38492/packages/flutter/lib/src/animation/animation.dart (L208-L211)
2024-07-02 22:15:06 +00:00
Andrew Kolos
8acf86d995
[tool] Fix stdin.flush calls on processes started by FakeProcessManager (#151183)
Fixes https://github.com/flutter/flutter/issues/151151
2024-07-02 20:40:06 +00:00
engine-flutter-autoroll
4cb6d38492
Roll Flutter Engine from 433d360eee11 to 44278941443e (4 revisions) (#151186)
433d360eee...4427894144

2024-07-02 skia-flutter-autoroll@skia.org Roll Skia from 42fad315c162 to c0ee0e108900 (1 revision) (flutter/engine#53691)
2024-07-02 jiahaog@users.noreply.github.com Revert "[web] switch from .didGain/LoseAccessibilityFocus to .focus" (flutter/engine#53679)
2024-07-02 kjlubick@users.noreply.github.com [skia] Use more GNI file lists (flutter/engine#53685)
2024-07-02 skia-flutter-autoroll@skia.org Roll Skia from 7f2094d4cf43 to 42fad315c162 (1 revision) (flutter/engine#53684)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC aaclarke@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-07-02 20:13:23 +00:00
Andrew Kolos
af913a75b5
Use ErrorHandlingFileSystem.deleteIfExists when deleting .plugin_symlinks (#151073)
Fixes https://github.com/flutter/flutter/issues/137168.
2024-07-02 18:46:22 +00:00
Hans Muller
acb41f3174
ScrollEndNotification example: auto-scroll based on RenderSliver constraints and geometry (#143538)
Adds a new ScrollNotificationEnd example that demonstrates how to trigger an auto-scroll based on an individual sliver's `SliverConstraints` and `SliverGeometry`. 

Then new example auto-scrolls one special "aligned item" sliver to the top or bottom of the viewport, whenever it's partially visible (because it overlaps the top or bottom of the viewport). This example differs from the existing ScrollEndNotification example because the layout of the to-be aligned sliver is retrieved from its `RenderSliver` via a
GlobalKey.  The new example does not rely on all of the list items having the same extent.
2024-07-02 18:46:19 +00:00
engine-flutter-autoroll
9527259c70
Roll Packages from 412ec4615aa4 to d2705fb82b26 (13 revisions) (#151169)
412ec4615a...d2705fb82b

2024-07-01 engine-flutter-autoroll@skia.org Roll Flutter from 651a17db5427 to 99bb2ff6a614 (10 revisions) (flutter/packages#7038)
2024-07-01 49699333+dependabot[bot]@users.noreply.github.com [in_app_pur]: Bump androidx.test.espresso:espresso-core from 3.5.1 to 3.6.1 in /packages/in_app_purchase/in_app_purchase_android/android (flutter/packages#7032)
2024-07-01 stuartmorgan@google.com [google_maps_flutter] Semi-convert remaining Android host API calls to Pigeon (flutter/packages#6980)
2024-07-01 49699333+dependabot[bot]@users.noreply.github.com [local_auth]: Bump androidx.test.espresso:espresso-core from 3.5.1 to 3.6.1 in /packages/local_auth/local_auth_android/android (flutter/packages#7022)
2024-07-01 49699333+dependabot[bot]@users.noreply.github.com [video_player]: Bump com.android.tools.build:gradle from 7.2.1 to 8.5.0 in /packages/video_player/video_player_android/android (flutter/packages#6931)
2024-07-01 49699333+dependabot[bot]@users.noreply.github.com [camera]: Bump com.android.tools.build:gradle from 7.3.0 to 8.5.0 in /packages/camera/camera_android/android (flutter/packages#6928)
2024-07-01 matanlurey@users.noreply.github.com [ci] Adds @matanlurey to some Android CODEOWNERS until Impeller is enabled. (flutter/packages#7014)
2024-06-29 ditman@gmail.com [video_player] Bumps web implementation dependency. (flutter/packages#7015)
2024-06-29 engine-flutter-autoroll@skia.org Manual roll Flutter from 15f95ce0c38e to 651a17db5427 (7 revisions) (flutter/packages#7013)
2024-06-28 36687028+phong010198@users.noreply.github.com [flutter_markdown] Add horizontal scroll for markdown table (flutter/packages#6983)
2024-06-28 49699333+dependabot[bot]@users.noreply.github.com Bump ossf/scorecard-action from 2.3.1 to 2.3.3 (flutter/packages#6709)
2024-06-28 stuartmorgan@google.com [google_maps_flutter] Fix Obj-C type handling (flutter/packages#7010)
2024-06-28 engine-flutter-autoroll@skia.org Manual roll Flutter from e726eb401c2c to 15f95ce0c38e (48 revisions) (flutter/packages#7002)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-packages-flutter-autoroll
Please CC flutter-ecosystem@google.com,rmistry@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-07-02 17:49:53 +00:00
Michael Goderbauer
12e3635e8e
docimports for painting (#151143)
Part of https://github.com/flutter/flutter/issues/150800
2024-07-02 17:44:06 +00:00
Michael Goderbauer
9ff9c67272
docimports for scheduler (#151126)
Part of https://github.com/flutter/flutter/issues/150800
2024-07-02 17:31:58 +00:00
Nate Wilson
c9ec61ee90
dismissible.dart code cleanup (#150276)
While I was working on #149966, I noticed a couple of ways that `_DismissibleState` could be tweaked to be easier to follow.

Changes are described in comments below, and we're currently [awaiting a test exemption](https://discord.com/channels/608014603317936148/608018585025118217/1251255349277626490).
2024-07-02 17:31:53 +00:00
Michael Goderbauer
12954d1a38
docimports for physics (#151125)
Part of https://github.com/flutter/flutter/issues/150800

The `physics` library is completely clean after this! 🥳
2024-07-02 17:31:51 +00:00
Michael Goderbauer
06b9f7ba0b
docimports for services (#151134)
Part of https://github.com/flutter/flutter/issues/150800
2024-07-02 17:30:41 +00:00
Michael Goderbauer
3cf357ac7b
docimports for cupertino (#151149)
Part of https://github.com/flutter/flutter/issues/150800

Cupertino is fully clean after this!
2024-07-02 17:30:39 +00:00
Michael Goderbauer
82aaf3b44c
docimports for gestures (#151123)
Part of https://github.com/flutter/flutter/issues/150800
2024-07-02 17:29:43 +00:00
Michael Goderbauer
455be19d92
Docimports for foundation (#151119)
Part of https://github.com/flutter/flutter/issues/150800

Things I couldn't get to work:
2024-07-02 16:19:14 +00:00
Michael Goderbauer
0aedb5e688
docimports for semantics (#151132)
Part of https://github.com/flutter/flutter/issues/150800

Issues encountered:
2024-07-02 16:17:41 +00:00
Jonah Williams
61326afdae
[flutter_driver] add allocator mtl to memory event allowlist. (#151153)
Flutter driver side changes for https://github.com/flutter/engine/pull/53618
2024-07-02 15:34:04 +00:00
engine-flutter-autoroll
a052fb7638
Roll Flutter Engine from 40c087b31515 to 433d360eee11 (7 revisions) (#151165)
40c087b315...433d360eee

2024-07-02 skia-flutter-autoroll@skia.org Roll Skia from 7881ad4aae92 to 7f2094d4cf43 (1 revision) (flutter/engine#53683)
2024-07-02 skia-flutter-autoroll@skia.org Roll Fuchsia Linux SDK from LkXpxHsQlkPT4mmJ7... to x5Sccm0dUoMVbnyed... (flutter/engine#53682)
2024-07-02 skia-flutter-autoroll@skia.org Roll Skia from 4c1856aadb85 to 7881ad4aae92 (1 revision) (flutter/engine#53681)
2024-07-02 skia-flutter-autoroll@skia.org Roll Skia from d7a9375e86c1 to 4c1856aadb85 (2 revisions) (flutter/engine#53680)
2024-07-02 49699333+dependabot[bot]@users.noreply.github.com Bump github/codeql-action from 3.25.10 to 3.25.11 (flutter/engine#53678)
2024-07-02 49699333+dependabot[bot]@users.noreply.github.com Bump google/osv-scanner-action from 1.7.4 to 1.8.1 (flutter/engine#53677)
2024-07-02 skia-flutter-autoroll@skia.org Roll Skia from 8375bdc6e191 to d7a9375e86c1 (1 revision) (flutter/engine#53676)

Also rolling transitive DEPS:
  fuchsia/sdk/core/linux-amd64 from LkXpxHsQlkPT to x5Sccm0dUoMV

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC aaclarke@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-07-02 13:35:26 +00:00
Sigurd Meldgaard
21d996929b
Refactor BuildInfo to always require packageConfigPath (#150559)
Refactor warming up to #150196
2024-07-02 11:19:31 +02:00
engine-flutter-autoroll
95c0ab7a19
Roll Flutter Engine from d3c5bd66a78f to 40c087b31515 (1 revision) (#151156)
d3c5bd66a7...40c087b315

2024-07-02 robert.ancell@canonical.com Restore creation of engine before Linux widget is realized. (flutter/engine#53604)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC jimgraham@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-07-02 07:24:30 +00:00
engine-flutter-autoroll
e42c746ae7
Roll Flutter Engine from fc5bc14e6091 to d3c5bd66a78f (1 revision) (#151155)
fc5bc14e60...d3c5bd66a7

2024-07-02 skia-flutter-autoroll@skia.org Manual roll ICU from 98f2494518c2 to 43953f57b037 (1 revision) (flutter/engine#53675)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC jimgraham@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-07-02 05:47:39 +00:00
Tong Mu
b6163726a1
Fix: CupertinoActionSheet should take up max height when actions section is short (#150708)
This PR addresses a bug from the previous rewrite of the `CupertinoActionSheet` height allocation algorithm. 

The previous approach assigns the content section with a minimal height. As a result, if the actions section is shorter than `_kActionSheetActionsSectionMinHeight`, the remaining space will not be taken by the content section.

As far as I know, this algorithm can not be implemented by simply compositing simple layout widgets, and therefore I created a new widget `_PriorityColumn` that uses a custom layout algorithm. (The resulting code is still shorter (and cleaner) than before the rewrite!)

Some other trivial refactor is also done to clean up the code around parameters of `_ActionSheetMainSheet`.
2024-07-02 04:47:37 +00:00
engine-flutter-autoroll
66d5123604
Roll Flutter Engine from 3456fee1a6b9 to fc5bc14e6091 (8 revisions) (#151150)
3456fee1a6...fc5bc14e60

2024-07-01 98614782+auto-submit[bot]@users.noreply.github.com Reverts "Output .js files as ES6 modules. (#52023)" (flutter/engine#53674)
2024-07-01 skia-flutter-autoroll@skia.org Roll Dart SDK from 21c08743ee4a to c23e58143793 (1 revision) (flutter/engine#53670)
2024-07-01 skia-flutter-autoroll@skia.org Roll Skia from ae2b97d74812 to 8375bdc6e191 (3 revisions) (flutter/engine#53669)
2024-07-01 jacksongardner@google.com Output .js files as ES6 modules. (flutter/engine#52023)
2024-07-01 skia-flutter-autoroll@skia.org Roll Skia from a62bf018429c to ae2b97d74812 (3 revisions) (flutter/engine#53668)
2024-07-01 fmil@google.com [icu] Ignores the dir `flutter/third_party/icu/patches` (flutter/engine#53667)
2024-07-01 jonahwilliams@google.com [Impeller] track the sizes of all outstanding MTLTexture allocations and report per frame in MB, matching Vulkan implementation. (flutter/engine#53618)
2024-07-01 skia-flutter-autoroll@skia.org Roll Dart SDK from 338c6d4fd9c5 to 21c08743ee4a (1 revision) (flutter/engine#53666)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC jimgraham@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-07-02 01:31:31 +00:00
Andrew Kolos
271e0427e3
[tool] remove some temporary printTrace calls (#151074)
Cleans up printTrace calls added while investigating https://github.com/flutter/flutter/issues/146879.

Also makes[ this `catch` clause ](https://github.com/flutter/flutter/pull/151074/files#diff-214723283174eb75e740a102252215723aa56716226ea92d084ef8a5bea4e931L578-R581)more precise.
2024-07-02 00:53:19 +00:00
Nate Wilson
d07a165d22
Implementing a few switch statements (#150946)
I really like how patterns can be used for variable assignment and avoiding duplicated logic. (related: #150942)

```dart
// before
final GestureRecognizer? recognizer = info.recognizer;
if (recognizer is TapGestureRecognizer) {
  if (recognizer.onTap != null) {
    configuration.onTap = recognizer.onTap;
    configuration.isLink = true;
  }
} else if (recognizer is DoubleTapGestureRecognizer) {
  if (recognizer.onDoubleTap != null) {
    configuration.onTap = recognizer.onDoubleTap;
    configuration.isLink = true;
  }
}

// after
switch (info.recognizer) {
  case TapGestureRecognizer(:final VoidCallback? onTap):
  case DoubleTapGestureRecognizer(onDoubleTap: final VoidCallback? onTap):
    if (onTap != null) {
      configuration.onTap = onTap;
      configuration.isLink = true;
    }
}
```
2024-07-01 23:36:32 +00:00
auto-submit[bot]
dbc2dc88bc
Reverts "Upgrade template Gradle, App AGP, Module AGP, and Kotlin versions, and tests (#150969)" (#151147)
Reverts: flutter/flutter#150969
Initiated by: goderbauer
Reason for reverting: Failing test in https://logs.chromium.org/logs/flutter/buildbucket/cr-buildbucket/8743574743030691569/+/u/run_android_obfuscate_test/stdout
Original PR Author: gmackall

Reviewed By: {christopherfujino, reidbaker}

This change reverts the following previous change:
After the land of https://github.com/flutter/engine/pull/53592, there is some log spam:
```
e: /Users/mackall/.gradle/caches/transforms-3/c1e137371ec1afe9bc9bd7b05823752d/transformed/fragment-1.7.1/jars/classes.jar!/META-INF/fragment_release.kotlin_module: Module was compiled with an incompatible version of Kotlin. The binary version of its metadata is 1.8.0, expected version is 1.6.0.
e: /Users/mackall/.gradle/caches/transforms-3/d86c7cb1c556fe1655fa56db671c649c/transformed/jetified-activity-1.8.1/jars/classes.jar!/META-INF/activity_release.kotlin_module: Module was compiled with an incompatible version of Kotlin. The binary version of its metadata is 1.8.0, expected version is 1.6.0.
...
```

I think this is harmless, but still annoying. Upgrading the AGP version fixes it. To be honest, I don't know why (I expected the Kotlin version would do it). But after https://github.com/flutter/flutter/pull/146307, our tests have been running on AGP/Gradle 8.1/8.3 for a while, so it makes sense to upgrade anyways.

In a follow up PR:
1. Also upgrade the tests that were left behind in https://github.com/flutter/flutter/pull/146307, as I think removal of discontinued plugins paved the way here.
2024-07-01 23:31:26 +00:00
Gray Mackall
bd5ab96018
Upgrade template Gradle, App AGP, Module AGP, and Kotlin versions, and tests (#150969)
After the land of https://github.com/flutter/engine/pull/53592, there is some log spam:
```
e: /Users/mackall/.gradle/caches/transforms-3/c1e137371ec1afe9bc9bd7b05823752d/transformed/fragment-1.7.1/jars/classes.jar!/META-INF/fragment_release.kotlin_module: Module was compiled with an incompatible version of Kotlin. The binary version of its metadata is 1.8.0, expected version is 1.6.0.
e: /Users/mackall/.gradle/caches/transforms-3/d86c7cb1c556fe1655fa56db671c649c/transformed/jetified-activity-1.8.1/jars/classes.jar!/META-INF/activity_release.kotlin_module: Module was compiled with an incompatible version of Kotlin. The binary version of its metadata is 1.8.0, expected version is 1.6.0.
...
```

I think this is harmless, but still annoying. Upgrading the AGP version fixes it. To be honest, I don't know why (I expected the Kotlin version would do it). But after https://github.com/flutter/flutter/pull/146307, our tests have been running on AGP/Gradle 8.1/8.3 for a while, so it makes sense to upgrade anyways.

In a follow up PR:
1. Also upgrade the tests that were left behind in https://github.com/flutter/flutter/pull/146307, as I think removal of discontinued plugins paved the way here.
2024-07-01 21:41:59 +00:00
engine-flutter-autoroll
44622dac46
Roll Flutter Engine from b57a044ed10f to 3456fee1a6b9 (5 revisions) (#151127)
b57a044ed1...3456fee1a6

2024-07-01 skia-flutter-autoroll@skia.org Roll Skia from a67a67b7452b to a62bf018429c (2 revisions) (flutter/engine#53665)
2024-07-01 skia-flutter-autoroll@skia.org Roll Skia from 8af866a56bce to a67a67b7452b (1 revision) (flutter/engine#53664)
2024-07-01 skia-flutter-autoroll@skia.org Roll Fuchsia Linux SDK from DSPuQ9O6WejkIBUUh... to LkXpxHsQlkPT4mmJ7... (flutter/engine#53663)
2024-07-01 skia-flutter-autoroll@skia.org Roll Skia from e27104eaef37 to 8af866a56bce (4 revisions) (flutter/engine#53661)
2024-07-01 skia-flutter-autoroll@skia.org Roll Skia from 34be7c830184 to e27104eaef37 (1 revision) (flutter/engine#53659)

Also rolling transitive DEPS:
  fuchsia/sdk/core/linux-amd64 from DSPuQ9O6Wejk to LkXpxHsQlkPT

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC jimgraham@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-07-01 19:36:57 +00:00
John McDole
33be93b210
Read AndroidManifest.xml and emit manifest-aar-impeller-(enabled|disabled) analytics (#150970)
Same as #150791 except with AARs (`flutter build module`)
2024-07-01 18:50:24 +00:00