4385 Commits

Author SHA1 Message Date
Chinmay Garde
fedda1d8df Fix leak of the picture after tracing it to a file 2015-09-22 16:08:39 -07:00
Chinmay Garde
70c98ff994 Generate unique SkPicture trace files each time a trace is requested 2015-09-22 15:00:36 -07:00
Chinmay Garde
f222d57e4d When capturing a frame, pass the frame size to the top level picture 2015-09-22 14:33:27 -07:00
Adam Barth
5b4899694c Merge pull request #1283 from abarth/fn3_basic2
Add CustomPaint and few other basic widgets to fn3
2015-09-22 12:03:18 -07:00
Adam Barth
5068939407 Add CustomPaint and few other basic widgets to fn3
We'll need tag nodes before finishing Flex and Stack.
2015-09-22 11:26:20 -07:00
Ian Hickson
dfb5fbdae4 Merge pull request #1280 from Hixie/block
Fix scrolling of Block.
2015-09-22 10:43:22 -07:00
Adam Barth
b247ac824b Merge pull request #1281 from abarth/fn3_basic
Add a number of basic widgets to fn3
2015-09-22 10:42:35 -07:00
Hixie
838fa55385 Fix scrolling of Block.
Since our build function depends on scrollBehavior.isScrollable, any
time we update scrollBehavior we are implicitly updating our state. As
such, we must do so during a setState() call, or else we won't rebuild
and might not bother to listen to the scroll gestures.

This probably broke when we made Block not listen to gestures if it
wasn't overflowing.
2015-09-22 10:36:34 -07:00
Adam Barth
dd78171041 Add a number of basic widgets to fn3
There are some TODOs in this file that I'll address in the next patch.
2015-09-22 10:27:28 -07:00
Adam Barth
c0a7b2a2fb Merge pull request #1279 from Hixie/fn3
More dartdocs for fn3, refactor buildDirtyElements
2015-09-22 09:41:38 -07:00
Jason Simmons
e4c329d19b Merge pull request #1245 from jason-simmons/editable_text_initial_blink
Ensure that EditableText always shows a cursor
2015-09-22 09:29:52 -07:00
Jason Simmons
148dade286 Merge pull request #1255 from jason-simmons/skyanalyzer_pub_cache
Some cleanup of the Sky analyzer script
2015-09-22 09:29:27 -07:00
Hixie
43ee253c09 More dartdocs for fn3, refactor buildDirtyElements
The buildDirtyElements() method now enforces that we only build deeper
nodes and never go back to build higher nodes during a frame.
2015-09-22 09:20:30 -07:00
Adam Barth
985e430532 Merge pull request #1273 from abarth/rm_gesture_event
Remove GestureEvent.idl
2015-09-21 21:36:45 -07:00
Adam Barth
6b3133405c Merge pull request #1277 from abarth/fix_analyzer
Fix analyzer warning
2015-09-21 21:36:16 -07:00
Adam Barth
ca72b60a29 Fix analyzer warning 2015-09-21 21:35:36 -07:00
Ian Hickson
cc82617792 Merge pull request #1274 from Hixie/fn3
More dartdoc for fn3, and sundry changes.
2015-09-21 17:44:19 -07:00
Hixie
e2fefe0fc0 More dartdoc for fn3, and sundry changes.
- move _uniqueChild earlier since a comment now mentions it earlier.
- reorder methods in Element to more closely reflect call order.
- change mount to be the place that sets the parent pointer, for consistency.
- make the lifecycleState a purely debug-time thing for consistency.
- make BuildableElement.unmount set dirty to false so that we won't
  build unmounted objects.
- rename "updated" to "newWidget" for clarity.
- change how we unmount things so that the slot is reset up to a
  RenderObjectElement, but not further, and don't reset the depth.
2015-09-21 17:44:15 -07:00
James Robinson
e93e326614 Merge pull request #1275 from jamesr/content_handler_flx
Teach content handler service to serve flx (and only flx) files
2015-09-21 17:43:14 -07:00
James Robinson
defb7d2c6f Teach content handler service to serve flx (and only flx) files 2015-09-21 17:34:29 -07:00
Adam Barth
ffb27159d7 Remove GestureEvent.idl
This interface no longer has any clients.
2015-09-21 17:14:04 -07:00
James Robinson
77d5aa16b3 Merge pull request #1272 from jamesr/fix_build
Add include of <memory> for std::unique_ptr
2015-09-21 17:13:32 -07:00
James Robinson
1c40171d31 Add include of <memory> for std::unique_ptr 2015-09-21 17:10:47 -07:00
Adam Barth
44083d2edc Merge pull request #1270 from abarth/rm_gesture_events
Remove uses of sky.GestureEvent
2015-09-21 17:06:07 -07:00
Adam Barth
7d7986a993 Remove uses of sky.GestureEvent 2015-09-21 17:05:45 -07:00
Adam Barth
86c235c229 Merge pull request #1269 from abarth/rm_event_disposition
Remove EventDisposition
2015-09-21 16:47:51 -07:00
Adam Barth
c94726ec32 Remove EventDisposition
All the use cases for EventDisposition are now addressed by the gesture
detection system.
2015-09-21 16:45:09 -07:00
Chinmay Garde
1766ec4ff4 Merge pull request #1268 from chinmaygarde/master
Delete "services/sky/compositor/picture_serializer"
2015-09-21 16:43:17 -07:00
Chinmay Garde
faee292fa2 Delete "services/sky/compositor/picture_serializer" 2015-09-21 16:31:26 -07:00
Adam Barth
61373a0c9b Merge pull request #1266 from abarth/toggle_gesture
RenderToggleable should use a gesture recognizer
2015-09-21 16:26:52 -07:00
Adam Barth
2ecd58b5da RenderToggleable should use a gesture recognizer
We no longer have gesture events.
2015-09-21 16:26:28 -07:00
Chinmay Garde
29988fac46 Merge pull request #1267 from chinmaygarde/master
Move picture_serializer from sky/shell/gpu to sky/compositor
2015-09-21 16:26:05 -07:00
Chinmay Garde
28aa97988d Move picture_serializer from sky/shell/gpu to sky/compositor 2015-09-21 16:22:33 -07:00
Chinmay Garde
b258a3367f Merge pull request #1265 from chinmaygarde/master
SkPicture tracing to file follows same path as rendering into the OpenGL context
2015-09-21 16:01:48 -07:00
Ian Hickson
18e4653fde Merge pull request #1264 from Hixie/fn3
Fix fn3 build errors
2015-09-21 15:48:07 -07:00
Chinmay Garde
0a2984c959 Remove the SERIALIZE_LAYER_TREE macro 2015-09-21 15:46:39 -07:00
Hixie
060662ce5a Fix fn3 build errors
Add a LeafRenderObjectElement, fix a test to use the new contract.
2015-09-21 15:45:49 -07:00
Chinmay Garde
ef4df93e06 SkPicture tracing to file follows same path as rendering into the OpenGL context 2015-09-21 15:45:09 -07:00
Ian Hickson
76dc3716b0 Merge pull request #1262 from Hixie/fn3
fn3 review
2015-09-21 15:42:28 -07:00
Hixie
e4033a8af6 fn3 review
- adds dartdocs
- replaces config setter with didUpdateConfig() so that you can't replace
the config outside of the system
- renames didUnmount() with destroy().
- rename Component to StatelessComponent, ComponentConfiguration to
StatefulComponent
- move debug dump to end of file
- renamed _holder to _element
2015-09-21 15:42:18 -07:00
Adam Barth
9fd3e81912 Merge pull request #1261 from abarth/strip_linux
Strip Linux binaries
2015-09-21 15:26:35 -07:00
Adam Barth
54cbc1b84e Strip Linux binaries
We distribute some Linux binaries. It's useful for them to be small.
2015-09-21 15:25:21 -07:00
Adam Barth
5c62909cf0 Merge pull request #1259 from abarth/fn3_rebuild
fn3 shouldn't rebuild components that don't change identity
2015-09-21 15:05:14 -07:00
Collin Jackson
3e4b3caed0 Merge pull request #1214 from collinjackson/scale_tests
add a test for scale gestures
2015-09-21 14:47:50 -07:00
Jason Simmons
d0668c002e Some cleanup of the Sky analyzer script
* If no source path is provided, then run the analyzer on the Sky unit tests
* Fix the filter for errors found in pub cache packages
* Generalize the filter for the analyzer's "xx errors/warnings/hints found" status message

Also fix a test that caused a warning in the analyzer.
2015-09-21 14:14:30 -07:00
Jason Simmons
86be504c41 Ensure that EditableText always shows a cursor
Previously EditableText would render a text widget with no cursor if the text
value was empty.

Also adjust the height of the cursor widget to reflect the style's line
height, and update the cursor painting to match.
2015-09-21 14:12:55 -07:00
Adam Barth
bac52dc8b1 fn3 shouldn't rebuild components that don't change identity 2015-09-21 14:00:26 -07:00
Hans Muller
964874bc43 Merge pull request #1256 from HansMuller/update_contributing_readme
Be explicit about the working directory in CONTRIBUTING
2015-09-21 12:52:51 -07:00
Adam Barth
5e35cc62f3 Rev pub packages 2015-09-21 12:46:47 -07:00
Adam Barth
05c11e34d3 Merge pull request #1258 from abarth/big_red
Make big_red_button work with the current Dart SDK
2015-09-21 12:46:08 -07:00