Generate unique SkPicture trace files each time a trace is requested

This commit is contained in:
Chinmay Garde 2015-09-22 15:00:36 -07:00
parent f222d57e4d
commit 70c98ff994
2 changed files with 10 additions and 3 deletions

View File

@ -6,8 +6,9 @@
#include "base/macros.h"
#include "base/trace_event/trace_config.h"
#include "base/trace_event/trace_event.h"
#include "sky/shell/tracing_controller.h"
#include "sky/shell/shell.h"
#include "sky/shell/tracing_controller.h"
#include <string>
namespace sky {
@ -18,7 +19,9 @@ const char kBaseTraceEnd[] = "]}";
const char kSentinel[] = "\0";
TracingController::TracingController()
: view_(nullptr), picture_tracing_enabled_(false) {}
: view_(nullptr),
picture_tracing_enabled_(false),
trace_controller_start_(base::TimeTicks::Now()) {}
TracingController::~TracingController() {}
@ -121,7 +124,9 @@ TracingController::SkPictureTracingOptions
TracingController::picture_tracing_options() const {
return SkPictureTracingOptions(
picture_tracing_path_.length() == 0 ? false : picture_tracing_enabled_,
picture_tracing_path_);
picture_tracing_path_ +
std::to_string((base::TimeTicks::Now() - trace_controller_start_)
.InMillisecondsRoundedUp()));
}
void TracingController::set_picture_tracing_path(const std::string& path) {

View File

@ -8,6 +8,7 @@
#include "base/files/file.h"
#include "base/macros.h"
#include "base/memory/ref_counted_memory.h"
#include "base/time/time.h"
#include "mojo/data_pipe_utils/data_pipe_drainer.h"
#include "mojo/public/cpp/system/data_pipe.h"
#include "sky/shell/shell_view.h"
@ -52,6 +53,7 @@ class TracingController : public mojo::common::DataPipeDrainer::Client {
ShellView* view_;
std::string picture_tracing_path_;
bool picture_tracing_enabled_;
base::TimeTicks trace_controller_start_;
void StartDartTracing();
void StartBaseTracing();