DEV/flutter_flutter
1
0
Fork 0
mirror of https://github.com/flutter/flutter.git synced 2026-02-20 02:29:02 +08:00
Code Issues Packages Projects Releases Wiki Activity
84,588 Commits 882 Branches 1,069 Tags
Commit Graph

84588 Commits

This Branch
This Branch
All Branches
Author SHA1 Message Date
engine-flutter-autoroll
f71d9d3313
Roll Skia from 22018eab8c1f to 70455b7c74dd (1 revision) (#170564) 
https://skia.googlesource.com/skia.git/+log/22018eab8c1f..70455b7c74dd

2025-06-12 skia-autoroll@skia-public.iam.gserviceaccount.com Roll
vulkan-deps from ee3e78abdb24 to 4ef9a1d933cf (4 revisions)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC
jsimmons@google.com,kjlubick@google.com,michaelludwig@google.com on the
revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter:
https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2025-06-13 01:54:59 +00:00
engine-flutter-autoroll
bf0a05333e
Roll Fuchsia Linux SDK from Dueykg3VpLT5D_jSG... to lVfYTWxB0rTTuW_k3... (#170557) 
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/fuchsia-linux-sdk-flutter
Please CC jsimmons@google.com,zra@google.com on the revert to ensure
that a human
is aware of the problem.

To file a bug in Flutter:
https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2025-06-13 01:37:24 +00:00
Loïc Sharma
2e0b9f26cc
[Windows] Use ANGLE blit extension on GLES 2.0 (#170298) 
This updates Flutter Windows to fall back to
[`glBlitFramebufferANGLE`](https://github.com/google/angle/blob/main/extensions/ANGLE_framebuffer_blit.txt)
if `glBlitFramebuffer` is not available. This makes Flutter Windows work
on devices where ANGLE supports only GLES 2.0.

Fixes: https://github.com/flutter/flutter/issues/169178

### Background

ANGLE only implements GLES 2.0 on some Windows 10+ machines
([1](https://github.com/flutter/flutter/issues/169178#issuecomment-2943735504),
[2](https://github.com/flutter/flutter/issues/169178#issuecomment-2944096179)).

Flutter Windows 3.27.4 and lower was using `glBlitFramebuffer` on GLES
2.0 devices, even though that requires GLES 3.0. This magically worked
though, thanks to ANGLE.

However in 3.29.0, Impeller was updated to not resolve GLES 3.0 procs on
GLES 2.0: https://github.com/flutter/engine/pull/56636. This caused
Flutter Windows to crash on GLES 2.0 devices since it was calling
`glBlitFramebuffer`.

## Pre-launch Checklist

- [x] I read the [Contributor Guide] and followed the process outlined
there for submitting PRs.
- [x] I read the [Tree Hygiene] wiki page, which explains my
responsibilities.
- [x] I read and followed the [Flutter Style Guide], including [Features
we expect every widget to implement].
- [x] I signed the [CLA].
- [x] I listed at least one issue that this PR fixes in the description
above.
- [x] I updated/added relevant documentation (doc comments with `///`).
- [x] I added new tests to check the change I am making, or this PR is
[test-exempt].
- [x] I followed the [breaking change policy] and added [Data Driven
Fixes] where supported.
- [x] All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel
on [Discord].

<!-- Links -->
[Contributor Guide]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#overview
[Tree Hygiene]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md
[test-exempt]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#tests
[Flutter Style Guide]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md
[Features we expect every widget to implement]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md#features-we-expect-every-widget-to-implement
[CLA]: https://cla.developers.google.com/
[flutter/tests]: https://github.com/flutter/tests
[breaking change policy]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#handling-breaking-changes
[Discord]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Chat.md
[Data Driven Fixes]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Data-driven-Fixes.md
 2025-06-13 01:31:27 +00:00
John "codefu" McDole
bcae39bdf8
chore: move experimental setup steps to composite action (#170496) 
tool-test-general.yml had a lot of gnarly, but sharable code. Moving to
a shared, composite workflow.

updates:
- removed the "flutter/" working folder while running; keep the code in
the workspace
- moved android and pub-cache to /opt/
- switched to `flutter pub get` as the last step
- caching still works; but I think we could do better.
 2025-06-12 23:35:57 +00:00
Jonah Williams
3b95b61fd4
[Impeller] fix mask filter application to Vertices. (#170548) 
Fixes https://github.com/flutter/flutter/issues/170480

Vertices should ignore mask filter. One particular code path in draw
vertices with no per-vertex colors was applying it though.
 2025-06-12 23:13:10 +00:00
engine-flutter-autoroll
b2f8c57c00
Roll Skia from b41e7017658e to 22018eab8c1f (2 revisions) (#170551) 
https://skia.googlesource.com/skia.git/+log/b41e7017658e..22018eab8c1f

2025-06-12 michaelludwig@google.com Reland "[graphite] Use HW blends for
kPlus on unorm texture formats"
2025-06-12 thomsmit@google.com Promote linear gradient bias calculation
to f32

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC
jsimmons@google.com,kjlubick@google.com,michaelludwig@google.com on the
revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter:
https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2025-06-12 22:52:36 +00:00
Loïc Sharma
19d04a15c8
Add CupertinoSheetRoute widget of the week video (#170026) 2025-06-12 21:29:54 +00:00
Matan Lurey
8953ea2cf9
Fix stray --packages argument from workspace refactor; add a test. (#170449) 
Closes https://github.com/flutter/flutter/issues/170433.
 2025-06-12 21:28:07 +00:00
flutter-pub-roller-bot
8d2c80829f
Roll pub packages (#170522) 
This PR was generated by `flutter update-packages --force-upgrade`.
 2025-06-12 21:28:05 +00:00
chunhtai
6f0570bd5d
Navigator should call didpop when popping page based route (#170376) 
<!--
Thanks for filing a pull request!
Reviewers are typically assigned within a week of filing a request.
To learn more about code review, see our documentation on Tree Hygiene:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md
-->

as title

## Pre-launch Checklist

- [ ] I read the [Contributor Guide] and followed the process outlined
there for submitting PRs.
- [ ] I read the [Tree Hygiene] wiki page, which explains my
responsibilities.
- [ ] I read and followed the [Flutter Style Guide], including [Features
we expect every widget to implement].
- [ ] I signed the [CLA].
- [ ] I listed at least one issue that this PR fixes in the description
above.
- [ ] I updated/added relevant documentation (doc comments with `///`).
- [ ] I added new tests to check the change I am making, or this PR is
[test-exempt].
- [ ] I followed the [breaking change policy] and added [Data Driven
Fixes] where supported.
- [ ] All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel
on [Discord].

<!-- Links -->
[Contributor Guide]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#overview
[Tree Hygiene]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md
[test-exempt]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#tests
[Flutter Style Guide]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md
[Features we expect every widget to implement]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md#features-we-expect-every-widget-to-implement
[CLA]: https://cla.developers.google.com/
[flutter/tests]: https://github.com/flutter/tests
[breaking change policy]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#handling-breaking-changes
[Discord]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Chat.md
[Data Driven Fixes]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Data-driven-Fixes.md
 2025-06-12 21:26:00 +00:00
chunhtai
257411dcb7
Relax RadioGroup semantics to allow non-radio children (#170273) 
<!--
Thanks for filing a pull request!
Reviewers are typically assigned within a week of filing a request.
To learn more about code review, see our documentation on Tree Hygiene:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md
-->

as title, also adjust radio group semantics to form a semantics node.
This makes sure it won't merge up and end up taking other semantics node
sibling as its children

## Pre-launch Checklist

- [ ] I read the [Contributor Guide] and followed the process outlined
there for submitting PRs.
- [ ] I read the [Tree Hygiene] wiki page, which explains my
responsibilities.
- [ ] I read and followed the [Flutter Style Guide], including [Features
we expect every widget to implement].
- [ ] I signed the [CLA].
- [ ] I listed at least one issue that this PR fixes in the description
above.
- [ ] I updated/added relevant documentation (doc comments with `///`).
- [ ] I added new tests to check the change I am making, or this PR is
[test-exempt].
- [ ] I followed the [breaking change policy] and added [Data Driven
Fixes] where supported.
- [ ] All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel
on [Discord].

<!-- Links -->
[Contributor Guide]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#overview
[Tree Hygiene]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md
[test-exempt]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#tests
[Flutter Style Guide]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md
[Features we expect every widget to implement]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md#features-we-expect-every-widget-to-implement
[CLA]: https://cla.developers.google.com/
[flutter/tests]: https://github.com/flutter/tests
[breaking change policy]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#handling-breaking-changes
[Discord]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Chat.md
[Data Driven Fixes]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Data-driven-Fixes.md
 2025-06-12 21:26:00 +00:00
Ben Konyi
05d341e734
[ Widget Preview ] Refactor the flutter widget-preview command (#170467) 
No functional changes.
 2025-06-12 21:24:06 +00:00
Victoria Ashworth
22c916a2c0
Pause UIScene migration (#170490) 
UIScene migration is not yet enforced by Apple so we have some more time
to handle this. Let's pause on auto-migrating projects.

Reland of https://github.com/flutter/flutter/pull/170457.

This PR differs as it keeps our tests migrated to UI Scene lifecycle.

## Pre-launch Checklist

- [x] I read the [Contributor Guide] and followed the process outlined
there for submitting PRs.
- [x] I read the [Tree Hygiene] wiki page, which explains my
responsibilities.
- [x] I read and followed the [Flutter Style Guide], including [Features
we expect every widget to implement].
- [x] I signed the [CLA].
- [ ] I listed at least one issue that this PR fixes in the description
above.
- [x] I updated/added relevant documentation (doc comments with `///`).
- [x] I added new tests to check the change I am making, or this PR is
[test-exempt].
- [x] I followed the [breaking change policy] and added [Data Driven
Fixes] where supported.
- [x] All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel
on [Discord].

<!-- Links -->
[Contributor Guide]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#overview
[Tree Hygiene]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md
[test-exempt]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#tests
[Flutter Style Guide]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md
[Features we expect every widget to implement]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md#features-we-expect-every-widget-to-implement
[CLA]: https://cla.developers.google.com/
[flutter/tests]: https://github.com/flutter/tests
[breaking change policy]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#handling-breaking-changes
[Discord]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Chat.md
[Data Driven Fixes]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Data-driven-Fixes.md
 2025-06-12 21:24:05 +00:00
engine-flutter-autoroll
0777beac65
Roll Dart SDK from 9f741ef8a689 to ac589dba5282 (3 revisions) (#170519) 
https://dart.googlesource.com/sdk.git/+log/9f741ef8a689..ac589dba5282

2025-06-12 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com
Version 3.9.0-224.0.dev
2025-06-12 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com
Version 3.9.0-223.0.dev
2025-06-11 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com
Version 3.9.0-222.0.dev

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/dart-sdk-flutter
Please CC dart-vm-team@google.com,jsimmons@google.com on the revert to
ensure that a human
is aware of the problem.

To file a bug in Flutter:
https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2025-06-12 21:22:17 +00:00
engine-flutter-autoroll
5d043d994e
Roll Packages from 0b322a2d9fb5 to 6d3aaf4b5523 (2 revisions) (#170528) 
0b322a2d9f...6d3aaf4b55

2025-06-11 stuartmorgan@google.com Roll Flutter master to
824868f5d1e6c091a5df23d3628407e75149e1da (flutter/packages#9416)
2025-06-11 10687576+bparrishMines@users.noreply.github.com
[interactive_media_ads] Adds support for companion ads
(flutter/packages#9260)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-packages-flutter-autoroll
Please CC flutter-ecosystem@google.com on the revert to ensure that a
human
is aware of the problem.

To file a bug in Flutter:
https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2025-06-12 21:22:17 +00:00
Matan Lurey
ab97b0a675
Fix the path to packages_autoroller. (#170538) 
Recipe already was updated, it will be easier to just make this shell
script location correct.
 2025-06-12 20:10:06 +00:00
engine-flutter-autoroll
f79452e3f4
Roll Skia from 38b9f9b0e496 to b41e7017658e (12 revisions) (#170514) 
https://skia.googlesource.com/skia.git/+log/38b9f9b0e496..b41e7017658e

2025-06-12
recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com
Roll recipe dependencies (trivial).
2025-06-12 skia-autoroll@skia-public.iam.gserviceaccount.com Roll ANGLE
from c6b3440bf382 to d8c154990b5b (8 revisions)
2025-06-12
recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com
Roll recipe dependencies (trivial).
2025-06-12 skia-autoroll@skia-public.iam.gserviceaccount.com Roll Skia
Infra from 80f512e1a5d1 to a5570b3b45a2 (14 revisions)
2025-06-12 skia-autoroll@skia-public.iam.gserviceaccount.com Roll
SwiftShader from 155f095a8c63 to 7b7b93aa0b85 (3 revisions)
2025-06-12 skia-autoroll@skia-public.iam.gserviceaccount.com Roll Dawn
from 9d27097cc7dd to 517d8b7d9a1d (15 revisions)
2025-06-12
recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com
Roll recipe dependencies (trivial).
2025-06-12 skia-autoroll@skia-public.iam.gserviceaccount.com Roll
vulkan-deps from c786a2e47b03 to ee3e78abdb24 (5 revisions)
2025-06-12
recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com
Roll recipe dependencies (trivial).
2025-06-11 thomsmit@google.com GrTriangulator: Fix stability and
correctness with degenerate paths
2025-06-11 robertphillips@google.com Fix ChromePrecompileTest on non-M1
jobs
2025-06-11 robertphillips@google.com [graphite] Add some missing Android
Precompilation combinations

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC
jsimmons@google.com,kjlubick@google.com,michaelludwig@google.com on the
revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter:
https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2025-06-12 11:35:26 +00:00
Renzo Olivares
cf12796001
Fix Semantics.identifier on TextField not working on web (#170395) 
Fixes #155323

Before this change the `identifier` would not be updated even if marked
dirty for a `SemanticRole` that had no `SemanticBehavior`s. After this
change an `identifier` marked dirty is now updated even if the
`SemanticRole` has no `SemanticBehavior`s.

## Pre-launch Checklist

- [x] I read the [Contributor Guide] and followed the process outlined
there for submitting PRs.
- [x] I read the [Tree Hygiene] wiki page, which explains my
responsibilities.
- [x] I read and followed the [Flutter Style Guide], including [Features
we expect every widget to implement].
- [x] I signed the [CLA].
- [x] I listed at least one issue that this PR fixes in the description
above.
- [x] I updated/added relevant documentation (doc comments with `///`).
- [x] I added new tests to check the change I am making, or this PR is
[test-exempt].
- [x] I followed the [breaking change policy] and added [Data Driven
Fixes] where supported.
- [x] All existing and new tests are passing.

---------

Co-authored-by: Renzo Olivares <roliv@google.com>
 2025-06-12 07:13:20 +00:00
Hannah Jin
a534b21380
Revert "[a11y] Semantics flag refactor step 2: embedder part" (#170498) 
Reverts flutter/flutter#167738

Reason: I want to make more changes on embedder so some semantics flags
will be tristate. To avoid introducing breaking changes, revert the
former PR
 2025-06-12 03:37:56 +00:00
Matan Lurey
72807f451a
Copy packages_autoroller to dev/packages_autoroller/run. (#170495) 
Towards https://github.com/flutter/flutter/issues/169780.

Staging this so the recipe can be updated asynchronously:

https://flutter-review.googlesource.com/c/recipes/+/66560
 2025-06-12 02:18:27 +00:00
yim
972c181212
Allow the Slider to always show the value indicator. (#162223) 
Fixes: #34704

Modified enum `ShowValueIndicator`
before:
```dart
enum ShowValueIndicator {
  onlyForDiscrete,
  onlyForContinuous,
  always,
  never,
}
```
after:
```dart
enum ShowValueIndicator {
  onlyForDiscrete,
  onlyForContinuous,
  @Deprecated(
    'Use ShowValueIndicator.onDrag. '
    'This feature was deprecated after v3.28.0-1.0.pre.',
  )
  always,
  onDrag,
  alwaysVisible,
  never,
}
```
To maintain previous behavior, `ShowValueIndicator.onlyForDiscrete` and
`ShowValueIndicator.onlyForContinuous` are still retained.

The behavior of `ShowValueIndicator.always` remains consistent with the
previous implementation, but it is marked as deprecated and should be
replaced with `ShowValueIndicator.onDrag`. A new
`ShowValueIndicator.alwaysVisible` has been added to show the value
indicator even when not dragging.

Additionally, the value indicator is now rendered by `OverlayPortal`.


*If you had to change anything in the [flutter/tests] repo, include a
link to the migration guide as per the [breaking change policy].*

## Pre-launch Checklist

- [x] I read the [Contributor Guide] and followed the process outlined
there for submitting PRs.
- [x] I read the [Tree Hygiene] wiki page, which explains my
responsibilities.
- [x] I read and followed the [Flutter Style Guide], including [Features
we expect every widget to implement].
- [x] I signed the [CLA].
- [x] I listed at least one issue that this PR fixes in the description
above.
- [ ] I updated/added relevant documentation (doc comments with `///`).
- [x] I added new tests to check the change I am making, or this PR is
[test-exempt].
- [x] I followed the [breaking change policy] and added [Data Driven
Fixes] where supported.
- [x] All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel
on [Discord].

<!-- Links -->
[Contributor Guide]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#overview
[Tree Hygiene]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md
[test-exempt]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#tests
[Flutter Style Guide]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md
[Features we expect every widget to implement]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md#features-we-expect-every-widget-to-implement
[CLA]: https://cla.developers.google.com/
[flutter/tests]: https://github.com/flutter/tests
[breaking change policy]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#handling-breaking-changes
[Discord]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Chat.md
[Data Driven Fixes]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Data-driven-Fixes.md
 2025-06-11 23:25:14 +00:00
Matan Lurey
26dfb62acd
Update master branch CHANGELOG.md for 3.32.3. (#170492) 2025-06-11 23:25:13 +00:00
LouiseHsu
269771548f
Add time to first frame for Mac_arm64_ios imitation_game_swiftui (#167602) 
Partially addresses https://github.com/flutter/flutter/issues/154138
Closes https://github.com/flutter/flutter/issues/170386

## Pre-launch Checklist

- [x] I read the [Contributor Guide] and followed the process outlined
there for submitting PRs.
- [x] I read the [Tree Hygiene] wiki page, which explains my
responsibilities.
- [x] I read and followed the [Flutter Style Guide], including [Features
we expect every widget to implement].
- [x] I signed the [CLA].
- [x] I listed at least one issue that this PR fixes in the description
above.
- [x] I updated/added relevant documentation (doc comments with `///`).
- [x] I added new tests to check the change I am making, or this PR is
[test-exempt].
- [x] I followed the [breaking change policy] and added [Data Driven
Fixes] where supported.
- [x] All existing and new tests are passing.
 2025-06-11 23:09:54 +00:00
Ahmed R.
4e0c01066e
Make DropdownMenu TextField reactive to label changes (#162062) 
## Description

The current behavior of Flutter regarding `DropdownMenu` text field is
very basic: `DropdownMenu` updates the text field once a selection has
been made with its coordinating `label`, and nothing more.

If the selection's `label` changes, the text field will still show the
old value, although the menu buttons have been updated.

This not only results in the need to write a lot of boilerplate code to
match the label to the current selection, but it's also
counterintuitive. The `DropdownMenu` should handle rematching by itself.

Issue #155660, touched on this, and a solution was introduced in
#155757. It was later reverted due to it restricting some use cases.
That issue & solution, however, only address `initialSelection`. If
another selection was made and its corresponding `label` was changed,
the text field would still show the old value, bringing us back to
square one.

This PR should not conflict with any previous behavior of
`DropdownMenu`: any new value provided by `initialSelection` or via
controller would not be overwritten by rematching. However, entries with
the same value will be mapped to a single label (the first matched
entry's label).

## Related Issues

- Fixes #155660.

## Tests

Added 3 tests.

## Pre-launch Checklist

- [x] I read the [Contributor Guide] and followed the process outlined
there for submitting PRs.
- [x] I read the [Tree Hygiene] wiki page, which explains my
responsibilities.
- [x] I read and followed the [Flutter Style Guide], including [Features
we expect every widget to implement].
- [x] I signed the [CLA].
- [x] I listed at least one issue that this PR fixes in the description
above.
- [x] I updated/added relevant documentation (doc comments with `///`).
- [x] I added new tests to check the change I am making, or this PR is
[test-exempt].
- [x] I followed the [breaking change policy] and added [Data Driven
Fixes] where supported.
- [x] All existing and new tests are passing.
 2025-06-11 23:08:37 +00:00
engine-flutter-autoroll
85cef5f226
Roll Dart SDK from b569246d64bc to 9f741ef8a689 (1 revision) (#170473) 
https://dart.googlesource.com/sdk.git/+log/b569246d64bc..9f741ef8a689

2025-06-11 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com
Version 3.9.0-221.0.dev

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/dart-sdk-flutter
Please CC dart-vm-team@google.com,jsimmons@google.com on the revert to
ensure that a human
is aware of the problem.

To file a bug in Flutter:
https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2025-06-11 23:07:50 +00:00
Jonah Williams
2773965a3c
[impellerc] add GLES shader define. (#170375) 
Fixes https://github.com/flutter/flutter/issues/169429

For ImageShader.filter we need a way to distinguish between the
coordinate system of GL vs Metal/Vulkan. I documented in
https://github.com/flutter/flutter/pull/169761 how to do it but
neglected to wire up the define. This fixes that.
 2025-06-11 23:06:05 +00:00
auto-submit[bot]
2bc99def13
Reverts "Pause UIScene migration (#170457)" (#170487) 
<!-- start_original_pr_link -->
Reverts: flutter/flutter#170457
<!-- end_original_pr_link -->
<!-- start_initiating_author -->
Initiated by: vashworth
<!-- end_initiating_author -->
<!-- start_revert_reason -->
Reason for reverting: Failing postsubmit tests

<!-- end_revert_reason -->
<!-- start_original_pr_author -->
Original PR Author: vashworth
<!-- end_original_pr_author -->

<!-- start_reviewers -->
Reviewed By: {hellohuanlin}
<!-- end_reviewers -->

<!-- start_revert_body -->
This change reverts the following previous change:
UIScene migration is not yet enforced by Apple so we have some more time
to handle this. Let's pause on auto-migrating projects.

## Pre-launch Checklist

- [x] I read the [Contributor Guide] and followed the process outlined
there for submitting PRs.
- [x] I read the [Tree Hygiene] wiki page, which explains my
responsibilities.
- [x] I read and followed the [Flutter Style Guide], including [Features
we expect every widget to implement].
- [x] I signed the [CLA].
- [ ] I listed at least one issue that this PR fixes in the description
above.
- [x] I updated/added relevant documentation (doc comments with `///`).
- [x] I added new tests to check the change I am making, or this PR is
[test-exempt].
- [x] I followed the [breaking change policy] and added [Data Driven
Fixes] where supported.
- [x] All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel
on [Discord].

<!-- Links -->
[Contributor Guide]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#overview
[Tree Hygiene]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md
[test-exempt]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#tests
[Flutter Style Guide]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md
[Features we expect every widget to implement]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md#features-we-expect-every-widget-to-implement
[CLA]: https://cla.developers.google.com/
[flutter/tests]: https://github.com/flutter/tests
[breaking change policy]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#handling-breaking-changes
[Discord]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Chat.md
[Data Driven Fixes]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Data-driven-Fixes.md

<!-- end_revert_body -->

Co-authored-by: auto-submit[bot] <flutter-engprod-team@google.com>
 2025-06-11 22:03:26 +00:00
auto-submit[bot]
ee089d09b2
Reverts "Fix DropdownButtonFormField focusing when replacing FocusNode (#166645)" (#170477) 
<!-- start_original_pr_link -->
Reverts: flutter/flutter#166645
<!-- end_original_pr_link -->
<!-- start_initiating_author -->
Initiated by: jonahwilliams
<!-- end_initiating_author -->
<!-- start_revert_reason -->
Reason for reverting: multiple test failures w/ dropdown buttons -
https://ci.chromium.org/ui/p/flutter/builders/prod/Linux%20framework_tests_libraries/22946/overview
<!-- end_revert_reason -->
<!-- start_original_pr_author -->
Original PR Author: AhmedLSayed9
<!-- end_original_pr_author -->

<!-- start_reviewers -->
Reviewed By: {bleroux, justinmc}
<!-- end_reviewers -->

<!-- start_revert_body -->
This change reverts the following previous change:
fixes #166642

**The newly added tests verify the following behaviors:**

1. DropdownButtonFormField can be focused if it was unfocused and we
replaced FocusNode.
2. DropdownButtonFormField can be unfocused if it was focused and we
replaced FocusNode.

## Pre-launch Checklist

- [x] I read the [Contributor Guide] and followed the process outlined
there for submitting PRs.
- [x] I read the [Tree Hygiene] wiki page, which explains my
responsibilities.
- [x] I read and followed the [Flutter Style Guide], including [Features
we expect every widget to implement].
- [x] I signed the [CLA].
- [x] I listed at least one issue that this PR fixes in the description
above.
- [x] I updated/added relevant documentation (doc comments with `///`).
- [x] I added new tests to check the change I am making, or this PR is
[test-exempt].
- [x] I followed the [breaking change policy] and added [Data Driven
Fixes] where supported.
- [x] All existing and new tests are passing.
<!-- end_revert_body -->

Co-authored-by: auto-submit[bot] <flutter-engprod-team@google.com>
 2025-06-11 20:48:48 +00:00
Victoria Ashworth
820ff598ce
Pause UIScene migration (#170457) 
UIScene migration is not yet enforced by Apple so we have some more time
to handle this. Let's pause on auto-migrating projects.

## Pre-launch Checklist

- [x] I read the [Contributor Guide] and followed the process outlined
there for submitting PRs.
- [x] I read the [Tree Hygiene] wiki page, which explains my
responsibilities.
- [x] I read and followed the [Flutter Style Guide], including [Features
we expect every widget to implement].
- [x] I signed the [CLA].
- [ ] I listed at least one issue that this PR fixes in the description
above.
- [x] I updated/added relevant documentation (doc comments with `///`).
- [x] I added new tests to check the change I am making, or this PR is
[test-exempt].
- [x] I followed the [breaking change policy] and added [Data Driven
Fixes] where supported.
- [x] All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel
on [Discord].

<!-- Links -->
[Contributor Guide]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#overview
[Tree Hygiene]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md
[test-exempt]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#tests
[Flutter Style Guide]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md
[Features we expect every widget to implement]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md#features-we-expect-every-widget-to-implement
[CLA]: https://cla.developers.google.com/
[flutter/tests]: https://github.com/flutter/tests
[breaking change policy]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#handling-breaking-changes
[Discord]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Chat.md
[Data Driven Fixes]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Data-driven-Fixes.md
 2025-06-11 20:31:01 +00:00
Victoria Ashworth
0cea36129f
iOS tool dylibs do not need entitlements (#170448) 
iOS dylibs don't need entitlements. However, they were previously marked
as needing them. This seems to be a mistake.

This PR marks them as not needing entitlements. It also adds a test that
verifies they are codesigned and have the correct entitlements on
master, instead of only on release branches.

## Pre-launch Checklist

- [x] I read the [Contributor Guide] and followed the process outlined
there for submitting PRs.
- [x] I read the [Tree Hygiene] wiki page, which explains my
responsibilities.
- [x] I read and followed the [Flutter Style Guide], including [Features
we expect every widget to implement].
- [x] I signed the [CLA].
- [ ] I listed at least one issue that this PR fixes in the description
above.
- [x] I updated/added relevant documentation (doc comments with `///`).
- [x] I added new tests to check the change I am making, or this PR is
[test-exempt].
- [x] I followed the [breaking change policy] and added [Data Driven
Fixes] where supported.
- [x] All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel
on [Discord].

<!-- Links -->
[Contributor Guide]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#overview
[Tree Hygiene]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md
[test-exempt]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#tests
[Flutter Style Guide]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md
[Features we expect every widget to implement]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md#features-we-expect-every-widget-to-implement
[CLA]: https://cla.developers.google.com/
[flutter/tests]: https://github.com/flutter/tests
[breaking change policy]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#handling-breaking-changes
[Discord]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Chat.md
[Data Driven Fixes]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Data-driven-Fixes.md
 2025-06-11 20:05:21 +00:00
Victoria Ashworth
85af016e96
Adds getters for different formats of build mode name (#170251) 
Build mode names are commonly formatted in a couple of ways. To
standardize it, this PR adds a getter for each format.

Incremental change towards
https://github.com/flutter/flutter/issues/166486.

## Pre-launch Checklist

- [x] I read the [Contributor Guide] and followed the process outlined
there for submitting PRs.
- [x] I read the [Tree Hygiene] wiki page, which explains my
responsibilities.
- [x] I read and followed the [Flutter Style Guide], including [Features
we expect every widget to implement].
- [x] I signed the [CLA].
- [ ] I listed at least one issue that this PR fixes in the description
above.
- [x] I updated/added relevant documentation (doc comments with `///`).
- [x] I added new tests to check the change I am making, or this PR is
[test-exempt].
- [x] I followed the [breaking change policy] and added [Data Driven
Fixes] where supported.
- [x] All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel
on [Discord].

<!-- Links -->
[Contributor Guide]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#overview
[Tree Hygiene]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md
[test-exempt]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#tests
[Flutter Style Guide]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md
[Features we expect every widget to implement]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md#features-we-expect-every-widget-to-implement
[CLA]: https://cla.developers.google.com/
[flutter/tests]: https://github.com/flutter/tests
[breaking change policy]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#handling-breaking-changes
[Discord]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Chat.md
[Data Driven Fixes]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Data-driven-Fixes.md
 2025-06-11 19:57:09 +00:00
Matan Lurey
787163fd02
Remove all code in conductor/core that is now unused (#170454) 
... that the `conductor` tool itself is gone, i.e. this is now code only
powering `packages_autoroller`.

Towards https://github.com/flutter/flutter/issues/169780.
Closes https://github.com/flutter/flutter/issues/170455.
 2025-06-11 19:21:55 +00:00
engine-flutter-autoroll
0e857f83bc
Roll Packages from 974f1522ee03 to 0b322a2d9fb5 (9 revisions) (#170462) 
974f1522ee...0b322a2d9f

2025-06-11 stuartmorgan@google.com Roll Flutter master to 2d9977c14ebe
(flutter/packages#9402)
2025-06-11 stuartmorgan@google.com [google_maps_flutter] Fix iOS
analysis for newer Xcode (flutter/packages#9415)
2025-06-10 shaunpanjabi@gmail.com [in_app_purchase] Return
jwsRepresentation and jsonRepresentation for StoreKit2
(flutter/packages#9280)
2025-06-10 stuartmorgan@google.com Roll Flutter master to 7e30df2225
(flutter/packages#9413)
2025-06-10 42757204+wyqlxf@users.noreply.github.com [vector_graphics]Add
Null Check for Image Retrieval in listener.dart's onDrawImage Function
(flutter/packages#9211)
2025-06-10 stuartmorgan@google.com Roll Flutter master to 8b22f67c85114
(flutter/packages#9407)
2025-06-06 stuartmorgan@google.com Roll Flutter master to d8baa77b3
(flutter/packages#9379)
2025-06-06 ybz975218925@gmail.com Fix the `zIndex`-related issue in the
`copyWith` method. (flutter/packages#9396)
2025-06-06 katelovett@google.com [multi] Remove @tool from docs that
does not work (flutter/packages#9394)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-packages-flutter-autoroll
Please CC flutter-ecosystem@google.com on the revert to ensure that a
human
is aware of the problem.

To file a bug in Flutter:
https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2025-06-11 18:56:31 +00:00
engine-flutter-autoroll
e57ebb3408
Roll Skia from b78fdc3ba26b to 38b9f9b0e496 (7 revisions) (#170453) 
https://skia.googlesource.com/skia.git/+log/b78fdc3ba26b..38b9f9b0e496

2025-06-11 syoussefi@google.com [graphite][vulkan] Mark Imagination
hardware as coherent
2025-06-11 robertphillips@google.com Disable SimplifyPaintTest on
*Protected jobs
2025-06-11 michaelludwig@google.com Remove S7 Vulkan jobs
2025-06-11 mike@reedtribe.org Simplify asADash() to return its span
2025-06-11 skia-autoroll@skia-public.iam.gserviceaccount.com Roll
vulkan-deps from e16ef854c44f to c786a2e47b03 (1 revision)
2025-06-11 skia-autoroll@skia-public.iam.gserviceaccount.com Roll ANGLE
from a787766551aa to c6b3440bf382 (11 revisions)
2025-06-11 skia-autoroll@skia-public.iam.gserviceaccount.com Roll Skia
Infra from 29821d9a17ae to 80f512e1a5d1 (10 revisions)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC
jsimmons@google.com,kjlubick@google.com,michaelludwig@google.com on the
revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter:
https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2025-06-11 18:53:23 +00:00
Juergen Werner
a4a2ef6d1e
Fix remaining iconbuttontheme overrides in listtile (#169029) 
<!--
Thanks for filing a pull request!
Reviewers are typically assigned within a week of filing a request.
To learn more about code review, see our documentation on Tree Hygiene:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md
-->

Fix remaining outstanding IconButtonTheme overrides: overlayColor and
mouseCursor.

Issue: #167727


## Pre-launch Checklist

- [x] I read the [Contributor Guide] and followed the process outlined
there for submitting PRs.
- [x] I read the [Tree Hygiene] wiki page, which explains my
responsibilities.
- [x] I read and followed the [Flutter Style Guide], including [Features
we expect every widget to implement].
- [x] I signed the [CLA].
- [x] I listed at least one issue that this PR fixes in the description
above.
- [x] I updated/added relevant documentation (doc comments with `///`).
- [x] I added new tests to check the change I am making, or this PR is
[test-exempt].
- [x] I followed the [breaking change policy] and added [Data Driven
Fixes] where supported.
- [x] All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel
on [Discord].

<!-- Links -->
[Contributor Guide]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#overview
[Tree Hygiene]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md
[test-exempt]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#tests
[Flutter Style Guide]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md
[Features we expect every widget to implement]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md#features-we-expect-every-widget-to-implement
[CLA]: https://cla.developers.google.com/
[flutter/tests]: https://github.com/flutter/tests
[breaking change policy]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#handling-breaking-changes
[Discord]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Chat.md
[Data Driven Fixes]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Data-driven-Fixes.md
 2025-06-11 18:50:54 +00:00
Ahmed Elsayed
064f6d1509
Fix DropdownButtonFormField focusing when replacing FocusNode (#166645) 
fixes #166642

**The newly added tests verify the following behaviors:**

1. DropdownButtonFormField can be focused if it was unfocused and we
replaced FocusNode.
2. DropdownButtonFormField can be unfocused if it was focused and we
replaced FocusNode.

## Pre-launch Checklist

- [x] I read the [Contributor Guide] and followed the process outlined
there for submitting PRs.
- [x] I read the [Tree Hygiene] wiki page, which explains my
responsibilities.
- [x] I read and followed the [Flutter Style Guide], including [Features
we expect every widget to implement].
- [x] I signed the [CLA].
- [x] I listed at least one issue that this PR fixes in the description
above.
- [x] I updated/added relevant documentation (doc comments with `///`).
- [x] I added new tests to check the change I am making, or this PR is
[test-exempt].
- [x] I followed the [breaking change policy] and added [Data Driven
Fixes] where supported.
- [x] All existing and new tests are passing.

---------

Co-authored-by: Tong Mu <dkwingsmt@users.noreply.github.com>
 2025-06-11 18:50:54 +00:00
Loïc Sharma
16422f3c82
Add CupertinoRadio widget of the week video (#170027) 
Co-authored-by: Victor Sanni <victorsanniay@gmail.com>
 2025-06-11 18:49:41 +00:00
Kishan Rathore
e765ed43a5
Docs: Update docs for suffix icon interaction behaviour (#169828) 
Docs: Update docs for suffix icon interaction behaviour
fixes: #167713 

## Pre-launch Checklist

- [x] I read the [Contributor Guide] and followed the process outlined
there for submitting PRs.
- [x] I read the [Tree Hygiene] wiki page, which explains my
responsibilities.
- [x] I read and followed the [Flutter Style Guide], including [Features
we expect every widget to implement].
- [x] I signed the [CLA].
- [x] I listed at least one issue that this PR fixes in the description
above.
- [x] I updated/added relevant documentation (doc comments with `///`).
- [x] I added new tests to check the change I am making, or this PR is
[test-exempt].
- [x] I followed the [breaking change policy] and added [Data Driven
Fixes] where supported.
- [x] All existing and new tests are passing.
 2025-06-11 18:49:40 +00:00
Ben Konyi
b9a99683ae
[ Widget Preview ] Don't try to load previews with compile-time errors (#170262) 
This change reworks how preview detection is performed to allow for
identifying libraries which contain compile-time errors or transitive
dependencies with compile-time errors.

Previously, introducing a compile-time error into a preview containing
library's dependency chain would result in the preview environment no
longer being updated due to a failed compilation during hot reload.
Users would first need to know to fix the compilation error before being
able to make updates to previews.

With this change, the preview detector builds and maintains a dependency
graph, propagating errors from libraries to their upstream dependencies.
If a file containing a preview would fail to compile, it is no longer
inserted into the widget preview environment. In its place, an error
message is displayed informing the user that there's a compilation error
in a library that needs to be fixed first.

This change needs some follow up work to create a proper UI for
displaying the compilation error messaging, batch processing of bulk
file system operations (e.g., directory deletion) to avoid performance
issues, and some refactoring.

Work towards #166430
 2025-06-11 17:57:15 +00:00
Harry Terkelsen
f59e8e5885
[canvaskit] Manually trigger input event in text editing tests for Safari (#170022) 
Manually trigger an `input` event to trigger the `handleChange` handler
in the text input element. In Safari for MacOS 15.5, this workaround is
now required.

Fixes https://github.com/flutter/flutter/issues/169282

## Pre-launch Checklist

- [x] I read the [Contributor Guide] and followed the process outlined
there for submitting PRs.
- [x] I read the [Tree Hygiene] wiki page, which explains my
responsibilities.
- [x] I read and followed the [Flutter Style Guide], including [Features
we expect every widget to implement].
- [x] I signed the [CLA].
- [x] I listed at least one issue that this PR fixes in the description
above.
- [x] I updated/added relevant documentation (doc comments with `///`).
- [x] I added new tests to check the change I am making, or this PR is
[test-exempt].
- [x] I followed the [breaking change policy] and added [Data Driven
Fixes] where supported.
- [x] All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel
on [Discord].

<!-- Links -->
[Contributor Guide]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#overview
[Tree Hygiene]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md
[test-exempt]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#tests
[Flutter Style Guide]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md
[Features we expect every widget to implement]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md#features-we-expect-every-widget-to-implement
[CLA]: https://cla.developers.google.com/
[flutter/tests]: https://github.com/flutter/tests
[breaking change policy]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#handling-breaking-changes
[Discord]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Chat.md
[Data Driven Fixes]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Data-driven-Fixes.md

---------

Co-authored-by: Mouad Debbar <mdebbar@google.com>
 2025-06-11 17:48:41 +00:00
Tirth
b97eca7e91
Tiny clean-up in triage docs (#170429) 
<!--
Thanks for filing a pull request!
Reviewers are typically assigned within a week of filing a request.
To learn more about code review, see our documentation on Tree Hygiene:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md
-->

In #170084, this little change was missed

## Pre-launch Checklist

- [x] I read the [Contributor Guide] and followed the process outlined
there for submitting PRs.
- [x] I read the [Tree Hygiene] wiki page, which explains my
responsibilities.
- [x] I read and followed the [Flutter Style Guide], including [Features
we expect every widget to implement].
- [x] I signed the [CLA].
- [ ] I listed at least one issue that this PR fixes in the description
above.
- [x] I updated/added relevant documentation (doc comments with `///`).
- [ ] I added new tests to check the change I am making, or this PR is
[test-exempt].
- [ ] I followed the [breaking change policy] and added [Data Driven
Fixes] where supported.
- [x] All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel
on [Discord].

<!-- Links -->
[Contributor Guide]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#overview
[Tree Hygiene]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md
[test-exempt]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#tests
[Flutter Style Guide]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md
[Features we expect every widget to implement]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md#features-we-expect-every-widget-to-implement
[CLA]: https://cla.developers.google.com/
[flutter/tests]: https://github.com/flutter/tests
[breaking change policy]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#handling-breaking-changes
[Discord]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Chat.md
[Data Driven Fixes]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Data-driven-Fixes.md
 2025-06-11 17:29:59 +00:00
flutter-pub-roller-bot
6abfad4633
Roll pub packages (#170444) 
This PR was generated by `flutter update-packages --force-upgrade`.
 2025-06-11 17:28:25 +00:00
Jim Graham
68f39bac27
[Impeller] Avoid creating paths when rendering arcs (#170398) 
We now avoid a temporary path object and feed arc paths directly to the
renderer in all `DrawArc` cases.
 2025-06-11 16:02:18 +00:00
Bruno Leroux
d6b2a95215
Fix date picker calendar tap targets (portrait mode) (#169163) 
## Description

This PR fixes the touch target (and Semantic bounds) for day buttons
shown in the date picker calendar mode.
To do so it changes the dialog size and buttons padding to conform to
the M3 spec, see
https://m3.material.io/components/date-pickers/specs#2d53890e-a08f-4c63-a0d9-abd9e95b4245

### Before


![image](https://github.com/user-attachments/assets/22f906b9-bd95-4996-852e-bc2df4247364)

### After


![image](https://github.com/user-attachments/assets/83fd37e2-2cd1-454d-a13d-f2dcc3220e3b)

## Related Issue

Fixes [DateTimePicker date buttons fail touch target size accessibility
checks](https://github.com/flutter/flutter/issues/158325)

## Tests

Adds 1 test.

## Implementation choice

This PR targets only M3 and portrait mode:
- M3 because M2 dialog picker was not designed to be accessible (day
buttons are 40 pixels).
- Portrait mode only, because there are no specification for the
landscape mode and existing implementations (Google Calendar, Compose)
vary. I will open a separate issue to discuss a possible solution for
landscape mode.
 2025-06-11 16:00:50 +00:00
Florin Malita
d95aa4d6e2
Add SK_SUPPORT_UNSPANNED_APIS staging flag (#170139) 
Skia is updating its public APIs to use spans instead of rawptr + count.

This is a temporary flag to enable the old style entry points while
clients are being updated.

## Pre-launch Checklist

- [x] I read the [Contributor Guide] and followed the process outlined
there for submitting PRs.
- [x] I read the [Tree Hygiene] wiki page, which explains my
responsibilities.
- [x] I read and followed the [Flutter Style Guide], including [Features
we expect every widget to implement].
- [x] I signed the [CLA].
- [ ] I listed at least one issue that this PR fixes in the description
above.
- [ ] I updated/added relevant documentation (doc comments with `///`).
- [x] I added new tests to check the change I am making, or this PR is
[test-exempt].
- [x] I followed the [breaking change policy] and added [Data Driven
Fixes] where supported.
- [x] All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel
on [Discord].

<!-- Links -->
[Contributor Guide]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#overview
[Tree Hygiene]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md
[test-exempt]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#tests
[Flutter Style Guide]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md
[Features we expect every widget to implement]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md#features-we-expect-every-widget-to-implement
[CLA]: https://cla.developers.google.com/
[flutter/tests]: https://github.com/flutter/tests
[breaking change policy]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#handling-breaking-changes
[Discord]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Chat.md
[Data Driven Fixes]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Data-driven-Fixes.md
 2025-06-11 15:59:19 +00:00
engine-flutter-autoroll
0cb0c5590d
Roll Dart SDK from 6290dfd1d88a to b569246d64bc (4 revisions) (#170430) 
https://dart.googlesource.com/sdk.git/+log/6290dfd1d88a..b569246d64bc

2025-06-11 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com
Version 3.9.0-220.0.dev
2025-06-11 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com
Version 3.9.0-219.0.dev
2025-06-11 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com
Version 3.9.0-218.0.dev
2025-06-10 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com
Version 3.9.0-217.0.dev

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/dart-sdk-flutter
Please CC dart-vm-team@google.com,jsimmons@google.com on the revert to
ensure that a human
is aware of the problem.

To file a bug in Flutter:
https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2025-06-11 15:59:19 +00:00
engine-flutter-autoroll
46a225fd68
Roll Skia from 910070084066 to b78fdc3ba26b (33 revisions) (#170412) 
Roll Skia from 910070084066 to b78fdc3ba26b (33 revisions)

https://skia.googlesource.com/skia.git/+log/910070084066..b78fdc3ba26b

2025-06-11 skia-autoroll@skia-public.iam.gserviceaccount.com Roll Dawn
from 3d47c8a32f07 to 9d27097cc7dd (14 revisions)
2025-06-11 skia-autoroll@skia-public.iam.gserviceaccount.com Roll
SwiftShader from a857503547cb to 155f095a8c63 (2 revisions)
2025-06-11
recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com
Roll recipe dependencies (trivial).
2025-06-10 skia-autoroll@skia-public.iam.gserviceaccount.com Roll
vulkan-deps from d9842c624bd1 to e16ef854c44f (6 revisions)
2025-06-10 danieldilan@google.com Reland "[png] Simplify extra endian
transform for SkPngEncode"
2025-06-10 lukasza@chromium.org [rust png] Reset
`fIncrementalDecodingState` after nonrecoverable errors
2025-06-10 jreck@google.com Add host_supported to libskia_skcms
2025-06-10 syoussefi@google.com [graphite][vulkan] Disable MSAA on Intel
2025-06-10 robertphillips@google.com [graphite] Fold ColorFilters and
constant Shaders into a Solid Color
2025-06-10 mike@reedtribe.org Use SkSpan in SkTextBlob API
2025-06-10 mike@reedtribe.org Use SkSpan for dashing
2025-06-10 skia-autoroll@skia-public.iam.gserviceaccount.com Roll
vulkan-deps from fe4617b72605 to d9842c624bd1 (5 revisions)
2025-06-10 skia-autoroll@skia-public.iam.gserviceaccount.com Roll ANGLE
from 3a15fab06cff to a787766551aa (7 revisions)
2025-06-10 skia-autoroll@skia-public.iam.gserviceaccount.com Roll Skia
Infra from 3c7e00b52946 to 29821d9a17ae (13 revisions)
2025-06-10 skia-autoroll@skia-public.iam.gserviceaccount.com Roll Dawn
from f3220117fc62 to 3d47c8a32f07 (12 revisions)
2025-06-09 ccameron@chromium.org HDR v2: Add no-op OOTF parameters to
sk_color_space_transform
2025-06-09 syoussefi@google.com [vulkan] Require Vulkan 1.1 in Ganesh
2025-06-09 mike@reedtribe.org Use size_t for font/typeface return values
(to match span's)
2025-06-09 syoussefi@google.com [graphite][vulkan] Use
VK_EXT_graphics_pipeline_library
2025-06-09 thomsmit@google.com Reland "[graphite] Fix clamping bug on
Intel UHD 630."
2025-06-09 skia-autoroll@skia-public.iam.gserviceaccount.com Roll
vulkan-deps from d5d3942f4b8f to fe4617b72605 (1 revision)
2025-06-09 jreck@google.com Add dng sdk 1.4 -> 1.7.1 migration compat
2025-06-09 mike@reedtribe.org Use SkSpan in read and write buffers
2025-06-09 mike@reedtribe.org Use new span APIS (time to dogfood)
2025-06-09 skia-autoroll@skia-public.iam.gserviceaccount.com Manual Roll
vulkan-deps from 1c3b39ad6dc0 to d5d3942f4b8f (14 revisions)
2025-06-09 bungeman@google.com Remove many deprecated declarations
2025-06-09 syoussefi@google.com [vulkan] Apply RelaxedPrecision to
OpImageSampleImplicitLod
2025-06-09 skia-autoroll@skia-public.iam.gserviceaccount.com Roll ANGLE
from db9624073324 to 3a15fab06cff (4 revisions)
2025-06-09 skia-autoroll@skia-public.iam.gserviceaccount.com Roll
SwiftShader from 11dc1b167af4 to a857503547cb (1 revision)
2025-06-09 skia-autoroll@skia-public.iam.gserviceaccount.com Roll Skia
Infra from 3bbfa4528971 to 3c7e00b52946 (5 revisions)
2025-06-09 skia-autoroll@skia-public.iam.gserviceaccount.com Roll Dawn
from 63ca6919b752 to f3220117fc62 (31 revisions)
2025-06-08 ccameron@chromium.org SkColorSpaceXformSteps: Start to add
support for HLG and PQ
2025-06-08 skia-recreate-skps@skia-swarming-bots.iam.gserviceaccount.com
Update SKP version

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC
jsimmons@google.com,kjlubick@google.com,michaelludwig@google.com on the
revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter:
https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

...
 2025-06-11 15:57:05 +00:00
Kaylee Lubick
b4219783bb
Use pathops module groups (#169857) 
Skia is moving its [pathops code around](http://review.skia.org/999760).
In http://review.skia.org/1001216 we added a new set of filegroups to
facilitate this. This updates the BUILD.gn rules to use those new
groups.

## Pre-launch Checklist

- [ x ] I read the [Contributor Guide] and followed the process outlined
there for submitting PRs.
- [ x ] I read the [Tree Hygiene] wiki page, which explains my
responsibilities.
- [ x ] I read and followed the [Flutter Style Guide], including
[Features we expect every widget to implement].
- [ x ] I signed the [CLA].
- [ ] I listed at least one issue that this PR fixes in the description
above.
- [ ] I updated/added relevant documentation (doc comments with `///`).
- [ x ] I added new tests to check the change I am making, or this PR is
[test-exempt].
- [ x ] I followed the [breaking change policy] and added [Data Driven
Fixes] where supported.
- [ x ] All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel
on [Discord].

<!-- Links -->
[Contributor Guide]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#overview
[Tree Hygiene]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md
[test-exempt]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#tests
[Flutter Style Guide]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md
[Features we expect every widget to implement]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md#features-we-expect-every-widget-to-implement
[CLA]: https://cla.developers.google.com/
[flutter/tests]: https://github.com/flutter/tests
[breaking change policy]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#handling-breaking-changes
[Discord]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Chat.md
[Data Driven Fixes]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Data-driven-Fixes.md
 2025-06-11 14:36:04 +00:00
flutter-pub-roller-bot
4067b941d8
Roll pub packages (#170399) 
This PR was generated by `flutter update-packages --force-upgrade`.
 2025-06-10 23:38:27 +00:00
Harry Terkelsen
db8a64f90d
Verify old version of Python has the lib2to3 import available (#170187) 
The `yapf.sh` script checks for specific "known-to-work-with-YAPF"
versions of Python to run YAPF with. On my machine, I have `python3.11`
and `python3.12` (`python3` is a symlink to `python3.12`). However, the
`python3.11` release doesn't have `lib2to3` so the YAPF script fails
with:

```
Checking Python formatting...
To fix, run `et format` or:                                                                                   

git apply <<DONE
  /usr/local/google/home/het/Projects/flutter/engine/src/flutter/tools/gn
Traceback (most recent call last):
  File "<frozen runpy>", line 198, in _run_module_as_main
  File "<frozen runpy>", line 88, in _run_code
  File "/usr/local/google/home/het/Projects/flutter/engine/src/flutter/third_party/yapf/yapf/__main__.py", line 16, in <module>
    import yapf
  File "/usr/local/google/home/het/Projects/flutter/engine/src/flutter/third_party/yapf/yapf/__init__.py", line 35, in <module>
    from yapf.yapflib import errors
  File "/usr/local/google/home/het/Projects/flutter/engine/src/flutter/third_party/yapf/yapf/yapflib/errors.py", line 16, in <module>
    from lib2to3.pgen2 import tokenize
ModuleNotFoundError: No module named 'lib2to3'

DONE
```

On my Ubuntu machine I cannot install `lib2to3` through normal APT
packages; `apt install python3.11-lib2to3` fails since that package has
been obsoleted. I've been able to work around this by manually editing
the `yapf.sh` script to check if `lib2to3` can be imported before using
that version of Python.

See https://github.com/flutter/flutter/issues/158384

## Pre-launch Checklist

- [x] I read the [Contributor Guide] and followed the process outlined
there for submitting PRs.
- [x] I read the [Tree Hygiene] wiki page, which explains my
responsibilities.
- [x] I read and followed the [Flutter Style Guide], including [Features
we expect every widget to implement].
- [x] I signed the [CLA].
- [x] I listed at least one issue that this PR fixes in the description
above.
- [x] I updated/added relevant documentation (doc comments with `///`).
- [x] I added new tests to check the change I am making, or this PR is
[test-exempt].
- [x] I followed the [breaking change policy] and added [Data Driven
Fixes] where supported.
- [x] All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel
on [Discord].

<!-- Links -->
[Contributor Guide]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#overview
[Tree Hygiene]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md
[test-exempt]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#tests
[Flutter Style Guide]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md
[Features we expect every widget to implement]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md#features-we-expect-every-widget-to-implement
[CLA]: https://cla.developers.google.com/
[flutter/tests]: https://github.com/flutter/tests
[breaking change policy]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#handling-breaking-changes
[Discord]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Chat.md
[Data Driven Fixes]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Data-driven-Fixes.md
 2025-06-10 22:51:57 +00:00