skia-flutter-autoroll
eeec4e8e08
Roll Fuchsia Linux SDK from jXrn0SP_MnSmhkz_P... to EweLgJoiYUDok2vyU... ( flutter/engine#42035 )
...
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/fuchsia-linux-sdk-flutter-engine
Please CC aaclarke@google.com ,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2023-05-15 05:41:34 +00:00
skia-flutter-autoroll
27478f6013
Roll Skia from 0410e5d9ec03 to 0c2083a60b66 (1 revision) ( flutter/engine#42034 )
...
https://skia.googlesource.com/skia.git/+log/0410e5d9ec03..0c2083a60b66
2023-05-15 skia-autoroll@skia-public.iam.gserviceaccount.com Roll Dawn from 6d50a49da6d0 to 89a3dac88297 (11 revisions)
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC aaclarke@google.com ,brianosman@google.com,johnstiles@google.com,rmistry@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2023-05-15 05:33:24 +00:00
Casey Hillers
c77155e442
[Impeller] Include AndroidSurfaceVulkanImpeller behind a flag ( flutter/engine#42033 )
...
Fixes b/282290672
Google Testing currently does not support vulkan, and constructors like
this need to be behind a flag.
## Pre-launch Checklist
- [x] I read the [Contributor Guide] and followed the process outlined
there for submitting PRs.
- [x] I read the [Tree Hygiene] wiki page, which explains my
responsibilities.
- [x] I read and followed the [Flutter Style Guide] and the [C++,
Objective-C, Java style guides].
- [ ] I listed at least one issue that this PR fixes in the description
above.
- [ ] I added new tests to check the change I am making or feature I am
adding, or Hixie said the PR is test-exempt. See [testing the engine]
for instructions on writing and running engine tests.
- [x] I updated/added relevant documentation (doc comments with `///`).
- [x] I signed the [CLA].
- [x] All existing and new tests are passing.
2023-05-14 22:29:19 -07:00
Casey Hillers
f0c9869019
Reland "Remove GN staging flag for save layer bounds" ( flutter/engine#42029 )
...
Reverts flutter/engine#42026
After investigating, this is a bug fix for the scubas.
2023-05-15 04:34:28 +00:00
skia-flutter-autoroll
0b71b21824
Roll Fuchsia Mac SDK from qnNU5eQaox06ejpSE... to A3thcPNgxVcKzR-da... ( flutter/engine#42030 )
...
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/fuchsia-mac-sdk-flutter-engine
Please CC aaclarke@google.com ,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2023-05-15 03:10:30 +00:00
skia-flutter-autoroll
3d03285242
Roll Dart SDK from 005648f027a3 to 7d6324d5488b (1 revision) ( flutter/engine#42027 )
...
https://dart.googlesource.com/sdk.git/+log/005648f027a3..7d6324d5488b
2023-05-14 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com Version 3.1.0-110.0.dev
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/dart-sdk-flutter-engine
Please CC aaclarke@google.com ,dart-vm-team@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter Engine: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2023-05-14 18:40:49 +00:00
Casey Hillers
e331048fc7
Revert "Remove GN staging flag for save layer bounds" ( flutter/engine#42026 )
...
Reverts flutter/engine#41940
See b/282115120
This caused a golden failure on Google Testing where a rectangular avatar became circular.
2023-05-14 17:01:17 +00:00
skia-flutter-autoroll
c2634ce31d
Roll Fuchsia Linux SDK from hEJzgtSberqdXmLnk... to jXrn0SP_MnSmhkz_P... ( flutter/engine#42025 )
...
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/fuchsia-linux-sdk-flutter-engine
Please CC aaclarke@google.com ,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2023-05-14 16:49:24 +00:00
skia-flutter-autoroll
452da0c73c
Roll Skia from 35d8ac3ced75 to 0410e5d9ec03 (1 revision) ( flutter/engine#42024 )
...
https://skia.googlesource.com/skia.git/+log/35d8ac3ced75..0410e5d9ec03
2023-05-14 brianosman@google.com Revert "Enable OutParamsFunctionCallInArgument test on GPU."
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC aaclarke@google.com ,brianosman@google.com,johnstiles@google.com,rmistry@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2023-05-14 14:54:31 +00:00
skia-flutter-autoroll
f4d9ef9a6e
Roll Fuchsia Mac SDK from hXcPXU_V5nVeGkEbt... to qnNU5eQaox06ejpSE... ( flutter/engine#42023 )
...
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/fuchsia-mac-sdk-flutter-engine
Please CC aaclarke@google.com ,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2023-05-14 14:24:21 +00:00
skia-flutter-autoroll
41f36ba364
Roll Skia from 1c00432c2a85 to 35d8ac3ced75 (1 revision) ( flutter/engine#42022 )
...
https://skia.googlesource.com/skia.git/+log/1c00432c2a85..35d8ac3ced75
2023-05-14 skia-recreate-skps@skia-swarming-bots.iam.gserviceaccount.com Update SKP version
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC aaclarke@google.com ,brianosman@google.com,djsollen@google.com,rmistry@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2023-05-14 08:22:34 +00:00
skia-flutter-autoroll
fd47e42c2a
Roll Fuchsia Linux SDK from mAQy_vMru3cTWSoBl... to hEJzgtSberqdXmLnk... ( flutter/engine#42021 )
...
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/fuchsia-linux-sdk-flutter-engine
Please CC aaclarke@google.com ,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2023-05-14 04:00:35 +00:00
Jim Graham
820d1dbbde
add non-rendering operation culling to DisplayListBuilder ( flutter/engine#41463 )
...
This optimization avoids recording unnecessary render operations that will not affect the output and also eliminates the need for "draw detection" mechanisms like `DlOpSpy` and `CanvasSpy` by remembering if any non-transparent operations were included. The `DlOpSpy` unit tests were updated to check if the results from that object match the new `DisplayList::affects_transparent_surface()` method.
Fixes https://github.com/flutter/flutter/issues/125338
In addition, this change will unblock some other Issues:
- https://github.com/flutter/flutter/issues/125318
- https://github.com/flutter/flutter/issues/125403
2023-05-14 02:14:33 +00:00
skia-flutter-autoroll
06105c34ab
Roll Fuchsia Mac SDK from wxolyLvEWZ9IMOCU_... to hXcPXU_V5nVeGkEbt... ( flutter/engine#42020 )
...
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/fuchsia-mac-sdk-flutter-engine
Please CC aaclarke@google.com ,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2023-05-14 01:38:36 +00:00
skia-flutter-autoroll
7161aeef66
Roll Dart SDK from 48d09a6216a8 to 005648f027a3 (1 revision) ( flutter/engine#42017 )
...
https://dart.googlesource.com/sdk.git/+log/48d09a6216a8..005648f027a3
2023-05-13 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com Version 3.1.0-109.0.dev
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/dart-sdk-flutter-engine
Please CC aaclarke@google.com ,dart-vm-team@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter Engine: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2023-05-13 15:32:22 +00:00
skia-flutter-autoroll
d6720aa1f3
Roll Fuchsia Linux SDK from bddx8p5907poNnZTq... to mAQy_vMru3cTWSoBl... ( flutter/engine#42016 )
...
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/fuchsia-linux-sdk-flutter-engine
Please CC aaclarke@google.com ,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2023-05-13 15:10:13 +00:00
skia-flutter-autoroll
a3eb37a286
Roll Fuchsia Mac SDK from oc2gdx4PWYT-K7XQ9... to wxolyLvEWZ9IMOCU_... ( flutter/engine#42015 )
...
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/fuchsia-mac-sdk-flutter-engine
Please CC aaclarke@google.com ,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2023-05-13 12:51:24 +00:00
skia-flutter-autoroll
b6bc2c83d4
Roll Dart SDK from 2a285d87f5d7 to 48d09a6216a8 (1 revision) ( flutter/engine#42014 )
...
https://dart.googlesource.com/sdk.git/+log/2a285d87f5d7..48d09a6216a8
2023-05-12 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com Version 3.1.0-108.0.dev
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/dart-sdk-flutter-engine
Please CC aaclarke@google.com ,dart-vm-team@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter Engine: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2023-05-13 10:03:29 +00:00
skia-flutter-autoroll
4c6d847954
Roll Skia from 872787e7595c to 1c00432c2a85 (1 revision) ( flutter/engine#42013 )
...
https://skia.googlesource.com/skia.git/+log/872787e7595c..1c00432c2a85
2023-05-13 sallyqi@google.com Fix the way of Alpha8 gainmap support in Skia.
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC aaclarke@google.com ,brianosman@google.com,djsollen@google.com,rmistry@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2023-05-13 06:57:15 +00:00
Bruno Leroux
80c4704ddf
[macOS - TextInput] Insert new line only when TextInputAction.newline ( flutter/engine#41977 )
...
## Description
This PR updates the macOS text input plugin to avoid adding a new line on a multiline text field when action is not set to `TextInputAction.newline`.
## Related Issue
macOS implementation for https://github.com/flutter/flutter/issues/125879 .
(similar to the Linux implementation in https://github.com/flutter/engine/pull/41895 ).
## Tests
Adds 2 tests.
2023-05-13 06:48:14 +00:00
skia-flutter-autoroll
d182d2be80
Roll Skia from cfdfc039b848 to 872787e7595c (1 revision) ( flutter/engine#42010 )
...
https://skia.googlesource.com/skia.git/+log/cfdfc039b848..872787e7595c
2023-05-13 michaelludwig@google.com [skif] Fix inset=0 case for new Magnifier
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC aaclarke@google.com ,brianosman@google.com,djsollen@google.com,rmistry@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2023-05-13 05:04:16 +00:00
skia-flutter-autoroll
8056ac6066
Roll Skia from 6a4e29cbd73b to cfdfc039b848 (2 revisions) ( flutter/engine#42004 )
...
https://skia.googlesource.com/skia.git/+log/6a4e29cbd73b..cfdfc039b848
2023-05-12 skia-autoroll@skia-public.iam.gserviceaccount.com Roll vulkan-deps from 0d737f701865 to 3a356ab97987 (1 revision)
2023-05-12 johnstiles@google.com Add null guard to intrinsic evaluation of normalize().
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC aaclarke@google.com ,brianosman@google.com,djsollen@google.com,rmistry@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2023-05-13 03:10:26 +00:00
skia-flutter-autoroll
b165713640
Roll Fuchsia Linux SDK from HMLNsG7w9sTDpW2Ge... to bddx8p5907poNnZTq... ( flutter/engine#42003 )
...
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/fuchsia-linux-sdk-flutter-engine
Please CC aaclarke@google.com ,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2023-05-13 01:22:11 +00:00
skia-flutter-autoroll
0e6a5e2723
Roll Fuchsia Mac SDK from rO5qs4MpN6WfJcu64... to oc2gdx4PWYT-K7XQ9... ( flutter/engine#42000 )
...
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/fuchsia-mac-sdk-flutter-engine
Please CC aaclarke@google.com ,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2023-05-13 00:05:14 +00:00
skia-flutter-autoroll
638a24666a
Roll Skia from 64bdd87fadfe to 6a4e29cbd73b (2 revisions) ( flutter/engine#41999 )
...
https://skia.googlesource.com/skia.git/+log/64bdd87fadfe..6a4e29cbd73b
2023-05-12 johnstiles@google.com Allow convertArraySize to take an integer size.
2023-05-12 lokokung@google.com Updates webgpu C++ Release call to use MoveToCHandle.
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC aaclarke@google.com ,brianosman@google.com,djsollen@google.com,rmistry@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2023-05-12 23:48:18 +00:00
Jason Simmons
d3132f8e6a
[Impeller] Remove a debug log from the Vulkan render pass ( flutter/engine#41987 )
2023-05-12 16:42:03 -07:00
skia-flutter-autoroll
37cc77c5e7
Roll Dart SDK from 858f83d6d993 to 2a285d87f5d7 (2 revisions) ( flutter/engine#41997 )
...
https://dart.googlesource.com/sdk.git/+log/858f83d6d993..2a285d87f5d7
2023-05-12 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com Version 3.1.0-107.0.dev
2023-05-12 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com Version 3.1.0-106.0.dev
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/dart-sdk-flutter-engine
Please CC aaclarke@google.com ,dart-vm-team@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter Engine: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2023-05-12 23:10:32 +00:00
Brandon DeRosier
54d5c489c2
[Impeller] Ignore the Z basis when scaling text ( flutter/engine#41995 )
...
Fixes https://github.com/flutter/flutter/issues/126510 .
`GetMaxBasisLength()` includes the Z basis vector, which happens to not
be getting scaled down along with the X and Y for this reproduction
case. And so given the 2D nature of text and the intent of this scale
parameter, it's returning a value that's too large here.
2023-05-12 15:28:19 -07:00
skia-flutter-autoroll
b46ff342f3
Roll Skia from 539fb10d7cfb to 64bdd87fadfe (18 revisions) ( flutter/engine#41993 )
...
https://skia.googlesource.com/skia.git/+log/539fb10d7cfb..64bdd87fadfe
2023-05-12 johnstiles@google.com Remove unused methods from DSLFunction.
2023-05-12 michaelludwig@google.com [skif] Re-arrange static functions in SkImageFilterTypes.cpp
2023-05-12 robertphillips@google.com Add default for Mock backend types' 'isProtected' parameters
2023-05-12 kjlubick@google.com Manually Roll Dawn from 776a762c9a4d to 6d50a49da6d0 (19 revisions)
2023-05-12 johnstiles@google.com Enable OutParamsFunctionCallInArgument test on GPU.
2023-05-12 kjlubick@google.com Decouple SkImage and Graphite backend
2023-05-12 jamesgk@google.com [graphite] Account for primitive blending depending on dst
2023-05-12 jamesgk@google.com [graphite] Incorporate coverage into blending
2023-05-12 jvanverth@google.com [graphite] Set up snippetID and data for YUV shader
2023-05-12 brianosman@google.com Disallow SkSL in glyph drawables
2023-05-12 johnstiles@google.com Update SkSLTest to use SkEnumBitMask.
2023-05-12 brianosman@google.com Remove some unused SkPicture code
2023-05-12 kjlubick@google.com Make IWYU build skip linking
2023-05-12 robertphillips@google.com Adjust Mock backend's Protected implementation
2023-05-12 johnstiles@google.com Remove SkVM from the SkSL test matrix.
2023-05-12 johnstiles@google.com Remove DSLField type.
2023-05-12 johnstiles@google.com Rename SkSL::Type::Field and SkSL::Field.
2023-05-12 michaelludwig@google.com Handle zero-scale factors in InverseMapRect
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC aaclarke@google.com ,brianosman@google.com,djsollen@google.com,rmistry@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2023-05-12 21:56:02 +00:00
Mouad Debbar
7b3b362623
[web] Cleaner output on LUCI ( flutter/engine#41989 )
...
Using ansi colors in LUCI results in output that looks like:
```
00:00 [32m+0[0m: [1m[90mloading flutter_tester_emulation_golden_test.dart[0m[0m
00:01 [32m+0[0m: [1m[90mloading flutter_tester_emulation_golden_test.dart[0m[0m
00:02 [32m+0[0m: [1m[90mloading flutter_tester_emulation_golden_test.dart[0m[0m
```
This PR disables colors on LUCI so that we get clean output that's easily scannable and searchable.
2023-05-12 21:50:22 +00:00
Bruno Leroux
fea415faa0
[Web+Linux] Fix pressing Meta keys throws ( flutter/engine#41694 )
...
## Description
This PR fixes Meta keys throwing exception on Chrome Linux.
The assertions throws because the DOM event sent when Meta keys is pressed is not coherent when Meta is the only pressed key.
## Related Issue
Fixes https://github.com/flutter/flutter/issues/125672
## Tests
Adds 1 test.
2023-05-12 21:46:17 +00:00
gaaclarke
015608f15e
[Impeller] starts running vulkan golden image tests with swiftshader ( flutter/engine#41958 )
...
fixes https://github.com/flutter/flutter/issues/126022
[C++, Objective-C, Java style guides]: https://github.com/flutter/engine/blob/main/CONTRIBUTING.md#style
2023-05-12 20:34:55 +00:00
Mouad Debbar
e87d7155d2
[web] Fix crash on old versions of Chrome (Intl.Segmenter missing) ( flutter/engine#41986 )
...
`Chrome < v87` have the `v8BreakIterator` API but don't have `Intl.Segmenter`. This caused crashes for some apps (see b/281377168).
This PR enhances our feature detection to take into account this API mismatch.
2023-05-12 19:59:30 +00:00
godofredoc
bb93b87e6a
Move clang tidy v2 build to prod. ( flutter/engine#41985 )
...
The mac clang tidy build has been running successfully on staging for several days. This is also moving the ios and host legacy clang tidy builds to staging.
[C++, Objective-C, Java style guides]: https://github.com/flutter/engine/blob/main/CONTRIBUTING.md#style
2023-05-12 18:13:25 +00:00
godofredoc
e22a07ec64
Reland "Move linux_license to engine v2."" ( flutter/engine#41983 )
...
Relands https://github.com/flutter/engine/pull/41863
2023-05-12 17:57:52 +00:00
skia-flutter-autoroll
62b4895565
Roll Dart SDK from 6cd6e54f280d to 858f83d6d993 (2 revisions) ( flutter/engine#41980 )
...
https://dart.googlesource.com/sdk.git/+log/6cd6e54f280d..858f83d6d993
2023-05-12 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com Version 3.1.0-105.0.dev
2023-05-12 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com Version 3.1.0-104.0.dev
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/dart-sdk-flutter-engine
Please CC aaclarke@google.com ,dart-vm-team@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter Engine: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2023-05-12 14:47:23 +00:00
skia-flutter-autoroll
ec9efaf5f5
Roll Skia from 0b929ada9cc6 to 539fb10d7cfb (2 revisions) ( flutter/engine#41979 )
...
https://skia.googlesource.com/skia.git/+log/0b929ada9cc6..539fb10d7cfb
2023-05-12 kjlubick@google.com Move SkSurface::MakeNull to SkSurfaces::Null
2023-05-12 skia-autoroll@skia-public.iam.gserviceaccount.com Roll vulkan-deps from 729c65ec74f6 to 0d737f701865 (1 revision)
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC aaclarke@google.com ,brianosman@google.com,djsollen@google.com,rmistry@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2023-05-12 14:03:12 +00:00
skia-flutter-autoroll
d7c203b504
Roll Fuchsia Mac SDK from MjcKzcsqMDkuRKopu... to rO5qs4MpN6WfJcu64... ( flutter/engine#41975 )
...
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/fuchsia-mac-sdk-flutter-engine
Please CC aaclarke@google.com ,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2023-05-12 11:19:37 +00:00
skia-flutter-autoroll
3c6918db71
Roll Dart SDK from 4028c7d8b87c to 6cd6e54f280d (1 revision) ( flutter/engine#41974 )
...
https://dart.googlesource.com/sdk.git/+log/4028c7d8b87c..6cd6e54f280d
2023-05-12 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com Version 3.1.0-103.0.dev
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/dart-sdk-flutter-engine
Please CC aaclarke@google.com ,dart-vm-team@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter Engine: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2023-05-12 10:53:02 +00:00
skia-flutter-autoroll
141e7f3731
Roll Fuchsia Linux SDK from lf8VcONMWlne4oa3H... to HMLNsG7w9sTDpW2Ge... ( flutter/engine#41973 )
...
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/fuchsia-linux-sdk-flutter-engine
Please CC aaclarke@google.com ,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2023-05-12 10:02:16 +00:00
skia-flutter-autoroll
af26e7dc4f
Roll Skia from 208a07f71701 to 0b929ada9cc6 (2 revisions) ( flutter/engine#41971 )
...
https://skia.googlesource.com/skia.git/+log/208a07f71701..0b929ada9cc6
2023-05-12 skia-autoroll@skia-public.iam.gserviceaccount.com Roll ANGLE from 8b9440b630cb to 25def1a0da1c (6 revisions)
2023-05-12 skia-autoroll@skia-public.iam.gserviceaccount.com Roll SK Tool from 0d899fb75655 to ab616e27381f
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC aaclarke@google.com ,brianosman@google.com,djsollen@google.com,rmistry@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2023-05-12 07:45:05 +00:00
Dan Field
29c5e7808b
[Impeller] [Android] Refactor the Android context/surface implementation to work more like Skia. ( flutter/engine#41059 )
...
Noticed this while working on https://github.com/flutter/flutter/issues/124181
In Impeller right now, Android creates a context for each surface - but in Skia, Android creates one context and shares it across surfaces. For the multiple-engine scenario this matters. This also makes it possible for Android to provide the impeller::Context independently of surface creation.
2023-05-12 07:10:05 +00:00
skia-flutter-autoroll
dcc6e318f8
Roll Skia from ccec5093ca38 to 208a07f71701 (1 revision) ( flutter/engine#41970 )
...
https://skia.googlesource.com/skia.git/+log/ccec5093ca38..208a07f71701
2023-05-12 skia-autoroll@skia-public.iam.gserviceaccount.com Roll Skia Infra from 5a8b571f3a48 to 0d899fb75655 (6 revisions)
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC aaclarke@google.com ,brianosman@google.com,djsollen@google.com,rmistry@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2023-05-12 07:00:22 +00:00
Jonah Williams
e8cf388701
[Impeller] Dont synthesize fake index buffer if none was provided to VBB ( flutter/engine#41969 )
...
Followup from https://github.com/flutter/flutter/issues/126572
2023-05-12 05:58:04 +00:00
Dan Field
d1c3dac55d
[Impeller] Make index buffer optional ( flutter/engine#41962 )
...
Makes the index buffer optional. For calls that were just filling the index buffer with e.g. `std::iota`, it was wasteful. @jonahwilliams has also found cases where the index buffer will run out of room for drawPoints with lots of points.
Fixes https://github.com/flutter/flutter/issues/126572
2023-05-12 05:12:22 +00:00
skia-flutter-autoroll
46f623176e
Roll Dart SDK from 7ad028c26344 to 4028c7d8b87c (8 revisions) ( flutter/engine#41967 )
...
https://dart.googlesource.com/sdk.git/+log/7ad028c26344..4028c7d8b87c
2023-05-11 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com Version 3.1.0-102.0.dev
2023-05-11 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com Version 3.1.0-101.0.dev
2023-05-11 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com Version 3.1.0-100.0.dev
2023-05-10 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com Version 3.1.0-99.0.dev
2023-05-10 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com Version 3.1.0-98.0.dev
2023-05-10 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com Version 3.1.0-97.0.dev
2023-05-10 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com Version 3.1.0-96.0.dev
2023-05-10 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com Version 3.1.0-95.0.dev
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/dart-sdk-flutter-engine
Please CC aaclarke@google.com ,dart-vm-team@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter Engine: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2023-05-12 03:30:27 +00:00
Bruno Leroux
8a9edf40aa
[Linux - TextInput] Do not add new line for send action ( flutter/engine#41895 )
...
Respects input action.
2023-05-11 16:32:43 -07:00
skia-flutter-autoroll
878e2b2c28
Roll Skia from aed81125e6bc to ccec5093ca38 (10 revisions) ( flutter/engine#41963 )
...
https://skia.googlesource.com/skia.git/+log/aed81125e6bc..ccec5093ca38
2023-05-11 johnstiles@google.com Restructure Extension processing.
2023-05-11 johnstiles@google.com Simplify DSLVar classes.
2023-05-11 michaelludwig@google.com [skif] Don't assume SkSpecialImage::asShader() is non-null
2023-05-11 skia-autoroll@skia-public.iam.gserviceaccount.com Roll vulkan-deps from 0b71657bab97 to 729c65ec74f6 (5 revisions)
2023-05-11 michaelludwig@google.com [skif] Only consider CF's transparency not whole IF subtree
2023-05-11 jmbetancourt@google.com set SlotType to use enum
2023-05-11 jmbetancourt@google.com [skottie] set up ImageAssetProxy to support slottable assets
2023-05-11 jmbetancourt@google.com [skottie] apply changes live to slottable properties
2023-05-11 jmbetancourt@google.com [skottie] automatically populate slotManager with slots
2023-05-11 johnstiles@google.com Remove more unused portions of DSLCore.
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC aaclarke@google.com ,brianosman@google.com,djsollen@google.com,rmistry@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2023-05-11 23:26:36 +00:00
skia-flutter-autoroll
fcf19d1d9b
Roll Fuchsia Mac SDK from 2tQjI0g3aDmjHAtMw... to MjcKzcsqMDkuRKopu... ( flutter/engine#41960 )
...
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/fuchsia-mac-sdk-flutter-engine
Please CC aaclarke@google.com ,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2023-05-11 22:34:29 +00:00
Callum Moffat
1b72600567
iPhone floating cursor selection ( flutter/engine#36643 )
...
Floating cursor selection hasn't worked as we haven't been returning a real value for `caretRectForPosition:`. If we have the selection rectangles, we can do so.
Fixes [#30476 ](https://github.com/flutter/flutter/issues/30476 )
Requires selection rects to be turned on for iPhone (https://github.com/flutter/flutter/pull/113048 )
writing and running engine tests.
2023-05-11 22:19:01 +00:00
