DEV/flutter_flutter
1
0
Fork 0
mirror of https://github.com/flutter/flutter.git synced 2026-02-20 02:29:02 +08:00
Code Issues Packages Projects Releases Wiki Activity

[web] Cleaner output on LUCI (flutter/engine#41989)

Browse Source 
Using ansi colors in LUCI results in output that looks like:
```
00:00 +0: loading flutter_tester_emulation_golden_test.dart                                                                                                                                            
00:01 +0: loading flutter_tester_emulation_golden_test.dart                                                                                                                                            
00:02 +0: loading flutter_tester_emulation_golden_test.dart
```

This PR disables colors on LUCI so that we get clean output that's easily scannable and searchable.
This commit is contained in:
Mouad Debbar 2023-05-12 17:50:22 -04:00 committed by GitHub
parent fea415faa0
commit 7b3b362623
2 changed files with 9 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

1
engine/src/flutter/lib/web_ui/dev/steps/run_suite_step.dart
View File

@ -84,6 +84,7 @@ class RunSuiteStep implements PipelineStep {
'--platform=${browserEnvironment.packageTestRuntime.identifier}',
'--precompiled=$bundleBuildPath',
'--configuration=$configurationFilePath',
if (AnsiColors.shouldEscape) '--color' else '--no-color',
// TODO(jacksongardner): Set the default timeout to five minutes when
// https://github.com/dart-lang/test/issues/2006 is fixed.

9
engine/src/flutter/lib/web_ui/dev/utils.dart
View File

@ -10,6 +10,7 @@ import 'package:args/command_runner.dart';
import 'package:meta/meta.dart';
import 'package:path/path.dart' as path;
import 'common.dart';
import 'environment.dart';
import 'exceptions.dart';
import 'felt_config.dart';
@ -428,7 +429,13 @@ io.Directory getSkiaGoldDirectoryForSuite(TestSuite suite) {
}
extension AnsiColors on String {
static bool shouldEscape = io.stdout.hasTerminal && io.stdout.supportsAnsiEscapes;
static bool shouldEscape = () {
if (isLuci) {
// Produce clean output on LUCI.
return false;
}
return io.stdout.hasTerminal && io.stdout.supportsAnsiEscapes;
}();
static const String _noColorCode = '\u001b[39m';