DEV/flutter_flutter
1
0
Fork 0
mirror of https://github.com/flutter/flutter.git synced 2026-02-20 02:29:02 +08:00
Code Issues Packages Projects Releases Wiki Activity
34,453 Commits 882 Branches 1,069 Tags
Commit Graph

34453 Commits

This Branch
This Branch
All Branches
Author SHA1 Message Date
skia-flutter-autoroll
eccddb85ef Roll Skia from dfd933f9930c to 4b98d7b3ff2d (2 revisions) (flutter/engine#51160) 
https://skia.googlesource.com/skia.git/+log/dfd933f9930c..4b98d7b3ff2d

2024-03-04 skia-autoroll@skia-public.iam.gserviceaccount.com Roll SK Tool from f5ba03c10e1a to 4425aa95d113
2024-03-04 skia-autoroll@skia-public.iam.gserviceaccount.com Roll Skia Infra from d92d5744e419 to f5ba03c10e1a (1 revision)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC aaclarke@google.com,brianosman@google.com,herb@google.com,rmistry@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2024-03-04 06:43:12 +00:00
skia-flutter-autoroll
cfa66fea1a Roll Skia from a57372ca2e66 to dfd933f9930c (1 revision) (flutter/engine#51158) 
https://skia.googlesource.com/skia.git/+log/a57372ca2e66..dfd933f9930c

2024-03-04 skia-autoroll@skia-public.iam.gserviceaccount.com Roll Dawn from 0b135d53cd80 to d9da44a9929a (8 revisions)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC aaclarke@google.com,brianosman@google.com,herb@google.com,rmistry@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2024-03-04 05:25:22 +00:00
Liam Appelbe
27ca389132 Experimental platform isolates API (flutter/engine#48551) 
This is a prototype of the [PlatformIsolate
API](https://github.com/flutter/flutter/issues/136314).

**UPDATE (Jan 25):** The PR is ready for review. PTAL.

The `PlatformIsolate` creation flow is:

1. `PlatformIsolate.spawn` running on parent isolate
(platform_isolate.dart)
    a. Create `isolateReadyPort`
    b. `PlatformIsolateNativeApi::Spawn` (platform_isolate.cc)
    c. `DartIsolate::CreatePlatformIsolate` (dart_isolate.cc)
d. Isolate created. Entry point invocation task dispatched to platform
thread
    e. `PlatformIsolate.spawn` returns a `Future<Isolate>`
2. On the platform thread, `_platformIsolateMain` is invoked in the
platform isolate
    a. Create `entryPointPort`
b. Send `Isolate.current` metadata and `entryPointPort` back to the
parent isolate via `isolateReadyPort`
3. Back in the parent isolate, `isolateReadyPort.handler` is invoked
a. Send the user's `entryPoint` and `message` to the platform isolate
via `entryPointPort`
b. Use received isolate metadata to create a new `Isolate` representing
the platform isolate and complete the `Future<Isolate>`
4. In the platform isolate, `entryPointPort.handler` is invoked
    a. Run the user's `entryPoint(message)`

The engine shutdown flow is handled by `PlatformIsolateManager`, which
maintains a set of running platform isolates.
 2024-03-04 16:47:41 +13:00
Robert Ancell
614df9461d Fix custom FlValue API not being exported (flutter/engine#51154) 
Would fail to link when using it in a Flutter app.
 2024-03-04 15:05:41 +13:00
Zachary Anderson
8c09cffb92 Fold the GN dart_pkg template into its only use (flutter/engine#51151) 2024-03-03 20:33:47 +00:00
Jason Simmons
46259ce840 [Impeller] ASAN/LSAN fixes for the mock Vulkan implementation (flutter/engine#51115) 2024-03-01 22:18:22 +00:00
skia-flutter-autoroll
0d6adc6ec3 Roll Skia from b44ad3d40f54 to a57372ca2e66 (1 revision) (flutter/engine#51122) 
https://skia.googlesource.com/skia.git/+log/b44ad3d40f54..a57372ca2e66

2024-03-01 skia-autoroll@skia-public.iam.gserviceaccount.com Roll vulkan-deps from 0c9fdfc6c483 to 49ae911d780a (6 revisions)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC aaclarke@google.com,brianosman@google.com,rmistry@google.com,robertphillips@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2024-03-01 15:27:11 +00:00
skia-flutter-autoroll
7512a0d8c3 Roll Skia from d672d0fe2f0d to b44ad3d40f54 (1 revision) (flutter/engine#51121) 
https://skia.googlesource.com/skia.git/+log/d672d0fe2f0d..b44ad3d40f54

2024-03-01 skia-autoroll@skia-public.iam.gserviceaccount.com Roll ANGLE from 4d362242673e to 2ee295b475ec (8 revisions)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC aaclarke@google.com,brianosman@google.com,rmistry@google.com,robertphillips@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2024-03-01 07:53:05 +00:00
skia-flutter-autoroll
b2f1e43de0 Roll Skia from 002f4366e473 to d672d0fe2f0d (2 revisions) (flutter/engine#51119) 
https://skia.googlesource.com/skia.git/+log/002f4366e473..d672d0fe2f0d

2024-03-01 skia-autoroll@skia-public.iam.gserviceaccount.com Roll SK Tool from d92d5744e419 to f5ba03c10e1a
2024-03-01 skia-autoroll@skia-public.iam.gserviceaccount.com Roll Skia Infra from 983e5c4c3486 to d92d5744e419 (8 revisions)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC aaclarke@google.com,brianosman@google.com,rmistry@google.com,robertphillips@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2024-03-01 06:48:23 +00:00
skia-flutter-autoroll
3e389aca25 Roll Skia from 5961ed9c1d99 to 002f4366e473 (1 revision) (flutter/engine#51117) 
https://skia.googlesource.com/skia.git/+log/5961ed9c1d99..002f4366e473

2024-03-01 skia-autoroll@skia-public.iam.gserviceaccount.com Roll Dawn from dd050a5bef8f to 0b135d53cd80 (8 revisions)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC aaclarke@google.com,brianosman@google.com,rmistry@google.com,robertphillips@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2024-03-01 05:37:14 +00:00
Jason Simmons
089d1979c5 [Impeller] Fix string search in CompilerTest.SkSLTextureLookUpOrderOfOperations (flutter/engine#51109) 2024-03-01 03:34:48 +00:00
Jason Simmons
9a9a760710 [Impeller] Fix vertex counts in some display list tests (flutter/engine#51111) 2024-03-01 03:15:16 +00:00
Jason Simmons
f37e96e73b [Impeller] Fix leak of rectangle packer in typographer tests (flutter/engine#51113) 2024-03-01 03:03:04 +00:00
skia-flutter-autoroll
0e3cb6d640 Roll Skia from 01d9566c4db8 to 5961ed9c1d99 (13 revisions) (flutter/engine#51106) 
https://skia.googlesource.com/skia.git/+log/01d9566c4db8..5961ed9c1d99

2024-02-29 bungeman@google.com Have textshaper_harfbuzz_icu direct depend
2024-02-29 johnstiles@google.com Revert "Reland "[graphite] Enable SmallPathAtlas.""
2024-02-29 johnstiles@google.com Revert "[graphite] Rasterize SmallPathAtlas paths to the Plot backing store."
2024-02-29 jvanverth@google.com [graphite] Rasterize SmallPathAtlas paths to the Plot backing store.
2024-02-29 johnstiles@google.com Reland "Delete legacy shadeSpan implementation of Perlin Noise."
2024-02-29 kschmi@microsoft.com Expose min and max contrast and gamma values publicly
2024-02-29 skia-autoroll@skia-public.iam.gserviceaccount.com Roll vulkan-deps from 12f9cddb3ff7 to 0c9fdfc6c483 (2 revisions)
2024-02-29 kjlubick@google.com Fix failures associated with skshaper refactor
2024-02-29 skia-autoroll@skia-public.iam.gserviceaccount.com Manual roll Dawn from c288d62eb31b to dd050a5bef8f (4 revisions)
2024-02-29 kjlubick@google.com Make SkShaper more modular
2024-02-29 jvanverth@google.com Reland "[graphite] Enable SmallPathAtlas."
2024-02-29 robertphillips@google.com Manual Roll Dawn from aa0be6f5777f to c288d62eb31b (14 revisions)
2024-02-29 nscobie@google.com Update gn/gn_to_bp.py to allowlist only certain extensions in srcs

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC aaclarke@google.com,brianosman@google.com,rmistry@google.com,robertphillips@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2024-03-01 02:22:16 +00:00
Zachary Anderson
49b2bad89d Run apple SDK finders as gclient hooks (flutter/engine#50957) 
Currently, these scripts run on each invocation of `gn`, and can take
many seconds to run.

This PR shifts them to run as `gclient` hooks instead, so that `gn` will
be faster.

Needs https://github.com/flutter/buildroot/pull/825.
 2024-02-29 18:14:31 -08:00
Matan Lurey
7b7d9a2f43 Add a basic e2e-test for skia_gold_client. (flutter/engine#51078) 
Basically, I take blank images of red/blue/green squares, like this:

![solid_red_square](https://github.com/flutter/engine/assets/168174/b1de63e4-8c3c-43ff-9bcf-b067a7e9d920)

... and use Image Magick to annotate it with the current git hash:

```sh
$ drt ./testing/skia_gold_client/tool/generate.dart

Writing annotation "8069cb4ca1" on images in testing/skia_gold_client/tool/source_images and saving them in testing/skia_gold_client/tool/e2e_fixtures.
Writing to testing/skia_gold_client/tool/e2e_fixtures/solid_red_square.png
Writing to testing/skia_gold_client/tool/e2e_fixtures/solid_green_square.png
Writing to testing/skia_gold_client/tool/e2e_fixtures/solid_blue_square.png
Done: wrote 3 image.
```

![solid_red_square](https://github.com/flutter/engine/assets/168174/0ece31a8-9e64-44a2-ad06-78c04b02650c)

... then, I upload the digests very similar to how we do it in `scenario_app`.

---

The idea here is to have a way for me to know if Skia gold is working the way I/we expect, independent of a more complicated test suite with various race-y or flake-y conditions. We could also augment it with tests of "dimensions" properties.
 2024-03-01 01:33:07 +00:00
John McCutchan
0be7a9c4f0 Add et run command (flutter/engine#51037) 
The `run` command builds both the host and target engines and then invokes `flutter run` so that it runs the app using the custom engine builds.

It is expected that 'et run' be used inside the directory of a flutter application.

Command line flags passed after `--` will be forwarded to `flutter run`.

Some examples:

- `et run` Build the debug variant and runs the app in that mode.
- `et run -- --profile` Build the profile variant and runs the app in that mode.
- `et run -- --release` Build the release variant and runs the app in that mode.

Also:

- Start a local_engine.json builder definition (it is missing a lot)
- Tweak the test fixture.
- Add a new Matcher to litetest.
- Tweaked the build config linter to only care about duplicate build names within the same builder.
 2024-03-01 01:09:04 +00:00
Gray Mackall
dde1849f04 Add instructions for getting code coverage in Android Studio (flutter/engine#51105) 
small readme change, because for whatever reason we need to apply the comment from this hero https://github.com/robolectric/robolectric/issues/3023#issuecomment-1326870713 to make code coverage work 

[C++, Objective-C, Java style guides]: https://github.com/flutter/engine/blob/main/CONTRIBUTING.md#style
 2024-03-01 00:02:29 +00:00
skia-flutter-autoroll
49f7a86db8 Roll Skia from 139461270500 to 01d9566c4db8 (1 revision) (flutter/engine#51093) 
https://skia.googlesource.com/skia.git/+log/139461270500..01d9566c4db8

2024-02-29 brianosman@google.com Fix subpixel image filtering in CPU backend

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC aaclarke@google.com,brianosman@google.com,rmistry@google.com,robertphillips@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2024-02-29 22:38:27 +00:00
skia-flutter-autoroll
8456f25d0e Manual roll Dart SDK from fdf4a62bd07b to 728fcf0bcbca (3 revisions) (flutter/engine#51098) 
Manual roll requested by kevinjchisholm@google.com

https://dart.googlesource.com/sdk.git/+log/fdf4a62bd07b..728fcf0bcbca

2024-02-29 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com Version 3.4.0-190.0.dev
2024-02-29 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com Version 3.4.0-189.0.dev
2024-02-28 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com Version 3.4.0-188.0.dev

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/dart-sdk-flutter-engine
Please CC aaclarke@google.com,dart-vm-team@google.com,kevinjchisholm@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter Engine: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2024-02-29 22:36:05 +00:00
Jonah Williams
f86e04d688 [Impeller] use specific format for bootstrap texture. (flutter/engine#51082) 
If we select a wide gamut format then 32 bits isn't enough to fill the texture.
 2024-02-29 21:55:03 +00:00
Jonah Williams
4ccf46cb96 [Impeller] remove warning about device transient depth+stencil. (flutter/engine#51033) 
I think this doesn't matter since use transient depth/stencil attachments now.
 2024-02-29 21:29:12 +00:00
Robert Ancell
fc560d4bc2 Refactor GL rendering to prepare for GTK4 (flutter/engine#50754) 
Refactor GL rendering to prepare for GTK4    
- Remove FlGLArea - we can just use GtkGLArea directly
- Stop using gdk_cairo_draw_from_gl, it's not available in GTK4.
- Rename FlRendererGL to FlRendererGdk, this was implying that
FlRenderer could be something other than OpenGL which is not the case
currently.
- Remove unnecessary virtual methods in FlRenderer, just implement them
as standard methods.

Related: https://github.com/flutter/flutter/issues/143408
 2024-03-01 10:24:11 +13:00
Jackson Gardner
0424f1f86e Reland "[skwasm] Clip pictures if they go beyond the bounds of the window." (flutter/engine#51077) 
This fixes https://github.com/flutter/flutter/issues/143800, where we are attempting to capture an image that is way too large. We only need to render the part of the image that will be visible in the window.

This includes some additional fixes for regressions in the original fix.
 2024-02-29 21:06:02 +00:00
Matej Knopp
0d3941630d Revert "[macOS] Use CVDisplayLink to drive repaint (#49159)" (flutter/engine#51095) 
The original PR assumed that `fml::TimePoint` has same base as
`CACurrentMediaTime()`. However due to recent change in Dart SDK that's
no longer true. Dart SDK
[replaced](https://dart-review.googlesource.com/c/sdk/+/348044?tab=comments)
call to `mach_absolute_time` with
`clock_gettime_nsec_np(CLOCK_MONOTONIC_RAW)`, while
`CACurrentMediaTime()` corresponds to `CLOCK_UPTIME_RAW`.

This needs to be fixed either in Dart SDK
https://github.com/dart-lang/sdk/issues/55071 or the original PR needs
to be relanded with appropriate conversions.

This reverts commit 8ff01af723be83ab019b0ddf7d64d8586d280186.

*Replace this paragraph with a description of what this PR is changing
or adding, and why. Consider including before/after screenshots.*

*List which issues are fixed by this PR. You must list at least one
issue.*

*If you had to change anything in the [flutter/tests] repo, include a
link to the migration guide as per the [breaking change policy].*

## Pre-launch Checklist

- [x] I read the [Contributor Guide] and followed the process outlined
there for submitting PRs.
- [x] I read the [Tree Hygiene] wiki page, which explains my
responsibilities.
- [x] I read and followed the [Flutter Style Guide] and the [C++,
Objective-C, Java style guides].
- [x] I listed at least one issue that this PR fixes in the description
above.
- [x] I added new tests to check the change I am making or feature I am
adding, or the PR is [test-exempt]. See [testing the engine] for
instructions on writing and running engine tests.
- [x] I updated/added relevant documentation (doc comments with `///`).
- [x] I signed the [CLA].
- [x] All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel
on [Discord].

<!-- Links -->
[Contributor Guide]:
https://github.com/flutter/flutter/wiki/Tree-hygiene#overview
[Tree Hygiene]: https://github.com/flutter/flutter/wiki/Tree-hygiene
[test-exempt]:
https://github.com/flutter/flutter/wiki/Tree-hygiene#tests
[Flutter Style Guide]:
https://github.com/flutter/flutter/wiki/Style-guide-for-Flutter-repo
[C++, Objective-C, Java style guides]:
https://github.com/flutter/engine/blob/main/CONTRIBUTING.md#style
[testing the engine]:
https://github.com/flutter/flutter/wiki/Testing-the-engine
[CLA]: https://cla.developers.google.com/
[flutter/tests]: https://github.com/flutter/tests
[breaking change policy]:
https://github.com/flutter/flutter/wiki/Tree-hygiene#handling-breaking-changes
[Discord]: https://github.com/flutter/flutter/wiki/Chat
 2024-02-29 12:39:33 -08:00
Kevin Moore
7ba403293e [web] Drop noisy prints from bootstrapping logic (flutter/engine#51097) 
Fixes https://github.com/flutter/flutter/issues/143976
 2024-02-29 20:00:22 +00:00
Jackson Gardner
3615c28ff8 Fix a few issues rendering text with Skwasm. (flutter/engine#51074) 
This fixes https://github.com/flutter/flutter/issues/141001
This also fixes https://github.com/flutter/flutter/issues/143743

* We need to always call `setStrutEnabled(true)` on `StrutStyle`.
* `getLineMetricsAt` had reversed ternary logic.
* We also need to apply the rounding hack in Skwasm.
* Ported unit tests from CanvasKit over to UI to cover Skwasm ~and HTML~
* ~The HTML renderer should return 0 line metrics for an empty paragraph.~
 2024-02-29 19:42:09 +00:00
Jonah Williams
9d7d2d5142 [Impeller] test removal of submit batching. (flutter/engine#51094) 
I have a feeling this is related to https://github.com/flutter/flutter/issues/144371 

Locally on the Pixel 4 (which is a similarish GPU, the batch submission is actually regressing performance).
 2024-02-29 18:11:55 +00:00
Zachary Anderson
efda66bcff Use RBE for mac_clang_tidy (flutter/engine#51083) 2024-02-29 17:27:17 +00:00
Dan Field
2e9e6107eb Reapply "Bump everything to Android 21" (#51056) (flutter/engine#51070) 
This reverts commit 98485b3f82fec45a6a0ac932c3c20285a9a14e02.

Reverted in https://github.com/flutter/engine/pull/51056 because it
caused failures in the framework. No changes, but framework test has
been updated to use an actual robolectric implementation to avoid those
failures.

This should not land until
https://github.com/flutter/flutter/pull/144348 has landed in the
framework.

@gaaclarke @johnmccutchan fyi
 2024-02-29 09:00:01 -08:00
Loïc Sharma
461cf83c58 [Windows] Add view ID runner APIs (flutter/engine#51020) 
Allow Flutter Windows apps and plugins to get the view's ID.

Design doc: https://flutter.dev/go/desktop-multi-view-runner-apis

Part of https://github.com/flutter/flutter/issues/143767
Part of https://github.com/flutter/flutter/issues/142845

[C++, Objective-C, Java style guides]: https://github.com/flutter/engine/blob/main/CONTRIBUTING.md#style
 2024-02-29 16:22:39 +00:00
skia-flutter-autoroll
c42482040d Roll Skia from 05a8d57f0e61 to 139461270500 (1 revision) (flutter/engine#51091) 
https://skia.googlesource.com/skia.git/+log/05a8d57f0e61..139461270500

2024-02-29 kjlubick@google.com Compile Slug::NextUnique on CPU builds also

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC aaclarke@google.com,brianosman@google.com,rmistry@google.com,robertphillips@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2024-02-29 15:23:10 +00:00
skia-flutter-autoroll
84adbd5296 Roll Skia from ffbe23b3b3b9 to 05a8d57f0e61 (1 revision) (flutter/engine#51090) 
https://skia.googlesource.com/skia.git/+log/ffbe23b3b3b9..05a8d57f0e61

2024-02-29 skia-autoroll@skia-public.iam.gserviceaccount.com Manual roll vulkan-deps from ffd0c1c14e46 to 12f9cddb3ff7 (3 revisions)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC aaclarke@google.com,brianosman@google.com,rmistry@google.com,robertphillips@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2024-02-29 14:18:40 +00:00
skia-flutter-autoroll
94ba9367c4 Roll Skia from 0d00c9f3852a to ffbe23b3b3b9 (2 revisions) (flutter/engine#51089) 
https://skia.googlesource.com/skia.git/+log/0d00c9f3852a..ffbe23b3b3b9

2024-02-29 jgaillard@google.com Use UserConfig to load platform in SkImageGeneratorCG.h
2024-02-29 skia-autoroll@skia-public.iam.gserviceaccount.com Roll ANGLE from 434a5b01707d to 4d362242673e (3 revisions)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC aaclarke@google.com,brianosman@google.com,rmistry@google.com,robertphillips@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2024-02-29 12:49:36 +00:00
skia-flutter-autoroll
cc0e2ddc42 Roll Skia from ef2511b0a6f2 to 0d00c9f3852a (2 revisions) (flutter/engine#51086) 
https://skia.googlesource.com/skia.git/+log/ef2511b0a6f2..0d00c9f3852a

2024-02-29 skia-autoroll@skia-public.iam.gserviceaccount.com Roll SK Tool from 983e5c4c3486 to 8be5f1367447
2024-02-29 skia-autoroll@skia-public.iam.gserviceaccount.com Roll Skia Infra from 1ce4523589b0 to 983e5c4c3486 (7 revisions)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC aaclarke@google.com,brianosman@google.com,rmistry@google.com,robertphillips@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2024-02-29 09:02:04 +00:00
Matan Lurey
b2b8311980 The adb logcat filtering will continue until morale improves. (flutter/engine#51069) 
Closes https://github.com/flutter/flutter/issues/144346.
 2024-02-28 19:10:17 -08:00
skia-flutter-autoroll
f1eec9b65f Roll Skia from f0a60bfe98e0 to ef2511b0a6f2 (2 revisions) (flutter/engine#51075) 
https://skia.googlesource.com/skia.git/+log/f0a60bfe98e0..ef2511b0a6f2

2024-02-28 skia-autoroll@skia-public.iam.gserviceaccount.com Manual roll ANGLE from a627dd89762e to 434a5b01707d (5 revisions)
2024-02-28 brianosman@google.com Remove outdated assert (that no longer holds)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC aaclarke@google.com,brianosman@google.com,rmistry@google.com,robertphillips@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2024-02-29 03:09:08 +00:00
Robert Ancell
da5550db7f Update Linux embedder to latest semantics API (flutter/engine#51030) 
Change to the latest semantics API and remove an unused class.
 2024-02-29 15:18:19 +13:00
Jonah Williams
65f3a2348b [Impeller] switch fallback default from ImpellerVulkan to SkiaOpenGLES (flutter/engine#51071) 
Unblocks shipping Impeller on Android before GLES is ready.
 2024-02-29 01:47:19 +00:00
skia-flutter-autoroll
f026d97f42 Roll Skia from 27171d6a9205 to f0a60bfe98e0 (4 revisions) (flutter/engine#51068) 
https://skia.googlesource.com/skia.git/+log/27171d6a9205..f0a60bfe98e0

2024-02-28 skia-autoroll@skia-public.iam.gserviceaccount.com Manual roll vulkan-deps from 83c3be5d8216 to ffd0c1c14e46 (2 revisions)
2024-02-28 herb@google.com Reland "Cleanup linkage in SkSwizzler_opts.h"
2024-02-28 johnstiles@google.com Update Perlin noise GM slide.
2024-02-28 herb@google.com Only define _opts functions when needed

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC aaclarke@google.com,brianosman@google.com,rmistry@google.com,robertphillips@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2024-02-28 23:44:50 +00:00
Casey Hillers
66a29b492b Prefix flutter in flutter_vma.h import (flutter/engine#51065) 
Breaks the Google build (b/327309677)
 2024-02-28 22:26:55 +00:00
Jonah Williams
2305461a66 [Impeller] Cache entire render target and not just allocations. (flutter/engine#50990) 
This may be required to fix https://github.com/flutter/flutter/issues/144116 , and in general the safety of the render pass caches.

Because the RenderPass / Framebuffer objects refer to specific attachments, the caches are placed on the resolve texture, which is "real". The stencil/depth and or MSAA textures may be different but that didn't seem to matter on many Android devices. It doesn't seem like its actually valid though, whether or not there is a validation error to catch it.

I can confirm this fixes https://github.com/flutter/flutter/issues/144116  locally.

This change moves the cache one level up to cover the properties of the RenderTarget we care about, and ensures that we always use the same attachment combinations.

Fixes https://github.com/flutter/flutter/issues/141750
Maybe https://github.com/flutter/flutter/issues/144255 ?
 2024-02-28 22:23:05 +00:00
Matan Lurey
bc4d5caa20 Test the SurfaceTextureSurfaceProducer-branch in the Android scenario_app (flutter/engine#51061) 
This PR does the following:
- Relands https://github.com/flutter/engine/pull/50993.
- Fixes a bug in `SurfaceTextureSurfaceProducer` where it would crash on
release (now tested, yay!)

Closes https://github.com/flutter/flutter/issues/143539.
Closes https://github.com/flutter/flutter/issues/143483.

/cc @gaaclarke @chinmaygarde, this PR should (after landed) test/verify
https://github.com/flutter/engine/pull/50730.
 2024-02-28 14:17:21 -08:00
Jackson Gardner
c98ee51b1e Revert "[skwasm] Clip pictures if they go beyond the bounds of the window. (#50887)" (flutter/engine#51067) 
This reverts commit 3af9b7b3baa33896103d286d3e4593f95b87b7a7.

The change is causing skwasm benchmarks to flake. See https://ci.chromium.org/ui/p/flutter/builders/luci.flutter.prod/Linux%20web_benchmarks_skwasm
 2024-02-28 21:20:00 +00:00
skia-flutter-autoroll
b2f8f71a8b Roll Fuchsia Linux SDK from T1xAi_ww_mWEiDkVN... to ujOkbeYbrC8loPbfR... (flutter/engine#51066) 
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/fuchsia-linux-sdk-flutter-engine
Please CC aaclarke@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2024-02-28 21:12:11 +00:00
Chris Bracken
99f8815ee4 Roll abseil-cpp to 1db3bdd4eb208bef55c77f22aa94991e52225230 (flutter/engine#51062) 
Our abseil dependency is a clone of Chromium's, located at:
https://chromium.googlesource.com/chromium/src/third_party/

which is a downstream copy of the source of truth, located at:
https://github.com/abseil/abseil-cpp

This rolls to Chromium commit 185f27671ca28c0f25d9d7a15b6e621f69972706,
then reapplies jsimmons@google.com's commits, in chronological order:
* 9ec8f453a42aad2f11a1760fe4ce6014a124edc2
* f92f9effc89af7692436c3b9fbb3a67f2239d893
* 61833f2c057a2b1993d871e8c51156aed1dd4354

Preparation for: https://github.com/flutter/flutter/issues/144201
Part of: https://github.com/flutter/flutter/issues/67373

## Pre-launch Checklist

- [X] I read the [Contributor Guide] and followed the process outlined
there for submitting PRs.
- [X] I read the [Tree Hygiene] wiki page, which explains my
responsibilities.
- [X] I read and followed the [Flutter Style Guide] and the [C++,
Objective-C, Java style guides].
- [X] This patch complies with USDA policy on the use of bovine growth
hormone.
- [X] I listed at least one issue that this PR fixes in the description
above.
- [X] I added new tests to check the change I am making or feature I am
adding, or the PR is [test-exempt]. See [testing the engine] for
instructions on writing and running engine tests.
- [X] I updated/added relevant documentation (doc comments with `///`).
- [X] I signed the [CLA].
- [X] All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel
on [Discord].

<!-- Links -->
[Contributor Guide]:
https://github.com/flutter/flutter/wiki/Tree-hygiene#overview
[Tree Hygiene]: https://github.com/flutter/flutter/wiki/Tree-hygiene
[test-exempt]:
https://github.com/flutter/flutter/wiki/Tree-hygiene#tests
[Flutter Style Guide]:
https://github.com/flutter/flutter/wiki/Style-guide-for-Flutter-repo
[C++, Objective-C, Java style guides]:
https://github.com/flutter/engine/blob/main/CONTRIBUTING.md#style
[testing the engine]:
https://github.com/flutter/flutter/wiki/Testing-the-engine
[CLA]: https://cla.developers.google.com/
[flutter/tests]: https://github.com/flutter/tests
[breaking change policy]:
https://github.com/flutter/flutter/wiki/Tree-hygiene#handling-breaking-changes
[Discord]: https://github.com/flutter/flutter/wiki/Chat
 2024-02-28 13:00:30 -08:00
skia-flutter-autoroll
631edadb1c Roll Dart SDK from 7896a944fe67 to fdf4a62bd07b (1 revision) (flutter/engine#51064) 
https://dart.googlesource.com/sdk.git/+log/7896a944fe67..fdf4a62bd07b

2024-02-28 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com Version 3.4.0-187.0.dev

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/dart-sdk-flutter-engine
Please CC aaclarke@google.com,dart-vm-team@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter Engine: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2024-02-28 20:58:06 +00:00
Jason Simmons
f6f7230917 [Impeller] Mark subpass framebuffer fetch tests as unsupported on GLES (flutter/engine#50982) 
Currently the GLES backend may claim the framebuffer fetch capability but its implementation does not support the multisample subpass input used in this test.  Do not run this on GLES until there is clarification of the level of framebuffer fetch support intended for the GLES backend.
 2024-02-28 20:54:06 +00:00
skia-flutter-autoroll
037e853355 Roll Skia from 93f245da0097 to 27171d6a9205 (1 revision) (flutter/engine#51063) 
https://skia.googlesource.com/skia.git/+log/93f245da0097..27171d6a9205

2024-02-28 johnstiles@google.com Fix baseFrequencyY calculation again.

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC aaclarke@google.com,brianosman@google.com,rmistry@google.com,robertphillips@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2024-02-28 20:37:05 +00:00
Jonah Williams
8acca62755 [Impeller] fix render pass depth descriptor. (flutter/engine#51031) 
Depth+stencil should be treated as the same attachment. Adding more than one d/s attachment in the render pass descriptor seems to be confusing swiftshader.

@bdero 

This fixes things for me locally, lets let CI take a spin
 2024-02-28 20:33:51 +00:00