DEV/flutter_flutter
1
0
Fork 0
mirror of https://github.com/flutter/flutter.git synced 2026-02-20 02:29:02 +08:00
Code Issues Packages Projects Releases Wiki Activity

[Impeller] test removal of submit batching. (flutter/engine#51094)

Browse Source 
I have a feeling this is related to https://github.com/flutter/flutter/issues/144371 

Locally on the Pixel 4 (which is a similarish GPU, the batch submission is actually regressing performance).
This commit is contained in:
Jonah Williams 2024-02-29 10:11:55 -08:00 committed by GitHub
parent efda66bcff
commit 9d7d2d5142
1 changed files with 2 additions and 11 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

13
engine/src/flutter/impeller/entity/contents/content_context.cc
View File

@ -5,6 +5,7 @@
#include "impeller/entity/contents/content_context.h"
#include <memory>
#include <utility>
#include "fml/trace_event.h"
#include "impeller/base/strings.h"
@ -599,17 +600,7 @@ void ContentContext::ClearCachedRuntimeEffectPipeline(
void ContentContext::RecordCommandBuffer(
std::shared_ptr<CommandBuffer> command_buffer) const {
// Metal systems seem to have a limit on the number of command buffers that
// can be created concurrently, which appears to be in the range of 50 or so
// command buffers. When this limit is hit, creation of further command
// buffers will fail. To work around this, we regularly flush the
// command buffers on the metal backend.
if (GetContext()->GetBackendType() == Context::BackendType::kMetal) {
GetContext()->GetCommandQueue()->Submit({command_buffer});
} else {
pending_command_buffers_->command_buffers.push_back(
std::move(command_buffer));
}
GetContext()->GetCommandQueue()->Submit({std::move(command_buffer)});
}
void ContentContext::FlushCommandBuffers() const {