31531 Commits

Author SHA1 Message Date
skia-flutter-autoroll
ebd9e705e0 Roll Skia from 1e84aa4509cd to 91adc7d289f7 (2 revisions) (flutter/engine#46040)
https://skia.googlesource.com/skia.git/+log/1e84aa4509cd..91adc7d289f7

2023-09-19 robertphillips@google.com [graphite] Refactor the precompilation SelectOption and AddToKey methods
2023-09-19 kjlubick@google.com Add googlefonts CIPD asset to fontations

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC brianosman@google.com,jonahwilliams@google.com,rmistry@google.com,tdenniston@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2023-09-19 14:30:28 +00:00
skia-flutter-autoroll
b4f66d847b Roll Dart SDK from 8ad823c03f26 to e7cd697bd0e9 (2 revisions) (flutter/engine#46039)
https://dart.googlesource.com/sdk.git/+log/8ad823c03f26..e7cd697bd0e9

2023-09-19 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com Version 3.2.0-179.0.dev
2023-09-19 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com Version 3.2.0-178.0.dev

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/dart-sdk-flutter-engine
Please CC dart-vm-team@google.com,jonahwilliams@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter Engine: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2023-09-19 14:22:54 +00:00
skia-flutter-autoroll
929b49fcb9 Roll Fuchsia Mac SDK from qy5FU4y6sx1FscCpd... to 06g6i7-5u8O-FOTSi... (flutter/engine#46038)
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/fuchsia-mac-sdk-flutter-engine
Please CC jonahwilliams@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2023-09-19 14:13:21 +00:00
Kevin Lubick
65945baf01 Add more missing Skia #includes (flutter/engine#46034)
Ran into compile errors when refactoring Skia's #includes. This
addresses those

## Pre-launch Checklist

- [x] I read the [Contributor Guide] and followed the process outlined
there for submitting PRs.
- [x] I read the [Tree Hygiene] wiki page, which explains my
responsibilities.
- [x] I read and followed the [Flutter Style Guide] and the [C++,
Objective-C, Java style guides].
- [ ] I listed at least one issue that this PR fixes in the description
above.
- [x] I added new tests to check the change I am making or feature I am
adding, or the PR is [test-exempt]. See [testing the engine] for
instructions on writing and running engine tests.
- [ ] I updated/added relevant documentation (doc comments with `///`).
- [x] I signed the [CLA].
- [x] All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel
on [Discord].

<!-- Links -->
[Contributor Guide]:
https://github.com/flutter/flutter/wiki/Tree-hygiene#overview
[Tree Hygiene]: https://github.com/flutter/flutter/wiki/Tree-hygiene
[test-exempt]:
https://github.com/flutter/flutter/wiki/Tree-hygiene#tests
[Flutter Style Guide]:
https://github.com/flutter/flutter/wiki/Style-guide-for-Flutter-repo
[C++, Objective-C, Java style guides]:
https://github.com/flutter/engine/blob/main/CONTRIBUTING.md#style
[testing the engine]:
https://github.com/flutter/flutter/wiki/Testing-the-engine
[CLA]: https://cla.developers.google.com/
[flutter/tests]: https://github.com/flutter/tests
[breaking change policy]:
https://github.com/flutter/flutter/wiki/Tree-hygiene#handling-breaking-changes
[Discord]: https://github.com/flutter/flutter/wiki/Chat
2023-09-19 10:05:20 -04:00
Bruno Leroux
195a313245 [macOS,iOS] Expose channel buffers 'resize' and 'overflow' control co… (flutter/engine#44848)
## Description

This PR update the helper function that invokes the control channel 'resize' command (previous implementation relied on a deprecated format). It also adds a similar helper function for the 'overflow' commands exposed by the control channel.

See:

c00c022036/lib/ui/channel_buffers.dart (L302-L309)

## Related Issue

iOS and macOS implementation for https://github.com/flutter/flutter/issues/132386

Similar implementations:
- Android: https://github.com/flutter/engine/pull/44434
- Linux: https://github.com/flutter/engine/pull/44636

## Tests

Adds two tests.
2023-09-19 09:40:18 +00:00
skia-flutter-autoroll
d9a3f74eec Roll Dart SDK from 5b0e7bda1379 to 8ad823c03f26 (3 revisions) (flutter/engine#46028)
https://dart.googlesource.com/sdk.git/+log/5b0e7bda1379..8ad823c03f26

2023-09-19 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com Version 3.2.0-177.0.dev
2023-09-18 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com Version 3.2.0-176.0.dev
2023-09-18 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com Version 3.2.0-175.0.dev

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/dart-sdk-flutter-engine
Please CC dart-vm-team@google.com,jonahwilliams@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter Engine: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2023-09-19 09:34:14 +00:00
skia-flutter-autoroll
68136393cd Roll Skia from 744807d740c7 to 1e84aa4509cd (4 revisions) (flutter/engine#46026)
https://skia.googlesource.com/skia.git/+log/744807d740c7..1e84aa4509cd

2023-09-19 skia-autoroll@skia-public.iam.gserviceaccount.com Roll ANGLE from 18f1b3b8e79d to 91ef1f3cfd30 (11 revisions)
2023-09-19 skia-autoroll@skia-public.iam.gserviceaccount.com Roll Skia Infra from 6e55411b61e1 to 1b17251d0e2c (10 revisions)
2023-09-19 skia-autoroll@skia-public.iam.gserviceaccount.com Roll Dawn from 02233e019c4e to 5ca21ed72084 (5 revisions)
2023-09-19 skia-autoroll@skia-public.iam.gserviceaccount.com Roll SK Tool from aea31dd66eb1 to 1b17251d0e2c

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC bdero@google.com,brianosman@google.com,rmistry@google.com,tdenniston@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2023-09-19 07:37:31 +00:00
skia-flutter-autoroll
2fcd4ce6eb Roll Skia from 4122791099ce to 744807d740c7 (1 revision) (flutter/engine#46019)
https://skia.googlesource.com/skia.git/+log/4122791099ce..744807d740c7

2023-09-19 skia-autoroll@skia-public.iam.gserviceaccount.com Roll vulkan-deps from cf45d7c5dc0d to 293f55f6d3d0 (5 revisions)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC bdero@google.com,brianosman@google.com,rmistry@google.com,tdenniston@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2023-09-19 04:17:22 +00:00
Jonah Williams
88e963e0fd [Android] Add support for setting thread affinity based on core speed. (flutter/engine#45673)
https://github.com/flutter/flutter/issues/134452

This patch parses the speed of all CPU data out of /proc and constructs a table that allows us to request high level CPU affinities: performance, efficiency, and not performance. These affinties are applied where appropriate during Android thread construction.
2023-09-19 03:50:05 +00:00
Chinmay Garde
88f8bb7e25 [Impeller] Fix STB backend to account for max texture sizes. (flutter/engine#46010)
Gets rid of the hardcoded 2048 px size.

Followup from review comment left unaddressed in https://github.com/flutter/engine/pull/45992.

Missing this will be less easy after https://github.com/flutter/flutter/issues/133029.
2023-09-19 03:26:36 +00:00
Matan Lurey
2b4d2616aa [Impeller] Hold the CommandPoolVK at a higher scope. (flutter/engine#46013)
Fixes https://github.com/flutter/flutter/issues/134982.

I could never reproduce the flakes locally, but this should prevent `pool1 == pool2`.
2023-09-19 01:25:25 +00:00
skia-flutter-autoroll
ac6eb5de3d Roll Skia from 0c990ab9e097 to 4122791099ce (19 revisions) (flutter/engine#46016)
https://skia.googlesource.com/skia.git/+log/0c990ab9e097..4122791099ce

2023-09-18 johnstiles@google.com Remove orphaned test disable.
2023-09-18 brianosman@google.com Remove paint-color transform in working-format color filter
2023-09-18 skia-autoroll@skia-public.iam.gserviceaccount.com Roll shaders-base from 45116d485d17 to 75c3a7bb1f19
2023-09-18 skia-autoroll@skia-public.iam.gserviceaccount.com Roll skottie-base from ac643e8ecce3 to 6fbc053bdad0
2023-09-18 skia-autoroll@skia-public.iam.gserviceaccount.com Roll jsfiddle-base from 420bf03c7a80 to 3c3b69cdbecd
2023-09-18 skia-autoroll@skia-public.iam.gserviceaccount.com Roll debugger-app-base from 5b191a5ec3d1 to 4880b92b4f1c
2023-09-18 brianosman@google.com Suppress alpha-only image shader logic when sampled via runtime effects
2023-09-18 bungeman@google.com Reland "[skicu] Use cache and respect locale"
2023-09-18 johnstiles@google.com Remove Dawn Ganesh-specific SkSL test disables.
2023-09-18 brianosman@google.com In DM, use an SkSurface for CPU configs
2023-09-18 johnstiles@google.com Add contextType() accessor to test contexts.
2023-09-18 kjlubick@google.com Enforce IWYU on src/core/SkC* and SkD*
2023-09-18 kjlubick@google.com Remove TextBlob's empty mailbox in favor of delegate
2023-09-18 egdaniel@google.com Remove SkRefCnt from GrGpu.
2023-09-18 jmbetancourt@google.com [skottie] make SkottieSlide slot manager UI responsive to live changes
2023-09-18 skia-autoroll@skia-public.iam.gserviceaccount.com Manual roll ANGLE from 22b6ca1c6191 to 18f1b3b8e79d (2 revisions)
2023-09-18 johnstiles@google.com Re-enable pixel-local storage test.
2023-09-18 skia-autoroll@skia-public.iam.gserviceaccount.com Roll vulkan-deps from 53e6e021f9b7 to cf45d7c5dc0d (1 revision)
2023-09-18 johnstiles@google.com Pass test run details into SkSL test permutation runner.

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC bdero@google.com,brianosman@google.com,rmistry@google.com,tdenniston@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2023-09-19 01:21:21 +00:00
Kevin Lubick
114d818f47 Add missing include of SkPath (flutter/engine#45996)
This is needed as Skia refactors its #includes internally.

[C++, Objective-C, Java style guides]: https://github.com/flutter/engine/blob/main/CONTRIBUTING.md#style
2023-09-18 23:49:17 +00:00
Chinmay Garde
91066844ea [Impeller] Respect max supported texture size when allocating glyph atlas texture. (flutter/engine#45992)
The earlier limit of 4096u was pessimistically small on some backends and too big on others (like older versions of OpenGL ES). The former would stop glpyhs from rendering when they got sufficiently large or numerous. The latter would cause errors on texture allocation.

The full fix is tracked in https://github.com/flutter/flutter/issues/133092
2023-09-18 22:37:57 +00:00
skia-flutter-autoroll
36b57aebce Roll Fuchsia Mac SDK from 3_Lh8otTpmVuf-Zwb... to qy5FU4y6sx1FscCpd... (flutter/engine#45998)
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/fuchsia-mac-sdk-flutter-engine
Please CC bdero@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2023-09-18 22:34:31 +00:00
Chris Bracken
0a532593f1 Revert "[Windows] Update vsync on raster thread (#45310)" (flutter/engine#46000)
This also reverts the ANGLE roll (for which the original fix was landed) to 48e2c605adcd5bcc1622b18f357c7a73ebfb3543.

fixes: https://github.com/flutter/flutter/issues/134262

This reverts commit 2bec12f0b4d76d9f60d55d057e16cd2788083ade.

[C++, Objective-C, Java style guides]: https://github.com/flutter/engine/blob/main/CONTRIBUTING.md#style
2023-09-18 22:34:29 +00:00
Matan Lurey
8af3ec1fb9 Provide a default --target-variant for clang_tidy. (flutter/engine#45909)
Using `engine_repo_tools`, provide a default `--target-variant` for the `clang_tidy` tool.

Mostly test code added below, the major change is that `--target-variant` now has a default other than `host_debug` if we're running inside of an engine root (which we ~always are). I didn't make any other changes (i.e. to the pre-commit hook) to keep this change smallish.

Also rewrote the `README.md` to represent the current state as best I could.
2023-09-18 22:34:27 +00:00
Chris Yang
c27c8aaa15 Revert "[ios] use python script to generate extension safe frameworks and code sign them" (flutter/engine#46004)
Reverts flutter/engine#45781

Issue with engine roll https://github.com/flutter/flutter/pull/134964.
We need to update the conductor and performa manual roll.
We also need to remove the Flutter.framework from the artifact.zip
2023-09-18 22:09:33 +00:00
John McCutchan
c74acc92aa Disable HardwareBuffer backed Platform Views temporarily (flutter/engine#45986)
Necessary to unblock the GPay release
2023-09-18 12:36:16 -07:00
John McCutchan
4081d7d574 Tighten up ImageReaderPlatformViewRenderTarget code (flutter/engine#45889)
- Fix a missing Image close in an error path.
- Ensure we close the Image when the TextureEntry is finalized.
- Fix an inconsistency in the maxImages when running on Android < 33.
- Wrap acquireLatestImage in a try block and return a null image instead
of crashing the application.
2023-09-18 12:34:10 -07:00
Chris Yang
969d5e0d18 [ios] use python script to generate extension safe frameworks and code sign them (flutter/engine#45781)
Generates the fat framework for extension safe variants and add them to the code sign list.

Also reverts part of https://github.com/flutter/engine/pull/45664 where the variants are uploaded in separate archive. Now with this change, the extension safe is inside a "extension_safe" folder under existing archive. 

fixes https://github.com/flutter/flutter/issues/124291

The destination folder after this change:
- An extension_safe folder is added, which includes the extension safe Flutter.frameworks and dsym
- The artifacts.zip now includes the `extension_safe` except the dysm
- A extension_safe_Flutter.dsym.zip is created (under ios/release/) , which includes the extension_safe/Flutter.dsym

<img width="508" alt="Screenshot 2023-09-13 at 3 26 23 PM" src="https://github.com/flutter/engine/assets/3756895/84901ef1-af89-413f-94c7-74ed0aa36da6">

[C++, Objective-C, Java style guides]: https://github.com/flutter/engine/blob/main/CONTRIBUTING.md#style
2023-09-18 18:02:54 +00:00
Brandon DeRosier
5dca938aa9 Bump impeller-cmake to HEAD. (flutter/engine#45953)
Weekly bump.
2023-09-18 10:38:47 -07:00
LongCatIsLooong
5b716552a7 [iOS] Remove selectionDidChange call in UndoManager (flutter/engine#45657)
Fixes https://github.com/flutter/flutter/issues/133424

The `-[TextInputDelegate selectionDidChange:]` call actually triggers some unwanted keyboard NLP actions that generate a bunch of candidates and automatically accept the first candidate. This causes `-[UITextInput setMarkedText:selection]` to be called with the first candidate and that inserts extraneous characters after the user types certain characters on the iPad software keyboard.

[C++, Objective-C, Java style guides]: https://github.com/flutter/engine/blob/main/CONTRIBUTING.md#style
2023-09-18 17:18:57 +00:00
skia-flutter-autoroll
c15e1176e9 Roll Skia from f8065ca00d0c to 0c990ab9e097 (7 revisions) (flutter/engine#45979)
https://skia.googlesource.com/skia.git/+log/f8065ca00d0c..0c990ab9e097

2023-09-18 skia-autoroll@skia-public.iam.gserviceaccount.com Manual roll Dawn from d00d8da6f58d to 02233e019c4e (69 revisions)
2023-09-18 robertphillips@google.com [graphite] Implement AddBlendModeColorFilter with the Blend helper
2023-09-18 skia-autoroll@skia-public.iam.gserviceaccount.com Manual roll vulkan-deps from dc9947ad4d2b to 53e6e021f9b7 (2 revisions)
2023-09-18 kjlubick@google.com Avoid direct call from SkPictureData -> Slug
2023-09-18 johnstiles@google.com Disable test PixelLocalStorage.sksl temporarily.
2023-09-18 skia-autoroll@skia-public.iam.gserviceaccount.com Roll skottie-base from 3d8e63c59919 to ac643e8ecce3
2023-09-18 kjlubick@google.com Remove shim includes

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC bdero@google.com,brianosman@google.com,rmistry@google.com,tdenniston@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2023-09-18 15:44:50 +00:00
Mouad Debbar
b470cd2ab1 [web] ScreenOrientation singleton (flutter/engine#45304)
One more piece moving out of `FlutterViewEmbedder`.

`ScreenOrientation` is a singleton class that can be used to control the screen orientation of the browser.

Part of https://github.com/flutter/flutter/issues/134443
2023-09-18 15:43:08 +00:00
Mouad Debbar
3ef852f5de [web] De-singletonize MouseCursor for multi-view (flutter/engine#45295)
`MouseCursor` is a singleton that works by accessing `flutterViewEmbedder` directly. After this PR, `MouseCursor` becomes a non-singleton that takes a `FlutterView` and controls the mouse cursor for said view.

Part of https://github.com/flutter/flutter/issues/134443
2023-09-18 15:35:58 +00:00
skia-flutter-autoroll
cbfdb15c31 Roll Dart SDK from 5c56e0f3fe13 to 5b0e7bda1379 (1 revision) (flutter/engine#45974)
https://dart.googlesource.com/sdk.git/+log/5c56e0f3fe13..5b0e7bda1379

2023-09-18 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com Version 3.2.0-174.0.dev

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/dart-sdk-flutter-engine
Please CC bdero@google.com,dart-vm-team@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter Engine: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2023-09-18 13:24:32 +00:00
skia-flutter-autoroll
e0cca37d5e Roll Dart SDK from 5eef4301567f to 5c56e0f3fe13 (1 revision) (flutter/engine#45966)
https://dart.googlesource.com/sdk.git/+log/5eef4301567f..5c56e0f3fe13

2023-09-18 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com Version 3.2.0-173.0.dev

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/dart-sdk-flutter-engine
Please CC bdero@google.com,dart-vm-team@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter Engine: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2023-09-18 09:20:56 +00:00
skia-flutter-autoroll
8ee38ff1e4 Roll Fuchsia Mac SDK from 2TJNsB32jPioIfFao... to 3_Lh8otTpmVuf-Zwb... (flutter/engine#45963)
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/fuchsia-mac-sdk-flutter-engine
Please CC bdero@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2023-09-18 08:31:22 +00:00
skia-flutter-autoroll
bb96ca3542 Roll Skia from eac827d9eed3 to f8065ca00d0c (2 revisions) (flutter/engine#45962)
https://skia.googlesource.com/skia.git/+log/eac827d9eed3..f8065ca00d0c

2023-09-18 skia-autoroll@skia-public.iam.gserviceaccount.com Roll ANGLE from b4852ef95ec1 to 22b6ca1c6191 (9 revisions)
2023-09-18 skia-autoroll@skia-public.iam.gserviceaccount.com Roll SK Tool from 6e55411b61e1 to 4dfcc029292a

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC bdero@google.com,brianosman@google.com,rmistry@google.com,tdenniston@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2023-09-18 07:13:22 +00:00
skia-flutter-autoroll
050dc329d1 Roll Skia from 0d02aa8cb640 to eac827d9eed3 (1 revision) (flutter/engine#45957)
https://skia.googlesource.com/skia.git/+log/0d02aa8cb640..eac827d9eed3

2023-09-18 skia-autoroll@skia-public.iam.gserviceaccount.com Roll Skia Infra from 18fd0925a396 to 6e55411b61e1 (4 revisions)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC bdero@google.com,brianosman@google.com,rmistry@google.com,tdenniston@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2023-09-18 05:30:25 +00:00
skia-flutter-autoroll
8f37543828 Roll Dart SDK from a0ca39c63c16 to 5eef4301567f (1 revision) (flutter/engine#45956)
https://dart.googlesource.com/sdk.git/+log/a0ca39c63c16..5eef4301567f

2023-09-18 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com Version 3.2.0-172.0.dev

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/dart-sdk-flutter-engine
Please CC bdero@google.com,dart-vm-team@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter Engine: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2023-09-18 05:22:07 +00:00
skia-flutter-autoroll
9b3f70ce49 Roll Skia from a160e7fb80db to 0d02aa8cb640 (1 revision) (flutter/engine#45952)
https://skia.googlesource.com/skia.git/+log/a160e7fb80db..0d02aa8cb640

2023-09-18 skia-autoroll@skia-public.iam.gserviceaccount.com Roll vulkan-deps from 54560bc26175 to dc9947ad4d2b (1 revision)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC bdero@google.com,brianosman@google.com,rmistry@google.com,tdenniston@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2023-09-18 04:22:17 +00:00
skia-flutter-autoroll
2ae3eac57f Roll Fuchsia Mac SDK from AjL85L6CVMEuMWPVZ... to 2TJNsB32jPioIfFao... (flutter/engine#45945)
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/fuchsia-mac-sdk-flutter-engine
Please CC bdero@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2023-09-17 19:32:22 +00:00
skia-flutter-autoroll
90d2c51003 Roll Fuchsia Mac SDK from IJXVQbD3CpkL2_ihZ... to AjL85L6CVMEuMWPVZ... (flutter/engine#45937)
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/fuchsia-mac-sdk-flutter-engine
Please CC bdero@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2023-09-17 06:52:23 +00:00
skia-flutter-autoroll
e3d3ba7cdb Roll Skia from 2eaaa5bf7dae to a160e7fb80db (1 revision) (flutter/engine#45933)
https://skia.googlesource.com/skia.git/+log/2eaaa5bf7dae..a160e7fb80db

2023-09-17 skia-autoroll@skia-public.iam.gserviceaccount.com Roll vulkan-deps from d94b7bab5be9 to 54560bc26175 (1 revision)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC bdero@google.com,brianosman@google.com,jmbetancourt@google.com,rmistry@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2023-09-17 03:58:12 +00:00
skia-flutter-autoroll
6f7325beba Roll Fuchsia Mac SDK from 3Tb9CQTTiBv1lb673... to IJXVQbD3CpkL2_ihZ... (flutter/engine#45928)
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/fuchsia-mac-sdk-flutter-engine
Please CC bdero@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2023-09-16 18:16:29 +00:00
skia-flutter-autoroll
346e6545ff Roll Skia from b33e0e6706b0 to 2eaaa5bf7dae (1 revision) (flutter/engine#45926)
https://skia.googlesource.com/skia.git/+log/b33e0e6706b0..2eaaa5bf7dae

2023-09-16 skia-autoroll@skia-public.iam.gserviceaccount.com Roll vulkan-deps from 5060b88f0c23 to d94b7bab5be9 (5 revisions)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC bdero@google.com,brianosman@google.com,jmbetancourt@google.com,rmistry@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2023-09-16 14:59:21 +00:00
skia-flutter-autoroll
9435d9c043 Roll Skia from a1f8fb54299a to b33e0e6706b0 (1 revision) (flutter/engine#45923)
https://skia.googlesource.com/skia.git/+log/a1f8fb54299a..b33e0e6706b0

2023-09-16 egdaniel@google.com Add GrDirectCotnext querey to check if the we are in a device lost state

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC bdero@google.com,brianosman@google.com,jmbetancourt@google.com,rmistry@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2023-09-16 05:42:11 +00:00
skia-flutter-autoroll
350785c260 Roll Fuchsia Mac SDK from -_edKGA5GTkDFxVgl... to 3Tb9CQTTiBv1lb673... (flutter/engine#45922)
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/fuchsia-mac-sdk-flutter-engine
Please CC bdero@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2023-09-16 05:38:03 +00:00
skia-flutter-autoroll
860eaf97de Roll Dart SDK from 029d6d73c860 to a0ca39c63c16 (1 revision) (flutter/engine#45921)
https://dart.googlesource.com/sdk.git/+log/029d6d73c860..a0ca39c63c16

2023-09-16 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com Version 3.2.0-171.0.dev

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/dart-sdk-flutter-engine
Please CC bdero@google.com,dart-vm-team@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter Engine: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2023-09-16 05:31:47 +00:00
Matan Lurey
6b489a6193 [Impeller] vk::CommandPool resets via ResourceManager (flutter/engine#45654)
Fixes https://github.com/flutter/flutter/issues/133198.

Major changes:

- `CommandPoolVK` is now created indirectly through `CommandPoolRecyclerVK`.
- Via destructor, `CommandPoolVK` resets on a background thread via `ResourceManager`.
- Removed all of the code trying to reuse/reset individual command buffers (no longer needed).
- After every frame, the current/active command pool is recycled.

---

_Tests secured._
2023-09-16 04:20:21 +00:00
skia-flutter-autoroll
8a87d088b7 Roll Fuchsia Linux SDK from wWzXsy6kx1sp8Km34... to ZhY53WD7bFJSA3xoO... (flutter/engine#45919)
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/fuchsia-linux-sdk-flutter-engine
Please CC bdero@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2023-09-16 04:12:10 +00:00
Matan Lurey
5e0a53255f Add a single MacOS+Vulkan+SwiftShader CI test (flutter/engine#45918)
Closes https://github.com/flutter/flutter/issues/133708.

Will track why it's (a) blank and (b) times out in async presentation in https://github.com/flutter/flutter/issues/134852.
2023-09-16 03:55:06 +00:00
skia-flutter-autoroll
64f6d56862 Roll Skia from 696ac041ea82 to a1f8fb54299a (1 revision) (flutter/engine#45917)
https://skia.googlesource.com/skia.git/+log/696ac041ea82..a1f8fb54299a

2023-09-16 johnstiles@google.com Fix Vulkan depth format flags for VK_FORMAT_D32_SFLOAT_S8_UINT.

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC bdero@google.com,brianosman@google.com,jmbetancourt@google.com,rmistry@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2023-09-16 03:46:49 +00:00
skia-flutter-autoroll
2081fa7754 Roll Skia from 4851cd29e1dd to 696ac041ea82 (1 revision) (flutter/engine#45915)
https://skia.googlesource.com/skia.git/+log/4851cd29e1dd..696ac041ea82

2023-09-16 michaelludwig@google.com [graphite] Add TRACE_EVENTS throughout

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC bdero@google.com,brianosman@google.com,jmbetancourt@google.com,rmistry@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2023-09-16 03:02:07 +00:00
skia-flutter-autoroll
13a99ca01f Roll Skia from c19cc483c619 to 4851cd29e1dd (1 revision) (flutter/engine#45913)
https://skia.googlesource.com/skia.git/+log/c19cc483c619..4851cd29e1dd

2023-09-16 skia-autoroll@skia-public.iam.gserviceaccount.com Roll vulkan-deps from 1ab98511aaae to 5060b88f0c23 (5 revisions)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC bdero@google.com,brianosman@google.com,jmbetancourt@google.com,rmistry@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2023-09-16 02:11:23 +00:00
skia-flutter-autoroll
d34c38ffdb Roll Dart SDK from e9452310189b to 029d6d73c860 (1 revision) (flutter/engine#45912)
https://dart.googlesource.com/sdk.git/+log/e9452310189b..029d6d73c860

2023-09-16 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com Version 3.2.0-170.0.dev

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/dart-sdk-flutter-engine
Please CC bdero@google.com,dart-vm-team@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter Engine: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2023-09-16 01:27:36 +00:00
Jonah Williams
83f48da122 Revert "[Impeller] construct text frames on UI thread." (flutter/engine#45910)
Reverts flutter/engine#45418

Some google3 tests are hitting the CHECK I added in the DlSkCanvasDispatcher::drawTextFrame, which indicates that the SkParagraph code likely thinks impeller is enabled, whereas other code might be running with Skia.

Perhaps this could happen if its software rendering? It should be a fatal error on startup so we can track this down.
2023-09-16 01:22:13 +00:00
skia-flutter-autoroll
080410ad70 Roll Skia from 7c179932cc06 to c19cc483c619 (1 revision) (flutter/engine#45911)
https://skia.googlesource.com/skia.git/+log/7c179932cc06..c19cc483c619

2023-09-16 michaelludwig@google.com Update SetTraceValue() to use a template, remove bitpun union

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC bdero@google.com,brianosman@google.com,jmbetancourt@google.com,rmistry@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2023-09-16 01:20:11 +00:00