LongCatIsLooong
e59543708d
iOS UITextInput autocorrection prompt ( #13959 )
2020-04-07 14:45:59 -07:00
George Wright
1a0932860b
Roll fuchsia/sdk/core/linux-amd64 from 3yOjK... to VzWN4... ( #17569 )
2020-04-07 14:41:01 -07:00
stuartmorgan
5b4b1f33c6
Reland "Improve C++ plugin lifetime handling" ( #17570 )
...
Relands #17489 with a fix for the unit test flake.
The previous unit test relied on the new instance not being created at the same memory address, which isn't guaranteed.
2020-04-07 14:11:56 -07:00
gaaclarke
8f6590cbbc
Added "unrecognized-selector" errors to match g3 builds ( #17566 )
...
Added "unrecognized-selector" errors to match g3 builds, added
"overriding-method-mismatch" to catch a common error.
2020-04-07 13:28:42 -07:00
stuartmorgan
fd10734e50
Fix flutter_windows_unittests runtime dependency ( #17524 )
...
The transitive dependency on the embedder library brings in the right
runtime for the build mode, so directly depending on the JIT version
isn't necessary, and causes duplicate symbol issues in release builds.
2020-04-07 13:19:49 -07:00
Nurhan Turgut
394ac6b484
[web] fix clipboard.getData ( #17544 )
...
* remove the fake reply for paste message. the clipboard.dart will reply with the content of the clipboard
* also remove the fake answer for copy
2020-04-07 11:34:33 -07:00
Ryoichi Izumita
ac574e11a0
Fixed a bug that left a blank at the bottom of the screen ( #17474 )
...
I fixed a bug that left a blank at the bottom of the screen when the iPad's split keyboard was hidden.
I also had the same problem with this issue, so I fixed it.
iPad split keyboard cause a blank space problem
There is no function to change the space size at the bottom of the screen when the split keyboard is moved. This is because it's not clear what the keyboard should do when it's moved to the top of the screen.
2020-04-07 11:27:15 -07:00
Jason Simmons
3190d54a69
Add the Android SDK lambda stub library to the classpath ( #17508 )
...
Previously the build scripts obtained the lambda support classes from rt.jar,
which is no longer provided by recent versions of the JDK.
2020-04-07 11:24:52 -07:00
chunhtai
e2fcc66fc6
always forward move event ( #17541 )
...
flutter/flutter#54022
The original issue is the _MotionEventsDispatcher depends on all down pointers to send out their own move events. If the third pointer has the movement of zero, it will get filter out by the PointerDataPacketConverter. This result with only two pointer move events been sent to RenderAndroidView, and they both get ignored because it is waiting for the third one.
This pr fixes it by always forward the move event
2020-04-07 11:24:11 -07:00
skia-flutter-autoroll
47c607a0f1
Roll src/third_party/dart 275a76f2fcd8..dcdc71d7639a (31 commits) ( #17562 )
...
https://dart.googlesource.com/sdk.git/+log/275a76f2fcd8..dcdc71d7639a
git log 275a76f2fcd8..dcdc71d7639a --date=short --first-parent --format='%ad %ae %s'
2020-04-07 scheglov@google.com Report CONFLICTING_GENERIC_INTERFACES using ClassHierarchy.
2020-04-07 eernst@google.com Adjust member signature expectations for mixed inheritance
2020-04-07 kustermann@google.com [vm/compiler] Move runtime call of Throw/ReThrow/AssertBoolean/InstanceOf out into a Stub
2020-04-07 cskau@google.com [Compiler] Adds a set of generic AllocateObject stubs.
2020-04-07 scheglov@google.com Update constants_2018/constant_types_test to allow type parameters in 'as'.
2020-04-07 alexmarkov@google.com [vm/tests] Speed up / filter slow vm/dart/minimal_kernel*_test
2020-04-07 leafp@google.com Add tests for extended GLB.
2020-04-07 sra@google.com [dart2js] createFromStaticType for LegacyType
2020-04-07 rnystrom@google.com Migrate language_2/covariant to NNBD.
2020-04-07 srujzs@google.com [dart:html] Fix named args in js_typed_interop tests
2020-04-06 rnystrom@google.com Migrate language_2/constants_2018 to NNBD.
2020-04-06 scheglov@google.com Update language/constructor/return_test
2020-04-06 scheglov@google.com Update ClassHierarchy for legacy support, record errors.
2020-04-06 rmacnak@google.com Revert "[vm, gc] Parallel scavenge."
2020-04-06 srujzs@google.com [dart:html] Add nullability to item type for lists
2020-04-06 srujzs@google.com [dart:html] Remove 2.7 annotation from lib/html
2020-04-06 srujzs@google.com [dart:html] Migrate tests with only null asserts
2020-04-06 srujzs@google.com [dart:html] Migrate tests that need changes to NNBD
2020-04-06 srujzs@google.com [dart:html] Migrate more js tests to NNBD
2020-04-06 srujzs@google.com [dart:html] Migrate html tests with dynamic list conversions
2020-04-06 srujzs@google.com [dart:html] Migrate htmlcollection_test to null-safe
2020-04-06 rmacnak@google.com [vm, gc] Parallel scavenge.
2020-04-06 jwren@google.com Update the completion_metrics.dart algorithm to have 2 overlay options
2020-04-06 scheglov@google.com Clear class hierarchies to reduce memory consumption.
2020-04-06 rileyporter@google.com [tests] Removing more List constructor usage in corelib tests.
2020-04-06 liama@google.com [vm] Fix bug in late field reloading
2020-04-06 mfairhurst@google.com [nnbd_migration] Add sanity checks before writing to disk.
2020-04-06 mfairhurst@google.com [nnbd_migration] Change edit links to buttons.
2020-04-06 mehmetf@google.com Reland "[dart:_http] Allow the embedder to prohibit HTTP traffic."
2020-04-06 rmacnak@google.com [vm] Include the handler function in HandleMessage timeline events.
2020-04-06 scheglov@google.com Allow potentially constant type expression in 'as'.
Created with:
gclient setdep -r src/third_party/dart@dcdc71d7639a
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/dart-sdk-flutter-engine
Please CC dart-vm-team@google.com on the revert to ensure that a human
is aware of the problem.
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md
Bug: None
Tbr: dart-vm-team@google.com
2020-04-07 11:23:23 -07:00
Chris Bracken
b2cc00f078
Revert "Added errors to match g3 builds and simple errors ( #17536 )" ( #17564 )
...
Test failure:
[ RUN ] FlutterStringCodec.CanEncodeAndDecodeNil
2020-04-07 10:21:25.091 flutter_channels_unittests[26965:163315] *** Assertion failure in -[FlutterStringCodec encode:], ../../flutter/shell/platform/darwin/common/framework/Source/FlutterCodecs.mm:36
2020-04-07 10:21:25.118 flutter_channels_unittests[26965:163315] *** Terminating app due to uncaught exception 'NSInternalInconsistencyException', reason: ''
*** First throw call stack:
(
0 CoreFoundation 0x00007fff2ccabcf9 __exceptionPreprocess + 256
1 libobjc.A.dylib 0x00007fff5785ea17 objc_exception_throw + 48
2 CoreFoundation 0x00007fff2ccc6a16 +[NSException raise:format:arguments:] + 98
3 Foundation 0x00007fff2ef58e11 -[NSAssertionHandler handleFailureInMethod:object:file:lineNumber:description:] + 194
4 flutter_channels_unittests 0x0000000105f1cce2 -[FlutterStringCodec encode:] + 290
5 flutter_channels_unittests 0x0000000105f01bbb _ZN45FlutterStringCodec_CanEncodeAndDecodeNil_Test8TestBodyEv + 107
6 flutter_channels_unittests 0x00000001081d1732 _ZN7testing8internal38HandleSehExceptionsInMethodIfSupportedINS_4TestEvEET0_PT_MS4_FS3_vEPKc + 146
7 flutter_channels_unittests 0x00000001081a76b0 _ZN7testing8internal35HandleExceptionsInMethodIfSupportedINS_4TestEvEET0_PT_MS4_FS3_vEPKc + 128
8 flutter_channels_unittests 0x00000001081a75c1 _ZN7testing4Test3RunEv + 209
9 flutter_channels_unittests 0x00000001081a8415 _ZN7testing8TestInfo3RunEv + 229
10 flutter_channels_unittests 0x00000001081a95aa _ZN7testing9TestSuite3RunEv + 266
11 flutter_channels_unittests 0x00000001081b4e43 _ZN7testing8internal12UnitTestImpl11RunAllTestsEv + 995
12 flutter_channels_unittests 0x00000001081d8572 _ZN7testing8internal38HandleSehExceptionsInMethodIfSupportedINS0_12UnitTestImplEbEET0_PT_MS4_FS3_vEPKc + 146
13 flutter_channels_unittests 0x00000001081b49b3 _ZN7testing8internal35HandleExceptionsInMethodIfSupportedINS0_12UnitTestImplEbEET0_PT_MS4_FS3_vEPKc + 131
14 flutter_channels_unittests 0x00000001081b4835 _ZN7testing8UnitTest3RunEv + 197
15 flutter_channels_unittests 0x0000000105f22e73 _Z13RUN_ALL_TESTSv + 35
16 flutter_channels_unittests 0x0000000105f22d79 main + 553
17 libdyld.dylib 0x00007fff5908c3d5 start + 1
)
libc++abi.dylib: terminating with uncaught exception of type NSException
[ERROR:flutter/fml/backtrace.cc(110)] Caught signal SIGABRT during program execution.
Frame 0: 0x7fff591316a6 abort
Frame 1: 0x7fff560ea641 __cxa_bad_cast
Frame 2: 0x7fff560ea7df default_unexpected_handler()�
Frame 3: 0x7fff57860ee3 _objc_terminate()�
Frame 4: 0x7fff560f619e std::__terminate(void (*)())�
Frame 5: 0x7fff560f5f86 __cxa_get_exception_ptr
Frame 6: 0x7fff560e8f99 __cxa_get_globals
Frame 7: 0x7fff5785eb51 objc_exception_throw
Frame 8: 0x7fff2ccc6a16 +[NSException raise:format:arguments:]
Frame 9: 0x7fff2ef58e11 -[NSAssertionHandler handleFailureInMethod:object:file:lineNumber:description:]
Frame 10: 0x105f1cce2 -[FlutterStringCodec encode:]
Frame 11: 0x105f01bbb FlutterStringCodec_CanEncodeAndDecodeNil_Test::TestBody()�
Frame 12: 0x1081d1732 void testing::internal::HandleSehExceptionsInMethodIfSupported<testing::Test, void>(testing::Test*, void (testing::Test::*)(), char const*)�
Frame 13: 0x1081a76b0 void testing::internal::HandleExceptionsInMethodIfSupported<testing::Test, void>(testing::Test*, void (testing::Test::*)(), char const*)�
Frame 14: 0x1081a75c1 testing::Test::Run()�
Frame 15: 0x1081a8415 testing::TestInfo::Run()�
Frame 16: 0x1081a95aa testing::TestSuite::Run()�
Frame 17: 0x1081b4e43 testing::internal::UnitTestImpl::RunAllTests()�
Frame 18: 0x1081d8572 bool testing::internal::HandleSehExceptionsInMethodIfSupported<testing::internal::UnitTestImpl, bool>(testing::internal::UnitTestImpl*, bool (testing::internal::UnitTestImpl::*)(), char const*)�
Frame 19: 0x1081b49b3 bool testing::internal::HandleExceptionsInMethodIfSupported<testing::internal::UnitTestImpl, bool>(testing::internal::UnitTestImpl*, bool (testing::internal::UnitTestImpl::*)(), char const*)�
Frame 20: 0x1081b4835 testing::UnitTest::Run()�
Frame 21: 0x105f22e73 RUN_ALL_TESTS()�
Frame 22: 0x105f22d79 main
Frame 23: 0x7fff5908c3d5 start
This reverts commit d1c90b4284282f9745ecd7c65aa72c612df671c1.
2020-04-07 10:32:38 -07:00
Chris Bracken
098761f76d
Revert "Improve C++ plugin lifetime handling ( #17489 )" ( #17563 )
...
Seems to have triggered flaky failures on the Windows bot since landing.
Example failure:
[ RUN ] PluginRegistrarTest.ManagerRemovesOnDestruction
c:\b\s\w\ir\cache\builder\src\flutter\shell\platform\common\cpp\client_wrapper\plugin_registrar_unittests.cc(149): error: Expected: (manager->GetRegistrar<PluginRegistrar>(dummy_registrar_handle)) != (first_wrapper), actual: 000002400A90E3D0 vs 000002400A90E3D0
This reverts commit faf44fed5a5913dcbeebd7ead8e3933a5e72a6fc.
2020-04-07 10:22:55 -07:00
gaaclarke
d1c90b4284
Added errors to match g3 builds and simple errors ( #17536 )
...
"unrecognized-selector" and "overriding-method-mismatch" added as errors.
2020-04-07 10:03:49 -07:00
skia-flutter-autoroll
47f17a9ec3
Roll src/third_party/dart 1210d27678a0..275a76f2fcd8 (4 commits) ( #17531 )
2020-04-06 15:16:03 -07:00
skia-flutter-autoroll
49891e0653
Roll src/third_party/skia 04513752fd6e..3ef77ddf9ec4 (3 commits) ( #17530 )
2020-04-06 15:11:03 -07:00
Amir Hardon
2fab00eb83
Fix AlertDialogs built by platform views ( #17511 )
2020-04-06 15:06:07 -07:00
Mouad Debbar
bd760768c8
[web] Detect when the mouseup occurs outside of window ( #17495 )
2020-04-06 15:06:03 -07:00
gaaclarke
ba615d5269
Added missing declaration (only showed up in g3 builds). ( #17535 )
2020-04-06 15:02:47 -07:00
Kaushik Iska
ab434c5540
Revert "[tools][fuchsia] Do not tar debug symbol CIPD uploads ( #17506 )" ( #17537 )
...
This reverts commit 4b69cf2c49db43ec89bb5004d1f4b767194c4fea.
2020-04-06 14:15:40 -07:00
gaaclarke
19a7fbf02f
Fixed nullability in plugin header and overridden type mismatch error. ( #17532 )
2020-04-06 13:23:00 -07:00
Joshua Seaton
4b69cf2c49
[tools][fuchsia] Do not tar debug symbol CIPD uploads ( #17506 )
...
Fuchsia is the main consumer of these CIPD packages and - to simplify
its infrastructure - it is migrating its SDK partners over to producing
a CIPD package containing a flat .build-id directory.
This change also updates the CIPD package so that the .build-id
directory is placed at the root.
Bug: fxbug.dev/41443
2020-04-06 10:04:54 -07:00
stuartmorgan
faf44fed5a
Improve C++ plugin lifetime handling ( #17489 )
...
This makes two changes:
- Adds a way to register a callback for when a FlutterDesktopPluginRegistrarRef is destroyed, and implements the logic to call it in the Windows and Linux embeddings.
- Adds a class to the C++ wrapper that handles making a singleton owning PluginRegistrar wrappers, and destroying them when the underlying reference goes away, to avoid needing that boilerplate code in every plugin's source.
Fixes https://github.com/flutter/flutter/issues/53496
2020-04-06 09:55:42 -07:00
skia-flutter-autoroll
0945635661
Roll src/third_party/skia cc8a76f3c763..04513752fd6e (22 commits) ( #17529 )
2020-04-06 09:11:02 -07:00
skia-flutter-autoroll
df257e59c2
Roll src/third_party/dart a8251f820b09..1210d27678a0 (5 commits) ( #17528 )
2020-04-06 09:06:04 -07:00
skia-flutter-autoroll
dabda2c66e
Roll fuchsia/sdk/core/mac-amd64 from LDdBU... to wZ5qZ... ( #17527 )
2020-04-06 04:36:02 -07:00
skia-flutter-autoroll
03bbd7c810
Roll src/third_party/dart 05103dfe5a0e..a8251f820b09 (4 commits) ( #17526 )
2020-04-06 00:36:01 -07:00
skia-flutter-autoroll
fd2f0d290e
Roll fuchsia/sdk/core/linux-amd64 from Ezm2f... to 3yOjK... ( #17525 )
2020-04-06 00:16:01 -07:00
skia-flutter-autoroll
9b8dcc7ecf
Roll src/third_party/dart 987ad1d96748..05103dfe5a0e (2 commits) ( #17522 )
2020-04-05 18:31:03 -07:00
skia-flutter-autoroll
6e4817f09c
Roll fuchsia/sdk/core/mac-amd64 from 6CeXq... to LDdBU... ( #17521 )
2020-04-05 14:16:02 -07:00
skia-flutter-autoroll
f1f7d5db59
Roll src/third_party/dart a7f1a5e677e5..987ad1d96748 (1 commits) ( #17520 )
2020-04-05 12:16:02 -07:00
skia-flutter-autoroll
bd725935ec
Roll fuchsia/sdk/core/linux-amd64 from hUO_b... to Ezm2f... ( #17519 )
2020-04-05 04:06:02 -07:00
skia-flutter-autoroll
ec6e8f4a00
Roll src/third_party/dart 80ae6ed91d6d..a7f1a5e677e5 (1 commits) ( #17518 )
2020-04-05 01:26:02 -07:00
skia-flutter-autoroll
2cc6a6d66d
Roll fuchsia/sdk/core/mac-amd64 from BHVYY... to 6CeXq... ( #17516 )
2020-04-04 23:31:01 -07:00
skia-flutter-autoroll
cb6fc30534
Roll src/third_party/dart 28eb884d4709..80ae6ed91d6d (2 commits) ( #17515 )
2020-04-04 10:41:03 -07:00
skia-flutter-autoroll
4072be436a
Roll fuchsia/sdk/core/linux-amd64 from TWx2R... to hUO_b... ( #17514 )
2020-04-04 04:46:01 -07:00
skia-flutter-autoroll
260683e567
Roll src/third_party/dart 1e4a56ee7202..28eb884d4709 (1 commits) ( #17513 )
2020-04-04 03:56:02 -07:00
skia-flutter-autoroll
53cf74ea91
Roll fuchsia/sdk/core/mac-amd64 from tKvUB... to BHVYY... ( #17512 )
2020-04-04 02:26:02 -07:00
skia-flutter-autoroll
fdbc21d2b5
Roll src/third_party/dart f144d5fdca56..1e4a56ee7202 (20 commits) ( #17510 )
2020-04-03 22:26:03 -07:00
gaaclarke
bac37de43d
refactor: split up accessibility bridge and semantics object ( #17507 )
2020-04-03 16:54:33 -07:00
skia-flutter-autoroll
d5a9e77adf
Roll src/third_party/dart e736495eb7f0..f144d5fdca56 (31 commits) ( #17503 )
2020-04-03 16:16:02 -07:00
skia-flutter-autoroll
a93382fe22
Roll src/third_party/skia e70e0c055f56..cc8a76f3c763 (23 commits) ( #17504 )
2020-04-03 15:51:02 -07:00
gaaclarke
4cfbe45033
Started clearing out the parent of orphaned semantic objects. ( #17499 )
2020-04-03 14:35:48 -07:00
xster
d5e7b807be
onRequestPermissionsResult now require calling super on AndroidX master ( #17305 )
2020-04-03 13:03:26 -07:00
xster
09bc1fc45e
Small updates to objcdocs ( #17151 )
2020-04-03 13:03:06 -07:00
Jason Simmons
983d1e1703
Fix include paths of fml/time headers in the shell and rasterizer ( #17502 )
2020-04-03 12:33:54 -07:00
skia-flutter-autoroll
fa09075127
Roll fuchsia/sdk/core/linux-amd64 from -jFTb... to TWx2R... ( #17498 )
2020-04-03 12:01:02 -07:00
skia-flutter-autoroll
a9c6222cdc
Roll fuchsia/sdk/core/mac-amd64 from 6V5BR... to tKvUB... ( #17497 )
2020-04-03 11:56:06 -07:00
skia-flutter-autoroll
e2b86556be
Roll src/third_party/skia 8efbbbc0d1d4..e70e0c055f56 (1 commits) ( #17496 )
2020-04-03 11:51:05 -07:00
Chris Bracken
e55b4476f1
Use const refs in for loops where reasonable ( #17484 )
...
This patch optimizes C++11 range-based for loops where the variable is
copied in each iteration but it would suffice to obtain it by const
reference. This is only applied to loop variables of types that are
expensive to copy which means they are not trivially copyable or have a
non-trivial copy constructor or destructor.
To ensure that it is safe to replace the copy with a const reference
only the following cases are modified:
* The loop variable is const-qualified.
* The loop variable is not const, but only const methods or operators
are invoked on it, or it is used as const reference or value argument
in constructors or function calls.
This is an application of the internal performance-for-range-copy
clang-tidy analysis.
2020-04-03 11:44:35 -07:00
Chris Bracken
83e493ae62
Revert "[tools][fuchsia] Do not tar debug symbol CIPD uploads ( #17275 )" ( #17501 )
...
Breaks CIPD package creation on Fuchsia.
Example error message:
Directory: /b/s/w/ir/k/recipe_cleanup/tmp9x3dHw is not empty, deleting it.
Traceback (most recent call last):
File "/b/s/w/ir/cache/builder/src/flutter/tools/fuchsia/merge_and_upload_debug_symbols.py", line 140, in <module>
sys.exit(main())
File "/b/s/w/ir/cache/builder/src/flutter/tools/fuchsia/merge_and_upload_debug_symbols.py", line 131, in main
HardlinkContents(symbol_dir, out_dir)
File "/b/s/w/ir/cache/builder/src/flutter/tools/fuchsia/merge_and_upload_debug_symbols.py", line 83, in HardlinkContents
os.makedirs(dest_dir)
File "/b/s/w/ir/cache/vpython/9f7888/lib/python2.7/os.py", line 157, in makedirs
mkdir(name, mode)
OSError: [Errno 17] File exists: '/b/s/w/ir/k/recipe_cleanup/tmp9x3dHw/.'
This reverts commit 03d5e500037fb091c9f044a067fca84466a191e5.
2020-04-03 11:00:57 -07:00