DEV/flutter_flutter
1
0
Fork 0
mirror of https://github.com/flutter/flutter.git synced 2026-02-20 02:29:02 +08:00
Code Issues Packages Projects Releases Wiki Activity
32,860 Commits 882 Branches 1,069 Tags
Commit Graph

32860 Commits

This Branch
This Branch
All Branches
Author SHA1 Message Date
skia-flutter-autoroll
d9dcf0228b Roll Fuchsia Linux SDK from LnToEykA8o68jv58K... to Q3HcTitDF90ZOPWDa... (flutter/engine#48244) 
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/fuchsia-linux-sdk-flutter-engine
Please CC jonahwilliams@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2023-11-20 22:12:50 +00:00
skia-flutter-autoroll
a6a706cdad Roll Skia from 2bcc2e8682a6 to c9943f14039f (1 revision) (flutter/engine#48243) 
https://skia.googlesource.com/skia.git/+log/2bcc2e8682a6..c9943f14039f

2023-11-20 brianosman@google.com Fix numerous cases of casting away const

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC brianosman@google.com,jamesgk@google.com,jonahwilliams@google.com,rmistry@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2023-11-20 21:46:29 +00:00
Matan Lurey
fcd9c27649 Make vulkan/... compatible with .clang_tidy. (flutter/engine#48240) 
Missed this straggler in a previous PR. Ezpz.
 2023-11-20 21:30:07 +00:00
Matan Lurey
7cc1f2f98c [Impeller] Write a text-decoration test at the dart:ui layer (flutter/engine#48101) 
Closes https://github.com/flutter/flutter/issues/138501.

---

It would be nice to turn this into a test-fixture, and create a better local environment.

Here is how to run it locally:

```bash
# The test expects you to be PWD in the `src` directory or it crashes.
cd $ENGINE_SRC

out/host_debug_unopt_arm64/flutter_tester \
  --force-multithreading \
  --disable-observatory \
  --use-test-fonts \
  --icu-data-file-path=out/host_debug_unopt_arm64/icudtl.dat \
  --flutter-assets-dir=out/host_debug_unopt_arm64/gen/flutter/lib/ui/assets \
  --disable-asset-fonts \
  --enable-impeller \
  out/host_debug_unopt_arm64/gen/canvas_test.dart.dill

# "See" the output goldens.
open out/host_debug_unopt_arm64/gen/skia_gold_canvas_test.dart
```

![image](https://github.com/flutter/engine/assets/168174/3deeab8d-409d-4b2e-8bdf-1cae272636f8)
 2023-11-20 21:07:05 +00:00
skia-flutter-autoroll
fc50f4cca5 Roll Skia from 69213ba6f68a to 2bcc2e8682a6 (1 revision) (flutter/engine#48238) 
https://skia.googlesource.com/skia.git/+log/69213ba6f68a..2bcc2e8682a6

2023-11-20 kjlubick@google.com Re-enable legacy SkFontMgr factory for Android

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC brianosman@google.com,jamesgk@google.com,jonahwilliams@google.com,rmistry@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2023-11-20 20:44:16 +00:00
Reid Baker
6f6ca74b5e Protect sdk upload script from missing ndk, add documentation for checking write access, improve comments to add context (flutter/engine#47989) 
Script used to upload 34v7 with ndk 26.1.10909125 
Added documentation for how to check for write access before running script. 
Added documentation for why the ndk is in a non standard location. 
Protected against silent ndk failure caused by a failure to download ndk on m1 macs https://github.com/flutter/engine/pull/47609#issuecomment-1800207937
Clean up os override so that script does not dirty the environment variables in a shell where it is run.  

See https://github.com/flutter/flutter/issues/117973 for more detail on why a newer ndk is required.
 2023-11-20 20:42:23 +00:00
skia-flutter-autoroll
41b5d9116b Roll Dart SDK from 09bd5d71062d to ee7aaca9adcc (1 revision) (flutter/engine#48237) 
https://dart.googlesource.com/sdk.git/+log/09bd5d71062d..ee7aaca9adcc

2023-11-20 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com Version 3.3.0-151.0.dev

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/dart-sdk-flutter-engine
Please CC dart-vm-team@google.com,jonahwilliams@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter Engine: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2023-11-20 20:30:00 +00:00
skia-flutter-autoroll
6d9200b4af Roll Skia from 151d297efcf5 to 69213ba6f68a (2 revisions) (flutter/engine#48236) 
https://skia.googlesource.com/skia.git/+log/151d297efcf5..69213ba6f68a

2023-11-20 lehoangquyen@chromium.org GraphiteDawn: cache single texture bind group
2023-11-20 skia-autoroll@skia-public.iam.gserviceaccount.com Roll vulkan-deps from 63bb05a5e0ad to ac8158a19e0b (1 revision)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC brianosman@google.com,jamesgk@google.com,jonahwilliams@google.com,rmistry@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2023-11-20 20:07:13 +00:00
skia-flutter-autoroll
ead9769060 Roll Skia from e9206d29ef07 to 151d297efcf5 (1 revision) (flutter/engine#48235) 
https://skia.googlesource.com/skia.git/+log/e9206d29ef07..151d297efcf5

2023-11-20 jamesgk@google.com [sksl] Support FB fetch in Dawn

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC brianosman@google.com,jamesgk@google.com,jonahwilliams@google.com,rmistry@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2023-11-20 19:23:16 +00:00
skia-flutter-autoroll
61eefd3758 Roll Skia from 795a259c2f56 to e9206d29ef07 (3 revisions) (flutter/engine#48231) 
https://skia.googlesource.com/skia.git/+log/795a259c2f56..e9206d29ef07

2023-11-20 kjlubick@google.com Extract Vulkan methods out of GrBackendSemaphore
2023-11-20 nscobie@google.com Allow SkQP to be shardable
2023-11-20 jamesgk@google.com Manual Dawn roll

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC brianosman@google.com,jamesgk@google.com,jonahwilliams@google.com,rmistry@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2023-11-20 18:29:05 +00:00
Mouad Debbar
5c93379571 [web] EngineFlutterView.dispose() (flutter/engine#48183) 
- New `EngineFlutterView.dispose()` to cleanup when the view is removed (and in hot restart).
- `EnginePlatformDispatcher.dispose()` now disposes of all of its registered views.
 2023-11-20 17:21:22 +00:00
skia-flutter-autoroll
9c7f9eabf8 Roll Skia from 64d1e14df168 to 795a259c2f56 (2 revisions) (flutter/engine#48227) 
https://skia.googlesource.com/skia.git/+log/64d1e14df168..795a259c2f56

2023-11-20 johnstiles@google.com Fix fuzzer-discovered timeout with deeply-nested structs.
2023-11-20 kjlubick@google.com Reland "Turn on SK_DISABLE_LEGACY_FONTMGR_FACTORY"

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC brianosman@google.com,jamesgk@google.com,jonahwilliams@google.com,rmistry@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2023-11-20 16:50:02 +00:00
skia-flutter-autoroll
1211f7d2e3 Roll Skia from a874e29d71c0 to 64d1e14df168 (1 revision) (flutter/engine#48225) 
https://skia.googlesource.com/skia.git/+log/a874e29d71c0..64d1e14df168

2023-11-20 kjlubick@google.com Remove SK_DISABLE_LEGACY_VK_GRDIRECTCONTEXT_FACTORIES

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC brianosman@google.com,jamesgk@google.com,jonahwilliams@google.com,rmistry@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2023-11-20 15:51:40 +00:00
skia-flutter-autoroll
bf66a69e54 Roll Dart SDK from 564cfb2cfe79 to 09bd5d71062d (1 revision) (flutter/engine#48222) 
https://dart.googlesource.com/sdk.git/+log/564cfb2cfe79..09bd5d71062d

2023-11-20 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com Version 3.3.0-150.0.dev

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/dart-sdk-flutter-engine
Please CC dart-vm-team@google.com,jonahwilliams@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter Engine: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2023-11-20 13:44:06 +00:00
Kevin Lubick
0d0d4db144 Replace calls to SkFontMgr::RefDefault (flutter/engine#48179) 
Skia is removing this API, so clients must track a default FontMgr if
they want one. See https://issues.skia.org/issues/305780908

## Pre-launch Checklist

- [x] I read the [Contributor Guide] and followed the process outlined
there for submitting PRs.
- [x] I read the [Tree Hygiene] wiki page, which explains my
responsibilities.
- [x] I read and followed the [Flutter Style Guide] and the [C++,
Objective-C, Java style guides].
- [x] I listed at least one issue that this PR fixes in the description
above.
- [x] I added new tests to check the change I am making or feature I am
adding, or the PR is [test-exempt]. See [testing the engine] for
instructions on writing and running engine tests.
- [x] I updated/added relevant documentation (doc comments with `///`).
- [x] I signed the [CLA].
- [x] All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel
on [Discord].

<!-- Links -->
[Contributor Guide]:
https://github.com/flutter/flutter/wiki/Tree-hygiene#overview
[Tree Hygiene]: https://github.com/flutter/flutter/wiki/Tree-hygiene
[test-exempt]:
https://github.com/flutter/flutter/wiki/Tree-hygiene#tests
[Flutter Style Guide]:
https://github.com/flutter/flutter/wiki/Style-guide-for-Flutter-repo
[C++, Objective-C, Java style guides]:
https://github.com/flutter/engine/blob/main/CONTRIBUTING.md#style
[testing the engine]:
https://github.com/flutter/flutter/wiki/Testing-the-engine
[CLA]: https://cla.developers.google.com/
[flutter/tests]: https://github.com/flutter/tests
[breaking change policy]:
https://github.com/flutter/flutter/wiki/Tree-hygiene#handling-breaking-changes
[Discord]: https://github.com/flutter/flutter/wiki/Chat
 2023-11-20 07:57:02 -05:00
skia-flutter-autoroll
fec11b4480 Roll Skia from 5010d0578f4d to a874e29d71c0 (1 revision) (flutter/engine#48216) 
https://skia.googlesource.com/skia.git/+log/5010d0578f4d..a874e29d71c0

2023-11-20 skia-autoroll@skia-public.iam.gserviceaccount.com Roll ANGLE from 8ae36a93bedc to 98d79260fa0e (5 revisions)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC brianosman@google.com,jamesgk@google.com,jonahwilliams@google.com,rmistry@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2023-11-20 07:27:24 +00:00
Zachary Anderson
aa3f8e61c1 Moves expat, ocmock, libjpeg-turbo, libwebp, and wuffs to //flutter/third_party (flutter/engine#48193) 
As part of eliminating the Flutter buildroot
(https://github.com/flutter/flutter/issues/67373), we are moving all
third-party dependencies from //third_party to //flutter/third_party.

Once all third-party dependencies have been migrated, tooling and config
will be moved and the buildroot will be eliminated altogether.

No tests changed because there is no semantic change to this PR. This is
simply relocating a dependency.

This PR moves expat, ocmock, libjpeg-turbo, libwebp, and wuffs to
//flutter/third_party.

It also deletes //third_party/fontconfig, which was unused.
 2023-11-19 22:53:29 -08:00
skia-flutter-autoroll
e4b3ff8afc Roll Skia from 343b249b2cac to 5010d0578f4d (1 revision) (flutter/engine#48215) 
https://skia.googlesource.com/skia.git/+log/343b249b2cac..5010d0578f4d

2023-11-20 skia-autoroll@skia-public.iam.gserviceaccount.com Roll SK Tool from 70ea436295e7 to f4a0318d3443

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC brianosman@google.com,jamesgk@google.com,jonahwilliams@google.com,rmistry@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2023-11-20 06:10:22 +00:00
skia-flutter-autoroll
40a3ca5972 Roll Skia from 0d49b661d75a to 343b249b2cac (1 revision) (flutter/engine#48214) 
https://skia.googlesource.com/skia.git/+log/0d49b661d75a..343b249b2cac

2023-11-20 skia-autoroll@skia-public.iam.gserviceaccount.com Roll vulkan-deps from 1be84b678dfe to 63bb05a5e0ad (3 revisions)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC brianosman@google.com,jamesgk@google.com,jonahwilliams@google.com,rmistry@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2023-11-20 04:54:35 +00:00
skia-flutter-autoroll
1a70c71e2e Roll Skia from 4ec239a62325 to 0d49b661d75a (1 revision) (flutter/engine#48212) 
https://skia.googlesource.com/skia.git/+log/4ec239a62325..0d49b661d75a

2023-11-19 skia-autoroll@skia-public.iam.gserviceaccount.com Roll vulkan-deps from b9ed775dbbe7 to 1be84b678dfe (1 revision)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC brianosman@google.com,jamesgk@google.com,jonahwilliams@google.com,rmistry@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2023-11-19 15:43:33 +00:00
skia-flutter-autoroll
06f3e9926a Roll Skia from f320a125e031 to 4ec239a62325 (1 revision) (flutter/engine#48210) 
https://skia.googlesource.com/skia.git/+log/f320a125e031..4ec239a62325

2023-11-19 skia-recreate-skps@skia-swarming-bots.iam.gserviceaccount.com Update SKP version

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC brianosman@google.com,jamesgk@google.com,jonahwilliams@google.com,rmistry@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2023-11-19 11:19:19 +00:00
skia-flutter-autoroll
6f54fe438c Roll Skia from b311e4d0d21e to f320a125e031 (1 revision) (flutter/engine#48208) 
https://skia.googlesource.com/skia.git/+log/b311e4d0d21e..f320a125e031

2023-11-19 skia-autoroll@skia-public.iam.gserviceaccount.com Roll skcms from 2b3cf74d484d to 02a8c0638601 (1 revision)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC brianosman@google.com,jonahwilliams@google.com,nicolettep@google.com,rmistry@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2023-11-19 05:27:23 +00:00
skia-flutter-autoroll
c16aa5e9a2 Roll Skia from f9e9bff1714a to b311e4d0d21e (1 revision) (flutter/engine#48207) 
https://skia.googlesource.com/skia.git/+log/f9e9bff1714a..b311e4d0d21e

2023-11-18 skia-autoroll@skia-public.iam.gserviceaccount.com Roll vulkan-deps from ca747870c613 to b9ed775dbbe7 (1 revision)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC brianosman@google.com,jonahwilliams@google.com,nicolettep@google.com,rmistry@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2023-11-19 00:29:21 +00:00
skia-flutter-autoroll
7d45a69824 Roll Skia from 4f22188e5103 to f9e9bff1714a (1 revision) (flutter/engine#48203) 
https://skia.googlesource.com/skia.git/+log/4f22188e5103..f9e9bff1714a

2023-11-18 skia-autoroll@skia-public.iam.gserviceaccount.com Roll vulkan-deps from 9c068ba7e8cd to ca747870c613 (6 revisions)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC brianosman@google.com,jonahwilliams@google.com,nicolettep@google.com,rmistry@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2023-11-18 11:47:30 +00:00
skia-flutter-autoroll
ac0b88e368 Roll Fuchsia Linux SDK from Bcq9TZdt-vtTSL5YH... to LnToEykA8o68jv58K... (flutter/engine#48202) 
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/fuchsia-linux-sdk-flutter-engine
Please CC jonahwilliams@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2023-11-18 10:32:19 +00:00
skia-flutter-autoroll
435bc8a370 Roll Dart SDK from 3d4886a2e218 to 564cfb2cfe79 (1 revision) (flutter/engine#48195) 
https://dart.googlesource.com/sdk.git/+log/3d4886a2e218..564cfb2cfe79

2023-11-18 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com Version 3.3.0-149.0.dev

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/dart-sdk-flutter-engine
Please CC dart-vm-team@google.com,jonahwilliams@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter Engine: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2023-11-18 01:57:16 +00:00
skia-flutter-autoroll
2b6716731a Roll Skia from 11b5847aea97 to 4f22188e5103 (1 revision) (flutter/engine#48196) 
https://skia.googlesource.com/skia.git/+log/11b5847aea97..4f22188e5103

2023-11-17 skia-autoroll@skia-public.iam.gserviceaccount.com Roll vulkan-deps from b5f778a99583 to 9c068ba7e8cd (5 revisions)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC brianosman@google.com,jonahwilliams@google.com,nicolettep@google.com,rmistry@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2023-11-18 01:53:33 +00:00
Matan Lurey
54a0749f76 Make impeller/... compatible with .clang-tidy. (flutter/engine#48155) 
I moved [`scene_context.h` to another PR](https://github.com/flutter/engine/pull/48194), and here are the boring remains.
 2023-11-18 01:21:48 +00:00
Matan Lurey
2b34bf3fe2 Make shell/platform/{darwin|embedder}/... compatible with .clang-tidy. (flutter/engine#48160) 2023-11-18 01:06:05 +00:00
Matan Lurey
8ee0e2f7e1 Make display_list/... compatible with .clang_tidy. (flutter/engine#48147) 2023-11-18 00:21:14 +00:00
Matan Lurey
ddce052e36 Make testing/... and vulkan/... compatible with .clang-tidy. (flutter/engine#48161) 2023-11-17 15:16:31 -08:00
Matan Lurey
65edca6565 Make impeller/aiks/... compatible with .clang-tidy. (flutter/engine#48152) 2023-11-17 23:00:13 +00:00
Bartek Pacia
2168e305d1 Fix a few typos (flutter/engine#47960) 
I found 3 small typos :)

Supersedes #47929

[C++, Objective-C, Java style guides]: https://github.com/flutter/engine/blob/main/CONTRIBUTING.md#style
 2023-11-17 22:46:51 +00:00
skia-flutter-autoroll
64e53d3adf Roll Skia from 04b0ac194443 to 11b5847aea97 (3 revisions) (flutter/engine#48188) 
https://skia.googlesource.com/skia.git/+log/04b0ac194443..11b5847aea97

2023-11-17 johnstiles@google.com Disable TransformHsw and TransformSkx on Android.
2023-11-17 jvanverth@google.com Remove legacy gradient stop calculation.
2023-11-17 skia-autoroll@skia-public.iam.gserviceaccount.com Roll skcms from fb11678cf25f to 2b3cf74d484d (4 revisions)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC brianosman@google.com,jonahwilliams@google.com,nicolettep@google.com,rmistry@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2023-11-17 22:29:03 +00:00
Matan Lurey
aa07289b98 Make fml/... compatible with .clang-tidy. (flutter/engine#48150) 2023-11-17 22:14:38 +00:00
skia-flutter-autoroll
ff14804a28 Roll Dart SDK from 03cddb5d740d to 3d4886a2e218 (1 revision) (flutter/engine#48187) 
https://dart.googlesource.com/sdk.git/+log/03cddb5d740d..3d4886a2e218

2023-11-17 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com Version 3.3.0-148.0.dev

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/dart-sdk-flutter-engine
Please CC dart-vm-team@google.com,jonahwilliams@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter Engine: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2023-11-17 21:46:05 +00:00
skia-flutter-autoroll
38660931e5 Roll Skia from dd7a26ead897 to 04b0ac194443 (8 revisions) (flutter/engine#48186) 
https://skia.googlesource.com/skia.git/+log/dd7a26ead897..04b0ac194443

2023-11-17 lovisolo@google.com [bazel] Generate device-specific configurations with Gold/Perf trace keys.
2023-11-17 maskray@google.com SkScan_AAAPath: for potential -fsanitize=alignment failure
2023-11-17 kjlubick@google.com Revert "Turn on SK_DISABLE_LEGACY_FONTMGR_FACTORY"
2023-11-17 maskray@google.com [docs] Fix /dev/contrib/ links
2023-11-17 kjlubick@google.com Turn on SK_DISABLE_LEGACY_FONTMGR_FACTORY
2023-11-17 brianosman@google.com Revert "Emoji font resolution fix"
2023-11-17 kjlubick@google.com Touch the skcms files to avoid 409 error on roll
2023-11-17 skia-autoroll@skia-public.iam.gserviceaccount.com Roll SK Tool from bc5a26ce9f2b to ff8a5b05fd8b

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC brianosman@google.com,jonahwilliams@google.com,nicolettep@google.com,rmistry@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2023-11-17 21:42:05 +00:00
hangyu
cd4c07d7a2 [Android] Send " did gain focus" message from engine to framework (flutter/engine#47114) 
issue:https://github.com/flutter/flutter/issues/97747

framework pr:https://github.com/flutter/flutter/pull/135771

## Pre-launch Checklist

- [ ] I read the [Contributor Guide] and followed the process outlined
there for submitting PRs.
- [ ] I read the [Tree Hygiene] wiki page, which explains my
responsibilities.
- [ ] I read and followed the [Flutter Style Guide] and the [C++,
Objective-C, Java style guides].
- [ ] I listed at least one issue that this PR fixes in the description
above.
- [ ] I added new tests to check the change I am making or feature I am
adding, or the PR is [test-exempt]. See [testing the engine] for
instructions on writing and running engine tests.
- [ ] I updated/added relevant documentation (doc comments with `///`).
- [ ] I signed the [CLA].
- [ ] All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel
on [Discord].

<!-- Links -->
[Contributor Guide]:
https://github.com/flutter/flutter/wiki/Tree-hygiene#overview
[Tree Hygiene]: https://github.com/flutter/flutter/wiki/Tree-hygiene
[test-exempt]:
https://github.com/flutter/flutter/wiki/Tree-hygiene#tests
[Flutter Style Guide]:
https://github.com/flutter/flutter/wiki/Style-guide-for-Flutter-repo
[C++, Objective-C, Java style guides]:
https://github.com/flutter/engine/blob/main/CONTRIBUTING.md#style
[testing the engine]:
https://github.com/flutter/flutter/wiki/Testing-the-engine
[CLA]: https://cla.developers.google.com/
[flutter/tests]: https://github.com/flutter/tests
[breaking change policy]:
https://github.com/flutter/flutter/wiki/Tree-hygiene#handling-breaking-changes
[Discord]: https://github.com/flutter/flutter/wiki/Chat

---------

Co-authored-by: Reid Baker <reidbaker@google.com>
 2023-11-17 13:31:33 -08:00
skia-flutter-autoroll
e7e9a40053 Roll Skia from 8e9e168418a0 to dd7a26ead897 (1 revision) (flutter/engine#48178) 
https://skia.googlesource.com/skia.git/+log/8e9e168418a0..dd7a26ead897

2023-11-17 scroggo@google.com Android: Pin skia's cpp_std to gnu++17

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC brianosman@google.com,jonahwilliams@google.com,nicolettep@google.com,rmistry@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2023-11-17 20:38:35 +00:00
Chris Yang
e7f47ca25d [Ios] move flutter_test_ios_mrc unittests to arc (flutter/engine#48162) 
Move all tests in flutter_test_ios_mrc to arc

Part of https://github.com/flutter/flutter/issues/137801

Changes mostly involves trivial mrc to arc changes. non-trivial changes are commented inline. 

[C++, Objective-C, Java style guides]: https://github.com/flutter/engine/blob/main/CONTRIBUTING.md#style
 2023-11-17 20:26:16 +00:00
Dan Field
21b2df9815 Reland "[Impeller] Fail if software backend is chosen and Impeller is enabled on iOS." (flutter/engine#46275) 
Reverts flutter/engine#46217

cl/568091248 makes this safe to land again.

fyi @jonahwilliams @chinmaygarde
 2023-11-17 20:12:48 +00:00
Matan Lurey
178e3396e3 Make impeller/geometry/... compatible with .clang-tidy. (flutter/engine#48154) 2023-11-17 12:05:40 -08:00
Matan Lurey
c175f20309 Make impeller/{archivist|compiler|core|entity}/... compatible with … (flutter/engine#48153) 2023-11-17 11:58:57 -08:00
yaakovschectman
bb97ac1d3b Assign mojom kSwitch role to switches (flutter/engine#48146) 
We have previously been using the `kToggleButton` role for any widget
that has a toggled state. Our AX library does not expect this role to be
used for switches, and so would not assign the checked state to switches
for MSAA. As far as I can tell, the `Switch` is the only widget that
uses the `toggled` semantic property (`ToggleButtons`, ironically, does
not), so we ought to be able to swap in the `kSwitch` role, for which
the proper states are presented. This will allow screen readers to
announce the state of a switch.

https://github.com/flutter/flutter/issues/138500

## Pre-launch Checklist

- [x] I read the [Contributor Guide] and followed the process outlined
there for submitting PRs.
- [x] I read the [Tree Hygiene] wiki page, which explains my
responsibilities.
- [x] I read and followed the [Flutter Style Guide] and the [C++,
Objective-C, Java style guides].
- [x] I listed at least one issue that this PR fixes in the description
above.
- [x] I added new tests to check the change I am making or feature I am
adding, or the PR is [test-exempt]. See [testing the engine] for
instructions on writing and running engine tests.
- [x] I updated/added relevant documentation (doc comments with `///`).
- [ ] I signed the [CLA].
- [x] All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel
on [Discord].

<!-- Links -->
[Contributor Guide]:
https://github.com/flutter/flutter/wiki/Tree-hygiene#overview
[Tree Hygiene]: https://github.com/flutter/flutter/wiki/Tree-hygiene
[test-exempt]:
https://github.com/flutter/flutter/wiki/Tree-hygiene#tests
[Flutter Style Guide]:
https://github.com/flutter/flutter/wiki/Style-guide-for-Flutter-repo
[C++, Objective-C, Java style guides]:
https://github.com/flutter/engine/blob/main/CONTRIBUTING.md#style
[testing the engine]:
https://github.com/flutter/flutter/wiki/Testing-the-engine
[CLA]: https://cla.developers.google.com/
[flutter/tests]: https://github.com/flutter/tests
[breaking change policy]:
https://github.com/flutter/flutter/wiki/Tree-hygiene#handling-breaking-changes
[Discord]: https://github.com/flutter/flutter/wiki/Chat
 2023-11-17 14:21:23 -05:00
Mouad Debbar
3e7fea4e4f [web] Move scene DOM management to DomManager (flutter/engine#47460) 
- Move scene insertion logic to `DomManager`.
- Add TODOs in `Renderer` subclasses (cc @harryterkelsen).

Part of https://github.com/flutter/flutter/issues/134443
 2023-11-17 18:35:15 +00:00
gaaclarke
cb70984e12 [Impeller] Unify around "transform" (flutter/engine#48184) 
This replaces usage of "xformation" and "transformation".

test-exempt: refactor

[C++, Objective-C, Java style guides]: https://github.com/flutter/engine/blob/main/CONTRIBUTING.md#style
 2023-11-17 18:03:23 +00:00
skia-flutter-autoroll
4d2b97c7eb Roll Dart SDK from a9c212f2f54b to 03cddb5d740d (1 revision) (flutter/engine#48182) 
https://dart.googlesource.com/sdk.git/+log/a9c212f2f54b..03cddb5d740d

2023-11-17 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com Version 3.3.0-147.0.dev

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/dart-sdk-flutter-engine
Please CC dart-vm-team@google.com,jonahwilliams@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter Engine: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2023-11-17 17:40:11 +00:00
Matan Lurey
6f19a763ec Actually make status_or.h compatible with .clang-tidy. (flutter/engine#48151) 
I needed to actually convince the checker I wasn't causing a value read
on a non-value. I think this is right?
 2023-11-17 09:07:05 -08:00
Jonah Williams
ea36645542 [Impeller] Cleanups to geometry interfaces. (flutter/engine#48180) 
* Removed virtual destructor. We only use Geometry types with std::shared_ptr which remembers the correct dtor, we'd only need the virtual destructor if we were using `free` ourselves.
* Remove std:unique_ptr. We had a mix on unique and shared ptrs, and were even doing some copies/conversions between the two. I made it consistently shared_ptr, I don't see the advantage of unique given that geometries are essentially immutable.
* made geometry classes have more const methods and final.
* Added some asserts on trivial destruction.
 2023-11-17 17:05:56 +00:00
Mouad Debbar
360c454b63 [web] Move all DOM creation to DomManager (flutter/engine#48123) 
- `FlutterViewEmbedder` doesn't create the DOM tree anymore (instead, `DomManager` does).
- `DomManager` only creates the DOM tree (with styles) but doesn't insert it into the document.
- `EngineFlutterView` takes the root element from `DomManager` and inserts it into the document.
- We finally can now create multiple Flutter views, each with its own DOM tree.

cc @yjbanov since I'm making a few changes that probably conflict with your semantics changes.

Part of https://github.com/flutter/flutter/issues/134443
Part of https://github.com/flutter/flutter/issues/137447
 2023-11-17 16:45:23 +00:00