11735 Commits

Author SHA1 Message Date
gaaclarke
cfbd7272da Started clearing out the parent of orphaned semantic objects. (flutter/engine#17499) 2020-04-03 14:35:48 -07:00
xster
11898dcd3a onRequestPermissionsResult now require calling super on AndroidX master (flutter/engine#17305) 2020-04-03 13:03:26 -07:00
xster
c81eeda828 Small updates to objcdocs (flutter/engine#17151) 2020-04-03 13:03:06 -07:00
Jason Simmons
02720fbca8 Fix include paths of fml/time headers in the shell and rasterizer (flutter/engine#17502) 2020-04-03 12:33:54 -07:00
skia-flutter-autoroll
fb3c662a37 Roll fuchsia/sdk/core/linux-amd64 from -jFTb... to TWx2R... (flutter/engine#17498) 2020-04-03 12:01:02 -07:00
skia-flutter-autoroll
8e9b3d9063 Roll fuchsia/sdk/core/mac-amd64 from 6V5BR... to tKvUB... (flutter/engine#17497) 2020-04-03 11:56:06 -07:00
skia-flutter-autoroll
369c1bc159 Roll src/third_party/skia 8efbbbc0d1d4..e70e0c055f56 (1 commits) (flutter/engine#17496) 2020-04-03 11:51:05 -07:00
Chris Bracken
adb73da22f Use const refs in for loops where reasonable (flutter/engine#17484)
This patch optimizes C++11 range-based for loops where the variable is
copied in each iteration but it would suffice to obtain it by const
reference. This is only applied to loop variables of types that are
expensive to copy which means they are not trivially copyable or have a
non-trivial copy constructor or destructor.

To ensure that it is safe to replace the copy with a const reference
only the following cases are modified:
  * The loop variable is const-qualified.
  * The loop variable is not const, but only const methods or operators
    are invoked on it, or it is used as const reference or value argument
    in constructors or function calls.

This is an application of the internal performance-for-range-copy
clang-tidy analysis.
2020-04-03 11:44:35 -07:00
Chris Bracken
07513a2d45 Revert "[tools][fuchsia] Do not tar debug symbol CIPD uploads (#17275)" (flutter/engine#17501)
Breaks CIPD package creation on Fuchsia.

Example error message:

    Directory: /b/s/w/ir/k/recipe_cleanup/tmp9x3dHw is not empty, deleting it.
    Traceback (most recent call last):
      File "/b/s/w/ir/cache/builder/src/flutter/tools/fuchsia/merge_and_upload_debug_symbols.py", line 140, in <module>
        sys.exit(main())
      File "/b/s/w/ir/cache/builder/src/flutter/tools/fuchsia/merge_and_upload_debug_symbols.py", line 131, in main
        HardlinkContents(symbol_dir, out_dir)
      File "/b/s/w/ir/cache/builder/src/flutter/tools/fuchsia/merge_and_upload_debug_symbols.py", line 83, in HardlinkContents
        os.makedirs(dest_dir)
      File "/b/s/w/ir/cache/vpython/9f7888/lib/python2.7/os.py", line 157, in makedirs
        mkdir(name, mode)
    OSError: [Errno 17] File exists: '/b/s/w/ir/k/recipe_cleanup/tmp9x3dHw/.'

This reverts commit 3369570b18f926f73ecd94a1365d9996afcb6eca.
2020-04-03 11:00:57 -07:00
George Wright
69163aaa96 Revert "[tools][fuchsia] Do not tar debug symbol CIPD uploads (#17275)"
This reverts commit 3369570b18f926f73ecd94a1365d9996afcb6eca.
2020-04-03 10:56:08 -07:00
skia-flutter-autoroll
9f74aa3539 Roll src/third_party/dart fae35fca47c9..e736495eb7f0 (26 commits) (flutter/engine#17494)
https://dart.googlesource.com/sdk.git/+log/fae35fca47c9..e736495eb7f0

git log fae35fca47c9..e736495eb7f0 --date=short --first-parent --format='%ad %ae %s'
2020-04-03 rnystrom@google.com Migrate language_2/const to NNBD.
2020-04-03 srujzs@google.com [dart:html] Copy and rename lib_2/html to NNBD.
2020-04-02 jwren@google.com Bug fix in inherited_reference_contributor.dart, completions inside of ConstructorDeclarations should include inherited members.
2020-04-02 scheglov@google.com Infer when nullable type parameter type.
2020-04-02 rnystrom@google.com Add a "fork" command to the migration tool.
2020-04-02 alexmarkov@google.com [tests/nnbd] Fix lib/convert/chunked_conversion_utf88_test for strong mode
2020-04-02 srujzs@google.com [dart:html] Add insertAll to ChildrenElementList
2020-04-02 liama@google.com [nnbd/tests] Fix more HTTP/socket strong mode tests
2020-04-02 srujzs@google.com [dart:html] Remove nullability from CssClassSet funcs
2020-04-02 srujzs@google.com [dart:html] Fix nullability for vars with null checks
2020-04-02 scheglov@google.com More work on ConstraintMatchingTest.
2020-04-02 rnystrom@google.com Migrate language_2/covariant_override to NNBD.
2020-04-02 alexmarkov@google.com Update pkg/vm patterns so pkg/vm_service doesn't match them
2020-04-02 brianwilkerson@google.com Clean up OpTypeTest
2020-04-02 sigmund@google.com [tests] adjust error_stack_trace2_test to work also for DDC.
2020-04-02 sstrickl@google.com [vm] Drop WSRs with reachable references, not just allocated.
2020-04-02 rnystrom@google.com Migrate language_2/closure to NNBD.
2020-04-02 liama@google.com [nnbd/lib] Fix some more strong mode tests
2020-04-02 regis@google.com [VM/nnbd] Minor cleanup when checking required named parameter in strong mode.
2020-04-02 alexmarkov@google.com [vm/nnbd] Infer more accurate types for late static fields
2020-04-02 brianwilkerson@google.com Remove an unnecessary type annotation to satisfy a lint
2020-04-02 brianwilkerson@google.com Report more development time metrics
2020-04-02 scheglov@google.com Remove typeParameterType() and replace with typeParameterTypeStar() mostly.
2020-04-02 brianwilkerson@google.com Pull the latest version of pedantic into the SDK
2020-04-02 scheglov@google.com Remove unused TypeComparison.
2020-04-02 scheglov@google.com Replace interfaceType() with interfaceTypeNone() in ConstraintMatchingTest.

Created with:
  gclient setdep -r src/third_party/dart@e736495eb7f0

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/dart-sdk-flutter-engine
Please CC dart-vm-team@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

Bug: None
Tbr: dart-vm-team@google.com
2020-04-03 09:44:15 -07:00
Joshua Seaton
3369570b18 [tools][fuchsia] Do not tar debug symbol CIPD uploads (flutter/engine#17275)
Fuchsia is the main consumer of these CIPD packages and - to simplify
its infrastructure - it is migrating its SDK partners over to producing
a CIPD package containing a flat .build-id directory.

This change also updates the CIPD package so that the .build-id
directory is placed at the root.

Bug: fxbug.dev/41443
2020-04-02 18:44:09 -07:00
skia-flutter-autoroll
fb859e0270 Roll src/third_party/skia 8afde5f39508..8efbbbc0d1d4 (14 commits) (flutter/engine#17491) 2020-04-02 18:26:02 -07:00
skia-flutter-autoroll
1bda40865c Roll fuchsia/sdk/core/linux-amd64 from v61zg... to -jFTb... (flutter/engine#17490) 2020-04-02 18:21:04 -07:00
Jason Simmons
3c089996dc Disconnect from platform views and virtual displays before detaching from the engine (flutter/engine#17379) 2020-04-02 18:16:05 -07:00
Kaushik Iska
ce0ec9042f [pipeline] Add trace event for lag between target and display times (flutter/engine#17384)
This change also adds TimeRecorder which records time at the start
of each frame to capture the latest vsync target display time and
wires it in to the rasterizer to add trace events when there is a lag.
2020-04-02 17:15:45 -07:00
Dan Field
f1a58638ad Fix bad texture view config (flutter/engine#17486) 2020-04-02 15:06:03 -07:00
stuartmorgan
7b222c8310 Remove JSON codec from C++ client wrapper (flutter/engine#17312)
The JSON codec is awkward to use in the wrapper (since the client has to build and link one of the JSON libraries to do so). Since it would be very cumbersome to wrap in a C API, and there's essentially no reason to use it instead of the standard codec, this removes it from the wrapper entirely.

Since some system channels (internal to the engine) still use it, it's moved into common/cpp instead of being eliminated entirely. Internally we always use RapidJSON though, so the jsoncpp implementation is removed. Also adds some unit test coverage, since there wasn't any.

Fixes #30669
2020-04-02 14:57:46 -07:00
Dan Field
904a84fee3 Roll to clang11, mark 4 (flutter/engine#17483)
* "Reland Clang 11, roll buildroot to 1bc40a5f916adb93d87e2a2230a0ec43db876c1c, take 4 (#17467)" (#17482)"

This reverts commit d7bbf2e70c8cb86823f1ec7a310d6ab0b9a610db.

* format code

* Roll buildroot to 3a27de1c5bb0f50be7d3efe3e00de4f6068c9f30
2020-04-02 13:04:49 -07:00
Chinmay Garde
165af3205c Always cache SkSL when using the Metal backend. (flutter/engine#17468)
There is no ability to compile shaders online and cache those binaries when
using the Metal backend. SkSL caching must always be used.
2020-04-02 13:00:29 -07:00
skia-flutter-autoroll
5a49380308 Roll fuchsia/sdk/core/mac-amd64 from QgqO4... to 6V5BR... (flutter/engine#17481) 2020-04-02 11:51:02 -07:00
Jonah Williams
e6e8170ea8 fix typos in switch descriptions (flutter/engine#17475) 2020-04-02 11:21:04 -07:00
skia-flutter-autoroll
67ba02a348 Roll src/third_party/skia 8ce842d38d0b..8afde5f39508 (9 commits) (flutter/engine#17480) 2020-04-02 10:51:02 -07:00
Dan Field
a04ba4f15e Initialize locale from FlutterEngine (flutter/engine#17473)
* Initialize locale from FlutterEngine
2020-04-02 10:06:06 -07:00
Dan Field
d7bbf2e70c Revert "Reland Clang 11, roll buildroot to 1bc40a5f916adb93d87e2a2230a0ec43db876c1c, take 3 (#17467)" (flutter/engine#17482)
This reverts commit 31eab31f771363d9c4fc9799449859abe0e464f2.
2020-04-02 10:01:26 -07:00
skia-flutter-autoroll
d32996916f Roll src/third_party/dart 5a965d5d0fef..fae35fca47c9 (7 commits) (flutter/engine#17478) 2020-04-02 09:56:03 -07:00
skia-flutter-autoroll
fc4c1fc626 Roll src/third_party/skia 6c51bf61e283..8ce842d38d0b (1 commits) (flutter/engine#17477) 2020-04-02 06:56:03 -07:00
skia-flutter-autoroll
a3d8e2e9d1 Roll src/third_party/dart 6e53ac6e4c7b..5a965d5d0fef (2 commits) (flutter/engine#17476) 2020-04-02 04:11:03 -07:00
skia-flutter-autoroll
2ff59573d0 Roll src/third_party/skia 46aacc771012..6c51bf61e283 (3 commits) (flutter/engine#17472) 2020-04-02 00:01:04 -07:00
skia-flutter-autoroll
55efd61beb Roll fuchsia/sdk/core/linux-amd64 from zJlvo... to v61zg... (flutter/engine#17471) 2020-04-01 23:56:03 -07:00
Dan Field
cf99fa2fd8 Roll Android NDK to r21.0.6113669 (flutter/engine#17470) 2020-04-01 23:07:05 -07:00
skia-flutter-autoroll
98295a6cbc Roll src/third_party/dart b85c68a73cc2..6e53ac6e4c7b (3 commits) (flutter/engine#17469) 2020-04-01 22:41:03 -07:00
skia-flutter-autoroll
ee3d1384dd Roll src/third_party/skia b14b14445884..46aacc771012 (5 commits) (flutter/engine#17466) 2020-04-01 21:26:03 -07:00
Dan Field
31eab31f77 Reland Clang 11, roll buildroot to 1bc40a5f916adb93d87e2a2230a0ec43db876c1c, take 3 (flutter/engine#17467)
* Reland Clang 11, Roll buildroot to 1bc40a5f916adb93d87e2a2230a0ec43db876c1c (#17457)" (#17464)

This reverts commit 6083cda709c194ec81d2092c70a0151a10f0c922.

* Skip more image tests, use newer dsymutil, add missing symbols
2020-04-01 20:55:27 -07:00
mikejurka
d133ffb5a8 [fuchsia] Add tests for TransformLayer. (flutter/engine#17439) 2020-04-01 20:01:52 -07:00
George Wright
9b4556331b Flush the session after updating the scene 2020-04-01 19:48:07 -07:00
George Wright
34be05b507 Manual roll fuchsia/sdk/core/linux-amd64 from nK6R0... to zJlvo... 2020-04-01 19:48:07 -07:00
skia-flutter-autoroll
d9ac997b8f Roll src/third_party/skia bfc09267bdb4..b14b14445884 (13 commits) (flutter/engine#17462) 2020-04-01 19:01:04 -07:00
skia-flutter-autoroll
5748521072 Roll src/third_party/dart b177e44ffa44..b85c68a73cc2 (21 commits) (flutter/engine#17460) 2020-04-01 18:56:03 -07:00
skia-flutter-autoroll
9bb1856b95 Roll fuchsia/sdk/core/mac-amd64 from iP6DE... to QgqO4... (flutter/engine#17463) 2020-04-01 18:51:08 -07:00
Gary Qian
eff62e12bd Implement getExtractedText in InputConnectionAdaptor (flutter/engine#17426) 2020-04-01 18:51:04 -07:00
liyuqian
474e90ba76 Add build_and_test_linux_release presubmit test (flutter/engine#17073) 2020-04-01 18:46:04 -07:00
Dan Field
6083cda709 Revert "Reland Clang 11, Roll buildroot to 1bc40a5f916adb93d87e2a2230a0ec43db876c1c (#17457)" (flutter/engine#17464)
This reverts commit fe77c763691277d3194269f30d9a8c915e437852.
2020-04-01 17:50:57 -07:00
Dan Field
fe77c76369 Reland Clang 11, Roll buildroot to 1bc40a5f916adb93d87e2a2230a0ec43db876c1c (flutter/engine#17457)
* Reland "Roll Clang to v11, roll buildroot to fe13f79dce4ce9aab3209f11988d825dcf580b4a, allow newly exported symbols (#17440)" (#17451)"

This reverts commit d77d53688f77285966adeb2a24349ba490a7e6ce.

* skip golden that is different on macos

* buildroot to 1bc40a5f916adb93d87e2a2230a0ec43db876c1c
2020-04-01 16:32:13 -07:00
gaaclarke
f3c6f8902f Started clearing out the semantics information in Dart as well as deleting the AccessibilityBridge. (flutter/engine#17433) 2020-04-01 13:08:01 -07:00
skia-flutter-autoroll
5ea5e92f0a Roll src/third_party/skia e8d2080a34ed..bfc09267bdb4 (8 commits) (flutter/engine#17450) 2020-04-01 12:16:01 -07:00
Dan Field
d77d53688f Revert "Roll Clang to v11, roll buildroot to fe13f79dce4ce9aab3209f11988d825dcf580b4a, allow newly exported symbols (#17440)" (flutter/engine#17451)
This reverts commit 44327d852622d7ea8fafa4b232b91f74ea7aaf72.
2020-04-01 11:06:07 -07:00
stuartmorgan
18e2aed939 Remove me from auto-assign list (flutter/engine#17446) 2020-04-01 10:51:03 -07:00
Dan Field
44327d8526 Roll Clang to v11, roll buildroot to fe13f79dce4ce9aab3209f11988d825dcf580b4a, allow newly exported symbols (flutter/engine#17440)
* Buildroot to fe13f79dce4ce9aab3209f11988d825dcf580b4a

* whitelist more symbols
2020-04-01 10:49:24 -07:00
cjng96
fdfb501df7 Remove code which skips keyEvent from input control on web (flutter/engine#17242) 2020-04-01 09:32:18 -07:00