Dart actually expects package: to work. This CL makes package:foo
map to /packages/foo, similar to how Dartium or bin/dart would expect.
This also means overlaying the /gen directory over the actual package
outputs (as consumers of an SDK would expect) as well as adding
an additional /lib indirection for the actual package source as
the Dart pub tool will expect.
This is far from perfect, but it unlocks us actually producing a
sky SDK.
I expect there may be some fallout from this change as I'm sure I
missed some package: uses. We also don't have a general solution
for all /foo/bar/baz includes which randomly included parts
of mojo's source directory. Those will need to be updated to use
a package: and deploy_sdk.py taught how to build a package for them.
R=abarth@chromium.org
Review URL: https://codereview.chromium.org/990493002
-Add a --testing flag to sky_viewer and cause it to paint into an
SkBitmap instead of a ganesh surface so we can get the pixels out.
-Add GetPixelsForTesting to layer.cc to actually grab out the pixels.
-Add a reftest and a mismatch reftest. They need a setTimeout after
the load event. Unclear why or what the right fix is. Maybe we should
give internals some way to force the paint? If we don't have the
setTimeout, we paint a white page (so we do a paint, but with no
content).
-Add a DisplayDelegate to Layer so that Viewer can decide whether
to use the real ganesh backend or the SkBitmap one without littering
the whole code-base with is_testing bools and logic.
R=esprehn@chromium.org
Review URL: https://codereview.chromium.org/797063002
-s/-expected.html/-expected.sky/
-s/-expected-mismatch.html/-expected-mismatch.sky/
-In single_test_runner.py, get rid of the image hash checking
for reftests. It doesn't provide any value and just makes
getting reftests working more complicated.
R=eseidel@chromium.org
Review URL: https://codereview.chromium.org/802573002
Skipped tests were not getting skipped because
the code gets whether the build is a debug or release
build from the configuration commandline argument, but
the asan bots pass Release_asan. Instead, read the
debug vs. release state from gn args instead of inferring
it from the out directory.
R=eseidel@chromium.org, esprehn@chromium.org, sky@chromium.org
Review URL: https://codereview.chromium.org/754673003
We keep seeing timeouts on the bots that seem to be due
to cherrypy dropping requests on the floor, which in turn
causes imports to stall, which causes the test to time out.
In local testing, I was able to reproduce the timeouts
and wasn't able to do so with the go-based server.
R=abarth@chromium.org, eseidel@chromium.org
Review URL: https://codereview.chromium.org/746373002
1. Print out the sky_server commandline as well so it's easy
to run the server without running test_sky.
2. Quote the --args-for arguments, so that they copy-paste
correctly.
R=abarth@chromium.org
Review URL: https://codereview.chromium.org/762703005
Flakiness dashboard assumed each buildbot step corresponds to one
test suite. So, it assumes the test type matches the buildbot
step name. This fix is somewhat hacky in that we won't be
able to make other test suites in mojob test upload to the
flakiness dashboard, but that's technical debt we already have
from smashing multiple test suites into one buildbot step.
R=eseidel@chromium.org
Review URL: https://codereview.chromium.org/725993003
Lets see if this removes the flake on the bots seen in sky tests. In
local testing it looks like sky_server's CherryPy becomes overloaded and
then the requests take a very long time to complete which makes the tests
timeout. I increased the timeout locally and it made the tests start
passing consistently when using high --repeat values.
R=ojan@chromium.org
Review URL: https://codereview.chromium.org/741603002
This makes the output much more readable and you can actually see
stacktraces. Long-term, we need to stick this output into the result
of the previous test instead of having them be printed to stderr.
R=esprehn@chromium.org
Review URL: https://codereview.chromium.org/686723004
