DEV/flutter_flutter
1
0
Fork 0
mirror of https://github.com/flutter/flutter.git synced 2026-02-20 02:29:02 +08:00
Code Issues Packages Projects Releases Wiki Activity

Add the ability to upload sky_tests to the flakiness dashboard.

Browse Source 
Modify mojob.py to plumb through the arguments needed to upload
sky tests to the flakiness dashboard. A followup change will
need to modify the buildbot side to pass these arguments
to mojob.py.

R=abarth@chromium.org, jamesr@chromium.org

Review URL: https://codereview.chromium.org/726313007
This commit is contained in:
Ojan Vafai 2014-11-17 13:14:38 -08:00
parent 0a474a4c0b
commit e0de9cbe42
3 changed files with 8 additions and 7 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

1
tools/webkitpy/layout_tests/layout_package/json_results_generator_unittest.py
View File

@ -35,7 +35,6 @@ from webkitpy.layout_tests.layout_package import json_results_generator
class JSONGeneratorTest(unittest.TestCase):
def setUp(self):
self.builder_name = 'DUMMY_BUILDER_NAME'
self.build_name = 'DUMMY_BUILD_NAME'
self.build_number = 'DUMMY_BUILDER_NUMBER'
# For archived results.

11
tools/webkitpy/layout_tests/models/test_run_results.py
View File

@ -311,17 +311,22 @@ def summarize_results(port_obj, expectations, initial_results, retry_results, en
# Don't do this by default since it takes >100ms.
# It's only used for uploading data to the flakiness dashboard.
results['chromium_revision'] = ''
results['blink_revision'] = ''
# TODO(ojan): Clean this up now that we only have one revision field.
# And rename it to sky_revision (requires modifing test-results.appspot).
if port_obj.get_option('builder_name'):
for (name, path) in port_obj.repository_paths():
scm = port_obj.host.scm_for_path(path)
if scm:
rev = scm.svn_revision(path)
rev = scm.latest_git_commit()
if rev:
results[name.lower() + '_revision'] = rev
else:
_log.warn('Failed to determine svn revision for %s, '
_log.warn('Failed to determine revision for %s, '
'leaving "%s_revision" key blank in full_results.json.'
% (path, name))
# TODO(ojan): Change test-results.appspot to not require this field.
# test-results.appspot.com requires this field to be a number. :(
results['blink_revision'] = 0
return results

3
tools/webkitpy/layout_tests/run_webkit_tests.py
View File

@ -281,9 +281,6 @@ def parse_args(args):
optparse.make_option("--builder-name", default="",
help=("The name of the builder shown on the waterfall running "
"this script e.g. WebKit.")),
optparse.make_option("--build-name", default="DUMMY_BUILD_NAME",
help=("The name of the builder used in its path, e.g. "
"webkit-rel.")),
optparse.make_option("--build-number", default="DUMMY_BUILD_NUMBER",
help=("The build number of the builder running this script.")),
optparse.make_option("--test-results-server", default="",