DEV/flutter_flutter
1
0
Fork 0
mirror of https://github.com/flutter/flutter.git synced 2026-02-20 02:29:02 +08:00
Code Issues Packages Projects Releases Wiki Activity

Green sky tests on the asan bot.

Browse Source 
Skipped tests were not getting skipped because
the code gets whether the build is a debug or release
build from the configuration commandline argument, but
the asan bots pass Release_asan. Instead, read the
debug vs. release state from gn args instead of inferring
it from the out directory.

R=eseidel@chromium.org, esprehn@chromium.org, sky@chromium.org

Review URL: https://codereview.chromium.org/754673003
This commit is contained in:
Ojan Vafai 2014-12-08 11:15:13 -08:00
parent 6a4ca1bc83
commit db877ecf4f
1 changed files with 11 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

12
tools/webkitpy/layout_tests/port/base.py
View File

@ -1159,7 +1159,17 @@ class Port(object):
def test_configuration(self):
"""Returns the current TestConfiguration for the port."""
if not self._test_configuration:
self._test_configuration = TestConfiguration(self._version, self._architecture, self._options.configuration.lower())
gn_args = self._executive.run_command([
'gn', 'args',
self._build_path_with_configuration(self._options.configuration),
'--list', '--short'])
if 'is_debug = true' in gn_args:
configuration = 'debug'
else:
configuration = 'release'
self._test_configuration = TestConfiguration(self._version, self._architecture, configuration)
return self._test_configuration
# FIXME: Belongs on a Platform object.