DEV/flutter_flutter
1
0
Fork 0
mirror of https://github.com/flutter/flutter.git synced 2026-02-20 02:29:02 +08:00
Code Issues Packages Projects Releases Wiki Activity
1,479 Commits 882 Branches 1,069 Tags
Commit Graph

1479 Commits

This Branch
This Branch
All Branches
Author SHA1 Message Date
Ojan Vafai
c8d918efa9 Make changing your layout manager work. 
If your layout manager changes, then you need to setNeedsLayout,
otherwise the next frame doesn't even get scheduled. We already
correctly handle going from not having layout to having one or
vice versa by doing the more drastic reattaching since that
requires changing your actual render class.

R=eseidel@chromium.org

Review URL: https://codereview.chromium.org/1060013005
 2015-04-15 11:08:32 -07:00
Ojan Vafai
a1d93b2847 Fix getChildElements. 
It was returing all element descendants instead of all element
immediate children.

R=eseidel@chromium.org

Review URL: https://codereview.chromium.org/1048333006
 2015-04-14 16:40:58 -07:00
Eric Seidel
cf80ee6250 Update CHANGELOGs for pub packages on trunk 
TBR=hansmuller@chromium.org

Review URL: https://codereview.chromium.org/1082413002
 2015-04-14 16:14:31 -07:00
Eric Seidel
9398450cbd Remove Widgets Demo, it's broken and doesn't provide any value over Stocks App 
R=ianh@google.com, ojan@chromium.org

Review URL: https://codereview.chromium.org/1085933002
 2015-04-14 14:47:21 -07:00
Ojan Vafai
7c974ed8cd Fix crash when removing layout managers. 
We weren't correctly marking an element as needing style
recalc if it was *losing* it's layout manager. We were
only doing so when it was gaining a layout manager for
the first time.

Review URL: https://codereview.chromium.org/1082273004
 2015-04-14 13:57:07 -07:00
Hixie
f76dd382b8 [Effen] We need to update the layout manager in _syncNode() also, 
otherwise when you switch from one Container instance to another, you
end up with the the layout being done by the wrong instance.

R=ojan@chromium.org

Review URL: https://codereview.chromium.org/1086983004
 2015-04-14 13:35:24 -07:00
Eric Seidel
987ba83d49 Make shelldb load sky_home by default 
TBR=ianh@google.com

Review URL: https://codereview.chromium.org/1083963003
 2015-04-14 12:49:22 -07:00
Eric Seidel
9fa6ca170a Teach window.location.href setter to handle relative urls. 
Also fixed display of text in touch-demo.sky

R=ianh@google.com

Review URL: https://codereview.chromium.org/1059743004
 2015-04-14 12:16:51 -07:00
Hixie
0e24ccd944 [Effen] Custom layout. For now, FixedHeightScrollable uses a custom BlockLayout algorithm, mostly as a proof of concept. 
R=ojan@chromium.org

Review URL: https://codereview.chromium.org/1064983002
 2015-04-14 10:38:05 -07:00
Hans Muller
ef3df2f4fb Scrollable should use scrollTo() instead of setting _scrollOffset directly, when starting an animation. 
I'd missed this case when adding Scrollable.scrollTo()
https://codereview.chromium.org/1074033002

R=ianh@google.com

Review URL: https://codereview.chromium.org/1082163002
 2015-04-14 10:01:44 -07:00
Eric Seidel
03b16f05b5 Remove needless comments in CSSValueKeywords.in 
TBR=ojan@chromium.org

Review URL: https://codereview.chromium.org/1056433004
 2015-04-13 13:10:18 -07:00
Hixie
f46c5d49d4 Fix the test broken by https://codereview.chromium.org/1078973002 by 
making sure the basic.sky test exposes the right (new) DOM now that
text is always wrapped in a display:paragraph div.

BUG=85
R=eseidel@chromium.org

Review URL: https://codereview.chromium.org/1083443002
 2015-04-10 15:04:54 -07:00
Eric Seidel
cc43ccec9a Remove LineFragmentationData it's unused 
TBR=ojan@chromium.org

Review URL: https://codereview.chromium.org/1063633006
 2015-04-10 13:34:37 -07:00
Eric Seidel
3f96f9344e Remove -webkit-user-drag 
Also cleaned up some uneeded comments in CSSValueKeywords.in

TBR=ojan@chromium.org

Review URL: https://codereview.chromium.org/1076353003
 2015-04-10 13:01:18 -07:00
Eric Seidel
5f7fdbc33a Remove completely-unused CSSValueKeywords 
I wrote a little script to try removing each
non-comment line of this file and re-compiling.

This was the result of said script.

R=ianh@google.com

Review URL: https://codereview.chromium.org/1076313003
 2015-04-10 11:54:29 -07:00
Ojan Vafai
9a7eb76c46 Remove dead code around anonymous renderers. 
There's no way to create anonymous renderers anymore.

R=eseidel@chromium.org

Review URL: https://codereview.chromium.org/1070233002
 2015-04-10 11:34:46 -07:00
Eric Seidel
ebb153fc8d Bump the pubspec versions for Sky and Mojo 
TBR=hansmuller@chromium.org

Review URL: https://codereview.chromium.org/1073243002
 2015-04-10 11:23:49 -07:00
Tony Gentilcore
940ac886a2 Disable sky/tests/framework/basic.sky due to issue #85 
TBR=ianh@google.com

Review URL: https://codereview.chromium.org/1073173002
 2015-04-10 07:26:36 -07:00
Hans Muller
b215015056 Added Scrollable.scrollTo() 
A subclass could override this method to limit scrolling or to initialize the scroll offset.

R=ianh@google.com

Review URL: https://codereview.chromium.org/1074033002
 2015-04-09 17:02:49 -07:00
James Robinson
b3cbc64e9a Generate trace header/footer in tracing consumer instead of service 
Having the output of the tracing service be a list of json objects
instead of one json object makes it much easier to combine multiple
sources. This teaches skydb (which wants to format the output into a
json file loadable by trace-viewer) to emit the tracing header/footer
itself. This will make it possible to combine data from the tracing
service with data collected by the shell itself.

R=eseidel@chromium.org

Review URL: https://codereview.chromium.org/1065093003
 2015-04-09 16:51:38 -07:00
Hixie
8c8ad532f4 [Effen] fix typo in animation code (impluse => impulse) 
R=eseidel@chromium.org

Review URL: https://codereview.chromium.org/1076963002
 2015-04-09 16:03:09 -07:00
Hixie
868b53259e [Effen] Use a Style element instead of inline style for the Text fn node's sky 
element with display:paragraph, so that the C++ side shares RenderStyles.
(based on review comments on https://codereview.chromium.org/1078973002 )

R=eseidel@chromium.org

Review URL: https://codereview.chromium.org/1070243003
 2015-04-09 16:00:10 -07:00
Hixie
3067bb641a [Effen] make fn wrap text in display:paragraph nodes 
R=eseidel@chromium.org, ojan@chromium.org

Review URL: https://codereview.chromium.org/1078973002
 2015-04-09 15:47:36 -07:00
Hixie
64a36de094 remove 'page' and 'size' since those are for printing, and that's obsolete in our world now 
Also it seems we're not parsing @page rules anyway, so this was presumably dead code.

R=eseidel@chromium.org

Review URL: https://codereview.chromium.org/1078883003
 2015-04-09 15:07:21 -07:00
Eric Seidel
51e1b37ba2 Remove empty-cells 
The world may never know what to do with empty cells?

Besides.  This was mislabled as layout, it was clearly a paint
property. :p

R=ianh@google.com

Review URL: https://codereview.chromium.org/1074953004
 2015-04-09 14:54:17 -07:00
Eric Seidel
8b5c8d86df Remove CSS table-layout property. 
It's dead Jim.

R=ianh@google.com

Review URL: https://codereview.chromium.org/1075023002
 2015-04-09 14:45:06 -07:00
Eric Seidel
bfbf14317f Remove page-break properties and captions 
We want some sort of per-screen breaking, but this
CSS is not the way to do it.  All of this was already
dead code.

R=ianh@google.com

Review URL: https://codereview.chromium.org/1070313003
 2015-04-09 14:39:17 -07:00
Hixie
9d8066aa56 remove 'widows' property because paged media support is gone so this does nothing now 
R=eseidel@chromium.org

Review URL: https://codereview.chromium.org/1078943002
 2015-04-09 14:35:27 -07:00
Eric Seidel
9cdf9ad09f remove CSS quotes property 
The support was gone, this is just dead code.

R=ianh@google.com, ojan@chromium.org

Review URL: https://codereview.chromium.org/1070263002
 2015-04-09 14:22:29 -07:00
Eric Seidel
559fd24b7e Roll mojo and sky pub versions to 0.0.4 
TBR=hansmuller@chromium.org

Review URL: https://codereview.chromium.org/1074933003
 2015-04-09 14:20:09 -07:00
Eric Seidel
9d740cb769 Remove CSSPropertySpeak 
This does not belong in CSS in Sky.

R=ojan@chromium.org

Review URL: https://codereview.chromium.org/1068383005
 2015-04-09 13:25:41 -07:00
Ojan Vafai
a8eda9b380 Remove dead createAnonymous functions. 
R=eseidel@chromium.org

Review URL: https://codereview.chromium.org/1077453002
 2015-04-09 11:40:53 -07:00
Ojan Vafai
b9f182a6bd Stop rendering text inside flex boxes. 
Text can only only inside paragraphs and inlines. This patch makes it
so we stop putting such text nodes in the render tree at all if their
parent is not a paragraph or an inline.

This is the final step in making it so that we don't create anonymous
renderers, which fixes a crash in the new custom layout code.

R=eseidel@chromium.org

Review URL: https://codereview.chromium.org/1077473002
 2015-04-09 11:40:03 -07:00
Hixie
ac53fad655 drop 'orphan' property, since it's for paged media and we don't support paged media any more 
R=ojan@chromium.org

Review URL: https://codereview.chromium.org/1068073002
 2015-04-09 09:24:49 -07:00
Przemyslaw Pietrzkiewicz
1964bdad39 Fix typo in sky/sdk/README.md. 
R=abarth@chromium.org

Review URL: https://codereview.chromium.org/1071523002
 2015-04-09 11:35:57 +02:00
Viet-Trung Luu
4a90c329d1 Fix Android build. 
RenderStyle apparently got smaller.

R=ojan@chromium.org, eseidel@chromium.org

Review URL: https://codereview.chromium.org/1067293003
 2015-04-08 16:37:40 -07:00
Eric Seidel
a118cc707c Remove CSS list-style 
We don't have lists.  So they can't be styled.

Dead code be dead.

R=ojan@chromium.org

Review URL: https://codereview.chromium.org/1069403003
 2015-04-08 15:03:38 -07:00
Eric Seidel
afaac6ec79 Remove our impressive amount of CSS Cursor code. 
With this gone, cursors will no longer change
on hover when running Sky on a desktop.

Then again the iGeneration doesn't
probably even know what a mouse is, let alone
have a burning desire to set a CSS3 custom-cursor.

R=ojan@chromium.org

Review URL: https://codereview.chromium.org/1076623002
 2015-04-08 14:23:13 -07:00
Eric Seidel
64e97bbea8 remove CSS 'all' property. 
The human mind is simply not capable of beholding the
sheer power of the CSS 'all' property.  We shall remove it
now and leave its echo for generations to contemplate.

R=ojan@chromium.org

Review URL: https://codereview.chromium.org/1068393002
 2015-04-08 13:39:47 -07:00
Eric Seidel
1381402a70 Remove obsolete CSSProperties.in -webkit- aliases. 
Just writing a C++ patch for a change to feel productive. :)

R=ojan@chromium.org

Review URL: https://codereview.chromium.org/1072613002
 2015-04-08 13:31:27 -07:00
Ojan Vafai
3029d211d7 Fix ink splashes in stocks app. 
https://codereview.chromium.org/1061163002 lost the default
value of stretch for align-items on flex boxes. We used to
have complicated rules where only flex boxes would default to
stretch. Now that we only have flex boxes, we can just make
it the default in RenderStyle.

R=eseidel@chromium.org

Review URL: https://codereview.chromium.org/1076543002
 2015-04-08 12:27:49 -07:00
Eric Seidel
5a8da4db70 Update test expectations 
This test was failing because I changed the url.
The new url is correct.  Sorry for not running the tests
before committing.

https://codereview.chromium.org/1065073002/
https://github.com/domokit/mojo/issues/81
TBR=ojan@chromium.org

Review URL: https://codereview.chromium.org/1075603002
 2015-04-08 12:25:07 -07:00
Tony Gentilcore
05c7de2f4a Disable sky/tests/framework/basic.sky due to issue #81 
TBR=eseidel@chromium.org

Review URL: https://codereview.chromium.org/1063233003
 2015-04-07 17:53:11 -07:00
Ojan Vafai
b9df2edb7d Delete RenderBlockFlow. 
We only ever create RenderParagraphs now. The only non-trivial change here
is making RenderView a RenderFlexibleBox. This required changing custom.sky.
That test was written in a fragile way that behaved differently if we
did multiple layouts. Instead, having it be less racy and only change
values during the test itself.

This also throws a wrench in moving all the layout code to dart
because we can't set the layout manager on the RenderView. Maybe
we need to explicitly let you do so.

R=eseidel@chromium.org

Review URL: https://codereview.chromium.org/1068683002
 2015-04-07 16:59:36 -07:00
Eric Seidel
cb473bbf48 Attempt to de-flake tests/framework/basic.sky 
new Image() is likely to cause the image to try
and load as soon as the underlying Image element
is inserted into the real DOM.

This at least points it at a real image so that
it won't dump 404 response text into the test
output if the image load kicks off before the test
completes.

Example:
http://build.chromium.org/p/client.mojo/builders/Mojo%20Linux%20NaCl/builds/1130/steps/Sky%20tests/logs/stdio

R=ianh@google.com, ojan@chromium.org

Review URL: https://codereview.chromium.org/1065073002
 2015-04-07 15:53:19 -07:00
Eric Seidel
9d26851ecb Fix sky_tool's calling of adb, and shelldb's analyze and stop 
Just silly fixes needed for our 4 copies of our python run script.

R=ianh@google.com

Review URL: https://codereview.chromium.org/1064983003
 2015-04-07 15:15:56 -07:00
Hixie
97ed9fdd7d [Effen] rename RenderNode and WrapperNode (previously know as Element) to SkyNodeWrapper and SkyElementWrapper to avoid confusion with C++ RenderNode objects 
R=eseidel@chromium.org

Review URL: https://codereview.chromium.org/1066093003
 2015-04-07 14:12:32 -07:00
John McCutchan
ee061ddf28 - Rename "nodefer" to "immediate" (gets rid of double negative in "nodefer: false"). 
- Immediate close means that anything pending will be discarded.
- Plumb immediate all the way down to the handle watcher close call.
- When an EventStream is closed because no one is listening for events, close immediately.
- Don't call Dart_NewSendPort with ILLEGAL_PORT in sky embedder.
- Bump DEPS to include fixes for Dart_NewSendPort and profiler signal handler executing after shared object is unloaded.
- Fixes https://github.com/domokit/mojo/issues/79

R=zra@google.com

Review URL: https://codereview.chromium.org/1060193002
 2015-04-07 12:59:58 -07:00
Eric Seidel
e8140cd33f Unbreak widgets_app.dart (by disabling PopupMenu for now) 
Also fix button.dart to include ink_well.dart.

R=ojan@chromium.org

Review URL: https://codereview.chromium.org/1058013003
 2015-04-07 11:17:26 -07:00
Ojan Vafai
970f42b8d7 Remove parsing for display:block/inline-block. 
The default is now column flexboxes, which are almost the
same as blocks.

R=eseidel@chromium.org

Review URL: https://codereview.chromium.org/1060223002
 2015-04-06 19:19:36 -07:00