DEV/flutter_flutter
1
0
Fork 0
mirror of https://github.com/flutter/flutter.git synced 2026-02-20 02:29:02 +08:00
Code Issues Packages Projects Releases Wiki Activity
35,186 Commits 882 Branches 1,069 Tags
Commit Graph

35186 Commits

This Branch
This Branch
All Branches
Author SHA1 Message Date
skia-flutter-autoroll
bfe017dd55 Roll Skia from b83b6bf7174f to e335a0a11aa0 (1 revision) (flutter/engine#52175) 
https://skia.googlesource.com/skia.git/+log/b83b6bf7174f..e335a0a11aa0

2024-04-16 kjlubick@google.com Remove guards for old versions of mac

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC brianosman@google.com,jsimmons@google.com,michaelludwig@google.com,rmistry@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2024-04-16 23:06:48 +00:00
auto-submit[bot]
e3a20e4fb6 Reverts "[Impeller] remove most temporary allocation during polyline generation. (#52131)" (flutter/engine#52177) 
Reverts: flutter/engine#52131
Initiated by: jonahwilliams
Reason for reverting: breaking flutter logo rendering

![image](https://github.com/flutter/engine/assets/8975114/90a6d70f-db22-4684-80f9-1cea3dc21ac5)

Original PR Author: jonahwilliams

Reviewed By: {chinmaygarde}

This change reverts the following previous change:
Part of https://github.com/flutter/flutter/issues/143077

Only allocate into reused arenas instead of allocating a new vector of data. Fixes https://github.com/flutter/flutter/issues/133348

Also moves tessellation logic into the c/tessellator and out of the impeller tessellator. This was necessary to fix a compilation error. introduced by including host_buffer -> allocator -> fml mapping -> window.h include which has a function definition that conflicts with the c tessellator definition.
 2024-04-16 22:55:47 +00:00
skia-flutter-autoroll
ba91beb2e8 Roll Skia from d506a3d526f7 to b83b6bf7174f (2 revisions) (flutter/engine#52173) 
https://skia.googlesource.com/skia.git/+log/d506a3d526f7..b83b6bf7174f

2024-04-16 tangm@microsoft.com Address null colorSpace in PDF Device
2024-04-16 michaelludwig@google.com [graphite] Restructure tracked device cleanup in case its called multiple times

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC brianosman@google.com,jsimmons@google.com,michaelludwig@google.com,rmistry@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2024-04-16 22:10:53 +00:00
Jenn Magder
05201a8018 Migrate FlutterUIPressProxy, ios_context*, rendering_api_selection, and a few other files to ARC (flutter/engine#51633) 
Smart pointers support ARC as of https://github.com/flutter/engine/pull/47612, and the unit tests were migrated in https://github.com/flutter/engine/pull/48162.

Migrate some files from MRC to ARC.  These files do not themselves import any MRC files, only ARC-ified files like `FlutterMetalLayer.h`, making them leaf nodes in the dependency graph of MRC files.  Just doing a few at a time to make the dependency graph manageable, and to easily revert if this causes retain cycles or other memory management issues.

Part of https://github.com/flutter/flutter/issues/137801.

[C++, Objective-C, Java style guides]: https://github.com/flutter/engine/blob/main/CONTRIBUTING.md#style
 2024-04-16 21:45:50 +00:00
skia-flutter-autoroll
0972552b3a Roll Skia from 98dbba281a84 to d506a3d526f7 (2 revisions) (flutter/engine#52170) 
https://skia.googlesource.com/skia.git/+log/98dbba281a84..d506a3d526f7

2024-04-16 jzern@google.com update to libwebp 1.4.0
2024-04-16 johnstiles@google.com Move SkASAN.h to include/private/base.

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC brianosman@google.com,jsimmons@google.com,michaelludwig@google.com,rmistry@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2024-04-16 21:16:03 +00:00
skia-flutter-autoroll
1de3ea26ad Roll Dart SDK from f2464b2892a1 to 57d7cba5bc3d (1 revision) (flutter/engine#52168) 
https://dart.googlesource.com/sdk.git/+log/f2464b2892a1..57d7cba5bc3d

2024-04-16 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com Version 3.5.0-67.0.dev

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/dart-sdk-flutter-engine
Please CC dart-vm-team@google.com,jsimmons@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter Engine: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2024-04-16 20:13:05 +00:00
skia-flutter-autoroll
49e7ab6ba9 Roll Skia from 300741074b41 to 98dbba281a84 (11 revisions) (flutter/engine#52167) 
https://skia.googlesource.com/skia.git/+log/300741074b41..98dbba281a84

2024-04-16 robertphillips@google.com [graphite] Add ImageFilter precompilation to PaintParamsKeyTest
2024-04-16 jsimmons@google.com In the Fuchsia font manager, add the style parameter that is now required by SkFontScanner_FreeType::computeAxisValues
2024-04-16 bungeman@google.com Allow old CoreText to return wrong style
2024-04-16 skia-autoroll@skia-public.iam.gserviceaccount.com Roll vulkan-deps from ea0fb515f594 to 8dc5cb57074c (2 revisions)
2024-04-16 michaelludwig@google.com [graphite] Impl. public image API in Image_Base via copies
2024-04-16 michaelludwig@google.com [graphite] Add PaintParamsKey to pipeline labels and traces
2024-04-16 tangm@microsoft.com Add SkColorSpace to SaveLayerRec
2024-04-16 bungeman@google.com Test variable font style
2024-04-16 bungeman@google.com DirectWrite to vary font style with variation
2024-04-16 bungeman@google.com FreeType to vary font style with variation
2024-04-16 robertphillips@google.com [graphite] Add minimal API to specify precompilation ImageFilters

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC brianosman@google.com,jsimmons@google.com,michaelludwig@google.com,rmistry@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2024-04-16 20:11:25 +00:00
gaaclarke
ed0a9bd410 [Impeller] removes advanced plus blending (flutter/engine#52163) 
Now that https://github.com/flutter/engine/pull/52019 has landed, we
shouldn't need it anymore.

## Pre-launch Checklist

- [x] I read the [Contributor Guide] and followed the process outlined
there for submitting PRs.
- [x] I read the [Tree Hygiene] wiki page, which explains my
responsibilities.
- [x] I read and followed the [Flutter Style Guide] and the [C++,
Objective-C, Java style guides].
- [x] I listed at least one issue that this PR fixes in the description
above.
- [x] I added new tests to check the change I am making or feature I am
adding, or the PR is [test-exempt]. See [testing the engine] for
instructions on writing and running engine tests.
- [x] I updated/added relevant documentation (doc comments with `///`).
- [x] I signed the [CLA].
- [x] All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel
on [Discord].

<!-- Links -->
[Contributor Guide]:
https://github.com/flutter/flutter/wiki/Tree-hygiene#overview
[Tree Hygiene]: https://github.com/flutter/flutter/wiki/Tree-hygiene
[test-exempt]:
https://github.com/flutter/flutter/wiki/Tree-hygiene#tests
[Flutter Style Guide]:
https://github.com/flutter/flutter/wiki/Style-guide-for-Flutter-repo
[C++, Objective-C, Java style guides]:
https://github.com/flutter/engine/blob/main/CONTRIBUTING.md#style
[testing the engine]:
https://github.com/flutter/flutter/wiki/Testing-the-engine
[CLA]: https://cla.developers.google.com/
[flutter/tests]: https://github.com/flutter/tests
[breaking change policy]:
https://github.com/flutter/flutter/wiki/Tree-hygiene#handling-breaking-changes
[Discord]: https://github.com/flutter/flutter/wiki/Chat
 2024-04-16 12:33:21 -07:00
Jonah Williams
e572ff5c6f [Impeller] remove most temporary allocation during polyline generation. (flutter/engine#52131) 
Part of https://github.com/flutter/flutter/issues/143077

Only allocate into reused arenas instead of allocating a new vector of data. Fixes https://github.com/flutter/flutter/issues/133348

Also moves tessellation logic into the c/tessellator and out of the impeller tessellator. This was necessary to fix a compilation error. introduced by including host_buffer -> allocator -> fml mapping -> window.h include which has a function definition that conflicts with the c tessellator definition.
 2024-04-16 18:48:47 +00:00
Jason Simmons
50771f3ad4 Roll reclient, libpng, and zlib (flutter/engine#52072) 
Based on https://github.com/flutter/engine/pull/52067
 2024-04-16 18:31:30 +00:00
Jenn Magder
cd1aa8d667 Only print "gclient sync" warning once during rebase (flutter/engine#52133) 
Skip the "pre-rebase" message since it will also be printed "post-checkout" at the end.

Fixes https://github.com/flutter/flutter/issues/146781

Before this PR:

![rebase](https://github.com/flutter/engine/assets/682784/db7279c7-ca27-4ccf-9f6b-f9c4ad10c20a)

On this PR it's only printed once

![Screenshot 2024-04-15 at 2 06 24 PM](https://github.com/flutter/engine/assets/682784/bc80a6bc-9fd9-447f-b060-18f3a5b05775)

Fixes https://github.com/flutter/flutter/issues/146781
 2024-04-16 18:03:20 +00:00
skia-flutter-autoroll
8454f13b89 Roll Skia from 75083dc8a34c to 300741074b41 (1 revision) (flutter/engine#52158) 
https://skia.googlesource.com/skia.git/+log/75083dc8a34c..300741074b41

2024-04-16 johnstiles@google.com Update libpng to 1.6.43.

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC brianosman@google.com,jsimmons@google.com,michaelludwig@google.com,rmistry@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2024-04-16 16:10:54 +00:00
skia-flutter-autoroll
b23c0faf70 Roll Dart SDK from 99928bb7e8a4 to f2464b2892a1 (1 revision) (flutter/engine#52157) 
https://dart.googlesource.com/sdk.git/+log/99928bb7e8a4..f2464b2892a1

2024-04-16 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com Version 3.5.0-66.0.dev

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/dart-sdk-flutter-engine
Please CC dart-vm-team@google.com,jsimmons@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter Engine: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2024-04-16 16:09:25 +00:00
skia-flutter-autoroll
d3998edba0 Roll Skia from 429ec245f4e2 to 75083dc8a34c (1 revision) (flutter/engine#52155) 
https://skia.googlesource.com/skia.git/+log/429ec245f4e2..75083dc8a34c

2024-04-16 jcgregorio@google.com Remove Test-Win10-Clang-RUBYR5-GPU-RadeonVega6-x86_64-Debug-All-Direct3D also.

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC brianosman@google.com,jsimmons@google.com,michaelludwig@google.com,rmistry@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2024-04-16 13:58:23 +00:00
skia-flutter-autoroll
19c915dfe5 Roll Dart SDK from cb0c34389d90 to 99928bb7e8a4 (1 revision) (flutter/engine#52154) 
https://dart.googlesource.com/sdk.git/+log/cb0c34389d90..99928bb7e8a4

2024-04-16 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com Version 3.5.0-65.0.dev

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/dart-sdk-flutter-engine
Please CC dart-vm-team@google.com,jsimmons@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter Engine: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2024-04-16 11:48:14 +00:00
skia-flutter-autoroll
e471aaf1a3 Roll Skia from 8013b7f1dcd3 to 429ec245f4e2 (1 revision) (flutter/engine#52153) 
https://skia.googlesource.com/skia.git/+log/8013b7f1dcd3..429ec245f4e2

2024-04-16 skia-autoroll@skia-public.iam.gserviceaccount.com Roll SK Tool from 80097301710b to e7f4512b2810

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC brianosman@google.com,jsimmons@google.com,michaelludwig@google.com,rmistry@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2024-04-16 10:34:28 +00:00
skia-flutter-autoroll
369dcf8e4f Roll Dart SDK from 7d02f18b8a84 to cb0c34389d90 (1 revision) (flutter/engine#52151) 
https://dart.googlesource.com/sdk.git/+log/7d02f18b8a84..cb0c34389d90

2024-04-16 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com Version 3.5.0-64.0.dev

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/dart-sdk-flutter-engine
Please CC dart-vm-team@google.com,jsimmons@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter Engine: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2024-04-16 07:58:22 +00:00
skia-flutter-autoroll
f020164efa Roll Skia from 50ac1117f159 to 8013b7f1dcd3 (5 revisions) (flutter/engine#52149) 
https://skia.googlesource.com/skia.git/+log/50ac1117f159..8013b7f1dcd3

2024-04-16 skia-autoroll@skia-public.iam.gserviceaccount.com Roll Dawn from f20a53466bc2 to 4cb74f447cb7 (21 revisions)
2024-04-16 skia-autoroll@skia-public.iam.gserviceaccount.com Roll vulkan-deps from ec0c320a8ca1 to ea0fb515f594 (8 revisions)
2024-04-16 skia-autoroll@skia-public.iam.gserviceaccount.com Roll Skia Infra from f184d1bfa242 to 80097301710b (6 revisions)
2024-04-16 sharaks@google.com Merge 8 release notes into RELEASE_NOTES.md
2024-04-16 sharaks@google.com Update Skia milestone to 126

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC brianosman@google.com,chinmaygarde@google.com,michaelludwig@google.com,rmistry@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2024-04-16 06:54:27 +00:00
dependabot[bot]
0cca5f3822 Bump google/osv-scanner-action from 1.6.2.pre.beta1 to 1.7.1 (flutter/engine#52147) 
Bumps [google/osv-scanner-action](https://github.com/google/osv-scanner-action) from 1.6.2.pre.beta1 to 1.7.1.
<details>
<summary>Release notes</summary>
<p><em>Sourced from <a href="https://github.com/google/osv-scanner-action/releases">google/osv-scanner-action's releases</a>.</em></p>
<blockquote>
<h2>v1.7.1</h2>
<p>First full release of osv-scanner, currently using v1.7.1 of osv-scanner. See <a href="https://github.com/google/osv-scanner-action/blob/main/README.md">README.md</a> or <a href="https://google.github.io/osv-scanner/github-action/">documentation</a> for usage instructions.</p>
</blockquote>
</details>
<details>
<summary>Commits</summary>
<ul>
<li><a href="1f1242919d"><code>1f12429</code></a> Merge pull request <a href="https://redirect.github.com/google/osv-scanner-action/issues/4">#4</a> from google/update-to-v1.7.1</li>
<li><a href="5c2a8dd5ce"><code>5c2a8dd</code></a> Update to v1.7.1</li>
<li><a href="c94002860c"><code>c940028</code></a> Merge pull request <a href="https://redirect.github.com/google/osv-scanner-action/issues/3">#3</a> from google/update-to-v.1.7.0</li>
<li><a href="604d5422a4"><code>604d542</code></a> Add exit code</li>
<li><a href="d878ed5134"><code>d878ed5</code></a> Add error troubleshotting step</li>
<li><a href="fcd6c0a9e3"><code>fcd6c0a</code></a> v1.7.0-beta1</li>
<li>See full diff in <a href="https://github.com/google/osv-scanner-action/compare/v1.6.2-beta1...v1.7.1">compare view</a></li>
</ul>
</details>
<br />

[![Dependabot compatibility score](https://dependabot-badges.githubapp.com/badges/compatibility_score?dependency-name=google/osv-scanner-action&package-manager=github_actions&previous-version=1.6.2.pre.beta1&new-version=1.7.1)](https://docs.github.com/en/github/managing-security-vulnerabilities/about-dependabot-security-updates#about-compatibility-scores)

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting `@dependabot rebase`.

---

<details>
<summary>Dependabot commands and options</summary>
<br />

You can trigger Dependabot actions by commenting on this PR:
- `@dependabot rebase` will rebase this PR
- `@dependabot recreate` will recreate this PR, overwriting any edits that have been made to it
- `@dependabot merge` will merge this PR after your CI passes on it
- `@dependabot squash and merge` will squash and merge this PR after your CI passes on it
- `@dependabot cancel merge` will cancel a previously requested merge and block automerging
- `@dependabot reopen` will reopen this PR if it is closed
- `@dependabot close` will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
- `@dependabot show <dependency name> ignore conditions` will show all of the ignore conditions of the specified dependency
- `@dependabot ignore this major version` will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
- `@dependabot ignore this minor version` will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
- `@dependabot ignore this dependency` will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)

</details>
 2024-04-16 06:10:14 +00:00
Jenn Magder
5f95d3b108 Migrate vsync_waiter_ios to ARC (flutter/engine#52104) 
Smart pointers support ARC as of https://github.com/flutter/engine/pull/47612, and the unit tests were migrated in https://github.com/flutter/engine/pull/48162.

Migrate `vsync_waiter_ios`  from MRC to ARC.

Part of https://github.com/flutter/flutter/issues/137801.

[C++, Objective-C, Java style guides]: https://github.com/flutter/engine/blob/main/CONTRIBUTING.md#style
 2024-04-16 06:01:08 +00:00
skia-flutter-autoroll
7c5eccfd96 Roll Skia from b159229f2174 to 50ac1117f159 (1 revision) (flutter/engine#52146) 
https://skia.googlesource.com/skia.git/+log/b159229f2174..50ac1117f159

2024-04-16 skia-autoroll@skia-public.iam.gserviceaccount.com Roll SwiftShader from 62c59c41e194 to 1eaac56def92 (1 revision)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC brianosman@google.com,chinmaygarde@google.com,michaelludwig@google.com,rmistry@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2024-04-16 05:59:52 +00:00
skia-flutter-autoroll
7037278acc Roll Dart SDK from 5f03197b9992 to 7d02f18b8a84 (2 revisions) (flutter/engine#52145) 
https://dart.googlesource.com/sdk.git/+log/5f03197b9992..7d02f18b8a84

2024-04-16 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com Version 3.5.0-63.0.dev
2024-04-15 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com Version 3.5.0-62.0.dev

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/dart-sdk-flutter-engine
Please CC chinmaygarde@google.com,dart-vm-team@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter Engine: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2024-04-16 04:04:30 +00:00
gaaclarke
e359708723 Relands "[Impeller] moved to bgra10_xr (#52019)" (flutter/engine#52142) 
relands https://github.com/flutter/engine/pull/52019

Patch addresses the compilation problem noted in https://github.com/flutter/engine/pull/52019#issuecomment-2058006113

[C++, Objective-C, Java style guides]: https://github.com/flutter/engine/blob/main/CONTRIBUTING.md#style
 2024-04-16 00:59:09 +00:00
skia-flutter-autoroll
a670454a01 Roll Skia from f6a2a2af83f1 to b159229f2174 (1 revision) (flutter/engine#52143) 
https://skia.googlesource.com/skia.git/+log/f6a2a2af83f1..b159229f2174

2024-04-15 kjlubick@google.com Remove old, private SkMultiPictureDocument

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC brianosman@google.com,chinmaygarde@google.com,michaelludwig@google.com,rmistry@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2024-04-16 00:59:07 +00:00
Chinmay Garde
7f416b5b79 [Impeller] Update the readme to reflect current guidance on how to try Impeller. (flutter/engine#52135) 2024-04-16 00:10:05 +00:00
Jonah Williams
9c212d5d0d [iOS] allow enabling asserts from Plist. (flutter/engine#52069) 
Part of https://github.com/flutter/flutter/issues/145729 .

I don't believe (or wasn't able to find ) if there is a way to specify dart-vm flags from an iOS application. Once its installed, the tool provided process args won't work. By allowing this to be specified in the Plist, developers can ensure the value persists for subsequent launches.
 2024-04-16 00:06:05 +00:00
skia-flutter-autoroll
d3232cba08 Roll Dart SDK from 3c2376cb9850 to 5f03197b9992 (5 revisions) (flutter/engine#52134) 
https://dart.googlesource.com/sdk.git/+log/3c2376cb9850..5f03197b9992

2024-04-15 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com Version 3.5.0-61.0.dev
2024-04-15 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com Version 3.5.0-60.0.dev
2024-04-15 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com Version 3.5.0-59.0.dev
2024-04-13 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com Version 3.5.0-58.0.dev
2024-04-13 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com Version 3.5.0-57.0.dev

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/dart-sdk-flutter-engine
Please CC chinmaygarde@google.com,dart-vm-team@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter Engine: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2024-04-16 00:00:00 +00:00
skia-flutter-autoroll
c3edd7201c Roll Skia from 0b5df0201734 to f6a2a2af83f1 (2 revisions) (flutter/engine#52136) 
https://skia.googlesource.com/skia.git/+log/0b5df0201734..f6a2a2af83f1

2024-04-15 skia-autoroll@skia-public.iam.gserviceaccount.com Roll skcms from 934b734ed72a to 9478a634ff6d (1 revision)
2024-04-15 fmalita@google.com [skottie] Text preshape experiment

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC brianosman@google.com,chinmaygarde@google.com,michaelludwig@google.com,rmistry@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2024-04-15 23:59:57 +00:00
Jenn Magder
2d3cce14a1 Migrate FlutterDartVMServicePublisher to ARC (flutter/engine#52081) 
Smart pointers support ARC as of https://github.com/flutter/engine/pull/47612, and the unit tests were migrated in https://github.com/flutter/engine/pull/48162.

Migrate `FlutterDartVMServicePublisher` from MRC to ARC.  I validated `flutter attach` works on this engine PR, so the VM service URL is being advertised and the tool is discovering it.

Part of https://github.com/flutter/flutter/issues/137801.
 2024-04-15 23:55:27 +00:00
auto-submit[bot]
b4bad7f256 Reverts "[Impeller] moved to bgra10_xr (#52019)" (flutter/engine#52140) 
Reverts: flutter/engine#52019
Initiated by: jonahwilliams
Reason for reverting: I believe the tree failures are due to changes in the build configuration this file introduced.
Original PR Author: gaaclarke

Reviewed By: {jonahwilliams}

This change reverts the following previous change:
fixes https://github.com/flutter/flutter/issues/145933

This required that we moved the golden image tests to arm64 since the wide gamut tests would now require BGRA10_XR and that's only available to arm64.

tests: in framework repo https://github.com/flutter/flutter/tree/master/dev/integration_tests/wide_gamut_test. There was a test added to that suite specifically for this case when we turned off BGRA10_XR the first time.

This has a dependency on https://github.com/flutter/engine/pull/51998 which includes the necessary skia change.

[C++, Objective-C, Java style guides]: https://github.com/flutter/engine/blob/main/CONTRIBUTING.md#style
 2024-04-15 22:50:46 +00:00
skia-flutter-autoroll
f4a1f31b92 Roll Skia from d27e288efd54 to 0b5df0201734 (1 revision) (flutter/engine#52132) 
https://skia.googlesource.com/skia.git/+log/d27e288efd54..0b5df0201734

2024-04-15 jvanverth@google.com Reland "Add GN variable to disable iOS
signing"

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC
brianosman@google.com,chinmaygarde@google.com,michaelludwig@google.com,rmistry@google.com
on the revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter:
https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2024-04-15 14:14:05 -07:00
skia-flutter-autoroll
e27ec99b0c Roll Skia from 0fe107da5a4e to d27e288efd54 (6 revisions) (flutter/engine#52130) 
https://skia.googlesource.com/skia.git/+log/0fe107da5a4e..d27e288efd54

2024-04-15 egdaniel@google.com Be more consistent in nanobench across Ganesh and Graphite.
2024-04-15 michaelludwig@google.com Update libwebp version to match chromium's
2024-04-15 jcgregorio@google.com Revert "Roll ANGLE from 66bc9cfa0014 to 9bae58594634 (4 revisions)"
2024-04-15 kjlubick@google.com Fail SkParagraph GMs gracefully when unicode fails to be created
2024-04-15 jcgregorio@google.com Remove Test-Win10-Clang-RUBYR5-GPU-RadeonVega6-x86_64-Release-All-Direct3D from the tree for now.
2024-04-15 jamesgk@google.com [graphite] Analytic blur for rects

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC brianosman@google.com,chinmaygarde@google.com,michaelludwig@google.com,rmistry@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2024-04-15 19:53:20 +00:00
gaaclarke
47ad73b01c [Impeller] moved to bgra10_xr (flutter/engine#52019) 
fixes https://github.com/flutter/flutter/issues/145933

This required that we moved the golden image tests to arm64 since the wide gamut tests would now require BGRA10_XR and that's only available to arm64.

tests: in framework repo https://github.com/flutter/flutter/tree/master/dev/integration_tests/wide_gamut_test. There was a test added to that suite specifically for this case when we turned off BGRA10_XR the first time.

This has a dependency on https://github.com/flutter/engine/pull/51998 which includes the necessary skia change.

[C++, Objective-C, Java style guides]: https://github.com/flutter/engine/blob/main/CONTRIBUTING.md#style
 2024-04-15 18:03:51 +00:00
skia-flutter-autoroll
6f2a94ded6 Roll Skia from 9e20a146c024 to 0fe107da5a4e (33 revisions) (flutter/engine#52129) 
Roll Skia from 9e20a146c024 to 0fe107da5a4e (33 revisions)

https://skia.googlesource.com/skia.git/+log/9e20a146c024..0fe107da5a4e

2024-04-15 skia-autoroll@skia-public.iam.gserviceaccount.com Roll vulkan-deps from 04aa78e8dbcb to ec0c320a8ca1 (2 revisions)
2024-04-15 brianosman@google.com Simplify special path type tracking
2024-04-15 jvanverth@google.com Revert "Add GN variable to disable iOS signing"
2024-04-15 kjlubick@google.com fix guard for skunicode
2024-04-15 robertphillips@google.com [graphite] Calve off PrecompileCombinations into its own helper
2024-04-15 kjlubick@google.com Expose the getClientICUData() to ParagraphBuilder
2024-04-15 bungeman@google.com Add job to test with checked-in FreeType
2024-04-15 kjlubick@google.com Fix up mac-related modules
2024-04-15 skia-autoroll@skia-public.iam.gserviceaccount.com Roll SK Tool from f184d1bfa242 to 80e2cdd73b81
2024-04-15 skia-autoroll@skia-public.iam.gserviceaccount.com Roll Skia Infra from bae2b98850ac to f184d1bfa242 (7 revisions)
2024-04-15 skia-autoroll@skia-public.iam.gserviceaccount.com Roll Dawn from 0e14373fbbeb to f20a53466bc2 (10 revisions)
2024-04-14 skia-autoroll@skia-public.iam.gserviceaccount.com Roll vulkan-deps from 5171f7f9892a to 04aa78e8dbcb (1 revision)
2024-04-14 skia-autoroll@skia-public.iam.gserviceaccount.com Roll vulkan-deps from 46248e60c4fa to 5171f7f9892a (1 revision)
2024-04-13 jcgregorio@google.com Revert "Temporarily remove iOS bots from CQ."
2024-04-13 skia-autoroll@skia-public.iam.gserviceaccount.com Roll vulkan-deps from 7922b393e32b to 46248e60c4fa (2 revisions)
2024-04-13 michaelludwig@google.com [graphite] Add Image::Copy to handle both blit and draw copies
2024-04-13 skia-autoroll@skia-public.iam.gserviceaccount.com Manual roll ANGLE from e41286e1092c to 5e790bfb16e8 (6 revisions)
2024-04-12 jvanverth@google.com [graphite] Move DrawAtlasMgr to PathAtlas.
2024-04-12 michaelludwig@google.com [graphite] Add CopyAsDraw helper to Image_Base
2024-04-12 michaelludwig@google.com [graphite] Add Device::isScratchDevice() helper
2024-04-12 michaelludwig@google.com [graphite] Add validation asserts to Device/Recorder flushing
2024-04-12 michaelludwig@google.com Reland "[graphite] Start with kDiscard load op in DrawContext; use clear op for floating-point textures"
2024-04-12 michaelludwig@google.com [graphite] Remove unique ID from Image[_YUVA] ctor, rename MakeView
2024-04-12 jvanverth@google.com Add GN variable to disable iOS signing
2024-04-12 skia-autoroll@skia-public.iam.gserviceaccount.com Manual roll Dawn from a79a81394ea6 to 0e14373fbbeb (26 revisions)
2024-04-12 skia-autoroll@skia-public.iam.gserviceaccount.com Roll vulkan-deps from f8fa42b1fbea to 7922b393e32b (10 revisions)
2024-04-12 skia-autoroll@skia-public.iam.gserviceaccount.com Roll SK Tool from cf3b51b7e14e to c150177839d1
2024-04-12 ccameron@chromium.org SkICC: Improve tonemapping precision
2024-04-12 fmalita@google.com [skottie wasm] Fix inline font decoding
2024-04-12 lehoangquyen@chromium.org Reland x2 "Graphite/Dawn: Eliminate Device::Tick() usages."
2024-04-12 kjlubick@google.com Remove SKCMS_REPLACE_IN_GOOGLE3_COMPATIBLE_WITH
2024-04-12 brianosman@google.com Another NaN guard in SkConic support code
2024-04-12 brianosman@google.com Guard against wild conics while stroking

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC brianosman@google.com,chinmaygarde@google.com,michaelludwig@google.com,rmistry@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

...
 2024-04-15 18:03:48 +00:00
Jonah Williams
a06a893374 [Impeller] Use Wang's formula for quad/cubic subdivision. (flutter/engine#52079) 
Use a faster method to compute the number of subdivisions of quadradic and cubic curves. Unlike the adaptive subdivison we use this may give us more line segments around straight-ish parts of a curve ... but who cares! the rasterizer can handle it. This is enough to lop off about 2ms from the animated tessellation benchmark (5.5 to 3.5 on a Pixel 7), and there are some additional savings we can book by removing some of the incidental allocations. This part will be done in a follow up (https://github.com/flutter/engine/pull/52078).

### Before

![image](https://github.com/flutter/engine/assets/8975114/8dc45012-3999-4598-ac3b-713e09d5a31f)

### After

![image](https://github.com/flutter/engine/assets/8975114/8a90636f-9698-46e6-bd3f-2f47c8abdbba)

From looking at the proproptions I think this is in the 3x-5x faster range.

Code originally taken from https://github.com/google/skia/blob/main/src/gpu/tessellate/WangsFormula.h
 2024-04-15 18:02:07 +00:00
Jonah Williams
fa75cef630 [Impeller] organize shaders a bit, make filter shaders use same vertex source. (flutter/engine#52113) 
yuv_to_rgb_filter.vert, srgb_to_linear_filter.vert, linear_to_srgb_filter.vert, color_matrix_color_filter.vert were all indentical, so I replaced them with a single shader called ... filter.vert!
 2024-04-15 18:02:05 +00:00
skia-flutter-autoroll
45e3c70690 Roll Dart SDK from ac31be3c8546 to 3c2376cb9850 (1 revision) (flutter/engine#52095) 
https://dart.googlesource.com/sdk.git/+log/ac31be3c8546..3c2376cb9850

2024-04-12 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com Version 3.5.0-56.0.dev

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/dart-sdk-flutter-engine
Please CC chinmaygarde@google.com,dart-vm-team@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter Engine: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2024-04-15 17:58:07 +00:00
Jenn Magder
31f79201a8 Migrate FlutterCallbackCache and FlutterKeyboardManager to ARC (flutter/engine#51983) 
Smart pointers support ARC as of https://github.com/flutter/engine/pull/47612, and the unit tests were migrated in https://github.com/flutter/engine/pull/48162.

Migrate`FlutterCallbackCache` and `FlutterKeyboardManager` from MRC to ARC.  These files do not themselves import any MRC files, making them leaf nodes in the dependency graph of MRC files.  

Doing a few at a time to make the dependency graph manageable, and to easily revert if this causes retain cycles or other memory management issues.

Part of https://github.com/flutter/flutter/issues/137801.
 2024-04-15 17:58:05 +00:00
Jason Simmons
595f6bd256 Roll buildroot and set ios_use_simulator variable used by Skia GN scripts (flutter/engine#52101) 2024-04-15 17:54:04 +00:00
Jonah Williams
0951e43921 [scenarios] test disabling surface clear. (flutter/engine#52128) 
I suspect that the change to clear the surface is the result of the
scenario app instability. just a guess: the screenshots looks like we're
missing the platform view. maybe the clearing of the surface is causing
an extra frame to be pushed. That frame is getting picked up in the
golden due to a race condition that is hard to hit locally


Testing disabling of this functionality in the golden test. If this pass
a real fix involves some sort of hook into the rendering to verify it
has fully completed before screenshotting.
 2024-04-15 10:25:20 -07:00
skia-flutter-autoroll
c047d488db Roll Dart SDK from 3d13dbfb3284 to ac31be3c8546 (8 revisions) (flutter/engine#52084) 
https://dart.googlesource.com/sdk.git/+log/3d13dbfb3284..ac31be3c8546

2024-04-12 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com Version 3.5.0-55.0.dev
2024-04-12 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com Version 3.5.0-54.0.dev
2024-04-12 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com Version 3.5.0-53.0.dev
2024-04-12 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com Version 3.5.0-52.0.dev
2024-04-11 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com Version 3.5.0-51.0.dev
2024-04-11 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com Version 3.5.0-50.0.dev
2024-04-11 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com Version 3.5.0-49.0.dev
2024-04-11 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com Version 3.5.0-48.0.dev

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/dart-sdk-flutter-engine
Please CC chinmaygarde@google.com,dart-vm-team@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter Engine: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2024-04-12 21:54:04 +00:00
skia-flutter-autoroll
69e1864dab Roll Skia from 761f6f7f6250 to 9e20a146c024 (7 revisions) (flutter/engine#52085) 
https://skia.googlesource.com/skia.git/+log/761f6f7f6250..9e20a146c024

2024-04-12 jcgregorio@google.com Update iOS Certs for 2024.
2024-04-12 johnstiles@google.com Fix premature loading of slide image.
2024-04-12 robertphillips@google.com [Graphite] Add BlurShader to Precompile system
2024-04-12 robertphillips@google.com Update OpenGL ES Interface autogeneration for GL_ARB_invalidate_subdata
2024-04-12 kjlubick@google.com Reland "Migrate SkParagraph's tests etc to provide SkUnicode"
2024-04-12 robertphillips@google.com [graphite] Allow PrecompileImageShader to skip cubic filtering combinations
2024-04-12 bungeman@google.com Roll HarfBuzz from 4cfc6d8e to c053e8f2 (342 commits)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC brianosman@google.com,chinmaygarde@google.com,rmistry@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2024-04-12 21:50:31 +00:00
Loïc Sharma
c17e21a794 [Windows] Refactor client wrapper to prepare for multi-view (flutter/engine#52073) 
_This is a refactoring with no semantic changes. No new public APIs are introduced by this change._

In the future, a new constructor will be added to `FlutterViewController` to allow it to use an existing `std::shared_ptr<FlutterEngine>` to create the view controller. This updates `FlutterViewController` to store a `std::shared_ptr` and other minor tweaks.

For context, we plan to not land the new multi-window `FlutterViewController` constructor until Window's multi-window support is productionized. Until then, we will maintain a [patch](https://github.com/flutter/flutter/issues/143767#issuecomment-2050741185) for folks that want to experiment with multi-window. This change makes that patch as small as possible.

Design doc: [flutter.dev/go/desktop-multi-view-runner-apis](https://flutter.dev/go/desktop-multi-view-runner-apis)

Part of https://github.com/flutter/flutter/issues/143767
Part of https://github.com/flutter/flutter/issues/142845

[C++, Objective-C, Java style guides]: https://github.com/flutter/engine/blob/main/CONTRIBUTING.md#style
 2024-04-12 21:45:30 +00:00
skia-flutter-autoroll
f41a4653e5 Roll Skia from 5101cbe5a6bb to 761f6f7f6250 (1 revision) (flutter/engine#52076) 
https://skia.googlesource.com/skia.git/+log/5101cbe5a6bb..761f6f7f6250

2024-04-12 jcgregorio@google.com Temporarily remove iOS bots from CQ.

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC brianosman@google.com,chinmaygarde@google.com,rmistry@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2024-04-12 20:16:24 +00:00
Jenn Magder
30569dc07a Migrate FlutterEmbedderKeyResponder to ARC (flutter/engine#52048) 
Smart pointers support ARC as of https://github.com/flutter/engine/pull/47612, and the unit tests were migrated in https://github.com/flutter/engine/pull/48162.

Migrate `FlutterEmbedderKeyResponder` from MRC to ARC.  Clean up some header imports which made this seem like it depended on not-yet-migrated MRC files.

Part of https://github.com/flutter/flutter/issues/137801.
 2024-04-12 20:09:04 +00:00
Jason Simmons
ad5a851612 Fix the Dart language version for Fuchsia's build of the args package (flutter/engine#52083) 
This is required for the next Dart roll (see
https://github.com/flutter/engine/pull/52077)
 2024-04-12 12:39:14 -07:00
Jenn Magder
f2152f1e0d Update iOS KeyCodeMap dictionary literal and migrate to ARC (flutter/engine#51981) 
Framework template updated in https://github.com/flutter/flutter/pull/146481.  See [gen_keycodes README](https://github.com/flutter/flutter/tree/master/dev/tools/gen_keycodes ) for details.

Fixes https://github.com/flutter/flutter/issues/146480 `-Wobjc-redundant-literal-use` error.

Note `-Wobjc-redundant-literal-use` is already on for clang-tidy 
3e5e40c10a/.clang-tidy (L13) but in this case it's only true triggered when the file is compiled with ARC.  When I migrated this file to ARC as part of https://github.com/flutter/flutter/issues/137801, it triggered the error.
 2024-04-11 23:59:24 +00:00
Brandon DeRosier
d09d3d5ecb [Impeller] Only set the stencil ref for StC draws. (flutter/engine#52006) 
Another clean-up patch following
https://github.com/flutter/engine/pull/51992.

Also, don't rely on Entity tracked stencil height for clip coverage
tracking.
 2024-04-11 16:42:25 -07:00
Chinmay Garde
83c02bfc38 Remove intermediate APKs during build process. (flutter/engine#52071) 
Found that these intermediates added a non-trivial amount of artifacts to the out directory. Folks run our of space because of the size of intermediates sometimes and this just exacerbates that problem.
 2024-04-11 23:21:11 +00:00
Jason Simmons
6674f823cf Clear the surface to transparent black when creating a PlatformViewWrapper (flutter/engine#52047) 
Without this, an opaque black surface may briefly flash onscreen when the platform view is shown (see internal issue b/332379081)

This matches the behavior used before to the introduction of PlatformViewRenderTarget in b3945f7706

That commit moved the clearing of the surface into SurfaceTexturePlatformViewRenderTarget.  But that caused surface clearing to happen in scenarios where there was no PlatformViewWrapper, resulting in the issue seen in https://github.com/flutter/flutter/issues/141068

Later the surface clearing was removed from SurfaceTexturePlatformViewRenderTarget, causing the flashing black screen.
 2024-04-11 22:05:33 +00:00