DEV/flutter_flutter
1
0
Fork 0
mirror of https://github.com/flutter/flutter.git synced 2026-02-20 02:29:02 +08:00
Code Issues Packages Projects Releases Wiki Activity

Only print "gclient sync" warning once during rebase (flutter/engine#52133)

Browse Source 
Skip the "pre-rebase" message since it will also be printed "post-checkout" at the end.

Fixes https://github.com/flutter/flutter/issues/146781

Before this PR:

![rebase](https://github.com/flutter/engine/assets/682784/db7279c7-ca27-4ccf-9f6b-f9c4ad10c20a)

On this PR it's only printed once

![Screenshot 2024-04-15 at 2 06 24 PM](https://github.com/flutter/engine/assets/682784/bc80a6bc-9fd9-447f-b060-18f3a5b05775)

Fixes https://github.com/flutter/flutter/issues/146781
This commit is contained in:
Jenn Magder 2024-04-16 11:03:20 -07:00 committed by GitHub
parent 8454f13b89
commit cd1aa8d667
1 changed files with 3 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

3
engine/src/flutter/tools/githooks/lib/src/messages.dart
View File

@ -10,6 +10,9 @@ const String _reset = '\x1B[0m';
/// Prints a reminder to stdout to run `gclient sync -D`. Uses colors when
/// stdout supports ANSI escape codes.
void printGclientSyncReminder(String command) {
if (command == 'pre-rebase') {
return;
}
final String prefix = io.stdout.supportsAnsiEscapes ? _redBoldUnderline : '';
final String postfix = io.stdout.supportsAnsiEscapes ? _reset : '';
io.stderr.writeln('$command: The engine source tree has been updated.');