20087 Commits

Author SHA1 Message Date
Chris Bracken
fd17e0846b
Fix linter errors in mock_engine (#21102)
Make a single-param ctor explicit in order to prevent surprising
implicit conversions.

Add a check for zero message-size and don't malloc/memcpy the incoming
message in those cases.

Add braces where they were missing.
2020-09-11 10:27:00 -07:00
skia-flutter-autoroll
223bf45e8e
Roll Fuchsia Mac SDK from b9rM1nBK1... to ggoll70iR... (#21101) 2020-09-11 10:10:01 -07:00
skia-flutter-autoroll
540dd230cf
Roll Dart SDK from 14f1940f537e to 1c887123b92c (1 revision) (#21093) 2020-09-11 09:55:01 -07:00
xster
397b6c6a93
re-enable scenario tests on iOS (#21088) 2020-09-11 09:21:37 -07:00
Chris Bracken
36f7f3ca82
Copyright header hygiene improvements (#21089)
Add copyright headers in a few files where they were missing.

Trim trailing blank comment line where present, for consistency with
other engine code.

Use the standard libtxt copyright header in one file where it differed
(extra (C) and comma compared to other files in libtxt).

This also amends tools/const_finder/test/const_finder_test.dart to look
for a const an additional four lines down to account for the copyright
header added to the test fixture.
2020-09-11 08:55:37 -07:00
skia-flutter-autoroll
78f968e317
Roll Skia from bbe69951b416 to 6518d77a2200 (1 revision) (#21096) 2020-09-11 08:10:02 -07:00
skia-flutter-autoroll
983b0ef164
Roll Dart SDK from 1abce6d054ad to 14f1940f537e (1 revision) (#21092) 2020-09-11 02:05:01 -07:00
skia-flutter-autoroll
a0bd862cc0
Roll Fuchsia Linux SDK from l8baHga4c... to XIejclW2X... (#21086) 2020-09-11 00:25:01 -07:00
skia-flutter-autoroll
63aec780b3
Roll Skia from 9d6f955f52e9 to bbe69951b416 (4 revisions) (#21090) 2020-09-11 00:05:02 -07:00
Chris Bracken
bdaac368f8
Re-enable (most) iOS Scenarios tests (#21087)
This re-enables the iOS Scenarios tests which have been flaky in the
last couple days.

Disabling two tests where we've seen the flakes:
* AppLifecycleTests testFlutterViewControllerDetachingSendsApplicationLifecycle
* FlutterViewControllerInitialRouteTest testSettingInitialRoute

This reverts commit 0c6c265a6f38bcacf551690a8fc8f78bb4f2c285.
2020-09-10 22:57:56 -07:00
skia-flutter-autoroll
7865174914
Roll Skia from 0b6bf1c9668e to 9d6f955f52e9 (8 revisions) (#21085) 2020-09-10 22:45:02 -07:00
skia-flutter-autoroll
67bfa7e133
Roll Dart SDK from 72393cc698da to 1abce6d054ad (3 revisions) (#21083)
https://dart.googlesource.com/sdk.git/+log/72393cc698da..1abce6d054ad

2020-09-11 dart-luci-ci-builder@dart-ci.iam.gserviceaccount.com Version 2.10.0-115.0.dev
2020-09-10 dart-luci-ci-builder@dart-ci.iam.gserviceaccount.com Version 2.10.0-114.0.dev
2020-09-10 dart-luci-ci-builder@dart-ci.iam.gserviceaccount.com Version 2.10.0-113.0.dev

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/dart-sdk-flutter-engine
Please CC dart-vm-team@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md
2020-09-10 21:37:36 -07:00
stuartmorgan
51d6502e13
Minor windows.h cleanup (#21082)
- Standardize on lowercase for windows.h
- Don't define NOMINMAX before including windows.h in (some) public
  wrapper headers, since it causes a warning when combined with setting
  NOMINMAX at the build level, which is the more robust way to avoid
  issues with min/max and windows.h
2020-09-10 21:11:07 -07:00
stuartmorgan
4eb069fe20
Remove deprecated methods from FlutterViewController (#21081)
The template now uses the FlutterEngine versions.
2020-09-10 21:10:28 -07:00
stuartmorgan
83cc9230c4
Clean up deprecated EncodableValue code (#20981)
Removes the older pointer-based versions of APIs taking EncodableValues for which there are now reference-based versions.
2020-09-10 21:08:52 -07:00
xster
216a1ab64d
add back a line to build host for scenario tests (#21076) 2020-09-10 21:05:03 -07:00
skia-flutter-autoroll
c7480be15d
Roll Skia from fb5e0ebef07c to 0b6bf1c9668e (2 revisions) (#21074)
https://skia.googlesource.com/skia.git/+log/fb5e0ebef07c..0b6bf1c9668e

2020-09-10 skia-autoroll@skia-public.iam.gserviceaccount.com Roll dawn from 0a1061da0c7f to 87f25134a8c1 (7 revisions)
2020-09-10 bsalomon@google.com Revert "Temporary hack to force text texture index varying to be float."

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC reed@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md
2020-09-10 21:03:49 -07:00
skia-flutter-autoroll
a168416c8c
Roll Fuchsia Mac SDK from 5o9onBKYd... to b9rM1nBK1... (#21079)
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/fuchsia-mac-sdk-flutter-engine
Please CC jsimmons@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md
2020-09-10 21:03:31 -07:00
chunhtai
833c6a2e00
Implement browser history class for router widget (#20794) 2020-09-10 21:00:02 -07:00
Chris Bracken
0c6c265a6f
Disable iOS ScenariosTests suite (#21080)
This disables the macOS Scenarios app tests until a fix for the current
flakiness is found.

This also reverts commit 55d447a1c3e124e4b1ae6c8a1230808412657a85 where
one test was previously disabled. However, another started failing soon
after, so instead we disable the whole suite here.
2020-09-10 19:50:03 -07:00
Chris Bracken
55d447a1c3
Disable a flaky Scenarios test (#21075)
This disables the macOS Scenarios app test
testFlutterViewControllerDetachingSendsApplicationLifecycle
until a fix for the flakiness is found.

Related issue: https://github.com/flutter/flutter/issues/61620
2020-09-10 13:21:17 -07:00
skia-flutter-autoroll
c88430629a
Roll Skia from 3d41d509a6a9 to fb5e0ebef07c (1 revision) (#21072) 2020-09-10 09:25:03 -07:00
Damian Wrobel
e831433a20
Add missing <cstring> header (#21069)
Fixes the following compilation errors:

../../flutter/shell/platform/linux/fl_value.cc:267:3: error: use of undeclared identifier 'memcpy'
  memcpy(self->values, data, sizeof(uint8_t) * data_length);
  ^
../../flutter/shell/platform/linux/fl_value.cc:284:3: error: use of undeclared identifier 'memcpy'
  memcpy(self->values, data, sizeof(int32_t) * data_length);
  ^
../../flutter/shell/platform/linux/fl_value.cc:294:3: error: use of undeclared identifier 'memcpy'
  memcpy(self->values, data, sizeof(int64_t) * data_length);
  ^
../../flutter/shell/platform/linux/fl_value.cc:304:3: error: use of undeclared identifier 'memcpy'
  memcpy(self->values, data, sizeof(double) * data_length);
  ^

../../flutter/shell/platform/linux/fl_string_codec.cc:29:28: error: use of undeclared identifier 'strlen'
  return g_bytes_new(text, strlen(text));
                           ^

../../flutter/shell/platform/linux/fl_standard_message_codec.cc:512:23: error: use of undeclared identifier 'strlen'
      size_t length = strlen(text);
                      ^

Signed-off-by: Damian Wrobel <dwrobel@ertelnet.rybnik.pl>
2020-09-10 09:24:54 -07:00
skia-flutter-autoroll
9a6f09daf7
Roll Fuchsia Linux SDK from 9kiAbu3bd... to l8baHga4c... (#21071) 2020-09-10 06:30:01 -07:00
skia-flutter-autoroll
059638452e
Roll Dart SDK from 66ca43504da0 to 72393cc698da (1 revision) (#21070) 2020-09-10 04:30:01 -07:00
skia-flutter-autoroll
66a56c020c
Roll Skia from 917a2d741e92 to 3d41d509a6a9 (2 revisions) (#21067) 2020-09-10 03:25:02 -07:00
skia-flutter-autoroll
cd516eedbc
Roll Fuchsia Mac SDK from K1oZWWtBn... to 5o9onBKYd... (#21066) 2020-09-10 03:05:01 -07:00
skia-flutter-autoroll
e6f1ee295e
Roll Skia from 5eea6aea02d9 to 917a2d741e92 (1 revision) (#21065) 2020-09-10 02:05:01 -07:00
skia-flutter-autoroll
38195b9c56
Roll Dart SDK from 325d9b628caa to 66ca43504da0 (1 revision) (#21064) 2020-09-10 00:00:02 -07:00
Sebastian Roth
fee6f9e533
Annotate valuePublishedByPlugin with nullable (#19267) 2020-09-09 19:45:02 -07:00
skia-flutter-autoroll
5ddbcc7120
Roll Dart SDK from 5e8b31a5fa48 to 325d9b628caa (1 revision) (#21063) 2020-09-09 19:30:02 -07:00
David Worsham
a52397e05f
fuchsia: Compile disabled RasterThreadMerger code (#20984) 2020-09-09 18:40:01 -07:00
Alexander Brusher
cd580e2099
Adds increment/decrement actions to fuchsia accessibility bridge. (#21049) 2020-09-09 18:34:38 -07:00
xster
7ebab5dc8a
Delete unused iOS test scripts after LUCI change (#18712)
This deletes old LUCI build scripts that have been unused since
https://flutter-review.googlesource.com/c/recipes/+/3160
2020-09-09 18:22:45 -07:00
Harry Terkelsen
80049a7b91
Remove the type parameter from SkObjectFinalizationRegistry. (#21061) 2020-09-09 17:20:02 -07:00
stuartmorgan
b55829887e
Rename Registrar to PluginRegistrar in Win/GLFW C API (#21058) 2020-09-09 17:15:03 -07:00
Yurii Nakonechnyi
e4f84f19fd
Clarify that run.sh builds and runs the GLFW example 2020-09-09 17:11:20 -07:00
skia-flutter-autoroll
7e1ff9cd92
Roll Fuchsia Linux SDK from eBus_y4DN... to 9kiAbu3bd... (#21056) 2020-09-09 17:10:02 -07:00
kele86838437
ab0d4b43be
Update Androidx import (#19059) 2020-09-09 16:10:03 -07:00
skia-flutter-autoroll
f8502d29e5
Roll Skia from 215d2b0fa42d to 5eea6aea02d9 (11 revisions) (#21055) 2020-09-09 15:40:01 -07:00
chunhtai
2a12d78c17
Fixed ios layout change to not refocus semantics object if the focus … (#21029)
* Fixed ios layout change to not refocus semantics object if the focus is outside of flutter

* update

* addressing comments
2020-09-09 15:39:21 -07:00
chenjianguang
5271340b88
Fix usage of WeakPtr valid check (#20106) 2020-09-09 15:34:24 -07:00
Yuqian Li
00978035cd
Open a fresh dir during LoadSkSLs (#21050)
Fixes https://github.com/flutter/flutter/issues/65258

The following devicelab tests should pass after this patch:

- flutter_gallery_sksl_warmup__transition_perf_e2e_ios32
- flutter_gallery_sksl_warmup_ios32__transition_perf
2020-09-09 15:33:33 -07:00
skia-flutter-autoroll
bc1507a5c2
Roll Dart SDK from 2e838b7b4503 to 5e8b31a5fa48 (2 revisions) (#21054)
https://dart.googlesource.com/sdk.git/+log/2e838b7b4503..5e8b31a5fa48

2020-09-09 dart-luci-ci-builder@dart-ci.iam.gserviceaccount.com Version 2.10.0-109.0.dev
2020-09-09 dart-luci-ci-builder@dart-ci.iam.gserviceaccount.com Version 2.10.0-108.0.dev

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/dart-sdk-flutter-engine
Please CC dart-vm-team@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md
2020-09-09 14:58:49 -07:00
linxuebin
564367b297
Increase thread priority before engine init (#20922)
We get huge ANRs in not pure flutter app.
We found that 0.15% of the engine initialization took more than 10 seconds, every 10 million starts.
2020-09-09 14:07:34 -07:00
Chris Bracken
404e9b7505
Check for dart2js on felt startup (#21046)
This adds a check for the presence of dart2js in the engine build.

Felt relies on an engine build with `--full-dart-sdk` set. Previously,
we checked for the presence of pub, but not for the presence of
web-specific tooling such as dart2js that felt relies on. Pub is built
as part of the default Dart SDK build when `--full-dart-sdk` is not set,
so its presence is insufficient to prove that other required tooling is
present.

Without this check, we get the following error on run:

    Unhandled exception:
    ProcessException: No such file or directory
      Command: /Users/cbracken/src/flutter/engine/src/out/host_debug_unopt/dart-sdk/bin/dart2js --no-minify --disable-inlining --enable-asserts --enable-experiment=non-nullable --no-sound-null-safety -O2 -o test/paragraph_builder_test.dart.browser_test.dart.js test/paragraph_builder_test.dart
2020-09-09 14:04:52 -07:00
skia-flutter-autoroll
1fb13373a9
Roll Fuchsia Mac SDK from Phn3nF_BJ... to K1oZWWtBn... (#21051) 2020-09-09 14:00:02 -07:00
skia-flutter-autoroll
c0abf5b365
Roll Skia from 81606b5d9774 to 215d2b0fa42d (4 revisions) (#21045) 2020-09-09 11:40:01 -07:00
Zachary Anderson
f7c7b41f0a
Revert "Enable lazy-async-stacks by-default in all modes (Take 3) (#20895)" (#21043)
This reverts commit 575a51948d81756c778352b40f639fa557325fd7.
2020-09-09 09:25:17 -07:00
skia-flutter-autoroll
61062fdbca
Roll Skia from 81c6d6eeb4cf to 81606b5d9774 (5 revisions) (#21041) 2020-09-09 09:00:02 -07:00