20087 Commits

Author SHA1 Message Date
skia-flutter-autoroll
bbcc495b13
Roll Dart SDK from ffbfa2000435 to 2e838b7b4503 (2 revisions) (#21039) 2020-09-09 07:05:01 -07:00
skia-flutter-autoroll
f3a17b63d0
Roll Skia from f9d5940fef55 to 81c6d6eeb4cf (1 revision) (#21038) 2020-09-09 06:20:02 -07:00
skia-flutter-autoroll
beb7df5060
Roll Skia from 445c8ebcb710 to f9d5940fef55 (3 revisions) (#21037) 2020-09-09 04:20:02 -07:00
skia-flutter-autoroll
e3de8d0f15
Roll Fuchsia Linux SDK from coVjRTWSf... to eBus_y4DN... (#21035) 2020-09-09 01:05:02 -07:00
skia-flutter-autoroll
7766d2e2b8
Roll Fuchsia Mac SDK from TyNHQXzNU... to Phn3nF_BJ... (#21034) 2020-09-09 00:55:02 -07:00
skia-flutter-autoroll
89d34b0f38
Roll Skia from b8ae7fa12aa0 to 445c8ebcb710 (1 revision) (#21032) 2020-09-08 23:05:01 -07:00
skia-flutter-autoroll
c538f40d36
Roll Dart SDK from a2c9cae4dcd8 to ffbfa2000435 (1 revision) (#21031) 2020-09-08 20:55:01 -07:00
skia-flutter-autoroll
686667591c
Roll Skia from 04b9443274cf to b8ae7fa12aa0 (1 revision) (#21030) 2020-09-08 17:15:01 -07:00
Chris Bracken
cf8c6b8ba1
Update web lerpDouble to match C++ behaviour (#21010)
This updates the web_ui implementation of lerpDouble to match the
behaviour of the C++ engine implementation in dart:ui.

Specifically this covers the following changes:
* #20871: stricter handling of NaN and infinity
* #20879: Improve the precision of lerpDouble

lerpDouble: stricter handling of NaN and infinity (#20871)
----------------------------------------------------------

Previously, the behaviour of lerpDouble with respect to NaN and infinity
was relatively complex and difficult to reason about. This patch
simplifies the behaviour with respect to those conditions and adds
documentation and tests.

In general, if `a == b` or both values are null, infinite, or NaN, `a`
is returned. Otherwise we require `a` and `b` and `t` to be finite or
null and the result of the linear interpolation is returned.

Improve the precision of lerpDouble (#20879)
--------------------------------------------

Reduces errors caused by the loss of floating point precision when the
two extrema of the lerp differ significantly in magnitude. Previously,
we used the calculation:

    a + (b - a) * t

When the difference in magnitude between `a` and `b` exceeds the
precision representable by double-precision floating point math, `b - a`
results in the larger-magnitude value of `a` or `b`. The error between
the value produced and the correct value is then scaled by t.

A simple example of the impact can be seen when `a` is significantly
larger in magnitude than `b`. In that case, `b - a` results in `a` and
when `t` is 1.0, the resulting value is `a - (a) * 1.0 == 0`.

The patch transforms the computation to the mathematically-equivalent
expression:

    a * (1.0 - t) + b * t

By scaling each value independently, the behaviour is more accurate.
From the point of view of performance, this adds an extra
multiplication, but multiplication is relatively cheap and the behaviour
is significantly better.

This patch also adds a `precisionErrorTolerance` constant to
test_utils.dart and migrates existing tests to use `closeTo()` for
testing.

The tests themselves *do* currently use values that have an exact
floating-point representation, but we should allow for flexibility in
future implementation changes.
2020-09-08 16:04:11 -07:00
skia-flutter-autoroll
cef383d3f5
Roll Skia from cf1a4f50121f to 04b9443274cf (2 revisions) (#21028) 2020-09-08 15:55:02 -07:00
skia-flutter-autoroll
74310709fc
Roll Dart SDK from 33b6c95936e0 to a2c9cae4dcd8 (1 revision) (#21027) 2020-09-08 15:00:02 -07:00
Gary Qian
716dce086f
Android 30r3 (#21025) 2020-09-08 14:51:50 -07:00
skia-flutter-autoroll
6a6c23aaf2
Roll Skia from c0d3495e1ee2 to cf1a4f50121f (6 revisions) (#21026) 2020-09-08 14:35:01 -07:00
Chinmay Garde
f0fb74b8fb
Avoid crashing and display error if the process cannot be prepared for JIT mode Dart VM. (#20980) 2020-09-08 13:41:31 -07:00
skia-flutter-autoroll
af90dd366f
Roll Skia from cd54c8385c31 to c0d3495e1ee2 (12 revisions) (#21024) 2020-09-08 13:15:02 -07:00
skia-flutter-autoroll
e7d558fbe4
Roll Dart SDK from b88c06c314f4 to 33b6c95936e0 (2 revisions) (#21023)
https://dart.googlesource.com/sdk.git/+log/b88c06c314f4..33b6c95936e0

2020-09-08 dart-luci-ci-builder@dart-ci.iam.gserviceaccount.com Version 2.10.0-103.0.dev
2020-09-08 dart-luci-ci-builder@dart-ci.iam.gserviceaccount.com Version 2.10.0-102.0.dev

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/dart-sdk-flutter-engine
Please CC dart-vm-team@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md
2020-09-08 12:59:55 -07:00
skia-flutter-autoroll
5aa6921a50
Roll Skia from 611a52108b01 to cd54c8385c31 (2 revisions) (#21021) 2020-09-08 11:55:01 -07:00
skia-flutter-autoroll
808bb859a4
Roll Fuchsia Mac SDK from tUwahggJ8... to TyNHQXzNU... (#21019) 2020-09-08 11:50:01 -07:00
skia-flutter-autoroll
d0d9ce6104
Roll Fuchsia Linux SDK from Ta3F40BV6... to coVjRTWSf... (#21018) 2020-09-08 11:45:01 -07:00
xster
09a5bf7acf
Tweak the mdns error message (#20991) 2020-09-08 10:54:42 -07:00
skia-flutter-autoroll
7d927dd4a4
Roll Dart SDK from f745f9447ddf to b88c06c314f4 (1 revision) (#21016) 2020-09-07 14:20:01 -07:00
skia-flutter-autoroll
539cb6985f
Roll Fuchsia Linux SDK from gfAt63Ezd... to Ta3F40BV6... (#21015) 2020-09-07 06:15:01 -07:00
skia-flutter-autoroll
22cca4cfd8
Roll Dart SDK from e59935669cb0 to f745f9447ddf (1 revision) (#21014) 2020-09-07 06:10:01 -07:00
skia-flutter-autoroll
040a794b68
Roll Fuchsia Mac SDK from 9pfHLZEFU... to tUwahggJ8... (#21013) 2020-09-07 06:00:02 -07:00
Clement Skau
575a51948d
Enable lazy-async-stacks by-default in all modes (Take 3) (#20895)
Lazy async stacks were already enabled by-default in AOT mode in [0] - which made the
gen_snapshot invocations use "--lazy-async-stacks --no-causal-async-stacks".

This change does the same with the engine defaults, which makes this be enabled
by-default in JIT mode as well.

See go/dart-10x-faster-async for more information.

This is a re-land: A fix for what we believe to have caused the last revert has landed upstream in Dart in dart-lang/sdk@0004589

[0] flutter/flutter@3478232
2020-09-07 10:55:48 +02:00
skia-flutter-autoroll
5b055bbf52
Roll Skia from d0fe7d37d678 to 611a52108b01 (2 revisions) (#21012) 2020-09-07 00:20:01 -07:00
skia-flutter-autoroll
6cf0cc475c
Roll Skia from a73a84f9b8e3 to d0fe7d37d678 (1 revision) (#21011) 2020-09-06 23:00:02 -07:00
skia-flutter-autoroll
b4cc631cc6
Roll Dart SDK from f3a9ca88b664 to e59935669cb0 (1 revision) (#21008) 2020-09-06 17:05:03 -07:00
skia-flutter-autoroll
5539820a6d
Roll Skia from d91cd6b5ee2b to a73a84f9b8e3 (1 revision) (#21007) 2020-09-06 17:00:01 -07:00
skia-flutter-autoroll
cceb7332ee
Roll Fuchsia Mac SDK from sih5f60Gt... to 9pfHLZEFU... (#21006) 2020-09-06 16:55:02 -07:00
skia-flutter-autoroll
b6a3c5488f
Roll Fuchsia Linux SDK from A0PKwETay... to gfAt63Ezd... (#21005) 2020-09-06 16:50:04 -07:00
skia-flutter-autoroll
556cb237eb
Roll Skia from 6763a713f957 to d91cd6b5ee2b (3 revisions) (#20989) 2020-09-04 15:30:02 -07:00
skia-flutter-autoroll
d1d848e842
Roll Fuchsia Mac SDK from EN2ycWLxi... to sih5f60Gt... (#20999) 2020-09-04 15:15:01 -07:00
skia-flutter-autoroll
0628492e76
Roll Dart SDK from 0f0cff3922ad to f3a9ca88b664 (1 revision) (#21000) 2020-09-04 12:45:01 -07:00
Jim Graham
d77c4e540e
adjust blur radius for HTML to match CanvasKit (#20840)
* adjust blur radius for HTML to match CanvasKit

* switch to new goldens for new blur radius logic
2020-09-04 12:10:48 -07:00
skia-flutter-autoroll
b4e0896395
Roll Fuchsia Linux SDK from 81O8Kg_Rw... to A0PKwETay... (#20998) 2020-09-04 09:15:01 -07:00
Gary Qian
242d522077
[Android R] Sync keyboard animation with view insets vs Android 11/R/API 30 WindowInsetsAnimation (#20843) 2020-09-04 02:06:30 -07:00
skia-flutter-autoroll
9fc9cb2b97
Roll Dart SDK from 016e8880f0ab to 0f0cff3922ad (7 revisions) (#20990) 2020-09-04 00:30:01 -07:00
Jim Graham
6a6986da47
improve sensitivity of BackdropFilter web tests (#20915) 2020-09-03 21:47:41 -07:00
skia-flutter-autoroll
c7b3d53047
Roll Fuchsia Mac SDK from gOI3W1UNU... to EN2ycWLxi... (#20985) 2020-09-03 21:45:01 -07:00
Siva
d77dd31013
Manual roll of Dart b29f228f62...016e8880f0 (#20967)
dart-lang/sdk@016e8880f0 Version 2.10.0-90.0.dev
dart-lang/sdk@34f636ce1d Revert "[vm/io] Fix FileSystemWatcher enum name typo."
dart-lang/sdk@7a02118a41 [vm/fuchsia]: Safely shutdown the async message loop.
dart-lang/sdk@334d368146 [analyzer_plugin] Remove unused dart:async imports
dart-lang/sdk@047c0f860a [Analyzer] Support analyzing open files without open workspaces
dart-lang/sdk@f846d0e7ea [analyzer_cli] Remove unused dart:async imports
dart-lang/sdk@ba372d6e8a [dartdev] Remove unused dart:async import
dart-lang/sdk@30cfb228c0 [nnbd_migration] Remove unused dart:async imports
dart-lang/sdk@1134a0f17c [analysis_server] Remove unused dart:async imports
dart-lang/sdk@3317d47c7d [_fe_analyzer_shared] Remove unused dart:async import
dart-lang/sdk@0a036db596 [vm/io] Fix FileSystemWatcher enum name typo.
dart-lang/sdk@000f3135a5 [analyzer] Remove unused dart:async imports
dart-lang/sdk@7817aa1796 [dartfix] Remove unused dart:async imports
dart-lang/sdk@0144087619 Version 2.10.0-89.0.dev
dart-lang/sdk@42dfb9d304 Add `generateCallGraphWithDominators` method to generate a `CallGraph` from a precompiler trace.
dart-lang/sdk@01024dfa5a Issue 43200. Report ASSIGNMENT_TO_FINAL when 'final late' has an initializer.
dart-lang/sdk@ab16d79af9 Revert "Flow analysis changes to fix mixed-mode unsoundness loophole."
dart-lang/sdk@7363adca67 [infra] Update checked-in SDKs to 2.10.0-79.0.dev
dart-lang/sdk@d833f2f65c Flow analysis changes to fix mixed-mode unsoundness loophole.
dart-lang/sdk@33e4a6bc2a Revert "[vm] Have Read/WriteStream use (S)LEB128 for variable-length encoding."
dart-lang/sdk@d9dc24b53e Version 2.10.0-88.0.dev
dart-lang/sdk@7130dd4d3d [cfe] Report error on non-void setter return type
dart-lang/sdk@a7cb764aa4 [tests/ffi] Reinstate deleted test
dart-lang/sdk@39689eb07c [co19] Roll co19 to 9c07e26d67665de7972ba6f7e87369933a978545
dart-lang/sdk@1f92293fd5 Revert "[dart:html] Add 'creates' type description to JS calls"
dart-lang/sdk@e44cf969c6 Fix creates value for getStats
dart-lang/sdk@15201ebe5f Version 2.10.0-87.0.dev
dart-lang/sdk@eb8dfee107 [CFE] Clean up duplicate entries in spell checker lists
2020-09-03 20:50:59 -07:00
Jason Simmons
0f0ae681e8
Update test Dart code to pass the latest Dart analyzer rules (#20986) 2020-09-03 18:09:05 -07:00
xster
b22a8c69d9
Let FlutterActivity/Fragment/FragmentActivity have an app bundle path override instead of eager resolving during construction (#20769) 2020-09-03 17:31:30 -07:00
Emmanuel Garcia
367c6dbd12
Don't use GetTaskQueueId() in rasterizer as it breaks Fuchsia (#20983) 2020-09-03 16:40:01 -07:00
Jim Graham
841401db8c
restore FML_DCHECK removed due to a code reviewing error (#20953) 2020-09-03 14:46:28 -07:00
skia-flutter-autoroll
c2e70109f3
Roll Skia from 1ee21cdfb6fe to 6763a713f957 (1 revision) (#20982) 2020-09-03 14:40:01 -07:00
Alexander Brusher
30b829e7ed
Populates fuchsia node actions in semantics updates. (#20451) 2020-09-03 14:38:36 -07:00
0xZero
ac8b9c4c52
Member variables should appear before the |WeakPtrFactory|. (#20899) 2020-09-03 14:34:01 -07:00
Guokai-Cheng
e284598d6d
Ensure the destructor is called since it destroys the EGLSurface before creating a new onscreen surface. (#20916) 2020-09-03 14:32:48 -07:00
Jason Simmons
d368b8763a
Log the results when ShellTest.Screenshot fails (#20932)
This test has been flaky on LUCI recently.

See https://github.com/flutter/flutter/issues/65026
2020-09-03 14:13:55 -07:00