15827 Commits

Author SHA1 Message Date
Jason Simmons
bdd4e4d948
Do not assume that createTypeface is called before getStyle in the AssetManagerFontStyleSet (#14343) 2019-12-13 09:23:08 -08:00
skia-flutter-autoroll
1377ef6808
Roll src/third_party/skia c514e7d9be6e..d0840ecf5831 (18 commits) (#14478)
https://skia.googlesource.com/skia.git/+log/c514e7d9be6e..d0840ecf5831

git log c514e7d9be6e..d0840ecf5831 --date=short --first-parent --format='%ad %ae %s'
2019-12-13 michaelludwig@google.com Provide record time allocator to onCombineIfPossible()
2019-12-13 skia-autoroll@skia-public.iam.gserviceaccount.com Roll third_party/externals/angle2 6381d7f14805..1d77542f5681 (8 commits)
2019-12-13 skia-autoroll@skia-public.iam.gserviceaccount.com Roll third_party/externals/swiftshader 07958d452f93..ebb0bec91552 (4 commits)
2019-12-13 skia-autoroll@skia-public.iam.gserviceaccount.com Roll ../src 636138928516..d11c17148d1a (358 commits)
2019-12-13 skia-autoroll@skia-public.iam.gserviceaccount.com Roll skia/third_party/skcms 5855011aeee5..cd31cb38833c (1 commits)
2019-12-13 recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com Roll recipe dependencies (trivial).
2019-12-12 skia-autoroll@skia-public.iam.gserviceaccount.com Roll skia/third_party/skcms e7b14532d922..5855011aeee5 (1 commits)
2019-12-12 herb@google.com Add filter to SkTHashTable and SkTHashMap
2019-12-12 skia-autoroll@skia-public.iam.gserviceaccount.com Roll skia/third_party/skcms 7240f337e5d6..e7b14532d922 (1 commits)
2019-12-12 mtklein@google.com use std::make_unique
2019-12-12 skia-autoroll@skia-public.iam.gserviceaccount.com Roll skia/third_party/skcms 4e9ed5892c00..7240f337e5d6 (1 commits)
2019-12-12 fmalita@chromium.org [skottie] Cascading track matte support
2019-12-12 skia-autoroll@skia-public.iam.gserviceaccount.com Roll skia/third_party/skcms 04c7f4ea275f..4e9ed5892c00 (1 commits)
2019-12-12 bsalomon@google.com Make Gr[Op]MemoryPool allocate itself into its initial block.
2019-12-12 reed@google.com perform perspective clip by default
2019-12-12 skia-autoroll@skia-public.iam.gserviceaccount.com Roll skia/third_party/skcms 2e1ffb61f677..04c7f4ea275f (1 commits)
2019-12-12 michaelludwig@google.com Reland "Detach op memory pool from recording context"
2019-12-12 skia-autoroll@skia-public.iam.gserviceaccount.com Roll skia/third_party/skcms 64374756e037..2e1ffb61f677 (1 commits)

Created with:
  gclient setdep -r src/third_party/skia@d0840ecf5831

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC djsollen@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

Bug: None
Tbr: djsollen@google.com
2019-12-13 11:45:24 -05:00
skia-flutter-autoroll
4a28c68601
Roll fuchsia/sdk/core/mac-amd64 from SlgE8... to 5t09i... (#14476)
Roll fuchsia/sdk/core/mac-amd64 from SlgE8... to 5t09i...

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/fuchsia-mac-sdk-flutter-engine
Please CC  on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md
2019-12-13 11:42:19 -05:00
skia-flutter-autoroll
b616dcd5df
Roll fuchsia/sdk/core/linux-amd64 from sBbWo... to QZVxo... (#14473)
Roll fuchsia/sdk/core/linux-amd64 from sBbWo... to QZVxo...

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/fuchsia-linux-sdk-flutter-engine
Please CC  on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md
2019-12-13 11:37:18 -05:00
skia-flutter-autoroll
4ca54fe2c4
Roll src/third_party/dart c561a9eacc1b..fe9f30c3896e (7 commits) (#14475)
https://dart.googlesource.com/sdk.git/+log/c561a9eacc1b..fe9f30c3896e

git log c561a9eacc1b..fe9f30c3896e --date=short --first-parent --format='%ad %ae %s'
2019-12-13 gityuan@gmail.com [timeline] support vm events available to systrace
2019-12-13 srujzs@google.com Skip all html tests for d8
2019-12-13 rnystrom@google.com Turn the Dart 2.0 migration tool into an NNBD migration tool.
2019-12-12 scheglov@google.com Stop setting AST properties for DDC.
2019-12-12 zichangguo@google.com [dart:io] RawSocketOption.fromInt should follow the same endian as host
2019-12-12 zichangguo@google.com [vm/debugger] --trace-debugger-stacktrace prints async causal stack trace
2019-12-12 rnystrom@google.com Move NNBD tests (language_2/nnbd) to new NNBD test directory.

Created with:
  gclient setdep -r src/third_party/dart@fe9f30c3896e

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/dart-sdk-flutter-engine
Please CC dart-vm-team@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

Bug: None
Tbr: dart-vm-team@google.com
2019-12-13 11:33:37 -05:00
Nurhan Turgut
7922bc80e9
[web] adding firefox unit tests to font loading (#14467)
* adding firefox unit tests to font loading

* reviewer suggestions
2019-12-13 07:28:27 -08:00
Kaushik Iska
e65b4901fa
[animator] Pass target frametime for Window.onBeginFrame (#14318)
This gives us a time closer to when the frame will be rendered on
screen.

Fixes: https://github.com/flutter/flutter/issues/10850
2019-12-12 15:03:27 -08:00
skia-flutter-autoroll
8d62a7c805
Roll src/third_party/dart 45db29709547..c561a9eacc1b (14 commits) (#14471)
https://dart.googlesource.com/sdk.git/+log/45db29709547..c561a9eacc1b

git log 45db29709547..c561a9eacc1b --date=short --first-parent --format='%ad %ae %s'
2019-12-12 nshahan@google.com [dartdevc] Delete the legacy version of DDC
2019-12-12 scheglov@google.com Issue 39752. Fix for promoting TypeParameterType twice.
2019-12-12 mfairhurst@google.com [nnbd_migration] Return simple LUB node for LUB(T, T) for type parameter type T
2019-12-12 mfairhurst@google.com [nnbd_migration] handle LUB(A<T>, B<T>)
2019-12-12 mfairhurst@google.com [nnbd_migration] handle LUB(null, T) for type parameters
2019-12-12 mfairhurst@google.com [nnbd_migration] Handle LUB(null, Function)
2019-12-12 mfairhurst@google.com [nnbd_migration] Assert GLB(null, S) cannot produce C<T>
2019-12-12 mfairhurst@google.com [nnbd_migration] Handle LUB(null, C<A, B, ..., Z>)
2019-12-12 sigmund@google.com (dart2js): escape names when creating tearoff closures
2019-12-12 scheglov@google.com Remove ResolverProvider, and its using for fileResolverProvider / packageResolverProvider.
2019-12-12 dantup@google.com Add explicit type to generated LSP classes == operators
2019-12-12 dantup@google.com Add a publishOutline notification to the LSP server
2019-12-12 sstrickl@google.com [vm] Add docs for DWARF stack traces and related tools/libraries.
2019-12-12 scheglov@google.com Fix TODO in lint/analysis.dart

Created with:
  gclient setdep -r src/third_party/dart@c561a9eacc1b

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/dart-sdk-flutter-engine
Please CC dart-vm-team@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

Bug: None
Tbr: dart-vm-team@google.com
2019-12-12 17:53:05 -05:00
Miguel
94654dbe63 [fuchsia] Add diagnostics directory to the set of remote dirs (#14470) 2019-12-12 14:50:49 -08:00
Jason Simmons
ef64becdd8
Roll fuchsia/sdk/core/linux-amd64 from 9wKTl... to sBbWo... (#14461) 2019-12-12 14:29:46 -08:00
Kaushik Iska
e0e0ac0a68
[testing] Make vsync waiters pluggable in shell_unittests (#14463)
This makes it so that the platform views can be passed
an arbitraty CreateVsyncWaiter callback that lets us inject
a vsync waiter other than just the simulated monotonic vsync waiter
that currently exists.
2019-12-12 14:15:36 -08:00
Chinmay Garde
181ad4e18f
Use futures to images used for comparison with fixtures in embedder unit-tests. (#14465)
This earlier pattern was to use callbacks with latching.
2019-12-12 14:07:53 -08:00
Yegor
18c89f1cf6
[web][refactor] Split html and canvaskit classes more (#14320)
* Split surface and canvaskit classes more

* fix licenses

* address comments
2019-12-12 13:20:49 -08:00
Kaushik Iska
ffbe2a40e7
[testing] Move test vsync waiters to their own TUs (#14456)
This move makes it easier to add more vsync waiters.
2019-12-12 12:27:56 -08:00
skia-flutter-autoroll
0c24f3d019
Roll src/third_party/skia 51b99659ed82..c514e7d9be6e (13 commits) (#14457)
https://skia.googlesource.com/skia.git/+log/51b99659ed82..c514e7d9be6e

git log 51b99659ed82..c514e7d9be6e --date=short --first-parent --format='%ad %ae %s'
2019-12-12 herb@google.com Move the GrGlyph* and vertex data onto the arena alloc.
2019-12-12 halcanary@google.com BUILD.gn: Fix formatting.
2019-12-12 nifong@google.com Parse android layer annotations in debugger, play back layers
2019-12-12 djsollen@google.com Revert "Detach op memory pool from recording context"
2019-12-12 mtklein@google.com don't create out of range enums
2019-12-12 robertphillips@google.com Add compression to Mock backend
2019-12-12 michaelludwig@google.com Detach op memory pool from recording context
2019-12-12 paraboul@gmail.com Use absolute sigma instead of clamping to 0 in SkDropShadowImageFilter.
2019-12-12 skia-autoroll@skia-public.iam.gserviceaccount.com Roll ../src cf2545c5111b..636138928516 (444 commits)
2019-12-12 skia-autoroll@skia-public.iam.gserviceaccount.com Roll third_party/externals/angle2 d6053daa6203..6381d7f14805 (11 commits)
2019-12-12 skia-autoroll@skia-public.iam.gserviceaccount.com Roll third_party/externals/swiftshader 50211670b4bf..07958d452f93 (11 commits)
2019-12-12 robertphillips@google.com Reland "Update FragmentProcessor TextureSampler to hold an GrSurfaceProxyView."
2019-12-12 robertphillips@google.com Revert "Update FragmentProcessor TextureSampler to hold an GrSurfaceProxyView."

Created with:
  gclient setdep -r src/third_party/skia@c514e7d9be6e

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC djsollen@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

Bug: None
Tbr: djsollen@google.com
2019-12-12 14:52:49 -05:00
Chris Bracken
4275b4976c
Fix type in build_fuchsia_artifacts (#14452)
Pakcage -> Package. Spotted while running over the CIPD package build
with someone.
2019-12-12 11:32:32 -08:00
Nurhan Turgut
f650bcaf77
Refactoring text editing. Strategy pattern is used to handle different browser/operating system and a11y behavior. (#14131)
* adding the default text editing strategy

* [DRAFT] Refactoring text editing. Strategy pattern is used to handle different browser/operating system and a11y behaviour. Unit tests are missing. Documentation needs updating.

* addressing PR comments

* addressing PR comments. Fixing documentation

* fixing persistenttextediting element which is used in a11y mode

* removing texteditingelement and using texteditingstrategy from hybridtextediting. fixing the unit tests. fixing comments

* fix unit tests

* add todos for firefox tests

* fixing chrome/android a11y issue
2019-12-12 11:18:02 -08:00
skia-flutter-autoroll
d8edfea033
Roll src/third_party/dart d9fa37e85d5c..45db29709547 (48 commits) (#14453)
https://dart.googlesource.com/sdk.git/+log/d9fa37e85d5c..45db29709547

git log d9fa37e85d5c..45db29709547 --date=short --first-parent --format='%ad %ae %s'
2019-12-12 victor.agnez@hotmail.com [vm/precomp] Reduce arm32 code size for BoxInt64Instr
2019-12-12 sstrickl@google.com [vm] De-obfuscate function and file names in DWARF sections.
2019-12-12 scheglov@google.com Remove Packages from SourceFactory.
2019-12-12 dacoharkes@google.com [vm/ffi] Split up function_callbacks_test
2019-12-12 whesse@google.com [infra] Add script to read builder status from Firestore
2019-12-12 whesse@google.com Reland "Reland "[infra] Add failing test to test CI systems and approvals workflow""
2019-12-12 sstrickl@google.com [vm/compiler] Add --save-debugging-info flag to gen_snapshot.
2019-12-12 johnniwinther@google.com [cfe] Refactor for-in loops to handle flow analysis
2019-12-12 dacoharkes@google.com [vm/ffi] Fix asan test expectations
2019-12-12 athom@google.com [test] Fix import in exact_selector_test
2019-12-12 dmitryas@google.com [cfe] Implement NNBD-aware lower / upper bound algorithms
2019-12-12 dacoharkes@google.com [samples/ffi] Native resource lifetime management
2019-12-12 netroby@users.noreply.github.com Fixed #39679 make sqlite ffi sample run success
2019-12-12 jensj@google.com [parser] Allow ?? after Type?
2019-12-12 jensj@google.com [parser] Allow '?.' and '?.[' after '!'
2019-12-12 fizaaluthra@google.com [dartfuzz] Add flag for displaying output divergence details
2019-12-12 rmacnak@google.com [vm, arm64] Fix heap corruption in PushArrayOfArguments.
2019-12-12 srawlins@google.com NNBD preview: Rip out static preview; only server preview
2019-12-12 srawlins@google.com Connect g/setters which override fields (w/ implicit g/setters)
2019-12-12 fizaaluthra@google.com [dartfuzz] Re-enabling Int32x4
2019-12-11 sigmund@google.com fix nnbd bots: build step broke when tests were moved
2019-12-11 scheglov@google.com Packages configuration abstraction on top of .packages or package_config.json files.
2019-12-11 fishythefish@google.com [dart2js] Remove bad assert from runtime_types_new.
2019-12-11 gityuan@gmail.com [timeline] Add  support for timeline asynchronous events in android platform trace
2019-12-11 alexmarkov@google.com Reland "[vm/compiler] Dead code elimination"
2019-12-11 rnystrom@google.com Move files under language_2 into subdirectories.
2019-12-11 rmacnak@google.com [vm] Initialize the handle vtable table during VM initialization instead of during class registration in each isolate's initialization.
2019-12-11 pquitslund@google.com bump to linter 0.1.106
2019-12-11 rmacnak@google.com [vm] Reduce frame size for the functions with the largest frame sizes.
2019-12-11 rmacnak@google.com [build] Use separate out directories for each sanitizer.
2019-12-11 brianwilkerson@google.com Update dartfix to display urls and wait when run in preview mode
2019-12-11 scheglov@google.com Implement NORM.
2019-12-11 alexmarkov@google.com [vm/test] Fix vm/dart/product_aot_kernel_test for bytecode
2019-12-11 alexmarkov@google.com [vm/ffi_test] Fix ClobberAndCall helper on Windows
2019-12-11 scheglov@google.com Implement parsing for package_config.json files in analyzer.
2019-12-11 scheglov@google.com Extract nullability TypeSystem tests.
2019-12-11 srawlins@google.com Remove duplicate 'DEFAULT_VALUE_IN_FUNCTION_TYPE_ALIAS' already reported by fasta
2019-12-11 paulberry@google.com Create null-aware companion methods for ElementTypeProvider.
2019-12-11 brianwilkerson@google.com Start sending urls for preview mode from server to dartfix
2019-12-11 brianwilkerson@google.com Prepare to publish analysis_server_client so that dartfix can use the new API
2019-12-11 srawlins@google.com NNBD preview: improve details of where a nullable value is 'assigned'
2019-12-11 athom@google.com [infra] Update checked-in SDKs to 2.8.0-dev.0.0
2019-12-11 jensj@google.com [CFE] Fix bug in DebugStack
2019-12-11 whesse@google.com Revert "Reland "[infra] Add failing test to test CI systems and approvals workflow""
2019-12-11 athom@google.com [co19] Run co19 nnbd tests on analyzer-nnbd
2019-12-11 sstrickl@google.com [vm] Remove the unchecked entry point offset field from RawInstructions.
2019-12-11 athom@google.com [release] Merge the two 2.7.0 sections in the changelog
2019-12-11 whesse@google.com Reland "[infra] Add failing test to test CI systems and approvals workflow"

Created with:
  gclient setdep -r src/third_party/dart@45db29709547

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/dart-sdk-flutter-engine
Please CC dart-vm-team@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

Bug: None
Tbr: dart-vm-team@google.com
2019-12-12 14:08:51 -05:00
Alexander Aprelev
0081e8c516
Remove unused _TypeNone enum field. (#14440)
* Remove unused field
* Similarly remove _TypeNone from web_ui
2019-12-12 09:43:44 -08:00
skia-flutter-autoroll
48ba39c569
Roll fuchsia/sdk/core/mac-amd64 from otkJA... to SlgE8... (#14407)
Roll fuchsia/sdk/core/mac-amd64 from otkJA... to SlgE8...

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/fuchsia-mac-sdk-flutter-engine
Please CC  on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md
2019-12-12 10:57:37 -05:00
Justin McCandless
a7b6ee58a2
Smart quote/dash configuration support in iOS (#13863)
Support for UITextSmartDashesType and UITextSmartQuotesType in iOS
2019-12-12 10:54:31 -05:00
skia-flutter-autoroll
97634d2efa
Roll src/third_party/skia 826484f2631f..51b99659ed82 (2 commits) (#14405)
https://skia.googlesource.com/skia.git/+log/826484f2631f..51b99659ed82

git log 826484f2631f..51b99659ed82 --date=short --first-parent --format='%ad %ae %s'
2019-12-12 herb@google.com Remove unused fields from GrTextBlobKey
2019-12-12 benjaminwagner@google.com Format public.bzl

Created with:
  gclient setdep -r src/third_party/skia@51b99659ed82

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC djsollen@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

Bug: None
Tbr: djsollen@google.com
2019-12-12 10:51:26 -05:00
Nathan Rogers
1ce85bec2f
[flutter_runner] Enable Skia tracing by default on Fuchsia (#13457)
Since Flutter tracing is wired up to Fuchsia system level tracing (and
that includes Skia tracing within Flutter), it makes more sense to
enable Skia tracing by default on Fuchsia, and to control Flutter Skia
tracing, rely on whether Fuchsia system tracing is enabled, in progress,
and contains the "skia" category.
2019-12-11 21:03:12 -08:00
skia-flutter-autoroll
897ce34bc6
Roll src/third_party/skia 3517aa7b14ad..826484f2631f (18 commits) (#14375)
https://skia.googlesource.com/skia.git/+log/3517aa7b14ad..826484f2631f

git log 3517aa7b14ad..826484f2631f --date=short --first-parent --format='%ad %ae %s'
2019-12-12 egdaniel@google.com Always report SkImage_Gpu subclasses as being texture backed.
2019-12-12 egdaniel@google.com Revert "When converting runtime SkSL to FP SkSL, use default settings"
2019-12-12 recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com Roll recipe dependencies (trivial).
2019-12-11 brianosman@google.com When converting runtime SkSL to FP SkSL, use default settings
2019-12-11 egdaniel@google.com Update FragmentProcessor TextureSampler to hold an GrSurfaceProxyView.
2019-12-11 jvanverth@google.com Change PerspectiveClip to clip directly to half plane.
2019-12-11 jvanverth@google.com Adjust cache key for Metal persistent cache.
2019-12-11 skia-autoroll@skia-public.iam.gserviceaccount.com Roll skia/third_party/skcms ef3043bd8110..64374756e037 (1 commits)
2019-12-11 nifong@google.com Fix audit trail visualization bugs
2019-12-11 fmalita@chromium.org [skottie] Invert effect support
2019-12-11 halcanary@google.com experimental/skottie_ios/SkottieUiView
2019-12-11 csmartdalton@google.com Suppress allocation warnings for tests that induce them intentionally
2019-12-11 mtklein@google.com add SK_CPU_LIMIT_AVX
2019-12-11 halcanary@google.com public.bzl: add metal_objc_srcs()
2019-12-11 fmalita@chromium.org [skottie] Add SkottieSlide frame rate UI option
2019-12-11 halcanary@google.com Roll third_party/externals/libgifcodec ed218be1..38d9c73f (2 commits)
2019-12-11 herb@google.com Remove unused buffer call for SkGlyphRunPaint
2019-12-11 mtklein@google.com roll clang to 9.0

Created with:
  gclient setdep -r src/third_party/skia@826484f2631f

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC djsollen@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

Bug: None
Tbr: djsollen@google.com
2019-12-11 23:39:22 -05:00
Kaushik Iska
9bafb3cd3c
[tests] Use distinct begin and end times (#14361) 2019-12-11 17:23:49 -08:00
xster
fc8cafb3c6
objcdoc fix for some ambiguity (#14367) 2019-12-11 16:43:22 -08:00
Wu Zhong
9e4c6ad40c Fix CGMutablePathRef memory leaks when the path is invalid. (#14275) 2019-12-11 15:52:29 -08:00
Gityuan
9dc23b8be8 Fix missing API stream when record event in systrace (#14323) 2019-12-11 15:51:47 -08:00
Gityuan
d698d96cea Fix missing timeline event of flutter engine's startup time (#14319)
Fixes https://github.com/flutter/flutter/issues/46744
2019-12-11 15:40:23 -08:00
Chinmay Garde
0a40f3d784
Assert that arc end caps on canvases with root surface transformations are drawn correctly. (#14359)
Verifies that the Skia commit https://skia-review.googlesource.com/c/skia/+/259174 has been pulled into the engine. This should have happened in the roll https://github.com/flutter/engine/pull/14345.

Fixes https://github.com/flutter/flutter/issues/46691
Fixes b/142280381
2019-12-11 15:17:34 -08:00
Jim Graham
85953615eb
Conditionally use offscreen root surface only when needed
Currently helps primarily on iOS when no BackdropFilter is present by lowering energy usage
2019-12-11 15:10:55 -08:00
Dwayne Slater
80d80ff6e6
Add ability to control dithering on Paint (#13868) 2019-12-11 14:53:50 -08:00
Alexander Aprelev
2713225a6e
Remove duplicate and outdated src/third_party/dart/tools/sdks entry from DEPS. (#14340)
* Drop duplicate entry
2019-12-11 14:28:00 -08:00
skia-flutter-autoroll
3ebb7b426a Roll src/third_party/skia 75799967be60..3517aa7b14ad (3 commits) (#14345)
https://skia.googlesource.com/skia.git/+log/75799967be60..3517aa7b14ad

git log 75799967be60..3517aa7b14ad --date=short --first-parent --format='%ad %ae %s'
2019-12-11 bsalomon@google.com Fix stroked arcs for mirror matrices.
2019-12-11 benjaminwagner@google.com Update iOS provisioning profile.
2019-12-11 skia-autoroll@skia-public.iam.gserviceaccount.com Roll ../src ffcaa57570c0..cf2545c5111b (466 commits)

Created with:
  gclient setdep -r src/third_party/skia@3517aa7b14ad

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC djsollen@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

Bug: None
Tbr: djsollen@google.com
2019-12-11 14:15:45 -08:00
Kaushik Iska
fb9dfe0fb6
[fuchsia] Move async_get_default_dispatcher include to the header (#14351) 2019-12-11 13:40:38 -08:00
Kaushik Iska
18519e9169
Roll fuchsia/sdk/core/linux-amd64 from UdfLO... to 9wKTl... (#14342)
* Roll fuchsia/sdk/core/linux-amd64 from UdfLO... to 9wKTl...

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/fuchsia-linux-sdk-flutter-engine
Please CC  on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

* async set dispatcher is now from async-default
2019-12-11 11:47:30 -08:00
skia-flutter-autoroll
db60ebc632
Roll fuchsia/sdk/core/mac-amd64 from h4iiT... to otkJA... (#14327)
Roll fuchsia/sdk/core/mac-amd64 from h4iiT... to otkJA...

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/fuchsia-mac-sdk-flutter-engine
Please CC  on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md
2019-12-11 11:13:34 -05:00
skia-flutter-autoroll
02fb9c1f94
Roll src/third_party/dart bd008dd1e406..d9fa37e85d5c (1 commits) (#14325)
https://dart.googlesource.com/sdk.git/+log/bd008dd1e406..d9fa37e85d5c

git log bd008dd1e406..d9fa37e85d5c --date=short --first-parent --format='%ad %ae %s'
2019-12-11 johnniwinther@google.com [kernel] Use Never as static type for throw/rethrow

Created with:
  gclient setdep -r src/third_party/dart@d9fa37e85d5c

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/dart-sdk-flutter-engine
Please CC dart-vm-team@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

Bug: None
Tbr: dart-vm-team@google.com
2019-12-11 11:09:20 -05:00
skia-flutter-autoroll
ac95536a64
Roll src/third_party/skia 5afc7b2af854..75799967be60 (2 commits) (#14324)
https://skia.googlesource.com/skia.git/+log/5afc7b2af854..75799967be60

git log 5afc7b2af854..75799967be60 --date=short --first-parent --format='%ad %ae %s'
2019-12-11 skia-autoroll@skia-public.iam.gserviceaccount.com Roll third_party/externals/angle2 f60da87424a4..d6053daa6203 (8 commits)
2019-12-11 skia-autoroll@skia-public.iam.gserviceaccount.com Roll third_party/externals/swiftshader 31916f494c2e..50211670b4bf (28 commits)

Created with:
  gclient setdep -r src/third_party/skia@75799967be60

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC djsollen@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

Bug: None
Tbr: djsollen@google.com
2019-12-11 11:07:04 -05:00
skia-flutter-autoroll
2ae0d4273b
Roll src/third_party/dart bcd18e67dcae..bd008dd1e406 (3 commits) (#14322)
https://dart.googlesource.com/sdk.git/+log/bcd18e67dcae..bd008dd1e406

git log bcd18e67dcae..bd008dd1e406 --date=short --first-parent --format='%ad %ae %s'
2019-12-11 srawlins@google.com Allow empty URI strings in library directives
2019-12-11 fishythefish@google.com Revert "[dart2js] Mark native classes as needed if they have new-rti is-tests or"
2019-12-11 nshahan@google.com [test_runner] Temporarily remove some packages from the DDC config

Created with:
  gclient setdep -r src/third_party/dart@bd008dd1e406

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/dart-sdk-flutter-engine
Please CC dart-vm-team@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

Bug: None
Tbr: dart-vm-team@google.com
2019-12-11 00:26:20 -05:00
Chinmay Garde
49d6552e76
Verify accounting for loop counts in Gif and WebP assets is consistent. (#14321)
Asserts that the Skia fix is pulled into Flutter Engine https://skia-review.googlesource.com/c/skia/+/259161. This should have happened in https://github.com/flutter/engine/pull/14315.

Fixes https://github.com/flutter/flutter/issues/46289
Fixes https://github.com/flutter/flutter/issues/45246
2019-12-10 20:04:15 -08:00
Kaushik Iska
6430ecfd39
[fuchsia] Do not Execute paint tasks when there is no vsync (#14298)
This should also reduce the number of OnSurfacesPresented calls
made.
2019-12-10 18:03:55 -08:00
skia-flutter-autoroll
058b4bc5cc
Roll src/third_party/dart c74a8ec2c46e..bcd18e67dcae (9 commits) (#14317)
https://dart.googlesource.com/sdk.git/+log/c74a8ec2c46e..bcd18e67dcae

git log c74a8ec2c46e..bcd18e67dcae --date=short --first-parent --format='%ad %ae %s'
2019-12-11 fishythefish@google.com [dart2js] Mark native classes as needed if they have new-rti is-tests or named type variables.
2019-12-10 sra@google.com [dart2js] Ensure native lookup always initialized
2019-12-10 kustermann@google.com Revert "[vm/compiler] Fix TypeTestingStub -> SubtypeTestCache fallback code if dst_type = TypeParameter"
2019-12-10 regis@google.com [VM/nnbd] Map nullable Never type to Null type.
2019-12-10 scheglov@google.com Issue 39598. Make UNNECESSARY_NULL_AWARE_CALL and other warnings.
2019-12-10 alexmarkov@google.com Revert "[vm/compiler] Dead code elimination"
2019-12-10 vsm@google.com [dartdevc] add forwarding from old docs to new info
2019-12-10 alexmarkov@google.com [vm/nnbd] Fix nullability of types in inferred types attribute
2019-12-10 jcollins@google.com Fix working directory problem shown in demo.

Created with:
  gclient setdep -r src/third_party/dart@bcd18e67dcae

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/dart-sdk-flutter-engine
Please CC dart-vm-team@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

Bug: None
Tbr: dart-vm-team@google.com
2019-12-10 20:40:50 -05:00
skia-flutter-autoroll
5b5206e56d
Roll fuchsia/sdk/core/linux-amd64 from nqJnP... to UdfLO... (#14316)
Roll fuchsia/sdk/core/linux-amd64 from nqJnP... to UdfLO...

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/fuchsia-linux-sdk-flutter-engine
Please CC  on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md
2019-12-10 20:37:46 -05:00
skia-flutter-autoroll
c0b1dc0c6a
Roll src/third_party/skia 732c49739fa5..5afc7b2af854 (16 commits) (#14315)
https://skia.googlesource.com/skia.git/+log/732c49739fa5..5afc7b2af854

git log 732c49739fa5..5afc7b2af854 --date=short --first-parent --format='%ad %ae %s'
2019-12-10 recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com Roll recipe dependencies (trivial).
2019-12-10 herb@google.com Move SubRun from .h to .cpp
2019-12-10 recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com Roll recipe dependencies (trivial).
2019-12-10 mtklein@google.com test for c++17 w/ c++14 stdlib
2019-12-10 scroggo@google.com SkWebpCodec: enable a loop count of 1
2019-12-10 herb@google.com Move luminance calculation to GrTextBlob::Make()
2019-12-10 egdaniel@google.com Add GrSurfaceProxyView to the various draw atlas ops.
2019-12-10 egdaniel@google.com Store GrSurfaceProxyView on shadow ops.
2019-12-10 herb@google.com Put SubRuns in an alloc on GrTextBlob
2019-12-10 fmalita@chromium.org [skottie] Add frame time histogram to SkottieSlide UI
2019-12-10 jlavrova@google.com Font features
2019-12-10 fmalita@chromium.org [skottie] Initial SkottieSlide UI
2019-12-10 halcanary@google.com utils/mac/SkCreateCGImageRef: cleanup
2019-12-10 brianosman@google.com GrSkSLFP: "Kind" is always kPipelineStage
2019-12-10 robertphillips@google.com Switch SkImage::CompressionType to be an enum class
2019-12-10 mtklein@google.com delete unused gyp hack

Created with:
  gclient setdep -r src/third_party/skia@5afc7b2af854

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC djsollen@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

Bug: None
Tbr: djsollen@google.com
2019-12-10 20:31:57 -05:00
skia-flutter-autoroll
b6d4fd164c
Roll fuchsia/sdk/core/mac-amd64 from 9C6UA... to h4iiT... (#14314)
Roll fuchsia/sdk/core/mac-amd64 from 9C6UA... to h4iiT...

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/fuchsia-mac-sdk-flutter-engine
Please CC  on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md
2019-12-10 20:20:34 -05:00
Kaushik Iska
3e55f64c4f
[web] Update build_web_compilers to 2.7.1 (#14305)
* [web] Update build_web_compilers to 2.7.1

This was causing problems with the dart compiler location
for web.

The compiler seems to be present in out/host_debug_unopt/dart-sdk/lib/dev_compiler/kernel/amd/dart_sdk.js as opposed to out/host_debug_unopt/dart-sdk/lib/dev_compiler/amd/dart_sdk.js

* also update build_runner
2019-12-10 16:12:53 -08:00
liyuqian
212fbbaf82
Cleanup the IO thread GrContext (#14265)
Fixes https://github.com/flutter/flutter/issues/19558

This is tested by the devicelab test fast_scroll_large_images__memory
2019-12-10 16:02:02 -08:00
Ben Konyi
2bd5cc2cce
Roll src/third_party/dart 98c13ba18f..c74a8ec2c4 (14 commits) (#14309)
dart-lang/sdk@c74a8ec2c4 [vm/bytecode] Fix handling of contravariant parameters in isUncheckedCall
dart-lang/sdk@4ce13659b4 Update server API to allow URLs to be returned to dartfix
dart-lang/sdk@e22ddd1372 Update TypeSystemTest to reuse more ElementsTypesMixin.
dart-lang/sdk@e1ef70fad4 [vm] Add nnbd-experiment to the snapshot feature string
dart-lang/sdk@ec6e8c8dfa Clarify the roles of isolate_data and isolate_group_data in Dart_CreateIsolateGroup
dart-lang/sdk@b69596bb1b [vm/compiler] Dead code elimination
dart-lang/sdk@1cc5d6927a Deprecate ErrorReporter.reportTypeErrorForNode()
dart-lang/sdk@28b0f18397 Add basic git package management to trial_migration.
dart-lang/sdk@25def20f5d Revert "[infra] Add failing test to test CI systems and approvals workflow"
dart-lang/sdk@620dd7dab5 Use just DartType.getDisplayString() in ErrorReporter.
dart-lang/sdk@d03a7686d2 [vm/compiler] Fix inlining of SIMD shuffle operations
dart-lang/sdk@6a16a59d08 Additional fixes to analyzer pubspec.
dart-lang/sdk@bb8bece3bf Widen the analyzer's pubspec constraint on _fe_analyzer_shared
dart-lang/sdk@e578eeb235 [infra] Add failing test to test CI systems and approvals workflow
2019-12-10 18:46:55 -05:00
Nurhan Turgut
deb8e57135
Fix for tab not working (#14165)
* some logs

* Masking moddifier state for lock keys if the key code is not the same as the modifier. this fixes tab issue happening when numlock/capslock is on.

* removing modifier state for locks

* addresing pr comments'
2019-12-10 14:55:46 -08:00