zijiehe@
bcd7116bef
[Fuchsia] Run tests with multiple packages ( flutter/engine#50219 )
...
This change enables tests requiring multiple packages in both debug and
release builders; though the AOT test cannot be executed.
Also 4 out of 5 suites are excluded from release builder since some of
the tests are failing; it's worth extra investigation.
MouseInputTest in theory is enabled, it indeed contains only disabled
tests.
Bug: https://github.com/flutter/flutter/issues/140179
## Pre-launch Checklist
- [x] I read the [Contributor Guide] and followed the process outlined
there for submitting PRs.
- [x] I read the [Tree Hygiene] wiki page, which explains my
responsibilities.
- [x] I read and followed the [Flutter Style Guide] and the [C++,
Objective-C, Java style guides].
- [x] I listed at least one issue that this PR fixes in the description
above.
- [x] I added new tests to check the change I am making or feature I am
adding, or the PR is [test-exempt]. See [testing the engine] for
instructions on writing and running engine tests.
- [x] I updated/added relevant documentation (doc comments with `///`).
- [x] I signed the [CLA].
- [x] All existing and new tests are passing.
If you need help, consider asking for advice on the #hackers-new channel
on [Discord].
<!-- Links -->
[Contributor Guide]:
https://github.com/flutter/flutter/wiki/Tree-hygiene#overview
[Tree Hygiene]: https://github.com/flutter/flutter/wiki/Tree-hygiene
[test-exempt]:
https://github.com/flutter/flutter/wiki/Tree-hygiene#tests
[Flutter Style Guide]:
https://github.com/flutter/flutter/wiki/Style-guide-for-Flutter-repo
[C++, Objective-C, Java style guides]:
https://github.com/flutter/engine/blob/main/CONTRIBUTING.md#style
[testing the engine]:
https://github.com/flutter/flutter/wiki/Testing-the-engine
[CLA]: https://cla.developers.google.com/
[flutter/tests]: https://github.com/flutter/tests
[breaking change policy]:
https://github.com/flutter/flutter/wiki/Tree-hygiene#handling-breaking-changes
[Discord]: https://github.com/flutter/flutter/wiki/Chat
2024-02-07 15:17:31 -08:00
skia-flutter-autoroll
5131cf0219
Roll Skia from 8332438cbeb9 to 91a9154d0dfa (2 revisions) ( flutter/engine#50452 )
...
https://skia.googlesource.com/skia.git/+log/8332438cbeb9..91a9154d0dfa
2024-02-07 skia-autoroll@skia-public.iam.gserviceaccount.com Manual roll Skia Infra from e83737e1d145 to 35d65e587f8e (29 revisions)
2024-02-07 kschmi@microsoft.com Add contrast and gamma to SkSurfaceProps and use in text rendering
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC brianosman@google.com ,bungeman@google.com,chinmaygarde@google.com,rmistry@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-02-07 22:41:19 +00:00
Jonah Williams
a363e03859
[Impeller] move path out of PathBuilder in TakePath. ( flutter/engine#50444 )
...
We should move this path so we don't end up allocating/deallocating twice.
Fixes https://github.com/flutter/flutter/issues/142873
2024-02-07 22:01:04 +00:00
skia-flutter-autoroll
c720373a9e
Roll Skia from eacaa2d3600c to 8332438cbeb9 (6 revisions) ( flutter/engine#50451 )
...
https://skia.googlesource.com/skia.git/+log/eacaa2d3600c..8332438cbeb9
2024-02-07 borenet@google.com [recipes] Fix SCP for ChromeOS
2024-02-07 borenet@google.com [recipes] Remove dependency on python recipe module
2024-02-07 skia-autoroll@skia-public.iam.gserviceaccount.com Roll skottie-base from 906e4c4c9b17 to 67e2da56aec4
2024-02-07 skia-autoroll@skia-public.iam.gserviceaccount.com Roll shaders-base from 89826f3f6f5d to 45ec924a5da0
2024-02-07 johnstiles@google.com Reland "Remove GR_TEST_UTILS from module loader."
2024-02-07 skia-autoroll@skia-public.iam.gserviceaccount.com Roll jsfiddle-base from b575daa903da to db3abc597412
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC brianosman@google.com ,bungeman@google.com,chinmaygarde@google.com,rmistry@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-02-07 21:46:06 +00:00
Dan Field
9f9ab34867
[Impeller] Log non-default graphics backend usages, use IMPORTANT rather than ERROR ( flutter/engine#50448 )
...
Fixes https://github.com/flutter/flutter/issues/142488
- Only logs on iOS if Skia is used instead of Impeller.
- Logs on other platforms if Impeller is used instead of Skia.
- Uses "IMPORTANT" rather than "ERROR" for these logs. This will show up by default since flutter_tools sets ERROR and above as logs to show.
- Adds some tests.
- Makes INFO log print file paths the same as other verbosities.
2024-02-07 21:29:12 +00:00
skia-flutter-autoroll
354e532c5f
Roll Fuchsia Linux SDK from kvEXgoydRYnW3UvX2... to CPiPDUwCrjHYf_lAR... ( flutter/engine#50447 )
...
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/fuchsia-linux-sdk-flutter-engine
Please CC chinmaygarde@google.com ,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-02-07 21:04:04 +00:00
Matan Lurey
b79821c019
Fix Android scenario_app to actually run and block on CI ( flutter/engine#50414 )
...
20337eaea4https://github.com/flutter/engine/pull/49938 ) on a now working test
runner, and verified that (with some fixes in this PR), we can now catch
regressions on CI with SkiaGold:
---
<details>
<summary>ExternalTextureTests_testCanvasSurface.png</summary>
This test shows that what previously was a picture has been reduced down
to a single stretched pixel.
**BEFORE**:
**AFTER**:
</details>
<details>
<summary>ExternalTextureTests_testRotatedMediaSurface_180.png</summary>
Similar to above, but shows _another_ bug (kClamp versus kRepeat)
**BEFORE**:
**AFTER**:
/cc
</details>
---
This PR now makes the `scenario_test` useful and blocking for Android
engine rolls:
- Add support for connecting to SkiaGold by depending on `goldctl` in
the appropriate configs.
- Add some useful local debugging flags for skipping SkiaGold or running
specific tests (not used by default).
- Failing to connect to Skia gold is now a test failure.
2024-02-07 12:58:41 -08:00
auto-submit[bot]
53ba0f96e4
Reverts "Roll Dart SDK from 452dd17120b7 to 322c81160fa9 (1 revision)" ( flutter/engine#50450 )
...
Reverts flutter/engine#50437
Initiated by: zanderso
Reason for reverting: Blocking the roll to the framework
Original PR Author: skia-flutter-autoroll
Reviewed By: {fluttergithubbot}
This change reverts the following previous change:
Original Description:
https://dart.googlesource.com/sdk.git/+log/452dd17120b7..322c81160fa9
2024-02-07 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com Version 3.4.0-117.0.dev
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/dart-sdk-flutter-engine
Please CC chinmaygarde@google.com ,dart-vm-team@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter Engine: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-02-07 20:28:18 +00:00
skia-flutter-autoroll
d921fd88a6
Roll Skia from a2fe78a31a14 to eacaa2d3600c (3 revisions) ( flutter/engine#50445 )
...
https://skia.googlesource.com/skia.git/+log/a2fe78a31a14..eacaa2d3600c
2024-02-07 skia-autoroll@skia-public.iam.gserviceaccount.com Manual roll Dawn from 79a1c20bb582 to ca9f38634fcf (9 revisions)
2024-02-07 skia-autoroll@skia-public.iam.gserviceaccount.com Roll debugger-app-base from d2ed43ed5bb9 to 3acd3682009f
2024-02-07 skia-autoroll@skia-public.iam.gserviceaccount.com Roll SK Tool from 07d4dd3ca04b to 35d65e587f8e
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC brianosman@google.com ,bungeman@google.com,chinmaygarde@google.com,rmistry@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-02-07 20:04:59 +00:00
Chinmay Garde
c00c8fe2a0
[Impeller] Initialize the stencil reference value. ( flutter/engine#50373 )
...
Viewports, scissors, and stencil reference values are part of the dynamic state and must be initialized in the case where the caller doesn't set any value via the render pass.
Fixes https://github.com/flutter/flutter/issues/142943
2024-02-07 19:42:21 +00:00
skia-flutter-autoroll
86902dbe24
Roll Skia from 9b103a4148e2 to a2fe78a31a14 (2 revisions) ( flutter/engine#50441 )
...
https://skia.googlesource.com/skia.git/+log/9b103a4148e2..a2fe78a31a14
2024-02-07 johnstiles@google.com Revert "Remove GR_TEST_UTILS from module loader."
2024-02-07 johnstiles@google.com Remove GR_TEST_UTILS from module loader.
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC brianosman@google.com ,bungeman@google.com,chinmaygarde@google.com,rmistry@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-02-07 19:12:53 +00:00
gaaclarke
d5a2976258
Fixed CONTRIBUTING.md markdown lints ( flutter/engine#50439 )
...
## Pre-launch Checklist
- [x] I read the [Contributor Guide] and followed the process outlined
there for submitting PRs.
- [x] I read the [Tree Hygiene] wiki page, which explains my
responsibilities.
- [x] I read and followed the [Flutter Style Guide] and the [C++,
Objective-C, Java style guides].
- [x] I listed at least one issue that this PR fixes in the description
above.
- [x] I added new tests to check the change I am making or feature I am
adding, or the PR is [test-exempt]. See [testing the engine] for
instructions on writing and running engine tests.
- [x] I updated/added relevant documentation (doc comments with `///`).
- [x] I signed the [CLA].
- [x] All existing and new tests are passing.
If you need help, consider asking for advice on the #hackers-new channel
on [Discord].
<!-- Links -->
[Contributor Guide]:
https://github.com/flutter/flutter/wiki/Tree-hygiene#overview
[Tree Hygiene]: https://github.com/flutter/flutter/wiki/Tree-hygiene
[test-exempt]:
https://github.com/flutter/flutter/wiki/Tree-hygiene#tests
[Flutter Style Guide]:
https://github.com/flutter/flutter/wiki/Style-guide-for-Flutter-repo
[C++, Objective-C, Java style guides]:
https://github.com/flutter/engine/blob/main/CONTRIBUTING.md#style
[testing the engine]:
https://github.com/flutter/flutter/wiki/Testing-the-engine
[CLA]: https://cla.developers.google.com/
[flutter/tests]: https://github.com/flutter/tests
[breaking change policy]:
https://github.com/flutter/flutter/wiki/Tree-hygiene#handling-breaking-changes
[Discord]: https://github.com/flutter/flutter/wiki/Chat
2024-02-07 10:27:07 -08:00
skia-flutter-autoroll
c52aac60fe
Roll Skia from 7777976cd518 to 9b103a4148e2 (1 revision) ( flutter/engine#50438 )
...
https://skia.googlesource.com/skia.git/+log/7777976cd518..9b103a4148e2
2024-02-07 jvanverth@google.com Remove some uses of GRAPHITE_TEST_UTILS outside of src/gpu/graphite.
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC brianosman@google.com ,bungeman@google.com,chinmaygarde@google.com,rmistry@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-02-07 18:06:01 +00:00
skia-flutter-autoroll
4611aadcc5
Roll Dart SDK from 452dd17120b7 to 322c81160fa9 (1 revision) ( flutter/engine#50437 )
...
https://dart.googlesource.com/sdk.git/+log/452dd17120b7..322c81160fa9
2024-02-07 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com Version 3.4.0-117.0.dev
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/dart-sdk-flutter-engine
Please CC chinmaygarde@google.com ,dart-vm-team@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter Engine: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-02-07 17:54:18 +00:00
zijiehe@
9a5734f5a9
Redo "[Fuchsia] Execute most of the testing/fuchsia/test_suites.yaml on debug and release builds" ( flutter/engine#50408 )
...
Reverts flutter/engine#50407 ,
https://github.com/flutter/flutter/issues/142811 , redo
https://github.com/flutter/engine/pull/50058 .
Comparing to the original change, this redo disabled lto / link time
optimization for x64 release builder. It's a known issue that lto
increased the compilation time from <5 min to over 30 min. (See commit
a1b104c61bhttps://github.com/flutter/flutter/issues/140179
## Pre-launch Checklist
- [x] I read the [Contributor Guide] and followed the process outlined
there for submitting PRs.
- [x] I read the [Tree Hygiene] wiki page, which explains my
responsibilities.
- [x] I read and followed the [Flutter Style Guide] and the [C++,
Objective-C, Java style guides].
- [x] I listed at least one issue that this PR fixes in the description
above.
- [x] I added new tests to check the change I am making or feature I am
adding, or the PR is [test-exempt]. See [testing the engine] for
instructions on writing and running engine tests.
- [x] I updated/added relevant documentation (doc comments with `///`).
- [x] I signed the [CLA].
- [x] All existing and new tests are passing.
If you need help, consider asking for advice on the #hackers-new channel
on [Discord].
<!-- Links -->
[Contributor Guide]:
https://github.com/flutter/flutter/wiki/Tree-hygiene#overview
[Tree Hygiene]: https://github.com/flutter/flutter/wiki/Tree-hygiene
[test-exempt]:
https://github.com/flutter/flutter/wiki/Tree-hygiene#tests
[Flutter Style Guide]:
https://github.com/flutter/flutter/wiki/Style-guide-for-Flutter-repo
[C++, Objective-C, Java style guides]:
https://github.com/flutter/engine/blob/main/CONTRIBUTING.md#style
[testing the engine]:
https://github.com/flutter/flutter/wiki/Testing-the-engine
[CLA]: https://cla.developers.google.com/
[flutter/tests]: https://github.com/flutter/tests
[breaking change policy]:
https://github.com/flutter/flutter/wiki/Tree-hygiene#handling-breaking-changes
[Discord]: https://github.com/flutter/flutter/wiki/Chat
2024-02-07 09:50:23 -08:00
Zachary Anderson
1fc1563a3f
Update NDK to version 26 ( flutter/engine#48254 )
...
This PR adjusts the GN build for a newer Android NDK. It relies on
https://github.com/flutter/buildroot/pull/822 .
2024-02-07 08:42:08 -08:00
skia-flutter-autoroll
19172af900
Roll Skia from 0fb71bedffa2 to 7777976cd518 (3 revisions) ( flutter/engine#50435 )
...
https://skia.googlesource.com/skia.git/+log/0fb71bedffa2..7777976cd518
2024-02-07 borenet@google.com Remove remaining Pixel7 jobs
2024-02-07 skia-autoroll@skia-public.iam.gserviceaccount.com Manual roll Dawn from 723c1871d30b to 79a1c20bb582 (5 revisions)
2024-02-07 skia-autoroll@skia-public.iam.gserviceaccount.com Roll vulkan-deps from 6ad0d5fca2ca to f9306036975c (6 revisions)
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC brianosman@google.com ,bungeman@google.com,chinmaygarde@google.com,rmistry@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-02-07 15:22:14 +00:00
ᠵᠠᠭᠠᠨᠵᠠᠪ ᠪᠤᠷᠵᠢᠭᠤᠳ ᠰᠠᠴᠤᠷᠠᠭ
af574f2aae
Fix: On the Web, cannot support multiline inputting when registering customized TextInputControl ( flutter/engine#45522 )
...
For [flutter/flutter/125875](https://github.com/flutter/flutter/issues/125875 )
When registering customized TextInputControl, the _PlatformTextInputControl sends inputType = TextInputType.none to the engine. After receiving TextInputType.none, the engine on the Web will create a `<input>` element instead of `<textarea>`. So there is no way to input \n(multiline).
This is my solution. I tested in Android Chrome, iOS Safari, and macOS Chrome. It works for me. But I'm not sure about other use cases. I pleasure, If someone gives me suggestions.
2024-02-07 15:15:00 +00:00
skia-flutter-autoroll
bb1dab9840
Roll Skia from 3cc2a15196cb to 0fb71bedffa2 (1 revision) ( flutter/engine#50429 )
...
https://skia.googlesource.com/skia.git/+log/3cc2a15196cb..0fb71bedffa2
2024-02-07 skia-autoroll@skia-public.iam.gserviceaccount.com Roll ANGLE from e62bd70a6c74 to 8abbe2836bb4 (3 revisions)
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC brianosman@google.com ,bungeman@google.com,chinmaygarde@google.com,rmistry@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-02-07 07:27:08 +00:00
skia-flutter-autoroll
a421599cf0
Roll Skia from 1b266b36a4c8 to 3cc2a15196cb (1 revision) ( flutter/engine#50427 )
...
https://skia.googlesource.com/skia.git/+log/1b266b36a4c8..3cc2a15196cb
2024-02-07 skia-autoroll@skia-public.iam.gserviceaccount.com Roll Dawn from bdc7e32ee461 to 723c1871d30b (4 revisions)
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC brianosman@google.com ,bungeman@google.com,chinmaygarde@google.com,rmistry@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-02-07 05:43:22 +00:00
Brandon DeRosier
e4e1d5cc21
[Impeller] Always pop clips on restore. ( flutter/engine#50419 )
...
Fixes https://github.com/flutter/flutter/issues/142846
We need to always resolve clips when `Restore()` is called. Before, I just had it resolving the clips for canvas xformation stack entires created via `SaveLayer`.
2024-02-07 05:17:10 +00:00
skia-flutter-autoroll
6c88cab2c4
Roll Dart SDK from 35269fa71956 to 452dd17120b7 (1 revision) ( flutter/engine#50424 )
...
https://dart.googlesource.com/sdk.git/+log/35269fa71956..452dd17120b7
2024-02-06 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com Version 3.4.0-116.0.dev
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/dart-sdk-flutter-engine
Please CC chinmaygarde@google.com ,dart-vm-team@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter Engine: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-02-07 01:47:09 +00:00
skia-flutter-autoroll
5ef560788c
Roll Skia from fd55a6bd3580 to 1b266b36a4c8 (1 revision) ( flutter/engine#50423 )
...
https://skia.googlesource.com/skia.git/+log/fd55a6bd3580..1b266b36a4c8
2024-02-06 skia-autoroll@skia-public.iam.gserviceaccount.com Roll vulkan-deps from 32051b1fe7ae to 6ad0d5fca2ca (12 revisions)
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC brianosman@google.com ,bungeman@google.com,chinmaygarde@google.com,rmistry@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-02-07 00:38:12 +00:00
skia-flutter-autoroll
3acebcbb84
Roll Skia from 44106ee8edea to fd55a6bd3580 (17 revisions) ( flutter/engine#50420 )
...
https://skia.googlesource.com/skia.git/+log/44106ee8edea..fd55a6bd3580
2024-02-06 johnstiles@google.com Update Tint method calls to match new style.
2024-02-06 herb@google.com Legacy flag SK_USE_FAST_UNPREMUL
2024-02-06 skia-autoroll@skia-public.iam.gserviceaccount.com Roll SK Tool from 4e1f58585b72 to 229ccfa616f1
2024-02-06 skia-autoroll@skia-public.iam.gserviceaccount.com Roll jsfiddle-base from fad68ece4009 to b575daa903da
2024-02-06 skia-autoroll@skia-public.iam.gserviceaccount.com Roll shaders-base from bf2a9ca94ef9 to 89826f3f6f5d
2024-02-06 skia-autoroll@skia-public.iam.gserviceaccount.com Manual roll Dawn from c9c20468546f to bdc7e32ee461 (27 revisions)
2024-02-06 skia-autoroll@skia-public.iam.gserviceaccount.com Roll debugger-app-base from d3314cdd050f to d2ed43ed5bb9
2024-02-06 herb@google.com Move rgbA_to_RGBA to specific opts
2024-02-06 skia-autoroll@skia-public.iam.gserviceaccount.com Roll skottie-base from f883f8608613 to 906e4c4c9b17
2024-02-06 skia-autoroll@skia-public.iam.gserviceaccount.com Roll skottie-base from 906e4c4c9b17 to f883f8608613
2024-02-06 skia-autoroll@skia-public.iam.gserviceaccount.com Roll shaders-base from 89826f3f6f5d to bf2a9ca94ef9
2024-02-06 michaelludwig@google.com [skif] Consolidate bounds analysis, refine flags
2024-02-06 kjlubick@google.com Remove old type union from GrGLInterface.h
2024-02-06 skia-autoroll@skia-public.iam.gserviceaccount.com Roll jsfiddle-base from b575daa903da to fad68ece4009
2024-02-06 skia-autoroll@skia-public.iam.gserviceaccount.com Roll debugger-app-base from d2ed43ed5bb9 to d3314cdd050f
2024-02-06 herb@google.com Implement bare bones unpremul conversions
2024-02-06 kjlubick@google.com Stop defining 'GR_TEST_UTILS' in G3
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC brianosman@google.com ,bungeman@google.com,chinmaygarde@google.com,rmistry@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-02-06 23:48:38 +00:00
Brandon DeRosier
06dc0e966f
[Impeller] Fix pipeline attachment layout in CanRenderToTexture. ( flutter/engine#50413 )
...
The pipeline descriptor defaults changed, so we need to align the attachments to the RenderPass in this test.
Should fix https://github.com/flutter/flutter/issues/142868 .
2024-02-06 23:13:04 +00:00
Ian Hickson
05e5a97357
Provide toStrings for Native objects ( flutter/engine#50168 )
...
This hides the "Instance of _Native" bit that you get in debug output otherwise.
2024-02-06 22:39:00 +00:00
skia-flutter-autoroll
afa905d10f
Roll Dart SDK from 29265c94a6e8 to 35269fa71956 (1 revision) ( flutter/engine#50402 )
...
https://dart.googlesource.com/sdk.git/+log/29265c94a6e8..35269fa71956
2024-02-06 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com Version 3.4.0-115.0.dev
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/dart-sdk-flutter-engine
Please CC chinmaygarde@google.com ,dart-vm-team@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter Engine: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-02-06 19:19:01 +00:00
keyonghan
680d87ab9d
Add use_rbe to gclient variables for Framework Smoke Tests ( flutter/engine#50403 )
...
This is to enable rbe support. Part of https://github.com/flutter/flutter/issues/142986
2024-02-06 19:18:59 +00:00
auto-submit[bot]
6173975c27
Reverts "Revert "Revert "[Fuchsia] Execute most of the testing/fuchsia/test_suites.yaml on debug and release builds""" ( flutter/engine#50407 )
...
Reverts "Reland "[Fuchsia] Execute most of the testing/fuchsia/test_suites.yaml on debug and release builds"""
Reverts flutter/engine#50295
Initiated by: zanderso
Reason for reverting: Timing out on CI
Original PR Author: zijiehe-google-com
Reviewed By: {keyonghan}
This change reverts the following previous change:
Original Description:
Reverts flutter/engine#50291 , https://github.com/flutter/flutter/issues/142811
Following is the original change description.
This change implements a BundledTestRunner to run most of the tests in testing/fuchsia/test_suites.yaml as ExecutableTestRunner.
- Tests with packages out of out/fuchsia_*_x64/ are ignored for now.
- Tests with extra test command line parameters are ignored for now.
The BundledTestRunner can share most of the logic in ExecutableTestRunner and avoid reinventing the wheel.
This change also fixes the build break of fuchsia_tests in fuchsia_release_x64 which allows tests to run on the build as well.
- Tests not built with AOT are filtered out with variant field in test_suites.yaml.
Bug: https://github.com/flutter/flutter/issues/140179
[C++, Objective-C, Java style guides]: https://github.com/flutter/engine/blob/main/CONTRIBUTING.md#style
2024-02-06 18:49:25 +00:00
Matan Lurey
4ed520b2af
Skip flaking test on Windows nobody is fixing. ( flutter/engine#50401 )
...
Filed https://github.com/flutter/flutter/issues/142991 to re-enable.
2024-02-06 10:23:06 -08:00
auto-submit[bot]
911b1400ea
Reverts "[web] Fix Scene clip bounds. Trigger resize on DPR Change." ( flutter/engine#50404 )
...
Reverts flutter/engine#50161
Initiated by: jonahwilliams
Reason for reverting: This is causing what looks like bogus goldens on the framework -> engine roll: https://github.com/flutter/flutter/pull/142966
Original PR Author: ditman
Reviewed By: {yjbanov, mdebbar}
This change reverts the following previous change:
Original Description:
The Scene of the HTML renderer is passing incorrect size information to the engine, and when DPR<1, it can result in elements being culled off of the viewport.
In addition to that, when an app is embedded, not all changes in DPR cause a Resize event (only those some of the dimensions fails by a rounding error!), so this PR ensures that all DPR events in embedded trigger a resize event.
### Issues
Fixes https://github.com/flutter/flutter/issues/129182
### Testing
Looking good at: https://dit-astral-test.web.app
[C++, Objective-C, Java style guides]: https://github.com/flutter/engine/blob/main/CONTRIBUTING.md#style
2024-02-06 17:35:47 +00:00
zijiehe@
76dce91cf2
Revert "Revert "[Fuchsia] Execute most of the testing/fuchsia/test_suites.yaml on debug and release builds"" ( flutter/engine#50295 )
...
Reverts flutter/engine#50291 ,
https://github.com/flutter/flutter/issues/142811
Following is the original change description.
This change implements a BundledTestRunner to run most of the tests in
testing/fuchsia/test_suites.yaml as ExecutableTestRunner.
- Tests with packages out of out/fuchsia_*_x64/ are ignored for now.
- Tests with extra test command line parameters are ignored for now.
The BundledTestRunner can share most of the logic in
ExecutableTestRunner and avoid reinventing the wheel.
This change also fixes the build break of fuchsia_tests in
fuchsia_release_x64 which allows tests to run on the build as well.
- Tests not built with AOT are filtered out with variant field in
test_suites.yaml.
Bug: https://github.com/flutter/flutter/issues/140179
## Pre-launch Checklist
- [x] I read the [Contributor Guide] and followed the process outlined
there for submitting PRs.
- [x] I read the [Tree Hygiene] wiki page, which explains my
responsibilities.
- [x] I read and followed the [Flutter Style Guide] and the [C++,
Objective-C, Java style guides].
- [x] I listed at least one issue that this PR fixes in the description
above.
- [x] I added new tests to check the change I am making or feature I am
adding, or the PR is [test-exempt]. See [testing the engine] for
instructions on writing and running engine tests.
- [x] I updated/added relevant documentation (doc comments with `///`).
- [x] I signed the [CLA].
- [x] All existing and new tests are passing.
If you need help, consider asking for advice on the #hackers-new channel
on [Discord].
<!-- Links -->
[Contributor Guide]:
https://github.com/flutter/flutter/wiki/Tree-hygiene#overview
[Tree Hygiene]: https://github.com/flutter/flutter/wiki/Tree-hygiene
[test-exempt]:
https://github.com/flutter/flutter/wiki/Tree-hygiene#tests
[Flutter Style Guide]:
https://github.com/flutter/flutter/wiki/Style-guide-for-Flutter-repo
[C++, Objective-C, Java style guides]:
https://github.com/flutter/engine/blob/main/CONTRIBUTING.md#style
[testing the engine]:
https://github.com/flutter/flutter/wiki/Testing-the-engine
[CLA]: https://cla.developers.google.com/
[flutter/tests]: https://github.com/flutter/tests
[breaking change policy]:
https://github.com/flutter/flutter/wiki/Tree-hygiene#handling-breaking-changes
[Discord]: https://github.com/flutter/flutter/wiki/Chat
2024-02-06 09:34:53 -08:00
Chinmay Garde
9d32cac3ed
[Impeller] Specify if Angle or SwiftShader is being used in the title. ( flutter/engine#50376 )
...
Minor QOL improvement. Tried taking a frame capture unsuccessfully before realizing that I was using SwiftShader.
2024-02-06 17:33:45 +00:00
Matan Lurey
5d1cc934ad
Run all Android scenario_app tests, not just the smoke test. ( flutter/engine#50400 )
...
I was making sure that I could get at least one test running and passing
on CI (as expected), now turn all of them on.
2024-02-06 09:15:08 -08:00
skia-flutter-autoroll
473f0508b3
Roll Dart SDK from b62066b42af0 to 29265c94a6e8 (10 revisions) ( flutter/engine#50398 )
...
https://dart.googlesource.com/sdk.git/+log/b62066b42af0..29265c94a6e8
2024-02-06 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com Version 3.4.0-114.0.dev
2024-02-06 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com Version 3.4.0-113.0.dev
2024-02-06 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com Version 3.4.0-112.0.dev
2024-02-05 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com Version 3.4.0-111.0.dev
2024-02-05 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com Version 3.4.0-110.0.dev
2024-02-05 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com Version 3.4.0-109.0.dev
2024-02-05 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com Version 3.4.0-108.0.dev
2024-02-03 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com Version 3.4.0-107.0.dev
2024-02-03 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com Version 3.4.0-106.0.dev
2024-02-02 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com Version 3.4.0-105.0.dev
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/dart-sdk-flutter-engine
Please CC chinmaygarde@google.com ,dart-vm-team@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter Engine: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-02-06 16:48:31 +00:00
Matan Lurey
8db41b6544
Capture FAILURES!!! when running Android scenario_app tests. ( flutter/engine#50255 )
...
I expect `Linux linux_android_emulator_tests` and `Linux
linux_android_emulator_tests_api_33` to fail.
When they fail, I'll fix the assertion
(https://github.com/flutter/flutter/issues/142746 ) before merging this
PR.
2024-02-06 08:42:14 -08:00
Jonny Wang
eb4b07ee1d
[fuchsia] Bump Fuchsia's API level to 16 ( flutter/engine#50358 )
...
Update Fuchsia's API level to 16.
b/322503140
## Pre-launch Checklist
- [x] I read the [Contributor Guide] and followed the process outlined
there for submitting PRs.
- [x] I read the [Tree Hygiene] wiki page, which explains my
responsibilities.
- [x] I read and followed the [Flutter Style Guide] and the [C++,
Objective-C, Java style guides].
- [x] I listed at least one issue that this PR fixes in the description
above.
- [x] I added new tests to check the change I am making or feature I am
adding, or the PR is [test-exempt]. See [testing the engine] for
instructions on writing and running engine tests.
- [x] I updated/added relevant documentation (doc comments with `///`).
- [x] I signed the [CLA].
- [x] All existing and new tests are passing.
2024-02-06 15:34:37 +00:00
skia-flutter-autoroll
1f1f04cac9
Roll Skia from 9e68ed6caf6d to 44106ee8edea (1 revision) ( flutter/engine#50393 )
...
https://skia.googlesource.com/skia.git/+log/9e68ed6caf6d..44106ee8edea
2024-02-06 skia-autoroll@skia-public.iam.gserviceaccount.com Roll vulkan-deps from 83223ec30684 to 32051b1fe7ae (9 revisions)
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC brianosman@google.com ,bungeman@google.com,chinmaygarde@google.com,rmistry@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-02-06 11:09:21 +00:00
skia-flutter-autoroll
fdf212b2fe
Roll Skia from c29a20702356 to 9e68ed6caf6d (1 revision) ( flutter/engine#50392 )
...
https://skia.googlesource.com/skia.git/+log/c29a20702356..9e68ed6caf6d
2024-02-06 skia-autoroll@skia-public.iam.gserviceaccount.com Roll ANGLE from 5a0615588a1a to e62bd70a6c74 (4 revisions)
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC brianosman@google.com ,bungeman@google.com,chinmaygarde@google.com,rmistry@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-02-06 09:45:17 +00:00
Jonah Williams
a70478263d
[Impeller] Cache RenderPass/Framebuffer objects on the resolve texture sources. ( flutter/engine#50142 )
...
Cache vk::RenderPass and vk::Framebuffer objects on the resolve texture of any render target attachments. Use these on the next frame unconditionally.
Fixes https://github.com/flutter/flutter/issues/141750
2024-02-06 04:35:05 +00:00
Jason Simmons
39a6ac669f
[Impeller] Do not skip the GLES render pass if the command list is empty ( flutter/engine#50381 )
...
The render pass may need to apply other changes such as painting the clear color.
See https://github.com/flutter/flutter/issues/142639
2024-02-06 02:43:27 +00:00
skia-flutter-autoroll
dfd78684bd
Roll Skia from cdf214adfb4d to c29a20702356 (54 revisions) ( flutter/engine#50382 )
...
Roll Skia from cdf214adfb4d to c29a20702356 (54 revisions)
https://skia.googlesource.com/skia.git/+log/cdf214adfb4d..c29a20702356
2024-02-06 brianosman@google.com Bring back DISABLE_LOWP
2024-02-06 skia-autoroll@skia-public.iam.gserviceaccount.com Roll ANGLE from f8c06f103a1f to 5a0615588a1a (10 revisions)
2024-02-05 lokokung@google.com Migrates graphite's main wait mechanism from using Tick to ProcessEvents.
2024-02-05 skia-autoroll@skia-public.iam.gserviceaccount.com Roll vulkan-deps from 3a55a3d5ee47 to 83223ec30684 (1 revision)
2024-02-05 fmalita@chromium.org [skottie] Fix supernormal spatial interpolation
2024-02-05 robertphillips@google.com [graphite] Add new Graphite Precompilation DMSink
2024-02-05 skia-autoroll@skia-public.iam.gserviceaccount.com Roll Dawn from dd852a700405 to c9c20468546f (26 revisions)
2024-02-05 skia-autoroll@skia-public.iam.gserviceaccount.com Roll SK Tool from 9a1a69ed50c4 to 5c8f3c7d6467
2024-02-05 kjlubick@google.com Fix skottie rules for G3
2024-02-05 kjlubick@google.com Temporarily disable animated_gif.cpp from Bazel test
2024-02-05 kjlubick@google.com Add bazel modules for Skottie and sksg
2024-02-03 skia-autoroll@skia-public.iam.gserviceaccount.com Roll vulkan-deps from a1def468c6b4 to 3a55a3d5ee47 (9 revisions)
2024-02-03 skia-autoroll@skia-public.iam.gserviceaccount.com Roll SK Tool from 8af152c5f7ce to 9a1a69ed50c4
2024-02-02 kjlubick@google.com Fix copypasta in public.bzl
2024-02-02 kjlubick@google.com Guard some gms/tests that require Skottie code
2024-02-02 skia-autoroll@skia-public.iam.gserviceaccount.com Roll jsfiddle-base from 969399a89649 to b575daa903da
2024-02-02 skia-autoroll@skia-public.iam.gserviceaccount.com Roll shaders-base from 9054c5988daf to 89826f3f6f5d
2024-02-02 skia-autoroll@skia-public.iam.gserviceaccount.com Roll skottie-base from 9ce4d2efff0c to 906e4c4c9b17
2024-02-02 skia-autoroll@skia-public.iam.gserviceaccount.com Roll debugger-app-base from 54bf3755c837 to d2ed43ed5bb9
2024-02-02 bungeman@google.com [unicode] Fix SkBreakIterator_libgrapheme
2024-02-02 skia-autoroll@skia-public.iam.gserviceaccount.com Roll vulkan-deps from 07589c29ccba to a1def468c6b4 (1 revision)
2024-02-02 kjlubick@google.com Make SVG backend explicitly depend on JPEG+PNG for OpenType
2024-02-02 kjlubick@google.com Add Bazel target for modular build of SkResources
2024-02-02 kjlubick@google.com Remove SkAnimCodecPlayer from the public API
2024-02-02 skia-autoroll@skia-public.iam.gserviceaccount.com Roll skottie-base from 5b5661dc98c7 to 9ce4d2efff0c
2024-02-02 skia-autoroll@skia-public.iam.gserviceaccount.com Roll shaders-base from e7695f0fdff5 to 9054c5988daf
2024-02-02 skia-autoroll@skia-public.iam.gserviceaccount.com Roll jsfiddle-base from f6c22747cda4 to 969399a89649
2024-02-02 skia-autoroll@skia-public.iam.gserviceaccount.com Roll debugger-app-base from 067d72e0dddf to 54bf3755c837
2024-02-02 johnstiles@google.com Fix fuzzer-discovered timeout by caching uniform information.
2024-02-02 bungeman@google.com [pdf] Properly handle drawing not on a page
2024-02-02 johnstiles@google.com Add method Type::isAllowedInUniform.
2024-02-02 brianosman@google.com Remove SK_DISABLE_LOWP_RASTER_PIPELINE
2024-02-02 drott@chromium.org [Fontations-backend] Minor: Remove return statement
2024-02-02 49699333+dependabot[bot]@users.noreply.github.com Bump follow-redirects from 1.14.8 to 1.15.5
2024-02-02 49699333+dependabot[bot]@users.noreply.github.com Bump socket.io-parser from 4.2.2 to 4.2.4 in /modules/canvaskit
2024-02-02 49699333+dependabot[bot]@users.noreply.github.com Bump jinja2 from 2.11.3 to 3.1.3
2024-02-02 kjlubick@google.com Update Bazel rules after vulkan_header update
2024-02-02 skia-autoroll@skia-public.iam.gserviceaccount.com Roll ANGLE from 1abfdc37320f to f8c06f103a1f (3 revisions)
2024-02-02 skia-autoroll@skia-public.iam.gserviceaccount.com Roll vulkan-deps from 82b9fb3ddb57 to 07589c29ccba (6 revisions)
2024-02-02 skia-autoroll@skia-public.iam.gserviceaccount.com Roll SK Tool from e83737e1d145 to b8aac8b590af
2024-02-02 skia-autoroll@skia-public.iam.gserviceaccount.com Roll Skia Infra from 6e97526ab534 to e83737e1d145 (14 revisions)
2024-02-02 skia-autoroll@skia-public.iam.gserviceaccount.com Roll SwiftShader from 78d1799ee43e to eb75201a4e03 (2 revisions)
2024-02-02 skia-autoroll@skia-public.iam.gserviceaccount.com Roll Dawn from 2c3a08ff64ba to dd852a700405 (8 revisions)
2024-02-02 bungeman@google.com Revert "[pdf] Properly handle drawing not on a page"
2024-02-02 johnstiles@google.com Add BUILD.gn cleanups to zlib.
2024-02-01 kjlubick@google.com Make SkScalarContext for Windows DirectWrite explicitly decode PNGs
...
2024-02-06 02:09:20 +00:00
David Iglesias
76129ffb8f
[web] Fix Scene clip bounds. Trigger resize on DPR Change. ( flutter/engine#50161 )
...
The Scene of the HTML renderer is passing incorrect size information to the engine, and when DPR<1, it can result in elements being culled off of the viewport.
In addition to that, when an app is embedded, not all changes in DPR cause a Resize event (only those some of the dimensions fails by a rounding error!), so this PR ensures that all DPR events in embedded trigger a resize event.
### Issues
Fixes https://github.com/flutter/flutter/issues/129182
### Testing
Looking good at: https://dit-astral-test.web.app
[C++, Objective-C, Java style guides]: https://github.com/flutter/engine/blob/main/CONTRIBUTING.md#style
2024-02-06 01:48:00 +00:00
Xilai Zhang
db877dd92a
[github actions] add cherry pick workflow for engine repo ( flutter/engine#50265 )
...
Follow up from sync with @itsjustkevin : Add cherry pick github actions to flutter/engine repository.
Would have the same functionalities as https://github.com/flutter/flutter/blob/master/.github/workflows/easy-cp.yml .
@godofredoc would be great if we could add [actions bot token](https://valentine.corp.google.com/#/show/1702960394753966?tab=metadata ) as a secret under the name FLUTTERACTIONSBOT_CP_TOKEN to the engine repository too. Thank you!
2024-02-06 01:31:54 +00:00
gaaclarke
10c52df4fb
[Impeller] blur: hold on to 1/8 downsample until the kernel overflows ( flutter/engine#50363 )
...
issue: https://github.com/flutter/flutter/issues/142753
After https://github.com/flutter/engine/pull/50262 there were still some
sigmas that could show shimmering around the sigma [50, 100] range which
had a downsample amount of 1/16. This makes those ranges hang on to 1/8
for as long as possible. I'm unable to see any shimmering with
`AiksTest.GaussianBlurAnimatedBackdrop` after this PR. I've also
expanded that test so the clip region could be scaled to make sure that
there aren't sizes which cause it to reappear.
Testing: Expanded on manual testing. Since the error only manifests when
evaluating multiple frames of rendering we don't have infrastructure to
test that.
Here is the graph of `GaussianBlurFilterContents::CalculateScale` after
this change:
<img width="903" alt="Screenshot 2024-02-05 at 2 10 41 PM"
src="https://github.com/flutter/engine/assets/30870216/ac3b735a-95f0-4d7b-af12-58e1ae75278e ">
## Pre-launch Checklist
- [x] I read the [Contributor Guide] and followed the process outlined
there for submitting PRs.
- [x] I read the [Tree Hygiene] wiki page, which explains my
responsibilities.
- [x] I read and followed the [Flutter Style Guide] and the [C++,
Objective-C, Java style guides].
- [x] I listed at least one issue that this PR fixes in the description
above.
- [x] I added new tests to check the change I am making or feature I am
adding, or the PR is [test-exempt]. See [testing the engine] for
instructions on writing and running engine tests.
- [x] I updated/added relevant documentation (doc comments with `///`).
- [x] I signed the [CLA].
- [x] All existing and new tests are passing.
If you need help, consider asking for advice on the #hackers-new channel
on [Discord].
<!-- Links -->
[Contributor Guide]:
https://github.com/flutter/flutter/wiki/Tree-hygiene#overview
[Tree Hygiene]: https://github.com/flutter/flutter/wiki/Tree-hygiene
[test-exempt]:
https://github.com/flutter/flutter/wiki/Tree-hygiene#tests
[Flutter Style Guide]:
https://github.com/flutter/flutter/wiki/Style-guide-for-Flutter-repo
[C++, Objective-C, Java style guides]:
https://github.com/flutter/engine/blob/main/CONTRIBUTING.md#style
[testing the engine]:
https://github.com/flutter/flutter/wiki/Testing-the-engine
[CLA]: https://cla.developers.google.com/
[flutter/tests]: https://github.com/flutter/tests
[breaking change policy]:
https://github.com/flutter/flutter/wiki/Tree-hygiene#handling-breaking-changes
[Discord]: https://github.com/flutter/flutter/wiki/Chat
2024-02-05 16:32:44 -08:00
skia-flutter-autoroll
78a1d58555
Manual roll Dart SDK from 5a5d4c262200 to b62066b42af0 (5 revisions) ( flutter/engine#50366 )
...
Manual roll requested by zra@google.com
https://dart.googlesource.com/sdk.git/+log/5a5d4c262200..b62066b42af0
2024-02-02 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com
Version 3.4.0-104.0.dev
2024-02-02 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com
Version 3.4.0-103.0.dev
2024-02-02 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com
Version 3.4.0-102.0.dev
2024-02-02 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com
Version 3.4.0-101.0.dev
2024-02-02 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com
Version 3.4.0-100.0.dev
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/dart-sdk-flutter-engine
Please CC dart-vm-team@google.com ,matanl@google.com,zra@google.com on
the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter Engine:
https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
---------
Co-authored-by: Zachary Anderson <zanderso@users.noreply.github.com>
2024-02-05 15:02:54 -08:00
Taha Tesser
5f93393312
Fix iOS password autofill prompt dismissal causes layout to resize ( flutter/engine#50364 )
...
fixes [Save password prompt dismiss is pushing UI up and down](https://github.com/flutter/flutter/issues/112281 )
### Code sample
<details>
<summary>expand to view the code sample</summary>
```dart
import 'package:flutter/material.dart';
void main() => runApp(const MyApp());
class MyApp extends StatelessWidget {
const MyApp({super.key});
@override
Widget build(BuildContext context) {
return const MaterialApp(
debugShowCheckedModeBanner: false,
home: HomePage(),
);
}
}
class HomePage extends StatefulWidget {
const HomePage({super.key});
@override
State<HomePage> createState() => _HomePageState();
}
class _HomePageState extends State<HomePage> {
final TextEditingController controller1 = TextEditingController();
final TextEditingController controller2 = TextEditingController();
@override
void dispose() {
controller1.dispose();
controller2.dispose();
super.dispose();
}
@override
Widget build(BuildContext context) {
return Scaffold( // Replace Scaffold with Material to fix glitch.
body: Center(
child: Column(
mainAxisSize: MainAxisSize.min,
children: <Widget>[
const Text('Login (Without Scaffold)'),
AutofillGroup(
child: Column(
children: <Widget>[
TextField(
controller: controller1,
autofillHints: const <String>[AutofillHints.username],
),
TextField(
controller: controller2,
autofillHints: const <String>[AutofillHints.password],
),
],
),
),
],
),
),
);
}
}
```
</details>
### Before
https://github.com/flutter/engine/assets/48603081/dfe36616-e1dd-4c6c-95b0-e4bd89bd3a6a
### After
https://github.com/flutter/engine/assets/48603081/cfb15252-10cd-4521-a1ef-2cace0004588
[C++, Objective-C, Java style guides]: https://github.com/flutter/engine/blob/main/CONTRIBUTING.md#style
2024-02-05 21:53:03 +00:00
LongCatIsLooong
0c52de1fda
visiblePassword uses ASCII keyboard on iOS (flutter/engine#50293 )
...
Fixes https://github.com/flutter/flutter/issues/129113
The documentation states that the `visiblePassword` input type
> Requests a keyboard with ready access to both letters and numbers.
`UIKeyboardTypeASCIICapable` seems to be the closest match.
[C++, Objective-C, Java style guides]: https://github.com/flutter/engine/blob/main/CONTRIBUTING.md#style
2024-02-05 21:34:09 +00:00
Dan Field
b763483b43
[Impeller] Do not reference this in the submit callback for Metal GPU Surfaces ( flutter/engine#50361 )
...
Fixes https://github.com/flutter/flutter/issues/141351 (speculatively - I have not directly reproduced this in an application, but without this change the added test crashes with a segfault in the submit callback).
If the rasterizer gets torn down, the surface gets released and the submit callback may fire on a collected object. Capturing `this` isn't safe. I'm not quite sure how that could happen from the linked stack trace though, since the draw call and the teardown call should be happening on the raster thread, and if the surface was reset then the draw call should've failed earlier...
The added test causes a segfault without the change.
2024-02-05 20:58:17 +00:00
gaaclarke
b3f6a88647
[Impeller] moved blur aiks tests to their own file ( flutter/engine#50356 )
...
issue: https://github.com/flutter/flutter/issues/140106
[C++, Objective-C, Java style guides]: https://github.com/flutter/engine/blob/main/CONTRIBUTING.md#style
2024-02-05 19:02:21 +00:00
