DEV/flutter_flutter
1
0
Fork 0
mirror of https://github.com/flutter/flutter.git synced 2026-02-20 02:29:02 +08:00
Code Issues Packages Projects Releases Wiki Activity

[Impeller] Do not skip the GLES render pass if the command list is empty (flutter/engine#50381)

Browse Source 
The render pass may need to apply other changes such as painting the clear color.

See https://github.com/flutter/flutter/issues/142639
This commit is contained in:
Jason Simmons 2024-02-05 18:43:27 -08:00 committed by GitHub
parent dfd78684bd
commit 39a6ac669f
1 changed files with 0 additions and 7 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

7
engine/src/flutter/impeller/renderer/backend/gles/render_pass_gles.cc
View File

@ -151,10 +151,6 @@ struct RenderPassData {
const std::shared_ptr<GPUTracerGLES>& tracer) {
TRACE_EVENT0("impeller", "RenderPassGLES::EncodeCommandsInReactor");
if (commands.empty()) {
return true;
}
const auto& gl = reactor.GetProcTable();
#ifdef IMPELLER_DEBUG
tracer->MarkFrameStart(gl);
@ -517,9 +513,6 @@ bool RenderPassGLES::OnEncodeCommands(const Context& context) const {
if (!IsValid()) {
return false;
}
if (commands_.empty()) {
return true;
}
const auto& render_target = GetRenderTarget();
if (!render_target.HasColorAttachment(0u)) {
return false;