1030 Commits

Author SHA1 Message Date
Christopher Fujino
62dc88c192 extend const_finder to allow skipping particular classes (flutter/engine#37257)
* wip

* extend const_finder_test to compile web dills

* add test

* add back tests, including non-const for web

* update run_tests.py

* fix whitespace

* clean up test file

* add new options to cli

* use annotation rather than explicit deny list

* clean up

* Apply suggestions from code review

Co-authored-by: Zachary Anderson <zanderso@users.noreply.github.com>

* clean up

* code review

Co-authored-by: Zachary Anderson <zanderso@users.noreply.github.com>
2022-11-11 23:38:03 +00:00
Jonah Williams
326f54412c [Impeller] null check samplers (flutter/engine#37489)
* [Impeller] null check sampler and assert in Paint

* ++

* ++

* ++

* ++

* Update fragment_shader_test.dart

* ++

* TESTING

* ++

* TESTING

* ++

* ++

* ++

* ++

* ++

* ++

* ++

* ++

* ++

* ++

* ++

* ++

* remove debugging code

* ++

* ++
2022-11-11 01:27:18 +00:00
Kaushik Iska
5b9e42523e [Reland] Add rects to accumulator rather than bounds (#37435) (flutter/engine#37451)
* [Reland] Add rects to accumulator rather than bounds (#37435)

When the accumulator is an `RTreeBoundsAccumulator` rather than a `RectBoundsAccumulator` just accumulating the bounds results in incorrect results as the `rtree` would need to be aware of the constituent non-overlapping rectangles. This would work fine for `RectBoundsAccumulator` as it would just adjust its bounds based on the passed rects.

Fixes: https://github.com/flutter/flutter/issues/113251

* Add a test for nested display list rtree
2022-11-09 10:57:29 +00:00
Kaushik Iska
2155c6ce00 Revert "Add rects to accumulator rather than bounds (#37435)" (flutter/engine#37444)
This reverts commit 10da0743a513f0ae3ae5afb5a6bd99350b881989.
2022-11-08 18:10:14 -05:00
Kaushik Iska
10da0743a5 Add rects to accumulator rather than bounds (flutter/engine#37435)
When the accumulator is an `RTreeBoundsAccumulator` rather than a `RectBoundsAccumulator` just accumulating the bounds results in incorrect results as the `rtree` would need to be aware of the constituent non-overlapping rectangles. This would work fine for `RectBoundsAccumulator` as it would just adjust its bounds based on the passed rects.

Fixes: https://github.com/flutter/flutter/issues/113251
2022-11-08 19:09:49 +00:00
Erik
fd9e9ccd63 [fuchsia] embedding-flutter test (flutter/engine#37052)
* Add embedding-flutter test

* Lint CC files

* GN formatting

* Remove changes to embedder

* Minor refactor

* Remove unused dependencies

* Lint CC files

* Remove comments

* Rename pubspec
2022-11-07 22:04:58 +00:00
ColdPaleLight
922ebdc160 [Android] Speed up the method 'FlutterRenderer.getBitmap' (flutter/engine#37342) 2022-11-07 17:40:09 +00:00
Jenn Magder
64bef739e9 Fix typo in overlay platform view iOS test (flutter/engine#37262) 2022-11-04 17:33:46 +00:00
Jason Simmons
17bcea458b Enter a scope before calling Dart APIs in ThrowIfUIOperationsProhibited (flutter/engine#37226) 2022-11-03 02:14:38 +00:00
Erik
81605481de [fuchsia] mouse-input test (flutter/engine#37221)
Introduces the `mouse-input` test, a straight port from fuchsia.git
2022-11-02 15:53:22 -04:00
Dan Field
21cc000359 Revert "Reland layer state stack" (flutter/engine#37178) 2022-10-31 18:56:18 +00:00
Jonah Williams
6641536611 use shader utils for JSON test (flutter/engine#37176) 2022-10-31 17:42:58 +00:00
Jim Graham
df85a4f401 Reland layer state stack (flutter/engine#37135) 2022-10-30 18:30:22 +00:00
Jonah Williams
4a72fe9fae [Impeller] add supprt for JSON output mode (flutter/engine#37123) 2022-10-29 16:38:16 +00:00
Chris Yang
b7b95e9372 Reland "PlatformView partial blur #36015" (flutter/engine#37086) 2022-10-28 16:43:14 +00:00
Dan Field
248aca72c6 [Impeller] Set resourceOptions/storageMode on MTLTextures created from MTLBuffers. (flutter/engine#37073) 2022-10-28 06:35:21 +00:00
Jim Graham
8ed073eb54 Revert layer state stack (flutter/engine#37090)
* Revert "Fix a clang-tidy warning in display_list_canvas_unittests.cc (#37062)"

This reverts commit 709c6735fc7ed34df36cee23805bdaa7f6969774.

* Revert "Create a mechanism to manage layer state (#36458)"

This reverts commit 501916deb19a8303ca2a3a9bb37692a873d4679e.
2022-10-27 15:29:58 -07:00
Kaushik Iska
1941c2ca48 [Impeller] Wire Flutter's own VulkanMemoryAllocator implementation (flutter/engine#37018) 2022-10-27 20:57:54 +00:00
Chris Yang
1806c34015 Revert "PlatformView partial blur" (flutter/engine#37085) 2022-10-27 18:15:14 +00:00
Chris Yang
d30087802c PlatformView partial blur (flutter/engine#36015) 2022-10-27 18:02:09 +00:00
Jim Graham
501916deb1 Create a mechanism to manage layer state (flutter/engine#36458) 2022-10-26 21:43:10 +00:00
gaaclarke
cb4c9f4727 Clang-tidy: made verbose print out commands and fixed quoting problem for warnings as errors (flutter/engine#37015) 2022-10-26 08:19:12 +00:00
Kaushik Iska
83489bd574 [Impeller] Add a shard for Impeller Vulkan testing (flutter/engine#36965) 2022-10-25 19:29:44 +00:00
Erik
e4db4408be Add touch-input-test to test_suites.yaml (flutter/engine#36900) 2022-10-20 16:37:56 -04:00
Dan Field
25c9713070 [Impeller] Improvements for SSBO codegen (flutter/engine#36619) 2022-10-14 18:44:15 +00:00
Dan Field
cb5d746c25 [Impeller] Add polyline benchmark with lots of cubics and quads. (flutter/engine#36731) 2022-10-13 18:31:04 +00:00
Jenn Magder
59383d2857 Run iOS Scenario apps with Skia and Impeller (flutter/engine#36652) 2022-10-12 00:16:28 +00:00
Alex Wallen
3cd8b9eaa4 Deprecate single semantics tree assumption from platform dispatcher (flutter/engine#36675) 2022-10-10 18:41:16 +00:00
Erik
9f4d9ff82a Add Dart AOT integration test (flutter/engine#36460) 2022-10-07 22:59:15 +00:00
Jenn Magder
14e991255a Use llvm version of libcxxabi instead of patched mirror (flutter/engine#36634) 2022-10-06 23:08:05 +00:00
Jonah Williams
aadc2d3094 Add ImmutableBuffer.fromFilePath (flutter/engine#36623) 2022-10-05 22:18:03 +00:00
Dan Field
e4d709de85 Avoid using non-UTF-8 encoded argv more often (flutter/engine#36590) 2022-10-05 12:03:20 -07:00
Erik
75d2baf5fe Add Dart JIT runner integration test (flutter/engine#36420) 2022-09-27 20:14:16 +00:00
gaaclarke
e41c775200 Removed instances of unnecessary values (flutter/engine#36221) 2022-09-26 21:28:04 +00:00
Alexander Biggs
6751734343 [fuchsia] Add run_unit_tests.sh script. (flutter/engine#36308)
This is a convenience script for running unit tests locally.

To make this script work, I had to move several test exclusions
from test_suites.yaml (which controls running tests on CQ)
to the tests themselves. I think this is for the best because
it makes running the tests locally with behavior that matches
CQ easier.

Also added fuchsia_tests to build_and_copy_to_fuchsia.sh
so it builds the unit tests .far packages by default.

Tested: Ran `run_unit_tests.sh`, all tests pass. Ran
`build_and_copy_to_fuchsia.sh`, it still builds.
2022-09-21 10:40:20 -07:00
Zachary Anderson
16fbee37b3 Removes FragmentProgram.shader() (flutter/engine#35904) 2022-09-21 07:14:12 -07:00
chunhtai
44595a130f Paragraph.GetWordBoundary respects text affinity (flutter/engine#36176) 2022-09-19 22:00:15 +00:00
Jason Simmons
a4543ccec9 Use a linker script to export only the required symbols in the Linux embedder library (flutter/engine#36187) 2022-09-16 22:09:09 +00:00
Greg Spencer
a9e863374e Clamp RRect radii when deflating, assert on negative radii (flutter/engine#36062) 2022-09-15 01:02:56 +00:00
Jonah Williams
8f1cb92a04 [Impeller] expose renderer choice in service extensions (flutter/engine#36103) 2022-09-12 23:24:19 +00:00
Greg Spencer
9454c0743d Add Radius.clamp and Radius.clampValues (flutter/engine#36106) 2022-09-12 23:09:05 +00:00
stuartmorgan
3eb6e7f4c3 Allow Hybrid Composition fallback for Android platform views (flutter/engine#35233) 2022-09-12 16:23:49 +00:00
stuartmorgan
d49e749f10 Remove context assertion from Android platform views using Virtual Display (flutter/engine#35997) 2022-09-09 11:40:30 +00:00
Polina Cherkasova
e0e86ca10b Instrument Image and Picture for leak tracking. (flutter/engine#35274) 2022-09-08 20:13:46 -07:00
Dan Field
08312a825e Lint and fix bugprone-use-after-move violations (flutter/engine#35978) 2022-09-09 02:41:03 +00:00
godofredoc
ca593fb04c Add relative directory support to symbols validation script. (flutter/engine#35936) 2022-09-09 00:37:03 +00:00
Alexander Biggs
aece90bdaa [fuchsia] Port text-input-test, part 1. (flutter/engine#35957)
Part 1 sets up the test to run but the UI has not been
ported yet so the test hangs.

This is mostly a straight port from
https://cs.opensource.google/fuchsia/fuchsia/+/main:src/ui/tests/integration_input_tests/text-input/

There were some nuances:

- Some FIDL APIs are not available in the SDK and have to be
  referenced by name instead (vulkan.Loader, scheduler.ProfileProvider).
- Some subtle differences between the GN rules in fuchsia.git
  vs. engine (e.g. fuchsia_component doesn't append .cm by default to
  CFv2 output).
- Moved shared logic from embedder test into a utils/ folder to
  facilitate writing new tests in the future.

Part 2 will port over the UI to dart:ui.
2022-09-07 11:57:12 -07:00
Jason Simmons
670f8dc88f Roll to a patched version of libcxxabi that is compatible with the latest Clang Mac/iOS toolchain (flutter/engine#35873) 2022-09-07 18:27:16 +00:00
emilyabest
2fd7dde9c8 PlatformView Blur for Backdrop Filter (flutter/engine#34596) 2022-09-06 17:30:57 +00:00
yaakovschectman
e2e7168850 Honor mixed state of tristate Checkbox in Semantics (flutter/engine#35868)
* Honor mixed state

* Add to unit test

* Add state enums

* Fix delimiter

* Add enums

* Scope subtests, rename enum

* Rename enums

* Comment specification

* Tidy up comments

* Rename java enum

* Trailing whitespace
2022-09-06 10:59:25 -04:00