DEV/flutter_flutter
1
0
Fork 0
mirror of https://github.com/flutter/flutter.git synced 2026-02-20 02:29:02 +08:00
Code Issues Packages Projects Releases Wiki Activity

[Impeller] Set resourceOptions/storageMode on MTLTextures created from MTLBuffers. (flutter/engine#37073)

Browse Source
This commit is contained in:
Dan Field 2022-10-27 23:35:21 -07:00 committed by GitHub
parent b767b7b9a9
commit 248aca72c6
2 changed files with 16 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
engine/src/flutter/impeller/renderer/backend/metal/device_buffer_mtl.mm
View File

@ -40,6 +40,10 @@ std::shared_ptr<Texture> DeviceBufferMTL::AsTexture(
return nullptr;
}
if (@available(iOS 13.0, macos 10.15, *)) {
mtl_texture_desc.resourceOptions = buffer_.resourceOptions;
}
auto texture = [buffer_ newTextureWithDescriptor:mtl_texture_desc
offset:0
bytesPerRow:row_bytes];

13
engine/src/flutter/testing/run_tests.py
View File

@ -427,7 +427,18 @@ def RunCCTests(build_dir, filter, coverage, capture_core_dump):
'impeller_unittests',
filter,
shuffle_flags,
coverage=coverage
coverage=coverage,
extra_env={
# See https://developer.apple.com/documentation/metal/diagnosing_metal_programming_issues_early?language=objc
'MTL_SHADER_VALIDATION':
'1', # Enables all shader validation tests.
'MTL_SHADER_VALIDATION_GLOBAL_MEMORY':
'1', # Validates accesses to device and constant memory.
'MTL_SHADER_VALIDATION_THREADGROUP_MEMORY':
'1', # Validates accesses to threadgroup memory.
'MTL_SHADER_VALIDATION_TEXTURE_USAGE':
'1', # Validates that texture references are not nil.
}
)