DEV/flutter_flutter
1
0
Fork 0
mirror of https://github.com/flutter/flutter.git synced 2026-02-20 02:29:02 +08:00
Code Issues Packages Projects Releases Wiki Activity
33,715 Commits 882 Branches 1,069 Tags
Commit Graph

33715 Commits

This Branch
This Branch
All Branches
Author SHA1 Message Date
skia-flutter-autoroll
ac3fa2f552 Roll Skia from c396b2171b16 to be4b398b4f2e (2 revisions) (flutter/engine#49988) 
https://skia.googlesource.com/skia.git/+log/c396b2171b16..be4b398b4f2e

2024-01-23 nicolettep@google.com [graphite] Fix an int value typo
2024-01-23 skia-autoroll@skia-public.iam.gserviceaccount.com Roll vulkan-deps from ba9b221d297c to 53c4c636ae4c (4 revisions)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC brianosman@google.com,jacksongardner@google.com,lovisolo@google.com,rmistry@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2024-01-24 00:47:50 +00:00
skia-flutter-autoroll
58e05b0e65 Roll Dart SDK from 5646ac9669f8 to 838cd732e56a (3 revisions) (flutter/engine#49982) 
https://dart.googlesource.com/sdk.git/+log/5646ac9669f8..838cd732e56a

2024-01-23 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com Version 3.4.0-63.0.dev
2024-01-23 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com Version 3.4.0-62.0.dev
2024-01-23 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com Version 3.4.0-61.0.dev

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/dart-sdk-flutter-engine
Please CC dart-vm-team@google.com,jacksongardner@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter Engine: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2024-01-24 00:15:53 +00:00
Jonah Williams
6f0249a062 [ui] hold a strong reference to fragment program objects. (flutter/engine#49868) 
The native engine needs to hold a strong reference to fragment programs. So the dart side holding a weak ref is more or less pointless
 2024-01-24 00:08:24 +00:00
skia-flutter-autoroll
db041900f3 Roll Skia from 4e42423c7f6f to c396b2171b16 (1 revision) (flutter/engine#49987) 
https://skia.googlesource.com/skia.git/+log/4e42423c7f6f..c396b2171b16

2024-01-23 bungeman@google.com [pdf] Set DisplayDocTitle when title is set

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC brianosman@google.com,jacksongardner@google.com,lovisolo@google.com,rmistry@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2024-01-23 23:58:17 +00:00
skia-flutter-autoroll
3dbc8dc62e Roll Skia from e7d10257ffb5 to 4e42423c7f6f (4 revisions) (flutter/engine#49985) 
https://skia.googlesource.com/skia.git/+log/e7d10257ffb5..4e42423c7f6f

2024-01-23 herb@google.com Fix IWYU problems
2024-01-23 herb@google.com Add Contours
2024-01-23 sharaks@google.com Merge 10 release notes into RELEASE_NOTES.md
2024-01-23 sharaks@google.com Update Skia milestone to 123

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC brianosman@google.com,jacksongardner@google.com,lovisolo@google.com,rmistry@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2024-01-23 23:12:48 +00:00
Matan Lurey
b9e3df7659 Geometry Wars: Documentation Edition (flutter/engine#49910) 
Document some confusing bits of `geometry` for the next bub.

Originally this PR was to add a test and fix a bug, but that's being handled here: https://github.com/flutter/engine/pull/49938.
 2024-01-23 21:55:36 +00:00
Jason Simmons
e870bf885a Exclude the Dart SDK sdk/lib/svg/dart2js directory from the license crawl (flutter/engine#49977) 
This directory contains a file that is generated from other sources.

It is causing problems for the license script because it contains multiple copyright messages and one of the messages is partially included in the header region parsed by the script.
 2024-01-23 21:25:47 +00:00
Zachary Anderson
c1205e974a Roll buildroot to 5d969bd98e31ec90c23ccb982666ace80559f442 (flutter/engine#49956) 
To pick up https://github.com/flutter/buildroot/pull/818

Fixes https://github.com/flutter/flutter/issues/141640
 2024-01-23 21:19:06 +00:00
skia-flutter-autoroll
401e11e2e0 Roll Skia from 59a70a1efc39 to e7d10257ffb5 (3 revisions) (flutter/engine#49978) 
https://skia.googlesource.com/skia.git/+log/59a70a1efc39..e7d10257ffb5

2024-01-23 nicolettep@google.com [graphite] Check if loading from MSAA when setting up Vulkan RenderPasses, pipeline keys
2024-01-23 skia-autoroll@skia-public.iam.gserviceaccount.com Manual roll Dawn from a62b04845e6d to 02262d895ff3 (10 revisions)
2024-01-23 kjlubick@google.com Enforce IWYU on more src/core files

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC brianosman@google.com,jacksongardner@google.com,lovisolo@google.com,rmistry@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2024-01-23 21:04:23 +00:00
Bruno Leroux
2538fd2edb [Web] Fix an assertion error due to synthesized keyboard events (flutter/engine#49087) 
## Description

On Web, browsers can emit key events with a logical key sets to `Process` during compostion.
It is usually not a problem, but in some edge cases (for instance when the browser window lost focus and some keys events were missed), the Flutter web engine might synthesize an up event with a logical key value different that the one used for the down event and this will lead to an assertion message on the framework side.

## Related Issue

Fixes https://github.com/flutter/flutter/issues/126247.

## Tests

Adds 1 test.
 2024-01-23 20:26:12 +00:00
Loïc Sharma
7509954809 [Windows] Introduce egl::Context (flutter/engine#49954) 
This introduces a new `egl::Context` type that abstracts a raw `EGLContext`. This also removes the EGL context logic out from `EGLManager`.

Part of https://github.com/flutter/flutter/issues/141996

[C++, Objective-C, Java style guides]: https://github.com/flutter/engine/blob/main/CONTRIBUTING.md#style
 2024-01-23 20:17:02 +00:00
skia-flutter-autoroll
e0862d3a04 Roll Fuchsia Linux SDK from uQK4l0QeH_PlZO6cF... to kYC2-fFgjbb36mukB... (flutter/engine#49976) 
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/fuchsia-linux-sdk-flutter-engine
Please CC jacksongardner@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2024-01-23 20:10:07 +00:00
skia-flutter-autoroll
7576e76619 Roll Skia from 58973cca0edd to 59a70a1efc39 (17 revisions) (flutter/engine#49975) 
https://skia.googlesource.com/skia.git/+log/58973cca0edd..59a70a1efc39

2024-01-23 kjlubick@google.com Expose all public Vulkan headers in gpu.gni
2024-01-23 jvanverth@google.com [graphite] Add viewer command line option to set path rendering strategy
2024-01-23 skia-autoroll@skia-public.iam.gserviceaccount.com Roll SK Tool from e7ebebe5934b to 234df898a5a7
2024-01-23 jamesgk@google.com [graphite] Don't register mipmap scratch device with recorder
2024-01-23 nicolettep@google.com Disable VK_EXT_shader_object to silence warnings on Windows when using Vulkan 1.3
2024-01-23 drott@chromium.org [Fontations] Roll Fontations libraries
2024-01-23 michaelludwig@google.com [graphite] Expand on comment from review
2024-01-23 kjlubick@google.com Update MutableTextureSurface use in Vulkan+Graphite
2024-01-23 skia-autoroll@skia-public.iam.gserviceaccount.com Roll vulkan-deps from 4307b0183c9e to ba9b221d297c (6 revisions)
2024-01-23 skia-autoroll@skia-public.iam.gserviceaccount.com Roll ANGLE from c6fbf93decba to 341906d568d2 (4 revisions)
2024-01-23 skia-autoroll@skia-public.iam.gserviceaccount.com Roll SwiftShader from 328e794f0c8b to 3bc9ccd923da (2 revisions)
2024-01-23 skia-autoroll@skia-public.iam.gserviceaccount.com Roll Dawn from 5b45794c2c24 to a62b04845e6d (4 revisions)
2024-01-22 bungeman@google.com [pdf] Allow setting the document language
2024-01-22 brianosman@google.com git-sync-deps: Switch shallow/deep to be command-line arg, flip default
2024-01-22 skia-autoroll@skia-public.iam.gserviceaccount.com Manual roll Dawn from 9fbef511d79e to 5b45794c2c24 (303 revisions)
2024-01-22 skia-autoroll@skia-public.iam.gserviceaccount.com Roll vulkan-deps from 167fd9d49add to 4307b0183c9e (2 revisions)
2024-01-22 kjlubick@google.com Remove deprecated uses of Vulkan MutableTextureState constructor

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC brianosman@google.com,jacksongardner@google.com,lovisolo@google.com,rmistry@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2024-01-23 20:02:32 +00:00
Jonah Williams
89bdfba3d7 [Impeller] fix validation error for playground texture upload. (flutter/engine#49957) 
Buffer to image is missing barriers. We don't really need to use this for playgrounds though, as set contents does the right thing more or less.

Fixes https://github.com/flutter/flutter/issues/142024
 2024-01-23 19:17:05 +00:00
Brandon DeRosier
20e12c94dd [Impeller] Fix runtime effect pipeline depth/stencil. (flutter/engine#49953) 
- Setup depth and stencil attachments for RuntimeEffect.
- Add validation check in `EntityPass` to force backends to set things
up the root pass correctly.
- Add checks in `ContentContextOptions::ApplyToPipelineDescriptor` to
validate that callers are holding it right.
 2024-01-23 10:57:52 -08:00
Zachary Anderson
bf70dc87fb Exclude prebuilts/Library from Mac builder_cache (flutter/engine#49971) 
Related https://github.com/flutter/flutter/issues/141688
 2024-01-23 18:42:10 +00:00
gaaclarke
867d175c2d [Impeller] turned on validation errors for one golden image test (flutter/engine#49955) 
issue https://github.com/flutter/flutter/issues/142017

This just turns on the validations for one test since not everything passes yet with them turned on across the board.

[C++, Objective-C, Java style guides]: https://github.com/flutter/engine/blob/main/CONTRIBUTING.md#style
 2024-01-23 18:16:55 +00:00
Michael Brase
2dc6593b48 Update buildroot for fidl_binding_deps() support in the Fuchsia SDK (flutter/engine#49909) 
See flutter/buildroot#813
 2024-01-23 16:08:08 +00:00
skia-flutter-autoroll
4562f67000 Roll Dart SDK from 5bd0742466d2 to 5646ac9669f8 (3 revisions) (flutter/engine#49965) 
https://dart.googlesource.com/sdk.git/+log/5bd0742466d2..5646ac9669f8

2024-01-23 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com Version 3.4.0-60.0.dev
2024-01-23 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com Version 3.4.0-59.0.dev
2024-01-23 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com Version 3.4.0-58.0.dev

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/dart-sdk-flutter-engine
Please CC dart-vm-team@google.com,jacksongardner@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter Engine: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2024-01-23 12:31:29 +00:00
auto-submit[bot]
16f151f920 Reverts "Add Mac cache_builder back into Prod" (flutter/engine#49961) 
Reverts flutter/engine#49936
Initiated by: zanderso
This change reverts the following previous change:
Original Description:
Add the Mac cache_builder target back to prod.

*List which issues are fixed by this PR. You must list at least one issue.*
Fixes https://github.com/flutter/flutter/issues/141688

*If you had to change anything in the [flutter/tests] repo, include a link to the migration guide as per the [breaking change policy].*

[C++, Objective-C, Java style guides]: https://github.com/flutter/engine/blob/main/CONTRIBUTING.md#style
 2024-01-23 05:39:16 +00:00
Matan Lurey
549738f77f Change how OpenGL textures are flipped in the Android embedder. (flutter/engine#49938) 
h/t @bdero for [writing the actual
code](https://github.com/flutter/flutter/issues/141636#issuecomment-1903677360)
(I just wrote comments).

Manual test[^1] of `cd
packages/packages/video_player/video_player/example && flutter run`:

## Skia

![Screenshot 2024-01-22 at 3 21
20 PM](https://github.com/flutter/engine/assets/168174/f1023251-4b44-47f3-94f8-1d5dced7bcb3)

## Impeller + OpenGL

![Screenshot 2024-01-22 at 9 41
59 AM](https://github.com/flutter/engine/assets/168174/a2bed578-c929-4222-a1f9-010e2dc95b7e)

```xml
<meta-data
      android:name="io.flutter.embedding.android.EnableImpeller"
      android:value="true" />
<meta-data
      android:name="io.flutter.embedding.android.ImpellerBackend"
      android:value="opengles" />
```

Closes https://github.com/flutter/flutter/issues/141636.

[^1]: I can't write a test worth writing at the same time of this PR, so
I've filed https://github.com/flutter/flutter/issues/141973 to do it
after.
 2024-01-22 16:52:32 -08:00
skia-flutter-autoroll
f72693e774 Roll Dart SDK from 9470ea6b00a5 to 5bd0742466d2 (1 revision) (flutter/engine#49951) 
https://dart.googlesource.com/sdk.git/+log/9470ea6b00a5..5bd0742466d2

2024-01-22 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com Version 3.4.0-57.0.dev

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/dart-sdk-flutter-engine
Please CC dart-vm-team@google.com,jonahwilliams@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter Engine: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2024-01-23 00:28:17 +00:00
Jonah Williams
2c02357c95 [Impeller] dont emulate command buffers for compute on Metal/Vulkan. (flutter/engine#49922) 
Part of the work for: https://github.com/flutter/flutter/issues/140804

Removes ComputeCommand and has both ComputePassMTL and ComputePassVK immediately record to their respective comand buffers. This combines the commits for Metal/Vulkan as they are both fairly small. After this, I can add barriers to fix compute for Vulkan.
 2024-01-22 22:45:05 +00:00
gaaclarke
7a4d6f1b6a [Impeller] fixed colorspace for metal screenshots (flutter/engine#49941) 
fixes https://github.com/flutter/flutter/issues/141903

The golden tests were generating images in the wrong colorspace which
left things brighter than they should have been. This fixes that issue.

## Pre-launch Checklist

- [x] I read the [Contributor Guide] and followed the process outlined
there for submitting PRs.
- [x] I read the [Tree Hygiene] wiki page, which explains my
responsibilities.
- [x] I read and followed the [Flutter Style Guide] and the [C++,
Objective-C, Java style guides].
- [x] I listed at least one issue that this PR fixes in the description
above.
- [x] I added new tests to check the change I am making or feature I am
adding, or the PR is [test-exempt]. See [testing the engine] for
instructions on writing and running engine tests.
- [x] I updated/added relevant documentation (doc comments with `///`).
- [x] I signed the [CLA].
- [x] All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel
on [Discord].

<!-- Links -->
[Contributor Guide]:
https://github.com/flutter/flutter/wiki/Tree-hygiene#overview
[Tree Hygiene]: https://github.com/flutter/flutter/wiki/Tree-hygiene
[test-exempt]:
https://github.com/flutter/flutter/wiki/Tree-hygiene#tests
[Flutter Style Guide]:
https://github.com/flutter/flutter/wiki/Style-guide-for-Flutter-repo
[C++, Objective-C, Java style guides]:
https://github.com/flutter/engine/blob/main/CONTRIBUTING.md#style
[testing the engine]:
https://github.com/flutter/flutter/wiki/Testing-the-engine
[CLA]: https://cla.developers.google.com/
[flutter/tests]: https://github.com/flutter/tests
[breaking change policy]:
https://github.com/flutter/flutter/wiki/Tree-hygiene#handling-breaking-changes
[Discord]: https://github.com/flutter/flutter/wiki/Chat
 2024-01-22 14:42:36 -08:00
Jonah Williams
2505092c79 [Impeller] remove frame counter that was unused in Vulkan allocator. (flutter/engine#49913) 
This was from a previous attempt to reduce allocation pressure using per-thread pools, but they don't actually work since as soon as a pool needs to allocate a new block we end up locking on some vk device calls,
 2024-01-22 22:35:13 +00:00
Jason Simmons
81277b90ed [Impeller] Create the golden test screenshotter after setting the Vulkan ICD environment variable (flutter/engine#49948) 
This ensures that the test process will load the SwiftShader implementation of Vulkan if a VulkanScreenshotter is instantiated.
 2024-01-22 22:19:18 +00:00
Loïc Sharma
e54858b901 [Windows] Rename and move EGL types (flutter/engine#49900) 
This is a refactoring with no semantic changes. The following types were renamed:

* `flutter::AngleSurfaceManager` to `flutter::egl::Manager`. In subsequent pull requests, this type will _create_ but not _own_ surfaces. Furthermore, this type will be split up to introduce `flutter::egl::Surface` and `flutter::egl::Context`. The manager will own the contexts and each surface will be owned by its view.
* `flutter::GlProcTable` to `flutter::egl::ProcTable`

This also introduces an `egl` directory to the Windows embedder.

Previous pull request: https://github.com/flutter/engine/pull/49895

Part of https://github.com/flutter/flutter/issues/141996

[C++, Objective-C, Java style guides]: https://github.com/flutter/engine/blob/main/CONTRIBUTING.md#style
 2024-01-22 22:09:25 +00:00
skia-flutter-autoroll
7474eb4b1a Roll Skia from fa5f2461554f to 58973cca0edd (2 revisions) (flutter/engine#49947) 
https://skia.googlesource.com/skia.git/+log/fa5f2461554f..58973cca0edd

2024-01-22 skia-autoroll@skia-public.iam.gserviceaccount.com Manual roll ANGLE from 151c1571989e to c6fbf93decba (6 revisions)
2024-01-22 brianosman@google.com Reland "Reland "Add GCC support to Raster Pipeline""

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC brianosman@google.com,jonahwilliams@google.com,lovisolo@google.com,rmistry@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2024-01-22 21:17:08 +00:00
Mouad Debbar
22a1d5c7d7 [web] Bootstrap tests without implicit view by default (flutter/engine#48629) 
- Follow up tests for https://github.com/flutter/engine/pull/48505
    - Tests for navigation without an implicit view should work.
- Package [this workaround](6efee0e79b/lib/web_ui/test/engine/semantics/semantics_multi_view_test.dart (L29-L30)) behind a nice, future-proof API.
- Tests by default start with no implicit view.
    - Tests that need an implicit view have to explicitly indicate so (by using the `withImplicitView` param).

Fixes https://github.com/flutter/flutter/issues/138906
 2024-01-22 20:43:50 +00:00
skia-flutter-autoroll
d0ca229a96 Roll Skia from bbb0d6feaf1c to fa5f2461554f (1 revision) (flutter/engine#49945) 
https://skia.googlesource.com/skia.git/+log/bbb0d6feaf1c..fa5f2461554f

2024-01-22 michaelludwig@google.com [graphite] Fix and optimize Transform scale factors and inverse

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC brianosman@google.com,jonahwilliams@google.com,lovisolo@google.com,rmistry@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2024-01-22 20:27:24 +00:00
skia-flutter-autoroll
ca2b0cdcef Roll Dart SDK from dc389e4a01f3 to 9470ea6b00a5 (1 revision) (flutter/engine#49944) 
https://dart.googlesource.com/sdk.git/+log/dc389e4a01f3..9470ea6b00a5

2024-01-22 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com Version 3.4.0-56.0.dev

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/dart-sdk-flutter-engine
Please CC dart-vm-team@google.com,jonahwilliams@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter Engine: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2024-01-22 20:03:00 +00:00
skia-flutter-autoroll
061e7129fb Roll Skia from cd6b0ff3596e to bbb0d6feaf1c (1 revision) (flutter/engine#49943) 
https://skia.googlesource.com/skia.git/+log/cd6b0ff3596e..bbb0d6feaf1c

2024-01-22 jamesgk@google.com [graphite] Just use two scratch textures for mipmap generation

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC brianosman@google.com,jonahwilliams@google.com,lovisolo@google.com,rmistry@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2024-01-22 19:40:00 +00:00
gaaclarke
95b6e9d1ca [Impeller] fixed CanRenderClippedRuntimeEffects for vulkan (flutter/engine#49912) 
fixes https://github.com/flutter/flutter/issues/141891

[C++, Objective-C, Java style guides]: https://github.com/flutter/engine/blob/main/CONTRIBUTING.md#style
 2024-01-22 19:32:47 +00:00
Loïc Sharma
3ed2cd569f [Windows] Fix resize crash (flutter/engine#49935) 
https://github.com/flutter/engine/pull/49872 introduced a crash in debug mode if the platform thread starts a window resize in between `OnFrameGenerated` and `OnFramePresented`.

Fixes https://github.com/flutter/flutter/issues/141855.

[C++, Objective-C, Java style guides]: https://github.com/flutter/engine/blob/main/CONTRIBUTING.md#style
 2024-01-22 19:08:56 +00:00
skia-flutter-autoroll
c596e50a25 Roll Skia from be066a6524ab to cd6b0ff3596e (3 revisions) (flutter/engine#49939) 
https://skia.googlesource.com/skia.git/+log/be066a6524ab..cd6b0ff3596e

2024-01-22 michaelludwig@google.com [skcms] Sync half/float conversions to SkVX impl
2024-01-22 nscobie@google.com Update Skia's own Vulkan headers to v1.3.268.0
2024-01-22 kjlubick@google.com Fix assert in GrGLDirectContext

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC brianosman@google.com,jonahwilliams@google.com,lovisolo@google.com,rmistry@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2024-01-22 18:32:00 +00:00
Ricardo Amador
b8b57d727b Add Mac cache_builder back into Prod (flutter/engine#49936) 
Add the Mac cache_builder target back to prod.

*List which issues are fixed by this PR. You must list at least one issue.*
Fixes https://github.com/flutter/flutter/issues/141688

*If you had to change anything in the [flutter/tests] repo, include a link to the migration guide as per the [breaking change policy].*

[C++, Objective-C, Java style guides]: https://github.com/flutter/engine/blob/main/CONTRIBUTING.md#style
 2024-01-22 17:56:52 +00:00
skia-flutter-autoroll
cba06a28bb Roll Skia from cc042f38288e to be066a6524ab (2 revisions) (flutter/engine#49937) 
https://skia.googlesource.com/skia.git/+log/cc042f38288e..be066a6524ab

2024-01-22 kjlubick@google.com Reland "Add Bazel rules for Ganesh GL backend and webp encoder"
2024-01-22 johnstiles@google.com Add flag 'skia_disable_tracing' to GN.

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC brianosman@google.com,jonahwilliams@google.com,lovisolo@google.com,rmistry@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2024-01-22 17:41:53 +00:00
Brandon DeRosier
03b9cb2896 [Impeller] Reland: Switch from transient stencil-only to depth+stencil buffer. (flutter/engine#49838) 
Part of https://github.com/flutter/flutter/issues/138460.

In preparation for [draw order
optimization](https://github.com/flutter/flutter/issues/114402) and
[StC](https://github.com/flutter/flutter/issues/123671).

Use a transient depth+stencil texture instead of a stencil-only texture.
Doing this in isolation to detect/weed out any bugs with handling the
attachment.
 2024-01-22 09:37:59 -08:00
Brandon DeRosier
76a798ee20 [Impeller] Add golden for Image ColorSource effect transform. (flutter/engine#49930) 
Adds a golden to verify that Impeller behaves correctly for a variety of
effect transforms, entity (positional) transforms, and source rects.

Skia fiddle: https://fiddle.skia.org/c/6cdc5aefb291fda3833b806ca347a885

Skia (top) vs Impeller (bottom):

![Screenshot 2024-01-22 at 1 37
16 AM](https://github.com/flutter/engine/assets/919017/8b073f83-9821-4004-a56e-60e8946cefe7)
 2024-01-22 09:01:47 -08:00
skia-flutter-autoroll
385b37a71c Roll Skia from 9cb4de5da15a to cc042f38288e (1 revision) (flutter/engine#49934) 
https://skia.googlesource.com/skia.git/+log/9cb4de5da15a..cc042f38288e

2024-01-22 mike@reedtribe.org trim unneeded includes, and hide priv method

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC brianosman@google.com,jonahwilliams@google.com,lovisolo@google.com,rmistry@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2024-01-22 16:47:22 +00:00
skia-flutter-autoroll
ec04c37dea Roll Fuchsia Linux SDK from p0njgljtokVLYfzqK... to uQK4l0QeH_PlZO6cF... (flutter/engine#49933) 
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/fuchsia-linux-sdk-flutter-engine
Please CC jonahwilliams@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2024-01-22 16:30:35 +00:00
skia-flutter-autoroll
6d1eaf38fe Roll Dart SDK from 7a91ef52d200 to dc389e4a01f3 (3 revisions) (flutter/engine#49932) 
https://dart.googlesource.com/sdk.git/+log/7a91ef52d200..dc389e4a01f3

2024-01-22 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com Version 3.4.0-55.0.dev
2024-01-20 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com Version 3.4.0-54.0.dev
2024-01-20 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com Version 3.4.0-53.0.dev

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/dart-sdk-flutter-engine
Please CC dart-vm-team@google.com,jonahwilliams@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter Engine: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2024-01-22 16:11:16 +00:00
skia-flutter-autoroll
fa89b11337 Roll Skia from f4b79968de2a to 9cb4de5da15a (1 revision) (flutter/engine#49931) 
https://skia.googlesource.com/skia.git/+log/f4b79968de2a..9cb4de5da15a

2024-01-22 ping.wang@amd.com Reland "Added AVX512 support for SkRasterPipeline_opts.h"

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC brianosman@google.com,jonahwilliams@google.com,lovisolo@google.com,rmistry@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2024-01-22 15:27:47 +00:00
skia-flutter-autoroll
75440f44ef Roll Skia from 8774ef8a314e to f4b79968de2a (1 revision) (flutter/engine#49929) 
https://skia.googlesource.com/skia.git/+log/8774ef8a314e..f4b79968de2a

2024-01-22 skia-autoroll@skia-public.iam.gserviceaccount.com Roll vulkan-deps from bc707fe39f82 to 167fd9d49add (1 revision)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC brianosman@google.com,jonahwilliams@google.com,lovisolo@google.com,rmistry@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2024-01-22 09:17:07 +00:00
skia-flutter-autoroll
31facb581e Roll Skia from 97a00523af28 to 8774ef8a314e (1 revision) (flutter/engine#49927) 
https://skia.googlesource.com/skia.git/+log/97a00523af28..8774ef8a314e

2024-01-22 skia-autoroll@skia-public.iam.gserviceaccount.com Roll ANGLE from 0da652252424 to 151c1571989e (5 revisions)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC brianosman@google.com,jonahwilliams@google.com,lovisolo@google.com,rmistry@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2024-01-22 07:13:08 +00:00
skia-flutter-autoroll
1dd17b3ef1 Roll Skia from c42ac527ff0e to 97a00523af28 (1 revision) (flutter/engine#49926) 
https://skia.googlesource.com/skia.git/+log/c42ac527ff0e..97a00523af28

2024-01-22 skia-autoroll@skia-public.iam.gserviceaccount.com Roll SK Tool from e82e36a84a08 to 548ae3bfb74d

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC brianosman@google.com,jonahwilliams@google.com,lovisolo@google.com,rmistry@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2024-01-22 06:02:34 +00:00
skia-flutter-autoroll
2fa6aa79d5 Roll Fuchsia Linux SDK from kOnlSGX_aTAK7vvLc... to p0njgljtokVLYfzqK... (flutter/engine#49924) 
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/fuchsia-linux-sdk-flutter-engine
Please CC jonahwilliams@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2024-01-21 15:39:23 +00:00
skia-flutter-autoroll
a9b529fabe Roll Skia from 3cac1efbdd7a to c42ac527ff0e (1 revision) (flutter/engine#49921) 
https://skia.googlesource.com/skia.git/+log/3cac1efbdd7a..c42ac527ff0e

2024-01-20 skia-autoroll@skia-public.iam.gserviceaccount.com Roll vulkan-deps from f5416720c542 to bc707fe39f82 (2 revisions)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC brianosman@google.com,jlavrova@google.com,jonahwilliams@google.com,rmistry@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2024-01-20 17:15:24 +00:00
skia-flutter-autoroll
166fda2725 Roll Fuchsia Linux SDK from geXIwPzzJiSXrZEEb... to kOnlSGX_aTAK7vvLc... (flutter/engine#49919) 
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/fuchsia-linux-sdk-flutter-engine
Please CC jonahwilliams@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2024-01-20 13:23:16 +00:00
skia-flutter-autoroll
4261f97cac Manual roll Dart SDK from 8d697eaa395c to 7a91ef52d200 (5 revisions) (flutter/engine#49917) 
Manual roll requested by zra@google.com

https://dart.googlesource.com/sdk.git/+log/8d697eaa395c..7a91ef52d200

2024-01-19 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com Version 3.4.0-52.0.dev
2024-01-19 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com Version 3.4.0-51.0.dev
2024-01-19 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com Version 3.4.0-50.0.dev
2024-01-19 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com Version 3.4.0-49.0.dev
2024-01-19 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com Version 3.4.0-48.0.dev

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/dart-sdk-flutter-engine
Please CC dart-vm-team@google.com,jonahwilliams@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter Engine: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2024-01-20 07:04:56 +00:00