DEV/flutter_flutter
1
0
Fork 0
mirror of https://github.com/flutter/flutter.git synced 2026-02-20 02:29:02 +08:00
Code Issues Packages Projects Releases Wiki Activity

[Impeller] fixed CanRenderClippedRuntimeEffects for vulkan (flutter/engine#49912)

Browse Source 
fixes https://github.com/flutter/flutter/issues/141891

[C++, Objective-C, Java style guides]: https://github.com/flutter/engine/blob/main/CONTRIBUTING.md#style
This commit is contained in:
gaaclarke 2024-01-22 11:32:47 -08:00 committed by GitHub
parent 3ed2cd569f
commit 95b6e9d1ca
2 changed files with 2 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

3
engine/src/flutter/impeller/aiks/aiks_unittests.cc
View File

@ -2742,7 +2742,8 @@ TEST_P(AiksTest, CanRenderClippedRuntimeEffects) {
TEST_P(AiksTest, DrawPaintTransformsBounds) {
auto runtime_stages = OpenAssetAsRuntimeStage("gradient.frag.iplr");
auto runtime_stage = runtime_stages[RuntimeStageBackend::kMetal];
auto runtime_stage =
runtime_stages[PlaygroundBackendToRuntimeStageBackend(GetBackend())];
ASSERT_TRUE(runtime_stage);
ASSERT_TRUE(runtime_stage->IsDirty());

3
engine/src/flutter/impeller/golden_tests/golden_playground_test_mac.cc
View File

@ -58,9 +58,6 @@ static const std::vector<std::string> kSkipTests = {
"impeller_Play_AiksTest_CanRenderClippedRuntimeEffects_Vulkan",
"impeller_Play_AiksTest_CaptureContext_Metal",
"impeller_Play_AiksTest_CaptureContext_Vulkan",
// TODO(https://github.com/flutter/flutter/issues/141891): This tests
// crashes on vulkan and needs to be fixed.
"impeller_Play_AiksTest_DrawPaintTransformsBounds_Vulkan",
};
namespace {