7c70ab1817 Revert change that empirically doesn't improve code for dart2js stopwatch.
895bc90509 Sync pub client to newest version
39f365f3b9 Sort declarations in parser.dart.
8af83b19d6 Sort declarations in ast_builder.dart.
0adddfbeab Eliminate uses of old AST node types from analysis server
120328aff7 [fasta] Commandline option to enable asserts
82c5c5bbb2 [fasta] Only read compiler context at construction in kernel_target.
9a4c49f301 Update field analysis tests to prepare for eager initializer improvements
75370569fc Fall back to DillLoader when computing types in SourceLoader
78ba3dab7a Rename ImplicitType to ImplcitFieldType
1720704594 Recognize effectively constant static fields
ba31e448ca Finish implementing IsIntersectionSubtypeOf
5f095b7039 [Fasta] Add support for spread in map literals
3b8591d13e [ddc] Initial impl for invoking service extension
ae70ce855f Include the completion suggestion labels as explicit relevance tags
50ab52d567 Use raw is-check when type arguments match the bounds
d650c619e2 more postfix "!" non-null assert operator tests
a3ab6b6514 [vm, gc] Reduce cost of maintaining allocation stats during scavenges.
36c14db2d3 Only refine non-null in SSA
a1349ac529 Remove childEntities and visitChildren from ForEachStatementImpl and ForStatementImpl.
31993bf1b5 improve expression function body recovery
1c477ad3aa Refactor downward inference to improve recovery
8f12d634fe add postfix "!" non-null assert operator
ab10fb12dc [vm/interpreter] Reduce stack usage of interpreter
ffc1383918 Move tests of five more analyzer codes to diagnostics
a6b76df8d8 Add flag to re-run global inference when reading a data file.
b04cb2f5e7 Don't create instances of ForStatement2Impl yet.
82a15835f0 Short-circuit logical operators in constants
7829012e61 add new ExperimentNotEnabled error code
1e2211bbb6 going to go ahead and just revert this. I don't think it is at all critical. Thanks for noticing the build failure Paul!
01cc5a6305 Ensure unknown fields in LSP payloads are ignored
d7a7de31bf Update dartkb test expectations
0e9d97498c Add some notes on using Dart LSP with Vim
a9ef31ba43 [Fasta] Add Kernel syntax for spread elements
b79e2a8882 Fix equivalence/show_helper
Some embedders prefer to minimise the number of semantics node/custom
action updates sent back to the host platform -- for example due to
expensive serialisation mechanisms, etc.
This patch provides a 'batch end' signal that provides embedders with an
indication of when a self-consistent set of semantics node or custom action
updates have been sent.
We overload the node/action ID with information that conveys a batch end
by using an ID (-1) that is never allotted to semantics nodes by the
framework.
40bab34fbd Fix Stopwatch timers to not overflow on intermediate computations.
edcaa05375 Support @pragma('dart2js:noElision') on non-internal methods
dc8a56bc0e Rename set literal tests to end in _test
f484e1b05e Call canParse() for all LSP requests before passing to handlers
0e54ce3b2d Fix a canParse method that would overflow the stack
8fb52650e5 Ensure LSP canParse type-checks optional values
26d91cf4b6 If LSP initialize fails in tests, throw
d1876531f2 Fix LSP canParse to allow nulls where the spec allows
9450c6d829 Move SUBTYPE_OF_SEALED_CLASS to own file, and DriverResolutionTest
603678e46c [vm, gc] Streamline the promotion allocation fast path.
8fd09304b6 [vm, gc] Force inline MarkObject into its sole caller.
fb88c983e7 [vm/compiler] Switch kernel helper for background compiler to use new space.
6d575152c9 [vm/compiler] Changes in Cid range computation
2d58ea3b42 [dartdevc] fix#35554, throw NullThrownError when null is thrown
25aa35ef98 Convert ast.dart to triple-slash comment style
b11cb39d66 [DDC] Support implict casts in [ForLoopStatement2]
e94e797d7b Fix flow analysis test for ForStatement2
0374ba1698 Coalesce ForStatementBase with ForStatement2Impl.
4cd309316b Prepare visitors for UI-as-code rework.
cfac26e184 Deprecate `Expression.precedence`.
4abf59202d Fix ForLoop2 support in reference collector
05bba46133 Use DFS numbering for block dominates test
fba89f9f64 [vm] Don't change the content of the VM isolate's snapshot based on what was loading into a core or app snapshot.
3d3f6f9d4b Remove immediateUnderSetLiteral.
7b86d78f07 Enable set literal lowering in dart2js.
e29835749a [dart_internal] Bump SDK constraint upper-bound to <2.3.0
53ca69ba7e [release] Bump version and update CHANGELOG for 2.2.0
Link dart:* sources into engine for debugger source support
Currently, dart:* libraries appear to have no source in
debuggers like Observatory. With this change, these sources will be
available in debug mode applications. Sources for dart:* libraries are
lazily loaded on a script-by-script basis.
Refer to https://dart-review.googlesource.com/c/sdk/+/93375 for the Dart
SDK change.
385be0cf31 Remove unused imports
7e0c2c83f4 Update pub revision
d4ff20f005 Remove unwanted @soloTest
155ac6afbd Create subtype benchmarks based on dart2js and a large application
f0042a3225 [vm/ffi] Factor out FFI code shared between compiler and runtime.
2eb3ac7c02 Specify implicit creation
b446d0a226 BenchMaker: a benchmark that reads the output from BenchMaker
f6389a4216 TypeComputer: handle named parameters
cffdd356ed BenchMaker: Don't obfuscate dart:async
1171c4735b BenchMaker: Ensure all classes are serialized
47555a25b8 Fix detection of implicit bounds
eb19bba3e3 Implement TypeBuilderComputer.visitFunctionType
7f00ea7e43 Subst interface types copied from superclass
561f7905d6 A type variable can be a subtype of another
f7e435ac26 [ VM / Windows ] Removed call to SetThreadDescription which is only supported in new Win 10 builds
bf7ecc40f9 [vm] Fix some compilation events to respect SUPPORT_TIMELINE instead of PRODUCT.
fa0ba2220e [vm/compiler] Fix bug in Cid range computation
afb8747fc2 [vm/tools] Add option in Graph Explorer to rewrite the graph to be more hierarchical.
bf0568c548 Document restrictions on LSP refactors/code fixes
73e544ed0b Improve errors when LSP integration tests fail to spawn server
380cec1708 Wait for LSP server to be ready before sending exit command in integration test
1e60ddbc5b Make more LSP enum classes support "any value"
3dfa610694 Work around #35993 by allowing ints to be assigned to doubles in constants.
32eedccdcd [gardening] Fix patches restored in earlier commit.
38259ca3c8 [Kernel] Change block expression to have a block body
b37de47842 [gardening] Restore flutter '--package' and dartjs_info_tag engine patch
76e3dfe096 Remove TypeEnvironment.legacyMode
20da48c7cf Remove unused legacyMode from constant transformer
ceb998ecc0 Remove unused TargetFlags
6af24a2490 Move LSP diagnostic server test -> integration
34614ef995 Exit LSP server with exitCode=1 if there was no shutdown notification
e7d263b05f [fasta] Transform set literals in annotations.
65698e2c2f Support mixin applications in type parser
e395cdb1ad Support mutually recursive types
393c1df600 Improve performance of scope creation in type parser
03ee0fea51 [infra] Temporarily support both the old latest build step names.
944544137b Fix path to step log in approve_results.dart.
55c07c6d7a [vm] Fix null checks when CodeSourceMap is missing
a481832df9 Add a failing test for recovery in typedef
010052cb2b Add an assist to convert conditional expressions to a null aware operator (issue 35691)
646c1f679a [tests] Minor fixes in control flow collections for tests
f0155931a9 Fix null reference exception in _constantValuesEqual
5192cd1008 Narrowing improvements in dart2js global inference.
ed796fcc3e Reland "Flatten constant operations to implement JS semantics by default."
8fface97f0 Reland "Eliminate singleton/static access to the constant system and expose its functionality at the top level."
e40b0e04c9 Reland "Merge the JavaScript constant system into the base constant system and flatten the inheritance hierarchy."
6bdd38ae84 Reland "Move the JavaScript constant system into constants/constant_system.dart in preparation to merge it with the base constant system and flatten the constant system hierarchy."
960b08a969 Reland "Remove the Dart constant system and move all required classes into the JavaScript constant system."
6532b24d71 Implementing constant visitors.
d9c05534de [dartdevc] Add helper methods to emit `For` and `ForOf` loops
620862fb13 [dartdevc] Support SetOrMapLiteral nodes
9b55682a5c Prepare to publish analyzer 0.35.2
e1992e0178 Revert "Remove the Dart constant system and move all required classes into the"
05d9c60a22 Revert "Move the JavaScript constant system into constants/constant_system.dart"
388f8e7731 Revert "Merge the JavaScript constant system into the base constant system and"
2c3dfa9e71 Revert "Eliminate singleton/static access to the constant system and expose its"
163c49fef9 Revert "Flatten constant operations to implement JS semantics by default."
8172270c95 Flatten constant operations to implement JS semantics by default.
027b76ecbf Eliminate singleton/static access to the constant system and expose its functionality at the top level.
cf51eb2fba Merge the JavaScript constant system into the base constant system and flatten the inheritance hierarchy.
1702b986c8 Move the JavaScript constant system into constants/constant_system.dart in preparation to merge it with the base constant system and flatten the constant system hierarchy.
5af8de8954 Remove the Dart constant system and move all required classes into the JavaScript constant system.
272f58e543 Revise parser to generate handleLiteralSetOrMap
30b47d24e6 [sdk] Remove unused --packages flag no longer recognized by gen_snapshot.
0ad7caa5af [testing] Improve multitest error messages
58cea93953 Update BodyBuilder to use handleLiteralSetOrMap
8e2fcf7782 Advanced tracking of field initialization
60e4f194b0 Recognize and inline effectively constant fields
db62dc5323 Remove hardcoded precedence integers in front end.
5aba7b7b85 Normalize expression precedence between analyzer and front_end.
ff265bb5ae remove dead default lint registration API
2087d6db46 initializeFromComponent has to include platform
7f2a83ee07 BenchMaker: collect used type parameters
b3c9aa624e BenchMaker: print call operators
74f0a36579 BenchMaker: Print function type arguments correctly
6b29680b12 Enable collection of type checks for benchmarking
c9b8bae4e6 [Kernel] Add BlockExpression to the Kernel language
e4d1b28698 Incremental compiler should respect omitPlatform setting
25bd6a1bd8 [CFE] Remove dead code for boolean method invocation.
128acb264b [VM] Decouple compile_type.h from runtime by making it only use runtime_api.h
93eca7745a Don't invalidate the entry point for no reason
af65aec21f [dart2js] Fix assignment chaining
bb8396592b [dart2js] Add tracing for codegen phases
3e304def65 switch dartdevc to kernel and fix path in rules.
b60a55510b [dart2js] Disable assignment chaining optimization
eff286becd Fix errors in mock SDK.
4a50b02364 [dartdevc] fix#36001, non-generic classes and recursive supertypes
d253642f25 [standalone] Fix isolate messages for processes that a creating an AppJIT snapshot.
f97f759ef3 Update the implementation of for loops
2b9e57e4b2 Move assignment chaining to own pass
627e96c9c1 [dartdevc] simplify microtask scheduling using JS Promise
ee32f8c87e [VM] Rehash sets after they are read from a snapshot.
0e99581c35 [gardening] Restore flutter '--package' patch, add dartjs_info_tag engine patch
a6f6c55dc8 [timeline] In newer versions of Catapult, arguments to an async end event override those in the async begin event.
4cff5a4fd6 [ VM / Service ] Dynamically load source from linked-in platform kernel
bc53c4dcda Update AstBuilder unified collection parsing to reduce error messages
e3b8065625 Add support for --dump-info=binary
372537f1e4 Add first support for strict-inference as an analysis option.
c49537e743 Support for 'double' fields in summaries.
9cdc189280 Fix bugs in list literals and add some inference tests
75ee523f91 [VM] Remove flutter/flutter patch for 3head, the issue has been fixed upstream
4013b0eece [gardening] Add adjusted fix to flutter test patch.
69d46587cf [gardening] Add fix to flutter test patch.
f5d43c45ea Include 'linterVersion' into AnalysisOption signature.
e58b7cd59e [gardening] Fix flutter patch.
22e70ed48f [gardening] Patch flutter/flutter to fix hhh buildbot
dc2422ef84 [vm, gc] Fix accounting of external sizes in the class table.
bdb52a8f33 Fix 'Organize Directives' handling end-of-line comments.
371d244273 linter version support
435a52eafa [ VM / Service ] Fixed inconsistencies in service protocol spec.
8ac6114028 Sort AvailableDeclaration fields.
48a9eb87ba [analyzer] Add hint for unnecessary ?.
ccb2e2d293 [analyzer] Report dead code for x ?? y where x is non-null
004dd969b0 Remove mock_type.dart, it looks that it is not used.
266ce73e28 Remove CompletionSuggestion.elementUri, replaced with AvailableSuggestionSet.
7ebb0411f3 Rework DartFix listener interface to separate edits from suggestions.
1c576b66bc Generalize FixCodeTask to handle arbitrary numbers of phases.
fd377a4d6f Sort file non_nullable_fix.dart
98af688787 Sort dartfix_listener.dart
5ddd157809 fix uris for libraries to allow the breakpoint to lookup scripts.
7ebd02cdaa Work around for #35908.
3068192450 [vm] Remove deferred canonicalization from isolate message serialization.
0e453c637b [dart2js] Chain static assignments
8b0dd94e11 Revise AstBuilder to generate the new set-or-map AST structure
5e2529c82e Remove 'importUri' from CompletionSuggestion.
1699562dfc Remove unused AbstractSingleUnitTest.
27a805bde8 Add fast case for ASCII in Utf8Decoder, it significantly increases decoding speed
7edb7dddd8 Merge allocator analysis with collection of elided fields
6f8415245d [fasta] Transform set literals in initializers and default values.
9b10476092 [kernel/ffi] fix library paths
ef9592a9c7 [kernel] Add (de)serialization for ExpressionStatements
187d6ceb20 [kernel] Add statements to Kernel (de)serialization verifier
395c0e4b98 [kernel] Add text (de)serialization for NamedTypes
14f5936468 [kernel] Simplify (de)serialization encoding for FunctionTypes
5e3e633d5d [kernel] Add text (de)serialization for TypeParameterTypes
923cea6652 [kernel] Add Bind and Binder combinators
c19af8cee9 [kernel] Cleanup code for (De)SerializationEnvironment
d60354b521 [kernel] Add binders and close terms as separate operations
a3736868c0 [kernel] Add text (de)serialization for type parameters
d76293a75a [testing] Add shared options on the test.py commandline.
596e0aa645 Include FieldInitializer in allocator analysis
8db489cb10 [vm/aot] Remove unnecessary closurization of some entry-points.
c635896e1b [vm] Fix langauge_2_kernel.status after 93301
273856c6e3 Issue 3204. Support for local mixins as types.
45cb49108f Issue 3204. Include mixin(s) into top-level declaration for import Quick Fix.
6cf71022a8 Add a test for type promotion in "if" collection elements.
7df88e5755 Fix the lack of '`' in the doc.
b83bcf59f2 Call dart::StubCode::Cleanup in AOT mode as well.
5722ca3126 Include defaultArgumentListString / defaultArgumentListTextRanges into AvailableSuggestion(s).
56356d426a Set 'displayUri' to IncludedSuggestionSet with file:// URIs.
43c4749f7e [dart2js] Turn on local aliases optimization
1ed9a34513 Add defaultArgumentListString / defaultArgumentListTextRanges to Declaration.
c338941801 [ddc] Elide continue to next switch case
3a0ded6d54 Use _ExecutableParameters to access named parameter names.
4c1025493a Enhance available suggestions protocol.
28eb8604e3 Correctly handle invocations of top-level functions with an import prefix
0ef30fb86e Protocol for IncludedSuggestionSet.displayUri.
bcd2c7fb96 Fix ListLiteral construction and add comments
d3fde891bf [VM] Fix deadlock between mutator and BG compiler
a85ae4e919 [vm/ffi] fix sizeOf on subtypes of Pointer
98bc608202 [testing] Blacklist tests and repeat options from reproduction commands
48beacfd78 Remove Kernel-based mixin inference
e2b7f48333 Implement ClassHierarchyBuilder.getLegacyLeastUpperBound
d19d50f45f Support async in LUB test
6a65f84a63 Implement longest path to Object
0720888236 Temporarily ignore context of errors in expression_test
6ccdffdb35 Test for expression compilation, type variables and initialize from dill
4bcc97a3d6 Don't run 'unbindCanonicalNames' in writeComponentToFile
c9ef5be8d7 Issue 124524319. Improve getElementDeclaration to support invalid code with synthetic names.
f9bb790f43 Add a fix to change invalid named argument names to an existing parameter name
1d1654592a Do not compute any imports for use on paste if import directives are being copied
03932bb852 Convert more diagnostic tests to DriverResolutionTest
e1d3186ed9 Make declarations in provisional_api_test.dart private.
bb76970857 Sort provisional_api_test.dart
db71576ef3 [dart2js] Generator bodies can be on super mixin applications
711dd8e82e [dart2js] Avoid generating 'return' statement in setter
f4b649ca4f [CFE] Propagate unevaluated constants upward.
5e70883859 [CFE] Refactor unevaluatedArguments
cba4168da3 [CFE] Use _evaluateSubexpression in more places.
8e5f644d0a Use constant evaluation in allocator analysis
bfa6041801 Add allocator analysis test for the J model
620743fb6b [vm/ffi] void functions
885f1cbe31 Fix constant folding of type literal equality
3638e433ce Change how DDC writes text when summarize-text is enabled
26970f370c Move source out of PotentialModification.
f20ee58aa7 Remove references to the set-literals experiment
7d7d85ffa2 Change the default assumption for named parameters to "assume nullable".
fa8c552fd9 Propagate non-null intent from callee to caller.
ab38cf7897 Allow non-nullable usage to imply non-null intent.
24928ffcef [dartdevc] hide summarize-text option and change default to off
15e7457519 [dartdevc] change browser tests to wait longer for async completion
6b5424a7e7 Use SSA nodes to infer map key/value types.
ec599a5977 [VM] Remove retry logic from close(fd) calls
1ac61b0c35 [dart2js] Basic chaining of field assignments
8cb4d00b0b Remove compareXyz() methods from ResynthesizeTestHelpers.
936b1c0404 Rename _mockOr to _either.
046928d502 [vm/kernel] Ignore package URIs when converting main script to package URI
99a5057bca Add set tracing.
c291757bed Finish handling SetLiterals in the inferrer and SSA builder kernels.
d11dd982dd Add typeinfo for sets and their elements and start tracing them in the inferrer.
61ab8e7816 Add kernel and backend impacts for set literals.
d87482a3e1 Add SetLiteralUse and start tracking them in resolution.
97bfcd4a3a Add remaining support for sets to the abstract value domain. This lets us create set values and access their element types in the inferrer.
e53cd30112 Add SetTypeMask.
15cd12beb4 Add SetConstantValue and SetConstantExpression plus their visitors.
c841f050c0 Add set types to the abstract value domain. We cannot yet allocate sets.
51db39a6ae Implement basic SetLiteral visitors. Builder kernels will come later.
a164e95582 Update CommonElements with set types.
cd53e3b4df Patch factories for generating set literals into LinkedHashSet.
6846a7c486 Fix flutter analyzer bot by disabling lint prefer_collection_literals.
cf63db2594 [VM/infra] Archive kernel-service.dart.snapshot together with coredumps
015cf88ef6 Disable set literal warning until engine rolls into flutter/flutter
fd8b546800 Issue 35940. Clear evaluation results for constants in the library being analyzed.
39afa4e555 Revert "Add ExecutableElement(s) based InheritanceManager3, and switch analyzer to it."
078f8e67f8 Tests for invalid library id, and requested name.
122aa43ef6 Convert ListLiteral and remove uses of ListLiteral2
6df253db27 Update parse/tryParse documentation.
5622925369 Test of class hierachy from dill file
f4379435dd Implement DillClassBuilder.typeVariables
d1abd84944 [infra] Add named configuration option to test.dart.
20c3cd62fc Revert adding dart:ffi to core_types and fasta kernel_target
185c0f3e89 [gardening] status file entry for entrypoints_verification_test
b15fe3a994 pkg:kernel: fix path to pkg:test in pubspec
763589472e [VM / vmservice] - Change setting of silentObservatory to a non const expression
0e62060be4 [test] Mark standalone_2/io/arguments_test as failing due to a bug in the test harness.
eb73f132c1 [vm] Add macro for fallthrough annotations
b66dc30334 [VM/interpreter] Skip tests enabling interpreter when not supported (fixes#35943).
65290f6e6a Add an option for reusing the previous compiler state in a worker
794e1e3a09 [gen_snapshot] Allow for multiple kernel inputs.
c8abe45b00 Retry 'getSuggestionDetails' on InconsistentAnalysisException.
54dbc0068a Migrate resynthesizer tests from task model.
79b4b558ec [vm/tlab] Abandon tlab when thread gets descheduled. Allow all threads to allocate from tlab. Add tlab test.
59efe201fd Fix mistake in CHANGELOG.
48f7364d7b Remove the UX experiment 2 flag from the Dart Analysis Server.
6c96ff0145 Test case reproducing issue #35940
3b2144fa93 [vm] Respect entry-point annotation on constructors during obfuscation.
d1b15cc92c Support for FieldFormalParameter in SyntacticScopeNamesCollector.
ed94feb30e Update dartdoc version to 0.28.2.
223eaa6fbb Report noSuchMethod forwarders as synthetic in the mirror api
5d6bab4ed2 Add ExecutableElement(s) based InheritanceManager3, and switch analyzer to it.
ae7bf9e999 [vm] Support closurization of methods through @pragma entry-points.
a5d396cd25 [vm/extensions] Fix native extensions in hot-reload and running from snapshot.
4daabe69c3 [vm/gardening] Mark convert/base64_test/01 as flaky
69a952b195 remove parseSetLiterals flag from tests
3abc7d34d7 [vm/ffi] Remove platform specific logic from DynamicLibrary.open
6a5c9597c6 Revert adding enclosingLibrary to ast.dart
8333c8a4d0 Revert adding dart:ffi to devc libraries
e9f239777f Split test so Kernel ClassHierarchy isn't required
25ee9b9d47 Rename test
837145a7c7 Properly restore state of _inConditionalControlFlow upon entering new function/method.
dfda06061a Restore state safely in migration visitors.
765e6338a8 [docs] classify dart:ffi as vm on docs site, and exclude it for now
70e300fea0 [co19] DEPS updated
7ff5be0ceb Convert LUB test to use type parser
763035eb40 Clean up and merge dev CHANGELOG entries for stable release.
92460b8923 Migration: use non-null assertions as a hint for parameters that should not be nullable.
80798fad97 [tests] Add missing parenthesis on <list|map|set>Equals() calls
46aa511b49 Improve the message when using a prefix to reference an undefined name (issue 35936)
f4ec983fec Migrate the rest of element_test from task model.
94d8e730fb Remove parser enableSetLiterals flag
9b45c14c65 First stage cleanup of MapLiteral2 and SetLiteral2
486238df49 Remove the UX experiment 1 flag from the Dart Analysis Server.
fa092aa77b [vm/compiler] actual string constant propagation
44eb626186 [VM} Fix script URLs for dart:* libraries
9ca9e66c1b [dartdevc] fix#35928, type literals are now instantiated to bounds
0f24b9e7ae [standalone] Name dart:io threads, take 2.
7a63d31151 Improve the message when importing a deprecated library (issue 35922)
30f9f5b1c7 Add SetOrMapLiteral to support the code-as-ui features
1c534d852c Clean up the tutorial related to implementing a visitor
7f2f840a91 Don't include constants of private enums.
7329247892 [vm/tools] Add Graph Explorer to visualize output of --write_v8_snapshot_profile_to.
5d71308b78 [vm/tools] Don't duplicate "problems" metadata into split package files.
If an app is using retainFlutterNativeView or a plugin wants to keep the
FlutterNativeView active, then the FlutterNativeView should not drop its
handle to the corresponding native platform view.
Fixes https://github.com/flutter/flutter/issues/26931
