27334 Commits

Author SHA1 Message Date
skia-flutter-autoroll
8ecd3c42fa Roll Fuchsia Linux SDK from tMm2Lzb-LE20Rxwm9... to hi7JwgHijuYYKAFUR... (flutter/engine#39742)
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/fuchsia-linux-sdk-flutter-engine
Please CC jacksongardner@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2023-02-18 04:50:21 +00:00
skia-flutter-autoroll
a0860b3a43 Roll Skia from 4b79e398dfe0 to 733a19f6a625 (9 revisions) (flutter/engine#39740)
https://skia.googlesource.com/skia.git/+log/4b79e398dfe0..733a19f6a625

2023-02-17 armansito@google.com [sksl][wgsl] Correctly handle vector equality operator
2023-02-17 armansito@google.com [sksl][wgsl] Support if statements
2023-02-17 armansito@google.com [sksl][wgsl] Implement GLSL out-parameter semantics
2023-02-17 armansito@google.com [sksl][metal] Fix invalid codegen with nested out-param invocations
2023-02-17 armansito@google.com [sksl][metal] Add test case that demonstrates nested out-param invocation bugs
2023-02-17 aaclarke@google.com Reland "Added BGR10_XR support for decoding images."
2023-02-17 bungeman@google.com Add typeface factory registry
2023-02-17 johnstiles@google.com Disable complex switch test on Intel + Linux + VK.
2023-02-17 lovisolo@google.com Add Python to all Docker tasks.

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC brianosman@google.com,jacksongardner@google.com,rmistry@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2023-02-18 03:01:19 +00:00
Xilai Zhang
760f63bfad add lint check for python files (flutter/engine#39736) 2023-02-18 01:31:13 +00:00
Chris Bracken
1d4e36274f [macOS] Mark move-only classes as such (flutter/engine#39734)
Applies the FML_DISALLOW_COPY_AND_ASSIGN to non-POD types in the macOS
embedder. Specifically the following three accessibility-related
classes:
* FlutterPlatformNodeDelegateMac
* FlutterTextPlatformNode
* AccessibilityBridgeMac

No new tests since no semantic change. Only has the compile-time effect
of preventing copying of classes intended to be move-only.
2023-02-17 17:18:35 -08:00
godofredoc
f62f92f339 Revert "[gn + codesign] mac code sign configuration for FlutterMacOS.framework.zip (#35707)" (flutter/engine#39735)
This reverts commit 729d2ae14020a23099559ec6cac913547322d124.
2023-02-18 00:25:00 +00:00
Xilai Zhang
729d2ae140 [gn + codesign] mac code sign configuration for FlutterMacOS.framework.zip (flutter/engine#35707)
* embed codesign config in macos framework

* format files

* update path

* y flag for outer layer zip

* simplify structure

* format files
2023-02-17 23:49:18 +00:00
Mouad Debbar
f027ff2c95 [web] Don't include end-of-line characters in line boundary (flutter/engine#39693) 2023-02-17 23:27:19 +00:00
godofredoc
66844e38d2 Integrate ios_engine debug, profile and release. (flutter/engine#39724)
* Integrate ios_engine debug, profile and release.

This provides greater reusability of subbuilds saving an approximate of
6 bots per run.

* Change xcframework names.
2023-02-17 23:11:20 +00:00
skia-flutter-autoroll
c4b7980c6e Roll Skia from 0e444e355607 to 4b79e398dfe0 (5 revisions) (flutter/engine#39725)
https://skia.googlesource.com/skia.git/+log/0e444e355607..4b79e398dfe0

2023-02-17 brianosman@google.com Revert "Added BGR10_XR support for decoding images."
2023-02-17 armansito@google.com [graphite] Use ComputeStep in compute pipeline creation and indexing
2023-02-17 johnstiles@google.com Implement scratch LValues.
2023-02-17 robertphillips@google.com Share code between Graphite and Ganesh
2023-02-17 kjlubick@google.com Remove sk_memsetNN indirection

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC brianosman@google.com,jacksongardner@google.com,rmistry@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2023-02-17 22:44:32 +00:00
Mouad Debbar
9a0f7de3b7 [web] Make glassPaneElement and glassPaneShadow non-nullable (flutter/engine#39692) 2023-02-17 21:14:01 +00:00
skia-flutter-autoroll
a39dffc0ad Roll Skia from 02890036028e to 0e444e355607 (9 revisions) (flutter/engine#39723)
https://skia.googlesource.com/skia.git/+log/02890036028e..0e444e355607

2023-02-17 johnstiles@google.com Collapse empty switch-cases in SPIR-V codegen.
2023-02-17 aaclarke@google.com Added BGR10_XR support for decoding images.
2023-02-17 robertphillips@google.com [graphite] Add colorSpace-aware gradient support
2023-02-17 armansito@google.com [graphite] Introduce ComputeStep interface
2023-02-17 jmbetancourt@google.com plumb support for building for Android through Bazel
2023-02-17 johnstiles@google.com Remove SlotMap from LValues.
2023-02-17 robertphillips@google.com Add final two configs to the ColorSpaces jobs
2023-02-17 johnstiles@google.com Combine adjacent stack-to-stack clone ops.
2023-02-17 ccameron@chromium.org SkJpegEncoder: Ensure MPF segment be written last

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC brianosman@google.com,jacksongardner@google.com,rmistry@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2023-02-17 20:52:52 +00:00
Jackson Gardner
ee497c7d4f Rollback Dart SDK to unblock the roller (flutter/engine#39722)
* Revert "Roll Dart SDK from c7ec16304216 to 8a7dc36cadf6 (1 revision) (#39716)"

This reverts commit c388f0696a207ffe95151070af147556be5b2b30.

* Revert "Roll Dart SDK from 42829b6f80b1 to c7ec16304216 (1 revision) (#39711)"

This reverts commit b828868ec964640c329e4a69f16d5b71f75ad5d2.

* Revert "Roll Dart SDK from 7642080abaf7 to 42829b6f80b1 (1 revision) (#39707)"

This reverts commit 13a8bfeb79360763aabf5dca75513a7e898a5bae.

* Revert "Roll Dart SDK from 3ec7f1f92216 to 7642080abaf7 (2 revisions) (#39702)"

This reverts commit 0fb2d7b84ecfd7a1b5008e6587c2c3ebd5f2f8c3.
2023-02-17 19:15:00 +00:00
Kaushik Iska
98aaa25559 [Impeller] Device default attachment pixel formats (flutter/engine#39655)
* [Impeller] Device default attachment pixel formats

fixes: https://github.com/flutter/flutter/issues/120498

* remove commented out defaults

* fix CR comments
2023-02-17 19:04:50 +00:00
Kaushik Iska
25a795ffe7 [impeller] support generating mip-maps on Vulkan (flutter/engine#39689)
* [impeller] support generating mip-maps on Vulkan

fix: https://github.com/flutter/flutter/issues/120134

* various bug fixes

* revert to gl surface
2023-02-17 18:48:47 +00:00
Zachary Anderson
4ecf893af3 Adds a Linux Fuchsia FEMU config that enables CSO (flutter/engine#39718)
* Adds a Linux Fuchsia FEMU config that enables CSO

* Update .ci.yaml

* Update .ci.yaml
2023-02-17 10:47:56 -08:00
Chris Bracken
2b185ea8d8 [linux] Eliminate mirrors support (flutter/engine#39701)
Support for using dart:mirrors has been deprecated for nearly two years.
this removes support for enabling mirrors from the embedder as
documented in the deprecation comment. This was primarily added as a
workaround for an internal tooling usecase, which no longer exists.

Issue: https://github.com/flutter/flutter/issues/120924
2023-02-17 09:37:03 -08:00
skia-flutter-autoroll
d2f0f8f790 Roll Skia from 5637cd56be32 to 02890036028e (2 revisions) (flutter/engine#39717)
https://skia.googlesource.com/skia.git/+log/5637cd56be32..02890036028e

2023-02-17 skia-autoroll@skia-public.iam.gserviceaccount.com Roll vulkan-deps from bda8c006c3c3 to 6c03926a2c66 (1 revision)
2023-02-17 kjlubick@google.com Reland "Move src/images to src/encode"

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC brianosman@google.com,jacksongardner@google.com,rmistry@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2023-02-17 17:29:59 +00:00
skia-flutter-autoroll
c388f0696a Roll Dart SDK from c7ec16304216 to 8a7dc36cadf6 (1 revision) (flutter/engine#39716)
https://dart.googlesource.com/sdk.git/+log/c7ec16304216..8a7dc36cadf6

2023-02-17 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com Version 3.0.0-250.0.dev

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/dart-sdk-flutter-engine
Please CC aam@google.com,dart-vm-team@google.com,jacksongardner@google.com,rmistry@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter Engine: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2023-02-17 17:02:23 +00:00
Casey Hillers
cf94c80405 Migrate skia png codec call to public interface (flutter/engine#39714) 2023-02-17 16:56:33 +00:00
skia-flutter-autoroll
fc2f6d8a75 Roll Fuchsia Mac SDK from haDvcC5VzWVdQs9Rs... to _wymybZYKzX_3iFd6... (flutter/engine#39715)
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/fuchsia-mac-sdk-flutter-engine
Please CC jacksongardner@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2023-02-17 16:52:54 +00:00
skia-flutter-autoroll
b828868ec9 Roll Dart SDK from 42829b6f80b1 to c7ec16304216 (1 revision) (flutter/engine#39711)
https://dart.googlesource.com/sdk.git/+log/42829b6f80b1..c7ec16304216

2023-02-17 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com Version 3.0.0-249.0.dev

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/dart-sdk-flutter-engine
Please CC aam@google.com,dart-vm-team@google.com,jacksongardner@google.com,rmistry@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter Engine: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2023-02-17 12:44:27 +00:00
skia-flutter-autoroll
4ee83f0fe3 Roll Skia from ba60fed7f075 to 5637cd56be32 (3 revisions) (flutter/engine#39710)
https://skia.googlesource.com/skia.git/+log/ba60fed7f075..5637cd56be32

2023-02-17 skia-autoroll@skia-public.iam.gserviceaccount.com Roll ANGLE from 13e8dabc47af to 9d84ad7da970 (10 revisions)
2023-02-17 skia-autoroll@skia-public.iam.gserviceaccount.com Roll Skia Infra from b1b0afe6ac4d to 504d379dd182 (5 revisions)
2023-02-17 skia-autoroll@skia-public.iam.gserviceaccount.com Roll Dawn from 86fbd1a7de5a to 7616dcb060e4 (4 revisions)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC brianosman@google.com,jacksongardner@google.com,rmistry@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2023-02-17 12:32:27 +00:00
skia-flutter-autoroll
738d43f19f Roll Fuchsia Linux SDK from yT4JLKTCWWwbRwB0l... to tMm2Lzb-LE20Rxwm9... (flutter/engine#39709)
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/fuchsia-linux-sdk-flutter-engine
Please CC jacksongardner@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2023-02-17 10:15:12 +00:00
skia-flutter-autoroll
13a8bfeb79 Roll Dart SDK from 7642080abaf7 to 42829b6f80b1 (1 revision) (flutter/engine#39707)
https://dart.googlesource.com/sdk.git/+log/7642080abaf7..42829b6f80b1

2023-02-17 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com Version 3.0.0-248.0.dev

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/dart-sdk-flutter-engine
Please CC aam@google.com,dart-vm-team@google.com,jacksongardner@google.com,rmistry@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter Engine: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2023-02-17 08:54:21 +00:00
Jim Graham
39c93ced57 Cached DisplayList opacity inheritance fix (flutter/engine#39690)
* only indicate opacity inheritance when DL is actually cached

* unit test

* use CacheInfo struct to simplify return values
2023-02-17 05:18:23 +00:00
skia-flutter-autoroll
b8676aff63 Roll Skia from d0df677ffd5e to ba60fed7f075 (6 revisions) (flutter/engine#39703)
https://skia.googlesource.com/skia.git/+log/d0df677ffd5e..ba60fed7f075

2023-02-17 skia-autoroll@skia-public.iam.gserviceaccount.com Roll SK Tool from b1b0afe6ac4d to d0dab2942852
2023-02-17 lovisolo@google.com Fix Docker errors on newly-recreated GCE machines.
2023-02-17 skia-autoroll@skia-public.iam.gserviceaccount.com Roll vulkan-deps from d03d09324f14 to bda8c006c3c3 (7 revisions)
2023-02-17 johnstiles@google.com Refactor stack management in SkRP codegen.
2023-02-17 armansito@google.com [graphite] Add support for indirect draw commands
2023-02-17 armansito@google.com [graphite][mtl] Support incremental resource updates in compute encoder

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC brianosman@google.com,jacksongardner@google.com,rmistry@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2023-02-17 05:14:34 +00:00
skia-flutter-autoroll
0fb2d7b84e Roll Dart SDK from 3ec7f1f92216 to 7642080abaf7 (2 revisions) (flutter/engine#39702)
https://dart.googlesource.com/sdk.git/+log/3ec7f1f92216..7642080abaf7

2023-02-16 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com Version 3.0.0-247.0.dev
2023-02-16 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com Version 3.0.0-246.0.dev

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/dart-sdk-flutter-engine
Please CC aam@google.com,dart-vm-team@google.com,jacksongardner@google.com,rmistry@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter Engine: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2023-02-17 03:25:11 +00:00
skia-flutter-autoroll
98c41bfdc9 Roll Fuchsia Mac SDK from xl9Y8o-9FDyvPogki... to haDvcC5VzWVdQs9Rs... (flutter/engine#39700)
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/fuchsia-mac-sdk-flutter-engine
Please CC jacksongardner@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2023-02-17 03:14:07 +00:00
skia-flutter-autoroll
3cacb3aff2 Roll Skia from b1800a8b9595 to d0df677ffd5e (13 revisions) (flutter/engine#39699)
https://skia.googlesource.com/skia.git/+log/b1800a8b9595..d0df677ffd5e

2023-02-16 armansito@google.com [graphite] Correct comments on compute terminology
2023-02-16 michaelludwig@google.com [graphite] Check miter limit for stroked rects
2023-02-16 kjlubick@google.com Revert "Move src/images to src/encode"
2023-02-16 kjlubick@google.com Move src/images to src/encode
2023-02-16 kjlubick@google.com Add gainmap code to fuzz target
2023-02-16 brianosman@google.com Manual roll Dawn from 01ac21cc9aba to 86fbd1a7de5a (92 revisions)
2023-02-16 johnstiles@google.com Fix GLSL codegen of empty trailing switch-case blocks.
2023-02-16 johnstiles@google.com Eliminate no-op branches via peephole optimization.
2023-02-16 johnstiles@google.com Implement switch statement in RP codegen.
2023-02-16 johnstiles@google.com Add RP builder support for case_op.
2023-02-16 ccameron@chromium.org SkJpegCodec: Merge JpegR and HDRGM
2023-02-16 brianosman@google.com Add new header to G3 build
2023-02-16 johnstiles@google.com Add RP builder op for reenable_loop_mask from the stack.

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC brianosman@google.com,jacksongardner@google.com,rmistry@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2023-02-17 02:28:09 +00:00
Chris Bracken
63fbaec5b1 [macOS] Eliminate mirrors support (flutter/engine#39694)
Support for using dart:mirrors has been deprecated for nearly two years.
this removes support for enabling mirrors from the embedder as
documented in the deprecation comment. This was primarily added as a
workaround for an internal tooling usecase, which no longer exists.

Issue: https://github.com/flutter/flutter/issues/120924
2023-02-16 17:23:38 -08:00
Loïc Sharma
a9e12287f6 [dart:ui] Introduce PlatformDispatcher.implicitView (flutter/engine#39553)
This introduces `PlatformDispatcher.implicitView`, a low-level primitive for the framework's bootstrapping. Most code, including the framework after bootstrapping, will use `View.of(context)` instead of this new API. This new primitive will let us deprecate the `window` global.

Goals:

1. **Enable multi-window**. The `PlatformDispatcher.implicitView` is nullable. If `null`, the app must create a window to get a view it can draw into.
2. **Backwards compatibility**. For "single window" apps, `PlatformDispatcher.instance.implicitView` should behave as similar to `window` as possible.
    1. The `PlatformDispatcher.instance.implicitView.viewId` should be `0`.
    1. The `PlatformDispatcher.instance.implicitView` must be available synchronously at root isolate startup. This allows the framework to determine if it can make single window assumptions at startup.
    2. The `PlatformDispatcher.instance.implicitView` reference must not change after startup: if it is null at startup, it must always be null; if it is non-null at startup, it must always be non-null. If "single window" app enters headless mode, the implicit view must remain non-null.

In the future, the embedder will control whether an implicit view is created: mobile & legacy desktop apps will have an implicit view, multi-window desktop apps won't have an implicit view. This requires updating the engine's embedder API and is out-of-scope for this change. For now, all apps will have an implicit view.

Part of https://github.com/flutter/flutter/issues/120306
2023-02-16 16:32:14 -08:00
Matej Knopp
0a6f4a106e [macOS] Implement platform view mutators (flutter/engine#38699)
* [macOS] Implement platform view mutators

* Add FlutterMutatorViewTest

* Move private declaration to test
2023-02-16 22:32:17 +00:00
Dan Field
071350e901 Remove extraneous if (flutter/engine#39683)
* Remove extraneous if

* Update geometry.cc
2023-02-16 21:09:21 +00:00
Jonah Williams
4e4af6119e [Impeller] use IPSampleDecal in advanced blends. (flutter/engine#39523)
* [impeller] use IPSampleDecal in advanced blends

* update framebuffr_blend

* ++

* ++

* YAY

* fix relative paths from local work

* Update malioc_diff.py
2023-02-16 21:06:51 +00:00
Brandon DeRosier
327c0dfeaa [Impeller] Match position attribute name across runtime effect stages (flutter/engine#39552) 2023-02-16 21:06:48 +00:00
Chris Yang
7e60a47eea test (flutter/engine#39630)
more comments
2023-02-16 20:26:16 +00:00
Rulong Chen(陈汝龙)
4fb5044193 Uses int64_t instead of int for the |view_id| parameter. (flutter/engine#39618) 2023-02-16 20:20:15 +00:00
skia-flutter-autoroll
a78e886e54 Roll Dart SDK from 09361aea2ca8 to 3ec7f1f92216 (1 revision) (flutter/engine#39686)
https://dart.googlesource.com/sdk.git/+log/09361aea2ca8..3ec7f1f92216

2023-02-16 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com Version 3.0.0-245.0.dev

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/dart-sdk-flutter-engine
Please CC aam@google.com,dart-vm-team@google.com,jacksongardner@google.com,rmistry@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter Engine: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2023-02-16 19:57:08 +00:00
Jonah Williams
83124e9bce [Impeller] align SSBOs to 16 bytes to fix iOS shader validation issue. (flutter/engine#39654)
* [Impeller] align SSBOs to 16 bytes to fix iOS shader validation issue.

* use DefaultUniformAlignment
2023-02-16 19:45:34 +00:00
Jenn Magder
6cf3c90e27 Delete dead statusBarPadding iOS code (flutter/engine#39682) 2023-02-16 19:07:03 +00:00
skia-flutter-autoroll
5efd6934a5 Roll Skia from 10c9e3b2185f to b1800a8b9595 (9 revisions) (flutter/engine#39684)
https://skia.googlesource.com/skia.git/+log/10c9e3b2185f..b1800a8b9595

2023-02-16 ccameron@chromium.org SkGainmapInfo: Fix typos in comments
2023-02-16 jvanverth@google.com [graphite] Fix up VulkanTexture.
2023-02-16 fmalita@chromium.org [skottie] Editor support for multiple layers
2023-02-16 ccameron@chromium.org SkJpegXmp: Do not hardcode namespaces
2023-02-16 ccameron@chromium.org SkJpegMultiPictureParameters: Fix version verification
2023-02-16 kjlubick@google.com Introduce filegroups and gni file lists for encoding logic
2023-02-16 herb@google.com Use glyph* instead of SkPackedGlyphID
2023-02-16 jvanverth@google.com [graphite] Hook up creation of buffers via VulkanResourceProvider.
2023-02-16 jvanverth@google.com [graphite] VulkanCaps: fix one format table def

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC brianosman@google.com,jacksongardner@google.com,rmistry@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2023-02-16 19:01:06 +00:00
skia-flutter-autoroll
66ac7e2e35 Roll Skia from f2c67bb88bc6 to 10c9e3b2185f (2 revisions) (flutter/engine#39680)
https://skia.googlesource.com/skia.git/+log/f2c67bb88bc6..10c9e3b2185f

2023-02-16 brianosman@google.com Move *SAN_Vulkan jobs from IntelBayTrail to IntelIrisXe
2023-02-16 johnstiles@google.com Add Raster Pipeline op for switch cases.

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC brianosman@google.com,jacksongardner@google.com,rmistry@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2023-02-16 16:49:23 +00:00
godofredoc
4f175e2481 Enable the same tests in linux host for v2 and legacy recipes. (flutter/engine#39635)
* Enable the same test in linux host for v2 and legacy recipes.

Dart tests were not being run in the engine v2 linux builds.

Bug: https://github.com/flutter/flutter/issues/120701

* Generate path_ops.

* Remove unopt build requirement.

* Remove the check for host_debug_unopt.

* Add shell_testing deps.

* Add path_ops.

* Build benchmarks in release.

* Enable fml benchmarks.

* Add UI benchmarks.

* Add ui_list.

* Add geometry benchmarks.

* Add remaining benchmark targets.
2023-02-16 16:39:39 +00:00
skia-flutter-autoroll
034ab59962 Roll Fuchsia Linux SDK from q7u2WyX2BSRBIzyTW... to yT4JLKTCWWwbRwB0l... (flutter/engine#39679)
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/fuchsia-linux-sdk-flutter-engine
Please CC jacksongardner@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2023-02-16 16:31:29 +00:00
skia-flutter-autoroll
a73771da8d Roll Skia from 7b3fb04bc3d4 to f2c67bb88bc6 (1 revision) (flutter/engine#39677)
https://skia.googlesource.com/skia.git/+log/7b3fb04bc3d4..f2c67bb88bc6

2023-02-16 skia-autoroll@skia-public.iam.gserviceaccount.com Roll vulkan-deps from 9389b6ff49a3 to d03d09324f14 (1 revision)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC brianosman@google.com,jacksongardner@google.com,rmistry@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2023-02-16 14:50:08 +00:00
skia-flutter-autoroll
48decc3056 Roll Dart SDK from ce9397c5fc8f to 09361aea2ca8 (3 revisions) (flutter/engine#39678)
https://dart.googlesource.com/sdk.git/+log/ce9397c5fc8f..09361aea2ca8

2023-02-16 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com Version 3.0.0-244.0.dev
2023-02-16 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com Version 3.0.0-243.0.dev
2023-02-15 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com Version 3.0.0-242.0.dev

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/dart-sdk-flutter-engine
Please CC aam@google.com,dart-vm-team@google.com,jacksongardner@google.com,rmistry@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter Engine: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2023-02-16 14:48:22 +00:00
skia-flutter-autoroll
b3b2d7dd2a Roll Fuchsia Mac SDK from YpQKlqmyn8r_snx06... to xl9Y8o-9FDyvPogki... (flutter/engine#39675)
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/fuchsia-mac-sdk-flutter-engine
Please CC jacksongardner@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2023-02-16 14:07:09 +00:00
skia-flutter-autoroll
b23fcdbe79 Roll Skia from b8b36146c7a0 to 7b3fb04bc3d4 (3 revisions) (flutter/engine#39673)
https://skia.googlesource.com/skia.git/+log/b8b36146c7a0..7b3fb04bc3d4

2023-02-16 skia-autoroll@skia-public.iam.gserviceaccount.com Roll ANGLE from 1145a4970d09 to 13e8dabc47af (11 revisions)
2023-02-16 skia-autoroll@skia-public.iam.gserviceaccount.com Roll Skia Infra from 87d3eee3434b to b1b0afe6ac4d (10 revisions)
2023-02-16 skia-autoroll@skia-public.iam.gserviceaccount.com Roll SwiftShader from a9f5c19e28bd to 64eb04027b9f (1 revision)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC brianosman@google.com,jacksongardner@google.com,rmistry@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2023-02-16 07:15:32 +00:00
skia-flutter-autoroll
969a17c216 Roll Skia from f24059cf165a to b8b36146c7a0 (2 revisions) (flutter/engine#39671)
https://skia.googlesource.com/skia.git/+log/f24059cf165a..b8b36146c7a0

2023-02-16 skia-autoroll@skia-public.iam.gserviceaccount.com Roll SK Tool from 87d3eee3434b to b1b0afe6ac4d
2023-02-16 johnstiles@google.com Factor out repeated code in Metal codegen.

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC brianosman@google.com,jacksongardner@google.com,rmistry@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2023-02-16 05:28:06 +00:00
skia-flutter-autoroll
c6f5d9b124 Roll Skia from bb3d8185f067 to f24059cf165a (4 revisions) (flutter/engine#39670)
https://skia.googlesource.com/skia.git/+log/bb3d8185f067..f24059cf165a

2023-02-16 skia-autoroll@skia-public.iam.gserviceaccount.com Roll vulkan-deps from 0186a1f39398 to 9389b6ff49a3 (11 revisions)
2023-02-15 ccameron@chromium.org SkJpegGainmapEncoder: Encode HDRGM using combined MPF and GContainer
2023-02-15 johnstiles@google.com Update unit test to exercise Metal precedence issue.
2023-02-15 ccameron@chromium.org SkJpegCodec: Create MPF component

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC brianosman@google.com,jacksongardner@google.com,rmistry@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2023-02-16 03:37:13 +00:00