DEV/flutter_flutter
1
0
Fork 0
mirror of https://github.com/flutter/flutter.git synced 2026-02-20 02:29:02 +08:00
Code Issues Packages Projects Releases Wiki Activity

[web] Don't include end-of-line characters in line boundary (flutter/engine#39693)

Browse Source
This commit is contained in:
Mouad Debbar 2023-02-17 18:27:19 -05:00 committed by GitHub
parent 66844e38d2
commit f027ff2c95
2 changed files with 5 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
engine/src/flutter/lib/web_ui/lib/src/engine/text/canvas_paragraph.dart
View File

@ -237,7 +237,7 @@ class CanvasParagraph implements ui.Paragraph {
}
final ParagraphLine line = lines[i];
return ui.TextRange(start: line.startIndex, end: line.endIndex);
return ui.TextRange(start: line.startIndex, end: line.endIndex - line.trailingNewlines);
}
@override

6
engine/src/flutter/lib/web_ui/test/text/canvas_paragraph_test.dart
View File

@ -700,7 +700,8 @@ Future<void> testMain() async {
for (int i = 0; i < 11; i++) {
expect(
paragraph.getLineBoundary(ui.TextPosition(offset: i)),
const ui.TextRange(start: 0, end: 11),
// The "\n" is not included in the line boundary.
const ui.TextRange(start: 0, end: 10),
reason: 'failed at offset $i',
);
}
@ -709,7 +710,8 @@ Future<void> testMain() async {
for (int i = 11; i < 23; i++) {
expect(
paragraph.getLineBoundary(ui.TextPosition(offset: i)),
const ui.TextRange(start: 11, end: 23),
// The "\n" is not included in the line boundary.
const ui.TextRange(start: 11, end: 22),
reason: 'failed at offset $i',
);
}