29665 Commits

Author SHA1 Message Date
skia-flutter-autoroll
85e29db9d4 Roll Skia from 04fa1c1ef69c to 9635d54210dc (2 revisions) (flutter/engine#43145)
https://skia.googlesource.com/skia.git/+log/04fa1c1ef69c..9635d54210dc

2023-06-23 robertphillips@google.com [graphite] Add SrcConstraint support
2023-06-23 michaelludwig@google.com Reland "[skif] Update lighting image filters to use FilterResult"

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC brianosman@google.com,fmalita@google.com,jsimmons@google.com,rmistry@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2023-06-23 16:19:00 +00:00
skia-flutter-autoroll
5d5f5446a2 Roll ANGLE from 9211ebf1f2ac to 2e285bb591f7 (1 revision) (flutter/engine#43144)
9211ebf1f2..2e285bb591

2023-06-23 angle-autoroll@skia-public.iam.gserviceaccount.com Roll SwiftShader from ae667fe96db9 to afd97bf1e914 (3 revisions)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/angle-flutter-engine
Please CC flutter-engine@google.com,jsimmons@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in ANGLE: http://anglebug.com/new
To file a bug in Flutter Engine: https://github.com/flutter/flutter/issues/new

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2023-06-23 15:11:41 +00:00
gmackall
805cd4816d Add a note in ImeSyncDeferringInsetsCallback explaining the reason behind capturing the latest final inset state (flutter/engine#43109)
Solely documentation change to explain the reasoning behind the change in https://github.com/flutter/engine/pull/42700.

[C++, Objective-C, Java style guides]: https://github.com/flutter/engine/blob/main/CONTRIBUTING.md#style
2023-06-23 14:21:55 +00:00
skia-flutter-autoroll
848795bbc4 Roll Skia from 6ab865ee1f65 to 04fa1c1ef69c (1 revision) (flutter/engine#43141)
https://skia.googlesource.com/skia.git/+log/6ab865ee1f65..04fa1c1ef69c

2023-06-23 skia-autoroll@skia-public.iam.gserviceaccount.com Roll vulkan-deps from 5c770c263e28 to 994861071dc5 (5 revisions)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC brianosman@google.com,fmalita@google.com,jsimmons@google.com,rmistry@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2023-06-23 13:38:09 +00:00
skia-flutter-autoroll
4397526ac8 Roll Dart SDK from 7b30bcd6207e to 81cdbe69a16b (2 revisions) (flutter/engine#43138)
https://dart.googlesource.com/sdk.git/+log/7b30bcd6207e..81cdbe69a16b

2023-06-23 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com Version 3.1.0-246.0.dev
2023-06-23 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com Version 3.1.0-245.0.dev

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/dart-sdk-flutter-engine
Please CC dart-vm-team@google.com,jsimmons@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter Engine: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2023-06-23 10:19:36 +00:00
skia-flutter-autoroll
987ca9e941 Roll ANGLE from 16d65289e868 to 9211ebf1f2ac (1 revision) (flutter/engine#43137)
16d65289e8..9211ebf1f2

2023-06-23 angle-autoroll@skia-public.iam.gserviceaccount.com Roll Chromium from 0b8bd02c6abc to 14fa1a826dad (564 revisions)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/angle-flutter-engine
Please CC flutter-engine@google.com,jsimmons@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in ANGLE: http://anglebug.com/new
To file a bug in Flutter Engine: https://github.com/flutter/flutter/issues/new

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2023-06-23 09:34:04 +00:00
skia-flutter-autoroll
ab5a4c31f7 Roll Skia from a94abf80dd2f to 6ab865ee1f65 (1 revision) (flutter/engine#43135)
https://skia.googlesource.com/skia.git/+log/a94abf80dd2f..6ab865ee1f65

2023-06-23 skia-autoroll@skia-public.iam.gserviceaccount.com Roll ANGLE from ac263582dda4 to c1ba8e6f28d8 (11 revisions)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC brianosman@google.com,fmalita@google.com,jsimmons@google.com,rmistry@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2023-06-23 07:46:06 +00:00
skia-flutter-autoroll
cee6554538 Roll Fuchsia Linux SDK from tcVndpnH_jzGm5LsJ... to VSKvLPB4DCIDvXzOA... (flutter/engine#43134)
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/fuchsia-linux-sdk-flutter-engine
Please CC jsimmons@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2023-06-23 07:38:20 +00:00
skia-flutter-autoroll
08a7e697f7 Roll ANGLE from ac4f52c4f7ff to 16d65289e868 (1 revision) (flutter/engine#43133)
ac4f52c4f7..16d65289e8

2023-06-23 syoussefi@chromium.org Vulkan: Remove hashing of the SPIR-V id in variable map

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/angle-flutter-engine
Please CC flutter-engine@google.com,jsimmons@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in ANGLE: http://anglebug.com/new
To file a bug in Flutter Engine: https://github.com/flutter/flutter/issues/new

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2023-06-23 07:06:15 +00:00
skia-flutter-autoroll
73ed54d95e Roll Skia from 450bc21cc836 to a94abf80dd2f (2 revisions) (flutter/engine#43132)
https://skia.googlesource.com/skia.git/+log/450bc21cc836..a94abf80dd2f

2023-06-23 skia-autoroll@skia-public.iam.gserviceaccount.com Roll Skia Infra from 7fe8d8d9b147 to 74755bf0105b (7 revisions)
2023-06-23 skia-autoroll@skia-public.iam.gserviceaccount.com Roll Dawn from 6dfc38b8a59d to 8278361fbbef (2 revisions)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC brianosman@google.com,fmalita@google.com,jsimmons@google.com,rmistry@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2023-06-23 06:39:05 +00:00
skia-flutter-autoroll
8a80d7d57e Roll ANGLE from 4ed2d403a329 to ac4f52c4f7ff (2 revisions) (flutter/engine#43130)
4ed2d403a3..ac4f52c4f7

2023-06-23 steven@uplinklabs.net Vulkan: release all resources on RendererVk destroy
2023-06-23 syoussefi@chromium.org Vulkan: Flatten shader interface variable maps

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/angle-flutter-engine
Please CC flutter-engine@google.com,jsimmons@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in ANGLE: http://anglebug.com/new
To file a bug in Flutter Engine: https://github.com/flutter/flutter/issues/new

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2023-06-23 05:52:10 +00:00
skia-flutter-autoroll
ab48290d56 Roll Skia from a989b6f1aec5 to 450bc21cc836 (2 revisions) (flutter/engine#43128)
https://skia.googlesource.com/skia.git/+log/a989b6f1aec5..450bc21cc836

2023-06-23 skia-autoroll@skia-public.iam.gserviceaccount.com Roll SK Tool from 6c6064d504e6 to 74755bf0105b
2023-06-23 skia-autoroll@skia-public.iam.gserviceaccount.com Manual roll Dawn from 58f0978d5039 to 6dfc38b8a59d (20 revisions)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC brianosman@google.com,fmalita@google.com,jsimmons@google.com,rmistry@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2023-06-23 05:25:16 +00:00
Dan Field
682e06b5fc Removed outdated comment from lib/ui/canvas.h (flutter/engine#43112)
This no longer applies.
2023-06-23 04:29:19 +00:00
skia-flutter-autoroll
4f1774d782 Roll Dart SDK from 05d99585adab to 7b30bcd6207e (1 revision) (flutter/engine#43123)
https://dart.googlesource.com/sdk.git/+log/05d99585adab..7b30bcd6207e

2023-06-23 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com Version 3.1.0-244.0.dev

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/dart-sdk-flutter-engine
Please CC dart-vm-team@google.com,jsimmons@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter Engine: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2023-06-23 03:45:43 +00:00
skia-flutter-autoroll
3d40f7724e Roll Skia from 6595192c8352 to a989b6f1aec5 (1 revision) (flutter/engine#43120)
https://skia.googlesource.com/skia.git/+log/6595192c8352..a989b6f1aec5

2023-06-23 nicolettep@google.com [graphite] Add binding field to descriptor struct and rename appropriately; utilize in Vulkan

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC brianosman@google.com,fmalita@google.com,jsimmons@google.com,rmistry@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2023-06-23 02:13:11 +00:00
skia-flutter-autoroll
8cbc29769a Roll Fuchsia Mac SDK from Ylc35wOk0_j0NLzDv... to 07vKo_Vaiy_Vw2xxb... (flutter/engine#43119)
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/fuchsia-mac-sdk-flutter-engine
Please CC jsimmons@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2023-06-23 01:15:17 +00:00
Brandon DeRosier
e88246ebb4 [Impeller] Include CPU blends + Flutter blend reference image in goldens (flutter/engine#43117)
Part of https://github.com/flutter/flutter/issues/128606.

- Adds blend imagery that matches the Flutter BlendMode documentation:
https://api.flutter.dev/flutter/dart-ui/BlendMode.html
- Adds a clear side-by-side comparison of SaveLayer blending vs CPU
blending to make verifying correctness possible.
  - Top squares are SaveLayer-applied blends.
  - Bottom squares are CPU blends.
2023-06-22 17:57:13 -07:00
gaaclarke
3604e9b519 [Impeller] Fix and reland drawPaint collapsing optimization. (flutter/engine#43097)
Collapses DrawPaint calls into clear colors when possible.

issue https://github.com/flutter/flutter/issues/129292
relands https://github.com/flutter/engine/pull/41711

## Pre-launch Checklist

- [x] I read the [Contributor Guide] and followed the process outlined
there for submitting PRs.
- [x] I read the [Tree Hygiene] wiki page, which explains my
responsibilities.
- [x] I read and followed the [Flutter Style Guide] and the [C++,
Objective-C, Java style guides].
- [x] I listed at least one issue that this PR fixes in the description
above.
- [x] I added new tests to check the change I am making or feature I am
adding, or Hixie said the PR is test-exempt. See [testing the engine]
for instructions on writing and running engine tests.
- [x] I updated/added relevant documentation (doc comments with `///`).
- [x] I signed the [CLA].
- [x] All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel
on [Discord].

<!-- Links -->
[Contributor Guide]:
https://github.com/flutter/flutter/wiki/Tree-hygiene#overview
[Tree Hygiene]: https://github.com/flutter/flutter/wiki/Tree-hygiene
[Flutter Style Guide]:
https://github.com/flutter/flutter/wiki/Style-guide-for-Flutter-repo
[C++, Objective-C, Java style guides]:
https://github.com/flutter/engine/blob/main/CONTRIBUTING.md#style
[testing the engine]:
https://github.com/flutter/flutter/wiki/Testing-the-engine
[CLA]: https://cla.developers.google.com/
[flutter/tests]: https://github.com/flutter/tests
[breaking change policy]:
https://github.com/flutter/flutter/wiki/Tree-hygiene#handling-breaking-changes
[Discord]: https://github.com/flutter/flutter/wiki/Chat
2023-06-22 17:40:49 -07:00
skia-flutter-autoroll
9817da472d Roll Skia from 5265b5ee1afc to 6595192c8352 (1 revision) (flutter/engine#43116)
https://skia.googlesource.com/skia.git/+log/5265b5ee1afc..6595192c8352

2023-06-22 skia-autoroll@skia-public.iam.gserviceaccount.com Roll vulkan-deps from 23a32754e715 to 5c770c263e28 (11 revisions)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC brianosman@google.com,fmalita@google.com,jsimmons@google.com,rmistry@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2023-06-23 00:38:13 +00:00
skia-flutter-autoroll
7dbf376307 Roll Dart SDK from ecca5857b3ba to 05d99585adab (4 revisions) (flutter/engine#43113)
https://dart.googlesource.com/sdk.git/+log/ecca5857b3ba..05d99585adab

2023-06-22 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com Version 3.1.0-243.0.dev
2023-06-22 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com Version 3.1.0-242.0.dev
2023-06-22 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com Version 3.1.0-241.0.dev
2023-06-22 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com Version 3.1.0-240.0.dev

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/dart-sdk-flutter-engine
Please CC dart-vm-team@google.com,jsimmons@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter Engine: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2023-06-22 23:28:31 +00:00
skia-flutter-autoroll
e20c352bf0 Roll Skia from cb44fca83da0 to 5265b5ee1afc (4 revisions) (flutter/engine#43114)
https://skia.googlesource.com/skia.git/+log/cb44fca83da0..5265b5ee1afc

2023-06-22 kjlubick@google.com Preserve SkNWayCanvas::onFlush
2023-06-22 bsalomon@google.com Fold SkMatrixProvider into SkBaseDevice and remove it.
2023-06-22 weiyuhuang@google.com Add `applyRoundingHack` to `ParagraphStyle`
2023-06-22 brianosman@google.com Remove all usage of SkMatrixProvider outside of SkDevice.

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC brianosman@google.com,fmalita@google.com,jsimmons@google.com,rmistry@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2023-06-22 23:28:29 +00:00
godofredoc
51e1adf23c Add missing android lint to linux_unopt. (flutter/engine#43099)
The test was not migrated to v2.

Bug: https://github.com/flutter/flutter/issues/127759

[C++, Objective-C, Java style guides]: https://github.com/flutter/engine/blob/main/CONTRIBUTING.md#style
2023-06-22 22:25:10 +00:00
skia-flutter-autoroll
784eaf4e31 Roll Skia from 273f4cf92b7e to cb44fca83da0 (2 revisions) (flutter/engine#43107)
https://skia.googlesource.com/skia.git/+log/273f4cf92b7e..cb44fca83da0

2023-06-22 nicolettep@google.com [graphite] Batch of Vulkan fixes for running dm
2023-06-22 jvanverth@google.com [graphite] Add Vulkan Linux bots

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC brianosman@google.com,fmalita@google.com,jsimmons@google.com,rmistry@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2023-06-22 22:20:47 +00:00
utzcoz
23d3ca2e2b [android]: Make Robolectric tests work with SDK 33 (flutter/engine#42965)
Make Robolectric tests work with SDK 33. The Robolectric doesn't support create presentation window now, so this CL also adds a custom presentation shadow to hook showing state to make related tests work.

[C++, Objective-C, Java style guides]: https://github.com/flutter/engine/blob/main/CONTRIBUTING.md#style
2023-06-22 20:33:57 +00:00
skia-flutter-autoroll
5a20ffdb0a Roll Skia from 09b36b8ce0db to 273f4cf92b7e (1 revision) (flutter/engine#43106)
https://skia.googlesource.com/skia.git/+log/09b36b8ce0db..273f4cf92b7e

2023-06-22 michaelludwig@google.com Revert "[skif] Update lighting image filters to use FilterResult"

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC brianosman@google.com,fmalita@google.com,jsimmons@google.com,rmistry@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2023-06-22 20:30:10 +00:00
skia-flutter-autoroll
1477162816 Roll ANGLE from bbcf54bcb738 to 4ed2d403a329 (7 revisions) (flutter/engine#43105)
bbcf54bcb7..4ed2d403a3

2023-06-22 msisov@igalia.com metal: disable render to texture extension.
2023-06-22 syoussefi@chromium.org Vulkan: Fix email in OWNERS
2023-06-22 geofflang@chromium.org  Metal: Store MSL in shared pointers to immutable strings
2023-06-22 geofflang@chromium.org Include framebuffer completeness reason in draw errors
2023-06-22 geofflang@chromium.org Metal: Don't force all incomplete textures to initialize
2023-06-22 romanl@google.com Add pixels checks to bandingTest on Android +toggle GL_DITHER
2023-06-22 romanl@google.com Only build angle_capture_tests_trace when building traces

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/angle-flutter-engine
Please CC flutter-engine@google.com,jsimmons@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in ANGLE: http://anglebug.com/new
To file a bug in Flutter Engine: https://github.com/flutter/flutter/issues/new

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2023-06-22 20:26:50 +00:00
Lau Ching Jun
574191ed36 Workaround a release blocker after libc++ change (flutter/engine#43091)
The code breaks in C++20 mode after libc++ removes comparisons for `std::vector` and replaces them with 'operator <=>'.

See cl/542541552 for context.
2023-06-22 19:33:44 +00:00
skia-flutter-autoroll
bb015ab8c5 Roll Skia from 8168c802c391 to 09b36b8ce0db (1 revision) (flutter/engine#43102)
https://skia.googlesource.com/skia.git/+log/8168c802c391..09b36b8ce0db

2023-06-22 brianosman@google.com Avoid division by zero in emboss mask filter

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC brianosman@google.com,fmalita@google.com,jsimmons@google.com,rmistry@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2023-06-22 19:21:06 +00:00
Brandon DeRosier
05d4a13865 [Impeller] Reland: Correctly compute UVs in texture fill (flutter/engine#43093)
Resolves https://github.com/flutter/flutter/issues/128353.
Reverts https://github.com/flutter/engine/pull/43087.

Reland without the kDecal usage -- we don't need it after the last
iteration of fixes.
2023-06-22 11:38:19 -07:00
Brandon DeRosier
034f5e4edf [Impeller] Add validation forbidding SamplerAddressMode::kDecal on the OpenGLES backend (flutter/engine#43094)
Fixes uncontrolled crash when kDecal is used (as seen on
https://github.com/flutter/engine/pull/43087).
2023-06-22 11:35:15 -07:00
Jesse Seales
baef7fd849 Use minor version, ignore patches for CodeQL (flutter/engine#43088)
The patches of CodeQL updated by dependabot were causing too many engine PRs. This change updates to allow for dependabot to just use minor versions.

*List which issues are fixed by this PR. You must list at least one issue.*
Addresses https://github.com/flutter/flutter/issues/112911

*If you had to change anything in the [flutter/tests] repo, include a link to the migration guide as per the [breaking change policy].*

[C++, Objective-C, Java style guides]: https://github.com/flutter/engine/blob/main/CONTRIBUTING.md#style
2023-06-22 18:22:49 +00:00
Dan Field
b6fa0a20a5 Print a warning when a message channel is used on the wrong thread. (flutter/engine#42928)
Fixes https://github.com/flutter/flutter/issues/128746

Prints a warning the first time a platform channel sends a message from the wrong thread with instructions/link to the site about how to fix this.
2023-06-22 18:16:40 +00:00
skia-flutter-autoroll
97c396add6 Roll Skia from 3f3e1da4b7eb to 8168c802c391 (4 revisions) (flutter/engine#43096)
https://skia.googlesource.com/skia.git/+log/3f3e1da4b7eb..8168c802c391

2023-06-22 michaelludwig@google.com [skif] Update lighting image filters to use FilterResult
2023-06-22 jacksongardner@google.com Fix assert logic.
2023-06-22 johnstiles@google.com Eliminate remaining vestiges of SkVM.
2023-06-22 johnstiles@google.com Remove SkVM codegen support from SkSL.

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC brianosman@google.com,fmalita@google.com,jsimmons@google.com,rmistry@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2023-06-22 18:08:03 +00:00
Jonah Williams
5c56768c14 [Impeller] default sample count back to 1 (but configure to 4 in defaults). (flutter/engine#43089)
Also forces the creation of a stencil attachment always on Android to reduce the number of PSO variants.

https://github.com/flutter/flutter/issues/129050
2023-06-22 17:51:49 +00:00
Mouad Debbar
907fcd3245 [web] Don't get break type from v8BreakIterator (flutter/engine#43053)
In some languages, when the text contains a new line "\n", the `v8BreakIterator` starts returning different values from `breakType()`. This caused our code to think that those line breaks were hard line breaks when in fact they were soft line breaks. Still unclear if this is a `v8BreakIterator` bug or a wrong expectation on our side regarding how `breakType()` is supposed to work.

Instead of using `v8BreakIterator.breakType()`, let's do the `soft` vs `hard` detection ourselves (we already have all the necessary pieces).

Fixes https://github.com/flutter/flutter/issues/127379
2023-06-22 17:35:44 +00:00
Alexander Aprelev
6998943fab Roll dart to 3.1.0-239.0.dev (flutter/engine#43083)
Changes since last roll
```
ecca5857b3b Version 3.1.0-239.0.dev
55e71191833 [CMSR] Add new command to LSP, to convert selected formal parameter(s) to required named.
dd4045e67d2 Version 3.1.0-238.0.dev
6a4f127831d [CMSR] Not available if external executable element.
b8d8da0183c [analyzer] Refactor visitListLiteral to handle Constants.
02b10e1321d Revert "Send DAP events through DDS"
c3f3a00465a [CMSR] More checks for not allowed order of formal parameters.
8e6290bcb0f [vm] Remove unused ObjectStore::completer_class()
67970cc6134 Add failing tests for enum and 'if'.
bf62bc27bcf Adjust the definition of coveringNode to favor identifiers
7bdbc0560ed [vm/win] Use wide-character api for local hostname on Windows.
e4b7d100a1b Bump stream_channel to 34804a13bfa3112faecddfcd6a5a4f2b6e184aa4
752b21ee169 Version 3.1.0-237.0.dev
5292ee88395 Send DAP events through DDS
dfc1b6b16b9 [vm] Store the number of used inputs in SubtypeTestCaches.
24ad7f9000b [vm/tests] Skip vm/cc/TypeArguments_Cache_ManyInstantiations on qemu.
2ca7380ab02 Flow analysis: fix first phase handling of pattern assignments.
3deaeb84dd6 [analyzer] Refactor visitFunctionReference for the const evaluator.
5838562040e [dart2wasm] Add option and target for stringref.
21d45c02685 [dart2wasm] Put string_patch into its own patch
8f6eaeb883e [infra] Pass TEST_COMPILATION_DIR to Android tests
2f27fc5ddfc [dart2wasm] Update dart2wasm script
9a6c33571f0 [vm] Set page_size_ to 0 after deleting the compressed heap.
```
2023-06-22 17:22:51 +00:00
Jonah Williams
0b17d31261 Revert "[Impeller] dont use concurrent runner to decode images on Android." (flutter/engine#43061)
Reverts flutter/engine#42944

This didn't improve any of the benchmarks, which I think at least disproves my theory on overloading. Lets go back to the prior strategy and look for improvements elsewhere.
2023-06-22 17:19:42 +00:00
Jonah Williams
635a109a6d [Impeller] Add fence waiter trace event. (flutter/engine#43092)
I suspect that some of the worst frame times are caused by submission blocking on adding a fence. Add a trace event that would make that obvious.

![unnamed](https://github.com/flutter/engine/assets/8975114/93650ac8-4451-49d7-b8fa-00fc9f7f4277)
2023-06-22 17:17:48 +00:00
Jonah Williams
aa890e3d65 [Impeller] remove Vulkan pipeline cache mutex. (flutter/engine#43085)
At least from what I've found online, this API is already safe to call from multiple threads. From testing, at startup the presence of the mutex is adding ~100ms to shader creation time, as all compilations across N threads are fighting for the same lock.

https://github.com/flutter/flutter/issues/129050
2023-06-22 16:23:44 +00:00
Zachary Anderson
85aa1a0f7c Revert "[Impeller] Correctly compute UVs in texture fill" (flutter/engine#43087)
Reverts flutter/engine#43028

An engine roll containing only this commit turned the framework tree red with a crasher on Android. I'm a bit concerned because it looked like one of the benchmarks that crashed should not have been using Impeller see https://github.com/flutter/flutter/pull/129353 and https://ci.chromium.org/ui/p/flutter/builders/prod/Linux_android%20animated_blur_backdrop_filter_perf__timeline_summary/1120/overview
2023-06-22 15:41:24 +00:00
skia-flutter-autoroll
f62f444425 Roll Fuchsia Linux SDK from 7EZeNE4aGd29VfDly... to tcVndpnH_jzGm5LsJ... (flutter/engine#43081)
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/fuchsia-linux-sdk-flutter-engine
Please CC jsimmons@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2023-06-22 15:37:50 +00:00
skia-flutter-autoroll
db6192d93c Roll Skia from 117f57a53215 to 3f3e1da4b7eb (4 revisions) (flutter/engine#43080)
https://skia.googlesource.com/skia.git/+log/117f57a53215..3f3e1da4b7eb

2023-06-22 johnstiles@google.com Remove `transformT` SkVM helpers from gradient code.
2023-06-22 kjlubick@google.com Completely remove graphite #ifdefs from subruncontainer
2023-06-22 kjlubick@google.com Move VertexFiller::boundsAndDeviceMatrix impl to src/graphite
2023-06-22 kjlubick@google.com Move VertexFiller::fillInstanceData to src/graphite

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC brianosman@google.com,fmalita@google.com,jsimmons@google.com,rmistry@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2023-06-22 15:21:57 +00:00
skia-flutter-autoroll
cb17eb5e5f Roll ANGLE from 7658525166a4 to bbcf54bcb738 (1 revision) (flutter/engine#43079)
7658525166..bbcf54bcb7

2023-06-22 syoussefi@chromium.org Vulkan: Refactor uniform/block binding duplication code

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/angle-flutter-engine
Please CC flutter-engine@google.com,jsimmons@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in ANGLE: http://anglebug.com/new
To file a bug in Flutter Engine: https://github.com/flutter/flutter/issues/new

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2023-06-22 15:05:16 +00:00
skia-flutter-autoroll
fdbdf29c04 Roll Skia from 5013b651f8ec to 117f57a53215 (1 revision) (flutter/engine#43078)
https://skia.googlesource.com/skia.git/+log/5013b651f8ec..117f57a53215

2023-06-22 herb@google.com Cubic intersections for glyph underlines

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC brianosman@google.com,fmalita@google.com,jsimmons@google.com,rmistry@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2023-06-22 14:10:27 +00:00
skia-flutter-autoroll
c6e0b73134 Roll Fuchsia Mac SDK from QtQznuUmHMTyORqxJ... to Ylc35wOk0_j0NLzDv... (flutter/engine#43076)
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/fuchsia-mac-sdk-flutter-engine
Please CC jsimmons@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2023-06-22 12:10:24 +00:00
skia-flutter-autoroll
a867ce8c53 Roll ANGLE from a2b3f9b64670 to 7658525166a4 (1 revision) (flutter/engine#43075)
a2b3f9b646..7658525166

2023-06-22 angle-autoroll@skia-public.iam.gserviceaccount.com Roll vulkan-deps from bcc1118ec796 to 23a32754e715 (6 revisions)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/angle-flutter-engine
Please CC flutter-engine@google.com,jsimmons@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in ANGLE: http://anglebug.com/new
To file a bug in Flutter Engine: https://github.com/flutter/flutter/issues/new

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2023-06-22 11:59:23 +00:00
skia-flutter-autoroll
0f9bfbea61 Roll ANGLE from ac263582dda4 to a2b3f9b64670 (1 revision) (flutter/engine#43074)
ac263582dd..a2b3f9b646

2023-06-22 angle-autoroll@skia-public.iam.gserviceaccount.com Roll Chromium from 75b049842ff8 to 0b8bd02c6abc (547 revisions)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/angle-flutter-engine
Please CC flutter-engine@google.com,jsimmons@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in ANGLE: http://anglebug.com/new
To file a bug in Flutter Engine: https://github.com/flutter/flutter/issues/new

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2023-06-22 10:09:41 +00:00
skia-flutter-autoroll
84df708771 Roll Skia from 71047dca9f77 to 5013b651f8ec (4 revisions) (flutter/engine#43073)
https://skia.googlesource.com/skia.git/+log/71047dca9f77..5013b651f8ec

2023-06-22 skia-autoroll@skia-public.iam.gserviceaccount.com Roll ANGLE from 15156b1da43d to ac263582dda4 (7 revisions)
2023-06-22 skia-autoroll@skia-public.iam.gserviceaccount.com Roll SwiftShader from b8f1a3ad5f9e to afd97bf1e914 (1 revision)
2023-06-22 skia-autoroll@skia-public.iam.gserviceaccount.com Roll SK Tool from 7fe8d8d9b147 to 44d5e772a1fb
2023-06-22 skia-autoroll@skia-public.iam.gserviceaccount.com Roll Skia Infra from 3189ad2cb814 to 7fe8d8d9b147 (7 revisions)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC brianosman@google.com,fmalita@google.com,jsimmons@google.com,rmistry@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2023-06-22 09:20:53 +00:00
Brandon DeRosier
f2dfbd9193 [Impeller] Correctly compute UVs in texture fill (flutter/engine#43028)
Resolves https://github.com/flutter/flutter/issues/128353.

Depends on https://github.com/flutter/engine/pull/43026.

* Maps the texel coordinate space correctly relative to the geometry
pixel coordinates.
* Use decal sampling for subpass textures.
* Simplify the computation by using new rect utilities such as
`Rect::Project`.
2023-06-22 01:13:37 -07:00
skia-flutter-autoroll
6e0b80e2bb Roll Skia from 076e7c004d20 to 71047dca9f77 (1 revision) (flutter/engine#43071)
https://skia.googlesource.com/skia.git/+log/076e7c004d20..71047dca9f77

2023-06-22 skia-autoroll@skia-public.iam.gserviceaccount.com Roll Dawn from 0fde633f706b to 58f0978d5039 (11 revisions)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC brianosman@google.com,fmalita@google.com,jsimmons@google.com,rmistry@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2023-06-22 05:51:30 +00:00