DEV/flutter_flutter
1
0
Fork 0
mirror of https://github.com/flutter/flutter.git synced 2026-02-20 02:29:02 +08:00
Code Issues Packages Projects Releases Wiki Activity
30,212 Commits 882 Branches 1,069 Tags
Commit Graph

23079 Commits

Author SHA1 Message Date
skia-flutter-autoroll
82bc5a47e8 Roll Skia from 359d4726e423 to c79c781a3ce3 (2 revisions) (flutter/engine#43913) 
https://skia.googlesource.com/skia.git/+log/359d4726e423..c79c781a3ce3

2023-07-21 skia-autoroll@skia-public.iam.gserviceaccount.com Roll vulkan-deps from 7db08a9e0a29 to cde04d0cde8e (8 revisions)
2023-07-21 satcom1600@hanmail.net Add Blender of RuntimeEffect to canvaskit

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC bdero@google.com,brianosman@google.com,rmistry@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2023-07-22 00:06:21 +00:00
Jason Simmons
80d0d121cd [Impeller] Do not use clear color optimization if the subpass is being collapsed into its parent (flutter/engine#43878) 
The InlinePassContext will not apply the clear color within a parent pass that is already in progress.

Fixes https://github.com/flutter/flutter/issues/130824
 2023-07-21 20:34:58 +00:00
skia-flutter-autoroll
6830d49f3d Roll Skia from 2e28fe9de378 to 359d4726e423 (1 revision) (flutter/engine#43906) 
https://skia.googlesource.com/skia.git/+log/2e28fe9de378..359d4726e423

2023-07-21 johnstiles@google.com Add `flat` modifier to SSBO index varying.

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC bdero@google.com,brianosman@google.com,rmistry@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2023-07-21 20:33:19 +00:00
Brandon DeRosier
b5ee961e4f [Impeller] Disable color attachment removal for clips on VK (flutter/engine#43905) 
This is causing a validation failure on the Vulkan backend at ToT, as discovered by @jonahwilliams.

Need to figure out why this isn't getting hit in the Vulkan goldens.
 2023-07-21 20:17:05 +00:00
Brandon DeRosier
61b006d0ed [Impeller] Add a way to query the gfx backend type. (flutter/engine#43837) 
I've been trying to avoid this, but since the context type may vary
through runtime decisions, we just need something like this to select
which shader data to pull from the Dart GPU bundle at runtime. One
alternative would be to add a special omni shader concept to the HAL,
but that seems worse than just letting renderers key with a backend enum
sometimes.

Cautioned against using it for cap checks in the doc string.
 2023-07-21 13:11:32 -07:00
skia-flutter-autoroll
6bccb3cf4c Roll Skia from 497326dc66cd to 2e28fe9de378 (2 revisions) (flutter/engine#43900) 
https://skia.googlesource.com/skia.git/+log/497326dc66cd..2e28fe9de378

2023-07-21 cmumford@google.com [infra] Add debugger_app_container Bazel config
2023-07-21 lovisolo@google.com [bazel] //gm/vias/SimpleVias.cpp: Delete redundant out.data() call.

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC bdero@google.com,brianosman@google.com,rmistry@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2023-07-21 18:55:19 +00:00
skia-flutter-autoroll
b7b6090762 Roll Skia from 1f84e9d51bba to 497326dc66cd (1 revision) (flutter/engine#43899) 
https://skia.googlesource.com/skia.git/+log/1f84e9d51bba..497326dc66cd

2023-07-21 johnstiles@google.com Fix WGSL codegen for intrinsics that might overflow.

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC bdero@google.com,brianosman@google.com,rmistry@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2023-07-21 17:58:21 +00:00
Chris Yang
eacae26086 Refactor: fix typo "setup" -> "set up" (flutter/engine#43824) 
There are several places in the engine using the word "setup" incorrectly. I have changed them to "set up"

[C++, Objective-C, Java style guides]: https://github.com/flutter/engine/blob/main/CONTRIBUTING.md#style
 2023-07-21 17:06:34 +00:00
Jonah Williams
c309bebb03 [engine] disable picture complexity raster caching (flutter/engine#43897) 
Test removing picture complexity based raster caching.
 2023-07-21 16:42:09 +00:00
skia-flutter-autoroll
8e24b623e8 Roll Skia from e3d13d1b1c42 to 1f84e9d51bba (1 revision) (flutter/engine#43896) 
https://skia.googlesource.com/skia.git/+log/e3d13d1b1c42..1f84e9d51bba

2023-07-21 kjlubick@google.com Allow Ganesh Mesh factories to take nullptr ctx

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC bdero@google.com,brianosman@google.com,rmistry@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2023-07-21 16:35:47 +00:00
Zachary Anderson
c985c25882 Revert Dart (flutter/engine#43895) 
For analyzer failures starting in
https://github.com/flutter/flutter/pull/131050
 2023-07-21 09:09:18 -07:00
skia-flutter-autoroll
61d063717c Roll Fuchsia Linux SDK from CWNVmH6f_iryKU05E... to gpjF3QRGg_KH0guW5... (flutter/engine#43894) 
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/fuchsia-linux-sdk-flutter-engine
Please CC bdero@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2023-07-21 15:42:19 +00:00
skia-flutter-autoroll
340b50386e Roll Skia from 8388ec4d242c to e3d13d1b1c42 (1 revision) (flutter/engine#43893) 
https://skia.googlesource.com/skia.git/+log/8388ec4d242c..e3d13d1b1c42

2023-07-21 kjlubick@google.com Merge SkGpuBlurUtils into GrBlurUtils

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC bdero@google.com,brianosman@google.com,rmistry@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2023-07-21 15:25:02 +00:00
skia-flutter-autoroll
56a8802593 Roll Dart SDK from 8662af7d9aa3 to 6e79151ce988 (2 revisions) (flutter/engine#43885) 
https://dart.googlesource.com/sdk.git/+log/8662af7d9aa3..6e79151ce988

2023-07-21 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com Version 3.1.0-335.0.dev
2023-07-21 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com Version 3.1.0-334.0.dev

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/dart-sdk-flutter-engine
Please CC bdero@google.com,dart-vm-team@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter Engine: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2023-07-21 10:24:53 +00:00
skia-flutter-autoroll
bf1080e3b0 Roll Skia from 3dce2d4ee4f3 to 4857e876d8cf (1 revision) (flutter/engine#43882) 
https://skia.googlesource.com/skia.git/+log/3dce2d4ee4f3..4857e876d8cf

2023-07-21 skia-autoroll@skia-public.iam.gserviceaccount.com Roll Skia Infra from a1951225a465 to ac6948eb5d9f (4 revisions)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC bdero@google.com,brianosman@google.com,rmistry@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2023-07-21 06:28:16 +00:00
skia-flutter-autoroll
0a24baa004 Roll Dart SDK from 1df95f328d0c to 8662af7d9aa3 (1 revision) (flutter/engine#43876) 
https://dart.googlesource.com/sdk.git/+log/1df95f328d0c..8662af7d9aa3

2023-07-20 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com Version 3.1.0-333.0.dev

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/dart-sdk-flutter-engine
Please CC bdero@google.com,dart-vm-team@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter Engine: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2023-07-21 02:38:21 +00:00
Ian Hickson
69ded94b7b Add a breadcrumb for people who want to run the web tests (flutter/engine#43865) 2023-07-21 02:32:11 +00:00
skia-flutter-autoroll
193c9749fd Roll Skia from 049f389db75b to bae54bbf49bd (2 revisions) (flutter/engine#43875) 
https://skia.googlesource.com/skia.git/+log/049f389db75b..bae54bbf49bd

2023-07-21 lovisolo@google.com [bazel] //gm/BazelGMRunner.cpp: Add support for the "picture" via.
2023-07-21 lovisolo@google.com [bazel] //gm/BazelGMRunner.cpp: Add support for the "picture_serialization" via.

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC bdero@google.com,brianosman@google.com,rmistry@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2023-07-21 02:24:20 +00:00
skia-flutter-autoroll
f558044d9a Roll Skia from 6f2b2e94ebbd to 049f389db75b (1 revision) (flutter/engine#43873) 
https://skia.googlesource.com/skia.git/+log/6f2b2e94ebbd..049f389db75b

2023-07-20 kjlubick@google.com Do not register SDFMaskFilter for flattening

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC bdero@google.com,brianosman@google.com,rmistry@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2023-07-21 01:04:34 +00:00
Dan Field
193c6260fe [Impeller] [Vulkan] Add reset command buffer bit to command pools. (flutter/engine#43867) 
Without this bit, we're holding it wrong. From the docs:

> VK_COMMAND_POOL_CREATE_RESET_COMMAND_BUFFER_BIT allows any command buffer allocated from a pool to be individually reset to the initial state; either by calling vkResetCommandBuffer, or via the implicit reset when calling vkBeginCommandBuffer. If this flag is not set on a pool, then vkResetCommandBuffer must not be called for any command buffer allocated from that pool.

This means our reset calls later are getting ignored.

Fixes https://github.com/flutter/flutter/issues/131001
 2023-07-20 23:27:13 +00:00
skia-flutter-autoroll
4da623eefc Roll Skia from 981146e6305d to 6f2b2e94ebbd (3 revisions) (flutter/engine#43871) 
https://skia.googlesource.com/skia.git/+log/981146e6305d..6f2b2e94ebbd

2023-07-20 aeubanks@google.com Fix newly warned -Wconstant-logical-operand
2023-07-20 johnstiles@google.com Add WGSL support for uniforms inside interface blocks.
2023-07-20 skia-autoroll@skia-public.iam.gserviceaccount.com Roll vulkan-deps from e1c3b16d5aa5 to 13599b120a68 (8 revisions)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC bdero@google.com,brianosman@google.com,rmistry@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2023-07-20 23:20:04 +00:00
skia-flutter-autoroll
0f60dcbbf0 Roll Skia from 100d0f858f02 to 981146e6305d (3 revisions) (flutter/engine#43866) 
https://skia.googlesource.com/skia.git/+log/100d0f858f02..981146e6305d

2023-07-20 jmbetancourt@google.com add typeface setting to SkottieSlide's slot manager interface
2023-07-20 brianosman@google.com Convert recently added GM to unit test
2023-07-20 jvanverth@google.com [graphite] Get Vulkan present working.

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC bdero@google.com,brianosman@google.com,rmistry@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2023-07-20 21:37:13 +00:00
Jonah Williams
949e91bbba [Impeller] Provide fragment uniform data through varyings for solid color, glyph atlas, texture shaders. (flutter/engine#43838) 
From experimentation, providing these values through varyings runs substantially faster on Pixel devices. Alternative solutions to use f16 or push constants did not improve things substantially.

These subset of shaders are used very heavily and so they benefit from this change more substantially. I don't think this is applicable to all shaders as there is going to be an additional varying interpolation cost.

See also: [go/impeller-slow-fragment-shader](http://goto.google.com/impeller-slow-fragment-shader)
 2023-07-20 20:47:16 +00:00
skia-flutter-autoroll
f4fb229fe4 Roll Skia from 18e834916f47 to 100d0f858f02 (7 revisions) (flutter/engine#43863) 
https://skia.googlesource.com/skia.git/+log/18e834916f47..100d0f858f02

2023-07-20 penghuang@chromium.org dawn: remove a annoying spammy log from DawnCaps
2023-07-20 brianosman@google.com Remove reference to (obsolete/deleted) T8888 config
2023-07-20 armansito@google.com [graphite][vello] Adjust rough buffer size reduction
2023-07-20 armansito@google.com [graphite][AtlasShapeRenderStep] Implement boundsOutset
2023-07-20 robertphillips@google.com [graphite] Implement SkImage::textureSize
2023-07-20 skia-autoroll@skia-public.iam.gserviceaccount.com Roll skcms from 6140cf9c51a5 to 1323db7bd0b4 (2 revisions)
2023-07-20 cmumford@google.com [infra] Reland "Add rule to build final debugger-app image"

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC bdero@google.com,brianosman@google.com,rmistry@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2023-07-20 20:19:12 +00:00
skia-flutter-autoroll
614d825cd6 Roll Skia from a3aca7ae523e to 18e834916f47 (1 revision) (flutter/engine#43860) 
https://skia.googlesource.com/skia.git/+log/a3aca7ae523e..18e834916f47

2023-07-20 johnstiles@google.com Fix Overflow test in WGSL codegen.

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC bdero@google.com,brianosman@google.com,rmistry@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2023-07-20 19:02:23 +00:00
Mouad Debbar
a9896d3b98 Add url to get GoogleFonts API key (flutter/engine#43857) 2023-07-20 18:34:06 +00:00
Dan Field
f28f9ca32c More validation logs for CommandEncoderVK submission (flutter/engine#43859) 
Helps while investigating https://github.com/flutter/flutter/issues/131001
 2023-07-20 18:29:56 +00:00
skia-flutter-autoroll
ceb3365839 Roll Dart SDK from 857c9a2ae14a to 1df95f328d0c (1 revision) (flutter/engine#43858) 
https://dart.googlesource.com/sdk.git/+log/857c9a2ae14a..1df95f328d0c

2023-07-20 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com Version 3.1.0-332.0.dev

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/dart-sdk-flutter-engine
Please CC bdero@google.com,dart-vm-team@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter Engine: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2023-07-20 18:25:43 +00:00
Mouad Debbar
d205cf6af6 [web] Preserve correct CanvasKit Variant during test initialization (flutter/engine#43854) 
At some point, we started setting `useColorEmoji` to true in our tests, but we were doing it in a way that resets all other configurations to their defaults. This caused the `canvasKitVariant` config to be lost and always set to the default `auto`.

This PR fixes the issue and adds tests to:

1. Make sure that the CanvasKit suite always runs with a specific variant (not `auto`).
2. Make sure the given CanvasKit variant makes it all the way through to the tests.

The test harness uses a backdoor (a global JS property on `window`) to communicate which canvaskit variant it's using. The test then compares that with `configuration.canvasKitVariant` to make sure they match. If they don't match, then the configuration was lost somewhere on the way.

Fixes https://github.com/flutter/flutter/issues/130993
 2023-07-20 18:06:24 +00:00
skia-flutter-autoroll
102c2eda87 Roll Skia from b8133dda3a8c to a3aca7ae523e (1 revision) (flutter/engine#43855) 
https://skia.googlesource.com/skia.git/+log/b8133dda3a8c..a3aca7ae523e

2023-07-20 mike@reedtribe.org Remove unneeded generateAdvance() from SkScalerContext

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC bdero@google.com,brianosman@google.com,rmistry@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2023-07-20 17:40:14 +00:00
skia-flutter-autoroll
7ce5bd6366 Roll Skia from 401c85ab1e21 to b8133dda3a8c (4 revisions) (flutter/engine#43853) 
https://skia.googlesource.com/skia.git/+log/401c85ab1e21..b8133dda3a8c

2023-07-20 johnstiles@google.com Refactor GetConstantValueOrNullForVariable logic.
2023-07-20 brianosman@google.com Remove kBGR_888x_SkColorType
2023-07-20 johnstiles@google.com Remove inaccurate comment in YUVA pixmaps.
2023-07-20 ramasamy.si@zohocorp.com Fix crash in skparagraph's visit function

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC bdero@google.com,brianosman@google.com,rmistry@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2023-07-20 16:22:22 +00:00
skia-flutter-autoroll
e2371670ad Roll Dart SDK from 603aacd8400f to 857c9a2ae14a (1 revision) (flutter/engine#43851) 
https://dart.googlesource.com/sdk.git/+log/603aacd8400f..857c9a2ae14a

2023-07-20 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com Version 3.1.0-331.0.dev

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/dart-sdk-flutter-engine
Please CC bdero@google.com,dart-vm-team@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter Engine: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2023-07-20 14:36:03 +00:00
skia-flutter-autoroll
272e54908f Roll Skia from b238c09fe959 to d09e9869f84c (1 revision) (flutter/engine#43842) 
https://skia.googlesource.com/skia.git/+log/b238c09fe959..d09e9869f84c

2023-07-20 skia-autoroll@skia-public.iam.gserviceaccount.com Roll Skia Infra from c10b5129407a to a1951225a465 (3 revisions)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC bdero@google.com,brianosman@google.com,rmistry@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2023-07-20 06:25:22 +00:00
John McCutchan
b3945f7706 Add a PlatformViewRenderTarget abstraction (flutter/engine#43813) 
- Introduce PlatformViewRenderTarget interface.
- Refactor VirtualDisplayController and PlatformViewWrapper to extract
SurfaceTexturePlatformViewRenderTarget into a separate class.

In a future CL I will add an ImageReaderPlatformViewRenderTarget which
will enable Platform Views on Impeller/Vulkan.

Tracking issue: https://github.com/flutter/flutter/issues/130892
 2023-07-19 20:26:21 -07:00
skia-flutter-autoroll
4cb94272fd Roll Dart SDK from 677bbf64d4d7 to 368a205aa1d4 (1 revision) (flutter/engine#43841) 
https://dart.googlesource.com/sdk.git/+log/677bbf64d4d7..368a205aa1d4

2023-07-20 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com Version 3.1.0-329.0.dev

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/dart-sdk-flutter-engine
Please CC bdero@google.com,dart-vm-team@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter Engine: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2023-07-20 02:27:33 +00:00
skia-flutter-autoroll
6998929456 Roll Skia from 8413c82dea43 to b238c09fe959 (1 revision) (flutter/engine#43835) 
https://skia.googlesource.com/skia.git/+log/8413c82dea43..b238c09fe959

2023-07-19 johnstiles@google.com Add a WGSL testbed file to dm tests.

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC bdero@google.com,brianosman@google.com,rmistry@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2023-07-19 23:03:57 +00:00
skia-flutter-autoroll
f7b39000fd Roll Dart SDK from 936824d49aa7 to 677bbf64d4d7 (1 revision) (flutter/engine#43833) 
https://dart.googlesource.com/sdk.git/+log/936824d49aa7..677bbf64d4d7

2023-07-19 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com Version 3.1.0-328.0.dev

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/dart-sdk-flutter-engine
Please CC bdero@google.com,dart-vm-team@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter Engine: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2023-07-19 22:29:14 +00:00
Jim Graham
6f48af53e9 Reland "Add non-rendering operation culling to DisplayListBuilder" (#41463) (flutter/engine#43831) 
Fixes: https://github.com/flutter/flutter/issues/129862

This reverts commit 6237207218438748937fd4878c54884f83e66df2.

The framework test that was blocking the previous reland has been [fixed](https://github.com/flutter/flutter/pull/130751) to not rely on non-visible (cullable) operations.
 2023-07-19 22:26:01 +00:00
skia-flutter-autoroll
c880af72b7 Roll Skia from bf75ae2f6eec to 8413c82dea43 (1 revision) (flutter/engine#43832) 
https://skia.googlesource.com/skia.git/+log/bf75ae2f6eec..8413c82dea43

2023-07-19 johnstiles@google.com Fix overflow in matrix-multiply constant folding.

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC bdero@google.com,brianosman@google.com,rmistry@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2023-07-19 22:13:10 +00:00
skia-flutter-autoroll
4334052623 Roll Skia from b1d6eab1f590 to bf75ae2f6eec (2 revisions) (flutter/engine#43829) 
https://skia.googlesource.com/skia.git/+log/b1d6eab1f590..bf75ae2f6eec

2023-07-19 skia-autoroll@skia-public.iam.gserviceaccount.com Roll vulkan-deps from 616ec95a04fe to f3c508b81760 (4 revisions)
2023-07-19 johnstiles@google.com Fix assertion in inliner when makeSampler2D is used.

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC bdero@google.com,brianosman@google.com,rmistry@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2023-07-19 21:25:36 +00:00
Loïc Sharma
5509e3b51f Add the 'affects: desktop' label to labeler.yml (flutter/engine#43827) 
The desktop team uses the [`affects: desktop`](https://github.com/flutter/engine/pulls?q=is%3Aopen+label%3A%22affects%3A+desktop%22+sort%3Aupdated-desc) label to [triage](https://github.com/flutter/flutter/wiki/Triage#desktop-platforms-team-team-desktop) pull requests.
 2023-07-19 21:01:57 +00:00
skia-flutter-autoroll
34106734af Roll Skia from 30d458aea0b9 to b1d6eab1f590 (2 revisions) (flutter/engine#43826) 
https://skia.googlesource.com/skia.git/+log/30d458aea0b9..b1d6eab1f590

2023-07-19 jmbetancourt@google.com [skottie] plumb vec2 support to SlotManager
2023-07-19 jmbetancourt@google.com [skottie] move color slot tracking to bind call

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC bdero@google.com,brianosman@google.com,rmistry@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2023-07-19 20:36:13 +00:00
Jim Graham
8d73d38291 fix handling of clipped rendering inside a layer that applies a filter (flutter/engine#43787) 
When a saveLayer is rendered with an ImageFilter that modifies the bounds of the rendered pixels, and some of the content of that saveLayer did not intersect the clip, but the filtered output of that content did intersect the clip, we might not accumulate the bounds of those rendering operations into the DisplayList bounds.

This bug was not encountered during practical testing, but showed up on some testing with the new NOP culling code.

For now, this bug only affects the accuracy of the reported bounds of the DisplayList, but that can affect raster caching and potentially the layer culling done in the LayerTree. It might also affect the accuracy of the RTree associated with the DisplayList, which would only show up in rare circumstances when the indicated operation was used in the presence of an embedded view.
 2023-07-19 18:40:31 +00:00
skia-flutter-autoroll
017f0f9085 Roll Skia from 8d19d04472e1 to 650c980daa72 (6 revisions) (flutter/engine#43821) 
https://skia.googlesource.com/skia.git/+log/8d19d04472e1..650c980daa72

2023-07-19 jvanverth@google.com [GL] Restrict setMaxLevel mipmap fix
2023-07-19 michaelludwig@google.com Consolidate SkImage::makeWithFilter implementations
2023-07-19 cmumford@google.com Revert "[infra] Add rule to build final debugger-app image"
2023-07-19 aeubanks@google.com Fix newly warned -Wconstant-logical-operand
2023-07-19 bungeman@google.com Roll FreeType from e4586d96 to 5769f13a (9 commits)
2023-07-19 brianosman@google.com Remove gltestthreading config

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC bdero@google.com,brianosman@google.com,rmistry@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2023-07-19 18:38:54 +00:00
skia-flutter-autoroll
8eb6250802 Roll Skia from 4728980564b1 to a352521a3a7c (3 revisions) (flutter/engine#43816) 
https://skia.googlesource.com/skia.git/+log/4728980564b1..a352521a3a7c

2023-07-19 nigeltao@google.com Roll third_party/wuffs to version 0.3.3
2023-07-19 johnstiles@google.com Enable inlining for runtime effects using SkRP.
2023-07-19 johnstiles@google.com Add instruction count to the top of SkRP dumps.

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC bdero@google.com,brianosman@google.com,rmistry@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2023-07-19 16:57:53 +00:00
Brandon DeRosier
6bb9c99a11 [Impeller] Disable color attachment on clip pipelines for Metal & Vulkan. (flutter/engine#43781) 
Remove the color attachment completely in Metal and Vulkan clips.

When the color write mask is set to all false, Metal is smart about not
executing the fragment shader at all, but some Vulkan and GL drivers may
not be. GL requires binding shader objects to draw, and so a cap check
is needed here.

In the future, we could add minimal no-op shaders to use with the GL
clip pipeline to shave off a few flops on drivers that aren't smart
about the color write mask.
 2023-07-19 09:57:50 -07:00
Jason Simmons
a4e0000a77 Apply the offset to the child bounds of an ImageFilterLayer with no filter (flutter/engine#43783) 
Fixes https://github.com/flutter/flutter/issues/130318
 2023-07-19 15:15:02 +00:00
skia-flutter-autoroll
0013a53d42 Roll Skia from e9409b832799 to 1f175b7a2155 (1 revision) (flutter/engine#43811) 
https://skia.googlesource.com/skia.git/+log/e9409b832799..1f175b7a2155

2023-07-19 robertphillips@google.com [graphite] Add initial precompilation fuzzer

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC bdero@google.com,brianosman@google.com,rmistry@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2023-07-19 14:32:04 +00:00
skia-flutter-autoroll
a2ab2e8980 Roll Fuchsia Linux SDK from ZABO4Om1vToxhI394... to -SNz0augjLKFVsUWn... (flutter/engine#43810) 
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/fuchsia-linux-sdk-flutter-engine
Please CC bdero@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2023-07-19 12:44:27 +00:00
Kevin Lubick
c4494c9718 Update legacy call to SkImage::makeSubset (flutter/engine#43786) 
In https://skia-review.googlesource.com/c/skia/+/671679 Skia updated the
calls to SkImage::makeSubset() to always need a `GrDirectContext*`. This
updates Flutter's one call that needed it.

## Pre-launch Checklist

- [x] I read the [Contributor Guide] and followed the process outlined
there for submitting PRs.
- [x] I read the [Tree Hygiene] wiki page, which explains my
responsibilities.
- [x] I read and followed the [Flutter Style Guide] and the [C++,
Objective-C, Java style guides].
- [ ] I listed at least one issue that this PR fixes in the description
above.
- [x] I added new tests to check the change I am making or feature I am
adding, or Hixie said the PR is test-exempt. See [testing the engine]
for instructions on writing and running engine tests.
- [ ] I updated/added relevant documentation (doc comments with `///`).
- [x] I signed the [CLA].
- [x] All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel
on [Discord].

<!-- Links -->
[Contributor Guide]:
https://github.com/flutter/flutter/wiki/Tree-hygiene#overview
[Tree Hygiene]: https://github.com/flutter/flutter/wiki/Tree-hygiene
[Flutter Style Guide]:
https://github.com/flutter/flutter/wiki/Style-guide-for-Flutter-repo
[C++, Objective-C, Java style guides]:
https://github.com/flutter/engine/blob/main/CONTRIBUTING.md#style
[testing the engine]:
https://github.com/flutter/flutter/wiki/Testing-the-engine
[CLA]: https://cla.developers.google.com/
[flutter/tests]: https://github.com/flutter/tests
[breaking change policy]:
https://github.com/flutter/flutter/wiki/Tree-hygiene#handling-breaking-changes
[Discord]: https://github.com/flutter/flutter/wiki/Chat
 2023-07-19 08:26:05 -04:00