DEV/flutter_flutter
1
0
Fork 0
mirror of https://github.com/flutter/flutter.git synced 2026-02-20 02:29:02 +08:00
Code Issues Packages Projects Releases Wiki Activity

Apply the offset to the child bounds of an ImageFilterLayer with no filter (flutter/engine#43783)

Browse Source 
Fixes https://github.com/flutter/flutter/issues/130318
This commit is contained in:
Jason Simmons 2023-07-19 08:15:02 -07:00 committed by GitHub
parent 885df86099
commit a4e0000a77
2 changed files with 14 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

1
engine/src/flutter/flow/layers/image_filter_layer.cc
View File

@ -64,6 +64,7 @@ void ImageFilterLayer::Preroll(PrerollContext* context) {
PrerollChildren(context, &child_bounds);
if (!filter_) {
child_bounds.offset(offset_);
set_paint_bounds(child_bounds);
return;
}

13
engine/src/flutter/flow/layers/image_filter_layer_unittests.cc
View File

@ -711,6 +711,19 @@ TEST_F(ImageFilterLayerDiffTest, ImageFilterLayerInflatestChildSize) {
EXPECT_EQ(damage.frame_damage, SkIRect::MakeLTRB(40, 40, 170, 170));
}
TEST_F(ImageFilterLayerTest, EmptyFilterWithOffset) {
const SkRect child_bounds = SkRect::MakeLTRB(10.0f, 11.0f, 19.0f, 20.0f);
const SkPath child_path = SkPath().addRect(child_bounds);
const DlPaint child_paint = DlPaint(DlColor::kYellow());
auto mock_layer = std::make_shared<MockLayer>(child_path, child_paint);
const SkPoint offset = SkPoint::Make(5.0f, 6.0f);
auto layer = std::make_shared<ImageFilterLayer>(nullptr, offset);
layer->Add(mock_layer);
layer->Preroll(preroll_context());
EXPECT_EQ(layer->paint_bounds(), child_bounds.makeOffset(offset));
}
} // namespace testing
} // namespace flutter