DEV/flutter_flutter
1
0
Fork 0
mirror of https://github.com/flutter/flutter.git synced 2026-02-20 02:29:02 +08:00
Code Issues Packages Projects Releases Wiki Activity

[Impeller] Do not use clear color optimization if the subpass is being collapsed into its parent (flutter/engine#43878)

Browse Source 
The InlinePassContext will not apply the clear color within a parent pass that is already in progress.

Fixes https://github.com/flutter/flutter/issues/130824
This commit is contained in:
Jason Simmons 2023-07-21 13:34:58 -07:00 committed by GitHub
parent 6830d49f3d
commit 80d0d121cd
1 changed files with 11 additions and 11 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

22
engine/src/flutter/impeller/entity/entity_pass.cc
View File

@ -604,12 +604,10 @@ bool EntityPass::OnRender(
return false;
}
if (!(GetClearColor(root_pass_size) == Color::BlackTransparent())) {
if (!collapsed_parent_pass &&
!GetClearColor(root_pass_size).IsTransparent()) {
// Force the pass context to create at least one new pass if the clear color
// is present. The `EndPass` first ensures that the clear color will get
// applied even if this EntityPass is getting collapsed into the parent
// pass.
pass_context.EndPass();
// is present.
pass_context.GetRenderPass(pass_depth);
}
@ -752,13 +750,15 @@ bool EntityPass::OnRender(
bool is_collapsing_clear_colors = true;
for (const auto& element : elements_) {
// Skip elements that are incorporated into the clear color.
if (is_collapsing_clear_colors) {
auto [entity_color, _] =
ElementAsBackgroundColor(element, root_pass_size);
if (entity_color.has_value()) {
continue;
if (!collapsed_parent_pass) {
if (is_collapsing_clear_colors) {
auto [entity_color, _] =
ElementAsBackgroundColor(element, root_pass_size);
if (entity_color.has_value()) {
continue;
}
is_collapsing_clear_colors = false;
}
is_collapsing_clear_colors = false;
}
EntityResult result =