1048 Commits

Author SHA1 Message Date
ColdPaleLight
f2007cfd2b Use DisplayListMatrixClipTracker in DisplayListBuilder (flutter/engine#38349)
* Use DisplayListMatrixClipTracker in DisplayListBuilder

* Ignore is_aa

* Revert "Ignore is_aa"

This reverts commit b201dadc773f8e726ec68ed88114df9be7b5a9b0.

* Tweak code

* Use content_culled

* getLocalClipBounds without device clip bounds roundsOut

* Tweak code and add more tests

* remove virtual
2022-12-20 10:05:40 +00:00
Siva
99b4cb739a Manual Roll Dart SDK from 7b4d4ec3cad1 to 35f6108ef685 (4 revisions) (flutter/engine#38409)
* Manual Roll Dart SDK from 7b4d4ec3cad1 to 35f6108ef685 (4 revisions)

https://dart.googlesource.com/sdk.git/+log/7b4d4ec3cad1..35f6108ef685

2022-12-16 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com Version 3.0.0-39.0.dev
2022-12-16 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com Version 3.0.0-38.0.dev
2022-12-16 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com Version 3.0.0-37.0.dev
2022-12-16 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com Version 3.0.0-36.0.dev

* Add package:js path dependency
2022-12-19 19:31:31 -08:00
Chinmay Garde
a35e55cf9a [Impeller] Disable impeller_unittests. (flutter/engine#38307)
Fixes https://github.com/flutter/flutter/issues/114872
Followup in https://github.com/flutter/flutter/issues/117122
2022-12-15 02:27:17 +00:00
Phil Quitslund
9545fe3573 Fix new unnecessary_parenthesis diagnostics. (flutter/engine#38291)
These will get flagged w/ the latest linter.

See, [try failure](https://logs.chromium.org/logs/dart/buildbucket/cr-buildbucket/8794866247739072257/+/u/analyze_flutter_plugins/stdout) and [linter roll PR](https://dart-review.googlesource.com/c/sdk/+/275044).
2022-12-14 20:05:08 +00:00
Zachary Anderson
9896c5f66d pylint all Python scripts under testing/ (flutter/engine#38268) 2022-12-14 16:23:16 +00:00
Jonah Williams
6bbe15577d Fix sampler offsets (flutter/engine#38170)
* [impeller] dont remap floats

* ++

* Update fragment_shader_test.dart

* ++:

* ++
2022-12-10 18:37:04 +00:00
Zachary Anderson
6a6203c77e Pylint testing/run_tests.py (flutter/engine#38016) 2022-12-09 09:14:48 -08:00
Jonah Williams
83206b1c23 [Impeller] order metal samplers according to declared order and not usage order (flutter/engine#38115)
* [Impeller] order metal samplers according to declared order and not use order

* ++

* always enabl remapping

* Revert "always enabl remapping"

This reverts commit 2fffb05aeea9cfcbd0df051540054ca0d6c337c0.

* ++

* add test

* ++

* ++

* only run on mac
2022-12-08 17:23:12 +00:00
Erik
b7bf0a3155 Full implementation of text-input-test (flutter/engine#37986)
Implements text-input-test, validates that we're able to receive the correct platform messages through the flutter/keyevent channel
2022-12-07 12:17:51 -05:00
Jason Simmons
426d21f97e Disable an extension in Xvfb to work around errors seen when running Impeller/Vulkan unit tests (flutter/engine#38092)
See https://github.com/flutter/flutter/issues/116130
2022-12-06 17:18:12 +00:00
Ian Hickson
7ab8cddeb7 Documentation and other cleanup in dart:ui, plus a small performance improvement. (flutter/engine#38047)
* Remove nonsensical (and I think unnecessary?) comment.
* Document willChangeHint, isComplexHint
* Fix grammer in Rect docs
* Remove runtimeType.toString twice
* Add detail to ImageShader constructor docs.
* Document Vertices and drawVertices!
* Update checks in Vertices constructors (and add tests).
* Fix some typos.
* Minor other doc improvements.
* Fold in @jonahwilliams' performance improvement from https://github.com/flutter/engine/pull/38041
2022-12-03 01:13:06 +00:00
Erik
94c88a9253 [fuchsia] arm64 Dart runner (flutter/engine#37399)
- Fuchsia FEMU tests now run using `ffx`
- There is now a Fuchsia arm64 FEMU builder to allow tests to run on an arm64 emulator
2022-11-28 17:39:50 -05:00
Brandon DeRosier
df3230a307 Remove setSampler from FragmentShader (flutter/engine#37839) 2022-11-22 11:26:17 -08:00
Chris Yang
6eb43b7697 iOS PlatformView only sets a maskView when necessary (flutter/engine#37434)
* only clip when necessary

tests

fix tests

format

review

fix

add scenario tset

more scenario tests

add docs and comments

use offset.zero

* remove mistakenly checked-in code
2022-11-18 02:43:50 +00:00
Jason Simmons
0010be93cd Add semantics constants to the exported symbols list for the embedder library (flutter/engine#37526)
Fixes https://github.com/flutter/flutter/issues/114657
2022-11-17 21:50:04 +00:00
Jim Graham
2252b6f362 Reland layer state stack 2 (flutter/engine#37394)
* Revert "Revert "Reland layer state stack" (#37178)"

This reverts commit 21cc000359d8a4da097e8849e83dcbe8ac941e01.

* fix double-transform rendering issues in #114359

* adjust recently added unit test to state_stack APIs

* introduce LSS delegates to simplify some code and reduce overhead

* Fix ShellTest.OnServiceProtocolEstimateRasterCacheMemoryWorks

* add unit test for tracker.setTransform(4x4) and fix bug

* fix culling issue in LayerTree::Flatten
2022-11-17 19:34:19 +00:00
Jim Graham
87e6c95c55 update Scene.toImageSync test to use proper bounds in the request (flutter/engine#37638) 2022-11-15 20:59:18 +00:00
Dan Field
e3f249ab52 Avoid segfault when converting no-op ColorFilter to ImageFilter (flutter/engine#37596) 2022-11-14 22:41:04 +00:00
Christopher Fujino
62dc88c192 extend const_finder to allow skipping particular classes (flutter/engine#37257)
* wip

* extend const_finder_test to compile web dills

* add test

* add back tests, including non-const for web

* update run_tests.py

* fix whitespace

* clean up test file

* add new options to cli

* use annotation rather than explicit deny list

* clean up

* Apply suggestions from code review

Co-authored-by: Zachary Anderson <zanderso@users.noreply.github.com>

* clean up

* code review

Co-authored-by: Zachary Anderson <zanderso@users.noreply.github.com>
2022-11-11 23:38:03 +00:00
Jonah Williams
326f54412c [Impeller] null check samplers (flutter/engine#37489)
* [Impeller] null check sampler and assert in Paint

* ++

* ++

* ++

* ++

* Update fragment_shader_test.dart

* ++

* TESTING

* ++

* TESTING

* ++

* ++

* ++

* ++

* ++

* ++

* ++

* ++

* ++

* ++

* ++

* ++

* remove debugging code

* ++

* ++
2022-11-11 01:27:18 +00:00
Kaushik Iska
5b9e42523e [Reland] Add rects to accumulator rather than bounds (#37435) (flutter/engine#37451)
* [Reland] Add rects to accumulator rather than bounds (#37435)

When the accumulator is an `RTreeBoundsAccumulator` rather than a `RectBoundsAccumulator` just accumulating the bounds results in incorrect results as the `rtree` would need to be aware of the constituent non-overlapping rectangles. This would work fine for `RectBoundsAccumulator` as it would just adjust its bounds based on the passed rects.

Fixes: https://github.com/flutter/flutter/issues/113251

* Add a test for nested display list rtree
2022-11-09 10:57:29 +00:00
Kaushik Iska
2155c6ce00 Revert "Add rects to accumulator rather than bounds (#37435)" (flutter/engine#37444)
This reverts commit 10da0743a513f0ae3ae5afb5a6bd99350b881989.
2022-11-08 18:10:14 -05:00
Kaushik Iska
10da0743a5 Add rects to accumulator rather than bounds (flutter/engine#37435)
When the accumulator is an `RTreeBoundsAccumulator` rather than a `RectBoundsAccumulator` just accumulating the bounds results in incorrect results as the `rtree` would need to be aware of the constituent non-overlapping rectangles. This would work fine for `RectBoundsAccumulator` as it would just adjust its bounds based on the passed rects.

Fixes: https://github.com/flutter/flutter/issues/113251
2022-11-08 19:09:49 +00:00
Erik
fd9e9ccd63 [fuchsia] embedding-flutter test (flutter/engine#37052)
* Add embedding-flutter test

* Lint CC files

* GN formatting

* Remove changes to embedder

* Minor refactor

* Remove unused dependencies

* Lint CC files

* Remove comments

* Rename pubspec
2022-11-07 22:04:58 +00:00
ColdPaleLight
922ebdc160 [Android] Speed up the method 'FlutterRenderer.getBitmap' (flutter/engine#37342) 2022-11-07 17:40:09 +00:00
Jenn Magder
64bef739e9 Fix typo in overlay platform view iOS test (flutter/engine#37262) 2022-11-04 17:33:46 +00:00
Jason Simmons
17bcea458b Enter a scope before calling Dart APIs in ThrowIfUIOperationsProhibited (flutter/engine#37226) 2022-11-03 02:14:38 +00:00
Erik
81605481de [fuchsia] mouse-input test (flutter/engine#37221)
Introduces the `mouse-input` test, a straight port from fuchsia.git
2022-11-02 15:53:22 -04:00
Dan Field
21cc000359 Revert "Reland layer state stack" (flutter/engine#37178) 2022-10-31 18:56:18 +00:00
Jonah Williams
6641536611 use shader utils for JSON test (flutter/engine#37176) 2022-10-31 17:42:58 +00:00
Jim Graham
df85a4f401 Reland layer state stack (flutter/engine#37135) 2022-10-30 18:30:22 +00:00
Jonah Williams
4a72fe9fae [Impeller] add supprt for JSON output mode (flutter/engine#37123) 2022-10-29 16:38:16 +00:00
Chris Yang
b7b95e9372 Reland "PlatformView partial blur #36015" (flutter/engine#37086) 2022-10-28 16:43:14 +00:00
Dan Field
248aca72c6 [Impeller] Set resourceOptions/storageMode on MTLTextures created from MTLBuffers. (flutter/engine#37073) 2022-10-28 06:35:21 +00:00
Jim Graham
8ed073eb54 Revert layer state stack (flutter/engine#37090)
* Revert "Fix a clang-tidy warning in display_list_canvas_unittests.cc (#37062)"

This reverts commit 709c6735fc7ed34df36cee23805bdaa7f6969774.

* Revert "Create a mechanism to manage layer state (#36458)"

This reverts commit 501916deb19a8303ca2a3a9bb37692a873d4679e.
2022-10-27 15:29:58 -07:00
Kaushik Iska
1941c2ca48 [Impeller] Wire Flutter's own VulkanMemoryAllocator implementation (flutter/engine#37018) 2022-10-27 20:57:54 +00:00
Chris Yang
1806c34015 Revert "PlatformView partial blur" (flutter/engine#37085) 2022-10-27 18:15:14 +00:00
Chris Yang
d30087802c PlatformView partial blur (flutter/engine#36015) 2022-10-27 18:02:09 +00:00
Jim Graham
501916deb1 Create a mechanism to manage layer state (flutter/engine#36458) 2022-10-26 21:43:10 +00:00
gaaclarke
cb4c9f4727 Clang-tidy: made verbose print out commands and fixed quoting problem for warnings as errors (flutter/engine#37015) 2022-10-26 08:19:12 +00:00
Kaushik Iska
83489bd574 [Impeller] Add a shard for Impeller Vulkan testing (flutter/engine#36965) 2022-10-25 19:29:44 +00:00
Erik
e4db4408be Add touch-input-test to test_suites.yaml (flutter/engine#36900) 2022-10-20 16:37:56 -04:00
Dan Field
25c9713070 [Impeller] Improvements for SSBO codegen (flutter/engine#36619) 2022-10-14 18:44:15 +00:00
Dan Field
cb5d746c25 [Impeller] Add polyline benchmark with lots of cubics and quads. (flutter/engine#36731) 2022-10-13 18:31:04 +00:00
Jenn Magder
59383d2857 Run iOS Scenario apps with Skia and Impeller (flutter/engine#36652) 2022-10-12 00:16:28 +00:00
Alex Wallen
3cd8b9eaa4 Deprecate single semantics tree assumption from platform dispatcher (flutter/engine#36675) 2022-10-10 18:41:16 +00:00
Erik
9f4d9ff82a Add Dart AOT integration test (flutter/engine#36460) 2022-10-07 22:59:15 +00:00
Jenn Magder
14e991255a Use llvm version of libcxxabi instead of patched mirror (flutter/engine#36634) 2022-10-06 23:08:05 +00:00
Jonah Williams
aadc2d3094 Add ImmutableBuffer.fromFilePath (flutter/engine#36623) 2022-10-05 22:18:03 +00:00
Dan Field
e4d709de85 Avoid using non-UTF-8 encoded argv more often (flutter/engine#36590) 2022-10-05 12:03:20 -07:00