DEV/flutter_flutter
1
0
Fork 0
mirror of https://github.com/flutter/flutter.git synced 2026-02-20 02:29:02 +08:00
Code Issues Packages Projects Releases Wiki Activity
29,646 Commits 882 Branches 1,069 Tags
Commit Graph

29646 Commits

This Branch
This Branch
All Branches
Author SHA1 Message Date
skia-flutter-autoroll
7dbf376307 Roll Dart SDK from ecca5857b3ba to 05d99585adab (4 revisions) (flutter/engine#43113) 
https://dart.googlesource.com/sdk.git/+log/ecca5857b3ba..05d99585adab

2023-06-22 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com Version 3.1.0-243.0.dev
2023-06-22 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com Version 3.1.0-242.0.dev
2023-06-22 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com Version 3.1.0-241.0.dev
2023-06-22 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com Version 3.1.0-240.0.dev

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/dart-sdk-flutter-engine
Please CC dart-vm-team@google.com,jsimmons@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter Engine: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2023-06-22 23:28:31 +00:00
skia-flutter-autoroll
e20c352bf0 Roll Skia from cb44fca83da0 to 5265b5ee1afc (4 revisions) (flutter/engine#43114) 
https://skia.googlesource.com/skia.git/+log/cb44fca83da0..5265b5ee1afc

2023-06-22 kjlubick@google.com Preserve SkNWayCanvas::onFlush
2023-06-22 bsalomon@google.com Fold SkMatrixProvider into SkBaseDevice and remove it.
2023-06-22 weiyuhuang@google.com Add `applyRoundingHack` to `ParagraphStyle`
2023-06-22 brianosman@google.com Remove all usage of SkMatrixProvider outside of SkDevice.

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC brianosman@google.com,fmalita@google.com,jsimmons@google.com,rmistry@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2023-06-22 23:28:29 +00:00
godofredoc
51e1adf23c Add missing android lint to linux_unopt. (flutter/engine#43099) 
The test was not migrated to v2.

Bug: https://github.com/flutter/flutter/issues/127759

[C++, Objective-C, Java style guides]: https://github.com/flutter/engine/blob/main/CONTRIBUTING.md#style
 2023-06-22 22:25:10 +00:00
skia-flutter-autoroll
784eaf4e31 Roll Skia from 273f4cf92b7e to cb44fca83da0 (2 revisions) (flutter/engine#43107) 
https://skia.googlesource.com/skia.git/+log/273f4cf92b7e..cb44fca83da0

2023-06-22 nicolettep@google.com [graphite] Batch of Vulkan fixes for running dm
2023-06-22 jvanverth@google.com [graphite] Add Vulkan Linux bots

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC brianosman@google.com,fmalita@google.com,jsimmons@google.com,rmistry@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2023-06-22 22:20:47 +00:00
utzcoz
23d3ca2e2b [android]: Make Robolectric tests work with SDK 33 (flutter/engine#42965) 
Make Robolectric tests work with SDK 33. The Robolectric doesn't support create presentation window now, so this CL also adds a custom presentation shadow to hook showing state to make related tests work.

[C++, Objective-C, Java style guides]: https://github.com/flutter/engine/blob/main/CONTRIBUTING.md#style
 2023-06-22 20:33:57 +00:00
skia-flutter-autoroll
5a20ffdb0a Roll Skia from 09b36b8ce0db to 273f4cf92b7e (1 revision) (flutter/engine#43106) 
https://skia.googlesource.com/skia.git/+log/09b36b8ce0db..273f4cf92b7e

2023-06-22 michaelludwig@google.com Revert "[skif] Update lighting image filters to use FilterResult"

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC brianosman@google.com,fmalita@google.com,jsimmons@google.com,rmistry@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2023-06-22 20:30:10 +00:00
skia-flutter-autoroll
1477162816 Roll ANGLE from bbcf54bcb738 to 4ed2d403a329 (7 revisions) (flutter/engine#43105) 
bbcf54bcb7..4ed2d403a3

2023-06-22 msisov@igalia.com metal: disable render to texture extension.
2023-06-22 syoussefi@chromium.org Vulkan: Fix email in OWNERS
2023-06-22 geofflang@chromium.org  Metal: Store MSL in shared pointers to immutable strings
2023-06-22 geofflang@chromium.org Include framebuffer completeness reason in draw errors
2023-06-22 geofflang@chromium.org Metal: Don't force all incomplete textures to initialize
2023-06-22 romanl@google.com Add pixels checks to bandingTest on Android +toggle GL_DITHER
2023-06-22 romanl@google.com Only build angle_capture_tests_trace when building traces

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/angle-flutter-engine
Please CC flutter-engine@google.com,jsimmons@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in ANGLE: http://anglebug.com/new
To file a bug in Flutter Engine: https://github.com/flutter/flutter/issues/new

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2023-06-22 20:26:50 +00:00
Lau Ching Jun
574191ed36 Workaround a release blocker after libc++ change (flutter/engine#43091) 
The code breaks in C++20 mode after libc++ removes comparisons for `std::vector` and replaces them with 'operator <=>'.

See cl/542541552 for context.
 2023-06-22 19:33:44 +00:00
skia-flutter-autoroll
bb015ab8c5 Roll Skia from 8168c802c391 to 09b36b8ce0db (1 revision) (flutter/engine#43102) 
https://skia.googlesource.com/skia.git/+log/8168c802c391..09b36b8ce0db

2023-06-22 brianosman@google.com Avoid division by zero in emboss mask filter

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC brianosman@google.com,fmalita@google.com,jsimmons@google.com,rmistry@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2023-06-22 19:21:06 +00:00
Brandon DeRosier
05d4a13865 [Impeller] Reland: Correctly compute UVs in texture fill (flutter/engine#43093) 
Resolves https://github.com/flutter/flutter/issues/128353.
Reverts https://github.com/flutter/engine/pull/43087.

Reland without the kDecal usage -- we don't need it after the last
iteration of fixes.
 2023-06-22 11:38:19 -07:00
Brandon DeRosier
034f5e4edf [Impeller] Add validation forbidding SamplerAddressMode::kDecal on the OpenGLES backend (flutter/engine#43094) 
Fixes uncontrolled crash when kDecal is used (as seen on
https://github.com/flutter/engine/pull/43087).
 2023-06-22 11:35:15 -07:00
Jesse Seales
baef7fd849 Use minor version, ignore patches for CodeQL (flutter/engine#43088) 
The patches of CodeQL updated by dependabot were causing too many engine PRs. This change updates to allow for dependabot to just use minor versions.

*List which issues are fixed by this PR. You must list at least one issue.*
Addresses https://github.com/flutter/flutter/issues/112911

*If you had to change anything in the [flutter/tests] repo, include a link to the migration guide as per the [breaking change policy].*

[C++, Objective-C, Java style guides]: https://github.com/flutter/engine/blob/main/CONTRIBUTING.md#style
 2023-06-22 18:22:49 +00:00
Dan Field
b6fa0a20a5 Print a warning when a message channel is used on the wrong thread. (flutter/engine#42928) 
Fixes https://github.com/flutter/flutter/issues/128746

Prints a warning the first time a platform channel sends a message from the wrong thread with instructions/link to the site about how to fix this.
 2023-06-22 18:16:40 +00:00
skia-flutter-autoroll
97c396add6 Roll Skia from 3f3e1da4b7eb to 8168c802c391 (4 revisions) (flutter/engine#43096) 
https://skia.googlesource.com/skia.git/+log/3f3e1da4b7eb..8168c802c391

2023-06-22 michaelludwig@google.com [skif] Update lighting image filters to use FilterResult
2023-06-22 jacksongardner@google.com Fix assert logic.
2023-06-22 johnstiles@google.com Eliminate remaining vestiges of SkVM.
2023-06-22 johnstiles@google.com Remove SkVM codegen support from SkSL.

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC brianosman@google.com,fmalita@google.com,jsimmons@google.com,rmistry@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2023-06-22 18:08:03 +00:00
Jonah Williams
5c56768c14 [Impeller] default sample count back to 1 (but configure to 4 in defaults). (flutter/engine#43089) 
Also forces the creation of a stencil attachment always on Android to reduce the number of PSO variants.

https://github.com/flutter/flutter/issues/129050
 2023-06-22 17:51:49 +00:00
Mouad Debbar
907fcd3245 [web] Don't get break type from v8BreakIterator (flutter/engine#43053) 
In some languages, when the text contains a new line "\n", the `v8BreakIterator` starts returning different values from `breakType()`. This caused our code to think that those line breaks were hard line breaks when in fact they were soft line breaks. Still unclear if this is a `v8BreakIterator` bug or a wrong expectation on our side regarding how `breakType()` is supposed to work.

Instead of using `v8BreakIterator.breakType()`, let's do the `soft` vs `hard` detection ourselves (we already have all the necessary pieces).

Fixes https://github.com/flutter/flutter/issues/127379
 2023-06-22 17:35:44 +00:00
Alexander Aprelev
6998943fab Roll dart to 3.1.0-239.0.dev (flutter/engine#43083) 
Changes since last roll
```
ecca5857b3b Version 3.1.0-239.0.dev
55e71191833 [CMSR] Add new command to LSP, to convert selected formal parameter(s) to required named.
dd4045e67d2 Version 3.1.0-238.0.dev
6a4f127831d [CMSR] Not available if external executable element.
b8d8da0183c [analyzer] Refactor visitListLiteral to handle Constants.
02b10e1321d Revert "Send DAP events through DDS"
c3f3a00465a [CMSR] More checks for not allowed order of formal parameters.
8e6290bcb0f [vm] Remove unused ObjectStore::completer_class()
67970cc6134 Add failing tests for enum and 'if'.
bf62bc27bcf Adjust the definition of coveringNode to favor identifiers
7bdbc0560ed [vm/win] Use wide-character api for local hostname on Windows.
e4b7d100a1b Bump stream_channel to 34804a13bfa3112faecddfcd6a5a4f2b6e184aa4
752b21ee169 Version 3.1.0-237.0.dev
5292ee88395 Send DAP events through DDS
dfc1b6b16b9 [vm] Store the number of used inputs in SubtypeTestCaches.
24ad7f9000b [vm/tests] Skip vm/cc/TypeArguments_Cache_ManyInstantiations on qemu.
2ca7380ab02 Flow analysis: fix first phase handling of pattern assignments.
3deaeb84dd6 [analyzer] Refactor visitFunctionReference for the const evaluator.
5838562040e [dart2wasm] Add option and target for stringref.
21d45c02685 [dart2wasm] Put string_patch into its own patch
8f6eaeb883e [infra] Pass TEST_COMPILATION_DIR to Android tests
2f27fc5ddfc [dart2wasm] Update dart2wasm script
9a6c33571f0 [vm] Set page_size_ to 0 after deleting the compressed heap.
```
 2023-06-22 17:22:51 +00:00
Jonah Williams
0b17d31261 Revert "[Impeller] dont use concurrent runner to decode images on Android." (flutter/engine#43061) 
Reverts flutter/engine#42944

This didn't improve any of the benchmarks, which I think at least disproves my theory on overloading. Lets go back to the prior strategy and look for improvements elsewhere.
 2023-06-22 17:19:42 +00:00
Jonah Williams
635a109a6d [Impeller] Add fence waiter trace event. (flutter/engine#43092) 
I suspect that some of the worst frame times are caused by submission blocking on adding a fence. Add a trace event that would make that obvious.

![unnamed](https://github.com/flutter/engine/assets/8975114/93650ac8-4451-49d7-b8fa-00fc9f7f4277)
 2023-06-22 17:17:48 +00:00
Jonah Williams
aa890e3d65 [Impeller] remove Vulkan pipeline cache mutex. (flutter/engine#43085) 
At least from what I've found online, this API is already safe to call from multiple threads. From testing, at startup the presence of the mutex is adding ~100ms to shader creation time, as all compilations across N threads are fighting for the same lock.

https://github.com/flutter/flutter/issues/129050
 2023-06-22 16:23:44 +00:00
Zachary Anderson
85aa1a0f7c Revert "[Impeller] Correctly compute UVs in texture fill" (flutter/engine#43087) 
Reverts flutter/engine#43028

An engine roll containing only this commit turned the framework tree red with a crasher on Android. I'm a bit concerned because it looked like one of the benchmarks that crashed should not have been using Impeller see https://github.com/flutter/flutter/pull/129353 and https://ci.chromium.org/ui/p/flutter/builders/prod/Linux_android%20animated_blur_backdrop_filter_perf__timeline_summary/1120/overview
 2023-06-22 15:41:24 +00:00
skia-flutter-autoroll
f62f444425 Roll Fuchsia Linux SDK from 7EZeNE4aGd29VfDly... to tcVndpnH_jzGm5LsJ... (flutter/engine#43081) 
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/fuchsia-linux-sdk-flutter-engine
Please CC jsimmons@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2023-06-22 15:37:50 +00:00
skia-flutter-autoroll
db6192d93c Roll Skia from 117f57a53215 to 3f3e1da4b7eb (4 revisions) (flutter/engine#43080) 
https://skia.googlesource.com/skia.git/+log/117f57a53215..3f3e1da4b7eb

2023-06-22 johnstiles@google.com Remove `transformT` SkVM helpers from gradient code.
2023-06-22 kjlubick@google.com Completely remove graphite #ifdefs from subruncontainer
2023-06-22 kjlubick@google.com Move VertexFiller::boundsAndDeviceMatrix impl to src/graphite
2023-06-22 kjlubick@google.com Move VertexFiller::fillInstanceData to src/graphite

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC brianosman@google.com,fmalita@google.com,jsimmons@google.com,rmistry@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2023-06-22 15:21:57 +00:00
skia-flutter-autoroll
cb17eb5e5f Roll ANGLE from 7658525166a4 to bbcf54bcb738 (1 revision) (flutter/engine#43079) 
7658525166..bbcf54bcb7

2023-06-22 syoussefi@chromium.org Vulkan: Refactor uniform/block binding duplication code

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/angle-flutter-engine
Please CC flutter-engine@google.com,jsimmons@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in ANGLE: http://anglebug.com/new
To file a bug in Flutter Engine: https://github.com/flutter/flutter/issues/new

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2023-06-22 15:05:16 +00:00
skia-flutter-autoroll
fdbdf29c04 Roll Skia from 5013b651f8ec to 117f57a53215 (1 revision) (flutter/engine#43078) 
https://skia.googlesource.com/skia.git/+log/5013b651f8ec..117f57a53215

2023-06-22 herb@google.com Cubic intersections for glyph underlines

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC brianosman@google.com,fmalita@google.com,jsimmons@google.com,rmistry@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2023-06-22 14:10:27 +00:00
skia-flutter-autoroll
c6e0b73134 Roll Fuchsia Mac SDK from QtQznuUmHMTyORqxJ... to Ylc35wOk0_j0NLzDv... (flutter/engine#43076) 
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/fuchsia-mac-sdk-flutter-engine
Please CC jsimmons@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2023-06-22 12:10:24 +00:00
skia-flutter-autoroll
a867ce8c53 Roll ANGLE from a2b3f9b64670 to 7658525166a4 (1 revision) (flutter/engine#43075) 
a2b3f9b646..7658525166

2023-06-22 angle-autoroll@skia-public.iam.gserviceaccount.com Roll vulkan-deps from bcc1118ec796 to 23a32754e715 (6 revisions)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/angle-flutter-engine
Please CC flutter-engine@google.com,jsimmons@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in ANGLE: http://anglebug.com/new
To file a bug in Flutter Engine: https://github.com/flutter/flutter/issues/new

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2023-06-22 11:59:23 +00:00
skia-flutter-autoroll
0f9bfbea61 Roll ANGLE from ac263582dda4 to a2b3f9b64670 (1 revision) (flutter/engine#43074) 
ac263582dd..a2b3f9b646

2023-06-22 angle-autoroll@skia-public.iam.gserviceaccount.com Roll Chromium from 75b049842ff8 to 0b8bd02c6abc (547 revisions)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/angle-flutter-engine
Please CC flutter-engine@google.com,jsimmons@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in ANGLE: http://anglebug.com/new
To file a bug in Flutter Engine: https://github.com/flutter/flutter/issues/new

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2023-06-22 10:09:41 +00:00
skia-flutter-autoroll
84df708771 Roll Skia from 71047dca9f77 to 5013b651f8ec (4 revisions) (flutter/engine#43073) 
https://skia.googlesource.com/skia.git/+log/71047dca9f77..5013b651f8ec

2023-06-22 skia-autoroll@skia-public.iam.gserviceaccount.com Roll ANGLE from 15156b1da43d to ac263582dda4 (7 revisions)
2023-06-22 skia-autoroll@skia-public.iam.gserviceaccount.com Roll SwiftShader from b8f1a3ad5f9e to afd97bf1e914 (1 revision)
2023-06-22 skia-autoroll@skia-public.iam.gserviceaccount.com Roll SK Tool from 7fe8d8d9b147 to 44d5e772a1fb
2023-06-22 skia-autoroll@skia-public.iam.gserviceaccount.com Roll Skia Infra from 3189ad2cb814 to 7fe8d8d9b147 (7 revisions)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC brianosman@google.com,fmalita@google.com,jsimmons@google.com,rmistry@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2023-06-22 09:20:53 +00:00
Brandon DeRosier
f2dfbd9193 [Impeller] Correctly compute UVs in texture fill (flutter/engine#43028) 
Resolves https://github.com/flutter/flutter/issues/128353.

Depends on https://github.com/flutter/engine/pull/43026.

* Maps the texel coordinate space correctly relative to the geometry
pixel coordinates.
* Use decal sampling for subpass textures.
* Simplify the computation by using new rect utilities such as
`Rect::Project`.
 2023-06-22 01:13:37 -07:00
skia-flutter-autoroll
6e0b80e2bb Roll Skia from 076e7c004d20 to 71047dca9f77 (1 revision) (flutter/engine#43071) 
https://skia.googlesource.com/skia.git/+log/076e7c004d20..71047dca9f77

2023-06-22 skia-autoroll@skia-public.iam.gserviceaccount.com Roll Dawn from 0fde633f706b to 58f0978d5039 (11 revisions)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC brianosman@google.com,fmalita@google.com,jsimmons@google.com,rmistry@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2023-06-22 05:51:30 +00:00
Dan Field
a535f5635f [Impeller] Fix up coverage hints for blending/vertices, fix TiledTextureContents::RenderToSnapshot (flutter/engine#43017) 
Fixes https://github.com/flutter/flutter/issues/128329
Fixes https://github.com/flutter/flutter/issues/128807

The panorama example app is still not quite visually on par with skia - the scaling or filtering or something isn't quite as nice as in the skia backend - but it does render now and no longer tries to create gigantical textures.
 2023-06-22 03:20:36 +00:00
Tamir Duberstein
fd56ab9e44 Remove process-local tempfs (flutter/engine#43056) 
This was incorrectly made read-only in 0984c52a8f; instead of implementing it locally, ask the component manager for the directory.
 2023-06-22 02:46:23 +00:00
skia-flutter-autoroll
78e9b58804 Roll Skia from 0185ce148be9 to 076e7c004d20 (2 revisions) (flutter/engine#43069) 
https://skia.googlesource.com/skia.git/+log/0185ce148be9..076e7c004d20

2023-06-22 skia-autoroll@skia-public.iam.gserviceaccount.com Roll vulkan-deps from bcc1118ec796 to 23a32754e715 (6 revisions)
2023-06-22 armansito@google.com [graphite][compute] PathAtlas and ComputePathAtlas classes

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC brianosman@google.com,fmalita@google.com,jsimmons@google.com,rmistry@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2023-06-22 02:26:48 +00:00
skia-flutter-autoroll
caa0802bad Roll Skia from 96d6135e9ee8 to 0185ce148be9 (4 revisions) (flutter/engine#43068) 
https://skia.googlesource.com/skia.git/+log/96d6135e9ee8..0185ce148be9

2023-06-21 armansito@google.com [graphite] Support ClipStack evaluation without side effects
2023-06-21 johnstiles@google.com Remove SkUpdatableColorShader class.
2023-06-21 johnstiles@google.com Remove SkVMBlitter class.
2023-06-21 armansito@google.com [graphite] Fix local coords in Bitmap and SDF text renderers

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC brianosman@google.com,fmalita@google.com,jsimmons@google.com,rmistry@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2023-06-22 01:15:17 +00:00
Brandon DeRosier
0caad561d9 [Impeller] Uniquely label subpasses and root blit (flutter/engine#43015) 
Makes subpasses easier to identify in frame captures.
 2023-06-21 17:18:15 -07:00
Brandon DeRosier
cec295a528 [Impeller] Add Rect::Project (flutter/engine#43026) 
- Utility to project a rectangle onto another rectangle.
- Fix constness for Rect::Expand.
- Add named methods for scaling.
 2023-06-21 17:17:51 -07:00
skia-flutter-autoroll
e2c36cac36 Roll Skia from 32e953e71266 to 96d6135e9ee8 (1 revision) (flutter/engine#43067) 
https://skia.googlesource.com/skia.git/+log/32e953e71266..96d6135e9ee8

2023-06-21 brianosman@google.com SkDraw no longer uses SkMatrixProvider

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC brianosman@google.com,fmalita@google.com,jsimmons@google.com,rmistry@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2023-06-21 23:39:57 +00:00
skia-flutter-autoroll
f937fea79b Roll Fuchsia Mac SDK from ct6r5YjdG2xpZPhkT... to QtQznuUmHMTyORqxJ... (flutter/engine#43065) 
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/fuchsia-mac-sdk-flutter-engine
Please CC jsimmons@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2023-06-21 23:07:52 +00:00
skia-flutter-autoroll
091c429506 Roll Fuchsia Linux SDK from 4mkuVtlGBaumKSe8x... to 7EZeNE4aGd29VfDly... (flutter/engine#43066) 
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/fuchsia-linux-sdk-flutter-engine
Please CC jsimmons@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2023-06-21 23:04:47 +00:00
skia-flutter-autoroll
005f9c9d08 Roll ANGLE from 3a3a3c655a96 to ac263582dda4 (60 revisions) (flutter/engine#43062) 
Roll ANGLE from 3a3a3c655a96 to ac263582dda4 (60 revisions)

3a3a3c655a..ac263582dd

2023-06-21 steven@uplinklabs.net Vulkan: add workaround for VK_EXT_full_screen_exclusive on AMD
2023-06-21 thakis@chromium.org [apple] Fix build with newer libc++
2023-06-21 ynovikov@chromium.org Temporarily remove NVIDIA testing from mac-test
2023-06-21 geofflang@chromium.org Add internal format to TexStorage validation errors
2023-06-21 syoussefi@chromium.org Update OWNERS
2023-06-21 angle-autoroll@skia-public.iam.gserviceaccount.com Roll vulkan-deps from 90577eb35eea to bcc1118ec796 (12 revisions)
2023-06-21 angle-autoroll@skia-public.iam.gserviceaccount.com Roll Chromium from 4c627b09fbd1 to 75b049842ff8 (625 revisions)
2023-06-20 steven@uplinklabs.net Vulkan: disable graphics_pipeline_library on old NVIDIA drivers
2023-06-20 syoussefi@chromium.org Remove unused helper classes
2023-06-20 steven@uplinklabs.net Vulkan: copy drawIndirectFirstInstance from physical device features
2023-06-20 steven@uplinklabs.net optimize glShaderSource string concatenation
2023-06-20 steven@uplinklabs.net Vulkan: detect Apple GPU as being a tile-based renderer
2023-06-20 steven@uplinklabs.net Vulkan: avoid crash on AMD drivers with MSRTT emulation
2023-06-20 steven@uplinklabs.net D3D11: unbreak instanced indirect multidraw with ushort indices
2023-06-20 romanl@google.com Assert !is_official_build in Android builds.
2023-06-20 syoussefi@chromium.org Vulkan: Deduplicate SpvAssignLocations call in program pipeline
2023-06-20 geofflang@chromium.org Metal: Refactor hasValidRenderTarget checks
2023-06-20 amy@amyspark.me GL: fall back to WGL if EGL_ANGLE_surface_orientation unset
2023-06-20 angle-autoroll@skia-public.iam.gserviceaccount.com Roll VK-GL-CTS from 7fcb3c6e0082 to f29bd2feeaff (19 revisions)
2023-06-20 angle-autoroll@skia-public.iam.gserviceaccount.com Roll vulkan-deps from c5656423525b to 90577eb35eea (5 revisions)
2023-06-20 angle-autoroll@skia-public.iam.gserviceaccount.com Roll Chromium from cc7a0bd198ec to 4c627b09fbd1 (415 revisions)
2023-06-20 syoussefi@chromium.org Vulkan: Mark the location of vertex output in the compiler
2023-06-20 syoussefi@chromium.org Vulkan: Mark the location of xfb emulation in the compiler
2023-06-19 syoussefi@chromium.org Vulkan: Mark the beginning of the shader in the compiler
2023-06-19 geofflang@chromium.org Metal: Cache render pipelines at the context level
2023-06-19 syoussefi@chromium.org Fix clearing of extended dirty bits in draw calls
2023-06-19 syoussefi@chromium.org Vulkan: Don't output SPIR-V debug info in release
2023-06-19 syoussefi@chromium.org Vulkan: Use user names directly in SPIR-V
2023-06-19 angle-autoroll@skia-public.iam.gserviceaccount.com Roll vulkan-deps from 58c6e1ea988a to c5656423525b (18 revisions)
2023-06-19 angle-autoroll@skia-public.iam.gserviceaccount.com Roll Chromium from 7df45c601f1c to cc7a0bd198ec (1481 revisions)
2023-06-17 syoussefi@chromium.org Vulkan: Use SPIR-V ids instead of names in the transformer
2023-06-16 syoussefi@chromium.org Vulkan: Refactor framebuffer fetch shader emulation
2023-06-16 mark@lunarg.com Android: Add Pixel 7 entries to End2End expectations
2023-06-16 romanl@google.com Remove _shardN suffix from tests when it's not necessary.
2023-06-16 geofflang@chromium.org Turn CreateMTLRenderPipelineDescriptor into a method
2023-06-16 geofflang@chromium.org Metal: Remove copy constructors in various util classes
2023-06-16 blundell@chromium.org Record duration of syncFromNativeContext()
2023-06-16 angle-autoroll@skia-public.iam.gserviceaccount.com Roll VK-GL-CTS from f7646f53ba61 to 7fcb3c6e0082 (1 revision)
2023-06-16 angle-autoroll@skia-public.iam.gserviceaccount.com Roll vulkan-deps from cebf5626ca50 to 58c6e1ea988a (14 revisions)
2023-06-16 amy@amyspark.me Validate GL backend after dispatch table initialization
2023-06-15 romanl@google.com Capture/Replay: Initial setup for angle_capture_tests
2023-06-15 i.nazarov@samsung.com Add isContextMutexStateConsistent() ASSERT
2023-06-15 romanl@google.com Make Test spec JSON generator hashless.
2023-06-15 geofflang@chromium.org Metal: Set alphaToCoverageEnabled in checkIfPipelineChanged
2023-06-15 fangzhoug@chromium.org Mali: Make the placeholder FBO complete for timer queries
2023-06-15 ynovikov@chromium.org Add ANGLE experimental SwiftShader builders
...
 2023-06-21 22:37:22 +00:00
skia-flutter-autoroll
82bafb3517 Roll Skia from 7eeb94b1e778 to 32e953e71266 (17 revisions) (flutter/engine#43064) 
https://skia.googlesource.com/skia.git/+log/7eeb94b1e778..32e953e71266

2023-06-21 johnstiles@google.com Remove class SkFilterColorProgram.
2023-06-21 brianosman@google.com Use MatrixRec in legacy shader context code
2023-06-21 johnstiles@google.com Delete SkVM program()/onProgram() callbacks.
2023-06-21 johnstiles@google.com Turn off mechanisms which can enable SkVM.
2023-06-21 kjlubick@google.com Remove SkCanvas::flush() from Skia-proper and remove other gpu-specific code
2023-06-21 brianosman@google.com SkShaderBase::ContextRec only needs paint alpha
2023-06-21 skia-autoroll@skia-public.iam.gserviceaccount.com Manual roll Dawn from ba42f5db9450 to 0fde633f706b (6 revisions)
2023-06-21 nicolettep@google.com [graphite] Move SkSL and shader module logic from Vulkan resource provider to graphics pipeline
2023-06-21 kjlubick@google.com Break SkTestCanvas.cpp off into own file list to put only in GPU builds
2023-06-21 herb@google.com Change SubRunType to SubRunStreamTag
2023-06-21 jvanverth@google.com [graphite] Add Vulkan Windows Debug test job
2023-06-21 herb@google.com Reland "De-SkScalar SkRect"
2023-06-21 johnstiles@google.com Remove SkVM JIT.
2023-06-21 robertphillips@google.com Fix tasks.json
2023-06-21 sharaks@google.com Update Skia milestone to 117
2023-06-21 robertphillips@google.com [graphite] Move tiled rendering helper function to TiledTextureUtils
2023-06-21 sharaks@google.com Merge 15 release notes into RELEASE_NOTES.md

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC brianosman@google.com,fmalita@google.com,jsimmons@google.com,rmistry@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2023-06-21 22:34:18 +00:00
Márk Tolmács
f41c1644d8 Enabling pre-push checks on Windows (flutter/engine#36123) 
Re-submit the changes to enable windows pre-push checks.

This patch changes how `ci/bin/format.dart` generate diffs from `diff` and `patch` commands to `git diff` and `git apply` in order to have a common method for these operations on all platforms. Windows installations don't have diff and patch commands available by default and many implementations which provide such commands work differently than the UN*X tools. Git however works consistently across all platforms.

Additionally, this patch also changes the python executable in some of the pre-push components affected by this to `vpython3` to continue the effort started at flutter/flutter#108474 and I also removed the `--no-sound-null-safety` parameter in the ci/format.sh, ci/format.bat files

NOTE: Since the original patch caused some issues, I suggest that this should be tested more carefully before it is merged.

### Issues fixed by this PR
* flutter/flutter#108122
* flutter/flutter#107920
* flutter/flutter#86506
* flutter/flutter#106615

### [flutter/tests] repo impact
None.

writing and running engine tests.

[C++, Objective-C, Java style guides]: https://github.com/flutter/engine/blob/main/CONTRIBUTING.md#style
 2023-06-21 17:20:06 +00:00
godofredoc
f039068b13 Document the use of contexts on engine_v2 tests. (flutter/engine#43013) 
Contexts are predefined python contexts that can be dynamically added to the test execution.

Bug: https://github.com/flutter/flutter/issues/129187

[C++, Objective-C, Java style guides]: https://github.com/flutter/engine/blob/main/CONTRIBUTING.md#style
 2023-06-21 16:43:33 +00:00
godofredoc
853bdd7bd7 Generate treemap. (flutter/engine#43029) 
Engine V2 was not generating the size treemap. This change will start uploading the size treemap to the test logs.

Bug: https://github.com/flutter/flutter/issues/128482

[C++, Objective-C, Java style guides]: https://github.com/flutter/engine/blob/main/CONTRIBUTING.md#style
 2023-06-21 16:28:09 +00:00
skia-flutter-autoroll
c1b1c6cdfe Roll Skia from c983b97d03a8 to 7eeb94b1e778 (4 revisions) (flutter/engine#43045) 
https://skia.googlesource.com/skia.git/+log/c983b97d03a8..7eeb94b1e778

2023-06-21 kjlubick@google.com Add filegroups to support G3 builds
2023-06-21 fmalita@chromium.org Manual Roll Dawn from 0d5e76a2427f to ba42f5db9450 (19 revisions)
2023-06-21 herb@google.com Only inline midpoint
2023-06-21 robertphillips@google.com [graphite] Update some GMs to use Graphite ContextOptions overrides

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC brianosman@google.com,fmalita@google.com,jsimmons@google.com,rmistry@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2023-06-21 16:01:13 +00:00
godofredoc
1567bc1600 Move android emulator tests to v2. (flutter/engine#43008) 
These tests have been running on staging successfully for a few days.

Bug: https://github.com/flutter/flutter/issues/127680

[C++, Objective-C, Java style guides]: https://github.com/flutter/engine/blob/main/CONTRIBUTING.md#style
 2023-06-21 15:26:00 +00:00
skia-flutter-autoroll
69577428b6 Roll Skia from 65f30e5804c7 to c983b97d03a8 (2 revisions) (flutter/engine#43044) 
https://skia.googlesource.com/skia.git/+log/65f30e5804c7..c983b97d03a8

2023-06-21 robertphillips@google.com [graphite] Add ContextOptions override for Graphite (in dm)
2023-06-21 robertphillips@google.com Move the Ganesh version of DrawTiledBitmap to its own file (and rename)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC brianosman@google.com,fmalita@google.com,jsimmons@google.com,rmistry@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2023-06-21 14:50:22 +00:00
skia-flutter-autoroll
e6ce69365e Roll Skia from 7121db7c6dc2 to 65f30e5804c7 (3 revisions) (flutter/engine#43043) 
https://skia.googlesource.com/skia.git/+log/7121db7c6dc2..65f30e5804c7

2023-06-21 kjlubick@google.com Remove SkTestCanvas from public.bzl
2023-06-21 skia-autoroll@skia-public.iam.gserviceaccount.com Roll vulkan-deps from f0fc1de57d41 to bcc1118ec796 (7 revisions)
2023-06-21 kjlubick@google.com Add decoder #includes to implementation files

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC brianosman@google.com,fmalita@google.com,jsimmons@google.com,rmistry@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2023-06-21 13:44:29 +00:00
skia-flutter-autoroll
a25df7879e Roll Dart SDK from 178d3d1184cb to 88fa9330633e (1 revision) (flutter/engine#43041) 
https://dart.googlesource.com/sdk.git/+log/178d3d1184cb..88fa9330633e

2023-06-21 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com Version 3.1.0-236.0.dev

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/dart-sdk-flutter-engine
Please CC dart-vm-team@google.com,jsimmons@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter Engine: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2023-06-21 12:08:22 +00:00