DEV/flutter_flutter
1
0
Fork 0
mirror of https://github.com/flutter/flutter.git synced 2026-02-20 02:29:02 +08:00
Code Issues Packages Projects Releases Wiki Activity
83,776 Commits 882 Branches 1,069 Tags
Commit Graph

30289 Commits

Author SHA1 Message Date
Yegor
7ca63fadd7
[web] close input connection when window/iframe loses focus (#166804) 
Fixes https://github.com/flutter/flutter/issues/155265

This includes 2 fixes:

* When the window/iframe loses focus, close the text input connection
instead of grabbing the focus again.
* Do not enable semantics using the placeholder when moving focus using
the "Tab" key.

Bonus: remove the no longer necessary `ViewFocusBinding.isEnabled`
(doesn't fix any issues, just a clean-up).

---------

Co-authored-by: Mouad Debbar <mdebbar@google.com>
 2025-04-18 17:43:36 +00:00
engine-flutter-autoroll
810024f3c9
Roll Dart SDK from b1eb743f97f5 to ab60afc99bcb (1 revision) (#167396) 
https://dart.googlesource.com/sdk.git/+log/b1eb743f97f5..ab60afc99bcb

2025-04-18 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com
Version 3.9.0-31.0.dev

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/dart-sdk-flutter
Please CC codefu@google.com,dart-vm-team@google.com on the revert to
ensure that a human
is aware of the problem.

To file a bug in Flutter:
https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2025-04-18 09:41:26 +00:00
engine-flutter-autoroll
b29d7bc42a
Roll Skia from a409d685a711 to acc910544da7 (10 revisions) (#167388) 
https://skia.googlesource.com/skia.git/+log/a409d685a711..acc910544da7

2025-04-18 skia-autoroll@skia-public.iam.gserviceaccount.com Manual roll
Dawn from 33862a3ffc8a to 971cc7345000 (191 revisions)
2025-04-17 skia-autoroll@skia-public.iam.gserviceaccount.com Roll
vulkan-deps from f6ce0375d108 to da64cc98aa1f (7 revisions)
2025-04-17 robertphillips@google.com Fix ChromePrecompileTest for Intel
Macs
2025-04-17 borenet@google.com [infra] Add P30 jobs
2025-04-17 skia-autoroll@skia-public.iam.gserviceaccount.com Roll
skottie-base from 868103199143 to f4a4eee934a3
2025-04-17 skia-autoroll@skia-public.iam.gserviceaccount.com Roll
shaders-base from 64b9cec3c82d to 11837b5a53d7
2025-04-17 skia-autoroll@skia-public.iam.gserviceaccount.com Roll
jsfiddle-base from 05716f858285 to 05b60ca904d9
2025-04-17 skia-autoroll@skia-public.iam.gserviceaccount.com Roll
debugger-app-base from 9e80d6bc5f11 to f59c59370426
2025-04-17 nicolettep@google.com [graphite] Run precompile tests when
making changes to relevant files
2025-04-17 jvanverth@google.com [graphite] Use sk_sp<TextureProxy> for
PathAtlas instead of raw pointer.

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC bwils@google.com,codefu@google.com,kjlubick@google.com on the
revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter:
https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2025-04-18 05:02:08 +00:00
engine-flutter-autoroll
40f25c9b19
Roll Dart SDK from 2bb85834e77e to b1eb743f97f5 (2 revisions) (#167387) 
https://dart.googlesource.com/sdk.git/+log/2bb85834e77e..b1eb743f97f5

2025-04-18 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com
Version 3.9.0-30.0.dev
2025-04-17 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com
Version 3.9.0-29.0.dev

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/dart-sdk-flutter
Please CC codefu@google.com,dart-vm-team@google.com on the revert to
ensure that a human
is aware of the problem.

To file a bug in Flutter:
https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2025-04-18 04:32:31 +00:00
engine-flutter-autoroll
1db4930a43
Roll Fuchsia Linux SDK from m8Aln7fTF_8zy1V9N... to MwYckh5OvwwmIYLx0... (#167385) 
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/fuchsia-linux-sdk-flutter
Please CC codefu@google.com,zra@google.com on the revert to ensure that
a human
is aware of the problem.

To file a bug in Flutter:
https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2025-04-18 02:06:36 +00:00
engine-flutter-autoroll
99c3d03758
Roll Skia from cc2b57434651 to a409d685a711 (3 revisions) (#167347) 
https://skia.googlesource.com/skia.git/+log/cc2b57434651..a409d685a711

2025-04-17 michaelludwig@google.com Revert "[graphite] Update DrawWriter
to minimize binds by using pending base offsets."
2025-04-17 jvanverth@google.com [graphite] Use sk_sp<TextureProxy> for
ClipAtlas instead of raw pointer.
2025-04-17 skia-autoroll@skia-public.iam.gserviceaccount.com Roll
vulkan-deps from 3bc11f8f2d55 to f6ce0375d108 (4 revisions)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC bwils@google.com,codefu@google.com,kjlubick@google.com on the
revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter:
https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2025-04-17 21:43:48 +00:00
Jason Simmons
c53fdbdf24
Reduce app startup latency by initializing the engine on a separate thread (#166918) 
If settings.merged_platform_ui_thread is set to kMergeAfterLaunch, then
the engine will be started on the UI thread. After engine setup
completes and the Dart isolate is loaded, the UI task runner will be
merged into the platform thread and all future Dart execution will run
on the platform thread.

This makes it possible for other work to run on the platform thread
while the engine starts.

See https://github.com/flutter/flutter/issues/163064
 2025-04-17 21:40:08 +00:00
engine-flutter-autoroll
9f4fe843a7
Roll Dart SDK from 992221a362ec to 2bb85834e77e (7 revisions) (#167361) 
https://dart.googlesource.com/sdk.git/+log/992221a362ec..2bb85834e77e

2025-04-17 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com
Version 3.9.0-28.0.dev
2025-04-17 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com
Version 3.9.0-27.0.dev
2025-04-17 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com
Version 3.9.0-26.0.dev
2025-04-16 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com
Version 3.9.0-25.0.dev
2025-04-16 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com
Version 3.9.0-24.0.dev
2025-04-16 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com
Version 3.9.0-23.0.dev
2025-04-16 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com
Version 3.9.0-22.0.dev

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/dart-sdk-flutter
Please CC codefu@google.com,dart-vm-team@google.com on the revert to
ensure that a human
is aware of the problem.

To file a bug in Flutter:
https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2025-04-17 21:38:52 +00:00
gaaclarke
ffa1891ab8
Added docstring for FilterInput::GetSnapshot (#167226) 
fixes https://github.com/flutter/flutter/issues/137970

## Pre-launch Checklist

- [x] I read the [Contributor Guide] and followed the process outlined
there for submitting PRs.
- [x] I read the [Tree Hygiene] wiki page, which explains my
responsibilities.
- [x] I read and followed the [Flutter Style Guide], including [Features
we expect every widget to implement].
- [x] I signed the [CLA].
- [x] I listed at least one issue that this PR fixes in the description
above.
- [x] I updated/added relevant documentation (doc comments with `///`).
- [x] I added new tests to check the change I am making, or this PR is
[test-exempt].
- [x] I followed the [breaking change policy] and added [Data Driven
Fixes] where supported.
- [x] All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel
on [Discord].

<!-- Links -->
[Contributor Guide]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#overview
[Tree Hygiene]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md
[test-exempt]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#tests
[Flutter Style Guide]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md
[Features we expect every widget to implement]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md#features-we-expect-every-widget-to-implement
[CLA]: https://cla.developers.google.com/
[flutter/tests]: https://github.com/flutter/tests
[breaking change policy]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#handling-breaking-changes
[Discord]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Chat.md
[Data Driven Fixes]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Data-driven-Fixes.md
 2025-04-17 21:38:52 +00:00
gaaclarke
df5dfdba61
adds Entity docstrings (#167228) 
fixes https://github.com/flutter/flutter/issues/144943

## Pre-launch Checklist

- [x] I read the [Contributor Guide] and followed the process outlined
there for submitting PRs.
- [x] I read the [Tree Hygiene] wiki page, which explains my
responsibilities.
- [x] I read and followed the [Flutter Style Guide], including [Features
we expect every widget to implement].
- [x] I signed the [CLA].
- [x] I listed at least one issue that this PR fixes in the description
above.
- [x] I updated/added relevant documentation (doc comments with `///`).
- [x] I added new tests to check the change I am making, or this PR is
[test-exempt].
- [x] I followed the [breaking change policy] and added [Data Driven
Fixes] where supported.
- [x] All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel
on [Discord].

<!-- Links -->
[Contributor Guide]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#overview
[Tree Hygiene]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md
[test-exempt]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#tests
[Flutter Style Guide]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md
[Features we expect every widget to implement]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md#features-we-expect-every-widget-to-implement
[CLA]: https://cla.developers.google.com/
[flutter/tests]: https://github.com/flutter/tests
[breaking change policy]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#handling-breaking-changes
[Discord]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Chat.md
[Data Driven Fixes]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Data-driven-Fixes.md
 2025-04-17 21:38:52 +00:00
gaaclarke
a23e4ca194
fixed impeller golden content scale (#167308) 
fixes https://github.com/flutter/flutter/issues/162036

This fixes the problem my scaling the render texture by the content
scalar. This means locally you'll probably be generating 2048x1536
images. This matches the rendering that is happening in playgrounds. On
CI the content scalar should be one so there is no change there.

## Pre-launch Checklist

- [x] I read the [Contributor Guide] and followed the process outlined
there for submitting PRs.
- [x] I read the [Tree Hygiene] wiki page, which explains my
responsibilities.
- [x] I read and followed the [Flutter Style Guide], including [Features
we expect every widget to implement].
- [x] I signed the [CLA].
- [x] I listed at least one issue that this PR fixes in the description
above.
- [x] I updated/added relevant documentation (doc comments with `///`).
- [x] I added new tests to check the change I am making, or this PR is
[test-exempt].
- [x] I followed the [breaking change policy] and added [Data Driven
Fixes] where supported.
- [x] All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel
on [Discord].

<!-- Links -->
[Contributor Guide]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#overview
[Tree Hygiene]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md
[test-exempt]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#tests
[Flutter Style Guide]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md
[Features we expect every widget to implement]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md#features-we-expect-every-widget-to-implement
[CLA]: https://cla.developers.google.com/
[flutter/tests]: https://github.com/flutter/tests
[breaking change policy]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#handling-breaking-changes
[Discord]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Chat.md
[Data Driven Fixes]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Data-driven-Fixes.md
 2025-04-17 21:37:00 +00:00
gaaclarke
0e4bebffa1
Added docstring for FilterContents::RenderFilter (#167227) 
fixes https://github.com/flutter/flutter/issues/137704

## Pre-launch Checklist

- [x] I read the [Contributor Guide] and followed the process outlined
there for submitting PRs.
- [x] I read the [Tree Hygiene] wiki page, which explains my
responsibilities.
- [x] I read and followed the [Flutter Style Guide], including [Features
we expect every widget to implement].
- [x] I signed the [CLA].
- [x] I listed at least one issue that this PR fixes in the description
above.
- [x] I updated/added relevant documentation (doc comments with `///`).
- [x] I added new tests to check the change I am making, or this PR is
[test-exempt].
- [x] I followed the [breaking change policy] and added [Data Driven
Fixes] where supported.
- [x] All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel
on [Discord].

<!-- Links -->
[Contributor Guide]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#overview
[Tree Hygiene]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md
[test-exempt]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#tests
[Flutter Style Guide]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md
[Features we expect every widget to implement]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md#features-we-expect-every-widget-to-implement
[CLA]: https://cla.developers.google.com/
[flutter/tests]: https://github.com/flutter/tests
[breaking change policy]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#handling-breaking-changes
[Discord]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Chat.md
[Data Driven Fixes]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Data-driven-Fixes.md
 2025-04-17 21:35:41 +00:00
Matej Knopp
9d3d0dc0ed
[macOS] Enable merged platform and UI thread by default (#166536) 
This enables running UI isolate on platform thread by default.

## Pre-launch Checklist

- [x] I read the [Contributor Guide] and followed the process outlined
there for submitting PRs.
- [x] I read the [Tree Hygiene] wiki page, which explains my
responsibilities.
- [x] I read and followed the [Flutter Style Guide], including [Features
we expect every widget to implement].
- [x] I signed the [CLA].
- [x] I listed at least one issue that this PR fixes in the description
above.
- [x] I updated/added relevant documentation (doc comments with `///`).
- [x] I added new tests to check the change I am making, or this PR is
[test-exempt].
- [x] I followed the [breaking change policy] and added [Data Driven
Fixes] where supported.
- [x] All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel
on [Discord].

<!-- Links -->
[Contributor Guide]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#overview
[Tree Hygiene]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md
[test-exempt]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#tests
[Flutter Style Guide]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md
[Features we expect every widget to implement]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md#features-we-expect-every-widget-to-implement
[CLA]: https://cla.developers.google.com/
[flutter/tests]: https://github.com/flutter/tests
[breaking change policy]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#handling-breaking-changes
[Discord]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Chat.md
[Data Driven Fixes]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Data-driven-Fixes.md
 2025-04-17 15:30:40 +00:00
Matej Knopp
afdc861129
[Windows] Enable merged platform and UI thread by default (#163726) 
This enables running UI isolate on platform thread by default. 

## Pre-launch Checklist

- [x] I read the [Contributor Guide] and followed the process outlined
there for submitting PRs.
- [x] I read the [Tree Hygiene] wiki page, which explains my
responsibilities.
- [x] I read and followed the [Flutter Style Guide], including [Features
we expect every widget to implement].
- [x] I signed the [CLA].
- [x] I listed at least one issue that this PR fixes in the description
above.
- [x] I updated/added relevant documentation (doc comments with `///`).
- [x] I added new tests to check the change I am making, or this PR is
[test-exempt].
- [x] I followed the [breaking change policy] and added [Data Driven
Fixes] where supported.
- [x] All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel
on [Discord].

<!-- Links -->
[Contributor Guide]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#overview
[Tree Hygiene]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md
[test-exempt]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#tests
[Flutter Style Guide]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md
[Features we expect every widget to implement]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md#features-we-expect-every-widget-to-implement
[CLA]: https://cla.developers.google.com/
[flutter/tests]: https://github.com/flutter/tests
[breaking change policy]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#handling-breaking-changes
[Discord]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Chat.md
[Data Driven Fixes]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Data-driven-Fixes.md

---------

Co-authored-by: Loïc Sharma <737941+loic-sharma@users.noreply.github.com>
 2025-04-17 15:30:29 +00:00
Victoria Ashworth
ecabb1a052
Hide error on mDNS registration failure and print warning in flutter attach (#166782) 
Publishing an mDNS service stopped working on macOS 15.4 for the iOS
Simulator. `DNSServiceRegister` always returns a callback with error
code `kDNSServiceErr_PolicyDenied`, as if the user had rejected the
permissions popup (except no popup is ever shown). mDNS is used to
discover the Dart VM when running `flutter attach`.

This PR does not display the error message when `DNSServiceRegister`
fails for iOS Simulators. Instead, it prints a warning if `flutter
attach` takes too long with instructions to either use `--debug-url` or
to run `flutter attach` before running the app.

If `DNSServiceRegister` works again in a future macOS update, mDNS will
continue to work the way it did previously.

Workaround for https://github.com/flutter/flutter/issues/166333.

## Pre-launch Checklist

- [x] I read the [Contributor Guide] and followed the process outlined
there for submitting PRs.
- [x] I read the [Tree Hygiene] wiki page, which explains my
responsibilities.
- [x] I read and followed the [Flutter Style Guide], including [Features
we expect every widget to implement].
- [x] I signed the [CLA].
- [x] I listed at least one issue that this PR fixes in the description
above.
- [x] I updated/added relevant documentation (doc comments with `///`).
- [x] I added new tests to check the change I am making, or this PR is
[test-exempt].
- [x] I followed the [breaking change policy] and added [Data Driven
Fixes] where supported.
- [x] All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel
on [Discord].

<!-- Links -->
[Contributor Guide]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#overview
[Tree Hygiene]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md
[test-exempt]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#tests
[Flutter Style Guide]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md
[Features we expect every widget to implement]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md#features-we-expect-every-widget-to-implement
[CLA]: https://cla.developers.google.com/
[flutter/tests]: https://github.com/flutter/tests
[breaking change policy]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#handling-breaking-changes
[Discord]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Chat.md
[Data Driven Fixes]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Data-driven-Fixes.md
 2025-04-17 14:20:23 +00:00
Bruno Leroux
fbed8a7194
Add support for language hints in TextFields (Android only) (#165554) 
## Description

This PR adds support for language hints in TextFields.
This is supported only on Android for the moment and the property name,
aka `TextField.hintLocales`, is based on Android's
`EditorInfo.hintLocales` property, see
https://developer.android.com/reference/android/view/inputmethod/EditorInfo#hintLocales.

## Related Issue

Fixes [Support for language hints in
TextFields](https://github.com/flutter/flutter/issues/163698)

## Tests

Adds 4 tests.
Updates several tests.
 2025-04-17 10:58:38 +00:00
engine-flutter-autoroll
af2e73343a
Roll Skia from 3d6165b70199 to d8f13372549d (14 revisions) (#167325) 
https://skia.googlesource.com/skia.git/+log/3d6165b70199..d8f13372549d

2025-04-16 robertphillips@google.com Revise ChromePrecompileTest
2025-04-16 bungeman@google.com [freetype] Check palette actually found
2025-04-16 skia-autoroll@skia-public.iam.gserviceaccount.com Roll
vulkan-deps from 729a70498186 to 3bc11f8f2d55 (2 revisions)
2025-04-16 vigneshv@google.com SkCrabbyAvifCodec: Use icc profile from
the decoded image
2025-04-16 thomsmit@google.com [graphite] Update DrawWriter to minimize
binds by using pending base offsets.
2025-04-16 faijur.rahman@imagination.corp-partner.google.com img-ddk:
Fix Driver Version Deduction for Unknown ANGLE Backend
2025-04-16 kjlubick@google.com Enforce IWYU on some graphite types
2025-04-16 coldpalelight@gmail.com Fix issue where drawArc loses endcaps
when stroke width is greater than or equal to oval size
2025-04-16 nicolettep@google.com [graphite] Add test to prove Vulkan
shares renderpasses when expected
2025-04-16 kjlubick@google.com Add thread-safe version of
SkResourceCache
2025-04-16 jvanverth@google.com Reland "[graphite] Add ProxyCache
support to RasterPathAtlas."
2025-04-16 jlavrova@google.com Small fix in Unicode CodeUnits API
2025-04-16 skia-autoroll@skia-public.iam.gserviceaccount.com Roll ANGLE
from a3f2545f6bb3 to ca0457f68880 (12 revisions)
2025-04-16 jeongik@google.com Support GL texture for BGRA8 format

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC bwils@google.com,codefu@google.com,kjlubick@google.com on the
revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter:
https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2025-04-17 04:44:05 +00:00
engine-flutter-autoroll
83b2f7f57c
Manual roll Dart SDK from 87965ab4864e to 992221a362ec (35 revisions) (#167243) 
Manual roll Dart SDK from 87965ab4864e to 992221a362ec (35 revisions)

Manual roll requested by codefu@google.com

https://dart.googlesource.com/sdk.git/+log/87965ab4864e..992221a362ec

2025-04-15 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com
Version 3.9.0-21.0.dev
2025-04-15 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com
Version 3.9.0-20.0.dev
2025-04-15 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com
Version 3.9.0-19.0.dev
2025-04-15 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com
Version 3.9.0-18.0.dev
2025-04-15 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com
Version 3.9.0-17.0.dev
2025-04-14 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com
Version 3.9.0-16.0.dev
2025-04-14 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com
Version 3.9.0-15.0.dev
2025-04-12 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com
Version 3.9.0-14.0.dev
2025-04-12 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com
Version 3.9.0-13.0.dev
2025-04-11 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com
Version 3.9.0-12.0.dev
2025-04-11 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com
Version 3.9.0-11.0.dev
2025-04-11 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com
Version 3.9.0-10.0.dev
2025-04-11 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com
Version 3.9.0-9.0.dev
2025-04-11 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com
Version 3.9.0-8.0.dev
2025-04-11 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com
Version 3.9.0-7.0.dev
2025-04-10 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com
Version 3.9.0-6.0.dev
2025-04-10 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com
Version 3.9.0-5.0.dev
2025-04-10 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com
Version 3.9.0-4.0.dev
2025-04-10 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com
Version 3.9.0-3.0.dev
2025-04-09 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com
Version 3.9.0-2.0.dev
2025-04-09 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com
Version 3.9.0-1.0.dev
2025-04-09 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com
Version 3.9.0-0.0.dev
2025-04-08 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com
Version 3.8.0-278.0.dev
2025-04-07 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com
Version 3.8.0-277.0.dev
2025-04-07 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com
Version 3.8.0-276.0.dev
2025-04-07 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com
Version 3.8.0-275.0.dev
2025-04-07 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com
Version 3.8.0-274.0.dev
2025-04-07 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com
Version 3.8.0-273.0.dev
2025-04-06 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com
Version 3.8.0-272.0.dev
2025-04-05 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com
Version 3.8.0-271.0.dev
2025-04-05 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com
Version 3.8.0-270.0.dev
2025-04-04 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com
Version 3.8.0-269.0.dev
2025-04-04 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com
Version 3.8.0-268.0.dev
2025-04-04 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com
Version 3.8.0-267.0.dev
2025-04-04 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com
Version 3.8.0-266.0.dev

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/dart-sdk-flutter
Please CC codefu@google.com,dart-vm-team@google.com on the revert to
ensure that a human
is aware of the problem.

To file a bug in Flutter:
https://github.com/flutter/flutter/issues/new/choose

...

Co-authored-by: Siva <a-siva@users.noreply.github.com>
 2025-04-17 00:31:14 +00:00
engine-flutter-autoroll
b747aeeb1f
Roll Fuchsia Linux SDK from 7bWzHwIPBTyU6R9nO... to m8Aln7fTF_8zy1V9N... (#167312) 
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/fuchsia-linux-sdk-flutter
Please CC codefu@google.com,zra@google.com on the revert to ensure that
a human
is aware of the problem.

To file a bug in Flutter:
https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2025-04-16 23:57:14 +00:00
gaaclarke
3f0ff18e76
Updated docstrings for TextureContents (#167221) 
fixes https://github.com/flutter/flutter/issues/139527

## Pre-launch Checklist

- [x] I read the [Contributor Guide] and followed the process outlined
there for submitting PRs.
- [x] I read the [Tree Hygiene] wiki page, which explains my
responsibilities.
- [x] I read and followed the [Flutter Style Guide], including [Features
we expect every widget to implement].
- [x] I signed the [CLA].
- [x] I listed at least one issue that this PR fixes in the description
above.
- [x] I updated/added relevant documentation (doc comments with `///`).
- [x] I added new tests to check the change I am making, or this PR is
[test-exempt].
- [x] I followed the [breaking change policy] and added [Data Driven
Fixes] where supported.
- [x] All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel
on [Discord].

<!-- Links -->
[Contributor Guide]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#overview
[Tree Hygiene]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md
[test-exempt]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#tests
[Flutter Style Guide]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md
[Features we expect every widget to implement]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md#features-we-expect-every-widget-to-implement
[CLA]: https://cla.developers.google.com/
[flutter/tests]: https://github.com/flutter/tests
[breaking change policy]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#handling-breaking-changes
[Discord]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Chat.md
[Data Driven Fixes]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Data-driven-Fixes.md
 2025-04-16 21:55:43 +00:00
gaaclarke
90b37bf053
Broke cyclical dependency with dlpath and typographer. (#167293) 
fixes https://github.com/flutter/flutter/issues/166593

## Pre-launch Checklist

- [x] I read the [Contributor Guide] and followed the process outlined
there for submitting PRs.
- [x] I read the [Tree Hygiene] wiki page, which explains my
responsibilities.
- [x] I read and followed the [Flutter Style Guide], including [Features
we expect every widget to implement].
- [x] I signed the [CLA].
- [x] I listed at least one issue that this PR fixes in the description
above.
- [x] I updated/added relevant documentation (doc comments with `///`).
- [x] I added new tests to check the change I am making, or this PR is
[test-exempt].
- [x] I followed the [breaking change policy] and added [Data Driven
Fixes] where supported.
- [x] All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel
on [Discord].

<!-- Links -->
[Contributor Guide]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#overview
[Tree Hygiene]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md
[test-exempt]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#tests
[Flutter Style Guide]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md
[Features we expect every widget to implement]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md#features-we-expect-every-widget-to-implement
[CLA]: https://cla.developers.google.com/
[flutter/tests]: https://github.com/flutter/tests
[breaking change policy]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#handling-breaking-changes
[Discord]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Chat.md
[Data Driven Fixes]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Data-driven-Fixes.md
 2025-04-16 20:12:32 +00:00
Jason Simmons
c866944682
Revert "Removed superfluous copy in license checker (#167146)" (#167246) 
This reverts commit b4dc23333c286bd6fb9b1aaeea63a933a2d62733.

The license script provides a RegExp wrapper that tracks the cost of the
script's regexes. Dart's RegExp.allMatches returns an Iterable whose
iterators lazily execute the regex. Calling toList will execute the
regex on the entire input within allMatches, allowing measurement of the
regex's cost. Returning the Iterable will instead shift the execution
cost to the caller.

Also, in local measurements I'm seeing significantly better performance
from finding all of the matches immediately with toList versus having
the caller use the lazy iterator.
 2025-04-16 19:13:46 +00:00
Tong Mu
aef4718b39
[Web] Remove webOnlyUniformRadii from RRect (#167237) 
This variable was added in https://github.com/flutter/engine/pull/15970
(for the HTML renderer I guess?) and is apparently no long used
anywhere.

## Pre-launch Checklist

- [ ] I read the [Contributor Guide] and followed the process outlined
there for submitting PRs.
- [ ] I read the [Tree Hygiene] wiki page, which explains my
responsibilities.
- [ ] I read and followed the [Flutter Style Guide], including [Features
we expect every widget to implement].
- [ ] I signed the [CLA].
- [ ] I listed at least one issue that this PR fixes in the description
above.
- [ ] I updated/added relevant documentation (doc comments with `///`).
- [ ] I added new tests to check the change I am making, or this PR is
[test-exempt].
- [ ] I followed the [breaking change policy] and added [Data Driven
Fixes] where supported.
- [ ] All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel
on [Discord].

<!-- Links -->
[Contributor Guide]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#overview
[Tree Hygiene]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md
[test-exempt]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#tests
[Flutter Style Guide]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md
[Features we expect every widget to implement]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md#features-we-expect-every-widget-to-implement
[CLA]: https://cla.developers.google.com/
[flutter/tests]: https://github.com/flutter/tests
[breaking change policy]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#handling-breaking-changes
[Discord]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Chat.md
[Data Driven Fixes]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Data-driven-Fixes.md
 2025-04-16 06:57:20 +00:00
engine-flutter-autoroll
055b23d47b
Roll Skia from 76cb5d4fba27 to 6627deb65939 (10 revisions) (#167249) 
https://skia.googlesource.com/skia.git/+log/76cb5d4fba27..6627deb65939

2025-04-15 nicolettep@google.com [graphite] Read dst as input attachment
in Vulkan
2025-04-15 skia-autoroll@skia-public.iam.gserviceaccount.com Roll skcms
from 8faeb7707de8 to df82c365f7be (1 revision)
2025-04-15 skia-autoroll@skia-public.iam.gserviceaccount.com Roll
vulkan-deps from 72ecfe9950d2 to 971325a8d446 (1 revision)
2025-04-15 kjlubick@google.com Rename existing SkRecorder ->
SkRecordCanvas
2025-04-15 skia-autoroll@skia-public.iam.gserviceaccount.com Roll ANGLE
from 1c0bcb06e36f to a3f2545f6bb3 (12 revisions)
2025-04-15 skia-autoroll@skia-public.iam.gserviceaccount.com Roll
SwiftShader from 2b323370501c to 2d70dae3d0ca (2 revisions)
2025-04-15 nscobie@google.com Ensure SkTraceEvent.h is kept as the
canonical header for tracing
2025-04-15 nscobie@google.com Revert "IWYU for SkTraceEventCommon.h"
2025-04-14 skia-autoroll@skia-public.iam.gserviceaccount.com Roll
vulkan-deps from a24af46b3d3b to 72ecfe9950d2 (10 revisions)
2025-04-14 bungeman@google.com IWYU for SkTraceEventCommon.h

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC bwils@google.com,codefu@google.com,kjlubick@google.com on the
revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter:
https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2025-04-16 05:27:25 +00:00
gaaclarke
b4dc23333c
Removed superfluous copy in license checker (#167146) 
This was the most expensive part of finding the files phase.

## Pre-launch Checklist

- [x] I read the [Contributor Guide] and followed the process outlined
there for submitting PRs.
- [x] I read the [Tree Hygiene] wiki page, which explains my
responsibilities.
- [x] I read and followed the [Flutter Style Guide], including [Features
we expect every widget to implement].
- [x] I signed the [CLA].
- [x] I listed at least one issue that this PR fixes in the description
above.
- [x] I updated/added relevant documentation (doc comments with `///`).
- [x] I added new tests to check the change I am making, or this PR is
[test-exempt].
- [x] I followed the [breaking change policy] and added [Data Driven
Fixes] where supported.
- [x] All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel
on [Discord].

<!-- Links -->
[Contributor Guide]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#overview
[Tree Hygiene]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md
[test-exempt]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#tests
[Flutter Style Guide]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md
[Features we expect every widget to implement]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md#features-we-expect-every-widget-to-implement
[CLA]: https://cla.developers.google.com/
[flutter/tests]: https://github.com/flutter/tests
[breaking change policy]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#handling-breaking-changes
[Discord]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Chat.md
[Data Driven Fixes]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Data-driven-Fixes.md
 2025-04-15 21:34:56 +00:00
gaaclarke
4ae02d275a
license checker: ignore git sha in dart license (#167153) 
This works around the problem of the git sha in the license golden for
dart by:
1) Ignoring that line in the comparison
1) Verifying that that line includes the googlesource url

fixes https://github.com/flutter/flutter/issues/166807

## Pre-launch Checklist

- [x] I read the [Contributor Guide] and followed the process outlined
there for submitting PRs.
- [x] I read the [Tree Hygiene] wiki page, which explains my
responsibilities.
- [x] I read and followed the [Flutter Style Guide], including [Features
we expect every widget to implement].
- [x] I signed the [CLA].
- [x] I listed at least one issue that this PR fixes in the description
above.
- [x] I updated/added relevant documentation (doc comments with `///`).
- [x] I added new tests to check the change I am making, or this PR is
[test-exempt].
- [x] I followed the [breaking change policy] and added [Data Driven
Fixes] where supported.
- [x] All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel
on [Discord].

<!-- Links -->
[Contributor Guide]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#overview
[Tree Hygiene]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md
[test-exempt]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#tests
[Flutter Style Guide]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md
[Features we expect every widget to implement]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md#features-we-expect-every-widget-to-implement
[CLA]: https://cla.developers.google.com/
[flutter/tests]: https://github.com/flutter/tests
[breaking change policy]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#handling-breaking-changes
[Discord]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Chat.md
[Data Driven Fixes]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Data-driven-Fixes.md
 2025-04-15 21:11:35 +00:00
engine-flutter-autoroll
7515a99e65
Roll Fuchsia Linux SDK from 91RIHvX0YC3wzD7qj... to 7bWzHwIPBTyU6R9nO... (#167213) 
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/fuchsia-linux-sdk-flutter
Please CC codefu@google.com,zra@google.com on the revert to ensure that
a human
is aware of the problem.

To file a bug in Flutter:
https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2025-04-15 19:32:08 +00:00
Ryan Macnak
ca758ac49b
Add buildroot compatibility for HWASAN. (#167133) 
Needed to roll https://dart-review.googlesource.com/c/sdk/+/421180.
 2025-04-15 00:56:07 +00:00
engine-flutter-autoroll
ddb8116210
Roll Skia from e7aa93f33a20 to 76cb5d4fba27 (13 revisions) (#167132) 
https://skia.googlesource.com/skia.git/+log/e7aa93f33a20..76cb5d4fba27

2025-04-14 borenet@google.com [infra] Update os dimension for devonf
2025-04-14 borenet@google.com [infra] Fix dimensions and add jobs for
several migrated devices
2025-04-14 robertphillips@google.com Improve PrecompileYUVImageShader
2025-04-14 skia-autoroll@skia-public.iam.gserviceaccount.com Roll
vulkan-deps from ccbdbbedfc26 to a24af46b3d3b (2 revisions)
2025-04-13 skia-autoroll@skia-public.iam.gserviceaccount.com Roll
vulkan-deps from 9bca40f4243f to ccbdbbedfc26 (1 revision)
2025-04-13 skia-recreate-skps@skia-swarming-bots.iam.gserviceaccount.com
Update SKP version
2025-04-13 skia-autoroll@skia-public.iam.gserviceaccount.com Roll
vulkan-deps from 18aada14d26d to 9bca40f4243f (2 revisions)
2025-04-12 skia-autoroll@skia-public.iam.gserviceaccount.com Roll
vulkan-deps from 30455461e798 to 18aada14d26d (3 revisions)
2025-04-11 skia-autoroll@skia-public.iam.gserviceaccount.com Roll
vulkan-deps from 5ec40ef70a52 to 30455461e798 (6 revisions)
2025-04-11 thomsmit@google.com [graphite] AnalyticRRect and
PerEdgeAAQuad render steps now upload corner ID's as vertex data instead
of inferring the corner through sk_vertexID.
2025-04-11 michaelludwig@google.com [graphite] Fail
DrawPass::prepareResources if sampled textures are uninstantiated
2025-04-11 jvanverth@google.com Revert "[graphite] Add ProxyCache
support to RasterPathAtlas."
2025-04-11 skia-autoroll@skia-public.iam.gserviceaccount.com Roll
vulkan-deps from 5c8010f3b85e to 5ec40ef70a52 (2 revisions)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC bwils@google.com,jonahwilliams@google.com,kjlubick@google.com
on the revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter:
https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2025-04-14 21:40:26 +00:00
zijiehe@
296df33be8
[fuchsia] Uprev test-scripts with FUCHSIA_READELF env (#166929) 
Copied from https://github.com/flutter/flutter/pull/166901 with the
essential fix to make it work.

Bug: b/407890258, b/338009514

## Pre-launch Checklist

- [x] I read the [Contributor Guide] and followed the process outlined
there for submitting PRs.
- [x] I read the [Tree Hygiene] wiki page, which explains my
responsibilities.
- [x] I read and followed the [Flutter Style Guide], including [Features
we expect every widget to implement].
- [x] I signed the [CLA].
- [x] I listed at least one issue that this PR fixes in the description
above.
- [x] I updated/added relevant documentation (doc comments with `///`).
- [x] I added new tests to check the change I am making, or this PR is
[test-exempt].
- [x] I followed the [breaking change policy] and added [Data Driven
Fixes] where supported.
- [x] All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel
on [Discord].

<!-- Links -->
[Contributor Guide]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#overview
[Tree Hygiene]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md
[test-exempt]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#tests
[Flutter Style Guide]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md
[Features we expect every widget to implement]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md#features-we-expect-every-widget-to-implement
[CLA]: https://cla.developers.google.com/
[flutter/tests]: https://github.com/flutter/tests
[breaking change policy]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#handling-breaking-changes
[Discord]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Chat.md
[Data Driven Fixes]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Data-driven-Fixes.md
 2025-04-14 19:38:02 +00:00
Bogdan Lukin
c251366036
Cleanup links to flutter/engine in ci/builders docs (#166916) 
update outdated links to flutter/engine before fusion

## Pre-launch Checklist

- [x] I read the [Contributor Guide] and followed the process outlined
there for submitting PRs.
- [x] I read the [Tree Hygiene] wiki page, which explains my
responsibilities.
- [x] I read and followed the [Flutter Style Guide], including [Features
we expect every widget to implement].
- [x] I signed the [CLA].
- [ ] I listed at least one issue that this PR fixes in the description
above.
- [x] I updated/added relevant documentation (doc comments with `///`).
- [x] I added new tests to check the change I am making, or this PR is
[test-exempt].
- [x] I followed the [breaking change policy] and added [Data Driven
Fixes] where supported.
- [x] All existing and new tests are passing.

<!-- Links -->
[Contributor Guide]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#overview
[Tree Hygiene]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md
[test-exempt]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#tests
[Flutter Style Guide]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md
[Features we expect every widget to implement]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md#features-we-expect-every-widget-to-implement
[CLA]: https://cla.developers.google.com/
[flutter/tests]: https://github.com/flutter/tests
[breaking change policy]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#handling-breaking-changes
[Discord]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Chat.md
[Data Driven Fixes]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Data-driven-Fixes.md
 2025-04-14 18:33:08 +00:00
Jackson Gardner
2f6cdc3fe1
[skwasm] Use queueMicrotask instead of postMessage when single-threaded (#166997) 
It turns out `postMessage` is quite a bit more expensive than
`queueMicrotask`. Before dynamic threading, this is what we actually
did, and perf regressed when we started using `postMessage` instead.

This fixes https://github.com/flutter/flutter/issues/166905
 2025-04-14 17:59:10 +00:00
Jason Simmons
0aca715089
Remove some unused third party library build scripts (#166960) 2025-04-14 17:50:21 +00:00
Jonah Williams
a7f820163c
[Impeller] various iOS cleanups. (#166859) 
* delete lazy drawable holder which is unused.
* Add some docs/test to PassBindingsCache
* Add StencilRef to PassBindingsCache - mostly to reduce redundant ops
in the debugger.
 2025-04-12 01:24:16 +00:00
Jonah Williams
7c8730ee40
[Impeller] reland: defer vulkan context initialization as long as possible. (#167000) 
Removes "quiet: true" which stopped us from printing out "using the
vulkan rendering backend" which we read in tests.
 2025-04-11 23:10:13 +00:00
Jonah Williams
2a1b863663
[Impeller] fix vulkan/gl color space decode. (#166957) 
Fixes https://github.com/flutter/flutter/issues/166954
Improves https://github.com/flutter/flutter/issues/164452

We need to force conversion to an SRGB color space otherwise images look
wrong if they happen to have things like a color profile. I believe this
is the correct change, as it matches the wide gamut decode above.
 2025-04-11 19:40:12 +00:00
auto-submit[bot]
c710c160bd
Reverts "[Impeller] defer vulkan context initialization as long as possible. (#166941)" (#166990) 
<!-- start_original_pr_link -->
Reverts: flutter/flutter#166941
<!-- end_original_pr_link -->
<!-- start_initiating_author -->
Initiated by: jonahwilliams
<!-- end_initiating_author -->
<!-- start_revert_reason -->
Reason for reverting: failing hello world test on post submit.
<!-- end_revert_reason -->
<!-- start_original_pr_author -->
Original PR Author: jonahwilliams
<!-- end_original_pr_author -->

<!-- start_reviewers -->
Reviewed By: {matanlurey}
<!-- end_reviewers -->

<!-- start_revert_body -->
This change reverts the following previous change:
In service of a faster startup for customer money, go back to defering
vulkan context initialization until the surface itself is created.
<!-- end_revert_body -->

Co-authored-by: auto-submit[bot] <flutter-engprod-team@google.com>
 2025-04-11 17:24:28 +00:00
Jonah Williams
ff75f640de
[Impeller] defer vulkan context initialization as long as possible. (#166941) 
In service of a faster startup for customer money, go back to defering
vulkan context initialization until the surface itself is created.
 2025-04-11 15:38:21 +00:00
engine-flutter-autoroll
0642b152b6
Roll Fuchsia Linux SDK from vYisSsIgqw0mqFRVJ... to 91RIHvX0YC3wzD7qj... (#166963) 
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/fuchsia-linux-sdk-flutter
Please CC jonahwilliams@google.com,zra@google.com on the revert to
ensure that a human
is aware of the problem.

To file a bug in Flutter:
https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2025-04-11 07:08:26 +00:00
Jonah Williams
94480b0329
[Impeller] correct render pass bariers when resolve has mips. (#166892) 
The other mip levels must be initialized to the correct state. This
would trigger validation errors in the test case that was previously
skipped for non-GL.
 2025-04-11 03:29:21 +00:00
Jonah Williams
5ea45c6378
[Impeller] re-make AHB swapchain lazy and allow usage on < 34 (#166943) 
In service of faster customer money startup
 2025-04-11 03:29:20 +00:00
Renzo Olivares
fc12bec5ec
Reland "SliverEnsureSemantics (#165589)" (#166889) 
This reverts commit 2fc716d, and updates the cross-axis size of the
`_scrollOverflowElement` to be 1px (non-zero), so it is taken into
account by the scrollable elements scrollHeight.

Fixes #160217

## Pre-launch Checklist

- [x] I read the [Contributor Guide] and followed the process outlined
there for submitting PRs.
- [x] I read the [Tree Hygiene] wiki page, which explains my
responsibilities.
- [x] I read and followed the [Flutter Style Guide], including [Features
we expect every widget to implement].
- [x] I signed the [CLA].
- [x] I listed at least one issue that this PR fixes in the description
above.
- [x] I updated/added relevant documentation (doc comments with `///`).
- [x] I added new tests to check the change I am making, or this PR is
[test-exempt].
- [x] I followed the [breaking change policy] and added [Data Driven
Fixes] where supported.
- [x] All existing and new tests are passing.

---------

Co-authored-by: Renzo Olivares <roliv@google.com>
 2025-04-11 00:51:26 +00:00
engine-flutter-autoroll
6acc8d332b
Roll Skia from 171b2bf1e496 to 98deb838d3b8 (2 revisions) (#166955) 
https://skia.googlesource.com/skia.git/+log/171b2bf1e496..98deb838d3b8

2025-04-10 jvanverth@google.com Revert "[graphite] Free backing data for
Plots when we no longer need it."
2025-04-10 jvanverth@google.com Revert "[graphite] Add allocation checks
to BasicDrawAtlas test."

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC
jlavrova@google.com,jonahwilliams@google.com,kjlubick@google.com on the
revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter:
https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2025-04-11 00:33:41 +00:00
auto-submit[bot]
43e8a93e8e
Reverts "[Impeller] Speed up vulkan startup time by re-using existing vulkan context. (#166784)" (#166938) 
<!-- start_original_pr_link -->
Reverts: flutter/flutter#166784
<!-- end_original_pr_link -->
<!-- start_initiating_author -->
Initiated by: jonahwilliams
<!-- end_initiating_author -->
<!-- start_revert_reason -->
Reason for reverting: didn't do enough, going to try something
different.
<!-- end_revert_reason -->
<!-- start_original_pr_author -->
Original PR Author: jonahwilliams
<!-- end_original_pr_author -->

<!-- start_reviewers -->
Reviewed By: {matanlurey}
<!-- end_reviewers -->

<!-- start_revert_body -->
This change reverts the following previous change:
Once we've created the Vulkan context, lets just use it - creating it
isn't free. See numbers. Also change AHB swapchain to lazily create
images, which will also improve startup and will be added to an opt in
list to test startup performance.

```
════════════════════════════╡ ••• Raw results ••• ╞═════════════════════════════

timeToFirstFrameMicros:
  A:	371525.00	225155.00	
  B:	254054.00	254668.00	
timeToFirstFrameRasterizedMicros:
  A:	781015.00	555791.00	
  B:	527163.00	526827.00	



═════════════════════════╡ ••• Final A/B results ••• ╞══════════════════════════

Score	            Average A (noise)	Average B (noise)	Speed-up
timeToFirstFrameMicros	298340.00 (24.53%)	254361.00 (0.12%)	1.17x	
timeToFirstFrameRasterizedMicros	668403.00 (16.85%)	526995.00 (0.03%)	1.27x	
```
<!-- end_revert_body -->

Co-authored-by: auto-submit[bot] <flutter-engprod-team@google.com>
 2025-04-10 19:36:19 +00:00
engine-flutter-autoroll
430c52648d
Roll Skia from 5ef1b00ac320 to 171b2bf1e496 (4 revisions) (#166931) 
https://skia.googlesource.com/skia.git/+log/5ef1b00ac320..171b2bf1e496

2025-04-10 kjlubick@google.com Replace addPolyLine with addLine in
SkBasicEdgeBuilder
2025-04-10 skia-autoroll@skia-public.iam.gserviceaccount.com Roll
vulkan-deps from 1e366225664f to 5c8010f3b85e (3 revisions)
2025-04-10 bungeman@google.com Remove
SkScalerContext::forceGenerateImageFromPath
2025-04-10 skia-autoroll@skia-public.iam.gserviceaccount.com Roll ANGLE
from f680e1074ba5 to 02fb04a81e75 (13 revisions)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC
jlavrova@google.com,jonahwilliams@google.com,kjlubick@google.com on the
revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter:
https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2025-04-10 18:52:26 +00:00
Jonah Williams
5f48a17123
[Impeller] Use device property uniform aligment instead of conservative value of 256. (#166884) 
Fixes https://github.com/flutter/flutter/issues/132178

Rather than 256, use the device limits which may be substantially less.
Metal uses existing values and GLES still uses 256.
 2025-04-10 18:00:17 +00:00
Yegor
ac1d8613fc
[web:skwasm] be consistent about handling imbalanced layer push/pop sequence (#166887) 
Skwasm was the only renderer that enforced that the root layer cannot be
popped. However, canvaskit and the native engines all allow popping the
root layer. It's just a noop.

Also, `EngineSceneBuilder` called `currentBuilder.build()` before
checking if the layer that's being popped is a root layer. This means
skwasm would call `rootLayer.build()` twice when push/pop are
unbalanced. It is called once on the last `pop()` on the root layer.
Then it is called again in `EngineSceneBuilder.build`.

Not a guarantee, but this may help reduce the skwasm error rates from
DevTools that look like this:

```
org-dartlang-sdk:///dart-sdk/lib/_internal/wasm/lib/error_utils.dart 130:15 | _throwIndexError
org-dartlang-sdk:///dart-sdk/lib/_internal/wasm/lib/error_utils.dart 24:7 | checkIndexBCE
org-dartlang-sdk:///lib/_engine/engine/scene_builder.dart 458:53 | pop
file:///b/s/w/ir/x/w/rc/flutter/packages/flutter/lib/src/rendering/layer.dart 1520:13 | addToScene
file:///b/s/w/ir/x/w/rc/flutter/packages/flutter/lib/src/rendering/layer.dart 721:5 | _addToSceneWithRetainedRendering
file:///b/s/w/ir/x/w/rc/flutter/packages/flutter/lib/src/rendering/layer.dart 1519:5 | addToScene
file:///b/s/w/ir/x/w/rc/flutter/packages/flutter/lib/src/rendering/layer.dart 721:5 | _addToSceneWithRetainedRendering
```
 2025-04-10 17:09:07 +00:00
Tong Mu
97b5264fcc
Migrate in-comment links of the flutter/engine repository to the flutter/flutter repository (#166790) 
This PR migrates almost all in-comment links that points to the main
branch of flutter/engine repository to the flutter/flutter repository,
ensuring that such links are always up to date.

I've manually verified that all links are valid. There are a few cases
where the migration is not so trivial and I had to look up for the
updated location or line number, but I'm pretty sure the new value is
correct.

The only place that I don't know how to migrate is two links in
[Upgrading-pre-1.12-Android-projects.md](https://github.com/flutter/flutter/blob/master/docs/platforms/android/Upgrading-pre-1.12-Android-projects.md)
pointing to
`https://github.com/flutter/engine/blob/main/shell/platform/android/io/flutter/app/FlutterActivity.java`,
which I guess no longer exists.

There are still many links that point to a specific branch or revision
of the engine repo. I don't think we need to migrate these links, since
they're probably not meant to be kept up to date.

## Pre-launch Checklist

- [ ] I read the [Contributor Guide] and followed the process outlined
there for submitting PRs.
- [ ] I read the [Tree Hygiene] wiki page, which explains my
responsibilities.
- [ ] I read and followed the [Flutter Style Guide], including [Features
we expect every widget to implement].
- [ ] I signed the [CLA].
- [ ] I listed at least one issue that this PR fixes in the description
above.
- [ ] I updated/added relevant documentation (doc comments with `///`).
- [ ] I added new tests to check the change I am making, or this PR is
[test-exempt].
- [ ] I followed the [breaking change policy] and added [Data Driven
Fixes] where supported.
- [ ] All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel
on [Discord].

<!-- Links -->
[Contributor Guide]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#overview
[Tree Hygiene]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md
[test-exempt]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#tests
[Flutter Style Guide]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md
[Features we expect every widget to implement]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md#features-we-expect-every-widget-to-implement
[CLA]: https://cla.developers.google.com/
[flutter/tests]: https://github.com/flutter/tests
[breaking change policy]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#handling-breaking-changes
[Discord]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Chat.md
[Data Driven Fixes]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Data-driven-Fixes.md
 2025-04-10 15:58:23 +00:00
Jonah Williams
fe64cf4216
[engine] disable Skia resource manager warning when using Impeller. (#166882) 
Fixes https://github.com/flutter/flutter/issues/135522

This is a skia warning. If there is an impeller context we shouldn't
print it.
 2025-04-10 00:11:26 +00:00
engine-flutter-autoroll
c0f25df6c0
Roll Skia from ac01f9306a0c to 6552940886b8 (15 revisions) (#166883) 
https://skia.googlesource.com/skia.git/+log/ac01f9306a0c..6552940886b8

2025-04-09 borenet@google.com [infra] Use new Windows 11 VMs from GCE
Provider
2025-04-09 jvanverth@google.com Remove last remnant of
SK_USE_LEGACY_GANESH_TEXT_APIS
2025-04-09 kjlubick@google.com Refactor calculations in SkEdge to be
more understandable
2025-04-09 kjlubick@google.com Add tests and visualization slide for
aliased scan converter
2025-04-09 kjlubick@google.com Use polymorphism to clean up SkEdge
2025-04-09 kjlubick@google.com Remove shiftUp parameter from aliased
scan converter
2025-04-09 kjlubick@google.com Add docs to SkEdge and rename fields for
clarity
2025-04-09 skia-autoroll@skia-public.iam.gserviceaccount.com Roll
vulkan-deps from c18348e6dc1d to c8554b0ea83f (1 revision)
2025-04-09 skia-autoroll@skia-public.iam.gserviceaccount.com Roll ANGLE
from cbd6cdc90c3a to f680e1074ba5 (11 revisions)
2025-04-09 robertphillips@google.com Revert "Address TSAN issue in
GrSurfaceProxy::backingStoreDimensions"
2025-04-08 skia-autoroll@skia-public.iam.gserviceaccount.com Roll
vulkan-deps from ddb9ba0fdcc3 to c18348e6dc1d (13 revisions)
2025-04-08 robertphillips@google.com Revert "Add debugging info for
Assert firing in Chrome"
2025-04-08 michaelludwig@google.com [graphite] Refactor VulkanRenderPass
metadata in prep for AttachmentDesc update
2025-04-08 jvanverth@google.com [graphite] Disable use of ProxyCache for
Raster and Clip atlases.
2025-04-08 jvanverth@google.com Remove Ganesh dependencies from
AtlasSubRun types.

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC
jlavrova@google.com,jonahwilliams@google.com,kjlubick@google.com on the
revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter:
https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2025-04-10 00:04:26 +00:00