Tamir Duberstein
75da76c7cd
Add missing includes ( flutter/engine#42812 )
...
See https://fxrev.dev/869997 .
2023-06-13 19:34:06 +00:00
luckysmg
948e1fa81a
[iOS][Keyboard] Wait vsync on UI thread and update viewport inset to avoid jitter. ( flutter/engine#42312 )
...
Video for after and before this patch:
[videos.zip](https://github.com/flutter/engine/files/11231756/videos.zip )
- https://github.com/flutter/flutter/issues/120555
The technical problem is: if setViewportMetrics called **before** framework's vsync process callback (rebuild & layout & paint), will cause jitter keyboard animation.So this PR is to keep the time when updateViewportMetrics call to framework side legal.
### Before
### After
2023-06-13 17:40:05 +00:00
gmackall
04786833e9
Capture additional final inset states in ImeSyncDeferringInsetsCallback ( flutter/engine#42700 )
...
Fixes https://github.com/flutter/flutter/issues/118761 .
For some context: ImeSyncDeferringInsetsCallback extends [WindowInsetsAnimation.Callback](https://developer.android.com/reference/android/view/WindowInsetsAnimation.Callback ) specifically to handle insets related to keyboard animations.
When a keyboard animation happens, we get a call to onPrepare with the animation, and then to onApplyWindowInsets with [WindowInsets](https://developer.android.com/reference/android/view/WindowInsets ) that represent the post animation state. For example, for hiding the keyboard, we would get WindowInsets with height of 0 for insets of type WindowInsets.Type.ime() (input method editor). We save these post-animation insets.
We then get calls to onProgress for each frame of the animation, and use the WindowInsets passed to onProgress to build new WindowInsets based on the saved post-animation insets, but with the keyboard insets overridden by the WindowInsets passed to onProgress.
Finally, we get a call to onEnd, where we apply the saved insets.
However, there can be multiple animation running at the same time. For example, dismissing the keyboard can result in an animation associated solely with the keyboard happening, as well as an animation associated only with the navigation bar happening. And they can start at slightly different times. This can result in the situation described in this comment: https://github.com/flutter/flutter/issues/118761#issuecomment-1574284505
Re-setting needsSave to false ensures we don't ignore any updates to the final state, ensuring correct insets in onProgress and onEnd.
[C++, Objective-C, Java style guides]: https://github.com/flutter/engine/blob/main/CONTRIBUTING.md#style
2023-06-13 17:10:33 +00:00
skia-flutter-autoroll
c3ba78c362
Roll Fuchsia Linux SDK from r0hMbc7UJwTJkxjbt... to kQbij6Tvqe7F9-PhR... ( flutter/engine#42807 )
...
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/fuchsia-linux-sdk-flutter-engine
Please CC jacksongardner@google.com ,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2023-06-13 13:41:25 +00:00
dependabot[bot]
a192bf6703
Bump github/codeql-action from 2.3.6 to 2.13.4 ( flutter/engine#42802 )
...
Bumps [github/codeql-action](https://github.com/github/codeql-action ) from 2.3.6 to 2.13.4.
<details>
<summary>Release notes</summary>
<p><em>Sourced from <a href="https://github.com/github/codeql-action/releases ">github/codeql-action's releases</a>.</em></p>
<blockquote>
<h2>CodeQL Bundle</h2>
<p>Bundles CodeQL CLI v2.13.4</p>
<ul>
<li>(<a href="https://github.com/github/codeql-cli-binaries/blob/HEAD/CHANGELOG.md ">changelog</a>, <a href="https://github.com/github/codeql-cli-binaries/releases/tag/v2.13.4 ">release</a>)</li>
</ul>
<p>Includes the following CodeQL language packs from <a href="https://github.com/github/codeql/tree/codeql-cli/v2.13.4 "><code>github/codeql@codeql-cli/v2.13.4</code></a>:</p>
<ul>
<li><code>codeql/cpp-queries</code> (<a href="https://github.com/github/codeql/tree/codeql-cli/v2.13.4/cpp/ql/src/CHANGELOG.md ">changelog</a>, <a href="https://github.com/github/codeql/tree/codeql-cli/v2.13.4/cpp/ql/src ">source</a>)</li>
<li><code>codeql/cpp-all</code> (<a href="https://github.com/github/codeql/tree/codeql-cli/v2.13.4/cpp/ql/lib/CHANGELOG.md ">changelog</a>, <a href="https://github.com/github/codeql/tree/codeql-cli/v2.13.4/cpp/ql/lib ">source</a>)</li>
<li><code>codeql/csharp-queries</code> (<a href="https://github.com/github/codeql/tree/codeql-cli/v2.13.4/csharp/ql/src/CHANGELOG.md ">changelog</a>, <a href="https://github.com/github/codeql/tree/codeql-cli/v2.13.4/csharp/ql/src ">source</a>)</li>
<li><code>codeql/csharp-all</code> (<a href="https://github.com/github/codeql/tree/codeql-cli/v2.13.4/csharp/ql/lib/CHANGELOG.md ">changelog</a>, <a href="https://github.com/github/codeql/tree/codeql-cli/v2.13.4/csharp/ql/lib ">source</a>)</li>
<li><code>codeql/go-queries</code> (<a href="https://github.com/github/codeql/tree/codeql-cli/v2.13.4/go/ql/src/CHANGELOG.md ">changelog</a>, <a href="https://github.com/github/codeql/tree/codeql-cli/v2.13.4/go/ql/src ">source</a>)</li>
<li><code>codeql/go-all</code> (<a href="https://github.com/github/codeql/tree/codeql-cli/v2.13.4/go/ql/lib/CHANGELOG.md ">changelog</a>, <a href="https://github.com/github/codeql/tree/codeql-cli/v2.13.4/go/ql/lib ">source</a>)</li>
<li><code>codeql/java-queries</code> (<a href="https://github.com/github/codeql/tree/codeql-cli/v2.13.4/java/ql/src/CHANGELOG.md ">changelog</a>, <a href="https://github.com/github/codeql/tree/codeql-cli/v2.13.4/java/ql/src ">source</a>)</li>
<li><code>codeql/java-all</code> (<a href="https://github.com/github/codeql/tree/codeql-cli/v2.13.4/java/ql/lib/CHANGELOG.md ">changelog</a>, <a href="https://github.com/github/codeql/tree/codeql-cli/v2.13.4/java/ql/lib ">source</a>)</li>
<li><code>codeql/javascript-queries</code> (<a href="https://github.com/github/codeql/tree/codeql-cli/v2.13.4/javascript/ql/src/CHANGELOG.md ">changelog</a>, <a href="https://github.com/github/codeql/tree/codeql-cli/v2.13.4/javascript/ql/src ">source</a>)</li>
<li><code>codeql/javascript-all</code> (<a href="https://github.com/github/codeql/tree/codeql-cli/v2.13.4/javascript/ql/lib/CHANGELOG.md ">changelog</a>, <a href="https://github.com/github/codeql/tree/codeql-cli/v2.13.4/javascript/ql/lib ">source</a>)</li>
<li><code>codeql/python-queries</code> (<a href="https://github.com/github/codeql/tree/codeql-cli/v2.13.4/python/ql/src/CHANGELOG.md ">changelog</a>, <a href="https://github.com/github/codeql/tree/codeql-cli/v2.13.4/python/ql/src ">source</a>)</li>
<li><code>codeql/python-all</code> (<a href="https://github.com/github/codeql/tree/codeql-cli/v2.13.4/python/ql/lib/CHANGELOG.md ">changelog</a>, <a href="https://github.com/github/codeql/tree/codeql-cli/v2.13.4/python/ql/lib ">source</a>)</li>
<li><code>codeql/ruby-queries</code> (<a href="https://github.com/github/codeql/tree/codeql-cli/v2.13.4/ruby/ql/src/CHANGELOG.md ">changelog</a>, <a href="https://github.com/github/codeql/tree/codeql-cli/v2.13.4/ruby/ql/src ">source</a>)</li>
<li><code>codeql/ruby-all</code> (<a href="https://github.com/github/codeql/tree/codeql-cli/v2.13.4/ruby/ql/lib/CHANGELOG.md ">changelog</a>, <a href="https://github.com/github/codeql/tree/codeql-cli/v2.13.4/ruby/ql/lib ">source</a>)</li>
<li><code>codeql/swift-queries</code> (<a href="https://github.com/github/codeql/tree/codeql-cli/v2.13.4/swift/ql/src/CHANGELOG.md ">changelog</a>, <a href="https://github.com/github/codeql/tree/codeql-cli/v2.13.4/swift/ql/src ">source</a>)</li>
<li><code>codeql/swift-all</code> (<a href="https://github.com/github/codeql/tree/codeql-cli/v2.13.4/swift/ql/lib/CHANGELOG.md ">changelog</a>, <a href="https://github.com/github/codeql/tree/codeql-cli/v2.13.4/swift/ql/lib ">source</a>)</li>
</ul>
<h2>CodeQL Bundle v2.6.0-beta.1</h2>
<p>Bundles CodeQL CLI <a href="https://github.com/github/codeql-cli-binaries/releases/tag/v2.6.0-beta.1 ">v2.6.0-beta.1</a></p>
<h3>â ï¸ This is a beta release containing a new CodeQL packaging feature. It may not be compatible with existing workflows.</h3>
<p>This release contains beta support for <strong>CodeQL packs</strong>. Please read the documentation below for more information:</p>
<ul>
<li><a href="https://codeql.github.com/docs/codeql-cli/about-codeql-packs ">Using CodeQL packs with the CodeQL CLI</a></li>
<li><a href="https://docs.github.com/en/code-security/secure-coding/automatically-scanning-your-code-for-vulnerabilities-and-errors/configuring-code-scanning#using-codeql-query-packs ">Using CodeQL packs in Code Scanning on GitHub Actions</a></li>
<li><a href="https://docs.github.com/en/code-security/secure-coding/using-codeql-code-scanning-with-your-existing-ci-system/configuring-codeql-cli-in-your-ci-system#downloading-and-using-codeql-query-packs ">Using CodeQL packs in Code Scanning on 3rd-party CI systems</a></li>
</ul>
</blockquote>
</details>
<details>
<summary>Changelog</summary>
<p><em>Sourced from <a href="https://github.com/github/codeql-action/blob/main/CHANGELOG.md ">github/codeql-action's changelog</a>.</em></p>
<blockquote>
<h1>CodeQL Action Changelog</h1>
<h2>[UNRELEASED]</h2>
<p>No user facing changes.</p>
<h2>2.3.6 - 01 Jun 2023</h2>
<ul>
<li>Update default CodeQL bundle version to 2.13.3. <a href="https://redirect.github.com/github/codeql-action/pull/1698 ">#1698</a></li>
</ul>
<h2>2.3.5 - 25 May 2023</h2>
<ul>
<li>Allow invalid URIs to be used as values to <code>artifactLocation.uri</code> properties. This reverses a change from <a href="https://redirect.github.com/github/codeql-action/pull/1668 ">#1668</a> that inadvertently led to stricter validation of some URI values. <a href="https://redirect.github.com/github/codeql-action/pull/1705 ">#1705</a></li>
<li>Gracefully handle invalid URIs when fingerprinting. <a href="https://redirect.github.com/github/codeql-action/pull/1694 ">#1694</a></li>
</ul>
<h2>2.3.4 - 24 May 2023</h2>
<ul>
<li>Updated the SARIF 2.1.0 JSON schema file to the latest from <a href="123e95847b/Schemata/sarif-schema-2.1.0.jsonhttps://redirect.github.com/github/codeql-action/pull/1668 ">#1668</a></li>
<li>We are rolling out a feature in May 2023 that will disable Python dependency installation for new users of the CodeQL Action. This improves the speed of analysis while having only a very minor impact on results. <a href="https://redirect.github.com/github/codeql-action/pull/1676 ">#1676</a></li>
<li>We are improving the way that <a href="https://github.com/github/codeql-action/releases ">CodeQL bundles</a> are tagged to make it possible to easily identify bundles by their CodeQL semantic version. <a href="https://redirect.github.com/github/codeql-action/pull/1682 ">#1682</a>
<ul>
<li>As of CodeQL CLI 2.13.4, CodeQL bundles will be tagged using semantic versions, for example <code>codeql-bundle-v2.13.4</code>, instead of timestamps, like <code>codeql-bundle-20230615</code>.</li>
<li>This change does not affect the majority of workflows, and we will not be changing tags for existing bundle releases.</li>
<li>Some workflows with custom logic that depends on the specific format of the CodeQL bundle tag may need to be updated. For example, if your workflow matches CodeQL bundle tag names against a <code>codeql-bundle-yyyymmdd</code> pattern, you should update it to also recognize <code>codeql-bundle-vx.y.z</code> tags.</li>
</ul>
</li>
<li>Remove the requirement for <code>on.push</code> and <code>on.pull_request</code> to trigger on the same branches. <a href="https://redirect.github.com/github/codeql-action/pull/1675 ">#1675</a></li>
</ul>
<h2>2.3.3 - 04 May 2023</h2>
<ul>
<li>Update default CodeQL bundle version to 2.13.1. <a href="https://redirect.github.com/github/codeql-action/pull/1664 ">#1664</a></li>
<li>You can now configure CodeQL within your code scanning workflow by passing a <code>config</code> input to the <code>init</code> Action. See <a href="https://aka.ms/code-scanning-docs/config-file ">Using a custom configuration file</a> for more information about configuring code scanning. <a href="https://redirect.github.com/github/codeql-action/pull/1590 ">#1590</a></li>
</ul>
<h2>2.3.2 - 27 Apr 2023</h2>
<p>No user facing changes.</p>
<h2>2.3.1 - 26 Apr 2023</h2>
<p>No user facing changes.</p>
<h2>2.3.0 - 21 Apr 2023</h2>
<ul>
<li>Update default CodeQL bundle version to 2.13.0. <a href="https://redirect.github.com/github/codeql-action/pull/1649 ">#1649</a></li>
<li>Bump the minimum CodeQL bundle version to 2.8.5. <a href="https://redirect.github.com/github/codeql-action/pull/1618 ">#1618</a></li>
</ul>
<h2>2.2.12 - 13 Apr 2023</h2>
<ul>
<li>Include the value of the <code>GITHUB_RUN_ATTEMPT</code> environment variable in the telemetry sent to GitHub. <a href="https://redirect.github.com/github/codeql-action/pull/1640 ">#1640</a></li>
<li>Improve the ease of debugging failed runs configured using <a href="https://docs.github.com/en/code-security/code-scanning/automatically-scanning-your-code-for-vulnerabilities-and-errors/configuring-code-scanning-for-a-repository#configuring-code-scanning-automatically ">default setup</a>. The CodeQL Action will now upload diagnostic information to Code Scanning from failed runs configured using default setup. You can view this diagnostic information on the <a href="https://docs.github.com/en/code-security/code-scanning/automatically-scanning-your-code-for-vulnerabilities-and-errors/about-the-tool-status-page ">tool status page</a>. <a href="https://redirect.github.com/github/codeql-action/pull/1619 ">#1619</a></li>
</ul>
<h2>2.2.11 - 06 Apr 2023</h2>
</blockquote>
<p>... (truncated)</p>
</details>
<details>
<summary>Commits</summary>
<ul>
<li><a href="cdcdbb5797https://redirect.github.com/github/codeql-action/issues/1718 ">#1718</a>)</li>
<li><a href="8b0f2cf9dahttps://redirect.github.com/github/codeql-action/issues/1717 ">#1717</a> from github/henrymercer/fix-changelog</li>
<li><a href="a35a881b65d8667207b6https://redirect.github.com/github/codeql-action/issues/1714 ">#1714</a> from github/mergeback/v2.3.6-to-main-83f0fe6c</li>
<li><a href="926a4898bchttps://redirect.github.com/github/codeql-action/issues/1712 ">#1712</a> from github/henrymercer/remove-unused-env-var</li>
<li><a href="5c63cc5b1c30a3b9a904dfc31c9995019a40b91aae005db7f883f0fe6c49...cdcdbb5797https://dependabot-badges.githubapp.com/badges/compatibility_score?dependency-name=github/codeql-action&package-manager=github_actions&previous-version=2.3.6&new-version=2.13.4 )](https://docs.github.com/en/github/managing-security-vulnerabilities/about-dependabot-security-updates#about-compatibility-scores )
Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting `@dependabot rebase`.
---
<details>
<summary>Dependabot commands and options</summary>
<br />
You can trigger Dependabot actions by commenting on this PR:
- `@dependabot rebase` will rebase this PR
- `@dependabot recreate` will recreate this PR, overwriting any edits that have been made to it
- `@dependabot merge` will merge this PR after your CI passes on it
- `@dependabot squash and merge` will squash and merge this PR after your CI passes on it
- `@dependabot cancel merge` will cancel a previously requested merge and block automerging
- `@dependabot reopen` will reopen this PR if it is closed
- `@dependabot close` will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
- `@dependabot ignore this major version` will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
- `@dependabot ignore this minor version` will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
- `@dependabot ignore this dependency` will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)
</details>
2023-06-13 06:48:04 +00:00
dependabot[bot]
e4c67e1370
Bump actions/checkout from 3.5.2 to 3.5.3 ( flutter/engine#42801 )
...
Bumps [actions/checkout](https://github.com/actions/checkout ) from 3.5.2 to 3.5.3.
<details>
<summary>Release notes</summary>
<p><em>Sourced from <a href="https://github.com/actions/checkout/releases ">actions/checkout's releases</a>.</em></p>
<blockquote>
<h2>v3.5.3</h2>
<h2>What's Changed</h2>
<ul>
<li>Fix: Checkout Issue in self hosted runner due to faulty submodule check-ins by <a href="https://github.com/megamanics "><code>@âmegamanics</code></a> in <a href="https://redirect.github.com/actions/checkout/pull/1196 ">actions/checkout#1196</a></li>
<li>Fix typos found by codespell by <a href="https://github.com/DimitriPapadopoulos "><code>@âDimitriPapadopoulos</code></a> in <a href="https://redirect.github.com/actions/checkout/pull/1287 ">actions/checkout#1287</a></li>
<li>Add support for sparse checkouts by <a href="https://github.com/dscho "><code>@âdscho</code></a> and <a href="https://github.com/dfdez "><code>@âdfdez</code></a> in <a href="https://redirect.github.com/actions/checkout/pull/1369 ">actions/checkout#1369</a></li>
<li>Release v3.5.3 by <a href="https://github.com/TingluoHuang "><code>@âTingluoHuang</code></a> in <a href="https://redirect.github.com/actions/checkout/pull/1376 ">actions/checkout#1376</a></li>
</ul>
<h2>New Contributors</h2>
<ul>
<li><a href="https://github.com/megamanics "><code>@âmegamanics</code></a> made their first contribution in <a href="https://redirect.github.com/actions/checkout/pull/1196 ">actions/checkout#1196</a></li>
<li><a href="https://github.com/DimitriPapadopoulos "><code>@âDimitriPapadopoulos</code></a> made their first contribution in <a href="https://redirect.github.com/actions/checkout/pull/1287 ">actions/checkout#1287</a></li>
<li><a href="https://github.com/dfdez "><code>@âdfdez</code></a> made their first contribution in <a href="https://redirect.github.com/actions/checkout/pull/1369 ">actions/checkout#1369</a></li>
</ul>
<p><strong>Full Changelog</strong>: <a href="https://github.com/actions/checkout/compare/v3...v3.5.3 ">https://github.com/actions/checkout/compare/v3...v3.5.3 </a></p>
</blockquote>
</details>
<details>
<summary>Changelog</summary>
<p><em>Sourced from <a href="https://github.com/actions/checkout/blob/main/CHANGELOG.md ">actions/checkout's changelog</a>.</em></p>
<blockquote>
<h1>Changelog</h1>
<h2>v3.5.3</h2>
<ul>
<li><a href="https://redirect.github.com/actions/checkout/pull/1196 ">Fix: Checkout fail in self-hosted runners when faulty submodule are checked-in</a></li>
<li><a href="https://redirect.github.com/actions/checkout/pull/1287 ">Fix typos found by codespell</a></li>
<li><a href="https://redirect.github.com/actions/checkout/pull/1369 ">Add support for sparse checkouts</a></li>
</ul>
<h2>v3.5.2</h2>
<ul>
<li><a href="https://redirect.github.com/actions/checkout/pull/1289 ">Fix api endpoint for GHES</a></li>
</ul>
<h2>v3.5.1</h2>
<ul>
<li><a href="https://redirect.github.com/actions/checkout/pull/1246 ">Fix slow checkout on Windows</a></li>
</ul>
<h2>v3.5.0</h2>
<ul>
<li><a href="https://redirect.github.com/actions/checkout/pull/1237 ">Add new public key for known_hosts</a></li>
</ul>
<h2>v3.4.0</h2>
<ul>
<li><a href="https://redirect.github.com/actions/checkout/pull/1209 ">Upgrade codeql actions to v2</a></li>
<li><a href="https://redirect.github.com/actions/checkout/pull/1210 ">Upgrade dependencies</a></li>
<li><a href="https://redirect.github.com/actions/checkout/pull/1225 ">Upgrade <code>@âactions/io</code></a></li>
</ul>
<h2>v3.3.0</h2>
<ul>
<li><a href="https://redirect.github.com/actions/checkout/pull/1045 ">Implement branch list using callbacks from exec function</a></li>
<li><a href="https://redirect.github.com/actions/checkout/pull/1050 ">Add in explicit reference to private checkout options</a></li>
<li>[Fix comment typos (that got added in <a href="https://redirect.github.com/actions/checkout/issues/770 ">#770</a>)](<a href="https://redirect.github.com/actions/checkout/pull/1057 ">actions/checkout#1057</a>)</li>
</ul>
<h2>v3.2.0</h2>
<ul>
<li><a href="https://redirect.github.com/actions/checkout/pull/942 ">Add GitHub Action to perform release</a></li>
<li><a href="https://redirect.github.com/actions/checkout/pull/967 ">Fix status badge</a></li>
<li><a href="https://redirect.github.com/actions/checkout/pull/1002 ">Replace datadog/squid with ubuntu/squid Docker image</a></li>
<li><a href="https://redirect.github.com/actions/checkout/pull/964 ">Wrap pipeline commands for submoduleForeach in quotes</a></li>
<li><a href="https://redirect.github.com/actions/checkout/pull/1029 ">Update <code>@âactions/io</code> to 1.1.2</a></li>
<li><a href="https://redirect.github.com/actions/checkout/pull/1039 ">Upgrading version to 3.2.0</a></li>
</ul>
<h2>v3.1.0</h2>
<ul>
<li><a href="https://redirect.github.com/actions/checkout/pull/939 ">Use <code>@âactions/core</code> <code>saveState</code> and <code>getState</code></a></li>
<li><a href="https://redirect.github.com/actions/checkout/pull/922 ">Add <code>github-server-url</code> input</a></li>
</ul>
<h2>v3.0.2</h2>
<ul>
<li><a href="https://redirect.github.com/actions/checkout/pull/770 ">Add input <code>set-safe-directory</code></a></li>
</ul>
<h2>v3.0.1</h2>
<ul>
<li><a href="https://redirect.github.com/actions/checkout/pull/762 ">Fixed an issue where checkout failed to run in container jobs due to the new git setting <code>safe.directory</code></a></li>
<li><a href="https://redirect.github.com/actions/checkout/pull/744 ">Bumped various npm package versions</a></li>
</ul>
<h2>v3.0.0</h2>
<ul>
<li><a href="https://redirect.github.com/actions/checkout/pull/689 ">Update to node 16</a></li>
</ul>
<h2>v2.3.1</h2>
</blockquote>
<p>... (truncated)</p>
</details>
<details>
<summary>Commits</summary>
<ul>
<li><a href="c85c95e3d7https://redirect.github.com/actions/checkout/issues/1376 ">#1376</a>)</li>
<li><a href="d106d4669bhttps://redirect.github.com/actions/checkout/issues/1369 ">#1369</a>)</li>
<li><a href="f095bcc56bhttps://redirect.github.com/actions/checkout/issues/1287 ">#1287</a>)</li>
<li><a href="47fbe2df0a8e5e7e5ab8...c85c95e3d7https://dependabot-badges.githubapp.com/badges/compatibility_score?dependency-name=actions/checkout&package-manager=github_actions&previous-version=3.5.2&new-version=3.5.3 )](https://docs.github.com/en/github/managing-security-vulnerabilities/about-dependabot-security-updates#about-compatibility-scores )
Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting `@dependabot rebase`.
---
<details>
<summary>Dependabot commands and options</summary>
<br />
You can trigger Dependabot actions by commenting on this PR:
- `@dependabot rebase` will rebase this PR
- `@dependabot recreate` will recreate this PR, overwriting any edits that have been made to it
- `@dependabot merge` will merge this PR after your CI passes on it
- `@dependabot squash and merge` will squash and merge this PR after your CI passes on it
- `@dependabot cancel merge` will cancel a previously requested merge and block automerging
- `@dependabot reopen` will reopen this PR if it is closed
- `@dependabot close` will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
- `@dependabot ignore this major version` will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
- `@dependabot ignore this minor version` will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
- `@dependabot ignore this dependency` will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)
</details>
2023-06-13 06:38:22 +00:00
dependabot[bot]
d5a15cc3c4
Bump actions/labeler from 4.0.4 to 4.1.0 ( flutter/engine#42803 )
...
Bumps [actions/labeler](https://github.com/actions/labeler ) from 4.0.4 to 4.1.0.
<details>
<summary>Release notes</summary>
<p><em>Sourced from <a href="https://github.com/actions/labeler/releases ">actions/labeler's releases</a>.</em></p>
<blockquote>
<h2>v4.1.0</h2>
<h2>What's Changed</h2>
<p>In scope of this release, the <code>dot</code> input was added by <a href="https://github.com/kachkaev "><code>@âkachkaev</code></a> in <a href="https://redirect.github.com/actions/labeler/pull/316 ">actions/labeler#316</a>. It allows patterns to match paths starting with a period. This input is set to <code>false</code> by default.</p>
<h3>Usage</h3>
<pre lang="yml"><code>name: "Pull Request Labeler"
on:
- pull_request_target
<p>jobs:
triage:
permissions:
contents: read
pull-requests: write
runs-on: ubuntu-latest
steps:
- uses: actions/labeler@v4
with:
dot: true
</code></pre></p>
<p>This release also includes the following changes:</p>
<ul>
<li>Simplify globbing examples in README by <a href="https://github.com/Youssef1313 "><code>@âYoussef1313</code></a> in <a href="https://redirect.github.com/actions/labeler/pull/451 ">actions/labeler#451</a></li>
<li>Bump <code>@âtypescript-eslint/parser</code> from 5.59.7 to 5.59.8 by <a href="https://github.com/dependabot "><code>@âdependabot</code></a> in <a href="https://redirect.github.com/actions/labeler/pull/577 ">actions/labeler#577</a></li>
<li>Bump <code>@âtypescript-eslint/eslint-plugin</code> from 5.59.7 to 5.59.8 by <a href="https://github.com/dependabot "><code>@âdependabot</code></a> in <a href="https://redirect.github.com/actions/labeler/pull/578 ">actions/labeler#578</a></li>
</ul>
<h2>New Contributors</h2>
<ul>
<li><a href="https://github.com/Youssef1313 "><code>@âYoussef1313</code></a> made their first contribution in <a href="https://redirect.github.com/actions/labeler/pull/451 ">actions/labeler#451</a></li>
<li><a href="https://github.com/kachkaev "><code>@âkachkaev</code></a> made their first contribution in <a href="https://redirect.github.com/actions/labeler/pull/316 ">actions/labeler#316</a></li>
</ul>
<p><strong>Full Changelog</strong>: <a href="https://github.com/actions/labeler/compare/v4...v4.1.0 ">https://github.com/actions/labeler/compare/v4...v4.1.0 </a></p>
</blockquote>
</details>
<details>
<summary>Commits</summary>
<ul>
<li><a href="9fcb2c2f55https://redirect.github.com/actions/labeler/issues/578 ">#578</a> from actions/dependabot/npm_and_yarn/typescript-eslin...</li>
<li><a href="0d06c504351d399c3ab6https://redirect.github.com/actions/labeler/issues/577 ">#577</a> from actions/dependabot/npm_and_yarn/typescript-eslin...</li>
<li><a href="82a4f6fc25https://redirect.github.com/actions/labeler/issues/316 ">#316</a> from kachkaev/dot-option</li>
<li><a href="d40596e5db3cbc54c641https://redirect.github.com/actions/labeler/issues/451 ">#451</a> from Youssef1313/patch-1</li>
<li><a href="639ba81ab171d2484daa59d3310a72a78a6c7eb70776a67936...9fcb2c2f55https://dependabot-badges.githubapp.com/badges/compatibility_score?dependency-name=actions/labeler&package-manager=github_actions&previous-version=4.0.4&new-version=4.1.0 )](https://docs.github.com/en/github/managing-security-vulnerabilities/about-dependabot-security-updates#about-compatibility-scores )
Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting `@dependabot rebase`.
---
<details>
<summary>Dependabot commands and options</summary>
<br />
You can trigger Dependabot actions by commenting on this PR:
- `@dependabot rebase` will rebase this PR
- `@dependabot recreate` will recreate this PR, overwriting any edits that have been made to it
- `@dependabot merge` will merge this PR after your CI passes on it
- `@dependabot squash and merge` will squash and merge this PR after your CI passes on it
- `@dependabot cancel merge` will cancel a previously requested merge and block automerging
- `@dependabot reopen` will reopen this PR if it is closed
- `@dependabot close` will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
- `@dependabot ignore this major version` will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
- `@dependabot ignore this minor version` will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
- `@dependabot ignore this dependency` will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)
</details>
2023-06-13 06:34:15 +00:00
godofredoc
d7293a979c
Create v2 configuration for emulator tests. ( flutter/engine#42652 )
...
Migrates emulator tests to engine v2.
[C++, Objective-C, Java style guides]: https://github.com/flutter/engine/blob/main/CONTRIBUTING.md#style
2023-06-13 03:08:17 +00:00
Jonah Williams
99b4037a19
[Impeller] Ensure vulkan offscreen pixelformat is the same as the onscreen format ( flutter/engine#42788 )
...
Fixes https://github.com/flutter/flutter/issues/128604
THe problem was that we were selecting kB8G8R8A8UNormInt for the
offscreen and kR8G8B8A8UNormInt for the onscreen, so the blit was
swapping the color channels.
2023-06-12 18:21:51 -07:00
skia-flutter-autoroll
63270e3487
Roll Fuchsia Linux SDK from pd1VfyK_WEW6tu8WI... to r0hMbc7UJwTJkxjbt... ( flutter/engine#42786 )
2023-06-12 17:28:35 -07:00
Jonah Williams
0721bf1a95
[Impeller] Fix text jitter on Vulkan. ( flutter/engine#42792 )
...
Fixes https://github.com/flutter/flutter/issues/128624
2023-06-12 23:48:11 +00:00
Justin McCandless
7ffe595a77
Predictive back breakage fix ( flutter/engine#42789 )
...
Fixes breakages related to setFrameworkHandlesBack, for the Predictive Back feature for Android.
2023-06-12 16:19:30 -07:00
godofredoc
d6a1b45c11
Reland "Move linux clang tidy to engine_v2."" ( flutter/engine#42713 )
...
Reverts flutter/engine#42434
2023-06-12 21:15:05 +00:00
godofredoc
fdfe340e16
Relands "Move clang tidy v2 build to prod."" ( flutter/engine#42714 )
...
Reverts flutter/engine#42495
2023-06-12 21:11:51 +00:00
Jonah Williams
260d931b1c
[Impeller] allowing enabling Impeller on macOS. ( flutter/engine#42639 )
...
Ship it?
2023-06-12 20:02:46 +00:00
hellohuanlin
ab09f653a6
[floating_cursor_selection] a somewhat "design doc" for floating cursor feature ( flutter/engine#42173 )
...
This PR gives an overview of how floating cursor feature works (including the new floating cursor selection gesture, and the existing floating cursor move gesture). It can serve as the missing design doc.
I put it in the engine rather than the framework, since all logics are in one place, and it's closer to the UIKit behavior that I want to cover.
Thanks @moffatman for helping me understanding it.
*List which issues are fixed by this PR. You must list at least one issue.*
https://github.com/flutter/flutter/issues/30476
*If you had to change anything in the [flutter/tests] repo, include a link to the migration guide as per the [breaking change policy].*
[C++, Objective-C, Java style guides]: https://github.com/flutter/engine/blob/main/CONTRIBUTING.md#style
2023-06-12 19:19:54 +00:00
skia-flutter-autoroll
7b572fb659
Roll ANGLE from 43ef50f389e9 to 21f16cb16333 (1 revision) ( flutter/engine#42779 )
...
43ef50f389..21f16cb163romanl@google.com Disable clang-format on ANGLE features autogen outputs
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/angle-flutter-engine
Please CC flutter-engine@google.com ,jacksongardner@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in ANGLE: http://anglebug.com/new
To file a bug in Flutter Engine: https://github.com/flutter/flutter/issues/new
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2023-06-12 19:16:47 +00:00
Callum Moffat
641003fc6d
Fix crash with CJK keyboard with emoji at end of text field ( flutter/engine#42540 )
...
The `isRTLAtPosition` method had a bug, it used `NSInteger max = [_selectionRects count]` instead of `NSInteger max = [_selectionRects count] - 1`. But I realized we don't even need the function any more, it was used in a few places in previous iterations of #36643 , but in the only place remaining, we actually already have the selection rect and don't need to search for it by position.
Btw as an explanation of the crash, I guess there is some mismatch between code point and character count somewhere. UIKit was asking for `caretRectForPosition:2` when we only had 1 character. This could have only crashed when floating cursor selection was used, but actually when switching to CJK keyboard, UIKit turns out to use `caretRectForPosition` to calculate something about the composing rect.
Fixes https://github.com/flutter/flutter/issues/128031
2023-06-12 18:13:03 +00:00
skia-flutter-autoroll
ed72d25fef
Roll Skia from 658b1d366758 to 6bdb0ef30cb6 (2 revisions) ( flutter/engine#42778 )
...
https://skia.googlesource.com/skia.git/+log/658b1d366758..6bdb0ef30cb6
2023-06-12 johnstiles@google.com Remove Wno-redundant-move setting.
2023-06-12 bungeman@google.com Allow SkSpan to be created from Container&&
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC brianosman@google.com ,herb@google.com,jacksongardner@google.com,rmistry@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2023-06-12 18:11:52 +00:00
Jonah Williams
a9b8415bfc
[Impeller] Correct attachment description for offscreen MSAA resolve. ( flutter/engine#42753 )
...
Two issues:
1. The resolve texture is created from the same impeller attachment as the msaa attachment, so the store mode was getting set to dont care instead of store.
2. the image layout for the resolve attachment should be ePresentSrcKHR, at least from following the guide at https://vulkan-tutorial.com/Multisampling
Fixing both of these locally fixes all of the weird offscreen cursed rendering.
Fixes https://github.com/flutter/flutter/issues/128600
2023-06-12 18:01:07 +00:00
Tamir Duberstein
0984c52a8f
Remove dependency on memfs ( flutter/engine#42773 )
...
See individual commits.
2023-06-12 17:14:35 +00:00
Kevin Lubick
471a8975bd
Remove unnecessary #include of SkPromiseImageTexture ( flutter/engine#42770 )
...
I was refactoring this class on the Skia side and saw Flutter #included it, but did not appear to actually use it.
This replaces an unnecessary #include with a necessary one.
[C++, Objective-C, Java style guides]: https://github.com/flutter/engine/blob/main/CONTRIBUTING.md#style
2023-06-12 16:16:48 +00:00
skia-flutter-autoroll
9ff0c742c7
Roll Skia from 951123096e55 to 0f974a0f8c10 (5 revisions) ( flutter/engine#42771 )
...
https://skia.googlesource.com/skia.git/+log/951123096e55..0f974a0f8c10
2023-06-12 kjlubick@google.com Remove remaining references to GrSlug
2023-06-12 johnstiles@google.com Add a SkSLSwitchCase cpp file.
2023-06-12 michaelludwig@google.com [skif] Cleanup comments missed in Displacement update CL
2023-06-12 cmumford@google.com [bazel] Add PathKit build rule
2023-06-12 skia-autoroll@skia-public.iam.gserviceaccount.com Roll vulkan-deps from 61c4fb9d6c0c to 2219aacad808 (1 revision)
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC brianosman@google.com ,herb@google.com,jacksongardner@google.com,rmistry@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2023-06-12 16:15:43 +00:00
Jonah Williams
6eb184bed6
[Impeller] opt all vertex shader position/uvs into highp ( flutter/engine#42746 )
...
Fixes https://github.com/flutter/flutter/issues/128605
f16 doesn't have enough resolution at large pixel values to be safely used for positions. Opt all shaders into highp. I think we might be able to get away with mediump for uv since values from 0-1 should have plenty of precisision, but we can worry about that later.
2023-06-12 16:11:47 +00:00
gaaclarke
25e060e7bc
[Impeller] added debug info to frame debuggers like AGI ( flutter/engine#42717 )
...
fixes https://github.com/flutter/flutter/issues/128629
Screenshot of the change in action:
<img width="740" alt="Screenshot 2023-06-09 at 4 30 48 PM"
src="https://github.com/flutter/engine/assets/30870216/3923c992-323b-466c-bab7-18097c6d1ee2 ">
## Pre-launch Checklist
- [x] I read the [Contributor Guide] and followed the process outlined
there for submitting PRs.
- [x] I read the [Tree Hygiene] wiki page, which explains my
responsibilities.
- [x] I read and followed the [Flutter Style Guide] and the [C++,
Objective-C, Java style guides].
- [x] I listed at least one issue that this PR fixes in the description
above.
- [ ] I added new tests to check the change I am making or feature I am
adding, or Hixie said the PR is test-exempt. See [testing the engine]
for instructions on writing and running engine tests.
- [x] I updated/added relevant documentation (doc comments with `///`).
- [x] I signed the [CLA].
- [x] All existing and new tests are passing.
If you need help, consider asking for advice on the #hackers-new channel
on [Discord].
<!-- Links -->
[Contributor Guide]:
https://github.com/flutter/flutter/wiki/Tree-hygiene#overview
[Tree Hygiene]: https://github.com/flutter/flutter/wiki/Tree-hygiene
[Flutter Style Guide]:
https://github.com/flutter/flutter/wiki/Style-guide-for-Flutter-repo
[C++, Objective-C, Java style guides]:
https://github.com/flutter/engine/blob/main/CONTRIBUTING.md#style
[testing the engine]:
https://github.com/flutter/flutter/wiki/Testing-the-engine
[CLA]: https://cla.developers.google.com/
[flutter/tests]: https://github.com/flutter/tests
[breaking change policy]:
https://github.com/flutter/flutter/wiki/Tree-hygiene#handling-breaking-changes
[Discord]: https://github.com/flutter/flutter/wiki/Chat
2023-06-12 09:11:12 -07:00
skia-flutter-autoroll
efb58b46d9
Roll Skia from 91f5ec62e30b to 951123096e55 (4 revisions) ( flutter/engine#42767 )
...
https://skia.googlesource.com/skia.git/+log/91f5ec62e30b..951123096e55
2023-06-12 drott@chromium.org [Fontations] Implement onGetTableData table access
2023-06-12 drott@chromium.org [Fontations] No .0.as_ref() boilerplate, simpler tag conversion
2023-06-12 cmumford@google.com [pathkit] Eliminate compile warnings
2023-06-12 cmumford@google.com [canvaskit] fix path to git-sync-deps
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC brianosman@google.com ,herb@google.com,jacksongardner@google.com,rmistry@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2023-06-12 15:01:35 +00:00
skia-flutter-autoroll
ae7a6b81b6
Roll Skia from c4624cc7135a to 943f70d6f836 (2 revisions) ( flutter/engine#42754 )
...
https://skia.googlesource.com/skia.git/+log/c4624cc7135a..943f70d6f836
2023-06-12 skia-autoroll@skia-public.iam.gserviceaccount.com Roll Dawn from d2e4270f67b2 to 3a77c42f230d (11 revisions)
2023-06-12 skia-autoroll@skia-public.iam.gserviceaccount.com Roll Skia Infra from 76c4b7d0e45f to c5beac3c360b (8 revisions)
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC brianosman@google.com ,herb@google.com,jacksongardner@google.com,rmistry@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2023-06-12 05:53:38 +00:00
Jim Graham
0b6d9a337c
Reland "add non-rendering operation culling to DisplayListBuilder" ( #41463 ) ( flutter/engine#42584 )
...
This reverts commit 01aeff259aa37b93304d5dea20e38302e79bf84a.
Fixes https://github.com/flutter/flutter/issues/125338
This PR should fix the blendmode/color analysis that caused failures for https://github.com/flutter/engine/pull/41463 as well as the bounds failures for inverted rectangles that caused failures for https://github.com/flutter/engine/pull/42330 (incorporating the fix from https://github.com/flutter/engine/pull/42556 ).
The description from the [previous PR](https://github.com/flutter/engine/pull/41463 ) updated with the new name of the DL property:
---------------------------------
This optimization avoids recording unnecessary render operations that will not affect the output and also eliminates the need for "draw detection" mechanisms like `DlOpSpy` and `CanvasSpy` by remembering if any non-transparent operations were included. The `DlOpSpy` unit tests were updated to check if the results from that object match the new `DisplayList::modifies_transparent_black()` method.
Fixes https://github.com/flutter/flutter/issues/125338
In addition, this change will unblock some other Issues:
- https://github.com/flutter/flutter/issues/125318
- https://github.com/flutter/flutter/issues/125403
2023-06-11 21:14:24 +00:00
Tong Mu
57758b70c8
Use ShellTest::Config struct to create Shell ( flutter/engine#42332 )
2023-06-11 10:38:17 -07:00
skia-flutter-autoroll
69c3465d88
Roll Skia from 5c9cdc4e0b61 to 2bab3a2a2953 (57 revisions) ( flutter/engine#42731 )
...
Roll Skia from 5c9cdc4e0b61 to 2bab3a2a2953 (57 revisions)
https://skia.googlesource.com/skia.git/+log/5c9cdc4e0b61..2bab3a2a2953
2023-06-10 skia-autoroll@skia-public.iam.gserviceaccount.com Roll vulkan-deps from 4a513c734ca6 to 27c917dbec91 (1 revision)
2023-06-10 skia-autoroll@skia-public.iam.gserviceaccount.com Roll vulkan-deps from 938975820ae4 to 4a513c734ca6 (3 revisions)
2023-06-10 skia-autoroll@skia-public.iam.gserviceaccount.com Roll SK Tool from 76c4b7d0e45f to aefb2afea477
2023-06-10 johnstiles@google.com Revert "Refactor SkJpegXmp into SkXmp which is more generic."
2023-06-09 johnstiles@google.com Refactor IR helper functions into reusable helper class.
2023-06-09 skia-autoroll@skia-public.iam.gserviceaccount.com Roll vulkan-deps from 701c5daafb72 to 938975820ae4 (1 revision)
2023-06-09 robertphillips@google.com Disable the BigImageTest on IntelIris655 and IntelIris540 GPUs
2023-06-09 bungeman@google.com Reland "[pdf] Use DW when it is an integer"
2023-06-09 skia-autoroll@skia-public.iam.gserviceaccount.com Manual roll Dawn from 6e25bf7674bb to d2e4270f67b2 (10 revisions)
2023-06-09 maryla@google.com Refactor SkJpegXmp into SkXmp which is more generic.
2023-06-09 kjlubick@google.com Move DDL and SkSurfaceCharacterization to include/private/chromium
2023-06-09 johnstiles@google.com Improve WGSL codegen for break-if statements.
2023-06-09 johnstiles@google.com Optimize away logical-not applied to a comparison op.
2023-06-09 michaelludwig@google.com [skif] Update DisplacementMap to use FilterResult and runtime sksl
2023-06-09 robertphillips@google.com Minor refactor of tiled image unit test
2023-06-09 kjlubick@google.com Add codec files back (for now) to public.bzl
2023-06-09 jvanverth@google.com Revert "[graphite] Use SkSpan for YUVATextureProxies and YUVABackendTextures."
2023-06-09 jvanverth@google.com Revert "Add SkSpan constructor that takes const Container&"
2023-06-09 robertphillips@google.com Add clipping to the tiled image unit test
2023-06-09 robertphillips@google.com Restructure tiled image test
2023-06-09 senorblanco@google.com Manually roll Dawn from d7b8efa431ad to 6e25bf7674bb (16 revisions)
2023-06-09 kjlubick@google.com Remove Ganesh code from SkCanvasPriv
2023-06-09 boliu@google.com Null check GrGLBuffer::Make
2023-06-09 jvanverth@google.com [graphite] Use SkSpan for YUVATextureProxies and YUVABackendTextures.
2023-06-09 jvanverth@google.com [graphite] Add TextureFromYUVAImages.
2023-06-09 kjlubick@google.com Move XfermodeInterpretation -> SkBlendModePriv
2023-06-09 kjlubick@google.com [canvaskit] Fix exports in npm
2023-06-09 kjlubick@google.com Remove Ganesh code from SkBlendMode/XferMode
2023-06-09 zzyiwei@google.com Update VkHardwareBufferTest to also fallback for ahb mem type
2023-06-09 kjlubick@google.com Add more files to public.bzl
2023-06-09 bungeman@google.com Revert "[pdf] Use DW when it is an integer"
2023-06-09 kjlubick@google.com Manually Roll Dawn from d7b8efa431ad to 6e25bf7674bb (16 revisions)
2023-06-09 drott@chromium.org [Fontations] Make metrics scale with font variations
2023-06-09 skia-autoroll@skia-public.iam.gserviceaccount.com Roll ANGLE from bc66167d304a to 8a62b4c44fc9 (11 revisions)
2023-06-09 skia-autoroll@skia-public.iam.gserviceaccount.com Roll Skia Infra from 03004105c7e9 to 76c4b7d0e45f (11 revisions)
2023-06-09 skia-autoroll@skia-public.iam.gserviceaccount.com Roll SK Tool from f24ac179ced6 to eb8ee01a4b8b
2023-06-09 skia-autoroll@skia-public.iam.gserviceaccount.com Roll vulkan-deps from dbc2d4fbc1cf to 701c5daafb72 (2 revisions)
2023-06-09 herb@google.com Improve quadratic evaluation at t
2023-06-08 bungeman@google.com [pdf] Use DW when it is an integer
2023-06-08 johnstiles@google.com Remove TArray::reserve_back.
2023-06-08 johnstiles@google.com Convert TArray::reserve_back to reserve_exact throughout Skia.
2023-06-08 johnstiles@google.com Remove unused test file.
2023-06-08 johnstiles@google.com Add support for array-equality and struct-equality expressions.
2023-06-08 jvanverth@google.com Add SkSpan constructor that takes const Container&
2023-06-08 zzyiwei@google.com Fallback to use any available memory type for AHB import
2023-06-08 robertphillips@google.com Add picture-backed images to big image unit test
...
2023-06-11 04:54:13 +00:00
ColdPaleLight
4f49c89943
[Impeller] Improved numerical stability in cubic path boundary calculations ( flutter/engine#42720 )
...
fix https://github.com/flutter/flutter/issues/128532
In this commit, we refined the method for calculating cubic path boundaries in CubicPathBoundingPopulateValues function. By adopting an alternative quadratic formula from Numerical Recipes in C (The code is ported from skia's `SkFindUnitQuadRoots`), we mitigated numerical errors, hence boosting precision and reliability in handling cubic paths.
2023-06-11 04:02:05 +00:00
Jonah Williams
2142fff539
[Impeller] Fix vulkan gradient nan issue. ( flutter/engine#42715 )
...
Fixes https://github.com/flutter/flutter/issues/128603
We were hitting a nan issue. GLSL has different relaxed precision semantics than vulkan does, and didn't hit it for some reason.
2023-06-10 17:14:29 +00:00
skia-flutter-autoroll
e95110fbd6
Roll Fuchsia Linux SDK from 1ODZdNPvGxBrgnCzf... to pd1VfyK_WEW6tu8WI... ( flutter/engine#42723 )
...
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/fuchsia-linux-sdk-flutter-engine
Please CC jacksongardner@google.com ,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2023-06-10 10:28:30 +00:00
gaaclarke
36730c35a9
[Impeller] Added helper messaging around validation usage ( flutter/engine#42708 )
...
Adds some helper messages around using validation layers.
[C++, Objective-C, Java style guides]: https://github.com/flutter/engine/blob/main/CONTRIBUTING.md#style
2023-06-09 23:07:51 +00:00
keyonghan
a24de2eaef
Fix an archive name in windows_host_engine config ( flutter/engine#42709 )
...
Use the correct archive name.
2023-06-09 22:37:59 +00:00
Dan Field
d33b2d4288
Delete WeakPtrFactory from GPUSurfaceVulkanImpeller ( flutter/engine#42710 )
...
Should fix https://github.com/flutter/flutter/issues/128618 .
This is unused - if it were used we'd have to be careful about deleting the object on the same thread it's created on.
2023-06-09 22:27:46 +00:00
gaaclarke
bf5c52d8af
[Impeller] Reland: Added a switch to turn on vulkan ( flutter/engine#42669 )
...
relands https://github.com/flutter/engine/pull/42585
## Pre-launch Checklist
- [x] I read the [Contributor Guide] and followed the process outlined
there for submitting PRs.
- [x] I read the [Tree Hygiene] wiki page, which explains my
responsibilities.
- [x] I read and followed the [Flutter Style Guide] and the [C++,
Objective-C, Java style guides].
- [ ] I listed at least one issue that this PR fixes in the description
above.
- [ ] I added new tests to check the change I am making or feature I am
adding, or Hixie said the PR is test-exempt. See [testing the engine]
for instructions on writing and running engine tests.
- [x] I updated/added relevant documentation (doc comments with `///`).
- [x] I signed the [CLA].
- [x] All existing and new tests are passing.
If you need help, consider asking for advice on the #hackers-new channel
on [Discord].
<!-- Links -->
[Contributor Guide]:
https://github.com/flutter/flutter/wiki/Tree-hygiene#overview
[Tree Hygiene]: https://github.com/flutter/flutter/wiki/Tree-hygiene
[Flutter Style Guide]:
https://github.com/flutter/flutter/wiki/Style-guide-for-Flutter-repo
[C++, Objective-C, Java style guides]:
https://github.com/flutter/engine/blob/main/CONTRIBUTING.md#style
[testing the engine]:
https://github.com/flutter/flutter/wiki/Testing-the-engine
[CLA]: https://cla.developers.google.com/
[flutter/tests]: https://github.com/flutter/tests
[breaking change policy]:
https://github.com/flutter/flutter/wiki/Tree-hygiene#handling-breaking-changes
[Discord]: https://github.com/flutter/flutter/wiki/Chat
2023-06-09 11:35:29 -07:00
Brandon DeRosier
9d1159855f
[Impeller] Add CPU implementations for all color filters ( flutter/engine#42692 )
...
Part of https://github.com/flutter/flutter/issues/127232 .
Adds a CPU implementation for ColorMatrix and the color space
conversions. Also changes the blend signature for consistency.
These will be necessary to make the mask blur fast path continue working
in the presence of color filters. In general, we can use these to
eliminate a needlessly expensive image-based color filter for the
non-image color sources.
2023-06-09 11:13:05 -07:00
Jonah Williams
71009220e0
[Impeller] add explicit VMA flush to device memory writes. ( flutter/engine#42685 )
...
According to my read of the documentation for VMA/Vulkan allocation docs, setting VK_MEMORY_PROPERTY_HOST_COHERENT_BIT means we shouldn't need to flush the memory. nevertheless, this fixes the corruption of host buffers observed in https://github.com/flutter/flutter/issues/124040
Fixes https://github.com/flutter/flutter/issues/124040
> VK_MEMORY_PROPERTY_HOST_COHERENT_BIT bit specifies that the host cache management commands [vkFlushMappedMemoryRanges](https://registry.khronos.org/vulkan/specs/1.3-extensions/man/html/vkFlushMappedMemoryRanges.html ) and [vkInvalidateMappedMemoryRanges](https://registry.khronos.org/vulkan/specs/1.3-extensions/man/html/vkInvalidateMappedMemoryRanges.html ) are not needed to flush host writes to the device or make device writes visible to the host, respectively.
ð¤·ââï¸
2023-06-09 17:23:09 +00:00
gaaclarke
2097506136
[Impeller] Makes validation layers flag work for android ( flutter/engine#42625 )
...
This builds and links in the validation layers for android. They then
can be turned on or off with a manifest field.
fixes https://github.com/flutter/flutter/issues/123788
depends on https://github.com/flutter/buildroot/pull/741
## Pre-launch Checklist
- [x] I read the [Contributor Guide] and followed the process outlined
there for submitting PRs.
- [x] I read the [Tree Hygiene] wiki page, which explains my
responsibilities.
- [ ] I read and followed the [Flutter Style Guide] and the [C++,
Objective-C, Java style guides].
- [x] I listed at least one issue that this PR fixes in the description
above.
- [ ] I added new tests to check the change I am making or feature I am
adding, or Hixie said the PR is test-exempt. See [testing the engine]
for instructions on writing and running engine tests.
- [x] I updated/added relevant documentation (doc comments with `///`).
- [x] I signed the [CLA].
- [x] All existing and new tests are passing.
If you need help, consider asking for advice on the #hackers-new channel
on [Discord].
<!-- Links -->
[Contributor Guide]:
https://github.com/flutter/flutter/wiki/Tree-hygiene#overview
[Tree Hygiene]: https://github.com/flutter/flutter/wiki/Tree-hygiene
[Flutter Style Guide]:
https://github.com/flutter/flutter/wiki/Style-guide-for-Flutter-repo
[C++, Objective-C, Java style guides]:
https://github.com/flutter/engine/blob/main/CONTRIBUTING.md#style
[testing the engine]:
https://github.com/flutter/flutter/wiki/Testing-the-engine
[CLA]: https://cla.developers.google.com/
[flutter/tests]: https://github.com/flutter/tests
[breaking change policy]:
https://github.com/flutter/flutter/wiki/Tree-hygiene#handling-breaking-changes
[Discord]: https://github.com/flutter/flutter/wiki/Chat
2023-06-09 10:22:21 -07:00
Justin McCandless
986c173094
Platform channel for predictive back ( flutter/engine#39208 )
...
Adds a platform channel method for enabling/disabling Android's predictive back feature.
2023-06-09 10:06:33 -07:00
Jonah Williams
fb0c47c6ec
[Impeller] disable buffer to texture blit for Vulkan. ( flutter/engine#42686 )
...
This fixes some f'd up ness in the images. Will need to debug this separately on Android. For now, we can just turn it off in the caps.
2023-06-09 15:53:56 +00:00
Bruno Leroux
0445311a23
[Linux] Return keyboard pressed state ( flutter/engine#42346 )
...
## Description
This PR updates the Linux engine in order to answer to keyboard pressed state queries from the framework (as implemented in https://github.com/flutter/flutter/pull/122885 ).
## Related Issue
Linux engine implementation for https://github.com/flutter/flutter/issues/87391
## Tests
Adds 2 tests.
2023-06-09 11:28:15 +00:00
skia-flutter-autoroll
17cf5bf08b
Roll Fuchsia Linux SDK from lPCv1NshK-tvjtLgC... to xqQPG9jnWgD1Dj3FL... ( flutter/engine#42694 )
...
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/fuchsia-linux-sdk-flutter-engine
Please CC jacksongardner@google.com ,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2023-06-09 08:01:09 +00:00
Mitchell Kember
b1fa42d81e
[fuchsia] Bump the target API level to 12, and pass it to fidlc ( flutter/engine#42667 )
...
This makes the GN build pass the target Fuchsia API level to fidlc.
Currently it relies on the default of HEAD, meaning all FIDL changes are
immediately visible when the SDK rolls. This was never the intention:
flutter should be targeting a specific API level.
This unblocks https://fxrev.dev/864297 which makes the fidlc --available
flag required, and which uncovered this problem.
I also copied the changes to gen_response_file.py from
https://fxrev.dev/865020 to make it forward --available to fidlc.
2023-06-09 11:56:49 +10:00
Brandon DeRosier
320a689d5e
[Impeller] Add tests for foreground blends with mask blurs ( flutter/engine#42687 )
...
Part of https://github.com/flutter/flutter/issues/127232 .
Both of these tests should be rendering as a clipped and blurred green circle. Making mask blurs interact correctly with color filters is not going to be trivial... These bugs extend beyond the filter graph itself. Want to get some goldens in to compare against.
ForegroundPorterDuffBlend:
ForegroundAdvancedBlend:
2023-06-09 01:15:07 +00:00
godofredoc
dcb764b1d3
Document the use of realm in archives. ( flutter/engine#42682 )
...
Add docs for realm propery in the archives of build configuration files.
Bug: https://github.com/flutter/flutter/issues/126121
[C++, Objective-C, Java style guides]: https://github.com/flutter/engine/blob/main/CONTRIBUTING.md#style
2023-06-09 00:43:12 +00:00
godofredoc
0f80fdedc2
Prevent double upload of benchmarks. ( flutter/engine#42683 )
...
The benchmarks have been migrated to v2 but the legacy build is uploading benchmarks even when running on staging.
Bug: https://github.com/flutter/flutter/issues/127678
[C++, Objective-C, Java style guides]: https://github.com/flutter/engine/blob/main/CONTRIBUTING.md#style
2023-06-08 23:38:03 +00:00
godofredoc
834380cdfa
Remove all the uses of master branch in the .ci.yaml file. ( flutter/engine#42679 )
...
Master branch is not the default branch in the engine anymore and we should not run any builds on it.
Bug: https://github.com/flutter/flutter/issues/90476
[C++, Objective-C, Java style guides]: https://github.com/flutter/engine/blob/main/CONTRIBUTING.md#style
2023-06-08 22:31:52 +00:00
godofredoc
b58192e6b1
Replace benchmarks with its v2 version. ( flutter/engine#42677 )
...
Benchmarks has been migrated to engine v2 and it is ready to replace the legacy version.
[C++, Objective-C, Java style guides]: https://github.com/flutter/engine/blob/main/CONTRIBUTING.md#style
2023-06-08 22:18:11 +00:00
