mirror of
https://github.com/flutter/flutter.git
synced 2026-02-20 02:29:02 +08:00
[Impeller] added debug info to frame debuggers like AGI (flutter/engine#42717)
fixes https://github.com/flutter/flutter/issues/128629 Screenshot of the change in action: <img width="740" alt="Screenshot 2023-06-09 at 4 30 48 PM" src="https://github.com/flutter/engine/assets/30870216/3923c992-323b-466c-bab7-18097c6d1ee2"> ## Pre-launch Checklist - [x] I read the [Contributor Guide] and followed the process outlined there for submitting PRs. - [x] I read the [Tree Hygiene] wiki page, which explains my responsibilities. - [x] I read and followed the [Flutter Style Guide] and the [C++, Objective-C, Java style guides]. - [x] I listed at least one issue that this PR fixes in the description above. - [ ] I added new tests to check the change I am making or feature I am adding, or Hixie said the PR is test-exempt. See [testing the engine] for instructions on writing and running engine tests. - [x] I updated/added relevant documentation (doc comments with `///`). - [x] I signed the [CLA]. - [x] All existing and new tests are passing. If you need help, consider asking for advice on the #hackers-new channel on [Discord]. <!-- Links --> [Contributor Guide]: https://github.com/flutter/flutter/wiki/Tree-hygiene#overview [Tree Hygiene]: https://github.com/flutter/flutter/wiki/Tree-hygiene [Flutter Style Guide]: https://github.com/flutter/flutter/wiki/Style-guide-for-Flutter-repo [C++, Objective-C, Java style guides]: https://github.com/flutter/engine/blob/main/CONTRIBUTING.md#style [testing the engine]: https://github.com/flutter/flutter/wiki/Testing-the-engine [CLA]: https://cla.developers.google.com/ [flutter/tests]: https://github.com/flutter/tests [breaking change policy]: https://github.com/flutter/flutter/wiki/Tree-hygiene#handling-breaking-changes [Discord]: https://github.com/flutter/flutter/wiki/Chat
This commit is contained in:
parent
efb58b46d9
commit
25e060e7bc
@ -138,12 +138,13 @@ CapabilitiesVK::GetRequiredInstanceExtensions() const {
|
||||
}
|
||||
required.push_back("VK_EXT_debug_utils");
|
||||
|
||||
if (!HasExtension("VK_EXT_validation_features")) {
|
||||
VALIDATION_LOG << "Requested validations but could not find the "
|
||||
if (HasExtension("VK_EXT_validation_features")) {
|
||||
// It's valid to not have `VK_EXT_validation_features` available. That's
|
||||
// the case when using AGI as a frame debugger.
|
||||
FML_DLOG(INFO) << "Requested validations but could not find the "
|
||||
"VK_EXT_validation_features extension.";
|
||||
return std::nullopt;
|
||||
required.push_back("VK_EXT_validation_features");
|
||||
}
|
||||
required.push_back("VK_EXT_validation_features");
|
||||
}
|
||||
|
||||
return required;
|
||||
|
||||
Loading…
x
Reference in New Issue
Block a user