DEV/flutter_flutter
1
0
Fork 0
mirror of https://github.com/flutter/flutter.git synced 2026-02-20 02:29:02 +08:00
Code Issues Packages Projects Releases Wiki Activity

Delete WeakPtrFactory from GPUSurfaceVulkanImpeller (flutter/engine#42710)

Browse Source 
Should fix https://github.com/flutter/flutter/issues/128618.

This is unused - if it were used we'd have to be careful about deleting the object on the same thread it's created on.
This commit is contained in:
Dan Field 2023-06-09 15:27:46 -07:00 committed by GitHub
parent db34cccf92
commit d33b2d4288
2 changed files with 1 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

3
engine/src/flutter/shell/gpu/gpu_surface_vulkan_impeller.cc
View File

@ -12,8 +12,7 @@
namespace flutter {
GPUSurfaceVulkanImpeller::GPUSurfaceVulkanImpeller(
std::shared_ptr<impeller::Context> context)
: weak_factory_(this) {
std::shared_ptr<impeller::Context> context) {
if (!context || !context->IsValid()) {
return;
}

1
engine/src/flutter/shell/gpu/gpu_surface_vulkan_impeller.h
View File

@ -29,7 +29,6 @@ class GPUSurfaceVulkanImpeller final : public Surface {
std::shared_ptr<impeller::Renderer> impeller_renderer_;
std::shared_ptr<impeller::AiksContext> aiks_context_;
bool is_valid_ = false;
fml::WeakPtrFactory<GPUSurfaceVulkanImpeller> weak_factory_;
// |Surface|
std::unique_ptr<SurfaceFrame> AcquireFrame(const SkISize& size) override;