From d33b2d4288cff19ee91ba4def4b262f3a372a416 Mon Sep 17 00:00:00 2001 From: Dan Field Date: Fri, 9 Jun 2023 15:27:46 -0700 Subject: [PATCH] Delete WeakPtrFactory from GPUSurfaceVulkanImpeller (flutter/engine#42710) Should fix https://github.com/flutter/flutter/issues/128618. This is unused - if it were used we'd have to be careful about deleting the object on the same thread it's created on. --- engine/src/flutter/shell/gpu/gpu_surface_vulkan_impeller.cc | 3 +-- engine/src/flutter/shell/gpu/gpu_surface_vulkan_impeller.h | 1 - 2 files changed, 1 insertion(+), 3 deletions(-) diff --git a/engine/src/flutter/shell/gpu/gpu_surface_vulkan_impeller.cc b/engine/src/flutter/shell/gpu/gpu_surface_vulkan_impeller.cc index b5848cc4c66..8381fbf26d9 100644 --- a/engine/src/flutter/shell/gpu/gpu_surface_vulkan_impeller.cc +++ b/engine/src/flutter/shell/gpu/gpu_surface_vulkan_impeller.cc @@ -12,8 +12,7 @@ namespace flutter { GPUSurfaceVulkanImpeller::GPUSurfaceVulkanImpeller( - std::shared_ptr context) - : weak_factory_(this) { + std::shared_ptr context) { if (!context || !context->IsValid()) { return; } diff --git a/engine/src/flutter/shell/gpu/gpu_surface_vulkan_impeller.h b/engine/src/flutter/shell/gpu/gpu_surface_vulkan_impeller.h index 7eca3ecd17f..19ba2b58730 100644 --- a/engine/src/flutter/shell/gpu/gpu_surface_vulkan_impeller.h +++ b/engine/src/flutter/shell/gpu/gpu_surface_vulkan_impeller.h @@ -29,7 +29,6 @@ class GPUSurfaceVulkanImpeller final : public Surface { std::shared_ptr impeller_renderer_; std::shared_ptr aiks_context_; bool is_valid_ = false; - fml::WeakPtrFactory weak_factory_; // |Surface| std::unique_ptr AcquireFrame(const SkISize& size) override;